GNU logs - #67945, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#67945: 30.0.50; Jsonrpc trouble dealing with nested synchronous requests
Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 20 Dec 2023 23:31:02 +0000
Resent-Message-ID: <handler.67945.B.170311505811272 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 67945 <at> debbugs.gnu.org, daniel@HIDDEN
MIME-Version: 1.0
From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Date: Wed, 20 Dec 2023 23:30:08 +0000
Message-ID: <CALDnm53_BRvk4iN0udHkEFaZ7Ehcup9MeVBMgnEtCXi1ZHbT3A@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000d5f06b060cf95da5"
Received-SPF: pass client-ip=2a00:1450:4864:20::230;
 envelope-from=joaotavora@HIDDEN; helo=mail-lj1-x230.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--000000000000d5f06b060cf95da5
Content-Type: text/plain; charset="UTF-8"

Hi,

I've come across a rather complicated bug in jsonrpc.el that affects a
certain class of JSON-RPC applications.  Eglot, on of the more important
`jsonrpc.el` clients (perhaps the most) is not affected, as far as I
can tell.

I already have a fix for this bug, but I am filing this report as a
reference for the commit message and to collect comments.

I was made aware of this bug by Daniel Pettersson, who is experimenting
with integrating JSONRPC in his DAP client, dape.el.  DAP's based
transport protocol isn't really JSON-RPC based but jsonrpc.el can be
accomodated to support it.

However the bug can be triggered with a sufficiently insidious and plain
JSON-RPC application.  The attached files jbug.el and jbug.py worked on
by Daniel and me demonstrate the problem.

* jbug.py is a JSON-RPC server that upon receiving the ":ping"" request
  immediately notifies the client with a ":hello"" notification.  Then
  it waits briefly 0.1 seconds before reponding to the ":ping" request
  with ":pong".

* jbug.el is a JSON-RPC client that sends a ":ping" request and waits
  for a response.  While waiting for that response, it receives the
  ":hello" notification and issues a synchronous second ":slow" request
  inside the notification handler.  Both requests are synchronous and
  performed with the Elisp function 'jsonrpc-request'

As the name implies, the server takes longer to answer the ":slow"
request (about 0.5 seconds)

Before the patch that I'm about to push, the response to the ":slow"
request is never seen by the client.  The notification handler, which
runs in a timer, simply exists non-locally.

The reasons for this are somewhat complicated, but now well understood.

Briefly, the synchronicity of 'jsonrpc-request' is achieved by having
'accept-process-output' wrapped in a try-catch block.  A continuation
handler running in a timer will eventually throw to the catch tag, so
the next form after 'jsonrpc-request' can be executed.  During the wait,
JSON-RPC notifications may come in and they often do, but in most
JSON-RPC applications (Eglot, at least), the notification handlers don't
issue what will become a nested 'jsonrpc-request'.  And even if they
were to do that, they would only run into this problem if that second
inner request ends at a later time than the first request.

In dape.el and in the jbug.el file attached, this can happen.  The
result will be that the outer catch tag of the first outer request is
"thrown to" when the response arrives, but that also unwinds the stack
of the second inner request, which leads to the application never seeing
the response that will appear only later.

In the fix I'm about to push, the solution is to record the nesting in
an Elisp structure and prevent throwing to the outer request when its
response arrives.  Rather, we record that desired continuation to run
only when the inner request has resolved fully.  The throwing will
happen only when we are back at the first outer requests's
'accept-process-output'.

This makes both responses be seen by the JSON-RPC application, albeit in
reverse order.  I think this isn't a problem in real life, because from
the jsonrpc.el programmer's perspective a blocking jsonrpc-request call
is only meant to preserve the order of execution of the forms in which
that call.  It's _not_ the relative order of multiple "concurrent"
'jsonrpc-request' calls, because this concurrency isn't really defined
in the single-threaded Elisp programming model.

I attach the two files jbug.el and jbug.py.

--000000000000d5f06b060cf95da5
Content-Type: application/octet-stream; name="jbug.py"
Content-Disposition: attachment; filename="jbug.py"
Content-Transfer-Encoding: base64
Content-ID: <f_lqeejv7w1>
X-Attachment-Id: f_lqeejv7w1

IyEvdXNyL2Jpbi9lbnYgcHl0aG9uMwojIGpidWcucHkKaW1wb3J0IHN5cwppbXBvcnQganNvbgpp
bXBvcnQgYXN5bmNpbwpmcm9tIGpzb25ycGNzZXJ2ZXIgaW1wb3J0IG1ldGhvZCwgYXN5bmNfZGlz
cGF0Y2gsIFN1Y2Nlc3MsIEVycm9yCgpAbWV0aG9kCmFzeW5jIGRlZiBwaW5nKCk6CiAgICBzZW5k
X2pzb24oeyJtZXRob2QiOiAiaGVsbG8iLCAicGFyYW1zIjoge319KQogICAgYXdhaXQgYXN5bmNp
by5zbGVlcCgwLjEpICAjIFNpbXVsYXRlIGFzeW5jaHJvbm91cyB3b3JrCiAgICByZXR1cm4gU3Vj
Y2VzcygicG9uZyIpCgpAbWV0aG9kCmFzeW5jIGRlZiBzbG93KHNlbmRlcik6CiAgICBhd2FpdCBh
c3luY2lvLnNsZWVwKDAuNSkKICAgIHJldHVybiBTdWNjZXNzKGYiUmVzcG9uc2Ugd2l0aGluIHtz
ZW5kZXJ9IikKCmRlZiBzZW5kX2pzb24oZGF0YSk6CiAgICBkYXRhID0gZGljdChkYXRhKQogICAg
ZGF0YVsianNvbnJwYyJdID0gIjIuMCIKICAgIGpzb25fZGF0YSA9IGpzb24uZHVtcHMoZGF0YSkK
ICAgIHdyaXRlX3Jlc3BvbnNlKGpzb25fZGF0YSkKCmRlZiB3cml0ZV9yZXNwb25zZShyZXNwb25z
ZV9zdHIpOgogICAgc3lzLnN0ZG91dC53cml0ZShmIkNvbnRlbnQtbGVuZ3RoOiB7bGVuKHJlc3Bv
bnNlX3N0cil9XHJcblxyXG57cmVzcG9uc2Vfc3RyfSIpCiAgICBzeXMuc3Rkb3V0LmZsdXNoKCkK
CmFzeW5jIGRlZiBoYW5kbGVfcmVxdWVzdChyZXF1ZXN0X3N0cik6CiAgICB0cnk6CiAgICAgICAg
cmVzcG9uc2Vfc3RyID0gYXdhaXQgYXN5bmNfZGlzcGF0Y2gocmVxdWVzdF9zdHIpCiAgICAgICAg
d3JpdGVfcmVzcG9uc2UocmVzcG9uc2Vfc3RyKQogICAgZXhjZXB0IEV4Y2VwdGlvbiBhcyBlOgog
ICAgICAgIGVycm9yX3Jlc3BvbnNlID0gRXJyb3Ioc3RyKGUpKQogICAgICAgIHdyaXRlX3Jlc3Bv
bnNlKHN0cihlcnJvcl9yZXNwb25zZSkpCgpkZWYgcmVhZF9tZXNzYWdlKCk6CiAgICBjb250ZW50
X2xlbmd0aCA9IHN5cy5zdGRpbi5yZWFkbGluZSgpLnN0cmlwKCkKICAgIHN5cy5zdGRpbi5yZWFk
bGluZSgpCiAgICBtZXNzYWdlX2xlbmd0aCA9IGludChjb250ZW50X2xlbmd0aC5zcGxpdCgiOiIp
WzFdLnN0cmlwKCkpCiAgICBtZXNzYWdlID0gc3lzLnN0ZGluLnJlYWQobWVzc2FnZV9sZW5ndGgp
CiAgICByZXR1cm4gbWVzc2FnZQoKYXN5bmMgZGVmIG1haW4oKToKICAgIGxvb3AgPSBhc3luY2lv
LmdldF9ldmVudF9sb29wKCkKCiAgICB3aGlsZSBUcnVlOgogICAgICAgIHRyeToKICAgICAgICAg
ICAgbWVzc2FnZSA9IGF3YWl0IGxvb3AucnVuX2luX2V4ZWN1dG9yKE5vbmUsIHJlYWRfbWVzc2Fn
ZSkKICAgICAgICAgICAgbG9vcC5jcmVhdGVfdGFzayhoYW5kbGVfcmVxdWVzdChtZXNzYWdlKSkK
ICAgICAgICBleGNlcHQgRU9GRXJyb3I6CiAgICAgICAgICAgIGJyZWFrCgppZiBfX25hbWVfXyA9
PSAiX19tYWluX18iOgogICAgYXN5bmNpby5ydW4obWFpbigpKQo=
--000000000000d5f06b060cf95da5
Content-Type: application/octet-stream; name="jbug.el"
Content-Disposition: attachment; filename="jbug.el"
Content-Transfer-Encoding: base64
Content-ID: <f_lqeejv7o0>
X-Attachment-Id: f_lqeejv7o0

Ozs7IGpidWcuZWwgLS0tIGFzZCAgICAgICAgICAgICAgICAgICAgICAgICAgIC0qLSBsZXhpY2Fs
LWJpbmRpbmc6IHQ7IC0qLQoocmVxdWlyZSAnanNvbnJwYykKCihkZWZjbGFzcyBqYnVnLXRlc3Qt
Y29ubmVjdGlvbiAoanNvbnJwYy1wcm9jZXNzLWNvbm5lY3Rpb24pICgodGhpbmdzIDppbml0Zm9y
bSBuaWwpKSkKCihjbC1kZWZtZXRob2QgamJ1Zy1oYW5kbGUtbm90aWZpY2F0aW9uIChjb25uICht
IChlcWwgaGVsbG8pKSBfKQogIChwdXNoIChqc29ucnBjLXJlcXVlc3QgY29ubiA6c2xvdyAobGlz
dCA6c2VuZGVyIChzeW1ib2wtbmFtZSBtKSApKQogICAgICAgIChzbG90LXZhbHVlIGNvbm4gJ3Ro
aW5ncykpKQoKKGRlZnZhciBqYnVnLXRlc3QtY2xpZW50IG5pbCkKCgooZGVmdW4gamJ1Zy1ldmVu
dHMgKCkKICAoaW50ZXJhY3RpdmUpCiAgKHdpdGgtY3VycmVudC1idWZmZXIKICAgICAgKGpzb25y
cGMtZXZlbnRzLWJ1ZmZlciBqYnVnLXRlc3QtY2xpZW50KQogICAgKGxldCAoKGluaGliaXQtcmVh
ZC1vbmx5IHQpKQogICAgICAoZXJhc2UtYnVmZmVyKSkKICAgIChkaXNwbGF5LWJ1ZmZlciAoY3Vy
cmVudC1idWZmZXIpKSkpCgooZGVmdW4gamJ1ZyAoKQogIChpbnRlcmFjdGl2ZSkKICAod2hlbiBq
YnVnLXRlc3QtY2xpZW50CiAgICAoanNvbnJwYy1zaHV0ZG93biBqYnVnLXRlc3QtY2xpZW50KQog
ICAgKGpidWctZXZlbnRzKSkKICAoc2V0cSBqYnVnLXRlc3QtY2xpZW50CiAgICAgICAgKG1ha2Ut
aW5zdGFuY2UgJ2pidWctdGVzdC1jb25uZWN0aW9uCiAgICAgICAgICAgICAgICAgICAgICAgOm5h
bWUgInRlc3QgY2xpZW50IgogICAgICAgICAgICAgICAgICAgICAgIDpyZXF1ZXN0LWRpc3BhdGNo
ZXIgJ2lnbm9yZQogICAgICAgICAgICAgICAgICAgICAgIDpub3RpZmljYXRpb24tZGlzcGF0Y2hl
ciAjJ2pidWctaGFuZGxlLW5vdGlmaWNhdGlvbgogICAgICAgICAgICAgICAgICAgICAgIDpwcm9j
ZXNzIChsYW1iZGEgKF9jb25uKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG1h
a2UtcHJvY2VzcwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDpuYW1lICJkdW1t
eSBzZXJ2ZXIiCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOnN0ZGVyciAoZ2V0
LWJ1ZmZlci1jcmVhdGUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAoZm9ybWF0ICIqdGVzdCBjbGllbnQgc3RkZXJyKiIpKQogICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIDpjb21tYW5kICcoInB5dGhvbjMiICJqYnVnLnB5IikKICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICA6Y29ubmVjdGlvbi10eXBlICdwaXBlCiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgOmNvZGluZyAndXRmLTgtZW1hY3MtdW5peAogICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgIDpub3F1ZXJ5IHQpKSkpKQoKKHByb2duCiAgKGpi
dWcpCiAgKGpidWctZXZlbnRzKSA7IGZvciBkZWJ1Z2dpbmcKICAocHVzaCAoanNvbnJwYy1yZXF1
ZXN0IGpidWctdGVzdC1jbGllbnQgOnBpbmcgKG1ha2UtaGFzaC10YWJsZSkpCiAgICAgICAgKHNs
b3QtdmFsdWUgamJ1Zy10ZXN0LWNsaWVudCAndGhpbmdzKSkKICAoc2F2ZS1leGN1cnNpb24KICAg
IChpbnNlcnQgKGZvcm1hdCAiXG47OyAlUyIgKHNsb3QtdmFsdWUgamJ1Zy10ZXN0LWNsaWVudCAn
dGhpbmdzKSkpKSkKOzsgKCJwb25nIiAiUmVzcG9uc2Ugd2l0aGluIGhlbGxvIikKOzsgKCJwb25n
IiAiUmVzcG9uc2Ugd2l0aGluIGhlbGxvIikKCjs7ICgicG9uZyIgIlJlc3BvbnNlIHdpdGhpbiBz
ZWNvbmRFdmVudCIpCjs7ICgicG9uZyIgIlJlc3BvbnNlIHdpdGhpbiBzZWNvbmRFdmVudCIpCjs7
ICgicG9uZyIgIlJlc3BvbnNlIHdpdGhpbiBzZWNvbmRFdmVudCIpCjs7ICgiUmVzcG9uc2Ugd2l0
aGluIHNlY29uZEV2ZW50IiAicG9uZyIpCjs7ICgiUmVzcG9uc2Ugd2l0aGluIHNlY29uZEV2ZW50
IiAicG9uZyIpCgo=
--000000000000d5f06b060cf95da5--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Subject: bug#67945: Acknowledgement (30.0.50; Jsonrpc trouble dealing with
 nested synchronous requests)
Message-ID: <handler.67945.B.170311505811272.ack <at> debbugs.gnu.org>
References: <CALDnm53_BRvk4iN0udHkEFaZ7Ehcup9MeVBMgnEtCXi1ZHbT3A@HIDDEN>
X-Gnu-PR-Message: ack 67945
X-Gnu-PR-Package: emacs
Reply-To: 67945 <at> debbugs.gnu.org
Date: Wed, 20 Dec 2023 23:31:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 67945 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
67945: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D67945
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#67945: 30.0.50; Jsonrpc trouble dealing with nested synchronous requests
Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 21 Dec 2023 01:03:02 +0000
Resent-Message-ID: <handler.67945.B67945.170312053417756 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 67945 <at> debbugs.gnu.org, daniel@HIDDEN
MIME-Version: 1.0
References: <CALDnm53_BRvk4iN0udHkEFaZ7Ehcup9MeVBMgnEtCXi1ZHbT3A@HIDDEN>
In-Reply-To: <CALDnm53_BRvk4iN0udHkEFaZ7Ehcup9MeVBMgnEtCXi1ZHbT3A@HIDDEN>
From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Date: Thu, 21 Dec 2023 01:01:44 +0000
Message-ID: <CALDnm517x1vGm_di6VxFDfz1AkCcL=YEQGr6TvX5jTTWu7-3KA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Wed, Dec 20, 2023 at 11:31=E2=80=AFPM Jo=C3=A3o T=C3=A1vora <joaotavora@=
gmail.com> wrote:
>
> Hi,
>
> I've come across a rather complicated bug in jsonrpc.el that affects a
> certain class of JSON-RPC applications.  Eglot, on of the more important
> `jsonrpc.el` clients (perhaps the most) is not affected, as far as I
> can tell.
>
> I already have a fix for this bug, but I am filing this report as a
> reference for the commit message and to collect comments.

I've now pushed the fix to jsonrpc.el and tagged version 1.0.21
of the jsonrpc package.

I'd like to push some tests using the `jbug.py` test server
attached earlier.  Is here a good place to store such helper scripts
in our test subtree?

Jo=C3=A3o

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#67945: 30.0.50; Jsonrpc trouble dealing with nested synchronous requests
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 21 Dec 2023 07:52:02 +0000
Resent-Message-ID: <handler.67945.B67945.17031451116873 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Cc: 67945 <at> debbugs.gnu.org, daniel@HIDDEN
Date: Thu, 21 Dec 2023 09:51:20 +0200
Message-Id: <834jgcgfif.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <CALDnm517x1vGm_di6VxFDfz1AkCcL=YEQGr6TvX5jTTWu7-3KA@HIDDEN>
 (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Thu, 21 Dec 2023 01:01:44
 +0000)
References: <CALDnm53_BRvk4iN0udHkEFaZ7Ehcup9MeVBMgnEtCXi1ZHbT3A@HIDDEN>
 <CALDnm517x1vGm_di6VxFDfz1AkCcL=YEQGr6TvX5jTTWu7-3KA@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: João Távora <joaotavora@HIDDEN>
> Date: Thu, 21 Dec 2023 01:01:44 +0000
> 
> I'd like to push some tests using the `jbug.py` test server
> attached earlier.  Is here a good place to store such helper scripts
> in our test subtree?

In the FOO-resources subdirectory (where FOO is the name of the test)?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#67945: 30.0.50; Jsonrpc trouble dealing with nested synchronous requests
Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 21 Dec 2023 09:54:02 +0000
Resent-Message-ID: <handler.67945.B67945.17031523981469 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 67945
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 67945 <at> debbugs.gnu.org, daniel@HIDDEN
Received: via spool by 67945-submit <at> debbugs.gnu.org id=B67945.17031523981469
          (code B ref 67945); Thu, 21 Dec 2023 09:54:02 +0000
Received: (at 67945) by debbugs.gnu.org; 21 Dec 2023 09:53:18 +0000
Received: from localhost ([127.0.0.1]:42441 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rGFjy-0000Nd-2E
	for submit <at> debbugs.gnu.org; Thu, 21 Dec 2023 04:53:18 -0500
Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:60640)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joaotavora@HIDDEN>) id 1rGFjs-0000NL-Hc
 for 67945 <at> debbugs.gnu.org; Thu, 21 Dec 2023 04:53:16 -0500
Received: by mail-lj1-x229.google.com with SMTP id
 38308e7fff4ca-2cc55698c81so6448611fa.0
 for <67945 <at> debbugs.gnu.org>; Thu, 21 Dec 2023 01:53:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1703152383; x=1703757183; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:from:to:cc:subject:date
 :message-id:reply-to;
 bh=UYZsRS3tkGBdYx/5HWSZ6oS6HInzTUxQEFZBQBTvJbM=;
 b=KqZbsRDZ8jmWDr7yAqO4kqMXiv6B2NfB07c3aNJDyA8DsGeTiRRuSndbyk3B14y/Rj
 76ljB2ks+ZMrTug2+0+DgQWMrDc8c0gqLgf9WCY4zsQW7AI3zoR8ew+TS5mp2HEKdZZj
 V/ImcRQu21U7EauDeUTOtta85AWMbKKF4VAmk1VRtEMT0UI1nXqOZ3I7pmzqEkkQp7yr
 Z9P86n/5pUDL5o5dW81wgtrdqR8gHV0KlYEA8HZZishFupW2N6jUqtkaq+bKwcvwTv+Z
 Ih9ESzO5ggGUD5366cS45KR4E0ms1q5G0VMo2YHXbPS/PiTMNFlyk9qcZ/XO59gOn4UF
 nKEA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1703152383; x=1703757183;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=UYZsRS3tkGBdYx/5HWSZ6oS6HInzTUxQEFZBQBTvJbM=;
 b=PP84gehB5aumVLoAi1Vx6ch+MkKq6Xxy5bUX0HL5wksvMOxfBBTGgUQmUTIG1UydY5
 NIp4u7gAmooFYv5wD1wpa7AA9QIO5USrnEnd7jhYom2+b1GUuutgjy+p31W/k2GW28eD
 KcoYLxb3LHRkxNDASrgQa6WQNMVslmHZ82YLQW8VBNCQV+a7uFGLkyz3RqRD4ZO287WL
 Oca2Ed9n0+NyMl/c3T2r8uL6b3+MlcWRpFBaret44Vop952nsoVtFvkVP8R5v8Ektdj6
 dYgm3bOfQ6314SamfD1iHG7fPi9TZa8kXHQL/oqyQmP0qu3gR7FC9AqcLFVZ8fV2uTEE
 brlw==
X-Gm-Message-State: AOJu0YyoaXZcgj7LJHbNGx2mKmV14XSL0j+DOc0r1KMu0ZKUay3ko4Qo
 IElLiuoIElCS5EugPRw+/Xs5OYRADlYLbzd2KEyUabM2
X-Google-Smtp-Source: AGHT+IGiXOtKi/wZx2lFWvz7f6ce3NkPP/0NhdI7I4bEbL6dp9r9z1OaRE7AF0iD6hjvsDG8dlVNxkvAvhEoPXLZgIo=
X-Received: by 2002:a05:651c:207:b0:2cc:7127:ebb1 with SMTP id
 y7-20020a05651c020700b002cc7127ebb1mr3437392ljn.81.1703152382671; Thu, 21 Dec
 2023 01:53:02 -0800 (PST)
MIME-Version: 1.0
References: <CALDnm53_BRvk4iN0udHkEFaZ7Ehcup9MeVBMgnEtCXi1ZHbT3A@HIDDEN>
 <CALDnm517x1vGm_di6VxFDfz1AkCcL=YEQGr6TvX5jTTWu7-3KA@HIDDEN>
 <834jgcgfif.fsf@HIDDEN>
In-Reply-To: <834jgcgfif.fsf@HIDDEN>
From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Date: Thu, 21 Dec 2023 09:52:51 +0000
Message-ID: <CALDnm50V292dTBa77tC5YuobqxDnce-r-xUjimh_YaM2NMjRJw@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Thu, Dec 21, 2023 at 7:51=E2=80=AFAM Eli Zaretskii <eliz@HIDDEN> wrote:
>
> > From: Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN>
> > Date: Thu, 21 Dec 2023 01:01:44 +0000
> >
> > I'd like to push some tests using the `jbug.py` test server
> > attached earlier.  Is here a good place to store such helper scripts
> > in our test subtree?
>
> In the FOO-resources subdirectory (where FOO is the name of the test)?

Yes, that was my idea too.  Thanks for confirming.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#67945: 30.0.50; Jsonrpc trouble dealing with nested synchronous requests
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 02 Feb 2024 07:42:02 +0000
Resent-Message-ID: <handler.67945.B67945.17068596838565 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 67945
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= <joaotavora@HIDDEN>
Cc: 67945 <at> debbugs.gnu.org, daniel@HIDDEN
Received: via spool by 67945-submit <at> debbugs.gnu.org id=B67945.17068596838565
          (code B ref 67945); Fri, 02 Feb 2024 07:42:02 +0000
Received: (at 67945) by debbugs.gnu.org; 2 Feb 2024 07:41:23 +0000
Received: from localhost ([127.0.0.1]:43597 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rVoAs-0002E3-Dj
	for submit <at> debbugs.gnu.org; Fri, 02 Feb 2024 02:41:23 -0500
Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:48264)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1rVoAm-0002Dd-Gy
 for 67945 <at> debbugs.gnu.org; Fri, 02 Feb 2024 02:41:20 -0500
Received: by mail-ed1-x52c.google.com with SMTP id
 4fb4d7f45d1cf-55fd5f67f03so1442114a12.0
 for <67945 <at> debbugs.gnu.org>; Thu, 01 Feb 2024 23:41:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1706859660; x=1707464460; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=uTY8Wqnb43HgoiJVdWNAnJX3H1f2UPrj4WQsALGJEd0=;
 b=bvSTClcpxhhmFiFKZxMVeXQg20mAIJIP0vZgvfqIkPVw9ZsrIONxTjaA2FUCxGCvdD
 wZ828eEKqlCwhknAoMvID/cLD/Pjz0yBqi63uobB5CAhS+5e5MPOcrVhxIMxAT8QlhcB
 Gj44902QSD1X9TRK/HeKG0ShydyBNiEZf97H7ciUZfSYhajcghT9PajQ4gGWeeUvHd48
 xEitbXLnnOMRsrLTJUPNsPb+QO8Bfr4k4DeFNblW5BBMABCY6H/cD7C2y42878ERl7m7
 YzoR1vskWfStqyt6WztfX3/BSy44tM+bZxCDva+wcWmJfPO76TbRmYublNyE6kFacMZy
 6S0A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1706859660; x=1707464460;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=uTY8Wqnb43HgoiJVdWNAnJX3H1f2UPrj4WQsALGJEd0=;
 b=VBbcVOlNsRmKMQ3lR6JDJL4Zph4zTTJ7cQTXSIchOQoO3SBECHl1KDirO5BfF5nD6D
 vXYzEdYomzzryRqmYs2BHMLy4CuKM3KQlbTs5lgmVLg/mnyXelFM4cmLIjODrxzNIaoL
 zrQe4Y+w7LewNpCQZBQX1sja71ECDZFVhiy5qBRrg4oFMNftldfoVDCS9nOPE1mzMZFY
 +Xx/28EdU+vrnsLRw0v0IA1yIEUUdFqcnV2SC/VWuJgYjAf6DML/Euve3jco+a8OE4gV
 BgTqOM+HpX35akKAyUsgIH1B1xkmkc1R78UYE5f2YYi2vzyVtZzzTmBGHmf4qUYVJwap
 VxGA==
X-Gm-Message-State: AOJu0YxMTL6sysyqPI7ZoK8wsTNVNReU22OcrmrSLlQ0+YixLzljRsk9
 TTJqk+GyM19HiZMLF5DziAnUTOIdRWfRXWh7vN26SjQgh2s6b8gNABzjT4CfWHlLYd2eL294ZMk
 wc6Xmz3X7jtWT7bLW8ClMAQiHtoI=
X-Google-Smtp-Source: AGHT+IHM1ipedVwy3Tk4fXFO7ELmKcJ7CcKaclSoWhu+bn2ceOlHvqkzvBZvYJ1dzg2jGKp9mfjAltDaYRjSSDFE9Q8=
X-Received: by 2002:aa7:db5a:0:b0:55f:370d:a9b1 with SMTP id
 n26-20020aa7db5a000000b0055f370da9b1mr3300931edt.1.1706859660159; Thu, 01 Feb
 2024 23:41:00 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 1 Feb 2024 23:40:59 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <CALDnm517x1vGm_di6VxFDfz1AkCcL=YEQGr6TvX5jTTWu7-3KA@HIDDEN> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Thu, 21 Dec 2023 01:01:44 +0000")
References: <CALDnm53_BRvk4iN0udHkEFaZ7Ehcup9MeVBMgnEtCXi1ZHbT3A@HIDDEN>
 <CALDnm517x1vGm_di6VxFDfz1AkCcL=YEQGr6TvX5jTTWu7-3KA@HIDDEN>
MIME-Version: 1.0
Date: Thu, 1 Feb 2024 23:40:59 -0800
Message-ID: <CADwFkmmsx=p==psPci5HfTHSSHCzRZXHBOV+U0cGO0qG7Y-bxQ@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes:

> On Wed, Dec 20, 2023 at 11:31=E2=80=AFPM Jo=C3=A3o T=C3=A1vora <joaotavor=
a@HIDDEN> wrote:
>>
>> Hi,
>>
>> I've come across a rather complicated bug in jsonrpc.el that affects a
>> certain class of JSON-RPC applications.  Eglot, on of the more important
>> `jsonrpc.el` clients (perhaps the most) is not affected, as far as I
>> can tell.
>>
>> I already have a fix for this bug, but I am filing this report as a
>> reference for the commit message and to collect comments.
>
> I've now pushed the fix to jsonrpc.el and tagged version 1.0.21
> of the jsonrpc package.
>
> I'd like to push some tests using the `jbug.py` test server
> attached earlier.  Is here a good place to store such helper scripts
> in our test subtree?
>
> Jo=C3=A3o

Thanks, should this bug be closed or is there more to do here?

Last modified: Fri, 2 Feb 2024 07:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.