Received: (at 68244) by debbugs.gnu.org; 23 Feb 2024 12:25:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 23 07:25:17 2024 Received: from localhost ([127.0.0.1]:35478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rdUc8-0000nz-Ia for submit <at> debbugs.gnu.org; Fri, 23 Feb 2024 07:25:17 -0500 Received: from mail-lj1-f182.google.com ([209.85.208.182]:47484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rdUVO-0000WX-8e for 68244 <at> debbugs.gnu.org; Fri, 23 Feb 2024 07:18:19 -0500 Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2d2505352e6so8135951fa.3 for <68244 <at> debbugs.gnu.org>; Fri, 23 Feb 2024 04:17:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708690609; x=1709295409; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=Ux5Jk4tV0YLIdVgdmkqLGNdo+A2Hg/7Ex2F1KS2m8wU=; b=biERaUZhJJpuph38Y9cvmjvigzBvmD7sWwFCZQcWsW7cg97gq2nFRkKEWjlal3/jNj S55/8YwRP6x065zsGUY2miRHf6YxnQWaLAcVqIPlhLh7u+Kxg8UiEKULh0kqNl3E5Hw1 52yP/WWIKeePg+fNQ1Z3UDmUwZUCsAJnRtl7L4390L5SDjzYv/ZfyUf44ddqBKT/fBbC /LvXySobCmedVsJIPNj+OE01nZZZXSrkVsPyyF3WFgQGdUnhgOSi6MiaIwa+iqBgdMdG KoAbDbfLjwrFpMsWOJHUW6UZDr5hzx9loPS1uxqRAxcZZE2SHDGkH/N/GI64AR23RH8n zL5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708690609; x=1709295409; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ux5Jk4tV0YLIdVgdmkqLGNdo+A2Hg/7Ex2F1KS2m8wU=; b=BMP2pFNgYbtaRkAw/DYDKBiirqbNxrMF/Igl4lbZZ3fzLp5/kix8wHEDoqVkANjPbp StsPrUKr7nsGzCUbS7nQ0snGUSzJwE4QCh8a72Rn/SLhA6/m9gcBvbC4jGQlFOSEBBR8 PSsa5X/lXuleQBg8rSNx537tIgrROR96BE6ptpDzFa8Ql6JAooTxPDagJe9Snk9/Ggpn HVtH4+1SvGQ+IYyT8Ud/4Znk6zlQNJebUrYILn8zCqXe7MieacL8NmtXnwo5hcBxx0HF /yMz8TBB0Pvb2U1gvvqduT5XplEUT/rHeOq5fHaZNCnPyzZjQFrNYY/KjS2BWJ3ISsXc Mwcw== X-Forwarded-Encrypted: i=1; AJvYcCUb09cTApapuCVxY+gA+18/LeTGrFSRjrMaqr1CwcSrz7Hx+8LCkaWp8l8uvTFAsTz/zKYcnRay08M+INeCJujEOr9uOAs= X-Gm-Message-State: AOJu0YwiQauzr6Mf4CiNtzzPxWeI2EULmofPrwFzLsBqYWAFc7nIsfiv IxRA6vJNmkLZicvbX+KxX/WRMnT5JuDn/4Bb8EF7jJxWx2KWwWzy X-Google-Smtp-Source: AGHT+IEh0dpRoJmTN55xAtzuAmoRktgVM0rNLPbwI7iRRURynkhYJelhdK0U76PgoX1mIIP03iSRmA== X-Received: by 2002:a2e:9193:0:b0:2d2:3599:2e25 with SMTP id f19-20020a2e9193000000b002d235992e25mr1106454ljg.46.1708690608493; Fri, 23 Feb 2024 04:16:48 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id y19-20020a2e95d3000000b002d14817efd3sm2549775ljh.106.2024.02.23.04.16.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Feb 2024 04:16:47 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <86r0h6m0rh.fsf@HIDDEN> Date: Fri, 23 Feb 2024 13:16:46 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <2E0CDF51-5871-4F53-91B0-33115E30B1F2@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> <E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN> <jwvttmjousn.fsf-monnier+emacs@HIDDEN> <6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN> <jwvr0hmq21z.fsf-monnier+emacs@HIDDEN> <E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN> <m2le7o68fw.fsf@HIDDEN> <13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN> <jwv4jecbktx.fsf-monnier+emacs@HIDDEN> <5C9DFD74-B166-444E-BFDC-D022826098C8@HIDDEN> <jwvh6ib6vwm.fsf-monnier+emacs@HIDDEN> <D1E7E6F2-DD5F-466F-BF5D-649A7E73B328@HIDDEN> <8F240949-B24F-4538-8ED1-7153F10AB5EC@HIDDEN> <1BD12E80-6BC0-4B17-A0D8-8C47414C8911@HIDDEN> <86sf1nnslp.fsf@HIDDEN> <886A589C-5139-4FC9-8B59-636A9D6DFBD4@HIDDEN> <86frxnnjq1.fsf@HIDDEN> <86r0h6m0rh.fsf@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN>, Andrea Corallo <acorallo@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: gerd.moellmann@HIDDEN, dmitry@HIDDEN, 68244 <at> debbugs.gnu.org, monnier@HIDDEN, stefankangas@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 21 feb. 2024 kl. 13.59 skrev Eli Zaretskii <eliz@HIDDEN>: > I've built the branch on this platform and configuration: >=20 > In GNU Emacs 30.0.50 (build 1, i686-pc-mingw32) of 2024-02-21 built = on > [...] --with-wide-int 21 feb. 2024 kl. 21.13 skrev Andrea Corallo <acorallo@HIDDEN>: > I've built as well the branch on aarch64-unknown-linux-gnu Eli and Andrea, thank you very much! I think this spans a sufficient = space of relevant builds (in particular since both you and I regularly = commit changes with more platform-dependent stuff). Now pushed to master, so that it can get some real testing.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 21 Feb 2024 20:13:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 21 15:13:33 2024 Received: from localhost ([127.0.0.1]:38650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rcsyC-0005O4-Gh for submit <at> debbugs.gnu.org; Wed, 21 Feb 2024 15:13:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <acorallo@HIDDEN>) id 1rcsyA-0005Ne-CQ for 68244 <at> debbugs.gnu.org; Wed, 21 Feb 2024 15:13:31 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <acorallo@HIDDEN>) id 1rcsxh-00064C-9l; Wed, 21 Feb 2024 15:13:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=lrG5JYYi9V2uEtuavTcb/P+Eo4j0m84vxPzFjMYy78s=; b=rD++ZZqF68uOqYLfxFoF k5nv5dE0IK/jdF1Od1bUqmE2KGGVjNVuvp7MGD/Et+zXR8UGEL7OXjxHnJe8s9N0+3Qrw8xwIWKrJ bqFpz2UVkASsymm0HaaFiUsnFpUkAgiUJtrEp1dd0VeD+9ZoTpqkp9c+PIjgfofJCmz8w1fKXnqg4 3rXLSd9I2mziKGuyN9w7FmY+npYfhCB3sslubsOnhyMuL+b7aHgSXgPwZbix6GY4RbHUoTp+e+nZ4 nwgI+ACmi+q+QtQaH70XU+YLFIOqzodOWTJniFmM54MdA3DsealpeeDIk/UV7b1ZepVK09WUOVYvH U3fdxa+sNAmcqA==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from <acorallo@HIDDEN>) id 1rcsxg-0003nq-QL; Wed, 21 Feb 2024 15:13:00 -0500 From: Andrea Corallo <acorallo@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#68244: hash-table improvements In-Reply-To: <86r0h6m0rh.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 21 Feb 2024 14:59:14 +0200") References: <170438379722.3921.9312235725296561206@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> <E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN> <jwvttmjousn.fsf-monnier+emacs@HIDDEN> <6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN> <jwvr0hmq21z.fsf-monnier+emacs@HIDDEN> <E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN> <m2le7o68fw.fsf@HIDDEN> <13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN> <jwv4jecbktx.fsf-monnier+emacs@HIDDEN> <5C9DFD74-B166-444E-BFDC-D022826098C8@HIDDEN> <jwvh6ib6vwm.fsf-monnier+emacs@HIDDEN> <D1E7E6F2-DD5F-466F-BF5D-649A7E73B328@HIDDEN> <8F240949-B24F-4538-8ED1-7153F10AB5EC@HIDDEN> <1BD12E80-6BC0-4B17-A0D8-8C47414C8911@HIDDEN> <86sf1nnslp.fsf@HIDDEN> <886A589C-5139-4FC9-8B59-636A9D6DFBD4@HIDDEN> <86frxnnjq1.fsf@HIDDEN> <86r0h6m0rh.fsf@HIDDEN> Date: Wed, 21 Feb 2024 15:13:00 -0500 Message-ID: <yp1r0h58tkj.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 68244 Cc: mattias.engdegard@HIDDEN, gerd.moellmann@HIDDEN, dmitry@HIDDEN, monnier@HIDDEN, 68244 <at> debbugs.gnu.org, stefankangas@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.2 (-----) Eli Zaretskii <eliz@HIDDEN> writes: >> Cc: gerd.moellmann@HIDDEN, dmitry@HIDDEN, 68244 <at> debbugs.gnu.org, >> monnier@HIDDEN, stefankangas@HIDDEN >> Date: Tue, 20 Feb 2024 19:12:06 +0200 >> From: Eli Zaretskii <eliz@HIDDEN> >> >> Please ask on emacs-devel that the branch be tried on platforms you >> didn't try it, and let's please wait for a few days to give people >> chance to do that and report back. > > I've built the branch on this platform and configuration: > > In GNU Emacs 30.0.50 (build 1, i686-pc-mingw32) of 2024-02-21 built on > ELIZ-PC > Windowing system distributor 'Microsoft Corp.', version 10.0.22631 > System Description: Microsoft Windows 10 Enterprise (v10.0.2009.22631.3155) > > Configured using: > 'configure -C --prefix=/d/usr --with-wide-int > --without-native-compilation --enable-checking=yes,glyphs 'CFLAGS=-O0 > -gdwarf-4 -g3'' > > and it builds cleanly and passes a few tests related to obarrays. Hi all, I've built as well the branch on aarch64-unknown-linux-gnu configured as: 'configure --with-native-compilation --with-x-toolkit=no --prefix=/home/andcor03 --with-xpm=ifavailable --with-jpeg=ifavailable --with-gif=ifavailable --with-tiff=ifavailable --with-gnutls=ifavailable' I can't see regressions for make check over 20997aa2072. Bests Andrea
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 21 Feb 2024 13:00:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 21 08:00:07 2024 Received: from localhost ([127.0.0.1]:48022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rcmCk-0007di-9M for submit <at> debbugs.gnu.org; Wed, 21 Feb 2024 08:00:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rcmCT-0007cK-Tk for 68244 <at> debbugs.gnu.org; Wed, 21 Feb 2024 08:00:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rcmC1-0002q2-Ka; Wed, 21 Feb 2024 07:59:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CJWGi5K6pKSL4svVI+0R6NCsh6wXSZkis3rlVYH2s8I=; b=dWl/2pvNYOZc xEcJjRT6ruifdi78DFlAbhcr6EKSx5fm/dsIC0bbO8pjwgS0/PHXHtKacjL18VPkLElj4gf3iYkTU jdlH7RyJgzqtZkse2Sw5MCzgGNhY9aYPCRSpog8Sv2MQ48ZlJ6f/TtXD/eD/SKDcfd7d8TT8qmY9t FFGlRySb+YPvEBiy4etSTLiElLxS3srTuB4F46fLzI9nn9vieYkwIbZ6cZNV+/7gWM8Uyu5xOkvIa Z1rXM3U6fkZQxAb5MD9VmLIsPTJ0fT4qB38/ijgirEeFMYW2lCEKJfc6D52+2PdYNsWfLGHtleLAf lCW7M/B5IsPs0H68gyTMtA==; Date: Wed, 21 Feb 2024 14:59:14 +0200 Message-Id: <86r0h6m0rh.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: mattias.engdegard@HIDDEN In-Reply-To: <86frxnnjq1.fsf@HIDDEN> (message from Eli Zaretskii on Tue, 20 Feb 2024 19:12:06 +0200) Subject: Re: bug#68244: hash-table improvements References: <170438379722.3921.9312235725296561206@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> <E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN> <jwvttmjousn.fsf-monnier+emacs@HIDDEN> <6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN> <jwvr0hmq21z.fsf-monnier+emacs@HIDDEN> <E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN> <m2le7o68fw.fsf@HIDDEN> <13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN> <jwv4jecbktx.fsf-monnier+emacs@HIDDEN> <5C9DFD74-B166-444E-BFDC-D022826098C8@HIDDEN> <jwvh6ib6vwm.fsf-monnier+emacs@HIDDEN> <D1E7E6F2-DD5F-466F-BF5D-649A7E73B328@HIDDEN> <8F240949-B24F-4538-8ED1-7153F10AB5EC@HIDDEN> <1BD12E80-6BC0-4B17-A0D8-8C47414C8911@HIDDEN> <86sf1nnslp.fsf@HIDDEN> <886A589C-5139-4FC9-8B59-636A9D6DFBD4@HIDDEN> <86frxnnjq1.fsf@HIDDEN> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 68244 Cc: gerd.moellmann@HIDDEN, dmitry@HIDDEN, 68244 <at> debbugs.gnu.org, monnier@HIDDEN, stefankangas@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.2 (-----) > Cc: gerd.moellmann@HIDDEN, dmitry@HIDDEN, 68244 <at> debbugs.gnu.org, > monnier@HIDDEN, stefankangas@HIDDEN > Date: Tue, 20 Feb 2024 19:12:06 +0200 > From: Eli Zaretskii <eliz@HIDDEN> > > Please ask on emacs-devel that the branch be tried on platforms you > didn't try it, and let's please wait for a few days to give people > chance to do that and report back. I've built the branch on this platform and configuration: In GNU Emacs 30.0.50 (build 1, i686-pc-mingw32) of 2024-02-21 built on ELIZ-PC Windowing system distributor 'Microsoft Corp.', version 10.0.22631 System Description: Microsoft Windows 10 Enterprise (v10.0.2009.22631.3155) Configured using: 'configure -C --prefix=/d/usr --with-wide-int --without-native-compilation --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3'' and it builds cleanly and passes a few tests related to obarrays.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 20 Feb 2024 17:12:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 20 12:12:39 2024 Received: from localhost ([127.0.0.1]:46447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rcTfb-0006zq-1a for submit <at> debbugs.gnu.org; Tue, 20 Feb 2024 12:12:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rcTfZ-0006ze-85 for 68244 <at> debbugs.gnu.org; Tue, 20 Feb 2024 12:12:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rcTf7-0008Jb-Qt; Tue, 20 Feb 2024 12:12:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=e8bdneGZGITg4OctZ0zpRjJAgokHyJ6oaXrEE2sl5rU=; b=ESoRBnuWfwvCtquSvlNJ 4+tCN9D/uKcJ3B03eQgWISkp0eUhDesN42J8Hl6HRWpTQaG9oyXGmeR11izhdQeenICO91nfX5OyQ nSVMr9Ze4ABUBwCTBXJBrZGpJNt73FcYrEt4j6NCYRnsV58LSjp5rLutfVc44lo0C+jyt3N0hcVwd be4il6wJ53a1NFju2WWVEN0EqjcYQpMXGBrCO8RVTGSbJnTD+/Db3CJ1tf/y1bQdd/VujH2TBjaAs 98E2ktt4pDzsvakYMBBJ/UQumUs/lnJ8b7veEb1W9vrKc3DMlpzk+QrQNiLOagBMIL3GsiyPS16HN BNhA4TQ9vcWhrA==; Date: Tue, 20 Feb 2024 19:12:06 +0200 Message-Id: <86frxnnjq1.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <886A589C-5139-4FC9-8B59-636A9D6DFBD4@HIDDEN> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Tue, 20 Feb 2024 17:11:23 +0100) Subject: Re: bug#68244: hash-table improvements References: <170438379722.3921.9312235725296561206@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> <E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN> <jwvttmjousn.fsf-monnier+emacs@HIDDEN> <6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN> <jwvr0hmq21z.fsf-monnier+emacs@HIDDEN> <E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN> <m2le7o68fw.fsf@HIDDEN> <13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN> <jwv4jecbktx.fsf-monnier+emacs@HIDDEN> <5C9DFD74-B166-444E-BFDC-D022826098C8@HIDDEN> <jwvh6ib6vwm.fsf-monnier+emacs@HIDDEN> <D1E7E6F2-DD5F-466F-BF5D-649A7E73B328@HIDDEN> <8F240949-B24F-4538-8ED1-7153F10AB5EC@HIDDEN> <1BD12E80-6BC0-4B17-A0D8-8C47414C8911@HIDDEN> <86sf1nnslp.fsf@HIDDEN> <886A589C-5139-4FC9-8B59-636A9D6DFBD4@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 68244 Cc: gerd.moellmann@HIDDEN, dmitry@HIDDEN, 68244 <at> debbugs.gnu.org, monnier@HIDDEN, stefankangas@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.2 (-----) > From: Mattias Engdegård <mattias.engdegard@HIDDEN> > Date: Tue, 20 Feb 2024 17:11:23 +0100 > Cc: monnier@HIDDEN, > gerd.moellmann@HIDDEN, > dmitry@HIDDEN, > 68244 <at> debbugs.gnu.org, > stefankangas@HIDDEN > > 20 feb. 2024 kl. 15.00 skrev Eli Zaretskii <eliz@HIDDEN>: > > > How many different platforms and configurations tried to build and use > > the branch? For such a change, I think I'd like to see all the major > > platforms be able to compile and run it, before we land it. > > In this case the risk for platform-specific bugs is not high (no system-dependent code nor, from what I can tell, any architecture or configuration-dependent code(*)). Famous last words ;-) > Of course accidents can always happen. If someone would like to try building the scratch/obarray branch on a non-64-bit machine then I'd be very grateful. Please ask on emacs-devel that the branch be tried on platforms you didn't try it, and let's please wait for a few days to give people chance to do that and report back. Thanks.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 20 Feb 2024 16:12:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 20 11:12:56 2024 Received: from localhost ([127.0.0.1]:46409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rcSjo-0005VG-Dz for submit <at> debbugs.gnu.org; Tue, 20 Feb 2024 11:12:56 -0500 Received: from mail-lf1-f45.google.com ([209.85.167.45]:51473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rcSjl-0005V1-6c for 68244 <at> debbugs.gnu.org; Tue, 20 Feb 2024 11:12:54 -0500 Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5129e5b8cecso4524727e87.3 for <68244 <at> debbugs.gnu.org>; Tue, 20 Feb 2024 08:12:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708445485; x=1709050285; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=2+52r9H0FK6aWz8dNwdKlhEwu3TNwoDMl2jKxV1KCAg=; b=nJ86rvJZ+7GLwGDElef8fA36wYy957qtZubWLmRWtY9gSPRnPpcUFfTj14zOUs3qiL VPp1Y90nzenytDqWAr4Fr8ifv57yxPl2LcJQALheszeofBIH4DaKhY9IOR5iNm2k4YdP x+7MmkNKP1CR1Kikwnz19mH9I1gnDbCLi+Se6Bntq6t98Y7rgqL4xAKVyQl00tpKRJ8d mmKFsTwSXFWDZdTZyMQr5NTqY3EURCmmWXG8YZCerwBF8KIiI2kzCgjV6TD4c41grpVX eTbYcqnoyAebEUDkpK/39mwMqK8nxA+VBl6oHqrsGTdSlrXKpDF2q83MWRBjUoQojkyD JYUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708445485; x=1709050285; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2+52r9H0FK6aWz8dNwdKlhEwu3TNwoDMl2jKxV1KCAg=; b=VQ+3ljjoPiKPekGh7Ux2phMUeOz+jPHPpoVV7VF40iacIU6GxNLV0loXulFFsNNH8D +mbvuhxGqUmGzY775eJw/UxHFflS036dGGoXXs+jUKi3d670HNTINkPtIXC5Ok+BMaEt rH+oC9QaQL9q7ZpmWOM/mhX8WqSjtx1iQvqolv7xNoz2LL5tgjEhBQvOOv8DTLfdX1dp TMM8J9ak0NoinxhmDumm5h93D+YY6XnZNlnKkR5ehYfPDTApHPYXBCG+zpizmG05KQ/z /sxop9FsvSXpvEn4bh+j2kA5B8S4QasJKbwJBPmuomWipOhzsWxwM/C1nVU75JUZjB4B XWUw== X-Forwarded-Encrypted: i=1; AJvYcCV9Jbj8JgR+2SWx+vAwVN1OyB1J7/CGu8rST0kpl5XL2Fpn+mI42rGSDOMVAKkuEUksbtmUuiazYqslaU0xZvLY2zaeqmo= X-Gm-Message-State: AOJu0YwcxahMzuvH4WZyuTyLojfDyVCZ5nif608bXlcgYvtrrUpUgWGX 1ASChg7FwgUjf0ACK3viHYi6Ptmen7EhVRN4xjs4k8x3ZaGzu4bg X-Google-Smtp-Source: AGHT+IHdfCM/9gRj2U7iaFK/XY6HMD1DlkJsiZhNgATJcngmIpEMY9L2Dm67VKokjmg3AbU37fpdxA== X-Received: by 2002:a05:6512:234c:b0:512:a8e1:abd1 with SMTP id p12-20020a056512234c00b00512a8e1abd1mr7916586lfu.23.1708445485083; Tue, 20 Feb 2024 08:11:25 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id b20-20020a0565120b9400b005116f7d1873sm1310400lfv.301.2024.02.20.08.11.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Feb 2024 08:11:24 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <86sf1nnslp.fsf@HIDDEN> Date: Tue, 20 Feb 2024 17:11:23 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <886A589C-5139-4FC9-8B59-636A9D6DFBD4@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> <E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN> <jwvttmjousn.fsf-monnier+emacs@HIDDEN> <6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN> <jwvr0hmq21z.fsf-monnier+emacs@HIDDEN> <E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN> <m2le7o68fw.fsf@HIDDEN> <13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN> <jwv4jecbktx.fsf-monnier+emacs@HIDDEN> <5C9DFD74-B166-444E-BFDC-D022826098C8@HIDDEN> <jwvh6ib6vwm.fsf-monnier+emacs@HIDDEN> <D1E7E6F2-DD5F-466F-BF5D-649A7E73B328@HIDDEN> <8F240949-B24F-4538-8ED1-7153F10AB5EC@HIDDEN> <1BD12E80-6BC0-4B17-A0D8-8C47414C8911@HIDDEN> <86sf1nnslp.fsf@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 68244 Cc: gerd.moellmann@HIDDEN, dmitry@HIDDEN, 68244 <at> debbugs.gnu.org, monnier@HIDDEN, stefankangas@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.9 (--) 20 feb. 2024 kl. 15.00 skrev Eli Zaretskii <eliz@HIDDEN>: > How many different platforms and configurations tried to build and use > the branch? For such a change, I think I'd like to see all the major > platforms be able to compile and run it, before we land it. In this case the risk for platform-specific bugs is not high (no = system-dependent code nor, from what I can tell, any architecture or = configuration-dependent code(*)). Of course accidents can always happen. If someone would like to try = building the scratch/obarray branch on a non-64-bit machine then I'd be = very grateful. (*) Building with --enable-checking=3Dstructs is certain to fail because = there's no point in updating the pdumper struct hash until it's actually = merged.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 20 Feb 2024 14:00:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 20 09:00:53 2024 Received: from localhost ([127.0.0.1]:44612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rcQg1-0001jA-Ba for submit <at> debbugs.gnu.org; Tue, 20 Feb 2024 09:00:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rcQfz-0001ix-HU for 68244 <at> debbugs.gnu.org; Tue, 20 Feb 2024 09:00:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rcQfY-0007nM-9g; Tue, 20 Feb 2024 09:00:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=HP/L1D89SbMpJJwZgqTF5V8x+bhXxw8zldCoPyuCMQs=; b=io/8zootVn8MC2j/51Pw E0MSXPZrFD+Jhc9EzwnnqwW1l3pNCRC0hzuJ/izROlt84WMfX1aRf8/MAV51BhkS84rDdZxhAxm03 jG3inAGhEaNEND3aUWECpt3GQ+rMHWIjuPqf7oV0YLo99Jr/d6TK+Ju2boaU7WWeSfVacBlkBU0lp DvWO0X1s/OmlgdevkboLG04FXlfhYWiTm4uh0wCuV9+cACq9jR0p+LUDpUm9vHK6/jBDgpcNNygMv vHc5Sei6FxXRC7g66QNhWYEFp3m+1rPwpYrPa16LZZeYt5SMLhC4OFjGD4GF1RxGLaMFZmROqLpfX VDqm6xeK//5NoA==; Date: Tue, 20 Feb 2024 16:00:18 +0200 Message-Id: <86sf1nnslp.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <1BD12E80-6BC0-4B17-A0D8-8C47414C8911@HIDDEN> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Tue, 20 Feb 2024 11:21:41 +0100) Subject: Re: bug#68244: hash-table improvements References: <170438379722.3921.9312235725296561206@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> <E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN> <jwvttmjousn.fsf-monnier+emacs@HIDDEN> <6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN> <jwvr0hmq21z.fsf-monnier+emacs@HIDDEN> <E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN> <m2le7o68fw.fsf@HIDDEN> <13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN> <jwv4jecbktx.fsf-monnier+emacs@HIDDEN> <5C9DFD74-B166-444E-BFDC-D022826098C8@HIDDEN> <jwvh6ib6vwm.fsf-monnier+emacs@HIDDEN> <D1E7E6F2-DD5F-466F-BF5D-649A7E73B328@HIDDEN> <8F240949-B24F-4538-8ED1-7153F10AB5EC@HIDDEN> <1BD12E80-6BC0-4B17-A0D8-8C47414C8911@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 68244 Cc: gerd.moellmann@HIDDEN, dmitry@HIDDEN, 68244 <at> debbugs.gnu.org, monnier@HIDDEN, stefankangas@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.2 (-----) > From: Mattias Engdegård <mattias.engdegard@HIDDEN> > Date: Tue, 20 Feb 2024 11:21:41 +0100 > Cc: Gerd Möllmann <gerd.moellmann@HIDDEN>, > Dmitry Gutov <dmitry@HIDDEN>, > Eli Zaretskii <eliz@HIDDEN>, > 68244 <at> debbugs.gnu.org, > Stefan Kangas <stefankangas@HIDDEN> > > > The scratch/obarray branch has now been updated. Now obarrayp detects obarray objects only. > > Except for a few cosmetic changes that branch is what I will push to master in a few days unless anyone objects. Getting the new type in place is the important part here. (It's really a reform long overdue.) How many different platforms and configurations tried to build and use the branch? For such a change, I think I'd like to see all the major platforms be able to compile and run it, before we land it. Thanks.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 20 Feb 2024 10:23:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 20 05:23:12 2024 Received: from localhost ([127.0.0.1]:44377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rcNHM-0001Th-9S for submit <at> debbugs.gnu.org; Tue, 20 Feb 2024 05:23:12 -0500 Received: from mail-lf1-f43.google.com ([209.85.167.43]:50453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rcNHK-0001TV-EO for 68244 <at> debbugs.gnu.org; Tue, 20 Feb 2024 05:23:11 -0500 Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-51197ca63f5so5431641e87.1 for <68244 <at> debbugs.gnu.org>; Tue, 20 Feb 2024 02:22:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708424503; x=1709029303; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=frm8ULEzAPbKKo9DFv1itw+mToTSVcqazzwy2VnDdEw=; b=UAMedby1RJ/5n5BasX0uNK18W0C1V8ym7uKOLyRtRz7Krmn4KkslytLbA9V3ELKc3s OOV7XefUBUY9sgxSl0KAgOz7BPeR4iedpHRMVOQucnzrkgLG84AGLP70kaUlO3qZ5OiJ c7tE6FZZr4N0JMVgNK8kPQ7Zsw4B67LW9yEKpbJYLuUkeDZ6LzCUrkJaQ8f2KLrwYfBj DOpWQftLQIFumHFPer/YDT6nR3XheAS9unLJUkwfEdgz3tZ4VOqAZQZS7ijiLUdXDhBm m/T3YTPFuk6Z1GnJsmWutMARKPn7oVvXIy1Z4NGeINwSUokAOhnKPW++dKEd6zEBS4ja Mf6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708424503; x=1709029303; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=frm8ULEzAPbKKo9DFv1itw+mToTSVcqazzwy2VnDdEw=; b=ZhqcZcRxeXpJJnuFVuUr0QohY3ZRhYDfGHl27u0rWASnpwgNaZaLoH3wpMHhfFvgvZ MdTlVbI+9QiZx4kVoDGzQY78QEJRCT3TycM5pqBPslzJikQLwNbyz51dZFLTHNjRXtp6 5q2fFkOAWEIWuEz83B9U8nf/w3WvE9r+Vbfg4PolykAFjWtjXtlmBNIblRMbcHoIT8ga fWxyDXIXrdbnitZGIt0UP2q3OPwIVR6VTabjOoLc74uXNPWV+z4DN+EZ3yxpdLk2ye2D MscDdKmQ7t96B0PhBI6IDt0ida0JUhhEfu0oCUvaOfSoFF7o55VBpvyC2ZR8w9dwhn5A lGEg== X-Forwarded-Encrypted: i=1; AJvYcCVeotDLkVEB/JUTrcftpp132Q5YXl9nIbeu3A+qSds2vYkf+Zb9BQa/2FlIShU4BgzvIGllNNRWnJQp/3HU8pnImaqeyyQ= X-Gm-Message-State: AOJu0YyUDjjJyZ6nldjTKMeHlWB9sP5HsINgPpltS2wzOIgM6I38ZNbN lj1G3v2/aB97CnZwLrAS2SCio6aCuFMzIgLWIKgR0TlRCNTu3rBb1AgN4avg X-Google-Smtp-Source: AGHT+IEa1V9Mf1DY6IItTKfEXtf3x1U+wyryoPPUcfsYbyr9DApdaqYJFNgTzZcqCzItuNMgyLtUDg== X-Received: by 2002:ac2:515e:0:b0:512:b381:d12a with SMTP id q30-20020ac2515e000000b00512b381d12amr3433767lfd.3.1708424502540; Tue, 20 Feb 2024 02:21:42 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id z19-20020a19f713000000b005116fce16b5sm1219487lfe.284.2024.02.20.02.21.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Feb 2024 02:21:42 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <8F240949-B24F-4538-8ED1-7153F10AB5EC@HIDDEN> Date: Tue, 20 Feb 2024 11:21:41 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <1BD12E80-6BC0-4B17-A0D8-8C47414C8911@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> <E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN> <jwvttmjousn.fsf-monnier+emacs@HIDDEN> <6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN> <jwvr0hmq21z.fsf-monnier+emacs@HIDDEN> <E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN> <m2le7o68fw.fsf@HIDDEN> <13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN> <jwv4jecbktx.fsf-monnier+emacs@HIDDEN> <5C9DFD74-B166-444E-BFDC-D022826098C8@HIDDEN> <jwvh6ib6vwm.fsf-monnier+emacs@HIDDEN> <D1E7E6F2-DD5F-466F-BF5D-649A7E73B328@HIDDEN> <8F240949-B24F-4538-8ED1-7153F10AB5EC@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 68244 Cc: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.9 (--) > The scratch/obarray branch has now been updated. Now obarrayp detects = obarray objects only. Except for a few cosmetic changes that branch is what I will push to = master in a few days unless anyone objects. Getting the new type in = place is the important part here. (It's really a reform long overdue.)
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 17 Feb 2024 19:52:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 17 14:52:12 2024 Received: from localhost ([127.0.0.1]:33922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rbQjM-0001il-0Z for submit <at> debbugs.gnu.org; Sat, 17 Feb 2024 14:52:12 -0500 Received: from mail-lf1-f53.google.com ([209.85.167.53]:43288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rbQjJ-0001iY-Gy for 68244 <at> debbugs.gnu.org; Sat, 17 Feb 2024 14:52:10 -0500 Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-511570b2f49so3603126e87.1 for <68244 <at> debbugs.gnu.org>; Sat, 17 Feb 2024 11:51:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708199443; x=1708804243; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=ZotMwivraWqjisjo5rd+THMlgU06EsPVC/Pck9sC07o=; b=JkPbK0w6oZQFIoquugn/Rg8k1eD5VSomf8Io3hwCrTg8nW10yqpz5FWj9K+192CVLp /QSL9/TZpNcJYgO8JX3uN5fVoJAzJut3XoBoK+KoRlPh4lHTINMPN+PGk3kBbmf6QgVK Tg9WHZWg3dodmc5uRz+ljhoCDZow8Qe3WbA+KbtE6pPyTgfIQwjHelokJcPb0KpK5nNe aABAEOw7CBadkCdfoeSligjY4Kmc6HNwdRAoBdRYnxxbUBuYPWrm58adPXAKm/+Kbk7o bP2upJbNyitm1oLQUfehXJNmh+jVKJjCwB9ZX6h3qLL5TkZpq6PZ2AY4Flfgkq5SF9la WCmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708199443; x=1708804243; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZotMwivraWqjisjo5rd+THMlgU06EsPVC/Pck9sC07o=; b=kR5qg/19y9yEkudmGGBRFn3xRA3wTbsbJC9eMAX1tLQfRjNDMtWSqSwvp4FOtg7Tlt wEjwKeUgCfubA/Bfz9wadfAAt5lYEyUqkxCWWmQy346zi+Jd8wQ3ICLPCw4orqjdHmAl 5l4SO/Dg7x2NdnSCuZLb4I6mQcpPv0PJVeZAe+wEKxFazA1NCfwtQ/pmfUHtm3yyMWbk K+MdVK8PbGg6o1zxigRTdUPG93/uhf5wFo/ZCytccrrh39fDAronCrrA8KTLRXWLviPI CK+FhssMe0ah2no3cEQCrxi7MfMr/pkYwxkUJdEMiS2C7ibd4z2xWMqdOVR65GvEb9YT UAzg== X-Forwarded-Encrypted: i=1; AJvYcCWFcZWbtDqZX26AN1UROfdHscaTW1n2SB2levvIiAQf2iJfI3/JHEzY81RZVB9p3J5eOpr36FNSoP2Sw5M6KQ/+qTY7wWE= X-Gm-Message-State: AOJu0Yyf4VWv83qHdTqRwjXnyQOzLd7Vn+FmhBzSChFFBCXWLleVaLSp ALDYvOkHVQqYMyfT+w/rxdu8mEJ8tS83xvULHyjWrOBOMCFTOra/ X-Google-Smtp-Source: AGHT+IEEcXoUzaCAkEfTMAfC04EGL1/P3UK8efssmpVbw+BUvKYOK4o+iyEEBD+wdgexVYiPRTxitw== X-Received: by 2002:ac2:5f53:0:b0:511:9f67:f7b with SMTP id 19-20020ac25f53000000b005119f670f7bmr2300615lfz.9.1708199443152; Sat, 17 Feb 2024 11:50:43 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id bi5-20020a0565120e8500b00512a98514b4sm149845lfb.122.2024.02.17.11.50.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Feb 2024 11:50:42 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <D1E7E6F2-DD5F-466F-BF5D-649A7E73B328@HIDDEN> Date: Sat, 17 Feb 2024 20:50:41 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <8F240949-B24F-4538-8ED1-7153F10AB5EC@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> <E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN> <jwvttmjousn.fsf-monnier+emacs@HIDDEN> <6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN> <jwvr0hmq21z.fsf-monnier+emacs@HIDDEN> <E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN> <m2le7o68fw.fsf@HIDDEN> <13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN> <jwv4jecbktx.fsf-monnier+emacs@HIDDEN> <5C9DFD74-B166-444E-BFDC-D022826098C8@HIDDEN> <jwvh6ib6vwm.fsf-monnier+emacs@HIDDEN> <D1E7E6F2-DD5F-466F-BF5D-649A7E73B328@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 68244 Cc: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.9 (--) The scratch/obarray branch has now been updated. Now obarrayp detects = obarray objects only. Some added polish: manual updates, the obarray type can be used in = cl-defmethod, iterators for pretties internal code, etc.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 14 Feb 2024 13:23:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 14 08:23:09 2024 Received: from localhost ([127.0.0.1]:50770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1raFED-0007qH-2T for submit <at> debbugs.gnu.org; Wed, 14 Feb 2024 08:23:09 -0500 Received: from mail-lj1-f171.google.com ([209.85.208.171]:56619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1raFEB-0007pq-9f for 68244 <at> debbugs.gnu.org; Wed, 14 Feb 2024 08:23:07 -0500 Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2d0f1ec376bso42699441fa.1 for <68244 <at> debbugs.gnu.org>; Wed, 14 Feb 2024 05:22:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707916903; x=1708521703; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=3F1M0hMswgf+9uGyo+ElFRruSWwz+S4vb7i4CwN99AI=; b=MEKjE4rQ8dRtZ4OwfJsWhD4Xx3154uWR8nMbG3G1IvGbJr9M2NxnFMCUcR0fKsYfUp gmwjazICw3mq5gWRs6AgLgUNVrXBMt6yjQbUM5vkE/GA4BqlRUGsNYPst+KaZ/8bjQee hp7M66xHeJd2dQcqGdEw+pE0X+JzVic3uGRD/dEYMDFxVtaZ63tlWTJypiOvr9wEZlDx wvm3D2Y6Q8e+GapW/8wrhZPQIxuHDDmoWhfPiFzcKN/TwtCRqR+vS6B2hFHCZHV+jDr5 fniD31GCJjQcrJ4oaWo3kPqjcLOePE35eom7Zq4xNMF6W6WgVWqx4GbCTZtVaBP8FyS6 lSkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707916903; x=1708521703; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3F1M0hMswgf+9uGyo+ElFRruSWwz+S4vb7i4CwN99AI=; b=jere3pmJYTnVeKagSrQhFFZ1fa1+VnuZlf8LWHQrfr6PQIeBR9bYURn4r0ac+Tc7ha rNwuSQsa+VTPg0Pyy5JfC3dl8y/+AzdrVieCZO7ibPsTDSNr2P/5jdOrDxrF9jmqdRkI 6MFEbIqLgK1ffuyeBc0XPc5k5PZOujejDDKyZfnwz5G2E38hbK2l0iBkI7roAfta6qw0 4Xh8uvzSjbu5IzMBoSTJOQpBBiWfAmxgk5/hnSr0FjMbbibWJaXvYex9F1uN93xC6FV4 p2mwoyTozgEQRW8UPBZrUHofM5xj3/2yoOZpnEkryHVfSEQv5L8Kyv3y83WCOH5iD9uq szJg== X-Forwarded-Encrypted: i=1; AJvYcCV4eLo1sqzG/yigr+SWx/XTYBovUogIHipJLCiXrWrGQwf5nWburULbXJpYPk3rWw30aaYLOY6uvO5WvYbVR+Bt3TikwqE= X-Gm-Message-State: AOJu0Ywqve4Lw46UEyeOmQnvI3kkh7vsfm2pmpSp7s5f642jT7vWzFV/ rrqWwdS0a+WHcO87wMKFRFsHGm3cJyT3gzvJ8XR8GPZigy6X/Fop X-Google-Smtp-Source: AGHT+IFj3oqY8j3KdwmUj6De8WD27bJl3PtIO5QL9XcS3MLA9hvfrs7TpM1TD+YQtFXVjXkcbpZJrw== X-Received: by 2002:a19:f70a:0:b0:511:ab2a:f346 with SMTP id z10-20020a19f70a000000b00511ab2af346mr876819lfe.52.1707916902736; Wed, 14 Feb 2024 05:21:42 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXAqEmVcTWTvEhdSkW6FiXw1+XWEaV5czEye9w4WymBcmOw9Lbci89wnFLsLm48Arem3i/ljrkrDNPdx1w43xEYTVHLMJyS6NxqnQlOhARLVS7WrS0icITfvVCXcUngnyVH7PqAvIztx1VwNDClnoQEJFJ0jOunWuyaoxeAKQ== Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id f3-20020ac25323000000b00511ad0609f9sm99987lfh.28.2024.02.14.05.21.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Feb 2024 05:21:42 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <jwvh6ib6vwm.fsf-monnier+emacs@HIDDEN> Date: Wed, 14 Feb 2024 14:21:41 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <D1E7E6F2-DD5F-466F-BF5D-649A7E73B328@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> <E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN> <jwvttmjousn.fsf-monnier+emacs@HIDDEN> <6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN> <jwvr0hmq21z.fsf-monnier+emacs@HIDDEN> <E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN> <m2le7o68fw.fsf@HIDDEN> <13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN> <jwv4jecbktx.fsf-monnier+emacs@HIDDEN> <5C9DFD74-B166-444E-BFDC-D022826098C8@HIDDEN> <jwvh6ib6vwm.fsf-monnier+emacs@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 68244 Cc: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.9 (--) 14 feb. 2024 kl. 14.05 skrev Stefan Monnier <monnier@HIDDEN>: > BTW, my idea adjusted for the kind of compatibility you're after would > have been to define `obarray-make` as (vector = (internal-make-real-obarray)) Yes, but since most primitives would need to accept a zero-filled vector = anyway (and replace the first element with an obarray object), = `obarray-make` might just as well just return [0]. Essentially: (intern X [0 ...]) -> (intern X [NEW-OBARRAY ...]) -> (intern X = NEW-OBARRAY) (intern-soft X [0 ...]) -> nil ;ie, treat as empty (intern-soft X [OBARRAY ...]) -> (intern-soft X OBARRAY)
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 14 Feb 2024 13:05:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 14 08:05:45 2024
Received: from localhost ([127.0.0.1]:50749 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1raExN-0007OD-8v
for submit <at> debbugs.gnu.org; Wed, 14 Feb 2024 08:05:45 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41780)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1raExL-0007Ny-0G
for 68244 <at> debbugs.gnu.org; Wed, 14 Feb 2024 08:05:44 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9DF8110005D;
Wed, 14 Feb 2024 08:05:18 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1707915913;
bh=36/mwGzEB1qjOHb6879TbPpFGI7sdoBue3Mj9WFv3/A=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=VBlK/47UdemMHNu57kYz9G4hWgtdnSeaK7wZqlOYaVOJ7dZNiEXrGKDpXofcdsnTc
XtRVFbbNfj3DgHOxNAKcS0kYAsjHtPGXqUQ85SatZVUUBe/x3LlqZgS2F0u72Jjvvh
F3yswbZyldGbKGSuk9Ap6NbkxKFpwz1oQ4SY+if4lyDY2lpWWZjJM0ktHwee2E0rjY
GzJO2g+tXnjcAG/h/59KblvLiPYc0QZStN68bGY9D3bEz+UEzIB//NkQPhhYhBpSQ3
dZEZUgdpimjzbZMdYwqBA67RwPaI668OUSzG2esht6kJC3Bi+4OLGRWp0bjSkgPxzZ
zTeyLJH0f40Vg==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5AB0B10004B;
Wed, 14 Feb 2024 08:05:13 -0500 (EST)
Received: from pastel (unknown [45.72.197.152])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 23E11120213;
Wed, 14 Feb 2024 08:05:13 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Mattias =?windows-1252?Q?Engdeg=E5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <5C9DFD74-B166-444E-BFDC-D022826098C8@HIDDEN> ("Mattias
=?windows-1252?Q?Engdeg=E5rd=22's?= message of "Wed, 14 Feb 2024 13:37:49
+0100")
Message-ID: <jwvh6ib6vwm.fsf-monnier+emacs@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN>
<jwvsf23qc3u.fsf-monnier+emacs@HIDDEN>
<E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN>
<jwvttmjousn.fsf-monnier+emacs@HIDDEN>
<6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN>
<jwvr0hmq21z.fsf-monnier+emacs@HIDDEN>
<E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN>
<m2le7o68fw.fsf@HIDDEN>
<13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN>
<jwv4jecbktx.fsf-monnier+emacs@HIDDEN>
<5C9DFD74-B166-444E-BFDC-D022826098C8@HIDDEN>
Date: Wed, 14 Feb 2024 08:05:12 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.132 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -4.2 (----)
X-Debbugs-Envelope-To: 68244
Cc: Gerd =?windows-1252?Q?M=F6llmann?= <gerd.moellmann@HIDDEN>,
Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
68244 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.2 (-----)
>>> With Stefan's suggestion, if I understood it right,
>>> we'd have `obarray-make` return (vector 0).
>> I did not suggest such a thing.
> Sorry, didn't mean to misrepresent. I should have said that it is one way of
> implementing `obarray-make` if compatibility with vector-assuming code
> really is a serious concern.
BTW, my idea adjusted for the kind of compatibility you're after would
have been to define `obarray-make` as (vector (internal-make-real-obarray))
>> I think it's worth introducing a bit of incompatibility, for the benefit
>> of a cleaner API. Such incompatibility should be very easy to fix while
>> still maintaining compatibility with old Emacsen (at least back to
>> Emacs-25, where the `obarray-make` and `obarrayp` were introduced).
> I'm all for it but those obarray functions weren't mentioned in NEWS at the
> time nor in the manual (which even today recommends, even mandates, use of
> make-vector) so perhaps we need a bridge?
You might be right. I guess time will tell :-)
Stefan
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 14 Feb 2024 12:39:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 14 07:39:16 2024 Received: from localhost ([127.0.0.1]:50718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1raEXk-0003ub-2t for submit <at> debbugs.gnu.org; Wed, 14 Feb 2024 07:39:16 -0500 Received: from mail-lf1-f46.google.com ([209.85.167.46]:59602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1raEXi-0003uK-Be for 68244 <at> debbugs.gnu.org; Wed, 14 Feb 2024 07:39:15 -0500 Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-511a45f6a57so970584e87.2 for <68244 <at> debbugs.gnu.org>; Wed, 14 Feb 2024 04:38:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707914270; x=1708519070; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=YUSsgHjgGe+XZSCro1nfDJ5INqXSo5KluBYP1iCFrGM=; b=GXFLcrOEoyYgbZu4O2aBB0W0qA/FxVk7lkFw+nqTt0Or7h5UgC/pO2S6SU8TWVnyEE Pj07zduploFM6efdCNSaa2618qHeBYGVtrXjd6TLF31f7D3NxUPAab/jaJoJSz9DWAGQ LC90Gye0otdFA4/gJ0aYCcX2Iu8Jaxdr3ZqmbRr0H4drxL9vYjSe5/jUq+HxI4k1lQ9P DMuLzPGbU7mnqTQyvCNiTgJi1xCz01dCc74TbKR9ut2rAC14hzZAwOsisEDkyux0mK8i 3nVH41asFf9XI3YpYgiOpndb7WG2wsuriSm6Ef+FG5K8IxZJfUWRruUJ0z2OisspCcXr ZvTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707914270; x=1708519070; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YUSsgHjgGe+XZSCro1nfDJ5INqXSo5KluBYP1iCFrGM=; b=awg2rm2AH+lJx/DXam7ius/Y/qxqlLE3vr8edbRXqmqHYZD+Gk/0Q9pTsuBRrlHoD8 gQYIJMwicL//qH1pq/KsytcWbL/ylKp7VS7ql5FuaPpaHD4j40ScjQw5TjStf0pdkVYU HHM4wYnumC1YlLalrYQ4PQ7EXIkW/OtIbdG1O7TsoGx4ihY+Fy0zRtyhTdR8H9SpxZQ6 1/YnDLweQ1kzWE2kh73aRdcJprbtUmzv+s7r7k0iCL/6f9ISFwHmE98i9hJ4lD+6Xjce Rtb++cFpz1CFXXmklbd7C+ZkdgVMVNmseZrMKPJ5Gbv4Kc99SX9tU5sSwB2KGxChUFqJ UDNQ== X-Forwarded-Encrypted: i=1; AJvYcCXdaahkncyTePxMuUyUeXMaBafY/XDOdyoqZiS7NsCDm9fV2UgfJRanpWPMAKmoQKaHUWb/ub0G5m55N5/px35qjaTjXA0= X-Gm-Message-State: AOJu0YyAXGkLk/kJ76UnxYCMUiuYuuatUij9pPPgwUprQ2vL5HSBJvsp 8oVLfNWLGzCS4Z7bW9HYpI5Gfven6KurUbiiSRExhp/FZp5SwTNP X-Google-Smtp-Source: AGHT+IEuQVYaYBW9tjApe/jUaTsKH0lOX0FMPZu5kw7gWN1J0aqBvR3+C8sTKlZhIZx6nNVE+W10zQ== X-Received: by 2002:ac2:484d:0:b0:511:8e33:639 with SMTP id 13-20020ac2484d000000b005118e330639mr2027758lfy.8.1707914270025; Wed, 14 Feb 2024 04:37:50 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWzZddQtx0RuKrWV8WqnCVGsMg+P/LSAzqFJBaxjt8Qz33wUbFo1dhfsCSPB5DxW/MGyXj+b9DC6Y6HlMD1m1gX1HT9xb4yrfohW6J8iUhBZrD3gTGLvXVla4b5scRbg7bCQJdQmjnhVL1BylBws2HiTdGZYYg66GRxRIPE6Q== Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id l5-20020ac25545000000b0051145f90c3bsm1663582lfk.67.2024.02.14.04.37.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Feb 2024 04:37:49 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <jwv4jecbktx.fsf-monnier+emacs@HIDDEN> Date: Wed, 14 Feb 2024 13:37:49 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <5C9DFD74-B166-444E-BFDC-D022826098C8@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> <E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN> <jwvttmjousn.fsf-monnier+emacs@HIDDEN> <6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN> <jwvr0hmq21z.fsf-monnier+emacs@HIDDEN> <E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN> <m2le7o68fw.fsf@HIDDEN> <13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN> <jwv4jecbktx.fsf-monnier+emacs@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 68244 Cc: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.9 (--) 13 feb. 2024 kl. 13.43 skrev Stefan Monnier <monnier@HIDDEN>: >> A more worrying problem is code that uses `obarray-make` but assumes = the >> result to be vectors. It may be unsafe to let obarray-make return an = obarray >> object for that reason. >=20 > I don't think it'd be "unsafe": it just introduces a bit > of incompatibility. > But `obarrayp` has been with us since Emacs-25 and it's trivial to > change code using `vectorp`, so I wouldn't worry about it. If we can do that, it's naturally preferable. Let's see how it goes. >> With Stefan's suggestion, if I understood it right, >> we'd have `obarray-make` return (vector 0). >=20 > I did not suggest such a thing. Sorry, didn't mean to misrepresent. I should have said that it is one = way of implementing `obarray-make` if compatibility with vector-assuming = code really is a serious concern. > I think it's worth introducing a bit of incompatibility, for the = benefit > of a cleaner API. Such incompatibility should be very easy to fix = while > still maintaining compatibility with old Emacsen (at least back to > Emacs-25, where the `obarray-make` and `obarrayp` were introduced). I'm all for it but those obarray functions weren't mentioned in NEWS at = the time nor in the manual (which even today recommends, even mandates, = use of make-vector) so perhaps we need a bridge?
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 13 Feb 2024 12:44:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 13 07:44:21 2024
Received: from localhost ([127.0.0.1]:42821 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rZs97-0004go-FM
for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 07:44:21 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31273)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1rZs93-0004gZ-N2
for 68244 <at> debbugs.gnu.org; Tue, 13 Feb 2024 07:44:20 -0500
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5048A440B2E;
Tue, 13 Feb 2024 07:43:54 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1707828233;
bh=4ENyXpdMpA7g2QNDUUbxHmCx+n4NydKKzKlQlWTgXFg=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=OLO+bZaXjmpcjT7hv+4Fna85IpU6e9sF8Kz49961L1g9gVJls4w8XOwKfg8Z3A2ip
+cXOZXdqIhjnc1fjz/LWT98qLIL/Je73bkaN58Xh6Xu/RbqsSHq5zJqRuZfNOHX/hB
TAKL4mPUIgr28IVpZ15tXRj2tL2YUucrerdKGfOvbmtlrWyY8ISsMVQ5bQ05FwOcxZ
ie99ysyPH08PCXHuH0ORFNMV+OUv+gsOVSlsN3kk0XuzSsGUMpREeFGRXFgeoFs9D9
Bscg67Yu6rRC/D3arJe1P8l8fXlUtzOpfZmGAe7RGRUZrqaugDlzjiorQIUCpMorDV
iqwJ3dMsDZzVg==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 13AC0440BF0;
Tue, 13 Feb 2024 07:43:53 -0500 (EST)
Received: from pastel (unknown [45.72.197.152])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CEB58120B70;
Tue, 13 Feb 2024 07:43:52 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Mattias =?windows-1252?Q?Engdeg=E5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN> ("Mattias
=?windows-1252?Q?Engdeg=E5rd=22's?= message of "Tue, 13 Feb 2024 11:12:37
+0100")
Message-ID: <jwv4jecbktx.fsf-monnier+emacs@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN>
<jwvsf23qc3u.fsf-monnier+emacs@HIDDEN>
<E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN>
<jwvttmjousn.fsf-monnier+emacs@HIDDEN>
<6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN>
<jwvr0hmq21z.fsf-monnier+emacs@HIDDEN>
<E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN>
<m2le7o68fw.fsf@HIDDEN>
<13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN>
Date: Tue, 13 Feb 2024 07:43:50 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.003 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68244
Cc: Gerd =?windows-1252?Q?M=F6llmann?= <gerd.moellmann@HIDDEN>,
Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
68244 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> A more worrying problem is code that uses `obarray-make` but assumes the
> result to be vectors. It may be unsafe to let obarray-make return an obarray
> object for that reason.
I don't think it'd be "unsafe": it just introduces a bit
of incompatibility.
But `obarrayp` has been with us since Emacs-25 and it's trivial to
change code using `vectorp`, so I wouldn't worry about it.
> With Stefan's suggestion, if I understood it right,
> we'd have `obarray-make` return (vector 0).
I did not suggest such a thing.
Stefan
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 13 Feb 2024 12:13:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 13 07:13:37 2024
Received: from localhost ([127.0.0.1]:42502 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rZrfN-0000sk-4a
for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 07:13:37 -0500
Received: from mail-ed1-f53.google.com ([209.85.208.53]:43362)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gerd.moellmann@HIDDEN>) id 1rZrfK-0000sU-8Q
for 68244 <at> debbugs.gnu.org; Tue, 13 Feb 2024 07:13:35 -0500
Received: by mail-ed1-f53.google.com with SMTP id
4fb4d7f45d1cf-562117d3dbfso65356a12.1
for <68244 <at> debbugs.gnu.org>; Tue, 13 Feb 2024 04:13:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1707826331; x=1708431131; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=GiToL/A46RbX00Pwbz9AakYif1H/4T3DWacC0+nrWEg=;
b=hnmWAAl+hPSZtr5AgrmmKMlQF0ltb+t/ZM6/iKh9u0HGIwtSFxINOVjzUgC8svU5RZ
LthETz2wJmAGfAvmf3j8CFD6/rSMznXN93j1fwObH1W7VYLByLbZwlY3Ygkoc+kLSqkU
/iAxhYQbV1XPFynhTblQqLAN6iXCp30fEmqCzdwfqEXKQnzcSAdAf2GQ3pCTqhGYfBup
8ma4XxOpj2fnaqL0B7kqF5DRCe2uO5Zb527owrIDxhGv6EBDExO9m7He0WeLK7XnThEF
AIEHx99JgKU7OZhhh6wiwqlSHTA3WpXO2isgZILiJJwEB3b17X1yP37U7vWFqAB1omyx
0WKQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1707826331; x=1708431131;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=GiToL/A46RbX00Pwbz9AakYif1H/4T3DWacC0+nrWEg=;
b=dKYcY4r7Tbku/xgNvyBoZXZh1WTklauS4uf7SPisa8PTj1Zg3o9lEZ37+dB8VxFYVL
L5dmCoz2MVpn7eqoIrQm0Qgrdw1JPrv2kZcut/ISVi0fDNBBMBWzLrCwQFS5iWEUK7WC
0DN+iSwnshH/31bf1Y+wO2zWSMwts0WH3jCrHpbF2Ooz1HNhTWr5+GTVquaYD1LKEKjH
AeXHSbLqx9accRKSG31Vfp+Ju83KdkeV4P2wjDwbMpPvBaDo3PpbUHDXFW7zz6W6WBj9
MmWyAchFVYQjiEEzKdz/jxG5SfsYxqgTAmwsgPDJadT45UehAVuIDt01D7ywunQiSG9M
4YOA==
X-Forwarded-Encrypted: i=1;
AJvYcCVdzAhyU4b0YD68ut6h5Khd0+guTrlq87S0d4trPK5dQWuGCzMMzl/jqulV/5z/SPGOQfm82O4+tEiTkf46Ix/KZbagFyc=
X-Gm-Message-State: AOJu0YzUMMipm/UWDpyuRAvxFTSC7SiQGhppyiK4gP3UN9ICAWqesx1N
HAHOP9XoY+E/Zfk5OD7GfqC+O+Px7D8IjhIILVs+xLEfROLJ/0VQmiabm9kZ
X-Google-Smtp-Source: AGHT+IESCqARdOyUgO6aIpMiZwNkyMS6+T9AOjmL412t0D1utJzhjfFEu71XRB4TEwvFO26bBamM2g==
X-Received: by 2002:a05:6402:290a:b0:561:ed6b:2848 with SMTP id
ee10-20020a056402290a00b00561ed6b2848mr1792918edb.3.1707826330798;
Tue, 13 Feb 2024 04:12:10 -0800 (PST)
X-Forwarded-Encrypted: i=1;
AJvYcCVm1Yo/w4dOZShacgXyanybk4DWg9q1rECPP1/3hnBjSSeQS0iW8i5U+bOuQpS85D0+M2SVAdnKcq6dDp/E2PDT4LApfHxh+7ldpf/L6Q60zmyvtnVYuwsMoIIjP2XNYOyp/Fy7uB1RaVDuhEqqwnuWysAJENMWEfpIGEeZGw==
Received: from Pro.fritz.box (pd9e36e83.dip0.t-ipconnect.de. [217.227.110.131])
by smtp.gmail.com with ESMTPSA id
f17-20020a056402355100b005620a2b5cedsm168955edd.49.2024.02.13.04.12.09
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 13 Feb 2024 04:12:10 -0800 (PST)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN> ("Mattias
=?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Tue, 13 Feb 2024 11:12:37
+0100")
References: <170438379722.3921.9312235725296561206@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN>
<jwvsf23qc3u.fsf-monnier+emacs@HIDDEN>
<E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN>
<jwvttmjousn.fsf-monnier+emacs@HIDDEN>
<6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN>
<jwvr0hmq21z.fsf-monnier+emacs@HIDDEN>
<E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN>
<m2le7o68fw.fsf@HIDDEN>
<13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN>
Date: Tue, 13 Feb 2024 13:12:08 +0100
Message-ID: <m2h6ic5zs7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68244
Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
68244 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>,
Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Mattias Engdeg=C3=A5rd <mattias.engdegard@HIDDEN> writes:
> 13 feb. 2024 kl. 10.05 skrev Gerd M=C3=B6llmann <gerd.moellmann@HIDDEN=
>:
>
>> I wonder, what does your code do for the places using (make-vector n 0)
>> create obarrays? I'm not 100% sure, but I think Cedet was an example of
>> that in Emacs itself.
>
> That code would still work, but just for completeness I changed all
> those instances to using `obarray-make`, including cedet. (See the
> branch scratch/obarray.)
>
> A more worrying problem is code that uses `obarray-make` but assumes
> the result to be vectors. It may be unsafe to let obarray-make return
> an obarray object for that reason. With Stefan's suggestion, if I
> understood it right, we'd have `obarray-make` return (vector 0). I'll
> give it a try.
Thanks for the pointer.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 13 Feb 2024 10:14:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 13 05:14:04 2024 Received: from localhost ([127.0.0.1]:41764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rZpng-0004mc-Iy for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 05:14:04 -0500 Received: from mail-lj1-f175.google.com ([209.85.208.175]:43104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rZpne-0004lx-EA for 68244 <at> debbugs.gnu.org; Tue, 13 Feb 2024 05:14:03 -0500 Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2d0c9967fdcso51869961fa.0 for <68244 <at> debbugs.gnu.org>; Tue, 13 Feb 2024 02:13:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707819159; x=1708423959; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=gvdnwvBBnVkX8s2GUJf1G+OrRzThlzxh6NVZtwfP2EE=; b=F3c/mPELG8XXps4M5gEfDEObVfnFRZw6Gv3zKLlGy6YQOP6I/B8hw15UF08mUrREkO gCvC+ddLhQDwkngleY+Qd3nhuTQ+gfvotLvnvT2YcaOTZ6AkVFKl+R/UxQjnuo+FQXsW Aaiuy8+rnc1zfSGENNGSLkWQp9a8jIZa6qpnAZhXhNSvUc8KPbnlnjTnRrmQHEYxxmIy dgthtlA1vDnvrU7Kx3jUO/8fWlX+cdo4QsaCMTeiNDMS/HFv5jbnZCBDt8+I30fXymMb NzFN1dC3T9qmUf5vsj5rPxt5nbcbOBLQTBo71eEgBbwRYlX1YfIqnF3V90rcfe2tnDhz XQ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707819159; x=1708423959; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gvdnwvBBnVkX8s2GUJf1G+OrRzThlzxh6NVZtwfP2EE=; b=pVFjZDarEt2G7w1xRMYkjHiV2Kv/ktY4o7pvcvj9uQdGl6B498Bycbr+6Nht0sSAhJ cpsdT3LK//aqVyUQJ2lxSG2icmFF2ZU72YsRn68pDzxJ2IzDX/RPq+jv28Uie/htb+8A 8CtG67g3aLT0GKdNAdKfku+xfyMxyYnwUQ+JyIe/y1Cfv6V8XDE8xVE97vZr/DVxLc5u IPsGhqjkUYoB9Ti6AUGerD1hpprMP/zrKX2Re5I8ttYgjQ4KKzRSlt4QQWaIeRXGIObR kgS90SmGhVCKC7JHLZGs4pkHRwGugCLHIeIrFaRO2MaNL7DZCva48OL2SzcmxFeR8ScP /dWQ== X-Forwarded-Encrypted: i=1; AJvYcCVxLAVhBqEQot9chY+S4/BwIdvnyU2Ebrkb/lIAr/TVajm1eUcYdRSX4KthnIEgqf1B4TfjYFgqQZvsNDY8KvEtwBYwOZs= X-Gm-Message-State: AOJu0Yyp8QKtL1kVNX/Cc+x8xiZ0c689MuHfM5xnNuH0KwWmFIKlKpdZ lgjek2sSilNUYAjFsPIYnjJ+F2JdnVeoEEDiO3XaSnciA5Vengy6 X-Google-Smtp-Source: AGHT+IGY5bc93sgse3IyH6KrSjtZHHzNUoVhAqdF7Hrym2/VHCYMdMwTOSTDf1laR8dcRH99Jam88w== X-Received: by 2002:a2e:9110:0:b0:2d0:fd07:92a6 with SMTP id m16-20020a2e9110000000b002d0fd0792a6mr701803ljg.23.1707819158681; Tue, 13 Feb 2024 02:12:38 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXB3I8AfDydWHH76SROuGLK5BSXCQQLRbCeQlqXFUeIyg06ERdNd1ZVmz3K3vzIfRTR+ZvckV8ML4pdIvcb5IyvIZrXmzSSkG2wGLs6KRlu5pQ+U2MrcImy09xk2q60b/3iBI/pNyydIzaXbqvAqpceBXvDJe1nbL6OR4/BJw== Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id z7-20020a2e8e87000000b002d0f98bcd81sm421266ljk.107.2024.02.13.02.12.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Feb 2024 02:12:38 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <m2le7o68fw.fsf@HIDDEN> Date: Tue, 13 Feb 2024 11:12:37 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <13877748-AFAB-4310-A0CA-104752C8BF2D@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> <E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN> <jwvttmjousn.fsf-monnier+emacs@HIDDEN> <6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN> <jwvr0hmq21z.fsf-monnier+emacs@HIDDEN> <E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN> <m2le7o68fw.fsf@HIDDEN> To: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 13 feb. 2024 kl. 10.05 skrev Gerd M=C3=B6llmann = <gerd.moellmann@HIDDEN>: > I wonder, what does your code do for the places using (make-vector n = 0) > create obarrays? I'm not 100% sure, but I think Cedet was an example = of > that in Emacs itself. That code would still work, but just for completeness I changed all = those instances to using `obarray-make`, including cedet. (See the = branch scratch/obarray.) A more worrying problem is code that uses `obarray-make` but assumes the = result to be vectors. It may be unsafe to let obarray-make return an = obarray object for that reason. With Stefan's suggestion, if I = understood it right, we'd have `obarray-make` return (vector 0). I'll = give it a try.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 13 Feb 2024 09:06:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 13 04:06:34 2024
Received: from localhost ([127.0.0.1]:41403 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rZokM-0001p5-KB
for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 04:06:34 -0500
Received: from mail-ej1-f46.google.com ([209.85.218.46]:59860)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gerd.moellmann@HIDDEN>) id 1rZokK-0001oe-Sc
for 68244 <at> debbugs.gnu.org; Tue, 13 Feb 2024 04:06:33 -0500
Received: by mail-ej1-f46.google.com with SMTP id
a640c23a62f3a-a3c1a6c10bbso323075866b.3
for <68244 <at> debbugs.gnu.org>; Tue, 13 Feb 2024 01:06:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1707815110; x=1708419910; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=kFvaxpevpZYnwRKjaUpm7utB/OFi/3MSfUSu+TziCqs=;
b=iOfXWxG3ShLcq/NTaUKAZqJOroAfTPKaXImXBza44I3xGjvZjW9YgeqG83pNpQJBMt
55TyKwAoco8kD88oYiB7rA4eSKxVbv9WqG4KGXsIMxIZoRzPIlkzZdGhPGuJGZ7O6oof
56yPjG239h2LsJtq6V5BdyT5iH4LKhKWj2cFVBw5tHJN3fi0rz2leObcymsXk62VBqav
dl4MQclQ1WvkyxavSWDxINH2i2d9+FmZU0zR1EA67g2SOJDlmLEeO/NrICyPmYqN1jl9
X0ywFC7Nol3y28r9VmYPu7tJXwTRskY5wuFvo7C7GsUGWZORpO7iIM5D7gq5kPjPsbA1
iD3g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1707815110; x=1708419910;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=kFvaxpevpZYnwRKjaUpm7utB/OFi/3MSfUSu+TziCqs=;
b=LNH9MaqxXkk2z58dfWxH+3oJw8dbSlgtjkyIav7LhkzrdLvp1n7DGj5K6ZqVgsdz0S
3HlMcRrRaOFlQKlVOTYruKdJkXp19nlFVlWEEJWoqTMtR/nkqiXDPEG8eoT8E/7kuLRq
7uN96UXewRnF+gHmTJbVoRUVaWacAZyO8MS9ZhnGGR3bEd7HNF4mQLa/rjrnp26Gmlbp
0zZkYxZ4+jrgdGIhm04E69gAtOvAwRKlSGh2K2Bj5y37w6stKLJO8l1iz91jnFx1fULI
j1ueK+R0SwArJkf3cCaspGAl68p3/gPczgrjtTX/7tnidaZelh5BUJmc0NNUWV6X5icw
SqXQ==
X-Forwarded-Encrypted: i=1;
AJvYcCXfkeUxflIS8Jen7H9FOOag1sUopfkQb9BD+MHA+oP+5dHeo05UQCUy28P1GU0K4VZQGVoU6mYTPEEG+YfyORDhG93fuIs=
X-Gm-Message-State: AOJu0YwzhF4cH0ROMtXhifFAVTl7cii3Jt9X0aUTBujC/ewsradQZwiu
cE3YUMBcFsGfbeKaLOfkgfvO1+IEGrGcwPKqLxJeLEtmQYirysq7
X-Google-Smtp-Source: AGHT+IE7VaZ2GEM94oJQPkXihTZ0K6R8BOeZFEV7JNP3FlMnGqLBi1gcSc4GsnAb1rpPy5S7eE1iwg==
X-Received: by 2002:a17:906:2dd1:b0:a3d:1ab:1d58 with SMTP id
h17-20020a1709062dd100b00a3d01ab1d58mr901621eji.17.1707815109586;
Tue, 13 Feb 2024 01:05:09 -0800 (PST)
X-Forwarded-Encrypted: i=1;
AJvYcCW8JRLg/E8RHDQ9eY6tFmLBAj4xRGqNzHqIewvC5XRTsKdwG8B9ElDp5qjz6lCYiaH2Ug12u6wJTUxcYmi3n/7XNSjsRXG1YIet5jScwLYcxmkuC7qW6M1piNAM9H9fVsULRNUxKhu4n5onlbpq78Zw/cHfb9KFGKHImd+0OA==
Received: from Pro.fritz.box (pd9e36e83.dip0.t-ipconnect.de. [217.227.110.131])
by smtp.gmail.com with ESMTPSA id
sd18-20020a170906ce3200b00a3c456b0c0esm1078285ejb.108.2024.02.13.01.05.08
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 13 Feb 2024 01:05:09 -0800 (PST)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN> ("Mattias
=?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Mon, 12 Feb 2024 13:16:44
+0100")
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN>
<jwvsf23qc3u.fsf-monnier+emacs@HIDDEN>
<E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN>
<jwvttmjousn.fsf-monnier+emacs@HIDDEN>
<6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN>
<jwvr0hmq21z.fsf-monnier+emacs@HIDDEN>
<E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN>
Date: Tue, 13 Feb 2024 10:05:07 +0100
Message-ID: <m2le7o68fw.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68244
Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
68244 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>,
Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Mattias Engdeg=C3=A5rd <mattias.engdegard@HIDDEN> writes:
> * Compatibility with existing code is excellent except for some places
> that used `obarray-make` but then assumed the result to be vectors
> (using `vectorp` instead of `obarrayp` etc).
I wonder, what does your code do for the places using (make-vector n 0)
create obarrays? I'm not 100% sure, but I think Cedet was an example of
that in Emacs itself.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 12 Feb 2024 13:36:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 12 08:36:56 2024
Received: from localhost ([127.0.0.1]:57108 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rZWUS-0005sB-KN
for submit <at> debbugs.gnu.org; Mon, 12 Feb 2024 08:36:56 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41156)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1rZWUQ-0005rS-7Y
for 68244 <at> debbugs.gnu.org; Mon, 12 Feb 2024 08:36:54 -0500
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C0CC5441639;
Mon, 12 Feb 2024 08:36:30 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1707744989;
bh=Ij9WFVFKdmC5WbkOpO94mxAIrSGIzXanHlmI7kPhuMk=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=FKQBeZG+m8tr1ZXm54gnDmzajsmDeMLBiy+MGQUpkNN3GoPqaoxVBOeZPIAH9Q5J7
55OnURVYZVkhTEv9WOMqdptELWJIZq10JDXSqADeozRyorjyq16fqEQRTJ6kGQGwJB
E5MSbfg6LI8Tm7p0wbVVyynsufO0FbDBbiwAcriEBJ8Z0iDxRcdim7xkHQiv4O/HYm
KZ12Ay6+7NB3xNSYuCg0i9q7af8Ls9zpeXl7IrlRP1yCRvfxQlAuw4B7QJ9Ic6IQVp
G6mgUzhGSVGoEGLg0i5IfhMRT+uQWyChdJxctrKFj5fnFudTyJNTnVVzDC0eCU1m3S
h2TkPKL3vMJMw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A0569441593;
Mon, 12 Feb 2024 08:36:29 -0500 (EST)
Received: from pastel (unknown [104.247.238.113])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 66621120490;
Mon, 12 Feb 2024 08:36:29 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Mattias =?windows-1252?Q?Engdeg=E5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN> ("Mattias
=?windows-1252?Q?Engdeg=E5rd=22's?= message of "Mon, 12 Feb 2024 13:16:44
+0100")
Message-ID: <jwvv86tdcue.fsf-monnier+emacs@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN>
<jwvsf23qc3u.fsf-monnier+emacs@HIDDEN>
<E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN>
<jwvttmjousn.fsf-monnier+emacs@HIDDEN>
<6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN>
<jwvr0hmq21z.fsf-monnier+emacs@HIDDEN>
<E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN>
Date: Mon, 12 Feb 2024 08:36:28 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.031 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68244
Cc: Gerd =?windows-1252?Q?M=F6llmann?= <gerd.moellmann@HIDDEN>,
Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
68244 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> - `obarrayp` is now true for both obarray objects and vectors;
> `obarray-object-p` detects the new type only.
Is this really necessary?
Stefan
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 12 Feb 2024 12:25:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 12 07:25:18 2024 Received: from localhost ([127.0.0.1]:53415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rZVN7-0006M2-M9 for submit <at> debbugs.gnu.org; Mon, 12 Feb 2024 07:25:18 -0500 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:56698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rZVFG-0005m2-TG for 68244 <at> debbugs.gnu.org; Mon, 12 Feb 2024 07:17:11 -0500 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-51147d0abd1so3364879e87.1 for <68244 <at> debbugs.gnu.org>; Mon, 12 Feb 2024 04:16:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707740207; x=1708345007; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=AbSuuvwZukSH4O31Tr+LR72fvtEexsiiHGRhB28vH9I=; b=hOG9ig22dKNAd08QZG9Rkt8mAYeq3jkpIqNoHjGhn9PGIeTddYFdrHmtSO7dsvqmNd 6ZoDrM8AUz/SCmCFSBRySat7E6pWeUXzNoO85fiML+8jUJeo6A3wZrkpREUsPK9x0jOt IRgWnn0eHmBTTgNQipMUqTxC86WaYEJjbpzZFFJT0mDLUjQJR2lytFxQm4ivw24jBa2+ sZdPwx5KfIIFP3HQwIV7Q1zmEC48M6coMuurojAQY4ouihQ4iDXB5lzgHGrDe9wiMyAa l/YYVC5k5ZMkBKHzw4nhIHU+zY6/2+8HWRfGfajfQs6Jiri5SY/6nLmVFDklDqn9sVSa fSIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707740207; x=1708345007; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=AbSuuvwZukSH4O31Tr+LR72fvtEexsiiHGRhB28vH9I=; b=QNl9k5aD/0TQRtN8fSzlaEiqs2GKoAhsEs2+4GHfLc4S6wSwqC+a5LFABITPCwxBY5 rUSR2/hdct+5ueAYMjIo6l1OJ1JVsnsJluwETsP1YJ/6fKIWEosl6FqQP0O/wMm/KIUF VHmWEHlpZdicIK9o7CjfFpbnmXAoqCu5Uw6GDOIRlHGSmS9Js4E3LMY5mLGvnfUQ1i7m aVj9EglGGIemhLT+WBOmw3v7opo27fFP5HF0Ov4xY/8h4uDOzmAOo5bxKuhTxNPaaQ1e 6NMxhz77v+zHT3jGWXwFhsx7Z/gmfjdBPMTJNVPxQb8xtIHvlKUinjUb6YjVlbs0xrHP VFrQ== X-Forwarded-Encrypted: i=1; AJvYcCWKnhQa3+Z3AAYTUL2j0T2x3a5L9H7RcPyfsiq0t7c8ykTEl+I/RyymN9sBNGVahAU1IDfiA0bsAkt8n3xSdNbPFlScFDU= X-Gm-Message-State: AOJu0Yx+TN3mMUHY29nJQrn1o3wd9K8AxFboDFVScFEIRvyHxeSKIRPH z4fsmJ9zcjwDp7zUnAr7rI9jfXeel2bVKBo+qGz6/v3R7JJlt9Zi X-Google-Smtp-Source: AGHT+IE4bTn2wnxeX/AmU2DLfdSWLvl8MZowEm8ZLUMF07UeemMomsdI156Ow6G3kDDm0RTNDp+iCQ== X-Received: by 2002:a19:7506:0:b0:511:3232:954f with SMTP id y6-20020a197506000000b005113232954fmr4303686lfe.2.1707740207133; Mon, 12 Feb 2024 04:16:47 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCW7AUTrU3n75W7tUxm7Vj9jscl3AnrX6CNwf/idtuhF4+WUYqFPt2tM9ZPACrSGLDU0IzIjKh/2sPsZwC9w2UgGxqwV55SGHPwP+VT6ExR/zvHbyguoeiIykajd23X0+QmfXVf6fY3MEKTHHOnQ/O4m0wyiV1ugIZnTBsBiacwlXIEb1j+T Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id fb13-20020a056512124d00b005118d5b3adbsm416862lfb.98.2024.02.12.04.16.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2024 04:16:46 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <jwvr0hmq21z.fsf-monnier+emacs@HIDDEN> Date: Mon, 12 Feb 2024 13:16:44 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <E17C94A2-39DF-4C72-89A6-D2CCA30EC62A@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> <E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN> <jwvttmjousn.fsf-monnier+emacs@HIDDEN> <6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN> <jwvr0hmq21z.fsf-monnier+emacs@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 8 feb. 2024 kl. 18.49 skrev Stefan Monnier <monnier@HIDDEN>: >> And you are right about the need for vector compatibility, just = discovered >> that the hard way. >=20 > Welcome to the club :-) And to show that I'm repeating all your mistakes and ignoring your = hard-won wisdom, I made a patch for PVEC_OBARRAY. * It does give a nice speed-up, not only in microbenchmarks. Relint on = the Emacs directory tree sees a speed-up of 5 % which is not bad = considering how much work that code does. * Contrary to your suggestion I went with an entirely new type, which = means that: - obarray objects grow automatically and use the same faster hashing = (Knuth) as hash tables - `obarrayp` is now true for both obarray objects and vectors; = `obarray-object-p` detects the new type only. - `obarray-make` now produces an obarray object. - All old built-in functions that take an obarray now accept both = vectors and obarray objects - New function `obarray-clear` to replace code that filled vectors with = 0 * Compatibility with existing code is excellent except for some places = that used `obarray-make` but then assumed the result to be vectors = (using `vectorp` instead of `obarrayp` etc). Your suggestion to represent obarrays as a single-element vector = containing an actual object (PVEC_OBARRAY or a hash table) would kind of = help here but it still seems like a half-measure and perpetuates some = problems that we would like to avoid with a new type. Maybe a different kind of compromise would be better: `obarray-make` is = kept unchanged as make-vector (but deprecated), and a new `make-obarray` = (for example) creates the new objects. Oh, and there is a small glitch in the existing code: when a symbol is = uninterned, its status is set to SYMBOL_UNINTERNED, but if its = containing obarray is GCed away or manually cleared then this doesn't = happen. This is probably not worth fixing but at least with PVEC_OBARRAY = we could if we wanted to.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 8 Feb 2024 17:51:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 08 12:51:15 2024
Received: from localhost ([127.0.0.1]:33571 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rY8YM-0004dj-OL
for submit <at> debbugs.gnu.org; Thu, 08 Feb 2024 12:51:15 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:59540)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1rY8YK-0004dP-6a
for 68244 <at> debbugs.gnu.org; Thu, 08 Feb 2024 12:51:12 -0500
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 044FC442BAA;
Thu, 8 Feb 2024 12:50:52 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1707414650;
bh=KexveThvn/d6/b2Zkh4NomfvRCLhWTrFHH88OcNQXvs=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=NdMm+99q86irZm+48tFZQ/XSz1KjwXZYTvDzy9kBuRgEQzN8KegnaxTekFZVMnAPw
dLnpQli+aSx7HlcjbUJTQwOho+pQ9oLrXTY4REqIolb18PdUI/BTfmy9CM8wvcA99q
Hu/7eqYSwsz0ZBc9riOBBuPVjPvIAfpcMg1893e8pMzanc+NNm+zjxYlGws29z9aV0
lK5/ZeQtOxPm4LLz8sy8CB5h+1zFy0CkESxsKnw2S02oP2qulfquHj91irKd4bx6df
SscGNaJAnznRsFBOxQ6RBvSFBBZ8aU2eKOJ3hs2TLmUC0pxTKLqx3S4406g1s5GqkV
ggazjdh83XM/w==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D7725442B85;
Thu, 8 Feb 2024 12:50:50 -0500 (EST)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C456F12041B;
Thu, 8 Feb 2024 12:50:50 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Mattias =?windows-1252?Q?Engdeg=E5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN> ("Mattias
=?windows-1252?Q?Engdeg=E5rd=22's?= message of "Thu, 8 Feb 2024 18:29:54
+0100")
Message-ID: <jwvr0hmq21z.fsf-monnier+emacs@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN>
<jwvsf23qc3u.fsf-monnier+emacs@HIDDEN>
<E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN>
<jwvttmjousn.fsf-monnier+emacs@HIDDEN>
<6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN>
Date: Thu, 08 Feb 2024 12:49:24 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.132 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68244
Cc: Gerd =?windows-1252?Q?M=F6llmann?= <gerd.moellmann@HIDDEN>,
Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
68244 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> And you are right about the need for vector compatibility, just discovered
> that the hard way.
Welcome to the club :-)
Stefan
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 8 Feb 2024 17:30:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 08 12:30:18 2024 Received: from localhost ([127.0.0.1]:33541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rY8E6-0002Gp-9E for submit <at> debbugs.gnu.org; Thu, 08 Feb 2024 12:30:18 -0500 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:43053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rY8E4-0001nG-4b for 68244 <at> debbugs.gnu.org; Thu, 08 Feb 2024 12:30:16 -0500 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-5112bd13a4fso1303111e87.0 for <68244 <at> debbugs.gnu.org>; Thu, 08 Feb 2024 09:30:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707413396; x=1708018196; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=74GAGY/3GZfnPQnA4U0XEn1SoNhH51ScGiOWU6OsuOs=; b=DxFAL/uNDUrsiS/aRUvsfArBFBqJ9pdLmfKNniljSJ85ZXFGYmKSBtt9nzltqr/U8A kVG8TIt5wWEMtHsm/eoGigeRX9qyg79sPtrdginpJ0E+8NLOAhiIQyKMaWVgEo3KMZb3 U2ck5YoENxrzqyMCkhMNpKVcFIToPKZJpKpgyvU9+NHV7EIBOTuFakT7vFkTmWVrwzkt s/Z+fSkZ1DZfLRtv6nlvLRM47AD8P39zSlYj4WGVX0mqjEfnpWmqcxHAkX/lwpCTbxlR JY9jlwRpWtwMN68dYfv+ClPcv3eQxWY3XF0jclVlS9OoOjRpElNo5PrIzWzv/WloSShv DRWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707413396; x=1708018196; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=74GAGY/3GZfnPQnA4U0XEn1SoNhH51ScGiOWU6OsuOs=; b=d7qyJTrwBIrvk1/GAxhGPQe+734cdYUzlOoJKS8pWWW5rQBg9K8CXzuUHC96MmbtxW QkP9PruDbx+h9iTLo4H+stMUQsk0E0ax9TjNl9wXTaWNNxLtZbO+BRkQJimCnGo+imec J46RlQR2gHc7xIA0tLBy4F8p5CLsvBPlU20qB6/fOsvQQW3k8p+dIo3f2Rd+PMPRLZNO nDktBNUd0yGUwtXKtY6lCOZcS2Tv0pGo8fKruX+zE/qZxgRy/OWM6rkIWhAM8QMiX8+g y5/Yb9Xhnc0XTqOJDuMmJN4jZTnozudSshQ2nNj9KMEBwskCLSvdewMUVr0HYbEdfzOr z4lQ== X-Gm-Message-State: AOJu0YxxFOJaJXmYRAASsUMuBJPtmkyBH3UvKjK7HPXh/E7r4+MKmtbv w2ey1CFj1eiCBl+eBItvFCbszp80KU3wRBV/CJHbyDvN7c1KOEwA X-Google-Smtp-Source: AGHT+IG1VzJRfYj6CBit06rdaJzk9qPgd7MpgP2VVqhuFxnCQ8EQewYQ3pttPEJKUoM5VnfuVcQbag== X-Received: by 2002:ac2:5443:0:b0:511:71be:be72 with SMTP id d3-20020ac25443000000b0051171bebe72mr585060lfn.5.1707413395444; Thu, 08 Feb 2024 09:29:55 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXGPHFhm4RH8qIPouliQabSy2N8kLuJWccxjWDJ0P5EIO3Yrybe3rkz2IKIGJttIsFMgLSoVv4tD9JkB2qNyjXL/bbUt+DcDVxJ1VsunzlGDQZT3im16EctKlfw9TiJB9H4O+rTM8QrcLTdwTf5P7qZ5UGFYdjeoqx/p+mRRpNfNUWTrX74 Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id t17-20020a199111000000b005116a12a9cesm11346lfd.188.2024.02.08.09.29.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Feb 2024 09:29:54 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <jwvttmjousn.fsf-monnier+emacs@HIDDEN> Date: Thu, 8 Feb 2024 18:29:54 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <6F3E332D-54ED-4E70-BBAA-A207750B52F8@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> <E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN> <jwvttmjousn.fsf-monnier+emacs@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) > I don't know in which sense what I propose is different from what you > mean by "accept both obarray objects and plain vectors": what I = propose > is a way to "accept both obarray objects and plain vectors". Of course, sorry about that. And you are right about the need for vector compatibility, just = discovered that the hard way. The practice to use `make-vector` to = create obarrays is widespread. (I have patch for the Emacs tree.)
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 8 Feb 2024 15:13:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 08 10:13:35 2024
Received: from localhost ([127.0.0.1]:33436 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rY65m-0003TX-PE
for submit <at> debbugs.gnu.org; Thu, 08 Feb 2024 10:13:35 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31160)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1rY65k-0003TL-Vk
for 68244 <at> debbugs.gnu.org; Thu, 08 Feb 2024 10:13:33 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DF1F110009E;
Thu, 8 Feb 2024 10:13:12 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1707405191;
bh=2GrGWsLlo5lKBCVmjcwN7w3pO/EASXeS1d8AADRSaXc=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=AljTGdFtqVHzvmNJOazvl+RpuTj9yesZycoxJ/xdJW3QTEZD4wFXv36FuLVwCGV5w
2jEZtEjWRq1ae8H5AALvN+lDG76LwN+tUwdidgKnl8AjbQdGYDEIanl/L7qLAWdBCQ
UpdPbUFpPGrYnXXsuFSomh3aI+F1X8y9a7iZjk77bGz82xmIaKJZgHaj64qB9KZ9uY
0R0yw0k7I4SXPjBz8+1v5F2M2XPWs3wwknBx4AgKHxoAwgKUPk1rgRxnp4ICwsNPsA
lwpeY2Hnqv3rjVCCFBEkOghnIlbNqBBOOCtFfY7ay3jS05FrDFVRCAHb4JzSmoqPHu
W6G7xnmSvsggw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D3F5C100054;
Thu, 8 Feb 2024 10:13:11 -0500 (EST)
Received: from pastel (unknown [104.247.238.113])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9C1D81209EF;
Thu, 8 Feb 2024 10:13:11 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Mattias =?windows-1252?Q?Engdeg=E5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN> ("Mattias
=?windows-1252?Q?Engdeg=E5rd=22's?= message of "Thu, 8 Feb 2024 15:42:45
+0100")
Message-ID: <jwvttmjousn.fsf-monnier+emacs@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN>
<jwvsf23qc3u.fsf-monnier+emacs@HIDDEN>
<E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN>
Date: Thu, 08 Feb 2024 10:13:10 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68244
Cc: Gerd =?windows-1252?Q?M=F6llmann?= <gerd.moellmann@HIDDEN>,
Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
68244 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> we can do something much simpler: vectors are accepted by
>> simply storing in the first field a reference to the actual obarray
>> object, so there's no need to play any games and/or share representation
>> between vectors and obarray.
>
> Why is that simpler than having `intern` accept both obarray objects and
> plain vectors, during a transitional period?
I don't know in which sense what I propose is different from what you
mean by "accept both obarray objects and plain vectors": what I propose
is a way to "accept both obarray objects and plain vectors".
Stefan
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 8 Feb 2024 14:43:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 08 09:43:10 2024 Received: from localhost ([127.0.0.1]:59422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rY5cM-0001kT-6W for submit <at> debbugs.gnu.org; Thu, 08 Feb 2024 09:43:10 -0500 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:44211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rY5cJ-0001kG-RC for 68244 <at> debbugs.gnu.org; Thu, 08 Feb 2024 09:43:08 -0500 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2d0aabed735so24361961fa.0 for <68244 <at> debbugs.gnu.org>; Thu, 08 Feb 2024 06:42:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707403367; x=1708008167; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=cSivXCE56ok7wbAMPbWs9buZo4W357MTiMXwQhpG6jk=; b=OeVMEm9hfO/M/PE1WK99M6xwtQw0yFH51cbAB7qcWSRZErspRf3rWOUkppfKz7Hz1M NKJxtzMN9MkZT+64RLi/HoVYyZdn9wLjuo/Q3UOacStduch5TDDvuFhz4F9EuCx5KWMO EYwVfo/EzXOxbbZlUDXt27fRL3oJpYrUt5w7tUOOQ6Wle1GPN6uw1WpnGWdEKRsd5v74 9tl+txMS25VDixe1GT3WOTWF8xiQ2Iw/TVQt9DAhAh4wLrovLnbWEqZ0XGfL4IiNxw2K QpZuD8tQfs07/GzHndk7KTJoy3Pvjrfr/2XtsoBve2gdeD9xdHMctVkl3YmkOqP9zanS lylw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707403367; x=1708008167; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=cSivXCE56ok7wbAMPbWs9buZo4W357MTiMXwQhpG6jk=; b=eVU4xHkawfTx7J2htoq1vv3tQhnO0bEm3+jFto7Op3amoU9uBlVZVKuFfadPSymJRR TCsLCaoIVl+Nc9EiVsZJ6o8pvhSElXAnIUuVnLUb2+NECq/UZ5IO4cMvqkEq50TxOR8B v8sSf5CCn5y1fNUHTt+DZz6HY/DBMFqV0U9IRG01vo8dsO38dJSWz0YKMUqm2ij+0Xgb J1jdF4Lyv2gHPpIaf09r33GF9bcZXZz3/VyoEpnz/3eLnmST72I4K8B6wDhjJ0kc/CgS OZ9irFZDN6Ftl9xL0ozRWYJxj9cM66CDBv3tXt3QAh9BrBqejAw4fdK8hE5OY2GWd9bq xyJg== X-Forwarded-Encrypted: i=1; AJvYcCXQ0GokSo/rW7MaX69Jk834KRkzptP9RIW25OCLKnMw/Azey1IGsFWE5usS7HCuqT1Ku2/u0JXLW1LkKvRP3es02sLipqo= X-Gm-Message-State: AOJu0Yz4C9OgTacYHkSHN4TaiAAi23rl8EdCv3xWMNVuveSAizGXr+wy 10aTihKCFvemrb/OOhJh+6GotolDD5LYXsgYnKv/6+kOfeeZKLux X-Google-Smtp-Source: AGHT+IF/5Kq/EUFuYOhcbn5ibGWKgxTPIbs3utyehxD+6/MOPidV91dsLDsbt9lAn0D4TPP4XuLb3Q== X-Received: by 2002:a05:651c:10d1:b0:2d0:aecf:3a3 with SMTP id l17-20020a05651c10d100b002d0aecf03a3mr6519319ljn.14.1707403366983; Thu, 08 Feb 2024 06:42:46 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV82zkPjSyN2RV2sYtT9ki14KiZBAEN0nZZZZdPmhqR9QeI82tCfXX09F88u5nTpmCIHgzRUQn4T0Bfe80lxdBxFT9x6E5cmj1lC0HKY86d/I++tDQXpxajEUWZuhoxDPX+FQyAip8wMmmp5XjYKrQR6VEckOSnnv/LwgETBMGuuiK6qPIP Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id z10-20020a2e350a000000b002d0c1f0ef6asm14624ljz.12.2024.02.08.06.42.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Feb 2024 06:42:46 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> Date: Thu, 8 Feb 2024 15:42:45 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <E14799C2-F1F1-44D6-A2E6-53765F038C92@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 8 feb. 2024 kl. 15.19 skrev Stefan Monnier <monnier@HIDDEN>: > For me, the more important aspect of obarrays is that we should have > a separate obarray type Oh yes. This is necessary for automatic growth if nothing else. > Of course, we'd still have to *also* accept plain vectors, sadly. In some contexts such as `try-complete` perhaps, but I don't think we're = saddled with it forever in places that actually use an obarray (like = `intern`). > we can do something much simpler: vectors are accepted by > simply storing in the first field a reference to the actual obarray > object, so there's no need to play any games and/or share = representation > between vectors and obarray. Why is that simpler than having `intern` accept both obarray objects and = plain vectors, during a transitional period?
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 8 Feb 2024 14:37:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 08 09:37:16 2024
Received: from localhost ([127.0.0.1]:59408 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rY5We-0001Y3-5i
for submit <at> debbugs.gnu.org; Thu, 08 Feb 2024 09:37:16 -0500
Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:43110)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gerd.moellmann@HIDDEN>) id 1rY5Wb-0001Wk-Vy
for 68244 <at> debbugs.gnu.org; Thu, 08 Feb 2024 09:37:14 -0500
Received: by mail-ed1-x535.google.com with SMTP id
4fb4d7f45d1cf-5610b9855a8so1153264a12.0
for <68244 <at> debbugs.gnu.org>; Thu, 08 Feb 2024 06:36:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1707403013; x=1708007813; darn=debbugs.gnu.org;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=EBvNXMvqHIgeneCdEqMQSkXCKrcpIv4tatu8hVLwGeE=;
b=DX57FuzOVFZ7Fj3+D7UoraqkPNJwGYPuo//9KJYaD/jAigmJ2m0l2lTKY2xxUa0mR4
6t29MQk8cJyMsiYfr6SP40HRTT4Xa3VdT0glhuDbSOA5lQq17zE36cqIcLe2aRkEkjg9
MXiOwFzYFypC5RuyUfjBgzRCXPeO4VxmhhRWABrycutQOdwVitvaZo0GLO5DcLy0Oe63
X8ce+P5SqDZYjqBZDtv4AGlUAPcTykzzgNfIvVZHqrZTGSHnC/oQY8Mf+zMOFBSQQR21
oPcxmtsmHEmSQN6tBwOtz12a0EwLRk2fzhYkAiv8chm8woTLY5Qtc+lljDtoMcz41goe
BB2A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1707403013; x=1708007813;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=EBvNXMvqHIgeneCdEqMQSkXCKrcpIv4tatu8hVLwGeE=;
b=XpS0zsmtBtB7URwEgGzSS6RhZNXpiRSzi5H3XQavE/P7WEZD4oqE85lVww805bt9Kw
vC6rNL0Fc5zzGZUe3fyWtLClGV1ogqO56tAjpUw3E/Ag50GWuoNLHy3ugZ6bBxvM6qjg
CNb0gc1PPoCj72cwJNJw5iFL2pUl3loeTQCBYf8GBKhPISEo4VQv+3kFyF3lb1qTN31L
Uj+gCLf19Hy6FmVGnZIYaSoeXp3HE1dl0alkKbL6C7fLpaie5ScysJwZl43U1eM3os7t
rfo2Lyec1Tt3Wd3enfOFMpSzBv2JshqNbzYDuBsLTEaD4xv4dwtdCoCO4GjXGMJcoV+g
ZBuw==
X-Forwarded-Encrypted: i=1;
AJvYcCVMKNTlh07ZzBgvfRgRX88+X/Z/LFPG+1xdcoVUxmK7fpUsLT2CyYuSCQk8ixntUmze214tLmkfNPuGZ7H7JJP7c5DpgTQ=
X-Gm-Message-State: AOJu0YwQ6jDmJik+3sjxBrv0Cu4yaoY7kSMuBjfFR9ciR+Hiq7+2TCDz
n4x4tjpx17dUDoGiNKJAlPftazBYxLINYCDaMUTvF/WUxW3snp/v
X-Google-Smtp-Source: AGHT+IEQRNDmcvFbOmC4JSDHWglIxVvHP8TY5PRcx3GxgNvE4+305o4TU9sotZfA3RZTIQGzsRgkRg==
X-Received: by 2002:a50:f617:0:b0:55f:d7f8:1072 with SMTP id
c23-20020a50f617000000b0055fd7f81072mr2852538edn.3.1707403013136;
Thu, 08 Feb 2024 06:36:53 -0800 (PST)
X-Forwarded-Encrypted: i=1;
AJvYcCW7OVnvYIiJPu+1mYNuqzUyVDkIcxyDXGN9K0ryS2J3TGIwWb9Ot4wv8Z92AFtcPHR9ivCQZ4/jdcOy+aDc5HqBWtMUE0B4yy+Bg3s0JMnzkj/9WtS2aYv129S/Xclad3jQPmLSbBtXHgBifqiNAzHhI9VvEj/Ty6Ma2l03BejywhcjwQClbiex4FsHwRPS43iZkJKr8EMw
Received: from Pro.fritz.box (p4fe3a32a.dip0.t-ipconnect.de. [79.227.163.42])
by smtp.gmail.com with ESMTPSA id
i8-20020a05640200c800b0055ffa94d6b8sm876706edu.31.2024.02.08.06.36.52
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 08 Feb 2024 06:36:52 -0800 (PST)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> (Stefan Monnier via's
message of "Thu, 08 Feb 2024 09:19:43 -0500")
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN>
<jwvsf23qc3u.fsf-monnier+emacs@HIDDEN>
Date: Thu, 08 Feb 2024 15:36:51 +0100
Message-ID: <m2y1bvowe4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68244
Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>,
Dmitry Gutov <dmitry@HIDDEN>, Stefan Monnier <monnier@HIDDEN>,
Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org,
Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@HIDDEN> writes:
> But I think we can do something much simpler: vectors are accepted by
> simply storing in the first field a reference to the actual obarray
> object, so there's no need to play any games and/or share representation
> between vectors and obarray.
Fun fact:
static Lisp_Object
pkg_fake_me_an_obarray (Lisp_Object vector)
{
eassert (VECTORP (vector));
Lisp_Object package = Faref (vector, make_fixnum (0));
if (!PACKAGEP (package))
{
package = pkg_make_package (build_string ("obarray"),
Flength (vector));
Faset (vector, make_fixnum (0), package);
}
return package;
}
Works like a charm :-). And the next pointer in Lisp_Symbol is also
gone.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 8 Feb 2024 14:37:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 08 09:37:20 2024
Received: from localhost ([127.0.0.1]:59411 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rY5Wi-0001YU-G6
for submit <at> debbugs.gnu.org; Thu, 08 Feb 2024 09:37:20 -0500
Received: from lists.gnu.org ([2001:470:142::17]:44936)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gerd.moellmann@HIDDEN>) id 1rY5Wg-0001Wp-0a
for submit <at> debbugs.gnu.org; Thu, 08 Feb 2024 09:37:18 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>)
id 1rY5WL-0006EP-SU
for bug-gnu-emacs@HIDDEN; Thu, 08 Feb 2024 09:36:57 -0500
Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <gerd.moellmann@HIDDEN>)
id 1rY5WK-0000bE-Fb; Thu, 08 Feb 2024 09:36:57 -0500
Received: by mail-ed1-x533.google.com with SMTP id
4fb4d7f45d1cf-56061ad3d3dso1845003a12.1;
Thu, 08 Feb 2024 06:36:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1707403013; x=1708007813; darn=gnu.org;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=EBvNXMvqHIgeneCdEqMQSkXCKrcpIv4tatu8hVLwGeE=;
b=JuX+Nkq6UHV8fDhG7606RDBhFJUuqpkNugCAxKByQYbJTwMUBJF4ScYZIs/zjrxZbe
T+u7FR0ABIeMPh4l2BTxVrllBdAdT30AFipZwSX2D7rq4958Q6Jfv8XWl79NHt/U6Dmj
qYQo0KRh2Wq8PcrkhvAptZsSzKrK/BTdox3oE1Tyrl3jnFahvyjVKL2z0hzVEidgEsV5
HPRqmcHMvHHyfDsVPJYVNw2zVN0cEzGSmDETEzpx9UzysU/UkOywBqxw/yFcP10Gjqs9
tpnvRfCHU1RykFJYFxo+bjN0UM3hTe+NSp8hwl/Ei0L+OvahVC5rMW/bFfB6VNnlTcnr
IqSg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1707403013; x=1708007813;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=EBvNXMvqHIgeneCdEqMQSkXCKrcpIv4tatu8hVLwGeE=;
b=btjlTEehLoK9bZ4KB7itmWrrLl+IiGNjT1ckvMAzrSblXoLezlOx7igDQm2k//Pqfs
js9EzJ+lm1jQXpBAk30SKlU025YgRmRsaxfttHEJsTrqFwTpX6TQg9QjvEllu4CZvhqH
0YApQfF38f+gvjHen+R+dXUdoGSMMLfpOE9mKAilz7EdFSAI3AEb9ecZmn4SKjjnMBiu
0vHICGX/tkO87lC3BTYYiI+H9UuaKEyq1eCAEHP5bFUuZ+3isIAkuu2GDYSBs/bIM6Ls
lhqx6Z7mOoR2GpkY9GvfE3319tbThvFh6+RlhcaNoozq8J9PJ6+17yTtoU5UghKBDb7p
adFg==
X-Forwarded-Encrypted: i=1;
AJvYcCVczWbzke9VwgDaU7w4/zIGlcKvG2oQ4p+daUGfs0G2+rjRfWUWdajLJFzsjfcg1rcXCR74oEANzK9b9gY=
X-Gm-Message-State: AOJu0YwT2JTs3YajcalIQ75e5Qvnh+1ufjoC9FzmhQj1nGxE9RcGj3WE
D4c4MCi0ZuV1fAtRCGpRUs4rbJ40mx0UC+ZELrS0UoeVHdaQz9qIVf0oW5+v9vo=
X-Google-Smtp-Source: AGHT+IEQRNDmcvFbOmC4JSDHWglIxVvHP8TY5PRcx3GxgNvE4+305o4TU9sotZfA3RZTIQGzsRgkRg==
X-Received: by 2002:a50:f617:0:b0:55f:d7f8:1072 with SMTP id
c23-20020a50f617000000b0055fd7f81072mr2852538edn.3.1707403013136;
Thu, 08 Feb 2024 06:36:53 -0800 (PST)
X-Forwarded-Encrypted: i=1;
AJvYcCW7OVnvYIiJPu+1mYNuqzUyVDkIcxyDXGN9K0ryS2J3TGIwWb9Ot4wv8Z92AFtcPHR9ivCQZ4/jdcOy+aDc5HqBWtMUE0B4yy+Bg3s0JMnzkj/9WtS2aYv129S/Xclad3jQPmLSbBtXHgBifqiNAzHhI9VvEj/Ty6Ma2l03BejywhcjwQClbiex4FsHwRPS43iZkJKr8EMw
Received: from Pro.fritz.box (p4fe3a32a.dip0.t-ipconnect.de. [79.227.163.42])
by smtp.gmail.com with ESMTPSA id
i8-20020a05640200c800b0055ffa94d6b8sm876706edu.31.2024.02.08.06.36.52
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 08 Feb 2024 06:36:52 -0800 (PST)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN> (Stefan Monnier via's
message of "Thu, 08 Feb 2024 09:19:43 -0500")
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN>
<jwvsf23qc3u.fsf-monnier+emacs@HIDDEN>
Date: Thu, 08 Feb 2024 15:36:51 +0100
Message-ID: <m2y1bvowe4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2a00:1450:4864:20::533;
envelope-from=gerd.moellmann@HIDDEN; helo=mail-ed1-x533.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>,
Dmitry Gutov <dmitry@HIDDEN>, Stefan Monnier <monnier@HIDDEN>,
Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org,
Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@HIDDEN> writes:
> But I think we can do something much simpler: vectors are accepted by
> simply storing in the first field a reference to the actual obarray
> object, so there's no need to play any games and/or share representation
> between vectors and obarray.
Fun fact:
static Lisp_Object
pkg_fake_me_an_obarray (Lisp_Object vector)
{
eassert (VECTORP (vector));
Lisp_Object package = Faref (vector, make_fixnum (0));
if (!PACKAGEP (package))
{
package = pkg_make_package (build_string ("obarray"),
Flength (vector));
Faset (vector, make_fixnum (0), package);
}
return package;
}
Works like a charm :-). And the next pointer in Lisp_Symbol is also
gone.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 8 Feb 2024 14:20:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 08 09:20:16 2024
Received: from localhost ([127.0.0.1]:59392 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rY5GB-0000sB-Pe
for submit <at> debbugs.gnu.org; Thu, 08 Feb 2024 09:20:16 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46621)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1rY5GA-0000rv-4t
for 68244 <at> debbugs.gnu.org; Thu, 08 Feb 2024 09:20:14 -0500
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D0FA9441804;
Thu, 8 Feb 2024 09:19:53 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1707401992;
bh=MXP7ndE/+uKAg3I4LUcTC66dn+1Ul2vJ+jNHjPKKliw=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=pkRoF4HMHM9UVRyQsWvxOIWGMPTzHwMi8Kwh+tckEXzM6MDbxY5zCxTsa78FBLnze
eWrXJPh0CIS11/oc8HZvVyuY3NZCenjZTVBrodKyi0jEFJWCJFrT+OUvuhEje2VbbT
HHx4256LE6hnCelYjtm74DQl6O9RR8RyAjGEP40ysyrvRGH3qN+rCxA7yk+QVu6hE0
/B12Xu3zapL1A5SVD7OOeu9lf9iNgSB2m0Qh/onWa0KuUTjTyxsWnXoiOm91L0EZ3Z
zO1wzSkELCI20HkaqlOMikELoG3cT38sKL6Cm0/GU2xLOCjI/p0HtHSxLqfUckbztC
ef5p+GWBdVybg==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 696344411F3;
Thu, 8 Feb 2024 09:19:52 -0500 (EST)
Received: from pastel (unknown [104.247.238.113])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2FDEF120483;
Thu, 8 Feb 2024 09:19:52 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Mattias =?windows-1252?Q?Engdeg=E5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> ("Mattias
=?windows-1252?Q?Engdeg=E5rd=22's?= message of "Thu, 8 Feb 2024 10:46:27
+0100")
Message-ID: <jwvsf23qc3u.fsf-monnier+emacs@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN>
Date: Thu, 08 Feb 2024 09:19:43 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.011 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68244
Cc: Gerd =?windows-1252?Q?M=F6llmann?= <gerd.moellmann@HIDDEN>,
Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
68244 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> We should probably do the same for obarrays but those have more low-hanging
> fruit. I'll be back with some changes.
For me, the more important aspect of obarrays is that we should have
a separate obarray type (if it can share code with hash-table, that's
gravy).
Of course, we'd still have to *also* accept plain vectors, sadly.
Some years ago I proposed a patch which changed nothing to the
implementation of obarrays but introduced a new PVEC_OBARRAY which was
used instead of the "PVEC_VECTOR" (and given the variable size of
vectors *and* of those obarrays, these two tags were treated specially).
It suffered from the lack of bits in the word that holds the PVEC_*
tag and the vector's size limiting the size of obarrays to
too-small value.
But I think we can do something much simpler: vectors are accepted by
simply storing in the first field a reference to the actual obarray
object, so there's no need to play any games and/or share representation
between vectors and obarray.
Stefan
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 8 Feb 2024 09:46:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 08 04:46:53 2024 Received: from localhost ([127.0.0.1]:59177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rY0zc-0006ex-TC for submit <at> debbugs.gnu.org; Thu, 08 Feb 2024 04:46:53 -0500 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:61591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rY0za-0006ej-Ks for 68244 <at> debbugs.gnu.org; Thu, 08 Feb 2024 04:46:51 -0500 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-511612e0c57so2738179e87.2 for <68244 <at> debbugs.gnu.org>; Thu, 08 Feb 2024 01:46:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707385590; x=1707990390; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=KgK8VzqF0j6UNVZZUsK9zVrqwYW7Hjinp1qx7rqBBgQ=; b=TjoB5Hr6QBEY57vP/iVCGvxe9zzxT6KM3vuvZqKP/KfJnSlcOHQSdKora0KCrx7LpT 4zFm3uYl+38QlcV6x0C2HeTos3uVNZVhICK9hBamSL/F4jAyP9zLBiXx34g/1LLwWsyD Ni9ZtAI98haUzkkC7N4ydHyvrhLHkJ2N2X0ZJCk/QWx9YiH+MGPaAFnxq6Jy3z32dx1D YroupbCLSDabe6Eq0/Xb9pYtF2AtXwi0OKPsfFtPlJrBMSh2Q8/sQJReGSGJxEUA30nB kdExmybZpLPE2nvO4ruN0CCkWA+MKY3qY6uBvxQn541eT5hsS4XlnrqcWnTO3Xss968i e5xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707385590; x=1707990390; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KgK8VzqF0j6UNVZZUsK9zVrqwYW7Hjinp1qx7rqBBgQ=; b=XPXrwAjN1s6sKZfdWINTk6g8WUG0c6tZ5auRmhi/GjLdPArajTMg9lA+nLGMsmg3SR C60Md6DywLIVQZy/l5kIGAGL6Epp/+scoKx2G0sZ6Y/wNQeKXuDMpUqfkSAKnSHeyR8j xNP3o+cYKu0ddnyRjRUF/PmWwvjh4x4tUT88CaSZtW9Lj9KSYohjk751E2la0EWY9b1U zsiI2N/ezJWURscy0szBWhwi4f/YHaOmbUKVR2n0jKYFFKIIko68vGIlmEIZDJDZNv/o ZkCaIJhtHmQSa2lId20NMrzmpAdJNsDG71otvS4wE6mbxFrFPQTcbj2aniFJBCaxjzaG ZDag== X-Forwarded-Encrypted: i=1; AJvYcCUCPhViMwhTTlpgEQzw/vOVxC/EVnH5Mo97X2PyuhdW+WbJq3jSMV0QXLCDCxYFUPw27t6NyCrpXQdXwpEBQgVgI7NmrPE= X-Gm-Message-State: AOJu0YyszoK0HGEgjLVCQrjo6dt2utcrUV5zkrFAMWxmTVq2kNc/1ESf g1QDXaIU/YT+JX9/u4T6mgn/shXrjbfkDmmr8UNKwo5Z3ojnG9Ve X-Google-Smtp-Source: AGHT+IGJEHFupszqUPKi37irZMKxotXhqsIUsQpEo9ucdCcF8CPb61spkwEvqEr4Ziu/cbgxNkFasA== X-Received: by 2002:ac2:5e8a:0:b0:511:5533:aa32 with SMTP id b10-20020ac25e8a000000b005115533aa32mr5348235lfq.58.1707385589911; Thu, 08 Feb 2024 01:46:29 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWrO7cJMjIS0zDVaXCw8ftFidopf+jLOxq2Ta62udOEs5xPdHU4BXJFIWkT3kM0o0F0NGBDFyOxJQtGdM18ausmb2UfvSBxdcXXVkHea4T0Fu+V5XVUa34jK7Asr+SJdP4D0Kozk4hfcB9BCnWMGeCMUIqSFGSP5eBIMImD1UVh3fd6MvPp Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id fb11-20020a056512124b00b005115317395dsm485096lfb.7.2024.02.08.01.46.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Feb 2024 01:46:29 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> Date: Thu, 8 Feb 2024 10:46:27 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <C1BEAA11-E8F2-46E0-AE21-333ECFB80DF8@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>, Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) I stopped dithering and pushed the Knuth range reduction change to = master. We should probably do the same for obarrays but those have more = low-hanging fruit. I'll be back with some changes.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 23 Jan 2024 09:45:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 23 04:45:04 2024
Received: from localhost ([127.0.0.1]:42217 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rSDL6-0002tu-J8
for submit <at> debbugs.gnu.org; Tue, 23 Jan 2024 04:45:04 -0500
Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]:57385)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <contovob@HIDDEN>) id 1rSDL4-0002t5-0U
for 68244 <at> debbugs.gnu.org; Tue, 23 Jan 2024 04:45:03 -0500
Received: by mail-ej1-x631.google.com with SMTP id
a640c23a62f3a-a2dc7827a97so443876466b.2
for <68244 <at> debbugs.gnu.org>; Tue, 23 Jan 2024 01:44:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=tcd.ie; s=google21; t=1706003091; x=1706607891; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=0nYm+sQsWpYeMHaolR3I+iC21LZzmluMwJak+93FXWs=;
b=QtwbgE4t7LCLF+LcIN8uzzXe2GYjVqN/DNoiwAt/01HAO5uBvHP0iN9RKXOaU6I7RR
DBt4Wb6GBoBPpbDjtw/j9p5pSztNJLqCN7Bl9FFgdxfcM9zpYPkzcfUO8P+er93YMDOB
ZZy3vLOqbGk69WBhR3eC7RBYvBCZF8Ks7pLO/yZNxqMj6nxgZ/edX3yK/VcjgP3wtmYd
VbY32LeBMkudO7u5GETJ3JODrTzYof+r47noZMjvCS360AaM4Dmy4oPJPH24j5e96vjD
s+JzdUjJJ9/hNOGPEyCeU6bpFcTJY78c+ORnQXperHLdNklhn4xrG22jSfrW4XY5+RP/
AepA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1706003091; x=1706607891;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=0nYm+sQsWpYeMHaolR3I+iC21LZzmluMwJak+93FXWs=;
b=OFD/qYS8QwcpVAispneEgqVbtUqfW9jKsAD0RcnxX6HU4VWEj4ZP7AYWQLSYuF/f5o
VrUVVP4DTc6TZw65B6CvLW9qwkLjiVLUzvfxshFuRWwH/82iYisTjyh1qz8nJTUqY/lI
9vDcxdHOMyoPLHiGiLzNSoLCTLhaJ4Syk4/SZbMBuEP6vVp3jCjVAyahmbLqKGmL2eXr
3ALKfcdc4BxckKXdkqyH6/QwfwXzGb+Q6KHMqdVbR77Gr1R1k9md/l0dixP4tJ9JkfmH
JMA3cgIoq6pYSQtZKtQjcllQelTKDlJfSOhDwwroMhQyoHmiihsdqnjCCm0KgtkrcQua
ZvGA==
X-Gm-Message-State: AOJu0Yz8Wt8T9DxbZcAyzA2qt6WslaAsQdsVR+oAsSokfZXtOxJeHyfv
noSSptQAvPxvEz7jrvvkykxq9WTXPJucGYxqJ0zcn0pVEKEmqMWpDJLVX38wCqo=
X-Google-Smtp-Source: AGHT+IHcDBeq317zpOAhUlqnXPSSNJPJinlorZ0gZ3LF6OsO9mJWKfvt3ETuAzCDDLAyMA6ONudBxw==
X-Received: by 2002:a17:906:4346:b0:a28:d608:9a27 with SMTP id
z6-20020a170906434600b00a28d6089a27mr2182241ejm.83.1706003091218;
Tue, 23 Jan 2024 01:44:51 -0800 (PST)
Received: from localhost ([2001:620:618:5c0:2:80b3:0:e5c])
by smtp.gmail.com with ESMTPSA id
19-20020a170906301300b00a26a93731c5sm14161859ejz.111.2024.01.23.01.44.50
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 23 Jan 2024 01:44:50 -0800 (PST)
From: "Basil L. Contovounesios" <contovob@HIDDEN>
To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <CALDnm50TfVU89byQSxDNjfvXsDM4=pr4=V25YbJgPCMp5nZLzg@HIDDEN>
(=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Mon, 22 Jan 2024
09:17:31 +0000")
References: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN>
<878r4iq1n0.fsf@HIDDEN>
<CALDnm50TfVU89byQSxDNjfvXsDM4=pr4=V25YbJgPCMp5nZLzg@HIDDEN>
Date: Tue, 23 Jan 2024 10:44:49 +0100
Message-ID: <8734uos7se.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68244
Cc: 68244 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Jo=C3=A3o T=C3=A1vora [2024-01-22 09:17 +0000] wrote:
> Dine, I guess.
Pushed, and thanks! I'll send you the receipt separately.
> But this is about a singleton hash table object right?
Yes, specifically an empty one.
> Will it work with Emacs 28 and=C2=A029 via GNU Elpa?
Should do:
$ for v in 24.5 25.3 26.3 27.2 28.2 29.1; do
emacs-$v -Q -batch \
-eval '(message "%.2s %s" emacs-version (make-hash-table :size 0))'
done
24 #s(hash-table size 1 test eql rehash-size 1.5 rehash-threshold 0.8 data =
())
25 #s(hash-table size 1 test eql rehash-size 1.5 rehash-threshold 0.8 data =
())
26 #s(hash-table size 1 test eql rehash-size 1.5 rehash-threshold 0.8125 da=
ta ())
27 #s(hash-table size 1 test eql rehash-size 1.5 rehash-threshold 0.8125 da=
ta ())
28 #s(hash-table size 1 test eql rehash-size 1.5 rehash-threshold 0.8125 da=
ta ())
29 #s(hash-table size 1 test eql rehash-size 1.5 rehash-threshold 0.8125 da=
ta ())
--=20
Basil
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 22 Jan 2024 09:18:59 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 22 04:18:59 2024 Received: from localhost ([127.0.0.1]:39879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rRqSI-0007Gg-Su for submit <at> debbugs.gnu.org; Mon, 22 Jan 2024 04:18:59 -0500 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:51671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1rRqSF-0007GQ-F6 for 68244 <at> debbugs.gnu.org; Mon, 22 Jan 2024 04:18:57 -0500 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50edf4f478eso3687268e87.3 for <68244 <at> debbugs.gnu.org>; Mon, 22 Jan 2024 01:18:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705915125; x=1706519925; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KWfOkIflVGS7B9fjxGlZrPRQ4DhFrzvKe2MKbdAN7Gs=; b=H9fCd1JPJfB2iIxq/pD/MCJLgqlEpSvUcNOQLqVExEyqaHa5s7psdFUptIqJbvEb9V LNB9SXcvtB28+iU0yuI1CTkBi75BvSoWZraG6dsqQ9+NMqggP66U5/750qCbiI3maTD5 dIbTubIqKIp/TCz1bgTQnYUnNiKu65c2eyweMP0ej8uwZZQEYg30IskmINXP1VnFdoxj 0U+G2eZPnjhCUHmQBoHrtbSfnIe5HfNz4WzpHtDjKpkVuEX3A3R3gYP6q456rcKJ2FNa m99o/T8m2txcDKGM7feWGvxwc9h59Zp6vvsvf3WOyMIxdil77/8EgmnPRjErncf7Frke 925Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705915125; x=1706519925; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KWfOkIflVGS7B9fjxGlZrPRQ4DhFrzvKe2MKbdAN7Gs=; b=muCy0xwA4QHLir5pw9VELRy9QhU24QvZbarmwke17XP8pkm8w/n/O3yM1z8anHgm+G IjYb+ITFGa2z2KSqWiuuba+vQlGbA2WzPjVhWRD1uduYmxX3djehD6nBv0ZEJ5Dc36wU CbQlRS8Gt381qDCu/a+J3FWxlgIZR2Q3G4AwnnnR2fO8B76dPn83626xeFEkeu7w1hp3 PjecSiVU/KXG+UqnPNHUoEMQSksJCWazhug4o7FALDuaMIRWgp9zXbkecH5y5YNJWGRP YwxCmgRFFycaje0wNgKdUyOeqdRQ2m/4E8ZCMKwA9ve1QQsYzSo5cO/jARD45K5aA8su FMhw== X-Gm-Message-State: AOJu0Yzo1aDAOQ0W4Z8TSEXtrjUc5pJGoBgBXIty0TN0rQYM6k/W+boq vr5Kj7cRvj32iMBYZbo9/AWNh6Ie2gA986bds9QcqsLraq3iQe4zul/J2YEyKoK77E/39Bc3dyh 2IFvpx1PP4BhEGL6w/SX7jwfn7CQ= X-Google-Smtp-Source: AGHT+IGyOhLL38SPyO39CReVgHgiz+lAIg9CWE4GcmNqHKlfgPrUtjO7/jkNqXf3mxPe+h1f/YEI2eKLR2xcsC1QRy0= X-Received: by 2002:a05:6512:3e0b:b0:50f:2190:c00 with SMTP id i11-20020a0565123e0b00b0050f21900c00mr1508788lfv.101.1705915125449; Mon, 22 Jan 2024 01:18:45 -0800 (PST) MIME-Version: 1.0 References: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN> <878r4iq1n0.fsf@HIDDEN> <CALDnm50TfVU89byQSxDNjfvXsDM4=pr4=V25YbJgPCMp5nZLzg@HIDDEN> In-Reply-To: <CALDnm50TfVU89byQSxDNjfvXsDM4=pr4=V25YbJgPCMp5nZLzg@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Mon, 22 Jan 2024 09:18:33 +0000 Message-ID: <CALDnm51CseomjGEtfmqToqYrR3pKFTRxOmOdd0GBGUkHUpUNwg@HIDDEN> Subject: Re: bug#68244: hash-table improvements To: "Basil L. Contovounesios" <contovob@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>, 68244 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Mon, Jan 22, 2024 at 9:17=E2=80=AFAM Jo=C3=A3o T=C3=A1vora <joaotavora@g= mail.com> wrote: > Dine, I guess. But this is about a singleton hash table object right? Yes, you should probably "dine" regularly as much as possible. But this change is also "fine".
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 22 Jan 2024 09:18:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 22 04:18:01 2024 Received: from localhost ([127.0.0.1]:39876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rRqRL-0007FC-VX for submit <at> debbugs.gnu.org; Mon, 22 Jan 2024 04:18:01 -0500 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]:47266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1rRqRG-0007Eu-AX for 68244 <at> debbugs.gnu.org; Mon, 22 Jan 2024 04:17:58 -0500 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-50e72e3d435so2536014e87.2 for <68244 <at> debbugs.gnu.org>; Mon, 22 Jan 2024 01:17:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705915064; x=1706519864; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=g5byEm4lS2ER0LI0Ns5ugyzc83Sxa6IczsRMNfckdvA=; b=CdiwKp2tmXu9K5gqJcte+KfzbkmY5V6LiSPmq50oQvNhOMdSoTbzuXsONRyQLWZKmS D0+uKFIFX76QVqQiowG5i3DVD5j2uDl+0Rnm0jIRX/DVPbEuZwfg3kk5IcDyoaMgJiCV 93rLCD1ordVjRzG1aWZans10Poa9cDIHMRHKo7FVfDNLBg+rL9nMBxauGWPeJYjCpeLZ DGdhqW3feDLvNHzkIc7jtPM2z41na7n/3ULdEP+jyUHkAAJH8Bf6Y/gVWjCmAlQ73FN5 uQwCuIixem/ij9blBTGXghHbiNso8MqkwaP4tom4tZUnC1OmdqX7bjHCFTGOzo6SDdPu azEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705915064; x=1706519864; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g5byEm4lS2ER0LI0Ns5ugyzc83Sxa6IczsRMNfckdvA=; b=Emf8iCgkQI6x4tCGTS/wa0k4sFkupvZISXGBYJ0GSG+aMwfbnhEWJPbmCniQehJ1UW RkvbxfS7NZYDj311b8vz2XSND4A82pSJdv0Y2jLpo7+Z+J0GLInGWM+cMm1KU/IVGHT7 LL+RbidJeWpUBk7XA+AKXCMIwFmrdSREB3KvENuI/NgJY/nLOiLeRh4x8RjuBCSOFnDi Ux8M8ZGjm424N31b3nVKv3Tiijk4LRW9Ravf0ObePzo1CTVmL8RBULNe5hifkvQPFEOD byZbbzmnia5lNx6sqyrGGveHQkspsmREQ8PV44+hnCbRMUb7Qp3J+nnN9QgG4RGXx1ts k25Q== X-Gm-Message-State: AOJu0YyA6hCT/NSQZLmUdHv08SCjbyufoMiEM+XR5KUfL0bT8kLY/khj Gp6p8uJnetLqcZu8pCcIsE9lUAm1fJ8+QJe4Vihs8f6rNkykFWiwaVQQSomXUlnFyACTxnWe/c3 2KPdcXbhWbXTtUi3zIb2bhBDd/bs= X-Google-Smtp-Source: AGHT+IFycFQW9MztCCHBo+CwZIqG6IWsY1GgtN+lTom7ZSBhD8zHYSxU0WD8wDS4Vy/hsDOdFgEy1pHxOjN/xQo6b+c= X-Received: by 2002:a05:6512:3d1c:b0:50e:8eca:a162 with SMTP id d28-20020a0565123d1c00b0050e8ecaa162mr1194123lfv.113.1705915063776; Mon, 22 Jan 2024 01:17:43 -0800 (PST) MIME-Version: 1.0 References: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN> <878r4iq1n0.fsf@HIDDEN> In-Reply-To: <878r4iq1n0.fsf@HIDDEN> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Date: Mon, 22 Jan 2024 09:17:31 +0000 Message-ID: <CALDnm50TfVU89byQSxDNjfvXsDM4=pr4=V25YbJgPCMp5nZLzg@HIDDEN> Subject: Re: bug#68244: hash-table improvements To: "Basil L. Contovounesios" <contovob@HIDDEN> Content-Type: multipart/alternative; boundary="00000000000064b9ca060f854d5d" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>, 68244 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --00000000000064b9ca060f854d5d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jan 21, 2024, 13:03 Basil L. Contovounesios <contovob@HIDDEN> wrote= : > Mattias Engdeg=C3=A5rd [2024-01-04 17:27 +0100] wrote: > > > It's the hash-table's turn to be subjected to some performance tuning. > > Thanks! > > > The implementation has changed very little over the years and it's not > > so much a matter of a single big thing to fix as many small ones, so > > the list of changes is fairly long but ever little helps. > > Jo=C3=A3o, is this tiny additional straw okay for the camel's back? > Dine, I guess. But this is about a singleton hash table object right? Will it work with Emacs 28 and 29 via GNU Elpa? Jo=C3=A3o > --00000000000064b9ca060f854d5d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"auto"><div><div class=3D"gmail_quote"><div dir= =3D"ltr" class=3D"gmail_attr">On Sun, Jan 21, 2024, 13:03 Basil L. Contovou= nesios <<a href=3D"mailto:contovob@HIDDEN" target=3D"_blank">contovob@tc= d.ie</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"mar= gin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Mattias Engdeg= =C3=A5rd [2024-01-04 17:27 +0100] wrote:<br> <br> > It's the hash-table's turn to be subjected to some performance= tuning.<br> <br> Thanks!<br> <br> > The implementation has changed very little over the years and it's= not<br> > so much a matter of a single big thing to fix as many small ones, so<b= r> > the list of changes is fairly long but ever little helps.<br> <br> Jo=C3=A3o, is this tiny additional straw okay for the camel's back?<br>= </blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">Dine= , I guess.=C2=A0 But this is about a singleton hash table object right?</di= v><div dir=3D"auto"><span style=3D"font-family:Arial,Helvetica,sans-serif">= Will it work with Emacs 28 and=C2=A029 via GNU Elpa?</span><br></div><div d= ir=3D"auto"><span style=3D"font-family:Arial,Helvetica,sans-serif"><br></sp= an></div><div><span style=3D"font-family:Arial,Helvetica,sans-serif">Jo=C3= =A3o</span></div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote c= lass=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;= padding-left:1ex"> </blockquote></div></div></div> </div> --00000000000064b9ca060f854d5d--
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 21 Jan 2024 13:04:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 21 08:04:06 2024
Received: from localhost ([127.0.0.1]:36730 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rRXUb-0000oJ-M2
for submit <at> debbugs.gnu.org; Sun, 21 Jan 2024 08:04:06 -0500
Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:58568)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <contovob@HIDDEN>) id 1rRXUX-0000nK-9D
for 68244 <at> debbugs.gnu.org; Sun, 21 Jan 2024 08:04:03 -0500
Received: by mail-wm1-x32f.google.com with SMTP id
5b1f17b1804b1-40e72a567eeso28143515e9.0
for <68244 <at> debbugs.gnu.org>; Sun, 21 Jan 2024 05:03:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=tcd.ie; s=google21; t=1705842232; x=1706447032; darn=debbugs.gnu.org;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=DGCTCKZlIhy2+EPwsQ3XT1gdsYYB8DBrLiSq4wCaCVA=;
b=I6y1fBCP9bhokXb6x3GR9tCItYRM/Z+LPxBsqzuWbq7O7y71brbtDFDluNGsag5mWc
oK0rgr1jrnrapNJLu9mvCTVn6E+o+usNv5QVHNVennryQ8lXN23yQwMOJe1e6SsbL981
XCAmV/viY5RPTd584o3qSv0dG0aBLzD57ifFB0QgAeX+LIYHTW4C/xQWLVqD8l/A62/E
7ZM1CIjBuVVdv65ACHJkYkNEPiulvfy4DT0b859is58/vbSV61kHDtq3WvpYig0ffOdr
lTvfqpURgcSTaxYFVCB15k7Whn4u1EUj+1CHuEtkf8MqRkBnSBhwLs4/recZQDfCElFz
O4Sg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1705842232; x=1706447032;
h=mime-version:user-agent:message-id:date:references:in-reply-to
:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
:message-id:reply-to;
bh=DGCTCKZlIhy2+EPwsQ3XT1gdsYYB8DBrLiSq4wCaCVA=;
b=PJi3yMqzY/NRYAuyxMHS17WD71sgNFAG7Dz2KYcbQO4hGQNfEKHHaQO/Qhii2phVs7
8KZuCTCpMAGmIZK2l47/n3FPF8LiX+8EEe+FoMsML7JgFVoornaBuj2TV1eGjjFj6Nui
er51vd/p3jFwNK0NvAnoneARpNz8eiirpHbOeJjjC4RhVi5IQAzTAuiZINuHTlDNldbK
M/M6lwen6mKcifF7cgiTMy9CLJvwb0YpBWghN14COYqKTiz7Ro9aoYjG4TQsTzXtHwfk
URTkBBNimPZO/efp9zze52HvbHCmEdjxF3iq0j8Iko5Ab+fzjOFXYFL8vPzHcai0BRmB
dn7A==
X-Gm-Message-State: AOJu0Ywz2xDjO2+SzV4MoYT0MCqzMaSs0AE7RAmhnHQrD9BIWvoTSpJd
Vfl1kCk6OYw0dgUnb4LD4nKIDgnsxTvFkHh8J9rThtQi3ky/D0sfyu4j/CHJvlU=
X-Google-Smtp-Source: AGHT+IHTkalKPB223V1tmYSzU7El4ux/13+zjMGij77Ori6QIUz5rp605KfTrWhkIzyRapXJpdanIQ==
X-Received: by 2002:a05:600c:540b:b0:40e:66cc:46e6 with SMTP id
he11-20020a05600c540b00b0040e66cc46e6mr765270wmb.181.1705842231694;
Sun, 21 Jan 2024 05:03:51 -0800 (PST)
Received: from localhost (mob-194-230-158-42.cgn.sunrise.net. [194.230.158.42])
by smtp.gmail.com with ESMTPSA id
b9-20020ac25e89000000b0050e7410d284sm1623587lfq.248.2024.01.21.05.03.50
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 21 Jan 2024 05:03:50 -0800 (PST)
From: "Basil L. Contovounesios" <contovob@HIDDEN>
To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN> ("Mattias
=?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Thu, 4 Jan 2024 17:27:53
+0100")
References: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN>
Date: Sun, 21 Jan 2024 14:03:47 +0100
Message-ID: <878r4iq1n0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68244
Cc: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>,
68244 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mattias Engdeg=C3=A5rd [2024-01-04 17:27 +0100] wrote:
> It's the hash-table's turn to be subjected to some performance tuning.
Thanks!
> The implementation has changed very little over the years and it's not
> so much a matter of a single big thing to fix as many small ones, so
> the list of changes is fairly long but ever little helps.
Jo=C3=A3o, is this tiny additional straw okay for the camel's back?
--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=0001-Further-shrink-eglot.patch
From 359e5d5b90754373ff8a2db6431421d7838c113b Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@HIDDEN>
Date: Fri, 19 Jan 2024 13:50:29 +0100
Subject: [PATCH] Further shrink eglot--{}
Up to and including Emacs 29, :size 0 was an alias for :size 1.
Emacs 30 gained support for :size 0 hash tables (bug#68244).
* lisp/progmodes/eglot.el (eglot--{}): Define as truly zero-sized.
---
lisp/progmodes/eglot.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index c5cfdd3cedd..511000927cf 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -575,7 +575,7 @@ eglot--tag-faces
(defvaralias 'eglot-{} 'eglot--{})
-(defconst eglot--{} (make-hash-table :size 1) "The empty JSON object.")
+(defconst eglot--{} (make-hash-table :size 0) "The empty JSON object.")
(defun eglot--executable-find (command &optional remote)
"Like Emacs 27's `executable-find', ignore REMOTE on Emacs 26."
--
2.43.0
--=-=-=
Content-Type: text/plain
--
Basil
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 21 Jan 2024 12:41:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 21 07:41:25 2024 Received: from localhost ([127.0.0.1]:36720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rRX8f-00007w-98 for submit <at> debbugs.gnu.org; Sun, 21 Jan 2024 07:41:25 -0500 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]:52242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1rRX8b-00007h-I9 for 68244 <at> debbugs.gnu.org; Sun, 21 Jan 2024 07:41:24 -0500 Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2cd33336b32so29056341fa.0 for <68244 <at> debbugs.gnu.org>; Sun, 21 Jan 2024 04:41:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705840872; x=1706445672; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=LrGc4cZPq5l80FkiDAiDzO1pU74WtLVki3/0eLg/PV8=; b=QiZqwKPbmQA+pMIFvGOPhwnssuMMTQrHZwu+PyfIa6SbxRwX/bo/Om8D+fTWFDFJFQ xshpkeDBztOtegY2W2UuioaKRVG8dws+iQCtWPg/LoO6nCifYsQuDScGjZP3r3fqDtqu 5+qjwGC3ET5zn4iQZ8JQxnVQhrXFESi19lKmJo12RlrN20t1FbN9RjWguG9driOvFOjC q/oo6pG69A1HHpxSoiMrOPTcoePwbdWG2BvnLkwPC0LgpBaIM/X4vlNUg8f+Ldtjvpzg 4linxS9bUjbGct9YesviO+GhhdsoA60zytuApqHQ15aaL2JHfbnFzapGP0RGmM9nHgey q1+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705840872; x=1706445672; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LrGc4cZPq5l80FkiDAiDzO1pU74WtLVki3/0eLg/PV8=; b=YgiBxpkTmo8Y1OLhDGAeE5zeJQBbTnLYA7w0d9GszTg2rNgSzdklZzQahvsw25a/9+ 0bKgCNh5Txd7+R6iZNQwqdp38jyBFxjuS5aYJmMnc4hng72pGXe6c0tnzG84dN8c1dEb 7+2kNhpRk9IR9GAdCclZ6Mnj2rbMkdRo5/Dq3jwwh6vDizpL3U0/qKrzN9KFlpIPdUz6 vxkSo2LbcWwf4yP5UYSJLlfwp7OJt/z0j3+n/o0PU8369yvsn85Y0sUThOetIu4/JYGU HuEO/mSD2vV3k9ZL4igERCX5T1qO4UQapPAA8wsukEEwlpRSM4O2RmD2ueJ7e2NhkMnM 2aDA== X-Gm-Message-State: AOJu0YwZ9AdQLl55ZRxrhJnlbPJ/GIgotKx7jKhRFCqki+YeYGVTKei+ eMsoBBbaOf8HxdJkpKcu4kagv1vEsXz236qzCSS7V311SFdYBMYjK54Z1S8D5KMAU+/beD4yqfg HLvK8SNCm3ofFFYzOUlYTjMoOsgI= X-Google-Smtp-Source: AGHT+IGg1yDFPgKCPXz8ekaFA4qc7ReepvwQKlELw0FsNUx7em2EG5+HYKI2btgkwwVcCfQ/H8CBhVIyY7z6xi6lTrM= X-Received: by 2002:a2e:bba1:0:b0:2cd:9f09:1367 with SMTP id y33-20020a2ebba1000000b002cd9f091367mr858886lje.82.1705840871857; Sun, 21 Jan 2024 04:41:11 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 21 Jan 2024 06:41:11 -0600 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> MIME-Version: 1.0 Date: Sun, 21 Jan 2024 06:41:11 -0600 Message-ID: <CADwFkmke_TNO9a-NMo341inqDpi7-TcqHHvtFqCB3edw42d3yg@HIDDEN> Subject: Re: bug#68244: hash-table improvements To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>, Stefan Monnier <monnier@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd <mattias.engdegard@HIDDEN> writes: > Maybe we should promote equal-including-properties to a first-class > hash table test? It's defined as a user test in two places in the > Emacs tree, and user tests are much slower than built-in ones. It might be worth a try. I see that it's used in the native compiler, for example, and we're obviously very happy if we can make that stuff more performant.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 21 Jan 2024 05:11:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 21 00:11:48 2024 Received: from localhost ([127.0.0.1]:36344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rRQ7Y-0007Ua-Ij for submit <at> debbugs.gnu.org; Sun, 21 Jan 2024 00:11:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rRQ7W-0007UJ-3S for 68244 <at> debbugs.gnu.org; Sun, 21 Jan 2024 00:11:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rRQ7M-0002P3-QF; Sun, 21 Jan 2024 00:11:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=k4HVNctfjUk1kI8peMffLb2neXvedivTNEaqtpPe2XU=; b=I51GRYbzrTPE QWZyOlU1VSTn6W3JpPayH+tJ8RoVeJ5CvFkSMhY+XqprpcBrxuhvcRL4SibWO0MOYCT/18TNvOJ3U iGQ4Q1ILRDoo17V8IY/jFVnTMb/21piL2aJYGq6K3laYfGAf3V3o0DPA+Hy11Ho1Va3YdSR3eSiRq lVzg+mODkk3S2wrGXgKJAiBIAfIC6tps2PNx+DZFZOHWlQKcu7vBVvqTcELI5vBZcpqvQjoG6kYVC iXltjtiP3WNeAgm462MSqn0XU+YMfjgo4JbAtpfQgLHqqMBcpUV1xINmtImWy8gPsrNHJHyARA/uM qSO0GQOX/0RY2Y047+TLfQ==; Date: Sun, 21 Jan 2024 07:11:12 +0200 Message-Id: <83le8js233.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Andy Moreton <andrewjmoreton@HIDDEN> In-Reply-To: <86zfwzzrh2.fsf@HIDDEN> (message from Andy Moreton on Sat, 20 Jan 2024 20:20:57 +0000) Subject: Re: bug#68244: hash-table improvements References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <86cyu37elt.fsf@HIDDEN> <83h6jeeq1z.fsf@HIDDEN> <BEF1A1B1-A295-44C8-96C1-29809C77B62A@HIDDEN> <70205AB6-275B-49C6-83AD-C90D843F8B5F@HIDDEN> <86a5p2idvj.fsf@HIDDEN> <83ttn9x20h.fsf@HIDDEN> <86zfwzzrh2.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68244 Cc: 68244 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Andy Moreton <andrewjmoreton@HIDDEN> > Date: Sat, 20 Jan 2024 20:20:57 +0000 > > I can no longer reproduce the problems on master or on emacs-29 with > ENABLE_CHECKING. OK, thanks. > I still get a few backtraces repeatably when bootstrapping a native > build on the emacs-28 branch, but I suspect that is not of much interest > any more. Right. If you want to be able to compile that branch anyway, my suggestion is to lower native-comp-speed to 1.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 20 Jan 2024 20:21:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 20 15:21:22 2024
Received: from localhost ([127.0.0.1]:35873 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rRHqE-0003YP-HY
for submit <at> debbugs.gnu.org; Sat, 20 Jan 2024 15:21:22 -0500
Received: from lists.gnu.org ([2001:470:142::17]:56528)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rRHqB-0003Y8-J8
for submit <at> debbugs.gnu.org; Sat, 20 Jan 2024 15:21:21 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rRHq0-00064a-U3
for bug-gnu-emacs@HIDDEN; Sat, 20 Jan 2024 15:21:10 -0500
Received: from ciao.gmane.io ([116.202.254.214])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rRHpz-0001yZ-MP
for bug-gnu-emacs@HIDDEN; Sat, 20 Jan 2024 15:21:08 -0500
Received: from list by ciao.gmane.io with local (Exim 4.92)
(envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rRHpv-0007Mq-Bx
for bug-gnu-emacs@HIDDEN; Sat, 20 Jan 2024 21:21:03 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: bug-gnu-emacs@HIDDEN
From: Andy Moreton <andrewjmoreton@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
Date: Sat, 20 Jan 2024 20:20:57 +0000
Message-ID: <86zfwzzrh2.fsf@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<86cyu37elt.fsf@HIDDEN> <83h6jeeq1z.fsf@HIDDEN>
<BEF1A1B1-A295-44C8-96C1-29809C77B62A@HIDDEN>
<70205AB6-275B-49C6-83AD-C90D843F8B5F@HIDDEN>
<86a5p2idvj.fsf@HIDDEN> <83ttn9x20h.fsf@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Gnus/5.13 (Gnus v5.13)
Cancel-Lock: sha1:y15/5nOdW/1baD89hJCTAM5ANlY=
Received-SPF: pass client-ip=116.202.254.214;
envelope-from=geb-bug-gnu-emacs@HIDDEN; helo=ciao.gmane.io
X-Spam_score_int: 5
X-Spam_score: 0.5
X-Spam_bar: /
X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001,
FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001,
HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.5 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Fri 19 Jan 2024, Eli Zaretskii wrote: >> From: Andy Moreton
>> Date: Thu, 18 Jan 2024 20:29:52 +0000 >> >> On Thu 18 Jan 2024, Mattias
Engdegård wrote: >> >> > I still don't know what problems you observed but
have now committed fixes f [...]
Content analysis details: (1.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
mail domains are different
0.0 T_SPF_PERMERROR SPF: test of record failed (permerror)
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received'
headers
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (andrewjmoreton[at]gmail.com)
-0.0 T_SCC_BODY_TEXT_LINE No description available.
0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
EnvelopeFrom freemail headers are
different
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.5 (/)
On Fri 19 Jan 2024, Eli Zaretskii wrote:
>> From: Andy Moreton <andrewjmoreton@HIDDEN>
>> Date: Thu, 18 Jan 2024 20:29:52 +0000
>>
>> On Thu 18 Jan 2024, Mattias Engdegård wrote:
>>
>> > I still don't know what problems you observed but have now committed fixes for
>> > two other assertion failures to master, ef01250e and e7a6ce84. Andy, did they
>> > help?
>>
>> I am begining to suspect a toolchain problem, as I see backtraces when
>> bootstrapping emacs-28 and emacs-29 native (.eln) builds, but not when
>> bootstrapping a non-native (.elc) build.
>
> Do the backtraces follow an assertion violation? Or are those crashes
> (as opposed to aborts)?
>
> Can you show a couple of examples, please?
I can no longer reproduce the problems on master or on emacs-29 with
ENABLE_CHECKING.
I still get a few backtraces repeatably when bootstrapping a native
build on the emacs-28 branch, but I suspect that is not of much interest
any more.
AndyM
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 19 Jan 2024 06:37:29 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 19 01:37:29 2024 Received: from localhost ([127.0.0.1]:57281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rQiVA-00045w-4a for submit <at> debbugs.gnu.org; Fri, 19 Jan 2024 01:37:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rQiV8-00045j-Ay for 68244 <at> debbugs.gnu.org; Fri, 19 Jan 2024 01:37:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rQiV0-00037v-Od; Fri, 19 Jan 2024 01:37:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=n8eiunjTFzXtKmb8dxokqxGVNGmAG24aZETF6at4wxo=; b=BRYIy/kqJtAWyKqWMhy3 CaTgr8/CWykPASeECdAksiTmznXPrEZrtYXPQt0pumXMDdc5VXGNxZwYKiNc00oZEcZJxstQoUen7 V/ImpANifM/5i83Vpc2iMjdZrPPq9O9PjDLTW3Kd9/K/1VhALl8rwkGSnXpF6KkFvjCdbUw6BE3AW j6fBJl1+oZrooTPqqi5cBg2a9X12WXYIBkPpxTqGqjst+QAQakwaY52nJZNQff6ptwEtgEX5nstw/ XXZrnRSxFCryfpAjvS4Es3N2b3Kt7KUj1eV85XVjituVDSO3AaRLCCLQmGbTbfQsLiqVOXU7OyVDw OFgwCbT/2MY6rA==; Date: Fri, 19 Jan 2024 08:37:02 +0200 Message-Id: <83ttn9x20h.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Andy Moreton <andrewjmoreton@HIDDEN> In-Reply-To: <86a5p2idvj.fsf@HIDDEN> (message from Andy Moreton on Thu, 18 Jan 2024 20:29:52 +0000) Subject: Re: bug#68244: hash-table improvements References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <86cyu37elt.fsf@HIDDEN> <83h6jeeq1z.fsf@HIDDEN> <BEF1A1B1-A295-44C8-96C1-29809C77B62A@HIDDEN> <70205AB6-275B-49C6-83AD-C90D843F8B5F@HIDDEN> <86a5p2idvj.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68244 Cc: 68244 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Andy Moreton <andrewjmoreton@HIDDEN> > Date: Thu, 18 Jan 2024 20:29:52 +0000 > > On Thu 18 Jan 2024, Mattias Engdegård wrote: > > > I still don't know what problems you observed but have now committed fixes for > > two other assertion failures to master, ef01250e and e7a6ce84. Andy, did they > > help? > > I am begining to suspect a toolchain problem, as I see backtraces when > bootstrapping emacs-28 and emacs-29 native (.eln) builds, but not when > bootstrapping a non-native (.elc) build. Do the backtraces follow an assertion violation? Or are those crashes (as opposed to aborts)? Can you show a couple of examples, please?
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 18 Jan 2024 20:30:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 18 15:30:13 2024
Received: from localhost ([127.0.0.1]:56786 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rQZ1h-00041x-6U
for submit <at> debbugs.gnu.org; Thu, 18 Jan 2024 15:30:13 -0500
Received: from lists.gnu.org ([2001:470:142::17]:48048)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rQZ1f-0003k2-69
for submit <at> debbugs.gnu.org; Thu, 18 Jan 2024 15:30:11 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rQZ1X-0000Wz-TN
for bug-gnu-emacs@HIDDEN; Thu, 18 Jan 2024 15:30:03 -0500
Received: from ciao.gmane.io ([116.202.254.214])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rQZ1W-0007Wx-KS
for bug-gnu-emacs@HIDDEN; Thu, 18 Jan 2024 15:30:03 -0500
Received: from list by ciao.gmane.io with local (Exim 4.92)
(envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rQZ1T-000AUJ-AK
for bug-gnu-emacs@HIDDEN; Thu, 18 Jan 2024 21:29:59 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: bug-gnu-emacs@HIDDEN
From: Andy Moreton <andrewjmoreton@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
Date: Thu, 18 Jan 2024 20:29:52 +0000
Message-ID: <86a5p2idvj.fsf@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<86cyu37elt.fsf@HIDDEN> <83h6jeeq1z.fsf@HIDDEN>
<BEF1A1B1-A295-44C8-96C1-29809C77B62A@HIDDEN>
<70205AB6-275B-49C6-83AD-C90D843F8B5F@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (windows-nt)
Cancel-Lock: sha1:rFYYAARvbqKsK6j3QSxrDHZsJ1g=
Received-SPF: pass client-ip=116.202.254.214;
envelope-from=geb-bug-gnu-emacs@HIDDEN; helo=ciao.gmane.io
X-Spam_score_int: 5
X-Spam_score: 0.5
X-Spam_bar: /
X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001,
FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001,
HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.5 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Thu 18 Jan 2024, Mattias Engdegård wrote: > I still don't
know what problems you observed but have now committed fixes for > two other
assertion failures to master, ef01250e and e7a6ce84. Andy, did they > help?
Content analysis details: (1.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
mail domains are different
0.0 T_SPF_PERMERROR SPF: test of record failed (permerror)
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received'
headers
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (andrewjmoreton[at]gmail.com)
-0.0 T_SCC_BODY_TEXT_LINE No description available.
0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
EnvelopeFrom freemail headers are
different
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.5 (/)
On Thu 18 Jan 2024, Mattias Engdegård wrote:
> I still don't know what problems you observed but have now committed fixes for
> two other assertion failures to master, ef01250e and e7a6ce84. Andy, did they
> help?
I am begining to suspect a toolchain problem, as I see backtraces when
bootstrapping emacs-28 and emacs-29 native (.eln) builds, but not when
bootstrapping a non-native (.elc) build.
AndyM
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 18 Jan 2024 18:13:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 18 13:13:35 2024 Received: from localhost ([127.0.0.1]:56617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rQWtT-0000mq-F6 for submit <at> debbugs.gnu.org; Thu, 18 Jan 2024 13:13:35 -0500 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:57840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rQWtR-0000mX-IF for 68244 <at> debbugs.gnu.org; Thu, 18 Jan 2024 13:13:34 -0500 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2cdeb808889so28476231fa.3 for <68244 <at> debbugs.gnu.org>; Thu, 18 Jan 2024 10:13:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705601606; x=1706206406; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=FL7hM5N4qKVcobsYZAj2M/4pW+bZYuOoy3qPDgPoweY=; b=JzpiuchxrtNTaUhZn2SecoAqeV3gmr3WfU12MJX7LDEvlsVw/RlvT/7kMi8an2Bf8s NTu84mKMecqnGtOa7GvSoW+phaK0R4WowWUHnsDwcP5BBHYUsxutGDRx9nnxWK6kdJwV DTSdRvUAMio1xKe+LZhDCoHDAcdkSwNIO8mBlOHpf/eB6wQHBQpr551S5Ratafc9FVuW C9oNsaGDRFkbVo/PMqwYw+FczT3X8/1ljN7efGRV4DAUKYsGKHoFgu30PaXhWIMdAnzs Kt8VIskBNOlhSTah6jAg2QyUNVHcEbKvHn9AujDGrdGYPYjB7qwSIP2gyDsANbe58bNV Gkew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705601606; x=1706206406; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FL7hM5N4qKVcobsYZAj2M/4pW+bZYuOoy3qPDgPoweY=; b=Uzr6agcPdZ9cjApkqaLY16hCg5UQDl9L5lPqAhn3rOHG8c31riUyQ7ToT1EFbIK2lY 5LMxnlJr58Q/r6oDZlBgRMXGPqUyvRhF0hNYoSIuqL4AUXcqGExZ2rMNOIGmwaJVYD+u 7d09ez8HZ+kPSD9s5GcQV3C9scEp9eRmmChyn/R68hlHzjaejeB/jTRzHtxZBgvOU31P +yiRAa77a9v3nYCgIVTiUomzKRyAg1U31Es6Ea+UH9AJ16GNeCfF5d76PJ/rPB5xYS86 /64gh0NOeSIsPq14w1AsuVs3FS0bfGHlY8tQF3jVvYZ2wHTpeSgvQOmcupRjWHxVUCFf V97w== X-Gm-Message-State: AOJu0Yy/TkgYlXkd7UquMeJttC2zCD/tH23/yFaJlFkKPxZ6kR4kNLwY tc/Pp/Pe0lisHoOSqjPE8gOA9Mf2nPHTINjeLVgpGeXe+6NBxJmh X-Google-Smtp-Source: AGHT+IHcS/sAqxdBAVKKFXV+MgEOIH5JtKV4b9AvThVkn6SrNVSQCM6tdTpouxeCItaNqZ3dMblz2g== X-Received: by 2002:a05:651c:1310:b0:2cc:f1ea:aa6b with SMTP id u16-20020a05651c131000b002ccf1eaaa6bmr728404lja.78.1705601605608; Thu, 18 Jan 2024 10:13:25 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id g23-20020a2e9cd7000000b002cca3325adasm2307264ljj.78.2024.01.18.10.13.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jan 2024 10:13:24 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <BEF1A1B1-A295-44C8-96C1-29809C77B62A@HIDDEN> Date: Thu, 18 Jan 2024 19:13:23 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <70205AB6-275B-49C6-83AD-C90D843F8B5F@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <86cyu37elt.fsf@HIDDEN> <83h6jeeq1z.fsf@HIDDEN> <BEF1A1B1-A295-44C8-96C1-29809C77B62A@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: 68244 <at> debbugs.gnu.org, Andy Moreton <andrewjmoreton@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) I still don't know what problems you observed but have now committed = fixes for two other assertion failures to master, ef01250e and e7a6ce84. = Andy, did they help?
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 17 Jan 2024 03:31:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 16 22:31:44 2024
Received: from localhost ([127.0.0.1]:50306 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rPweV-00010B-RY
for submit <at> debbugs.gnu.org; Tue, 16 Jan 2024 22:31:44 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:60974)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1rPweT-0000uU-Oo
for 68244 <at> debbugs.gnu.org; Tue, 16 Jan 2024 22:31:43 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1rPweN-0001eh-Lc; Tue, 16 Jan 2024 22:31:35 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=IXiyTUR/NtzPebO12IBvUAqrNKhlG9Oc2FB+HZi2cE8=; b=KR1ASsj1rSl5LSPAc1+v
ar5yrb4iyboQfJbGGXTRyGhbTD/Y5tyHBsEQ+RJw9KZ9jVqjF5ydlFHM0gCMWhttQ3dobP/7dua27
g0/rgGGZmNun+GfIEjIdRXOyUmmECH1z2hdjsuPgsSPickqCogvi2uG3J2XlWO5OH/45VQIf4JEso
0nwoLi30HbAibzufgGZW/CWWkPyD5mSpF3q2B4M5lDpwyhozRi4/IS5A0sZi2uqvTyM4oAwWltl2G
uG6Kb1+ILuOh7Lia1wpce4AK98N23AEZjWGjyz9qAiHntpz9eT7l3zrW0iB/zgJu9m7J8O/Y8z7JL
lrmItQ6EM+/SFQ==;
Date: Wed, 17 Jan 2024 05:31:24 +0200
Message-Id: <83r0igbppv.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Andy Moreton <andrewjmoreton@HIDDEN>
In-Reply-To: <86mst5t00f.fsf@HIDDEN> (message from Andy Moreton on Tue, 16
Jan 2024 21:57:04 +0000)
Subject: Re: bug#68244: hash-table improvements
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<86cyu37elt.fsf@HIDDEN> <83h6jeeq1z.fsf@HIDDEN>
<BEF1A1B1-A295-44C8-96C1-29809C77B62A@HIDDEN> <86mst5t00f.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68244
Cc: 68244 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Andy Moreton <andrewjmoreton@HIDDEN>
> Date: Tue, 16 Jan 2024 21:57:04 +0000
>
> On Mon 15 Jan 2024, Mattias Engdegård wrote:
>
> > 15 jan. 2024 kl. 13.31 skrev Eli Zaretskii <eliz@HIDDEN>:
> >
> >>> Bisect identifies this as the bad commit:
> >>> d3cefd3e9835 ("Leaner hash table dumping and thawing")
> >
> > Thank you, I can reproduce the (or at least an) assertion failure in this
> > commit. However it's probably a ghost error: although I've tried to make sure
> > that there is a correct build at each point, there have been a lot of work
> > going on rearranging things for correctness and clarity, and apparently I
> > never built this particular one with checking enabled the last time.
> >
> > However this assertion should be removed by the next commit so the error is
> > very short-lived (and it's just an over-zealous assertion, not an actual
> > flaw). What problems do you observe when building master?
> >
> > (And yes, I should update some hashes in pdumper.c; it's been a while.)
>
> I bisected from newer master to get to that point. Bootstrapping master
> commit f19f5604deb7 ("Update pdumper hashes for buffer and Lisp_Hash_Table")
> is still failing, and trying to continue the buid by retrying after that
> is glacially slow, so something is badly broken at that point.
>
> Note that the same commit bootstrapped after "git clean -xdf" still has
> multiple backtraces when building without ENABLE_CHECKING.
Can you show the first crash/assertion violation when building with
ENABLE_CHECKING? It is important to see the error message, and if you
can run the failing command under GDB and show a backtrace, it will be
even more useful.
Thanks.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 16 Jan 2024 21:57:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 16 16:57:29 2024
Received: from localhost ([127.0.0.1]:49904 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rPrR3-00069K-4O
for submit <at> debbugs.gnu.org; Tue, 16 Jan 2024 16:57:29 -0500
Received: from lists.gnu.org ([2001:470:142::17]:43428)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rPrR0-000695-Dw
for submit <at> debbugs.gnu.org; Tue, 16 Jan 2024 16:57:27 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rPrQu-0001gY-1j
for bug-gnu-emacs@HIDDEN; Tue, 16 Jan 2024 16:57:20 -0500
Received: from ciao.gmane.io ([116.202.254.214])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rPrQs-00015t-Ne
for bug-gnu-emacs@HIDDEN; Tue, 16 Jan 2024 16:57:19 -0500
Received: from list by ciao.gmane.io with local (Exim 4.92)
(envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rPrQp-0001Ml-IO
for bug-gnu-emacs@HIDDEN; Tue, 16 Jan 2024 22:57:15 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: bug-gnu-emacs@HIDDEN
From: Andy Moreton <andrewjmoreton@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
Date: Tue, 16 Jan 2024 21:57:04 +0000
Message-ID: <86mst5t00f.fsf@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<86cyu37elt.fsf@HIDDEN> <83h6jeeq1z.fsf@HIDDEN>
<BEF1A1B1-A295-44C8-96C1-29809C77B62A@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Gnus/5.13 (Gnus v5.13)
Cancel-Lock: sha1:C4peRQfQ4GzAVnNOKZCRUqd/QHc=
Received-SPF: pass client-ip=116.202.254.214;
envelope-from=geb-bug-gnu-emacs@HIDDEN; helo=ciao.gmane.io
X-Spam_score_int: 5
X-Spam_score: 0.5
X-Spam_bar: /
X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001,
FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001,
HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.5 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Mon 15 Jan 2024, Mattias Engdegård wrote: > 15 jan. 2024
kl. 13.31 skrev Eli Zaretskii : > >>> Bisect identifies this as the bad commit:
>>> d3cefd3e9835 ("Leaner hash table dumping and thawing") > > Thank you,
I can reproduce the (or at lea [...]
Content analysis details: (1.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
mail domains are different
0.0 T_SPF_PERMERROR SPF: test of record failed (permerror)
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received'
headers
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (andrewjmoreton[at]gmail.com)
-0.0 T_SCC_BODY_TEXT_LINE No description available.
0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
EnvelopeFrom freemail headers are
different
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.5 (/)
On Mon 15 Jan 2024, Mattias Engdegård wrote:
> 15 jan. 2024 kl. 13.31 skrev Eli Zaretskii <eliz@HIDDEN>:
>
>>> Bisect identifies this as the bad commit:
>>> d3cefd3e9835 ("Leaner hash table dumping and thawing")
>
> Thank you, I can reproduce the (or at least an) assertion failure in this
> commit. However it's probably a ghost error: although I've tried to make sure
> that there is a correct build at each point, there have been a lot of work
> going on rearranging things for correctness and clarity, and apparently I
> never built this particular one with checking enabled the last time.
>
> However this assertion should be removed by the next commit so the error is
> very short-lived (and it's just an over-zealous assertion, not an actual
> flaw). What problems do you observe when building master?
>
> (And yes, I should update some hashes in pdumper.c; it's been a while.)
I bisected from newer master to get to that point. Bootstrapping master
commit f19f5604deb7 ("Update pdumper hashes for buffer and Lisp_Hash_Table")
is still failing, and trying to continue the buid by retrying after that
is glacially slow, so something is badly broken at that point.
Note that the same commit bootstrapped after "git clean -xdf" still has
multiple backtraces when building without ENABLE_CHECKING.
AndyM
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 15 Jan 2024 20:22:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 15 15:22:34 2024
Received: from localhost ([127.0.0.1]:47094 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rPTTd-0001ii-Tp
for submit <at> debbugs.gnu.org; Mon, 15 Jan 2024 15:22:34 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:41350)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1rPTTc-0001iV-GI
for 68244 <at> debbugs.gnu.org; Mon, 15 Jan 2024 15:22:33 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1rPTTX-0000Rp-6B; Mon, 15 Jan 2024 15:22:27 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=y25AJR+OQ6j3sMvS89YvNOIU6yX7cKMXH2MLTSHB1c8=; b=EfCuO3sMUNZmajoI1e4P
f27NBzGF7Uv2FMnhwvidJpImXFCYXJqR135fxFCT3HOp2aJ0xy6fgscagM/qYzcLAy6dyU8B0I1M8
XFjXyPOjKtvNenolFaEJFXH5NOxZchLdaA42d+LxTtX7skQTUq6vq+iu5jO0VVDX3I3abLZKSjMfm
o+5ptkQQLflQChj/pXM5OfCqSd4uzGBnRyRb5Yu7AxrQXMWNF+eIfAVU89HlovLJaShStlEI4itoF
EcH8imVDBa48UqMI1vjGFaPbFfAHLMLphqJJhwu/XF7ZI6n6NBUBVJSh5ZBr2i+4jpaaOipZBoupF
zsco9MGFzATTnw==;
Date: Mon, 15 Jan 2024 22:21:52 +0200
Message-Id: <83o7dmcppb.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Andy Moreton <andrewjmoreton@HIDDEN>
In-Reply-To: <86r0iiv013.fsf@HIDDEN> (message from Andy Moreton on Mon, 15
Jan 2024 20:01:28 +0000)
Subject: Re: bug#68244: hash-table improvements
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<86cyu37elt.fsf@HIDDEN> <83h6jeeq1z.fsf@HIDDEN> <86r0iiv013.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68244
Cc: 68244 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Andy Moreton <andrewjmoreton@HIDDEN>
> Date: Mon, 15 Jan 2024 20:01:28 +0000
>
> On Mon 15 Jan 2024, Eli Zaretskii wrote:
>
> >> From: Andy Moreton <andrewjmoreton@HIDDEN>
> >> Date: Sun, 14 Jan 2024 22:08:14 +0000
> >>
> >> On Sat 13 Jan 2024, Mattias Engdegård wrote:
> >>
> >> > All right, I've pushed the parts that I have little doubt about being a
> >> > definite improvement: a batch of refactoring steps, then the hash-table
> >> > printing reforms, the representation and growth algorithm improvements, and
> >> > finally documentation updates, all now on master.
> >>
> >> Something in this patch series causes a build failure on Windows using
> >> the Mingw64 toolchain. I've tried bisecting this, and at each step doing
> >> "git clean -xdf" and then autogen, configure and make for a native build.
> >>
> >> The last good commit on master is:
> >> c3d0cc50faf5 ("Remove rehash-threshold and rehash-size struct members")
> >>
> >> Bisect identifies this as the bad commit:
> >> d3cefd3e9835 ("Leaner hash table dumping and thawing")
> >>
> >> I have included the end of the log from the failing build below.
> >>
> >> AndyM
> >>
> >> -----o0o-----
> >>
> >> cp -f temacs.exe bootstrap-emacs.exe
> >> rm -f bootstrap-emacs.pdmp
> >> ./temacs --batch -l loadup --temacs=pbootstrap \
> >> --bin-dest c:/emacs/30.0.50/mingw64-x86_64-O2-native/bin/ --eln-dest c:/emacs/30.0.50/mingw64-x86_64-O2-native/lib/emacs/30.0.50/
> >> Loading loadup.el (source)...
> >> Dump mode: pbootstrap
> >> Using load-path (c:/emacs/git/emacs/master/lisp c:/emacs/git/emacs/master/lisp/emacs-lisp c:/emacs/git/emacs/master/lisp/progmodes c:/emacs/git/emacs/master/lisp/language c:/emacs/git/emacs/master/lisp/international c:/emacs/git/emacs/master/lisp/textmodes c:/emacs/git/emacs/master/lisp/vc)
> >> Loading emacs-lisp/debug-early (source)...
> >>
> >> ...[snipped]...
> >>
> >> Loading c:/emacs/git/emacs/master/lisp/emacs-lisp/rmc.el (source)...
> >> Finding pointers to doc strings...
> >> Finding pointers to doc strings...done
> >> Dumping under the name bootstrap-emacs.pdmp
> >> Dumping fingerprint: 9f59e49a3ba95f3d7451327de9cf2863b9ddb392220c5f88f384f16245a619c2
> >> Dump complete
> >> Byte counts: header=100 hot=16147196 discardable=207320 cold=11360080
> >> Reloc counts: hot=1123689 discardable=5662
> >> ANCIENT=yes make -C ../lisp compile-first EMACS="../src/bootstrap-emacs.exe"
> >> make[3]: Entering directory '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2-native/lisp'
> >> ELC /c/emacs/git/emacs/master/lisp/emacs-lisp/macroexp.elc
> >>
> >> C:/emacs/git/emacs/master/src/lisp.h:2564: Emacs fatal error: assertion failed: 0 < size
> >
> > Thanks, but I see no assertion 0 < size on line 2564 of lisp.h, or
> > anywhere else in lisp.h. Can you tell which assertion fails?
>
> In commit d3cefd3e9835, line 2564 of lisp.h has "eassume (0 < size);" in
> HASH_TABLE_SIZE().
>
> If the hash table changes now allow zero sized tables then that would
> trigger in a build with ENABLE_CHECKING. My build script had checking
> enabled, which would explain the failure. Sorry for not mentioning that
> earlier (I had forgotten that it was enabled).
>
> With ENABLE_CHECKING disabled the build succeeds. Thus the invariants
> need looking at to allow a checked build to work.
I always build with ENABLE_CHECKING, so I still don't understand why I
don't see the problem. Can you suggest a way that avoids a full
bootstrap, but just compiles a (small) bunch of Lisp files?
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 15 Jan 2024 20:01:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 15 15:01:47 2024
Received: from localhost ([127.0.0.1]:47067 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rPT9X-0006ws-6P
for submit <at> debbugs.gnu.org; Mon, 15 Jan 2024 15:01:47 -0500
Received: from lists.gnu.org ([2001:470:142::17]:48518)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rPT9V-0006ru-AG
for submit <at> debbugs.gnu.org; Mon, 15 Jan 2024 15:01:45 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rPT9Q-0004Sx-0T
for bug-gnu-emacs@HIDDEN; Mon, 15 Jan 2024 15:01:40 -0500
Received: from ciao.gmane.io ([116.202.254.214])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rPT9O-0005o6-GM
for bug-gnu-emacs@HIDDEN; Mon, 15 Jan 2024 15:01:39 -0500
Received: from list by ciao.gmane.io with local (Exim 4.92)
(envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rPT9K-0000R0-U1
for bug-gnu-emacs@HIDDEN; Mon, 15 Jan 2024 21:01:34 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: bug-gnu-emacs@HIDDEN
From: Andy Moreton <andrewjmoreton@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
Date: Mon, 15 Jan 2024 20:01:28 +0000
Message-ID: <86r0iiv013.fsf@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
<86cyu37elt.fsf@HIDDEN> <83h6jeeq1z.fsf@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Gnus/5.13 (Gnus v5.13)
Cancel-Lock: sha1:KwDjeTkdgwTM+Fp6M/pAHK89jBs=
Received-SPF: pass client-ip=116.202.254.214;
envelope-from=geb-bug-gnu-emacs@HIDDEN; helo=ciao.gmane.io
X-Spam_score_int: 5
X-Spam_score: 0.5
X-Spam_bar: /
X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001,
FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001,
HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.5 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Mon 15 Jan 2024, Eli Zaretskii wrote: >> From: Andy Moreton
>> Date: Sun, 14 Jan 2024 22:08:14 +0000 >> >> On Sat 13 Jan 2024, Mattias
Engdegård wrote: >> >> > All right, I've pushed the parts that I have little
doubt about being a >> > [...]
Content analysis details: (1.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
mail domains are different
0.0 T_SPF_PERMERROR SPF: test of record failed (permerror)
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received'
headers
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (andrewjmoreton[at]gmail.com)
-0.0 T_SCC_BODY_TEXT_LINE No description available.
0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
EnvelopeFrom freemail headers are
different
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.5 (/)
On Mon 15 Jan 2024, Eli Zaretskii wrote:
>> From: Andy Moreton <andrewjmoreton@HIDDEN>
>> Date: Sun, 14 Jan 2024 22:08:14 +0000
>>
>> On Sat 13 Jan 2024, Mattias Engdegård wrote:
>>
>> > All right, I've pushed the parts that I have little doubt about being a
>> > definite improvement: a batch of refactoring steps, then the hash-table
>> > printing reforms, the representation and growth algorithm improvements, and
>> > finally documentation updates, all now on master.
>>
>> Something in this patch series causes a build failure on Windows using
>> the Mingw64 toolchain. I've tried bisecting this, and at each step doing
>> "git clean -xdf" and then autogen, configure and make for a native build.
>>
>> The last good commit on master is:
>> c3d0cc50faf5 ("Remove rehash-threshold and rehash-size struct members")
>>
>> Bisect identifies this as the bad commit:
>> d3cefd3e9835 ("Leaner hash table dumping and thawing")
>>
>> I have included the end of the log from the failing build below.
>>
>> AndyM
>>
>> -----o0o-----
>>
>> cp -f temacs.exe bootstrap-emacs.exe
>> rm -f bootstrap-emacs.pdmp
>> ./temacs --batch -l loadup --temacs=pbootstrap \
>> --bin-dest c:/emacs/30.0.50/mingw64-x86_64-O2-native/bin/ --eln-dest c:/emacs/30.0.50/mingw64-x86_64-O2-native/lib/emacs/30.0.50/
>> Loading loadup.el (source)...
>> Dump mode: pbootstrap
>> Using load-path (c:/emacs/git/emacs/master/lisp c:/emacs/git/emacs/master/lisp/emacs-lisp c:/emacs/git/emacs/master/lisp/progmodes c:/emacs/git/emacs/master/lisp/language c:/emacs/git/emacs/master/lisp/international c:/emacs/git/emacs/master/lisp/textmodes c:/emacs/git/emacs/master/lisp/vc)
>> Loading emacs-lisp/debug-early (source)...
>>
>> ...[snipped]...
>>
>> Loading c:/emacs/git/emacs/master/lisp/emacs-lisp/rmc.el (source)...
>> Finding pointers to doc strings...
>> Finding pointers to doc strings...done
>> Dumping under the name bootstrap-emacs.pdmp
>> Dumping fingerprint: 9f59e49a3ba95f3d7451327de9cf2863b9ddb392220c5f88f384f16245a619c2
>> Dump complete
>> Byte counts: header=100 hot=16147196 discardable=207320 cold=11360080
>> Reloc counts: hot=1123689 discardable=5662
>> ANCIENT=yes make -C ../lisp compile-first EMACS="../src/bootstrap-emacs.exe"
>> make[3]: Entering directory '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2-native/lisp'
>> ELC /c/emacs/git/emacs/master/lisp/emacs-lisp/macroexp.elc
>>
>> C:/emacs/git/emacs/master/src/lisp.h:2564: Emacs fatal error: assertion failed: 0 < size
>
> Thanks, but I see no assertion 0 < size on line 2564 of lisp.h, or
> anywhere else in lisp.h. Can you tell which assertion fails?
In commit d3cefd3e9835, line 2564 of lisp.h has "eassume (0 < size);" in
HASH_TABLE_SIZE().
If the hash table changes now allow zero sized tables then that would
trigger in a build with ENABLE_CHECKING. My build script had checking
enabled, which would explain the failure. Sorry for not mentioning that
earlier (I had forgotten that it was enabled).
With ENABLE_CHECKING disabled the build succeeds. Thus the invariants
need looking at to allow a checked build to work.
AndyM
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 15 Jan 2024 13:26:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 15 08:26:25 2024
Received: from localhost ([127.0.0.1]:44950 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rPMyv-0008PK-3n
for submit <at> debbugs.gnu.org; Mon, 15 Jan 2024 08:26:25 -0500
Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:47116)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mattias.engdegard@HIDDEN>) id 1rPMys-0008P5-6T
for 68244 <at> debbugs.gnu.org; Mon, 15 Jan 2024 08:26:23 -0500
Received: by mail-lf1-x12d.google.com with SMTP id
2adb3069b0e04-50e72e3d435so8381847e87.2
for <68244 <at> debbugs.gnu.org>; Mon, 15 Jan 2024 05:26:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1705325176; x=1705929976; darn=debbugs.gnu.org;
h=to:references:message-id:content-transfer-encoding:cc:date
:in-reply-to:from:subject:mime-version:sender:from:to:cc:subject
:date:message-id:reply-to;
bh=VLWmQUFuIdeQJfF0RvGN2fYVpHN+A1qhrurvPHVuAUo=;
b=RbdUmPbi3PazKyWmGM81BsjYdDgP5xtjKwi1AJOfGUntR26/UpeMlnHh6oPtzPNUlJ
n4aNebSggqLmSC9ANf9QPeMwj0y8YEflWqxfyEoAG+Q9VcF+oHkW4TDlggwUcHoSk3BM
VI17iXVuAL40NNigrwiLM8WfIpQWI4LnpaU/GOWsW/G4vjv/OcZ8gfBOj6mhhH0UCPKC
/ZTe1Fm9+A0Y4ODPxG9mtLps115b6LN0dPWpLsXU01O1d/meBPUz9PaCOR1q87LUeCEF
ytrx25FVeY4YP3xy9ykrU14Wmaze4JjeG+p9j7VH7l2R5/uCwfSbR1A0Njo0MFyA4tGX
bLHA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1705325176; x=1705929976;
h=to:references:message-id:content-transfer-encoding:cc:date
:in-reply-to:from:subject:mime-version:sender:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=VLWmQUFuIdeQJfF0RvGN2fYVpHN+A1qhrurvPHVuAUo=;
b=QjRHPj/8ZA2wFYHFVEFwxaxnQFfZIApiMRW+7u28kAV7Y1iWafdlwKsmrHylXcvTdG
/1IkyZpWdfTESS91WW1EpXKekoDRGFAAfNkFXSt1Wrq/EEvGAW8VTb3x8tlbUUdbLwpE
JGl/b75+e6q0y9OQ8qMrzS1uQwRxVPYl7g6h0DclWGn/9uQNPniN+wWVIVXBl8WxeUpa
oeYy4uWOyfLO21zyhqOKk78rE3+t13AJhwHwnmiqWfk9eXIIOqdp2J0j6MccVOI++oyD
WakqW+9TVh43kShpsUak+vjBbw1Nz8kYfcbs4+a/us0zomIkR8eNBkxWNUb+630aXuJl
R5Ug==
X-Gm-Message-State: AOJu0YzwQe70/PARibjLeyUM2qJm0HQBbxCqSlk41Jz49qIAPcxxhL1B
hou2B5rB2akHmTq+9GrG44M=
X-Google-Smtp-Source: AGHT+IFI+yFyWt8l2c6XCdXUOQw8o+kyMPbhggji8gRZ7+AuM3h+E72JBsvKokySsgSmMriWoZ1leQ==
X-Received: by 2002:ac2:5321:0:b0:50e:7c70:fbe8 with SMTP id
f1-20020ac25321000000b0050e7c70fbe8mr1409833lfh.186.1705325175462;
Mon, 15 Jan 2024 05:26:15 -0800 (PST)
Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se.
[80.217.1.132]) by smtp.gmail.com with ESMTPSA id
e12-20020a056512090c00b0050e86cda5a7sm1472552lft.96.2024.01.15.05.26.14
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Mon, 15 Jan 2024 05:26:14 -0800 (PST)
Content-Type: text/plain;
charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\))
Subject: Re: bug#68244: hash-table improvements
From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>
In-Reply-To: <83h6jeeq1z.fsf@HIDDEN>
Date: Mon, 15 Jan 2024 14:26:13 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <BEF1A1B1-A295-44C8-96C1-29809C77B62A@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <86cyu37elt.fsf@HIDDEN>
<83h6jeeq1z.fsf@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
X-Mailer: Apple Mail (2.3654.120.0.1.15)
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68244
Cc: 68244 <at> debbugs.gnu.org, Andy Moreton <andrewjmoreton@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
15 jan. 2024 kl. 13.31 skrev Eli Zaretskii <eliz@HIDDEN>:
>> Bisect identifies this as the bad commit:
>> d3cefd3e9835 ("Leaner hash table dumping and thawing")
Thank you, I can reproduce the (or at least an) assertion failure in =
this commit. However it's probably a ghost error: although I've tried to =
make sure that there is a correct build at each point, there have been a =
lot of work going on rearranging things for correctness and clarity, and =
apparently I never built this particular one with checking enabled the =
last time.
However this assertion should be removed by the next commit so the error =
is very short-lived (and it's just an over-zealous assertion, not an =
actual flaw). What problems do you observe when building master?
(And yes, I should update some hashes in pdumper.c; it's been a while.)
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 15 Jan 2024 12:31:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 15 07:31:42 2024
Received: from localhost ([127.0.0.1]:44854 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rPM7y-0006sL-0F
for submit <at> debbugs.gnu.org; Mon, 15 Jan 2024 07:31:42 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:33382)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1rPM7w-0006n9-Nh
for 68244 <at> debbugs.gnu.org; Mon, 15 Jan 2024 07:31:41 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1rPM7r-0002F4-6F; Mon, 15 Jan 2024 07:31:35 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
Date; bh=wQuMGzDfwig3NiNTggnbhxEIruyDuKD/t+cBOWbHsEs=; b=VNxRRKbxF4Mm+cqV+n8n
utMQZ1LZpjB2r4A12p3rhnzV/uhW8MCRHKiXnzBvOb6SR+k1Exr18HTGHOsDC5wUCqep2Oat40z7M
oJC7shnBLKZrTosEa6O3spCRVP9qKcUsIh8wLELApfSNjk5UOww3GZhwSnxc2UndtdFY8wMwZTYiB
i9a09hNy2Jrk+qv46r3S6fLtAAVoz3Jcalre5wSVfEKUKmENPWYAxHIZ02g9ZoYJs7sEKkbcllTs9
Y+GQX5EiRCOtbBQKCHOnk6Ka4Jmpd90NoFBuYZa9dfzizgScwkxiy85qyqVAYxK7RCyXQ+uJlfyx2
4qqBjzhRTEJkHg==;
Date: Mon, 15 Jan 2024 14:31:20 +0200
Message-Id: <83h6jeeq1z.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Andy Moreton <andrewjmoreton@HIDDEN>,
Mattias =?iso-8859-1?Q?Engdeg=E5rd?= <mattiase@HIDDEN>
In-Reply-To: <86cyu37elt.fsf@HIDDEN> (message from Andy Moreton on Sun, 14
Jan 2024 22:08:14 +0000)
Subject: Re: bug#68244: hash-table improvements
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <86cyu37elt.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68244
Cc: 68244 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Andy Moreton <andrewjmoreton@HIDDEN>
> Date: Sun, 14 Jan 2024 22:08:14 +0000
>
> On Sat 13 Jan 2024, Mattias Engdegård wrote:
>
> > All right, I've pushed the parts that I have little doubt about being a
> > definite improvement: a batch of refactoring steps, then the hash-table
> > printing reforms, the representation and growth algorithm improvements, and
> > finally documentation updates, all now on master.
>
> Something in this patch series causes a build failure on Windows using
> the Mingw64 toolchain. I've tried bisecting this, and at each step doing
> "git clean -xdf" and then autogen, configure and make for a native build.
>
> The last good commit on master is:
> c3d0cc50faf5 ("Remove rehash-threshold and rehash-size struct members")
>
> Bisect identifies this as the bad commit:
> d3cefd3e9835 ("Leaner hash table dumping and thawing")
>
> I have included the end of the log from the failing build below.
>
> AndyM
>
> -----o0o-----
>
> cp -f temacs.exe bootstrap-emacs.exe
> rm -f bootstrap-emacs.pdmp
> ./temacs --batch -l loadup --temacs=pbootstrap \
> --bin-dest c:/emacs/30.0.50/mingw64-x86_64-O2-native/bin/ --eln-dest c:/emacs/30.0.50/mingw64-x86_64-O2-native/lib/emacs/30.0.50/
> Loading loadup.el (source)...
> Dump mode: pbootstrap
> Using load-path (c:/emacs/git/emacs/master/lisp c:/emacs/git/emacs/master/lisp/emacs-lisp c:/emacs/git/emacs/master/lisp/progmodes c:/emacs/git/emacs/master/lisp/language c:/emacs/git/emacs/master/lisp/international c:/emacs/git/emacs/master/lisp/textmodes c:/emacs/git/emacs/master/lisp/vc)
> Loading emacs-lisp/debug-early (source)...
>
> ...[snipped]...
>
> Loading c:/emacs/git/emacs/master/lisp/emacs-lisp/rmc.el (source)...
> Finding pointers to doc strings...
> Finding pointers to doc strings...done
> Dumping under the name bootstrap-emacs.pdmp
> Dumping fingerprint: 9f59e49a3ba95f3d7451327de9cf2863b9ddb392220c5f88f384f16245a619c2
> Dump complete
> Byte counts: header=100 hot=16147196 discardable=207320 cold=11360080
> Reloc counts: hot=1123689 discardable=5662
> ANCIENT=yes make -C ../lisp compile-first EMACS="../src/bootstrap-emacs.exe"
> make[3]: Entering directory '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2-native/lisp'
> ELC /c/emacs/git/emacs/master/lisp/emacs-lisp/macroexp.elc
>
> C:/emacs/git/emacs/master/src/lisp.h:2564: Emacs fatal error: assertion failed: 0 < size
Thanks, but I see no assertion 0 < size on line 2564 of lisp.h, or
anywhere else in lisp.h. Can you tell which assertion fails?
Adding Mattias to the discussion.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 14 Jan 2024 22:08:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 14 17:08:31 2024
Received: from localhost ([127.0.0.1]:44189 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rP8ec-0005eE-PH
for submit <at> debbugs.gnu.org; Sun, 14 Jan 2024 17:08:31 -0500
Received: from lists.gnu.org ([2001:470:142::17]:48780)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rP8eb-0005dy-Fl
for submit <at> debbugs.gnu.org; Sun, 14 Jan 2024 17:08:30 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rP8eW-0001jX-6n
for bug-gnu-emacs@HIDDEN; Sun, 14 Jan 2024 17:08:24 -0500
Received: from ciao.gmane.io ([116.202.254.214])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rP8eU-0004JD-Mz
for bug-gnu-emacs@HIDDEN; Sun, 14 Jan 2024 17:08:23 -0500
Received: from list by ciao.gmane.io with local (Exim 4.92)
(envelope-from <geb-bug-gnu-emacs@HIDDEN>)
id 1rP8eS-0009GJ-NE
for bug-gnu-emacs@HIDDEN; Sun, 14 Jan 2024 23:08:20 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: bug-gnu-emacs@HIDDEN
From: Andy Moreton <andrewjmoreton@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
Date: Sun, 14 Jan 2024 22:08:14 +0000
Message-ID: <86cyu37elt.fsf@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Gnus/5.13 (Gnus v5.13)
Cancel-Lock: sha1:cAPPjYth/dNPwdwoLjup2Ma9gYI=
Received-SPF: pass client-ip=116.202.254.214;
envelope-from=geb-bug-gnu-emacs@HIDDEN; helo=ciao.gmane.io
X-Spam_score_int: 5
X-Spam_score: 0.5
X-Spam_bar: /
X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001,
FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001,
HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.5 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Sat 13 Jan 2024, Mattias Engdegård wrote: > All right,
I've pushed the parts that I have little doubt about being a > definite improvement:
a batch of refactoring steps, then the hash-table > printing reforms, the
representation and growth al [...]
Content analysis details: (1.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
mail domains are different
0.0 T_SPF_PERMERROR SPF: test of record failed (permerror)
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
1.0 FORGED_GMAIL_RCVD 'From' gmail.com does not match 'Received'
headers
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (andrewjmoreton[at]gmail.com)
-0.0 T_SCC_BODY_TEXT_LINE No description available.
0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
EnvelopeFrom freemail headers are
different
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.5 (/)
On Sat 13 Jan 2024, Mattias Engdegård wrote:
> All right, I've pushed the parts that I have little doubt about being a
> definite improvement: a batch of refactoring steps, then the hash-table
> printing reforms, the representation and growth algorithm improvements, and
> finally documentation updates, all now on master.
Something in this patch series causes a build failure on Windows using
the Mingw64 toolchain. I've tried bisecting this, and at each step doing
"git clean -xdf" and then autogen, configure and make for a native build.
The last good commit on master is:
c3d0cc50faf5 ("Remove rehash-threshold and rehash-size struct members")
Bisect identifies this as the bad commit:
d3cefd3e9835 ("Leaner hash table dumping and thawing")
I have included the end of the log from the failing build below.
AndyM
-----o0o-----
cp -f temacs.exe bootstrap-emacs.exe
rm -f bootstrap-emacs.pdmp
./temacs --batch -l loadup --temacs=pbootstrap \
--bin-dest c:/emacs/30.0.50/mingw64-x86_64-O2-native/bin/ --eln-dest c:/emacs/30.0.50/mingw64-x86_64-O2-native/lib/emacs/30.0.50/
Loading loadup.el (source)...
Dump mode: pbootstrap
Using load-path (c:/emacs/git/emacs/master/lisp c:/emacs/git/emacs/master/lisp/emacs-lisp c:/emacs/git/emacs/master/lisp/progmodes c:/emacs/git/emacs/master/lisp/language c:/emacs/git/emacs/master/lisp/international c:/emacs/git/emacs/master/lisp/textmodes c:/emacs/git/emacs/master/lisp/vc)
Loading emacs-lisp/debug-early (source)...
...[snipped]...
Loading c:/emacs/git/emacs/master/lisp/emacs-lisp/rmc.el (source)...
Finding pointers to doc strings...
Finding pointers to doc strings...done
Dumping under the name bootstrap-emacs.pdmp
Dumping fingerprint: 9f59e49a3ba95f3d7451327de9cf2863b9ddb392220c5f88f384f16245a619c2
Dump complete
Byte counts: header=100 hot=16147196 discardable=207320 cold=11360080
Reloc counts: hot=1123689 discardable=5662
ANCIENT=yes make -C ../lisp compile-first EMACS="../src/bootstrap-emacs.exe"
make[3]: Entering directory '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2-native/lisp'
ELC /c/emacs/git/emacs/master/lisp/emacs-lisp/macroexp.elc
C:/emacs/git/emacs/master/src/lisp.h:2564: Emacs fatal error: assertion failed: 0 < size
Backtrace:
00007ff722cebc3e
00007ff722b674b1
00007ff722be90dc
00007ff722c33077
00007ff722c26f8a
00007ff722c271e1
00007ff722c28a62
00007ff722c26dc8
00007ff722c271e1
00007ff722c27515
00007ff722c28e7a
00007ff722c267a1
00007ff722c271e1
00007ff722c297a7
00007ff722c26dc8
00007ff722c271e1
00007ff722c27515
00007ff722c28e7a
00007ff722c267a1
00007ff722c271e1
00007ff722c28a62
00007ff722c26dc8
00007ff722c28358
00007ff722c26dc8
00007ff722c5d820
00007ff722c66167
00007ff722c67cd1
00007ff722c26f36
00007ff722c271e1
00007ff722c26dc8
00007ff722c271e1
00007ff722c28a62
00007ff722c26dc8
00007ff722c271e1
00007ff722c28a62
00007ff722c26dc8
00007ff722c29a80
00007ff722c26dc8
00007ff722c271e1
00007ff722c28a62
00007ff722c26dc8
00007ff722c271e1
00007ff722c26dc8
00007ff722c271e1
00007ff722c27515
00007ff722c2269e
00007ff722c67708
00007ff722c67898
00007ff722c22382
00007ff722c3dde8
00007ff722c26f72
00007ff722c5d820
00007ff722c66167
00007ff722c67cd1
00007ff722c26f36
00007ff722c271e1
00007ff722c26dc8
00007ff722c271e1
00007ff722c28a62
00007ff722c26dc8
00007ff722c271e1
00007ff722c28a62
...
make[3]: *** [Makefile:325: /c/emacs/git/emacs/master/lisp/emacs-lisp/macroexp.elc] Error 3
make[3]: Leaving directory '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2-native/lisp'
make[2]: *** [Makefile:1017: bootstrap-emacs.pdmp] Error 2
make[2]: Leaving directory '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2-native/src'
make[1]: *** [Makefile:554: src] Error 2
make[1]: Leaving directory '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2-native'
make[1]: Entering directory '/c/emacs/git/emacs/master/build/mingw64-x86_64-O2-native'
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 14 Jan 2024 14:43:00 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 14 09:42:59 2024 Received: from localhost ([127.0.0.1]:42015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rP1hT-0005O7-M2 for submit <at> debbugs.gnu.org; Sun, 14 Jan 2024 09:42:59 -0500 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]:42129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rP1hR-0005Nq-Me for 68244 <at> debbugs.gnu.org; Sun, 14 Jan 2024 09:42:58 -0500 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-50eab4bf47aso6748863e87.0 for <68244 <at> debbugs.gnu.org>; Sun, 14 Jan 2024 06:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705243372; x=1705848172; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=ID2dL66SiV3kt/CNvS+iwfpXSOuEm+fE4tuSfb6U2Ro=; b=edijAKCYPwXSRUuTKCkH+S4ywAdCySQ5hBYktZ38ZH+LFkh5VsxiGMmL0hph0AmmL8 NsL0x/RvKVJp7AO+BPjxNsrB6XBHZP1SL+ktvo7onKQ2iX0D6uh4NA0D5Q4kkp2T9ydL 7iSly40LDdWivMqK8BG3Zth5o1CMiyZPZhHolQ2rk5YQz12EiQL+K7s8/iTdGg+csrq9 bbSox6SbA/UhQsSzKvmEZY9TT0CpcLsnnpGR4HEYOm7fjay+H96+N8UNsuRgxzCtwsOb Ql0/I46NgYQ/9qRCpCCiqn5Fsh5Yp0AQ1JQOkYRo3oMlQTEJOikzHiLV0RzKXzjyx3FQ uRGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705243372; x=1705848172; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ID2dL66SiV3kt/CNvS+iwfpXSOuEm+fE4tuSfb6U2Ro=; b=LHbddI5y3vst8PWFP3/hC1oGsTcJOPYPfYYR88ISJgtJ4LQWNlOHgRA3OrBF/ixT8E +d1BGNdOf2R8Xmrg0O/O40laKCjJxIbUfJIO9qDKQzn3T6uC7CNpm8iU9LuHwT4dDCcg r5kS1AgS4yIJqWwC66fjrjEaZI8FwYhXFlPdMy5noLTQD+4e9iahyr6X45a9O6A7Waof UhcL6seNDar1AamDWbOKqg6vciu+Gbww7yxTBK0haHVBdUzN00wpV347COj7+TvBE/l3 aV8IWXt2Lm+5FbQtNvYezufU5RPpj38o1gbgXkg9UvaysIUkGzXt7ls4sRISSq4SN1Sy Je3g== X-Gm-Message-State: AOJu0YzXysQeTD4ohH9nXtccVrMQrxdvUo92Hr2VjfsUNUpYWcjyBOpT es5ftNThaxAulPGy3rJBUdo= X-Google-Smtp-Source: AGHT+IGkZct1ypytqN6KkU68jKn5z2m7REibLpAnZ4qu57Yhuo9iK9BpQ1orAvPAh+H2Nsx3KqALXA== X-Received: by 2002:ac2:5fe8:0:b0:50e:7f5c:6c7f with SMTP id s8-20020ac25fe8000000b0050e7f5c6c7fmr1671207lfg.17.1705243372213; Sun, 14 Jan 2024 06:42:52 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id z10-20020a056512308a00b0050e8e89b6basm1167651lfd.241.2024.01.14.06.42.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Jan 2024 06:42:51 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <m28r4sbi5s.fsf@HIDDEN> Date: Sun, 14 Jan 2024 15:42:50 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <36584367-F206-4A92-9EBA-960634CF1449@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> <m28r4sbi5s.fsf@HIDDEN> To: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 14 jan. 2024 kl. 06.25 skrev Gerd M=C3=B6llmann = <gerd.moellmann@HIDDEN>: > These enums look a bit strange: Test_equal, Weak_Key_Or_Value. Thank you for reading my changes! Yes, it probably should have been = Test_Equal but I thought that it was more important to evoke the name of = the symbol (`equal`) that that value encodes. But these are just names = and can be altered as we see fit.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 14 Jan 2024 05:25:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 14 00:25:48 2024
Received: from localhost ([127.0.0.1]:41513 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rOt0G-0000Am-8a
for submit <at> debbugs.gnu.org; Sun, 14 Jan 2024 00:25:48 -0500
Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:43469)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gerd.moellmann@HIDDEN>) id 1rOt0A-0000AX-PU
for 68244 <at> debbugs.gnu.org; Sun, 14 Jan 2024 00:25:47 -0500
Received: by mail-ed1-x52f.google.com with SMTP id
4fb4d7f45d1cf-558e82bc4b4so2459653a12.1
for <68244 <at> debbugs.gnu.org>; Sat, 13 Jan 2024 21:25:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1705209938; x=1705814738; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=/IDIhsCATJPe9CQeppoMPA+5Hrp0fAnhfp/KjPO0CeA=;
b=G+FAdoc6wVMJzCSDDXrwmWGAUDU0H7Zlh9zf6lpkrdSZMPhLqYOL3pdCWsym5UaaVg
weK70lk4oTamI1ON7sj1ntF1GDgOome8T6hOmyS4iynmKJnrQisOxgdD4khph8zufxNV
FM9ZxGqbAGonN0kOaundTYuYCSeZfqWgVsV0qsAkIVjQLDfYkmmg0quJLPYITqD+Ktcq
O2RInf+8U7MWHoBb3IjGhfoG55xw7yFzSKZOHmXpjvxQllZ0Gu2a197EKwL8a3Lw2UNj
ChsTZuzdBTlRIkMIJky7QbjJkd/fff92DMBMuvbtW6NXbhOyiAosoY/PsVEZ6P/BMY9P
MMqQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1705209938; x=1705814738;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=/IDIhsCATJPe9CQeppoMPA+5Hrp0fAnhfp/KjPO0CeA=;
b=N6SxqzE63IHmtMuA3fvM6dgkYJvsmboSAlTMWj0aHed/Zi46jF7n8LryHetiIyQXhz
2QfvqgMm7ft5dVVTeTbYJXJAZds8sRwad3CrC8qxuS6gpQGcmr1/ck6UlIkmOCwepwqA
+GCvdv0hprpQNRAGpd+uX25UIGsQT2WQRh8RtMV3lvrmr1ZAv92zp9GPxjtdlw96ac0B
qiocU09R3HV/TeP6+jIAC5Bu1wXi1+7jwSq2zEfz73pFeZHAtwdNQrOKIkhwP2HgOS9v
mvUdHC371dBwR+94navqudZBiEBgMr5HTVj02Juc63hI+yl/9R9YZvmvB1UFlyNN58hQ
2v4g==
X-Gm-Message-State: AOJu0YyejxvmUQsAcgr/j0OOd6brnnCoPsap2HhGxll6es2FuxRc4Rbw
URxRqDuXzkzeGF8edQBP/XDlA3XFnXA=
X-Google-Smtp-Source: AGHT+IG5WRbL0dSinNyNaJROav0q4SOrVSdUUPXz6GpSvrAMjiA5IxH4YdXW4vNPhdfzKBMLvsOjTA==
X-Received: by 2002:a17:907:d502:b0:a2d:9a0d:5c7e with SMTP id
wb2-20020a170907d50200b00a2d9a0d5c7emr186684ejc.74.1705209937695;
Sat, 13 Jan 2024 21:25:37 -0800 (PST)
Received: from Pro.fritz.box (pd9e36745.dip0.t-ipconnect.de. [217.227.103.69])
by smtp.gmail.com with ESMTPSA id
xo16-20020a170907bb9000b00a26aa5c5a60sm3708283ejc.19.2024.01.13.21.25.36
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 13 Jan 2024 21:25:37 -0800 (PST)
From: =?utf-8?Q?Gerd_M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> ("Mattias
=?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Sat, 13 Jan 2024 21:06:06
+0100")
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
<jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
<CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN>
<F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN>
Date: Sun, 14 Jan 2024 06:25:35 +0100
Message-ID: <m28r4sbi5s.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68244
Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
68244 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>,
Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Mattias Engdeg=C3=A5rd <mattias.engdegard@HIDDEN> writes:
> All right, I've pushed the parts that I have little doubt about being
> a definite improvement
These enums look a bit strange: Test_equal, Weak_Key_Or_Value.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 13 Jan 2024 20:06:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 13 15:06:15 2024 Received: from localhost ([127.0.0.1]:41186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rOkGk-0004MB-Ru for submit <at> debbugs.gnu.org; Sat, 13 Jan 2024 15:06:15 -0500 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:55582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rOkGi-0004Lx-LP for 68244 <at> debbugs.gnu.org; Sat, 13 Jan 2024 15:06:13 -0500 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-50e759ece35so8475770e87.3 for <68244 <at> debbugs.gnu.org>; Sat, 13 Jan 2024 12:06:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705176368; x=1705781168; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=RULZLHbQUFpp1fXq9pcL0rBV2yr7eEqecJYTJieRxMs=; b=ijBSpeAw0nQBGkQ+JIXzY0koOPkuCldkFi13vJ0zvUj/fZ2AaIBwDV7Cbj1Qh4hGz4 9q6A5mKkX5OoN0c6uAjme5RQdKm3YvuLWOmYEEbrr3uXCnFYcVi0gLQxQN6NQ84voWVL Achk/+5cVKLHE49OzNYQv8ovDXRYT9lMJAOBAaJUge+gja3hiMP9eHcxegh01aoz/lUH d28hyN2yQNaMOKXYgtSTOtCd8dz10L3QTp2VvumrmtE1U6T5nkgj7TZfxEwIlKOEabNe 4N1kaDbbMlI2G+fLtJ8enulR7FWJmldSnNWqzVG1d/e6zp5rYjwwFcObW06BnYbm8jMd Ld1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705176368; x=1705781168; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RULZLHbQUFpp1fXq9pcL0rBV2yr7eEqecJYTJieRxMs=; b=pXD+3EzU24x1ckhKlLOnZAWEt/NbBiFiRVzo1kX+BaWcf9tXcRWM6ZNEUrhyWxDo5r t2CCpY2bkl/KX6kVn1cnyJLAKO4Aygx9eYqHalzkzHVyJBckxolb6QLKRGkbtguDkXA5 XZZI0fO74PHiYQxlAdB61jFT66sEDIWxaJqKB80iCVULbP5I3hFbkLrFk6PisT+JJ0eT pZNgEqNFCRWFUCp1imAPFO677aD9gzQf8jTBHVv5IgYjA6eOTOJS3PdVYQp/jreetvo8 G4sx27S+EqsD/KjyI9hHv90PtKYJ7ATqEZvl8M0IVk8yCxKrlRqCdRZhb559OqbfnLIo N8iw== X-Gm-Message-State: AOJu0Yy5EwhOsHXDV8qzrpcnVCrdmI+LPJ3iCCQou0Dxi0Vj1kVRhSaW EI8414DzrwvKcsYFhtqiOro= X-Google-Smtp-Source: AGHT+IGkWwsKiNsA2jXnIb3KD3WfHcfFbAdME82QSgMB/UK1ZFX5YN+6DKqiIPZhDjYGQuwB1u/jHg== X-Received: by 2002:a05:6512:2810:b0:50e:5958:5045 with SMTP id cf16-20020a056512281000b0050e59585045mr1688508lfb.22.1705176367648; Sat, 13 Jan 2024 12:06:07 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id j9-20020a05651231c900b0050ed70b8731sm926553lfe.249.2024.01.13.12.06.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Jan 2024 12:06:07 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> Date: Sat, 13 Jan 2024 21:06:06 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <F6059336-9FC6-47FA-8DB2-5483A79C5B85@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) All right, I've pushed the parts that I have little doubt about being a = definite improvement: a batch of refactoring steps, then the hash-table = printing reforms, the representation and growth algorithm improvements, = and finally documentation updates, all now on master. Not part of this yet: - unifying hash and next vectors (or hash, next and key_and_value) in a = single array: pending benchmarks. - Knuth range reduction: probably a gain as described earlier, but I = want to study the behaviour in more of an apples-to-apples comparison = since the table and index sizes were changed at the same time. - turning hash_table_test structures into Lisp objects so that they can = be referenced from a symbol property: seemed to worsen performance = slightly so putting this on hold for the time being. - adaptive index vector width: measurements needed. - fancier hashing: to be implemented. Maybe we should promote equal-including-properties to a first-class hash = table test? It's defined as a user test in two places in the Emacs = tree, and user tests are much slower than built-in ones.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 12 Jan 2024 15:42:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 12 10:42:45 2024 Received: from localhost ([127.0.0.1]:37268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rOJgD-00051n-2P for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 10:42:45 -0500 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]:44287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rOJgA-00051Z-OW for 68244 <at> debbugs.gnu.org; Fri, 12 Jan 2024 10:42:43 -0500 Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2cd0f4797aaso72394551fa.0 for <68244 <at> debbugs.gnu.org>; Fri, 12 Jan 2024 07:42:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705074159; x=1705678959; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=hSw4UDIVOYQhVk3qGBJ93fwDteQwbl/usboD1Aip56s=; b=bcHFszOBzRPVprUObzi40AgLCfjI38BbinKUFWpOL6N+tWS9EImzurVLSbNAtM6Ua1 gh91qF7FKkTvBHcdf481oeG2OuoJlxFgx0tbiBMQAm6rRsCTPuAKzdFFMkA895rH9Xun dhI99hBWleztGdCysh2kH1iCADTn48dXQBnHgOG9pFpUbGrMdDreqdtfQggcLRAn1lL8 lJrDJkLUKL+qH/YGOuwzOvc7CKxQjzPTF78sQPe1Y4n9+1VEEBXfOvMpo3T6owIOL+Rq t4z6/J/x7Nu7ck0ooSlZxiK0G5EKA00BTJZsEUrrKTqinKOe2/dvvWk0p8NL+M+nEvxd OJrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705074159; x=1705678959; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hSw4UDIVOYQhVk3qGBJ93fwDteQwbl/usboD1Aip56s=; b=AO5JlVp7xZ+MpehC3aozPrnwAZW9QAnU/mc8XMZpetj4AMUGvRKQKzzpK+qxRZLSTf MYue7+sh7fyNpuDgJPB6LzpvZNAEnbbF0ti50R2XeRKoPUXmIU2cABOQyvHwgrObz2NL hVEUbnh+ylS1mvzhFg1AZyBWUhjSsFbdPBOj9M6K5wpEf967DQPmeZAITMi5FtR51Wym OdzBGVMmaSJETEKZegs5NSTYlKEyKwm6g2sGtA9ZvnyP8Gn91pmE20Yq813q7S7dPZ7c Vl8v8QqieSHjuZ77qLy5nFFrjoRf147SIJs8Im5zRXdjl2oqkvC6th+S/VYP0mqK+sga xAig== X-Gm-Message-State: AOJu0YzcxDJAmnN8XBBzGSvTuYNEpSleZJsUvIyc8neSYfjrHAFJ5zDk DbaZKmO4uGB5z5I9EvD+uBs= X-Google-Smtp-Source: AGHT+IGGCzPkmvWtWrNBdX4smPKvkx3yawAfEbDvVPCJzEsXiI+lFRox3iLBGkwS4VLhIeTSYdKflA== X-Received: by 2002:a2e:8497:0:b0:2cc:d45a:48d8 with SMTP id b23-20020a2e8497000000b002ccd45a48d8mr759430ljh.43.1705074158399; Fri, 12 Jan 2024 07:42:38 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id h11-20020a2ea48b000000b002cd1eeccca9sm499382lji.32.2024.01.12.07.42.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Jan 2024 07:42:37 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <CADwFkmkJi9hx9bZMB7zBp97LAdjiGMaU-NE=wrMvpvfdcxuzXQ@HIDDEN> Date: Fri, 12 Jan 2024 16:42:37 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <6D166292-0D7E-4A00-857A-36CB9B624CB1@HIDDEN> References: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN> <CADwFkmkJi9hx9bZMB7zBp97LAdjiGMaU-NE=wrMvpvfdcxuzXQ@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: 68244 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 9 jan. 2024 kl. 22.51 skrev Stefan Kangas <stefankangas@HIDDEN>: > Maybe lift `hash-table-rehash-size' and `hash-table-rehash-threshold' = to > Lisp and mark them obsolete. Yes, I thought about that. It's probably a good idea, and it won't = inconvenience a lot of people. (Warning about the corresponding keywords in make-hash-table is probably = not worth it at this point.)
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 68244) by debbugs.gnu.org; 9 Jan 2024 21:51:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 09 16:51:40 2024 Received: from localhost ([127.0.0.1]:41168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rNK0a-0008A2-J1 for submit <at> debbugs.gnu.org; Tue, 09 Jan 2024 16:51:40 -0500 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:59764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1rNK0Y-00089j-PA for 68244 <at> debbugs.gnu.org; Tue, 09 Jan 2024 16:51:39 -0500 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-554fe147ddeso4012223a12.3 for <68244 <at> debbugs.gnu.org>; Tue, 09 Jan 2024 13:51:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704837086; x=1705441886; darn=debbugs.gnu.org; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:from:to:cc:subject:date:message-id :reply-to; bh=DLY4cyrAOCt8R9pgpcdcTr4WkRTuEqsTycB20cbGU5Q=; b=I5jEzmxR3Z2Kt4I9nnKuaphk109nLTCDM1NvE9D9WtCp/P0BkqruwpGeviYneSec5q 5GCeTPH8Ui+CRiAxcd1FS2W952Pml3HGByTChwbU1d2nfbPY58y+HW6O9VKW29Q4DhLn OzIDUKu11/R55rHxcmO2nXftxsMc8ED6lKdcOKq/kjEjEe7WZVBsaJtptvJOy0XmgrAW rdVmqeZuohw+qBU788kVB6jlv87HMUQEhcpvoZSfvsDF8fvqInXivXH2sDqeU7YrsC1G u3nxgGQ+0cciJ1V5wiU20Z7MpnqChkn74AnvNSwgfk8HahNFkDBJsW1skA2yZDRcGPGs ZP4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704837086; x=1705441886; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=DLY4cyrAOCt8R9pgpcdcTr4WkRTuEqsTycB20cbGU5Q=; b=Vs/IC7z/L3Z7Ja2ezAxhxZzTYTz+KtNvR7HgwKmaeNtc4N9We8nmokxhcReZEd7yk4 HE0+XeS3arfMBPet/lQWCISkT0jjSJTJ5T+SpZcnRP4csD/5MfYDBBoaGbDzo+wfyXB/ 7R8FzllBn2Hr6I0UM1Z9Zdntjug9s9DuNFPQg1OJ00M9Q1okmcQhMq8bl8Cfp7J+sROF rxbokCJCHp8Xl6PxEkAERFvdZbeZn3uGHKrZDhujRMTuMHfZroOBGPYDnK2vUtRXSUH3 bEZxJ7bJ5Z6jtWOn3UkdObrehJRups3fSDKESlpN7uYeehuWPdzet8fuxkI52gfZqtwh 6R3A== X-Gm-Message-State: AOJu0YxhSN9rrllMohYp7OBsgve5LdYouvYFkM3+so8G+LCswmanMQrI +RUYC26tPU8/TZ/qpRGdF8kh7TPqpgM38baKxT8= X-Google-Smtp-Source: AGHT+IExcdAFt7cTGj2RQ+LF3JZBQFHv8uCDUTt39YBFKqgpBY6qeeRcgTh5u25W76+c+i5M1QGxBrBzw/xUdOgtWsQ= X-Received: by 2002:a50:cccc:0:b0:54c:d9c5:f9ef with SMTP id b12-20020a50cccc000000b0054cd9c5f9efmr20596edj.8.1704837085663; Tue, 09 Jan 2024 13:51:25 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 9 Jan 2024 13:51:24 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN> References: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN> MIME-Version: 1.0 Date: Tue, 9 Jan 2024 13:51:24 -0800 Message-ID: <CADwFkmkJi9hx9bZMB7zBp97LAdjiGMaU-NE=wrMvpvfdcxuzXQ@HIDDEN> Subject: Re: bug#68244: hash-table improvements To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>, 68244 <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd <mattias.engdegard@HIDDEN> writes: > It's the hash-table's turn to be subjected to some performance > tuning. The implementation has changed very little over the years and > it's not so much a matter of a single big thing to fix as many small > ones, so the list of changes is fairly long but ever little helps. > > A working patch series can be found in the scratch/hash-table-perf > branch. Although it should all be satisfactory and an improvement on > what was before, there are a couple of details that I'd like to do > better, which is why this hasn't been merged yet: the way shared > hash_table_test structs are cached isn't very elegant, nor is the way > we deal with Qunbound in pdumper.c. Thanks, these changes make sense to me both in terms of the performance gains and the cleaner implementation. The improved usability (de-emphasizing `hash-table-size', etc.) and printed representation are certainly appreciated too. Maybe lift `hash-table-rehash-size' and `hash-table-rehash-threshold' to Lisp and mark them obsolete. The hash table implementation is complex enough for it to be worth avoiding cruft lying around.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 9 Jan 2024 10:26:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 09 05:26:25 2024 Received: from localhost ([127.0.0.1]:38432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rN9JR-0003zb-0G for submit <at> debbugs.gnu.org; Tue, 09 Jan 2024 05:26:25 -0500 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]:42394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rN9JM-0003zJ-10 for 68244 <at> debbugs.gnu.org; Tue, 09 Jan 2024 05:26:23 -0500 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2cd1aeb1bf3so25675331fa.1 for <68244 <at> debbugs.gnu.org>; Tue, 09 Jan 2024 02:26:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704795967; x=1705400767; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=a3EPIFzemGu8RFbWPsTLJrtEO2uVNws/yBmGApDzMtg=; b=UCF/eKpxH+LdV1TQ7UpzA0yYdKbzTZulhk7jw58EgpGhO4pRGBChYjqEP96KLk0e9X bfW44WbSY5ezw5/omXGS/agOl5JT07wKV2kJriyWPnQMFE48cpfHIXxzXn0nb2T5GsRy e8EnIwVogidkFmztI7veoXAdxpzmp9mpd2Aorbj2FIkJ84oIyF0XASsNLO/cvhP5spAl 0cvMh+FhxE69b96ViwFP0OiKGhU+KKjfJAExdoSbEKyvx5IVtYVJ5LKEyCo18/2ge/H0 k86zZn/6k3xsG2UY2m7EJ8zBLkTM2UdhMI0D+jPOZgQmBKiH1V9d6m2uV2BA0MpHFgze 9xZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704795967; x=1705400767; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=a3EPIFzemGu8RFbWPsTLJrtEO2uVNws/yBmGApDzMtg=; b=HhN5U32Jp0ztjs1jiWdkuZXfGr36Tm4NIHaq2m2VNcx0Dvdd6lhW3dvFkEAgJNgX+s Z2e40tmlxa28YYzqm3Tvo2aH4b2nGYAOPvEjyZIDFFWLN4DUyHmNbv/E3ah74A7JLMB/ ztYJCRAv1WW49ZlK1hX/79ILwkfoJRiqoVZzA+O2WzL87C4Kz1UT23KzdOS7itv8vz62 00E9/A4Sl0A05y9RPRRGRsmbI/SSfFGvfu+rmOETSp470KNwbxc77VL6HypDl4yVum7b 1euVwnhV/vKV/U/F3cGC5I5NvG+wWsWZ6OoDM0mn2/8A/vuWsju7ij2LVhEuCv0ZdseB AdVQ== X-Gm-Message-State: AOJu0YzONoSurQ4TPHzA1YPKTcEDHGJg9KjahA5oso3sw7xBA5b2iczz HZe8JDsVhyqa2sLMrVYeCy0= X-Google-Smtp-Source: AGHT+IEkV8bly2ejGohGaCFHgrPvA1dSc4VjOww5VAP/fEaSGWyVodR0gJcS1tnHdW2CQvD1GUwN2w== X-Received: by 2002:a05:651c:516:b0:2cc:dea3:23b with SMTP id o22-20020a05651c051600b002ccdea3023bmr372946ljp.3.1704795966928; Tue, 09 Jan 2024 02:26:06 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id l3-20020a2ea303000000b002cd46b08d4esm314996lje.67.2024.01.09.02.26.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jan 2024 02:26:06 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> Date: Tue, 9 Jan 2024 11:26:05 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <CEFE559B-94CD-496A-A85E-D43E6A40C4FA@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 9 jan. 2024 kl. 01.33 skrev Stefan Monnier <monnier@HIDDEN>: > BTW, what is the "per-entry byte-size" of your new code? > The old code had about 6 words per entry, IIRC. With tables filled to capacity, the old code was about 5.25 (assuming an = index vector size 1.25 times the table size). Now it's 1.625 words less, = thus 3.625 words per entry. I haven't done the maths for what the = average per-entry size would be if we take growth space into account. The index vector can be shrunk further if we use a narrower index for = smaller tables. This is a fairly common optimisation and usually the = lower memory usage is worth an extra branch or two. The hash-table object size is also down from 16 words to 10. 8 is = actually quite achievable: consolidate the key_and_value, hash and next = vectors into a single allocated block. It's just a matter of = benchmarking to see what memory arrangement is the most beneficial. >> We could try switching to a high-quality hash function (or family = thereof), >> like Murmur or Jenkins. Then range reduction is just a matter of = masking off >> the required number of bits. >=20 > I don't see a strong need for it. Maybe not, but I wouldn't discount it out of hand. A few cheap ALU ops = could easily pay for themselves if they lead to fewer collisions. > BTW, I see in the Knuth reduction you extract the bits 32..32+N of > the multiplication. It's supposed to be bits [32-N,32) actually (hope I got that right). > Any reason not to use the top N bits instead (so > we're not limited to 32 bits, for example)? I thought about writing a clever expression that would work for other = widths as well but it seemed like a waste of time given the current data = structures.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 9 Jan 2024 00:33:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 08 19:33:37 2024
Received: from localhost ([127.0.0.1]:37894 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rN03h-0003pG-OM
for submit <at> debbugs.gnu.org; Mon, 08 Jan 2024 19:33:37 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:23082)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1rN03c-0003ou-9A
for 68244 <at> debbugs.gnu.org; Mon, 08 Jan 2024 19:33:32 -0500
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 04BEF80CC9;
Mon, 8 Jan 2024 19:33:16 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1704760394;
bh=MifJ4B7Iwja96TOed25M0tt9iwL8CBCTXLIEp2YSoq8=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=m+W6h4UGQR7SIvHgddNPiapkbJhVi6nEZIjeR51y/dBrMWCuMx5SL4IAQe211V62O
edMeM4NcTALpVBDnpTkjnA1bOvJPAJwOA0WBa2vYxvCILdKrpdXOd0phtp87oBZiiH
9sPhm0bVs/g4vJ5iFeu9NSieDQrVwwcb7B/jssEEy9t9nKiw4m0V3eAx3tk66gmwI7
MO9n1S/GAZR+a4P879vAkBgn3hDxCbGU7srM/5qz5mjBPkyi2y0VnJfHQfimusXuA7
eK5v+ba4Itcn0p9nA7ldaQDzXI9Ogox4zGw1a+EaCPUl/wfC4W+OX7oUNjlXUU34sA
FT04Ec7I++pww==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D8FF7809A5;
Mon, 8 Jan 2024 19:33:14 -0500 (EST)
Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A98AC120BE4;
Mon, 8 Jan 2024 19:33:14 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Mattias =?windows-1252?Q?Engdeg=E5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> ("Mattias
=?windows-1252?Q?Engdeg=E5rd=22's?= message of "Mon, 8 Jan 2024 19:26:21
+0100")
Message-ID: <jwvmstfz6xi.fsf-monnier+emacs@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
<jwvv885dktt.fsf-monnier+emacs@HIDDEN>
<19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN>
Date: Mon, 08 Jan 2024 19:33:13 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.001 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68244
Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
68244 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> The left columns are for the standard hash tables with remainder-based range
> reduction, the right ones with Knuth reduction.
> 'size' is the table size, 'idxsiz' the index vector size, '1st%' the portion
> of entries accessed with a single lookup, 'avg' the average number of
> accesses and 'max' the maximum number of accesses required.
>
> The old code looks perfect (no collisions!), but the new shiny code is a disappointment.
Ah, that could explain it, indeed.
BTW, what is the "per-entry byte-size" of your new code?
The old code had about 6 words per entry, IIRC.
> We could try switching to a high-quality hash function (or family thereof),
> like Murmur or Jenkins. Then range reduction is just a matter of masking off
> the required number of bits.
I don't see a strong need for it.
BTW, I see in the Knuth reduction you extract the bits 32..32+N of
the multiplication. Any reason not to use the top N bits instead (so
we're not limited to 32 bits, for example)?
Stefan
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 8 Jan 2024 18:26:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 08 13:26:42 2024 Received: from localhost ([127.0.0.1]:37548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rMuKf-0005Hr-U1 for submit <at> debbugs.gnu.org; Mon, 08 Jan 2024 13:26:42 -0500 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:42083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rMuKa-0005Ha-9P for 68244 <at> debbugs.gnu.org; Mon, 08 Jan 2024 13:26:40 -0500 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50eab4bf47aso1971675e87.0 for <68244 <at> debbugs.gnu.org>; Mon, 08 Jan 2024 10:26:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704738384; x=1705343184; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=hbvj/+aLkpBWYT7TAvewJZqDs4B9qdDKVbWu71vRsE4=; b=dIaetEH+5S5sBVT2lVbdlbCyZICc+nzXihSRlHV4yMvnr+rT5SWyOo/1xUuXemaGPO PndckKntH/70cjbh1KEm2w7IHfDtfYSV76LZPBterxzeKdYer8FT5lqahxzrtFbNgWrR nJkG1s+74e6Hvg90U6i3zFlaTu2T5kaQvwpW4ufzdu5SWmlGzKx2C4OwiV4GbDIaZenW 767qrm+yBqVH8g1/3eV1zPExzDaZ1wcjDQ6xaN21QLcZtLRo4IiUY9l5jTyIdJV02Pza lhEYeZjo7XlExGcEDA+n2GS9fd/BMSvXa1ibX4e4eirp+ZuNkcykBij/fntIrTEfk8Ju jGKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704738384; x=1705343184; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hbvj/+aLkpBWYT7TAvewJZqDs4B9qdDKVbWu71vRsE4=; b=IiSUGbz879K6XhBADVHEUlOogURzOmfUZQbmJrCO5OmwxQ34iDb1qSg6D2x5Xs9r5A pDWG4lz0bAssDpNy06o4bUxIO/sI/+CAG+Fk796+bTH5ILsAHpG81blKaGgB9SiVAzvs vFG8hKfn1Up8kxVtUIxDKA6e0XVwsqZZ2kWSjFWBMy65spaWep6neKTEYbqh7P9MArLc XMzuTkIoz4BH4Ki+V0InZKkyBhavo+EOlq0zO4PQi2fYGpJRsLB3gbbDVoGq3dkJ0yAI RR2WkVl9U+z9ZyQqA9tYPWArdm6eGNx3YaTJ8umlAmWeQWBRWVj17+aT5ODw2jkLLheB jv1g== X-Gm-Message-State: AOJu0YyBjt+eF/9mCmqtlSTys0S2Kqa1oTBwuEXLqJ8+/Z1ifFK2gS4G mhQYMb/KDOFD8zxUkVbIqH8= X-Google-Smtp-Source: AGHT+IHE8f3P6kqEkGXRpn/yrQVdmCIsjiU605ItJCeJ52Bl8JdM+iHy48aLuZNQzdeoUuNnSbPVIw== X-Received: by 2002:a05:6512:b88:b0:50b:f231:d444 with SMTP id b8-20020a0565120b8800b0050bf231d444mr102574lfv.7.1704738383678; Mon, 08 Jan 2024 10:26:23 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id s29-20020a19771d000000b0050e74d04c8asm38775lfc.132.2024.01.08.10.26.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jan 2024 10:26:22 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <jwvv885dktt.fsf-monnier+emacs@HIDDEN> Date: Mon, 8 Jan 2024 19:26:21 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <19265EA5-E6F3-446C-AD9B-763693CF0A48@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> <jwvv885dktt.fsf-monnier+emacs@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 7 jan. 2024 kl. 20.10 skrev Stefan Monnier <monnier@HIDDEN>: > The change gives good results for small tables but less so for big = ones. > I don't have a good intuition for why that would be: none of the > operations directly involved seem to be more costly for large tables, = so > my best guess is that it leads to more collisions somehow, tho I don't > have a good idea about why that would be. Yes, I wondered about that too. It could simply be bad sampling. The = benchmarks with bad results used sequential numbers (0, 1, ...) as keys = so let's start with that: | count | size idxsiz 1st% avg max | size idxsiz 1st% avg max |--------+------------------------------+----------------------------- | 10000 | 12466 15343 100.0 1.00 1 | 12288 16384 100.0 1.00 1 | 20000 | 28048 34523 100.0 1.00 1 | 24576 32768 98.8 1.01 2 | 30000 | 42072 51781 100.0 1.00 1 | 49152 65536 99.1 1.01 2 | 40000 | 42072 51781 100.0 1.00 1 | 49152 65536 94.5 1.06 2 | 50000 | 63108 77671 100.0 1.00 1 | 98304 131072 100.0 1.00 1 | 60000 | 63108 77671 100.0 1.00 1 | 98304 131072 100.0 1.00 1 | 70000 | 94662 116507 100.0 1.00 1 | 98304 131072 100.0 1.00 1 | 80000 | 94662 116507 100.0 1.00 1 | 98304 131072 96.0 1.04 2 | 90000 | 94662 116507 100.0 1.00 1 | 98304 131072 89.3 1.11 2 | 100000 | 141993 174761 100.0 1.00 1 | 196608 262144 92.9 1.07 2 | 110000 | 141993 174761 100.0 1.00 1 | 196608 262144 90.9 1.09 2 | 120000 | 141993 174761 100.0 1.00 1 | 196608 262144 89.3 1.11 2 | 130000 | 141993 174761 100.0 1.00 1 | 196608 262144 87.9 1.12 2 | 140000 | 141993 174761 100.0 1.00 1 | 196608 262144 86.7 1.13 2 | 150000 | 212989 262141 100.0 1.00 1 | 196608 262144 85.7 1.14 2 | 160000 | 212989 262141 100.0 1.00 1 | 196608 262144 84.8 1.15 2 | 170000 | 212989 262141 100.0 1.00 1 | 196608 262144 84.0 1.16 2 | 180000 | 212989 262141 100.0 1.00 1 | 196608 262144 83.3 1.17 2 | 190000 | 212989 262141 100.0 1.00 1 | 196608 262144 82.7 1.17 2 | 200000 | 212989 262141 100.0 1.00 1 | 393216 524288 100.0 1.00 1 The left columns are for the standard hash tables with remainder-based = range reduction, the right ones with Knuth reduction. 'size' is the table size, 'idxsiz' the index vector size, '1st%' the = portion of entries accessed with a single lookup, 'avg' the average = number of accesses and 'max' the maximum number of accesses required. The old code looks perfect (no collisions!), but the new shiny code is a = disappointment. Then again, sequential numbers are best-case for remainder-based = indexing: Emacs hashes (smallish) fixnums to themselves so we are = guaranteed a minimum number of collisions, actually zero since the index = vector is always larger than the number of entries. But sequential keys would be a somewhat unusual use of hash tables; a = vector is a lot more efficient. Let's try with random fixnums instead, = using the same seed for each table: | count | size idxsiz 1st% avg max | size idxsiz 1st% avg max |--------+-----------------------------+---------------------------- | 10000 | 12466 15343 73.5 1.32 6 | 12288 16384 75.4 1.30 6 | 20000 | 28048 34523 75.7 1.29 6 | 24576 32768 75.2 1.30 6 | 30000 | 42072 51781 75.8 1.29 5 | 49152 65536 80.6 1.22 5 | 40000 | 42072 51781 69.6 1.39 7 | 49152 65536 75.0 1.30 6 | 50000 | 63108 77671 73.6 1.32 6 | 98304 131072 83.5 1.19 6 | 60000 | 63108 77671 69.6 1.39 7 | 98304 131072 80.5 1.23 6 | 70000 | 94662 116507 75.2 1.30 6 | 98304 131072 77.5 1.27 6 | 80000 | 94662 116507 72.4 1.34 7 | 98304 131072 75.0 1.30 7 | 90000 | 94662 116507 69.8 1.38 7 | 98304 131072 72.6 1.34 7 | 100000 | 141993 174761 76.2 1.29 6 | 196608 262144 83.3 1.19 6 | 110000 | 141993 174761 74.2 1.32 6 | 196608 262144 81.8 1.21 6 | 120000 | 141993 174761 72.4 1.34 7 | 196608 262144 80.3 1.23 6 | 130000 | 141993 174761 70.6 1.37 7 | 196608 262144 78.8 1.25 6 | 140000 | 141993 174761 68.8 1.40 7 | 196608 262144 77.6 1.27 6 | 150000 | 212989 262141 76.1 1.29 6 | 196608 262144 76.2 1.29 6 | 160000 | 212989 262141 74.8 1.31 6 | 196608 262144 74.9 1.30 6 | 170000 | 212989 262141 73.5 1.33 6 | 196608 262144 73.6 1.32 6 | 180000 | 212989 262141 72.3 1.35 7 | 196608 262144 72.3 1.34 6 | 190000 | 212989 262141 71.1 1.36 7 | 196608 262144 71.1 1.36 7 | 200000 | 212989 262141 69.9 1.38 7 | 393216 524288 83.1 1.19 5 Here the new code looks a bit better, but it could just be the bigger = index vectors. Not sure what to make of this. We could try switching to a high-quality hash function (or family = thereof), like Murmur or Jenkins. Then range reduction is just a matter = of masking off the required number of bits.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 7 Jan 2024 19:10:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 07 14:10:45 2024
Received: from localhost ([127.0.0.1]:33886 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rMYXl-0002w6-Bk
for submit <at> debbugs.gnu.org; Sun, 07 Jan 2024 14:10:45 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24924)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1rMYXj-0002vt-GX
for 68244 <at> debbugs.gnu.org; Sun, 07 Jan 2024 14:10:44 -0500
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 61DBB80A90;
Sun, 7 Jan 2024 14:10:32 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1704654631;
bh=DRwPPaWKhV6kYoZkcQcNXU+F3gqFF2Q1InDUNtGkh/Q=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=e3+mETk0VNm2D6UP3SJM6jwB2Y0tUkq4/CPfocfLJb62FVQeu/fHB1Snr9kWoxZTg
G37RWDuMHNgfiHAfBK5B9SKJBptKtZ+CD03gW7G0WDBpt0F1DAToVF7V1IikpgM6QM
b45FxJSZKeR1oakJN1kCaf1Qmof1qsxR2w/8yqOhEs3C+TGPqzq6Ol8Ktv1dhF38tT
6NOax5gXO+sG9lAcdq1SPOAJuAujuCCe3tFyW1iP7BV9ZiJtd9W6iZYmMwbN/2b2n8
EFqA7eA5WLHyOE/KDLAN2zVEdRJm/qQODOodjTodj2DFFcGemQyKj1QAazZmkXN8mw
aBRAzZ46sQcUg==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7FD7080946;
Sun, 7 Jan 2024 14:10:31 -0500 (EST)
Received: from milanesa (65-110-221-238.cpe.pppoe.ca [65.110.221.238])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4BD9E12062F;
Sun, 7 Jan 2024 14:10:31 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Mattias =?windows-1252?Q?Engdeg=E5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> ("Mattias
=?windows-1252?Q?Engdeg=E5rd=22's?= message of "Sun, 7 Jan 2024 19:36:17
+0100")
Message-ID: <jwvv885dktt.fsf-monnier+emacs@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
<C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN>
Date: Sun, 07 Jan 2024 14:10:29 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL 0.011 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68244
Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
68244 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> I've pushed two new changes: a correction to the GC accounting for the
> ancillary hash-table vectors, and a rather more interesting change to the
> hash table range reduction. It now uses a Knuth multiplicative method
> instead of the expensive remainder, so the index is now always a power of
> 2 in size.
The change gives good results for small tables but less so for big ones.
I don't have a good intuition for why that would be: none of the
operations directly involved seem to be more costly for large tables, so
my best guess is that it leads to more collisions somehow, tho I don't
have a good idea about why that would be.
Stefan
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 7 Jan 2024 18:36:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 07 13:36:41 2024 Received: from localhost ([127.0.0.1]:33827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rMY0l-00051D-Cu for submit <at> debbugs.gnu.org; Sun, 07 Jan 2024 13:36:40 -0500 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]:58435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rMY0c-00050o-Bw for 68244 <at> debbugs.gnu.org; Sun, 07 Jan 2024 13:36:31 -0500 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2cd17a979bcso10223221fa.0 for <68244 <at> debbugs.gnu.org>; Sun, 07 Jan 2024 10:36:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704652578; x=1705257378; darn=debbugs.gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=AGSyowT3MNQyukwTYTIATk3gfWzvv7fRWJ8qakswixY=; b=VFgSxYT73UJBXKWxtFRju3nZejGn8kEZxFQY0VNGD2PdTabFne07Zdcrz5MepkOAaF 09N2EfZdBXG545P4LGsQstXN/oP2PUA5NDvRilx3V+AKJhZGpZuosfo8CCGgFYD7OQCe 8AVa9uIY7pUPVcfI9qWBPhArODVuCG4g0t+Bs1eiJWl32F7ZKsbDzQ34wSjlC7xHYhcs ZbVaS+b5E2mAPISBlR/RxkFSKznQ82bxMXSHYNf08g7HW3NIKFEy0XxKKvyQyeFfqS/+ FL/VvEwA4ogxD9gLb/6vXs8b+DN7cIkYd+tHm0HP0gGia19V0szNTwLu9//Y8icAA0iK e3qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704652578; x=1705257378; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AGSyowT3MNQyukwTYTIATk3gfWzvv7fRWJ8qakswixY=; b=npBVPM+Z72XPD0DTaRk2Z1dfEDBXKGRGWj0KNJgnoIMEd97eWgwCmXiHGs+cgDOP5Z GsS/XStjvqPRCxCFGHDUa0sIyPLv+VtPHCmRFKuQT8EAOfaDizMEZQYWouOuHA0t8TmG QGGFlxQGUlpx0QNTugtOoianBcwZEvu1YMR7Q4dv9pfuhrBnC3+0lKneGQKNHaWIrtgh HlOKrAMu6jrojA4h1+QijmMJbW8/MUciEGfkzSsP12iI+67TbEbNijp7VeKhIml3BTXS XsnKQxIbzdnDntI13127C+GWuWyWKPG+JduVXIVWKKLZpi8R/SMJNJ+HfSbjYPMLCzi+ 5Byw== X-Gm-Message-State: AOJu0YwYvz4ohq97Vmjbgpff7x9RuYncbMPRWRdjP3jwrUUDhp0XQODI aFus9doC9bHp2elxmayZNhI= X-Google-Smtp-Source: AGHT+IECbrkSZfJ/ZEdkaazejb4ERGq0af4feQApVwkKVes31NeT+TrYys95oY4yZF/uY+u20EvaVA== X-Received: by 2002:a2e:8397:0:b0:2cd:31b9:b1d4 with SMTP id x23-20020a2e8397000000b002cd31b9b1d4mr443412ljg.54.1704652578424; Sun, 07 Jan 2024 10:36:18 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id k36-20020a05651c062400b002ccb984d5f8sm1236353lje.7.2024.01.07.10.36.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Jan 2024 10:36:17 -0800 (PST) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> Message-Id: <C1C07631-F385-460D-95AB-5FBFA83A1DD2@HIDDEN> Content-Type: multipart/mixed; boundary="Apple-Mail=_54817F36-7ABD-4580-AB5C-36D0B6990383" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements Date: Sun, 7 Jan 2024 19:36:17 +0100 In-Reply-To: <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --Apple-Mail=_54817F36-7ABD-4580-AB5C-36D0B6990383 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 7 jan. 2024 kl. 06.26 skrev Stefan Monnier <monnier@HIDDEN>: > The use of memory allocation as a way to decide when to do the next GC > is just a crude tool anyway, which can often result in bad GC = decisions, > anyway (e.g. typically during long periods of initialization where we > allocate many objects but don't generate almost any garbage). In any case the changes to GC heuristics and policy that have been = proposed aren't specific to hash-tables and while interesting are = outside the scope of my work at hand. This means that I'll keep using = the same kind of bookkeeping as before, so that the GC is reasonably = well informed if we want to change it in the future. I've pushed two new changes: a correction to the GC accounting for the = ancillary hash-table vectors, and a rather more interesting change to = the hash table range reduction. It now uses a Knuth multiplicative = method instead of the expensive remainder, so the index is now always a = power of 2 in size. Benchmark results attached: the first column is the same as before, the = middle after the accounting fix (which turned out not to be noticeable = at all), and the rightmost what we got from Knuth. I'll probably keep = both. --Apple-Mail=_54817F36-7ABD-4580-AB5C-36D0B6990383 Content-Disposition: attachment; filename=pct.org Content-Type: application/octet-stream; x-unix-mode=0644; name="pct.org" Content-Transfer-Encoding: 7bit | | 681a2877 | e366ae38 | b9c9539d | |---------------------------+----------+----------+----------| | make empty | -88.8 | -88.8 | -89.9 | | make 4, dead | -88.8 | -88.9 | -90.0 | | make 16, dead | -62.3 | -62.5 | -70.7 | | make 64, dead | +26.8 | +24.7 | -3.1 | | make 256, dead | -78.4 | -78.0 | -67.7 | | make 1024, dead | -76.7 | -76.7 | -67.0 | | make 4096, dead | -81.4 | -81.4 | -74.6 | | make 100000, dead | -73.2 | -73.3 | -59.0 | |---------------------------+----------+----------+----------| | make 4, alive | -93.3 | -93.3 | -95.4 | | make 16, alive | -75.6 | -75.6 | -82.8 | | make 64, alive | +11.4 | +12.6 | -22.6 | | make 256, alive | -82.4 | -82.4 | -72.5 | | make 1024, alive | -79.7 | -79.7 | -68.1 | | make 2048, alive | -83.3 | -83.7 | -73.3 | | make 4096, alive | -84.4 | -84.4 | -74.7 | | make 100000, alive | -75.3 | -75.3 | -61.2 | |---------------------------+----------+----------+----------| | gethash seq 4 | -4.7 | -4.7 | -11.2 | | gethash seq 16 | -5.7 | -5.7 | -7.6 | | gethash seq 64 | -5.5 | -4.9 | -6.8 | | gethash seq 256 | -5.3 | -4.7 | -6.4 | | gethash seq 1024 | -5.1 | -4.9 | -6.6 | | gethash seq 4096 | -5.1 | -4.5 | -6.6 | | gethash seq 100000 | -5.1 | -4.7 | +5.3 | |---------------------------+----------+----------+----------| | gethash rnd 4 | -5.0 | -5.0 | -8.7 | | gethash rnd 16 | -4.6 | -4.6 | -10.0 | | gethash rnd 64 | -8.9 | -8.9 | -13.6 | | gethash rnd 256 | -3.2 | -3.2 | -10.8 | | gethash rnd 1024 | -4.8 | -4.8 | -13.2 | | gethash rnd 4096 | -2.3 | -2.1 | -12.0 | | gethash rnd 100000 | -4.0 | -6.4 | -17.6 | |---------------------------+----------+----------+----------| | gethash sym 1059 | -15.4 | -15.4 | -18.0 | |---------------------------+----------+----------+----------| | gethash 20000 tbls 5 elts | -76.5 | -77.0 | -77.4 | | gethash 5263 tbls 19 elts | -63.5 | -63.8 | -67.4 | | gethash 1538 tbls 65 elts | -28.8 | -22.8 | -35.5 | | gethash 571 tbls 175 elts | -33.7 | -34.1 | -40.1 | |---------------------------+----------+----------+----------| | insert/remove all 10 | -5.4 | -5.0 | -10.8 | | insert/remove all 100 | -5.9 | -5.9 | -10.1 | | insert/remove all 1000 | -4.9 | -5.1 | -9.1 | | insert/remove all 10000 | -4.9 | -5.1 | -9.5 | | insert/remove all 100000 | -5.5 | -5.5 | +2.2 | |---------------------------+----------+----------+----------| | insert/remove 10 | +10.2 | +10.2 | -5.2 | | insert/remove 100 | -7.7 | -7.7 | -17.5 | | insert/remove 1000 | -12.4 | -12.4 | -16.1 | | insert/remove 10000 | -5.1 | -5.1 | -10.4 | | insert/remove 100000 | -9.9 | -9.9 | -6.9 | |---------------------------+----------+----------+----------| | maphash 10 | -6.1 | -6.0 | -7.1 | | maphash 100 | -0.4 | -0.4 | +0.8 | | maphash 1000 | -0.2 | -0.2 | +0.8 | | maphash 10000 | +0.8 | +0.8 | +0.0 | | maphash 100000 | -0.2 | -0.4 | +1.8 | |---------------------------+----------+----------+----------| | print empty eql | -43.2 | -41.8 | -42.6 | | print empty eq | -39.1 | -38.3 | -38.8 | |---------------------------+----------+----------+----------| | read empty eql | -96.5 | -96.5 | -96.5 | | read empty eq | -94.9 | -94.9 | -94.9 | | read 100 | -36.2 | -36.1 | -36.8 | | read 10000 | -6.8 | -7.0 | -7.8 | --Apple-Mail=_54817F36-7ABD-4580-AB5C-36D0B6990383--
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 7 Jan 2024 15:39:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 07 10:39:40 2024
Received: from localhost ([127.0.0.1]:33594 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rMVFU-0002rk-FP
for submit <at> debbugs.gnu.org; Sun, 07 Jan 2024 10:39:40 -0500
Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:43527)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <dmitry@HIDDEN>) id 1rMVFS-0002rV-SU
for 68244 <at> debbugs.gnu.org; Sun, 07 Jan 2024 10:39:39 -0500
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.west.internal (Postfix) with ESMTP id 1390D3200A3B;
Sun, 7 Jan 2024 10:39:26 -0500 (EST)
Received: from imap48 ([10.202.2.98])
by compute1.internal (MEProxy); Sun, 07 Jan 2024 10:39:27 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
:cc:content-type:content-type:date:date:from:from:in-reply-to
:in-reply-to:message-id:mime-version:references:reply-to:subject
:subject:to:to; s=fm1; t=1704641966; x=1704728366; bh=2Ga+EVwuzI
L58Hp8+HO1TOSTzzgL2WIF0H5GhCda3kQ=; b=KeCtfgiXA9adPQhTSGLxMAQUmU
TCL5ROvB1j4IgC8Fwyh2RxB2koQX215UsZy9cBMUhlNcvpd1c1GSchgkPDAiXTHO
ChcKH9DEgnYkNoQ9Va1JuIeEUedrRq40vRhDkJGp8ECSlerkg7Z3o8DM97tEa2Wl
vbA85dyhHYZjAtpm97E+hwQnOWGvXPmsOZF9YJqYiWyqvx/8te1m3g830I9V2cix
H2IyiGU3t+1yVhDSXoK/57+WPqG0XGou96cq9qq9t5J50Gbio0KzfI2EhqY7ZjwF
S7wRbqI3zA+iKrediCzL7LSnccShX4X8iBJQwdFeCRv0+20yeTu9iJMLZktg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-type:content-type:date:date
:feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
:message-id:mime-version:references:reply-to:subject:subject:to
:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
fm2; t=1704641966; x=1704728366; bh=2Ga+EVwuzIL58Hp8+HO1TOSTzzgL
2WIF0H5GhCda3kQ=; b=BQauCGb3j8rkrKb24GmCki+mxZDx+zTM+W1UvxcG0+u4
Feg8pgrj8VhM9lUiKAyv7HQUIFNfmq/d2/GiU8Ot1ZfS+W/mu8K9o8QHhRv8ZO+B
Nb4QUs3R7CHDSAFOz2WE0hfzFi8xjWABey5vy0RF4IpBgLWmQR3iRfY1nxziXfzL
RSBCPH41dQGyGGHIli97IGNdaRGcGGr6lbs6yIwG6t1tgB53xHICTSFBDPNRvXBr
do7oTJpiBZPPhRCdP/PiNKwA0HUvJuqZTuyiXY82jbO9uYNxRHo9x5+kzzZHRu/f
kyKWs4X4jjssvfqW1Uu1iXHdXKULnzsWKYPGVnt7LA==
X-ME-Sender: <xms:rsWaZTLKdj0qkn7kqDeTXacv_msVZVB4-yZEdRb9hQll0C5b1x5NJQ>
<xme:rsWaZXIfS-8hgmohrsDsDGL4Pvq9rQJUiSvrOEFDtJy0PywrDWpaRUEBb_dZM1iXS
o3xyN1IAdOnFp2hpH8>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdehgedgudelucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhepofgfggfkjghffffhvfevufgtsegrtderreerredtnecuhfhrohhmpeffmhhi
thhrhicuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrthhtvghrnhepve
fgiedvfffghfduuefhheejgeelheffteetffdtveeiffevudefleevtdehueefnecuvehl
uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmihhtrhihse
hguhhtohhvrdguvghv
X-ME-Proxy: <xmx:rsWaZbsntTEfuNVPGEDfKa-RaQC9QOoFqkPrUTwraZ9mCqFSNqtN7A>
<xmx:rsWaZcZYG_v6XI3AL_skJeXWJ_aOfm1x1t6m9e38l2qi20wF4nKr0A>
<xmx:rsWaZaZ0MkPBWIDVC0vDshO8Yb_hErGSvayH_hf2TP2KlNAFj1HyFA>
<xmx:rsWaZdx2nkS9GEbq85e39H2YQ-tSvX4iLNlkuN10yXYqTptxihFT4w>
Feedback-ID: i0e71465a:Fastmail
Received: by mailuser.nyi.internal (Postfix, from userid 501)
id 4EC2431A0065; Sun, 7 Jan 2024 10:39:26 -0500 (EST)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1364-ga51d5fd3b7-fm-20231219.001-ga51d5fd3
MIME-Version: 1.0
Message-Id: <5684d8e9-62b8-42bb-8560-d3f6a30a9cd7@HIDDEN>
In-Reply-To: <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
<jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
Date: Sun, 07 Jan 2024 17:39:06 +0200
From: Dmitry <dmitry@HIDDEN>
To: "Stefan Monnier" <monnier@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
Content-Type: multipart/alternative; boundary=20c4aef6b8414ba9acf9222fe27def77
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 68244
Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>,
68244 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--20c4aef6b8414ba9acf9222fe27def77
Content-Type: text/plain
On Sun, Jan 7, 2024, at 7:26 AM, Stefan Monnier wrote:
> Side note: I think reasoning won't get us out of this: either we decide
> the choice is important, and then we try and do some
> profiling/benchmarking
That's what I was going to suggest, but concluded that dropping the tallying increments in any of these constructors can lead to risky behavior in degenerate cases.
> The use of memory allocation as a way to decide when to do the next GC
> is just a crude tool anyway, which can often result in bad GC decisions,
> anyway (e.g. typically during long periods of initialization where we
> allocate many objects but don't generate almost any garbage).
Indeed, we have a latency/throughput tradeoff here with the current system, so it would be tempting to reduce the frequency of GCs at least in some cases.
--20c4aef6b8414ba9acf9222fe27def77
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable
<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Sun, Jan 7, =
2024, at 7:26 AM, Stefan Monnier wrote:<br></div><blockquote type=3D"cit=
e" id=3D"qt" style=3D""><div>Side note: I think reasoning won't get us o=
ut of this: either we decide<br></div><div>the choice is important, and =
then we try and do some<br></div><div>profiling/benchmarking</div></bloc=
kquote><div>That's what I was going to suggest, but concluded that dropp=
ing the tallying increments in any of these constructors can lead to ris=
ky behavior in degenerate cases.</div><blockquote type=3D"cite" id=3D"qt=
" style=3D""><div>The use of memory allocation as a way to decide when t=
o do the next GC<br></div><div>is just a crude tool anyway, which can of=
ten result in bad GC decisions,<br></div><div>anyway (e.g. typically dur=
ing long periods of initialization where we<br></div><div>allocate many =
objects but don't generate almost any garbage).<br></div></blockquote><d=
iv>Indeed, we have a latency/throughput tradeoff here with the current s=
ystem, so it would be tempting to reduce the frequency of GCs at least i=
n some cases.</div></body></html>
--20c4aef6b8414ba9acf9222fe27def77--
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 7 Jan 2024 05:27:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 07 00:27:12 2024
Received: from localhost ([127.0.0.1]:60564 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rMLgm-0005js-3D
for submit <at> debbugs.gnu.org; Sun, 07 Jan 2024 00:27:12 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4266)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1rMLgk-0005jg-Jd
for 68244 <at> debbugs.gnu.org; Sun, 07 Jan 2024 00:27:11 -0500
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B063E440315;
Sun, 7 Jan 2024 00:26:59 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1704605217;
bh=w2OC6ZDOa9u0J/YeRvwTDfV+BiJ9wKMIFV50rqqxw4o=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=GTPrIlAH1asqRZRM03o13qfdHBD9JLt56R9E6QXpAJAZEZin/TNaDSSjJ82/sDmhy
6CuMTkKcS9/Q+jrI2JNY6vDMh5sc6W/7s3N1ieOpFPcYEjbI6nlGwxY/zwQIOwXbq1
ceeo1OfMbqfWfrBo4xeocIvjwnhb6BCYV6AxVreL5aHcO8JtiVhhYgaHvzxcqofz8L
BO6OhwRtsVh7HwRwfO938qIThvW5q0sTo2FbOBfli59FuAcBbHQM4i3de2h3pQw/OQ
cqc6YRPXty3LqHE+7QTxr8bq8sXvz4bcXL9eEMeVkbscUFXXdfbygDZVwI4GFVmEuU
T4Elown+T1voA==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id BFF1344018E;
Sun, 7 Jan 2024 00:26:57 -0500 (EST)
Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8C8C412041B;
Sun, 7 Jan 2024 00:26:57 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Dmitry Gutov <dmitry@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> (Dmitry Gutov's
message of "Sun, 7 Jan 2024 05:13:39 +0200")
Message-ID: <jwv4jfp4t3a.fsf-monnier+emacs@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
<f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
<B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN>
<d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN>
Date: Sun, 07 Jan 2024 00:26:56 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.114 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68244
Cc: Mattias =?windows-1252?Q?Engdeg=E5rd?= <mattias.engdegard@HIDDEN>,
68244 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Side note: I think reasoning won't get us out of this: either we decide
the choice is important, and then we try and do some
profiling/benchmarking, or we decide it's probably not worth the effort
and make an arbitrary choice under the expectation that it probably
won't make any difference anyway.
The use of memory allocation as a way to decide when to do the next GC
is just a crude tool anyway, which can often result in bad GC decisions,
anyway (e.g. typically during long periods of initialization where we
allocate many objects but don't generate almost any garbage).
We sadly don't have a better alternative, but being crude means that the
details usually don't matter anyway.
Stefan
Dmitry Gutov [2024-01-07 05:13:39] wrote:
> On 06/01/2024 13:34, Mattias Engdeg=E5rd wrote:
>> 5 jan. 2024 kl. 16.41 skrev Dmitry Gutov <dmitry@HIDDEN>:
>>=20
>>>> That's a good question and it all comes down to how we interpret
>>> `consing_until_gc`. Here we take the view that it should encompass all
>>> parts of an allocation and this seems to be consistent with
>>> existing code.
>>>
>>> But the existing code used objects that would need to be collected by G=
C,
>>> right? And the new one, seemingly, does not.
>> But it does, similar to the same way that we deal with string data.
>
> Actually, vectors might be a better comparison. And we do increase the ta=
lly
> when creating a vector (inside 'allocate_vectorlike').
>
>>> So I don't quite see the advantage of increasing consing_until_gc
>>> then. It's like the difference between creating new strings and inserti=
ng
>>> strings into a buffer: new memory is used either way, but the latter
>>> doesn't increase consing.
>> Since we don't know exactly when objects die, we use object allocation as
>> a proxy, assuming that on average A bytes die for every B bytes allocated
>> and make an informed (and adjusted) guess as to what the A/B ratio might
>> be. That is the basis for the GC clock.
>> Buffer memory is indeed treated differently and does not advance the GC
>> clock as far as I can tell. Presumably the reasoning is that buffer size
>> changes make a poor proxy for object deaths.
>
> Perhaps we could look at it differently: what are the failure modes for n=
ot
> increasing the tally.
>
> For strings, one could allocate a handful of very long strings, taking up
> a lot of memory, and if the consing tally did not take into account the
> lengths of the strings, the GC might never start, and we die of OOM.
>
> For vectors, it almost looks different (the contained values are already
> counted, and they'd usually be larger than the memory taken by one cell),
> but then you could put many copies of the same value (could even be nil)
> into a large vector, and we're back to the same problem.
>
> Could we do something like that with a hash-table? Probably not - the
> hashing should at least guarantee 'eq' uniqueness. But then I suppose
> someone could create an empty hash-table of a very large size. If the
> internal vectors are pre-allocated, that could have the same effect as
> the above.
>
> The same reasoning could work for buffers too, but are they actually
> garbage-collected?
>
>> Of course we could reason that growing an existing hash table is also
>> a bad proxy for object deaths, but the evidence for that is weak so I us=
ed
>> the same metric as for other data structures just to be on the safe side.
>>
>> This reminds me that the `gcstat` bookkeeping should probably include the
>> hash-table ancillary arrays as well, since those counters are used to
>> adjust the GC clock (see total_bytes_of_live_objects and
>> consing_threshold). Will fix!
>>=20
>>> It's great that the new hash tables are garbage-collected more easily a=
nd
>>> produce less garbage overall, but in a real program any GC cycle will
>>> have to traverse the other data structures anyway. So we might be leavi=
ng
>>> free performance gains on the table when we induce GC cycles while no
>>> managed allocations are done. I could be missing something, of course.
>> So could I, and please know that your questions are much appreciated. Are
>> you satisfied by my replies above, or did I misunderstand your concerns?
>
> Thank you. I hope I'm not too off mark with my reasoning.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 7 Jan 2024 03:13:57 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 06 22:13:57 2024 Received: from localhost ([127.0.0.1]:60520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rMJbo-0004Cv-LG for submit <at> debbugs.gnu.org; Sat, 06 Jan 2024 22:13:57 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:59251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1rMJbn-0004Cf-50 for 68244 <at> debbugs.gnu.org; Sat, 06 Jan 2024 22:13:55 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B7CA45C00F2; Sat, 6 Jan 2024 22:13:43 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 06 Jan 2024 22:13:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1704597223; x=1704683623; bh=X8KhohXpGG63SsObzQ3/kqpS4hQhvINabVG3v8g2evY=; b= eD9MdR8Gukm/idrbJdKpEuSnUNgkYw5+IXzzQz5kJkIzAmBrF3gt+x5izqis+J/L NAg63MSBSc4Zat3j4UkmnQWNbgNjVLWMVjASOziPF3O82nmeLdhUrnOQVwnnc1Ns jGFN6cpcpIw14o4ZJ3kIvaWusgXpmklcFCdEZjJYxBlqd7ZFhbLlR92edPK8n/zy fhfPWK70qGG+dt9iLs6rFRM4Ws3s1extwve4vjXAOZw1RzmOjQJhqmUQjYiNQyYI o5ThvNuqKJjKS1mGRiAdxQZ9THSDP/t7U8xzZKRzynwyvqJlzEY9ZW2+z7EGvYzQ QMI/qtTrWQIZK/2mRn0dXg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1704597223; x= 1704683623; bh=X8KhohXpGG63SsObzQ3/kqpS4hQhvINabVG3v8g2evY=; b=N E7kw6ICllUpt2jh6EiZX4Wuo4KNmd0LR+Smro5GqNeXwl5tSPbjsDW5NZ1SUFMaw rv9qLmP94tr3y8iRGK1sLUMEv+JAMUECHjDKwGmQYTVn1p4PGHtfxQ7BtGs/eAzz 0N4roAPv/lhyIRSMwuDQXKUOzdKW+sPywx22IBVtKJQZlEBd8B9Eg1KnjeErkVQh UNXT+vwOAHjM6ja26J7VOJM1XOpLJ5uPSzUwFhJID1OxNkC1KrVCv+4qoxiHmf2F 2OgUibOgoCH/oWuVXYqVAiIcTjlaaNLbLnFJFBqMtvawB0wK/HU7Sz4AcqHqZYZi tznuFh4YQNT89Ro1l2dOA== X-ME-Sender: <xms:5xaaZeBybV8JFtTaAcGYNLevEeJHhoyxTc22D7a5D9aJIURXvyOuag> <xme:5xaaZYhFRWUg2WNINVAMq9ItTfcqCh-CgGm6Axc20oMT3FTF3k2T1_zJ05cXyJ-z0 k0H5J18UvPvxwem2Ms> X-ME-Received: <xmr:5xaaZRkjt1vX3JB7gXCSv_R5dCXkra4RLmDUSqhbhQEm1qnm7ijn51BnxpKMkjntK3KngA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdehvddgheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepgeelfeetkefghfdvhfdtgeevveevteetgeetveegtedthefhudekteehffeu keeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:5xaaZczTceSOU09nWb8NiXbnRBJrK-bYcfRFv2oH7SXzVCw7fwjWCw> <xmx:5xaaZTQ6FO1VW3UpLGZv8E04HOWRQmxeM3Ofbye8nEntuDc_yqK2BQ> <xmx:5xaaZXYcvl7xOractovGVYiwZv95fmHLS8rSmZ2klTch5aqU1cqP2A> <xmx:5xaaZefZEJLLeO4iFFGfJ2RDJTyS8sC9cjSygBmcC6FEWLrTrtItcw> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 Jan 2024 22:13:41 -0500 (EST) Message-ID: <d91c1625-56e8-4e50-9b0a-e041d1acf716@HIDDEN> Date: Sun, 7 Jan 2024 05:13:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#68244: hash-table improvements To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68244 Cc: Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 06/01/2024 13:34, Mattias Engdegård wrote: > 5 jan. 2024 kl. 16.41 skrev Dmitry Gutov <dmitry@HIDDEN>: > >>> That's a good question and it all comes down to how we interpret `consing_until_gc`. Here we take the view that it should encompass all parts of an allocation and this seems to be consistent with existing code. >> >> But the existing code used objects that would need to be collected by GC, right? And the new one, seemingly, does not. > > But it does, similar to the same way that we deal with string data. Actually, vectors might be a better comparison. And we do increase the tally when creating a vector (inside 'allocate_vectorlike'). >> So I don't quite see the advantage of increasing consing_until_gc then. It's like the difference between creating new strings and inserting strings into a buffer: new memory is used either way, but the latter doesn't increase consing. > > Since we don't know exactly when objects die, we use object allocation as a proxy, assuming that on average A bytes die for every B bytes allocated and make an informed (and adjusted) guess as to what the A/B ratio might be. That is the basis for the GC clock. > > Buffer memory is indeed treated differently and does not advance the GC clock as far as I can tell. Presumably the reasoning is that buffer size changes make a poor proxy for object deaths. Perhaps we could look at it differently: what are the failure modes for not increasing the tally. For strings, one could allocate a handful of very long strings, taking up a lot of memory, and if the consing tally did not take into account the lengths of the strings, the GC might never start, and we die of OOM. For vectors, it almost looks different (the contained values are already counted, and they'd usually be larger than the memory taken by one cell), but then you could put many copies of the same value (could even be nil) into a large vector, and we're back to the same problem. Could we do something like that with a hash-table? Probably not - the hashing should at least guarantee 'eq' uniqueness. But then I suppose someone could create an empty hash-table of a very large size. If the internal vectors are pre-allocated, that could have the same effect as the above. The same reasoning could work for buffers too, but are they actually garbage-collected? > Of course we could reason that growing an existing hash table is also a bad proxy for object deaths, but the evidence for that is weak so I used the same metric as for other data structures just to be on the safe side. > > This reminds me that the `gcstat` bookkeeping should probably include the hash-table ancillary arrays as well, since those counters are used to adjust the GC clock (see total_bytes_of_live_objects and consing_threshold). Will fix! > >> It's great that the new hash tables are garbage-collected more easily and produce less garbage overall, but in a real program any GC cycle will have to traverse the other data structures anyway. So we might be leaving free performance gains on the table when we induce GC cycles while no managed allocations are done. I could be missing something, of course. > > So could I, and please know that your questions are much appreciated. Are you satisfied by my replies above, or did I misunderstand your concerns? Thank you. I hope I'm not too off mark with my reasoning.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 6 Jan 2024 11:52:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 06 06:52:12 2024 Received: from localhost ([127.0.0.1]:58750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rM5Do-0006pH-HB for submit <at> debbugs.gnu.org; Sat, 06 Jan 2024 06:52:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rM5Dm-0006oz-01 for 68244 <at> debbugs.gnu.org; Sat, 06 Jan 2024 06:52:10 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rM5Db-0001OO-Q1; Sat, 06 Jan 2024 06:51:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=rtLVQeTxU+ty/Xhp9npp3Qz14HaGmIiizMCdulcl6wg=; b=LN0gE2+AAzGqr6KAK7fQ UagSJqk9FUyY0NYv+rRVAPUqJCPPZd3evq0Ox7DPgf8Sn0Z+ADKJT6v4+y04DU86aOJAJtMKajmwW zWwcYlK9CvGMZuuO/5lqAwsgzdSgLaTscjre0xsPkLSsN9KByMARhfOFDv+T+2EosGyRxUBS9RXQB GXzAGg6J4xEGADPen17/sG/wqJPSR5QPpyGtQEUdexfJ6T1Ou0zA3d3rQVvvUYUlwdDNbnxxrn9jH 5pFaaEmYC63PQV9+oIguEDwArH3B5hbFB+mIAPFZNPku+eglPdVHyu6g64CnG7WOGNVQkKf2Mjktf QuN6rLZaSjf3vw==; Date: Sat, 06 Jan 2024 13:51:51 +0200 Message-Id: <834jfqu1bc.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Sat, 6 Jan 2024 12:34:05 +0100) Subject: Re: bug#68244: hash-table improvements References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68244 Cc: dmitry@HIDDEN, 68244 <at> debbugs.gnu.org, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Mattias Engdegård <mattias.engdegard@HIDDEN> > Date: Sat, 6 Jan 2024 12:34:05 +0100 > Cc: 68244 <at> debbugs.gnu.org, > Eli Zaretskii <eliz@HIDDEN>, > Stefan Monnier <monnier@HIDDEN> > > Buffer memory is indeed treated differently and does not advance the GC clock as far as I can tell. Presumably the reasoning is that buffer size changes make a poor proxy for object deaths. Buffer memory is usually allocated via mmap (nowadays, implicitly by libc), which is why it is treated differently.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 6 Jan 2024 11:46:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 06 06:46:23 2024 Received: from localhost ([127.0.0.1]:58730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rM58A-0006Li-Rq for submit <at> debbugs.gnu.org; Sat, 06 Jan 2024 06:46:23 -0500 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]:53464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rM588-0006F0-2P for 68244 <at> debbugs.gnu.org; Sat, 06 Jan 2024 06:46:21 -0500 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2cca5d81826so4009081fa.2 for <68244 <at> debbugs.gnu.org>; Sat, 06 Jan 2024 03:46:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704541569; x=1705146369; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=qcY8VhdiZrNdHsGn5SY0B0iF85SSjArHQP6MyhTDQoU=; b=EUwRPjOlujCCOyLpDy7/qfMgia+6piz2Zb4G00h4sUPVZghqJo2jy0bYLI/u1yBZ6R hDwjkvIYFNQ37R+M/usdRBR+RIFu2hIFlxDGI5jjrIihciUV4bHNPq3oTSCwWe3iMoqo 7voRzujYb/s0ZxtCLu9ZexS6C4RQWPs2cuFfzRsKDqpIs30W817/fTYtfRtsUnXC8X5e Au7RaE9PtwXLTklMdOsNtWEMntz4VVhX2lirlq+hjP+LNkEYac4shngOMDzOr2z6R9MX 0sCfzf8f4koEeK3wYSP/n413QMOunbBvd+n35Gf9K6eUJ1Yas9g44mLHH32mhw8pRzZw Y/sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704541569; x=1705146369; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qcY8VhdiZrNdHsGn5SY0B0iF85SSjArHQP6MyhTDQoU=; b=uTJEfhHccDUfSJ2kMXDq7zd6RTsJrl4zJHnRzeDfQGuHBhv/42eSQB3T/NrZ0NducN sBHYZRZ+76RJpCuwQJ14ZMqZ3dpg/wFr8DM+wL+hm4AdVcr3vChI9vAeE4krWgTkD5t7 1r2qmQ2z5Ij4/G6YZ6YmMNEj0j9TS7LF52vBfr5qpgnIyOij7FuWxJGZjfUzIeAWzyzr 5uXyHe2668vC3D8b8ngauEg+b/EfHu+XbIYNre7XQ+nVI5vz/K6TQTrmsYk3Gb6Umdzb XdrkL+1lYHNAf4ajGGzeZicorlqzOuIcpeTLLHv0Ej4fXx2RoBbrTT3LaPPtiKwNjCmd IhYw== X-Gm-Message-State: AOJu0Ywb6CO4LJtoVsYVW2eRVACS+Smf5nHX2GIZZ9Oktfw7eaQcG5/c CRFJY6999QXeSkbjS09BZig= X-Google-Smtp-Source: AGHT+IH1u+ikwwSF1VB1JDTdz2OYI4vE3uFuPgdgGUj19Twjwuei0ZbWXQiN4HSphC7DR83SBzFhWA== X-Received: by 2002:a05:651c:547:b0:2cc:ea5b:ba6b with SMTP id q7-20020a05651c054700b002ccea5bba6bmr351058ljp.26.1704541568903; Sat, 06 Jan 2024 03:46:08 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id f1-20020a05651c160100b002cd38676699sm361347ljq.66.2024.01.06.03.46.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Jan 2024 03:46:08 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <jwv7ckniu19.fsf-monnier+emacs@HIDDEN> Date: Sat, 6 Jan 2024 12:46:07 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <2A9DEB8A-CDEB-425B-B7BC-45657BE43298@HIDDEN> References: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN> <83r0ixvys9.fsf@HIDDEN> <4FC7642E-BAAF-40E3-AADC-0485AB085D6D@HIDDEN> <83o7e1vvpp.fsf@HIDDEN> <EE625EA9-A704-40C2-A413-78E430337702@HIDDEN> <jwv7ckniu19.fsf-monnier+emacs@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 5 jan. 2024 kl. 18.14 skrev Stefan Monnier <monnier@HIDDEN>: >> [2. application/vnd.lotus-organizer; pct.org] >=20 > Lotus, eh? For those having trouble reading the file, I may have some Organiser = licenses left for sale. > What's up with 64? The old (current) hash tables have a default size of 65 which is very = convenient if you happen to fill it with that many entries. The new code = lowers the default substantially which is generally beneficial as most = tables are small, and growing them is much cheaper than before.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 6 Jan 2024 11:34:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 06 06:34:21 2024 Received: from localhost ([127.0.0.1]:58697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rM4wW-0003c5-LC for submit <at> debbugs.gnu.org; Sat, 06 Jan 2024 06:34:21 -0500 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:53446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rM4wU-0003br-7h for 68244 <at> debbugs.gnu.org; Sat, 06 Jan 2024 06:34:19 -0500 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2cca5d81826so3948471fa.2 for <68244 <at> debbugs.gnu.org>; Sat, 06 Jan 2024 03:34:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704540847; x=1705145647; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=wj2q92k6DOg/lyrWX0gF2wtRe4KBV7uD0PfcSvEUSds=; b=l6dzCMvtBvzelmkIDvfzj84B0OV9YPtJgeDu4jj26Dl3ZAXGsTvdKBZUHQ9YjypuQG 1nwSlKn/p8EPVpj2HxdISLj/fYGmC8EX5sxW/4fSLH+4wWYRlPZF/DaHF/zzUbjSSU5X z1dEe5sHB5rJso4TXHn0XIAMlqOZiUWTz2jNNoR1RS+2N5APAouF2sQvv50CfIS1kw6T V4DQA7JIkaRfkjlKeVZSRelmvBX9qAU3VUTbrIJgjdgoeqG+MLXAi/9fBVEeQ+7ei2JG hXHfRTjs9rGcRbcNCLicmFOcHm+U67odj1A7fjew/riLAPFJ5+7C0S3gf8KcGLbTBzxA pgTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704540847; x=1705145647; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wj2q92k6DOg/lyrWX0gF2wtRe4KBV7uD0PfcSvEUSds=; b=Se4qJAidmE7HWMS9SbRv//2bW/C1Wa6R1ogX+xlO1ELkTVpcWAnKbFqdCftLsWfMI7 3GNSaz45sJfKNdSC7f2Wvrmurig0fWBEeJVXecypxq2YqJgqwtf5JWTN5srYRcVjMpsw t0e/S2tRQx60ylt7LLPrkIXdSkc7np6m84Lb4BRVt7/DAP2wDhlybamlFPQGGBGrYDcA 0QskoFqdG923qq8y6ja/fTDCvxVfnEbSSbuUn4v48T02sEj3Q7rOn+s+dCIOhG+4mv5+ RPbjvDZBchNvRCj2/aTs6rdadwzdo53fVK/DBs4Ry9qfODO4tde7Z1NbxYwYR1Xej0/T u2bA== X-Gm-Message-State: AOJu0Yx/t7Op1FMgSWkalVsN27eV4EEyTUHuUqWwci1JxUd6aeksAH0K 0XWU69V4BkQ7A7H/0fs1CWI= X-Google-Smtp-Source: AGHT+IGV9lct76O9cwch6MKlywCOCb/eQrvRb0KxKsPYWauBHazydj/0qjQbA3CD3Fb2qOKUt2LJDg== X-Received: by 2002:a05:6512:74c:b0:50e:7daf:3141 with SMTP id c12-20020a056512074c00b0050e7daf3141mr301727lfs.58.1704540847024; Sat, 06 Jan 2024 03:34:07 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id s3-20020ac24643000000b0050e709ca890sm501479lfo.225.2024.01.06.03.34.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Jan 2024 03:34:06 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> Date: Sat, 6 Jan 2024 12:34:05 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <B509F736-F46D-494C-A929-DB25D1CF86A6@HIDDEN> References: <170438379722.3921.9312235725296561206@HIDDEN> <20240104155642.B4A99C00344@HIDDEN> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN> <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN> <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 5 jan. 2024 kl. 16.41 skrev Dmitry Gutov <dmitry@HIDDEN>: >> That's a good question and it all comes down to how we interpret = `consing_until_gc`. Here we take the view that it should encompass all = parts of an allocation and this seems to be consistent with existing = code. >=20 > But the existing code used objects that would need to be collected by = GC, right? And the new one, seemingly, does not. But it does, similar to the same way that we deal with string data. > So I don't quite see the advantage of increasing consing_until_gc = then. It's like the difference between creating new strings and = inserting strings into a buffer: new memory is used either way, but the = latter doesn't increase consing. Since we don't know exactly when objects die, we use object allocation = as a proxy, assuming that on average A bytes die for every B bytes = allocated and make an informed (and adjusted) guess as to what the A/B = ratio might be. That is the basis for the GC clock. Buffer memory is indeed treated differently and does not advance the GC = clock as far as I can tell. Presumably the reasoning is that buffer size = changes make a poor proxy for object deaths. Of course we could reason that growing an existing hash table is also a = bad proxy for object deaths, but the evidence for that is weak so I used = the same metric as for other data structures just to be on the safe = side. This reminds me that the `gcstat` bookkeeping should probably include = the hash-table ancillary arrays as well, since those counters are used = to adjust the GC clock (see total_bytes_of_live_objects and = consing_threshold). Will fix! > It's great that the new hash tables are garbage-collected more easily = and produce less garbage overall, but in a real program any GC cycle = will have to traverse the other data structures anyway. So we might be = leaving free performance gains on the table when we induce GC cycles = while no managed allocations are done. I could be missing something, of = course. So could I, and please know that your questions are much appreciated. = Are you satisfied by my replies above, or did I misunderstand your = concerns?
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 5 Jan 2024 17:14:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 05 12:14:27 2024
Received: from localhost ([127.0.0.1]:57760 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rLnm7-0001aN-8r
for submit <at> debbugs.gnu.org; Fri, 05 Jan 2024 12:14:27 -0500
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:35941)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1rLnm1-0001a6-RT
for 68244 <at> debbugs.gnu.org; Fri, 05 Jan 2024 12:14:25 -0500
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 136C310009E;
Fri, 5 Jan 2024 12:14:12 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1704474850;
bh=DnAWzDAmpdC0ryQZtIUV2JmXzHgMcv1UWYLRqfX72kA=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=bBOckKYy5r2v0qHTaMELSyobAZcas1c2BGfCRVHd0nNv1M8UVHzAK02Xpvtju3i+l
4eAioFqWBMgZlxU5s5b8gGZ4OtzV78ReBmq33RIbalY8ie8hILoeGpJ/fCar+39IWN
JYvLGPJBn2hFpxrAeVGuvN36KkUaAC1BP8YN+ArzcRHQm+5gNSfaJRtlaiIkuw0IQA
N4l3r/R08Q0qWcVaM8V8TWIxHMB7fCburwpyueOSMD0PVrw915LtviPcKwHI6+kbN4
O6G7DBLmWdsghlZRDnuRufH99+m0EZwGjs2L/jqp9kPT1qwNdwNreST8zPqX658Zfu
/O8NkXBUE6WyA==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E4D90100068;
Fri, 5 Jan 2024 12:14:10 -0500 (EST)
Received: from alfajor (unknown [23.233.149.155])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C0D0E120B60;
Fri, 5 Jan 2024 12:14:10 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
To: Mattias =?windows-1252?Q?Engdeg=E5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#68244: hash-table improvements
In-Reply-To: <EE625EA9-A704-40C2-A413-78E430337702@HIDDEN> ("Mattias
=?windows-1252?Q?Engdeg=E5rd=22's?= message of "Fri, 5 Jan 2024 12:34:50
+0100")
Message-ID: <jwv7ckniu19.fsf-monnier+emacs@HIDDEN>
References: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN>
<83r0ixvys9.fsf@HIDDEN>
<4FC7642E-BAAF-40E3-AADC-0485AB085D6D@HIDDEN>
<83o7e1vvpp.fsf@HIDDEN>
<EE625EA9-A704-40C2-A413-78E430337702@HIDDEN>
Date: Fri, 05 Jan 2024 12:14:10 -0500
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68244
Cc: Dmitry Gutov <dmitry@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
68244 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> But let's try anyway: here is a run of one of the main suites I've been
> using. The numbers indicate relative changes in percent of elapsed time from
> the baseline to the tip of the scratch/hash-table-perf branch, negative
> numbers being better. For example, -50 means that speed has doubled, +100
> that it has halved.
>
> [2. application/vnd.lotus-organizer; pct.org]
Lotus, eh?
> | | 681a2877cc2 |
> |---------------------------+-------------|
> | make empty | -88.9 |
> | make 4, dead | -88.8 |
> | make 16, dead | -62.3 |
> | make 64, dead | +25.1 |
> | make 256, dead | -77.7 |
> | make 1024, dead | -76.7 |
> | make 4096, dead | -81.4 |
> | make 100000, dead | -73.2 |
> |---------------------------+-------------|
> | make 4, alive | -93.3 |
> | make 16, alive | -75.6 |
> | make 64, alive | +11.5 |
> | make 256, alive | -82.4 |
> | make 1024, alive | -79.7 |
> | make 2048, alive | -83.3 |
> | make 4096, alive | -84.4 |
> | make 100000, alive | -75.1 |
What's up with 64?
Stefan
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 5 Jan 2024 15:42:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 05 10:42:04 2024
Received: from localhost ([127.0.0.1]:57631 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rLmKh-0000IC-Oc
for submit <at> debbugs.gnu.org; Fri, 05 Jan 2024 10:42:04 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:41785)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <dmitry@HIDDEN>) id 1rLmKf-0000Hh-J2
for 68244 <at> debbugs.gnu.org; Fri, 05 Jan 2024 10:42:02 -0500
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
by mailout.nyi.internal (Postfix) with ESMTP id 151655C00DF;
Fri, 5 Jan 2024 10:41:52 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Fri, 05 Jan 2024 10:41:52 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to; s=fm1; t=1704469312;
x=1704555712; bh=M163gRd+WpItyhKE+HALQ5hqtWxfMTh20wI1Mfs8PKg=; b=
irQhwz5FHlbpf5nmwbQ0Sb5E5zh72HfItFtgGT6cuo9QLQzA1TsJLkWGid8o48nU
MHXSIBAtZ12Oyjc266PunVAsGkoDf5rMsve846G0pnw6mZk9RWj7gy5tSnrypoP2
YEVJyj3H+YkTjDDa146SsTAzPne88POq7o6uCNk5nwZVTdnCTJ4IigR/g8BS2TCL
FCTg1tY8LEgU4UEzGM0aGWWJBoaYPf2CbAB9TbEOIvk1izH6y+FLImc2TuDILhsY
gaYh4G+mMmB5E54jZEonM61RbQSxemWMulryYGgTlYjvbyjASKmOr3g4yjukRrNP
dJkCtKtD78s40D6MmHR4Zw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1704469312; x=
1704555712; bh=M163gRd+WpItyhKE+HALQ5hqtWxfMTh20wI1Mfs8PKg=; b=v
L1RmtnhBKG3QppJhzGkB2v+JmTk6m43ofGdm04jSlOMfS0msPyG6jvetAPzzK/0b
s55QzWQ3OViF7D6LzbvEnQCPVEFkcI40ijcuVpuART/M5ep/DrNQwi9GaB9WgCdq
G6yO2BME3GR8tecjCFYa6HNGod6Vy2uFv/oKEeNVQVxWxjnvd4ZoNAsTsJ8DmMty
NAFuo3e3LXV8PjXZebDbPI8ZMo7cKNm/KpkqOWgBlHnkxbX+P1GVQ25Ng+7Gadon
yiwA6iW6OByvjvJcNzxi244OTuEBUDfKZdP3G6BKvyo9A7CMKPq0fbMSy6yM6XVG
K6DMtI3Sm6gjrYsX+snsw==
X-ME-Sender: <xms:PyOYZbYZs7smnm9vefEqsMLTI3AeYmXTuG15wWWZ38xN-oSjli5W8g>
<xme:PyOYZaaSGaSgJpdcwu1mtDiTA2ceF0jVpVHGJYA3gS6CV5IXAC2-UCizD7byXnwe5
RxLJVgpSzXkH_HGVFI>
X-ME-Received: <xmr:PyOYZd_sDPWDKt_T2NaV3oa5CsB2zZEUY20Q9-cQmsvcGS0YH-SGXHRPWucNmf5NI8YY3Q>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdegledgjeeiucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpeffmhhi
thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth
htvghrnhepgeelfeetkefghfdvhfdtgeevveevteetgeetveegtedthefhudekteehffeu
keeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug
hmihhtrhihsehguhhtohhvrdguvghv
X-ME-Proxy: <xmx:PyOYZRqhyPeUNclM_hGAc6b6Zu2brkpM5wfl1paf4xxC9434NcJNAw>
<xmx:PyOYZWq4ZQ3VibKtlaIGgiCjcQdDnQsk6bcNDr5PLjLiKwhoKD47IQ>
<xmx:PyOYZXRdnYaMX253Dcu1E6jVFDvYXV9Ii970DbZoPMB89FZE-Ff9zA>
<xmx:QCOYZd2owyFU7vcMBBdVLIiwZMKFOgoKQmNjKUV-7QK9rOOjJ4rxMw>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
5 Jan 2024 10:41:50 -0500 (EST)
Message-ID: <f2bf750d-73f0-4aa4-8dd6-11407e20e83e@HIDDEN>
Date: Fri, 5 Jan 2024 17:41:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: bug#68244: hash-table improvements
To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
<08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
Content-Language: en-US
From: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 68244
Cc: Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org,
Stefan Monnier <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
On 05/01/2024 12:33, Mattias Engdegård wrote:
> [ replies to questions asked elsewhere ]
>
> 4 jan. 2024 kl. 18.32 skrev Dmitry Gutov <dmitry@HIDDEN>:
>
>>> +hash_table_alloc_bytes (ptrdiff_t nbytes)
>>> +{
>>> + if (nbytes == 0)
>>> + return NULL;
>>> + tally_consing (nbytes);
>>> + return xmalloc (nbytes);
>>> +}
>>
>> Sorry if it's a stupid question, but if the operation doesn't add any Lisp "garbage", why increase the consing counter? That is likely triggers more GCs earlier which otherwise might not run, and if there are no slots to GC, it seems like they would run in vain.
>
> That's a good question and it all comes down to how we interpret `consing_until_gc`. Here we take the view that it should encompass all parts of an allocation and this seems to be consistent with existing code.
But the existing code used objects that would need to be collected by
GC, right? And the new one, seemingly, does not.
So I don't quite see the advantage of increasing consing_until_gc then.
It's like the difference between creating new strings and inserting
strings into a buffer: new memory is used either way, but the latter
doesn't increase consing.
> These ancillary allocations are parts of the hash-table object: they are allocated and freed at the same time as the mother object, and subject to the same `consing_until_gc` accounting.
>
> The new code is radically more efficient when growing tables, because we can free the old vectors immediately (and adjust consing_until_gc accordingly) instead of leaving it as garbage waiting to be collected. This provides several benefits in itself (GCs are made less often, we can re-use hot memory). Not having to traverse them in either the mark or sweep phases is another big gain (the key_and_value parts still have to be marked, of course).
It's great that the new hash tables are garbage-collected more easily
and produce less garbage overall, but in a real program any GC cycle
will have to traverse the other data structures anyway. So we might be
leaving free performance gains on the table when we induce GC cycles
while no managed allocations are done. I could be missing something, of
course.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 5 Jan 2024 11:35:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 05 06:35:07 2024 Received: from localhost ([127.0.0.1]:56545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rLiTi-0002h7-QQ for submit <at> debbugs.gnu.org; Fri, 05 Jan 2024 06:35:07 -0500 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:53759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rLiTg-0002g2-2t for 68244 <at> debbugs.gnu.org; Fri, 05 Jan 2024 06:35:04 -0500 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50e5a9bcec9so1869398e87.3 for <68244 <at> debbugs.gnu.org>; Fri, 05 Jan 2024 03:34:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704454494; x=1705059294; darn=debbugs.gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=VVId328r3mExrCAp5YMvE4xTLC0UXflO6ZN+zx/sbuA=; b=MWrXDJj3/8V2jMqtw2nfS3SEXggXum3OvP4tPF+s5mLAxY7nSSuCtcMqymOtBMyCS8 EhST9QwY7DhaRpaFqQz7HbLjcSJ1TShDhsX1i1WZlI9KLGUmsFjkSQ8wpaHwS9PPSOwq +wThw+eUCkxdkzCnqEFQfBFXKrjMrA56gdruoIn5qDXYRmZeC5V8xh+dDFy78pv4qASi b36lrwYFJvXHc22/xZQc3F3GDLAzreZcUgazt8j+nBCDz/1Zzy6FwnaqxzmTUq9FMWUF cPYvDyN56bD5wyUpgKiJ2atBvQ5xnfbNMZvvFxW9VitTYqizQDnQJg4JQVg/lP7WoabA uChw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704454494; x=1705059294; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VVId328r3mExrCAp5YMvE4xTLC0UXflO6ZN+zx/sbuA=; b=SXQtgggwbfYWCjWbwr3AihpVQFj+ytevvH2hZvrWcxVaL13Yj9FfWN0qo8kmwppBDK 9eBG5ReoMbwhdfYWHcY5IWd2EZI0Ty4IJ4pgcY4usbF8O0BmyONfTCHDIbTbGXb22AA6 F45qllKH+xtp9ZnH6NWVZlc7RarvAZg6Df9lDQT2jFM8wCZ0Vik+2pWLxzLAsrYphkFT lnQobjmTBJMUQ5fDw705tIc1I6ghYY4ztCe6v/Yx0Y/oXuAA2dIxNyQHowJF6YR+oLzR 3Rtg4mTUgqxLMQ0qY3E4118qKusxmPhI/o0Bd62ZmGRopFXsTk/OG6FQTZCoGr7HOZ8D KWdA== X-Gm-Message-State: AOJu0YzihtVamscXkR5bOUYwWbvLjvcBmWsJhFANjOYG9vUAWTKIEj2b bGex7sy21LsdtjJUHMwjCHduwr0Hp9M= X-Google-Smtp-Source: AGHT+IHt7HmU7L9q/wfWkud0rQMdgB/qSl5Z7AFQgTGrB37T+cVLajgtZdoowim0rxpmEDIPHXgGPQ== X-Received: by 2002:a05:6512:31d4:b0:50e:75fc:35be with SMTP id j20-20020a05651231d400b0050e75fc35bemr1252786lfe.90.1704454493478; Fri, 05 Jan 2024 03:34:53 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id br9-20020a056512400900b0050eb25b5092sm211710lfb.229.2024.01.05.03.34.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jan 2024 03:34:52 -0800 (PST) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> Message-Id: <EE625EA9-A704-40C2-A413-78E430337702@HIDDEN> Content-Type: multipart/mixed; boundary="Apple-Mail=_FED6533D-D349-44F8-BB29-7F1FA5CBD54D" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements Date: Fri, 5 Jan 2024 12:34:50 +0100 In-Reply-To: <83o7e1vvpp.fsf@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> References: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN> <83r0ixvys9.fsf@HIDDEN> <4FC7642E-BAAF-40E3-AADC-0485AB085D6D@HIDDEN> <83o7e1vvpp.fsf@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: Dmitry Gutov <dmitry@HIDDEN>, 68244 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --Apple-Mail=_FED6533D-D349-44F8-BB29-7F1FA5CBD54D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 4 jan. 2024 kl. 18.45 skrev Eli Zaretskii <eliz@HIDDEN>: > It doesn't have to be a single number. Showing a series of separate > benchmarks is also fine. Unfortunately it's not quite that simple: those numbers have to be = interpreted and understood as well, which requires about as much work as = making the benchmarks in the first place. But let's try anyway: here is a run of one of the main suites I've been = using. The numbers indicate relative changes in percent of elapsed time = from the baseline to the tip of the scratch/hash-table-perf branch, = negative numbers being better. For example, -50 means that speed has = doubled, +100 that it has halved. --Apple-Mail=_FED6533D-D349-44F8-BB29-7F1FA5CBD54D Content-Disposition: attachment; filename=pct.org Content-Type: application/octet-stream; x-unix-mode=0644; name="pct.org" Content-Transfer-Encoding: 7bit | | 681a2877cc2 | |---------------------------+-------------| | make empty | -88.9 | | make 4, dead | -88.8 | | make 16, dead | -62.3 | | make 64, dead | +25.1 | | make 256, dead | -77.7 | | make 1024, dead | -76.7 | | make 4096, dead | -81.4 | | make 100000, dead | -73.2 | |---------------------------+-------------| | make 4, alive | -93.3 | | make 16, alive | -75.6 | | make 64, alive | +11.5 | | make 256, alive | -82.4 | | make 1024, alive | -79.7 | | make 2048, alive | -83.3 | | make 4096, alive | -84.4 | | make 100000, alive | -75.1 | |---------------------------+-------------| | gethash seq 4 | -4.7 | | gethash seq 16 | -5.7 | | gethash seq 64 | -4.9 | | gethash seq 256 | -4.7 | | gethash seq 1024 | -4.7 | | gethash seq 4096 | -4.5 | | gethash seq 100000 | -4.5 | |---------------------------+-------------| | gethash rnd 4 | -5.1 | | gethash rnd 16 | -4.5 | | gethash rnd 64 | -8.9 | | gethash rnd 256 | -3.0 | | gethash rnd 1024 | -4.8 | | gethash rnd 4096 | -1.9 | | gethash rnd 100000 | -6.5 | |---------------------------+-------------| | gethash sym 1059 | -15.2 | |---------------------------+-------------| | gethash 20000 tbls 5 elts | -76.8 | | gethash 5263 tbls 19 elts | -64.0 | | gethash 1538 tbls 65 elts | -21.8 | | gethash 571 tbls 175 elts | -34.6 | |---------------------------+-------------| | insert/remove all 10 | -5.4 | | insert/remove all 100 | -5.7 | | insert/remove all 1000 | -4.7 | | insert/remove all 10000 | -5.1 | | insert/remove all 100000 | -5.5 | |---------------------------+-------------| | insert/remove 10 | +10.2 | | insert/remove 100 | -7.7 | | insert/remove 1000 | -12.4 | | insert/remove 10000 | -5.1 | | insert/remove 100000 | -10.2 | |---------------------------+-------------| | maphash 10 | -6.0 | | maphash 100 | -0.4 | | maphash 1000 | -0.2 | | maphash 10000 | +0.8 | | maphash 100000 | -0.4 | |---------------------------+-------------| | print empty eql | -42.1 | | print empty eq | -39.0 | |---------------------------+-------------| | read empty eql | -96.5 | | read empty eq | -94.9 | | read 100 | -36.0 | | read 10000 | -6.7 | --Apple-Mail=_FED6533D-D349-44F8-BB29-7F1FA5CBD54D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Again, these are micro-benchmarks designed to amplify the signal in = various respects, and the numbers don't tell everything -- far from it, = in fact. As mentioned before, one of the most important aspects of a data = structure is not just how well it performs itself but how good neighbour = it is: the less memory it uses and the better its locality of reference, = the less negative impact it has on other objects and data structures. = However, these effects can be difficult to measure correctly, so a lot = of the tuning and assessment have to be done by indirect means. --Apple-Mail=_FED6533D-D349-44F8-BB29-7F1FA5CBD54D--
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
Received: (at 68244) by debbugs.gnu.org; 5 Jan 2024 10:34:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 05 05:34:23 2024
Received: from localhost ([127.0.0.1]:56433 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rLhWi-0007QE-MY
for submit <at> debbugs.gnu.org; Fri, 05 Jan 2024 05:34:23 -0500
Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]:56648)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mattias.engdegard@HIDDEN>) id 1rLhWf-0007Pi-Bj
for 68244 <at> debbugs.gnu.org; Fri, 05 Jan 2024 05:34:07 -0500
Received: by mail-lj1-x236.google.com with SMTP id
38308e7fff4ca-2cd0d05838fso16559021fa.1
for <68244 <at> debbugs.gnu.org>; Fri, 05 Jan 2024 02:34:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1704450835; x=1705055635; darn=debbugs.gnu.org;
h=to:references:message-id:content-transfer-encoding:cc:date
:in-reply-to:from:subject:mime-version:sender:from:to:cc:subject
:date:message-id:reply-to;
bh=4Yx5jhAC8dbdAaJbRf0DVawBL1Rru4imF2Z3E3Tjw7s=;
b=dR3CU0MxJRlF7KaVNYZdk7Pqp/FKYeRcBICe8Uvx7vh/bu9y7ErUywK7I7C7Jh7HPC
VWxQEvrczNn8Ne3ilt0T1tEh96GSkrgQNq9TIRFll9DWpCDmjlVlv3HiA2dNFbnCwTmw
mUaHCoRs38XBmbh4g7DRyvBm8oi+ORG1ONxVdMbx8KCZCmY2+ZtG+0+WEpZ+fhaIt/Yh
HvOABasH/WS1sMZOwlJBtiiKA/+Lp3bddwjILzlSYvwQrMs3zM85Ix37An2fnG/hgAZh
F8xzEMhh/gk06SOSkc4znJWLLFvlFhUKO0w7pmYACuFqShPKkAkpifChd6vhpYTM/Gy3
QPFA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1704450835; x=1705055635;
h=to:references:message-id:content-transfer-encoding:cc:date
:in-reply-to:from:subject:mime-version:sender:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=4Yx5jhAC8dbdAaJbRf0DVawBL1Rru4imF2Z3E3Tjw7s=;
b=aYp2FxGbaGTC3clSM7Gea1GtU2I0iwTEUFIaD9720XJeBvJfVpwBhdt5RgeRV69YT+
3dVvJjr8EEFsM1d34H9UElguEVClzK++19vAWsyQaJxj6skUcRULIMdETegTzSYW6Gtv
VCY5eDqWFONqre9vx5BcQ2PC0KaUI5SJGgkd+phX28w1IOlc0ba3s3KS/ATAzoLv9GLB
Yx76GZ/U+3SkEXz5wV1TPjf4X0Hqqxvrs+yQWzGhViqFYTjo0AB+orD0Zp395wa1x05P
IC1TC0xWeUFTU27bCnXuq2Hcgpsrd6zo4tQ3e7v+QbtAphKcq+gdYLro2tGnw1LxuHrR
HDTQ==
X-Gm-Message-State: AOJu0YxujfTQlK4URDdcdvgK0KLo2nZGLEmoqstyCp7B1U3D5I8foD3Y
D4z68OpuFsa6d8BciM4pCPEBXrtvb0Y=
X-Google-Smtp-Source: AGHT+IHQCLtEdIAsLeo3WT/OfOPxseNRbSO8vHsO2pZUgxHyK8Bc2sBT+X+wCy+kofVa82y7vvzaMQ==
X-Received: by 2002:a05:6512:b12:b0:50e:9c17:24d2 with SMTP id
w18-20020a0565120b1200b0050e9c1724d2mr1252413lfu.18.1704450834643;
Fri, 05 Jan 2024 02:33:54 -0800 (PST)
Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se.
[80.217.1.132]) by smtp.gmail.com with ESMTPSA id
s17-20020a056512215100b0050e77b1f0c7sm202903lfr.117.2024.01.05.02.33.53
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Fri, 05 Jan 2024 02:33:53 -0800 (PST)
Content-Type: text/plain;
charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\))
Subject: Re: bug#68244: hash-table improvements
From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>
In-Reply-To: <8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
Date: Fri, 5 Jan 2024 11:33:52 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <08314177-5AE9-4352-94A0-641830B4094D@HIDDEN>
References: <170438379722.3921.9312235725296561206@HIDDEN>
<20240104155642.B4A99C00344@HIDDEN>
<8d49ebdc-9da7-4e70-a080-d8e892b980b6@HIDDEN>
To: Dmitry Gutov <dmitry@HIDDEN>
X-Mailer: Apple Mail (2.3654.120.0.1.15)
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68244
Cc: Eli Zaretskii <eliz@HIDDEN>, 68244 <at> debbugs.gnu.org,
Stefan Monnier <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
[ replies to questions asked elsewhere ]
4 jan. 2024 kl. 18.32 skrev Dmitry Gutov <dmitry@HIDDEN>:
>> +hash_table_alloc_bytes (ptrdiff_t nbytes)
>> +{
>> + if (nbytes =3D=3D 0)
>> + return NULL;
>> + tally_consing (nbytes);
>> + return xmalloc (nbytes);
>> +}
>=20
> Sorry if it's a stupid question, but if the operation doesn't add any =
Lisp "garbage", why increase the consing counter? That is likely =
triggers more GCs earlier which otherwise might not run, and if there =
are no slots to GC, it seems like they would run in vain.
That's a good question and it all comes down to how we interpret =
`consing_until_gc`. Here we take the view that it should encompass all =
parts of an allocation and this seems to be consistent with existing =
code.
These ancillary allocations are parts of the hash-table object: they are =
allocated and freed at the same time as the mother object, and subject =
to the same `consing_until_gc` accounting.
The new code is radically more efficient when growing tables, because we =
can free the old vectors immediately (and adjust consing_until_gc =
accordingly) instead of leaving it as garbage waiting to be collected. =
This provides several benefits in itself (GCs are made less often, we =
can re-use hot memory). Not having to traverse them in either the mark =
or sweep phases is another big gain (the key_and_value parts still have =
to be marked, of course).
> I'm curious whether any of these callers have tested with different =
values and found a difference in performance:
>=20
> =
https://github.com/search?q=3D%3Arehash-threshold+language%3A%22Emacs+Lisp=
%22&type=3Dcode&l=3DEmacs+Lisp
I don't think they did, but it's easy to picture what was going on:
Manual: Here is a Knob. It can be Turned to improve Performance.
User: Knob! Performance!
Some trials indicate that it's almost impossible for a user to use those =
knobs effectively, nor should they have to. Moreover, by removing them =
we not only give users fewer things to worry about, we are also able to =
improve performance for everyone.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 4 Jan 2024 17:45:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 04 12:45:50 2024 Received: from localhost ([127.0.0.1]:55615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rLRmw-0007u1-5n for submit <at> debbugs.gnu.org; Thu, 04 Jan 2024 12:45:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rLRmt-0007hD-W2 for 68244 <at> debbugs.gnu.org; Thu, 04 Jan 2024 12:45:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rLRmj-0003JO-4a; Thu, 04 Jan 2024 12:45:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=PqDKUhk32tdOZwpM6kgq5LhWvzUSkpR1NIVFSth3MAQ=; b=WDttqZ6YkGDfNq5Flsw8 eN7UOMIE8n6rd1PUYMAKaes0+J5P5a6ltVYp6+8e1YLdt0d+PpgFpf8MddbLOcnvJmpp833fl8bam D35ObrzINoBTsdVg1i8lB4mqAzZ0nYMm+AEOTViSsFYUdN0LeZA2uYyd6MN6Odd5j8OHSJGi1DsRE tEgbt5t2dfXKGZNOLZ3Q2JMjOhdGhcmcaeBeH989LqjX/4K/RVKDVlNbNMNnATWtb4qN0ymD4kulS jKiHpqKgJR8UJ3GMl0IZJUVOqB/Ess8kCOfRhLVFql6DmCwcHUPd2Cxw01micc545ps2de4rzxhQ9 PoiPzqdbMDbOrg==; Date: Thu, 04 Jan 2024 19:45:22 +0200 Message-Id: <83o7e1vvpp.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <4FC7642E-BAAF-40E3-AADC-0485AB085D6D@HIDDEN> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Thu, 4 Jan 2024 18:02:08 +0100) Subject: Re: bug#68244: hash-table improvements References: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN> <83r0ixvys9.fsf@HIDDEN> <4FC7642E-BAAF-40E3-AADC-0485AB085D6D@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68244 Cc: 68244 <at> debbugs.gnu.org, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Mattias Engdegård <mattias.engdegard@HIDDEN> > Date: Thu, 4 Jan 2024 18:02:08 +0100 > Cc: Stefan Monnier <monnier@HIDDEN>, > 68244 <at> debbugs.gnu.org > > 4 jan. 2024 kl. 17.39 skrev Eli Zaretskii <eliz@HIDDEN>: > > > Any data about the actual performance gains? > > Lots, naturally, but hash tables have many moving parts and performance is many-dimensional which is why I didn't include the raw data; it's voluminous and not always easy to interpret. Giving a single number as in 'now 20 % faster' is impossible if we want to stay honest, because there are so many different aspects, contexts and operations. It doesn't have to be a single number. Showing a series of separate benchmarks is also fine.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 4 Jan 2024 17:02:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 04 12:02:25 2024 Received: from localhost ([127.0.0.1]:55574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rLR6v-0008QJ-HX for submit <at> debbugs.gnu.org; Thu, 04 Jan 2024 12:02:25 -0500 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:50394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rLR6q-0008Q2-5x for 68244 <at> debbugs.gnu.org; Thu, 04 Jan 2024 12:02:24 -0500 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50e7d6565b5so800646e87.0 for <68244 <at> debbugs.gnu.org>; Thu, 04 Jan 2024 09:02:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704387730; x=1704992530; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=dikyA4I3s+509GSbvdV51kXgCPWuevNzCWd1UX66s+k=; b=JjfNvZ9VZmWpU8fjgEIC12TY4tKfHf1U+XoHA0a2VkS75XltAjhFoSRbVgYXiYD90B EBJYsNzQlOQA9q1sWMtgiy3HUQjuaweAqlqkYW+hAOuIccCQcJYNDBfw9nl4es5tl1TP t8VDX8mExFNepig58Vz7zLgfoLYuZ6B/4EmPdYjZhwGU1F+Ufk5TMQWLVncZltSXRK1J r5nluhN14l+XG5j31sGeeosOAi/ySoAdf9oDWCYy8K6YmXdFbhRLVvar3PPTLNp+PnUG LY5U54SJYw6nNxX9ORJnuioUo/Gb6W/0l6FxPorSYwUqA0x6uC1x+SaWMepBskaHCxcv ZZng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704387730; x=1704992530; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dikyA4I3s+509GSbvdV51kXgCPWuevNzCWd1UX66s+k=; b=A1+3CtCxWU6ZfftTmWFRT62rS6xhBbbZ3MnoIti22LSmMSH394MLfgh4M4owjNcoS4 vPm/XK3diZ1DyAzQsiayaoOlrL6LMu7Im8OioOMehSidFt6AKUz/8+ZCCV4FdiB1H/ER JCTxj2Ynva5LmBKn4WHPBdQ5NFRjXp84edcvG8gqzr5GEUQ4zkLsNkZ7GQnmSONAwlqT DZ4vBzC6RVlicFHfsLfMFyeqN99ClTAofmxyIu1Z5kZjAfIWkpo0wdddfjwVRSG2T6EJ TNax7elC8jwLSsFwDTW5+8AFP/3hOwb7Ls4sUFZIqtnJv2znrq3TSrBt8qf3AMrwBjIg WdTA== X-Gm-Message-State: AOJu0YyizBxWin6Te2B9Macxtkk0fZafNwCmW4k4IjSkKZj69EiiTlKz bxiGoG+tnl7FylKLIzc2oj8= X-Google-Smtp-Source: AGHT+IFGFtwmATa+tq86Jf/9xxZtYhm+vQL1jAZaZIHvf4EV4jzRMhYPbDerVwLnTa1zct7FRvZ2+A== X-Received: by 2002:ac2:592f:0:b0:50e:7be3:c706 with SMTP id v15-20020ac2592f000000b0050e7be3c706mr487247lfi.21.1704387729847; Thu, 04 Jan 2024 09:02:09 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id w15-20020ac2598f000000b0050e8d0c5efdsm2056023lfn.61.2024.01.04.09.02.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jan 2024 09:02:09 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68244: hash-table improvements From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <83r0ixvys9.fsf@HIDDEN> Date: Thu, 4 Jan 2024 18:02:08 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <4FC7642E-BAAF-40E3-AADC-0485AB085D6D@HIDDEN> References: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN> <83r0ixvys9.fsf@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68244 Cc: 68244 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 4 jan. 2024 kl. 17.39 skrev Eli Zaretskii <eliz@HIDDEN>: > Any data about the actual performance gains? Lots, naturally, but hash tables have many moving parts and performance = is many-dimensional which is why I didn't include the raw data; it's = voluminous and not always easy to interpret. Giving a single number as = in 'now 20 % faster' is impossible if we want to stay honest, because = there are so many different aspects, contexts and operations. The reforms so far actually don't change the basic algorithms or data = structures much but concentrate on slimming the internal and external = representation, both of which are basically guaranteed to provide = performance gains (and they do). External representation improvements means that printing and reading is = substantially faster, especially for small tables (otherwise most of the = time is just spent printing and reading the data), but many tables are = small. Internal representation means that we now use much less memory for the = basic hash table objects and for the tables, and even more importantly = avoid expensive GC involvement where not absolutely necessary. This = gives some measurable speed-up itself, but provides benefits for other = code. I do want to change some of the hashing and range reduction code, = though, but this requires even more careful benchmarking to be sure that = we don't end up with any surprises.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at 68244) by debbugs.gnu.org; 4 Jan 2024 16:39:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 04 11:39:45 2024 Received: from localhost ([127.0.0.1]:55525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rLQky-0002Wt-Un for submit <at> debbugs.gnu.org; Thu, 04 Jan 2024 11:39:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rLQkw-0002Wa-1A for 68244 <at> debbugs.gnu.org; Thu, 04 Jan 2024 11:39:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rLQkk-00084Y-Us; Thu, 04 Jan 2024 11:39:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=SFsT7pA1yMZQprxTAC4oSWejIjPke+Pjs6iDMb2aA+A=; b=MvVHClVP7DHcxNdEDZi+ ZVrbl9QdJpfo5bQ/LG7cB5nhmvJxK6LAxBo+lVlsksRLa1KV9LwRLXVjPx48tRaSEj8bcjlgxuh9e TpEOnYLUq1pv8P12GeItvsirwHHmw9Z28yP6Ow2wLYfToxlcwZGubWa7vep1BZX/Iva6hFmBloY3S cAJp3FtvfwoNhrm1nL+H/x/MzMP+xa88uJoKrRA1cjl7pFrR+bHehIVuE3hNYueA8o4P+ojZtw2dQ cry4rleaOT/6yD28thwpkRTKPDQCW0ub8QFtA2yPTKVTg2cbqtmCflPbiEKlIxwRY6rnkbyObSkP9 CBhd241jsYPtyQ==; Date: Thu, 04 Jan 2024 18:39:02 +0200 Message-Id: <83r0ixvys9.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>, Stefan Monnier <monnier@HIDDEN> In-Reply-To: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Thu, 4 Jan 2024 17:27:53 +0100) Subject: Re: bug#68244: hash-table improvements References: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68244 Cc: 68244 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Mattias Engdegård <mattias.engdegard@HIDDEN> > Date: Thu, 4 Jan 2024 17:27:53 +0100 > > It's the hash-table's turn to be subjected to some performance tuning. The implementation has changed very little over the years and it's not so much a matter of a single big thing to fix as many small ones, so the list of changes is fairly long but ever little helps. > > A working patch series can be found in the scratch/hash-table-perf branch. Although it should all be satisfactory and an improvement on what was before, there are a couple of details that I'd like to do better, which is why this hasn't been merged yet: the way shared hash_table_test structs are cached isn't very elegant, nor is the way we deal with Qunbound in pdumper.c. Thanks. Any data about the actual performance gains? Adding Stefan to the discussion, in case he has comments and suggestions.
bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 4 Jan 2024 16:28:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 04 11:28:12 2024 Received: from localhost ([127.0.0.1]:55502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rLQZo-00084a-CA for submit <at> debbugs.gnu.org; Thu, 04 Jan 2024 11:28:12 -0500 Received: from lists.gnu.org ([2001:470:142::17]:33088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rLQZj-000840-8H for submit <at> debbugs.gnu.org; Thu, 04 Jan 2024 11:28:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mattias.engdegard@HIDDEN>) id 1rLQZZ-0006pT-Rb for bug-gnu-emacs@HIDDEN; Thu, 04 Jan 2024 11:27:57 -0500 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <mattias.engdegard@HIDDEN>) id 1rLQZY-0001xr-9W for bug-gnu-emacs@HIDDEN; Thu, 04 Jan 2024 11:27:57 -0500 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2cd053d5683so8228711fa.2 for <bug-gnu-emacs@HIDDEN>; Thu, 04 Jan 2024 08:27:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704385674; x=1704990474; darn=gnu.org; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=UgeSveNzk8zLvh2NJMCMRh4TktcdLMjRTWfMz9WTCsQ=; b=U/ozGLCDdXgm4GJzGVSB2O33suZGmNel4wy4SsZ3IquCS+rrqNtelEGnD4H5ISA//5 cwsiSco3zXYlo8YTwfKnMq0nKs46ucrSZ0vhY9MYr72L/ngB2g1pCWOGITAT1Y5i84Ab nQOfRTUVg6cmifVw6is6szh7sSW0y+R8QLn3xgKajAH4YX7+CA/VO8Iu7o0qw1QVZ1g5 gzJtyx0ok0rakeZ9AQwE2ZOvTdaUMOSpU6lr5yQ8x95MwXn+gWqARRaAGeh0rVFU5Vlq 3UULPyUchNIxiA+FKDzazUcmgJxyVUDpCV6gyAri3D0slXccTzAtNbayw8qt4+v9km7C gh1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704385674; x=1704990474; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UgeSveNzk8zLvh2NJMCMRh4TktcdLMjRTWfMz9WTCsQ=; b=hoJEYU3fZcrhK70S+gPSM7RWgQa4uhOYvo4a4Zr60LFEqI/qnTxD0jtb+Uf/GM++m9 jCxqk9hgb5rV5JA4T1clFKT5wxezTRE5PuCglGx3fgS3sp0ykpB9U9ek39oOLWVDJNSv 7McecbceN4Fv7ZIJ9XBgmybiqjjUT+n2/pNm+q9Z04/jgtrUJhv7E1UoMd/6yNZeiN8K sbUoYrLeAE37DcUcqKbwuRBX9QSPAuA3Sw6RUdMgP2GntR4nPZRSNiJvVS6UjMALKpa5 uLg5xbSUVxztJz7UrKyVMaHFchwLULTrc7oBMTiG+ndvp9SlJADOOccy70GDWzC/gbia pl/w== X-Gm-Message-State: AOJu0Yw2/CSyRalKkpNQ+sdYsR7zkJZShYGqhVBrUL+Y/61Tk9Kw+cj0 GN63APdfjasY+m8/AjKXfDKSbn2Puyk= X-Google-Smtp-Source: AGHT+IFp1DV4X3Wm/baq1FwTOe0qb/gba/HpVifahD6ZOUSFQai2KoLFfuqJVzWY2x9fQLhRl9WqPQ== X-Received: by 2002:a2e:494a:0:b0:2cc:75c7:e7f4 with SMTP id b10-20020a2e494a000000b002cc75c7e7f4mr431510ljd.55.1704385674316; Thu, 04 Jan 2024 08:27:54 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id s6-20020a2ea106000000b002cd12db0546sm1021868ljl.117.2024.01.04.08.27.53 for <bug-gnu-emacs@HIDDEN> (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jan 2024 08:27:54 -0800 (PST) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: hash-table improvements Message-Id: <A4D8655E-B729-4C7A-99D6-D8FC7A3CF617@HIDDEN> Date: Thu, 4 Jan 2024 17:27:53 +0100 To: Emacs Bug Report <bug-gnu-emacs@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::229; envelope-from=mattias.engdegard@HIDDEN; helo=mail-lj1-x229.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) It's the hash-table's turn to be subjected to some performance tuning. = The implementation has changed very little over the years and it's not = so much a matter of a single big thing to fix as many small ones, so the = list of changes is fairly long but ever little helps. A working patch series can be found in the scratch/hash-table-perf = branch. Although it should all be satisfactory and an improvement on = what was before, there are a couple of details that I'd like to do = better, which is why this hasn't been merged yet: the way shared = hash_table_test structs are cached isn't very elegant, nor is the way we = deal with Qunbound in pdumper.c.
Mattias Engdegård <mattias.engdegard@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#68244; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.