GNU bug report logs - #68250
[PATCH v2] gnu: mpv: Fix pkgconfig file.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Hilton Chain <hako@HIDDEN>; Keywords: patch; dated Fri, 5 Jan 2024 05:08:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 68250 <at> debbugs.gnu.org:


Received: (at 68250) by debbugs.gnu.org; 19 Jan 2024 02:05:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 18 21:05:54 2024
Received: from localhost ([127.0.0.1]:57064 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rQeGX-0006k3-Vg
	for submit <at> debbugs.gnu.org; Thu, 18 Jan 2024 21:05:54 -0500
Received: from mail-qv1-xf31.google.com ([2607:f8b0:4864:20::f31]:61910)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1rQeGU-0006jk-T5
 for 68250 <at> debbugs.gnu.org; Thu, 18 Jan 2024 21:05:52 -0500
Received: by mail-qv1-xf31.google.com with SMTP id
 6a1803df08f44-68174626bb9so2259916d6.3
 for <68250 <at> debbugs.gnu.org>; Thu, 18 Jan 2024 18:05:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1705629943; x=1706234743; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=/62Rlj6DoHWdvj6SdJwHUsyxwrpcNcwDZyzSpPcDlu0=;
 b=Tan05v7IciqNe+fGc0HbjbC71yaYI0WPtPiVDVwUO77wmOIZbaE9KwGKPbAwa9FTAP
 m2aKBdquBYytgBMGn8MNvq85RcdxYi568Al5Q60U5z3si3jV4Njr+rmEKTY73ZW01Ci8
 1EZCVDjzscfNi1x5WnE80Mf+yJpvJ5MZ67rjLZKXSsNGzMVyfj0dtAdcGUYrdSJTV3pd
 hEORijzDSmPmqktQeHY/PeNjN9d4QykFO25+Ylw81pLf1BUMIdMsCdKJDIHXYYfsgaGM
 45P2J3uxQBtSFmobtKoefb5hH5HIYvw+ZlZyOYi5zSevRTDdPHbYVjOMKsv2UQeYFikQ
 Ntow==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1705629943; x=1706234743;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
 :to:cc:subject:date:message-id:reply-to;
 bh=/62Rlj6DoHWdvj6SdJwHUsyxwrpcNcwDZyzSpPcDlu0=;
 b=hjN8DmRy1Pz3hHcLqkxKptFRSw9mNLeZuWWBjMsATa3sDkve1aSbHXuI1dT47Kk5C0
 iD1NaJVt754Rs+driutXvIrMiwo9wu4ivQGbvLPsvARFAN0XrHoodRAzjQsNyqYkuKFS
 +5VBptNIOWWyXnX59rPshO7Cm003eqxvDruRiQIqOEHSkniZGa8fltfn4mouGU+7g6AU
 Ok+1iyaDhfnjgkbVp8OrqryQH/9q4TufkCmEpHsviZvVWsReTYrFX0Qip4mLFK+T38kG
 Vi0hzFDPWILfyE6i8+Vj7QC2bFL+sgMf8Pey7JRaH0jc93gcNtUwVi8VZoQMEthB2F9a
 ZkVw==
X-Gm-Message-State: AOJu0YyR1NCjpmMetOSBE0CLYuOjWIIyB8TYnCvDi1BLAKhjwjNFQL+Q
 HXconERhPjeHeNDvhsjxiBQS/7fKdN0vnloDsfqB6hi7zZAJVUSc
X-Google-Smtp-Source: AGHT+IHxgPS1y5jcXfvVzsjIjFvaWraUlQ2UmwnbFaVmvM4GubFMYNRhKS2I6Ep68CJp3FeNmd3wJA==
X-Received: by 2002:a05:6214:1bcf:b0:681:789f:4358 with SMTP id
 m15-20020a0562141bcf00b00681789f4358mr2068266qvc.39.1705629943319; 
 Thu, 18 Jan 2024 18:05:43 -0800 (PST)
Received: from hurd (dsl-10-132-160.b2b2c.ca. [72.10.132.160])
 by smtp.gmail.com with ESMTPSA id
 oh10-20020a056214438a00b0068187f22739sm1356864qvb.39.2024.01.18.18.05.42
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 18 Jan 2024 18:05:42 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Hilton Chain <hako@HIDDEN>
Subject: Re: bug#68250: [PATCH v2] gnu: mpv: Fix pkgconfig file.
In-Reply-To: <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@HIDDEN>
 (Hilton Chain's message of "Sat, 6 Jan 2024 12:23:49 +0800")
References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@HIDDEN>
 <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@HIDDEN>
Date: Thu, 18 Jan 2024 21:05:41 -0500
Message-ID: <8734uukrgq.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68250
Cc: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@HIDDEN>, 68250 <at> debbugs.gnu.org,
 Munyoki Kilyungi <me@HIDDEN>,
 Zheng Junjie <zhengjunjie@HIDDEN>, Lars-Dominik Braun <lars@HIDDEN>,
 Josselin Poiret <dev@HIDDEN>, Andrew Tropin <andrew@HIDDEN>,
 jgart <jgart@HIDDEN>, Marius Bakke <marius@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

Hilton Chain <hako@HIDDEN> writes:

> This is a follow-up to ce7b2b57aa6da0ceace94ea5fb42392c7ff97d53.
>
> * gnu/packages/video.scm (mpv)[arguments]<#:phases>: Add 'fix-mpv.pc.
>
> Suggested-by: =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@HIDDEN>
> Change-Id: I9826d5d6c957ca3022fa326aee111edb533f05bc
> ---
>  gnu/packages/video.scm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index e70aa5352e..10d46db38b 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -2365,7 +2365,13 @@ (define-public mpv
>                ;; and passed as linker flags, but the order in which they=
 are added
>                ;; varies.  See <https://github.com/mpv-player/mpv/issues/=
7855>.
>                ;; Set PYTHONHASHSEED as a workaround for deterministic re=
sults.
> -              (setenv "PYTHONHASHSEED" "1"))))
> +              (setenv "PYTHONHASHSEED" "1")))
> +          ;; mpv.pc is generated by meson.  libmpv's headers don't actua=
lly
> +          ;; require these dependencies so it's safe to remove these two=
 fields.
> +          (add-after 'install 'fix-mpv.pc
> +            (lambda _
> +              (substitute* (string-append #$output "/lib/pkgconfig/mpv.p=
c")
> +                (("^(Requires|Libs)\\.private:.*") "")))))
>        #:configure-flags
>        #~(list "-Dlibmpv=3Dtrue"
>                "-Dcdda=3Denabled"

I've just seen this, after pushing a hot fix as
f3fdb4e041cb5740ba0b38b9ad017571f8414d33, which propagates all listed
libraries in Requires.private.

I suppose that someone wanting to build something statically from mpv
would benefit from having the original mpv.pc file without
modifications.

Perhaps we can try it out for a bit, and if the propagation causes
problems, we can fall-back to this change here?

--=20
Thanks,
Maxim




Information forwarded to guix-patches@HIDDEN:
bug#68250; Package guix-patches. Full text available.

Message received at 68250 <at> debbugs.gnu.org:


Received: (at 68250) by debbugs.gnu.org; 13 Jan 2024 06:48:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 13 01:48:58 2024
Received: from localhost ([127.0.0.1]:38217 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOXpB-0007zm-PS
	for submit <at> debbugs.gnu.org; Sat, 13 Jan 2024 01:48:58 -0500
Received: from mail.boiledscript.com ([144.168.59.46]:35134)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <hako@HIDDEN>) id 1rOXp7-0007zc-A9
 for 68250 <at> debbugs.gnu.org; Sat, 13 Jan 2024 01:48:56 -0500
Date: Sat, 13 Jan 2024 14:48:35 +0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space;
 s=dkim; t=1705128520;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=6A24SpaekR/youQcO1j7ojQ1l4hGATBzWKpfcEwhZG0=;
 b=eT9/8LSFAmGLYIZD9BNKRFXajQq6A+dGeLW8xIv+fL7EY3YYBx7+YO+oiR/4DnzJJs6YY+
 e3kIOeoEsI+5gAt5v7GxijqFmLVNiRB6WkfOZeLSSYURwtnMVZWCMBdg8XVsYPPWCI9sev
 PnQVaTgI1FGW+L9wH6SD+arm2BhwftIVya5wECMoXm8x2wHLxDt+n3R2o8yOJmuTpo2tTv
 DWAPb5NgruznVvPNpQE7DccIZCucD1+EIpC0x5W5CF48zn3TbRJtqDcci8ahAW1KCMS/X4
 utksBH3WnhLVNBD2+T3WDIGmuoMctJd4vpDY5qqC1miBKLy1+uXL6/iQbzPd8w==
Authentication-Results: mail.boiledscript.com;
 auth=pass smtp.mailfrom=hako@HIDDEN
Message-ID: <871qalvid8.wl-hako@HIDDEN>
From: Hilton Chain <hako@HIDDEN>
To: Josselin Poiret <dev@HIDDEN>
Subject: Re: [bug#68250] [PATCH v2] gnu: mpv: Fix pkgconfig file.
In-Reply-To: <875y01hwrz.fsf@HIDDEN>
References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@HIDDEN>	<14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@HIDDEN>	<875y01hwrz.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spamd-Bar: /
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68250
Cc: =?ISO-2022-JP?B?GyRCQVdKOElwGyhC?= <iyzsong@HIDDEN>,
 68250 <at> debbugs.gnu.org, Munyoki Kilyungi <me@HIDDEN>,
 Zheng Junjie <zhengjunjie@HIDDEN>, Lars-Dominik Braun <lars@HIDDEN>,
 Andrew Tropin <andrew@HIDDEN>, jgart <jgart@HIDDEN>,
 Marius Bakke <marius@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Josselin,

On Thu, 11 Jan 2024 02:24:16 +0800,
Josselin Poiret wrote:
>
> [1  <text/plain (quoted-printable)>]
> Hi Hilton,
>
> Hilton Chain <hako@HIDDEN> writes:
>
> > This is a follow-up to ce7b2b57aa6da0ceace94ea5fb42392c7ff97d53.
> >
> > * gnu/packages/video.scm (mpv)[arguments]<#:phases>: Add 'fix-mpv.pc.
>
> Does this completely replace the previous patch, instead of augmenting it?

Yes!  I should clarify this before.




Information forwarded to guix-patches@HIDDEN:
bug#68250; Package guix-patches. Full text available.

Message received at 68250 <at> debbugs.gnu.org:


Received: (at 68250) by debbugs.gnu.org; 10 Jan 2024 18:24:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 10 13:24:40 2024
Received: from localhost ([127.0.0.1]:43070 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rNdFo-0000h0-9v
	for submit <at> debbugs.gnu.org; Wed, 10 Jan 2024 13:24:40 -0500
Received: from jpoiret.xyz ([206.189.101.64]:58122)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1rNdFl-0000gp-RD
 for 68250 <at> debbugs.gnu.org; Wed, 10 Jan 2024 13:24:38 -0500
Received: from authenticated-user (jpoiret.xyz [206.189.101.64])
 by jpoiret.xyz (Postfix) with ESMTPA id 2B297185446;
 Wed, 10 Jan 2024 18:24:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim;
 t=1704911077;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=QxUEAhFEQS2nEvAVdx+4xl/RzCrEm9os2U03MxG33ww=;
 b=W8qF/lGHtvxzE3HSVm1x88CMmirLvc6jk/naj/sD5GoFjoplfyhsHn5oTmCXw/uj0hB3AW
 K+OhJWYM2Iynk24VtRyT0WNEDyOuX8w1Vx/pEpmMxNJt/VSOzwdQEbJNIY+Jt3fLTC9I5S
 n2n9//zbi9E7Ag84XAAfIaANWE8xh6nf9JXSn8266Cfb4VvArtgq9mkr4u1jZpgiK7jELs
 JeLwe+PmbjNEXDEWGIkSiKNARwzKzivbSIo7rwDoxR+WB5UA6+YCngT6n318Z4X664CAY6
 XG30iGYzkrqX0kLjNVFxKLpj1SxBdaEBWt3Q2GOgj+66txs1gGkp8UuVgld91w==
From: Josselin Poiret <dev@HIDDEN>
To: Hilton Chain <hako@HIDDEN>, 68250 <at> debbugs.gnu.org
Subject: Re: [bug#68250] [PATCH v2] gnu: mpv: Fix pkgconfig file.
In-Reply-To: <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@HIDDEN>
References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@HIDDEN>
 <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@HIDDEN>
Date: Wed, 10 Jan 2024 19:24:16 +0100
Message-ID: <875y01hwrz.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spam-Level: *
X-Spamd-Bar: +
Authentication-Results: jpoiret.xyz;
 auth=pass smtp.auth=jpoiret@HIDDEN smtp.mailfrom=dev@HIDDEN
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Hi Hilton, Hilton Chain <hako@HIDDEN> writes: > This
 is a follow-up to ce7b2b57aa6da0ceace94ea5fb42392c7ff97d53. > > *
 gnu/packages/video.scm
 (mpv)[arguments]<#:phases>: Add 'fix-mpv.pc. 
 Content analysis details:   (3.0 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 3.0 MANY_TO_CC             Sent to 10+ recipients
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
X-Debbugs-Envelope-To: 68250
Cc: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@HIDDEN>,
 Munyoki Kilyungi <me@HIDDEN>,
 Zheng Junjie <zhengjunjie@HIDDEN>, Lars-Dominik Braun <lars@HIDDEN>,
 Andrew Tropin <andrew@HIDDEN>, Hilton Chain <hako@HIDDEN>,
 jgart <jgart@HIDDEN>, Marius Bakke <marius@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi Hilton,

Hilton Chain <hako@HIDDEN> writes:

> This is a follow-up to ce7b2b57aa6da0ceace94ea5fb42392c7ff97d53.
>
> * gnu/packages/video.scm (mpv)[arguments]<#:phases>: Add 'fix-mpv.pc.

Does this completely replace the previous patch, instead of augmenting it?

Best,
=2D-=20
Josselin Poiret

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQHEBAEBCAAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmWe4NAQHGRldkBqcG9p
cmV0Lnh5egAKCRBQXkC5FhcaihZfDACM1eHR2b6sjIjiLQuDGRgfkfymdEIvz+Xm
nxJ7SAz5EhpGkJF/ftigLHQiLDZJ3WMf+A9IEMSr50uxaQNPDwq6tGgk/Gf/eVlU
GbsJS53jfCtHfNazu/MOS1ZWcqwUvQuugx2v3iWIMFkyRJrClW9S9d/3z+SzlcLs
9Z04hwDBzWd+nizakzv1+50Jk3YAvwC4xEADjBYsr1bBK85HpPknaIcK+vhXWr5Y
rB17WBCUMmG+FilyWUwZir3fjH2yKp1msKk8HheXnzvFzXGtzJEjXm7FByI7uEdI
W02VBtymvnm7LsjE+dbSA6YQdPUdoCMKnLrfpI3vXbmTcvSMy+wUXY4bcuf3Q1gf
e2rGsCmJPdhFJtSJQqAZ5QwRCpR+l4FHMAsnVkmguONr6iN23KVBm9LFK2ewKFoc
hqCC313xVogNtVVSnfAYdjEMWK5++ZZ/YQt9KxY7hiO05a1I5RBiYreCHBlKdQ7b
S8R7uYrCFgW3j/HK56f5rr0gGbkinG8=
=cvTE
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#68250; Package guix-patches. Full text available.
Changed bug title to '[PATCH v2] gnu: mpv: Fix pkgconfig file.' from '[PATCH] gnu: Add libmpv.' Request was from Hilton Chain <hako@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 68250 <at> debbugs.gnu.org:


Received: (at 68250) by debbugs.gnu.org; 6 Jan 2024 04:29:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 05 23:29:42 2024
Received: from localhost ([127.0.0.1]:58278 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rLyJZ-0001B2-Uc
	for submit <at> debbugs.gnu.org; Fri, 05 Jan 2024 23:29:42 -0500
Received: from mail.boiledscript.com ([144.168.59.46]:37398)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <hako@HIDDEN>) id 1rLyJW-0001Ar-KF
 for 68250 <at> debbugs.gnu.org; Fri, 05 Jan 2024 23:29:40 -0500
From: Hilton Chain <hako@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space;
 s=dkim; t=1704515341;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=ZYosqGfqk6F3FwxXQYoJh7Z7payyadTyszvFwkdJ2gg=;
 b=E+BXHadBndU2pZ8nX3oT4iO6wK6cYUxetJ/qnoS449zUKym1XzsvEDATqj2rDRIFQd14zb
 4NTTdWpGKD81pCZfm/VzEPhAbdpfZBVu+RLE9S0uWgBa3mBQ/tqyfKwTAAn1M2dJo155+e
 DzgP1XZVXc4ezydSk1uxDSNwRiFcflYux6/ox1WXWWIyl4kYlG5tI8siA/52uheO5vSgvi
 ti5TWM2wN2O6GXwepUV97bIVNZav3hqKHsklEI92BVKrnORSKaoWZzKpPHBHA4+wSiW9M+
 xcwJnQIVObilmaHJtcHap8RrAtPpa/WOKzf17kzHxQF1jXCMGyW1qnnlwWOmGg==
Authentication-Results: mail.boiledscript.com;
 auth=pass smtp.mailfrom=hako@HIDDEN
To: 68250 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: mpv: Fix pkgconfig file.
Date: Sat,  6 Jan 2024 12:23:49 +0800
Message-ID: <14315fb383a6560c67bdc6bf3f7cab8b8e36e0bb.1704514279.git.hako@HIDDEN>
In-Reply-To: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@HIDDEN>
References: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@HIDDEN>
X-Debbugs-Cc: Hilton Chain <hako@HIDDEN>, 宋文武 <iyzsong@HIDDEN>, Lars-Dominik Braun <lars@HIDDEN>, Marius Bakke <marius@HIDDEN>, Munyoki Kilyungi <me@HIDDEN>, jgart <jgart@HIDDEN>, Andrew Tropin <andrew@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Zheng Junjie <zhengjunjie@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spamd-Bar: ---
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68250
Cc: Hilton Chain <hako@HIDDEN>,
 =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This is a follow-up to ce7b2b57aa6da0ceace94ea5fb42392c7ff97d53.

* gnu/packages/video.scm (mpv)[arguments]<#:phases>: Add 'fix-mpv.pc.

Suggested-by: 宋文武 <iyzsong@HIDDEN>
Change-Id: I9826d5d6c957ca3022fa326aee111edb533f05bc
---
 gnu/packages/video.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index e70aa5352e..10d46db38b 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2365,7 +2365,13 @@ (define-public mpv
               ;; and passed as linker flags, but the order in which they are added
               ;; varies.  See <https://github.com/mpv-player/mpv/issues/7855>.
               ;; Set PYTHONHASHSEED as a workaround for deterministic results.
-              (setenv "PYTHONHASHSEED" "1"))))
+              (setenv "PYTHONHASHSEED" "1")))
+          ;; mpv.pc is generated by meson.  libmpv's headers don't actually
+          ;; require these dependencies so it's safe to remove these two fields.
+          (add-after 'install 'fix-mpv.pc
+            (lambda _
+              (substitute* (string-append #$output "/lib/pkgconfig/mpv.pc")
+                (("^(Requires|Libs)\\.private:.*") "")))))
       #:configure-flags
       #~(list "-Dlibmpv=true"
               "-Dcdda=enabled"

base-commit: c0e21e523d93081153a2ffc91e5a9f06afe62b91
--
2.41.0




Information forwarded to hako@HIDDEN, iyzsong@HIDDEN, lars@HIDDEN, marius@HIDDEN, me@HIDDEN, jgart@HIDDEN, andrew@HIDDEN, dev@HIDDEN, zhengjunjie@HIDDEN, guix-patches@HIDDEN:
bug#68250; Package guix-patches. Full text available.

Message received at 68250 <at> debbugs.gnu.org:


Received: (at 68250) by debbugs.gnu.org; 5 Jan 2024 05:09:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 05 00:09:40 2024
Received: from localhost ([127.0.0.1]:56158 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rLcSh-0000OP-OO
	for submit <at> debbugs.gnu.org; Fri, 05 Jan 2024 00:09:40 -0500
Received: from mail.boiledscript.com ([144.168.59.46]:50346)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <hako@HIDDEN>)
 id 1rLcSe-0000Nv-2v; Fri, 05 Jan 2024 00:09:37 -0500
Date: Fri, 05 Jan 2024 13:09:17 +0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space;
 s=dkim; t=1704431341;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=6aB32GasFbSIjCLyzzzrrqdM2HhmxOYhQdIX5tiiKnM=;
 b=pxEkWCU+Ex2ftdMwBoDqWdIlkd4JKmpy27HEJsFs6Zqas43S/0dARsI87qyQV7SXQH24vu
 mV9Ws888W/emZf+fUn8+/v/hjMtFOAY/graiTEhNwRYLRCycV6N2jXx6xiF+1XZ14aqJ3P
 pE6Svoqh4ywbxAsjoSjlM67zP6HR0ZweTC/E00C3gC1gpgPA8O2ijC/WwFHU7zExXaSCDM
 qqkXcHaZ77c9O6DGhd+K/ckoeOmZYxCJSr4aX98DLO8dAqLCwQs/aGhlwI/h/Uv/faJ2j+
 RgBWgQX7W2z4s3TBKwL2YkiQrD33/SPJi80p5MNYAupiQe44U42YVKtp37qFqQ==
Authentication-Results: mail.boiledscript.com;
 auth=pass smtp.mailfrom=hako@HIDDEN
Message-ID: <87sf3c5ptu.wl-hako@HIDDEN>
From: Hilton Chain <hako@HIDDEN>
To: Andrew Tropin <andrew@HIDDEN>
Subject: Re: bug#67814: [PATCH 0/3] gnu: mpv: Update to 0.37.0.
In-Reply-To: <87sf3q1ppm.fsf@HIDDEN>
References: <cover.1702486251.git.zhengjunjie@HIDDEN>	<87ttoatigz.wl-hako@HIDDEN>	<87sf3q1ppm.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spamd-Bar: /
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68250
Cc: 68044 <at> debbugs.gnu.org, Josselin Poiret <dev@HIDDEN>,
 Zheng Junjie <zhengjunjie@HIDDEN>, 68250 <at> debbugs.gnu.org,
 67814 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

On Mon, 25 Dec 2023 19:33:41 +0800,
Andrew Tropin wrote:
>
> Hi Hilton!
>
> It seem the mpv update breaks mpv-mpris build.  I didn't dive into
> issue yet, only tried to revert this patch.

It's because mpv's pkgconfig file (for libmpv) now includes all its
dependencies in Requires.private.  Sorry that I didn't check all the
dependent packages.

Josselin has sent bug#68044, which adds mpv's inputs to mpv-mpris.

However there're actually other packages depend on libmpv, so I think
the proper fix is to split libmpv from the mpv package and propagate
inputs in a new package (as mpv users are likely to include mpv in
their profiles, thus these propagated inputs are usually unwanted).

I tried to add a "lib" output for mpv first but there would be cycles.
As a result, I disabled libmpv in mpv, added a libmpv package which
inherits from mpv, and sent it to bug#68250.

Thanks




Information forwarded to guix-patches@HIDDEN:
bug#68250; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 5 Jan 2024 05:07:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 05 00:07:21 2024
Received: from localhost ([127.0.0.1]:56146 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rLcQT-0000K4-EE
	for submit <at> debbugs.gnu.org; Fri, 05 Jan 2024 00:07:21 -0500
Received: from lists.gnu.org ([2001:470:142::17]:43430)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <hako@HIDDEN>) id 1rLcQO-0000Jo-Mg
 for submit <at> debbugs.gnu.org; Fri, 05 Jan 2024 00:07:20 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <hako@HIDDEN>)
 id 1rLcQE-0000OA-VT
 for guix-patches@HIDDEN; Fri, 05 Jan 2024 00:07:07 -0500
Received: from mail.boiledscript.com ([144.168.59.46])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <hako@HIDDEN>)
 id 1rLcQC-0007o6-Q0
 for guix-patches@HIDDEN; Fri, 05 Jan 2024 00:07:06 -0500
From: Hilton Chain <hako@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space;
 s=dkim; t=1704431190;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:
 content-transfer-encoding:content-transfer-encoding;
 bh=ytJREIQufEQ/R/uNA1NQYlIS8XnSwxNvMy9390I2pdQ=;
 b=0hv9BL2buKyMPS9dkWyVsPkNQuQy+8A48ftPFrF2TnOgk04YygLJFJgTEBvGOsXlrI4s8v
 rewzg9REkKpOpIjAvswllTced6e5VIJWuOQuI6anmYGwHzmbqec74v5KTLxW4eLtOcABSr
 RSlkHS2z8w0OtMPSmnXV1gxPhpQ2b7zupNmjZU5/npWG+rlo9IPTtHFxJCCKDKRy1AvQZQ
 LHUtR5ceZsHqrl0yOtweFvFI3nB0PJzn9SB/gRA9XikilCC8myEzYVW4/ND6L3ivfYXF00
 wZHXEmReFUlFbv9MNfJp/wqHrkH5w5I1q2+ioZhrj0UqwTT4osygvpm1WOs5gQ==
Authentication-Results: mail.boiledscript.com;
 auth=pass smtp.mailfrom=hako@HIDDEN
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: Add libmpv.
Date: Fri,  5 Jan 2024 13:06:17 +0800
Message-ID: <521d0ba6e3d10b3b8aa98b35862d819c82223412.1704430613.git.hako@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Lars-Dominik Braun <lars@HIDDEN>, Marius Bakke <marius@HIDDEN>,
 Munyoki Kilyungi <me@HIDDEN>, jgart <jgart@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spamd-Bar: +
X-Spam-Level: *
Received-SPF: pass client-ip=144.168.59.46; envelope-from=hako@HIDDEN;
 helo=mail.boiledscript.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: Hilton Chain <hako@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

* gnu/packages/video.scm (libmpv): New variable.
(mpv)[arguments]<#:configure-flags>: Remove libmpv library.
(celluloid,mpv-mpris)[inputs]: Replace mpv with libmpv.
* gnu/packages/kde-plasma.scm (plasmatube)[inputs]: Likewise.
* gnu/packages/python-xyz.scm (python-mpv)[inputs]: Likewise.

Change-Id: I7c0a808f9d54f9bfd98b3d2632316c7d58b67896
---
 gnu/packages/kde-plasma.scm |  2 +-
 gnu/packages/python-xyz.scm |  2 +-
 gnu/packages/video.scm      | 24 ++++++++++++++++++++----
 3 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm
index 331ab28cd1..0527fa136a 100644
--- a/gnu/packages/kde-plasma.scm
+++ b/gnu/packages/kde-plasma.scm
@@ -1611,12 +1611,12 @@ (define-public plasmatube
      (list kconfig
            kirigami
            ki18n
+           libmpv
            qtbase-5
            qtdeclarative-5
            qtmultimedia-5
            qtquickcontrols2-5
            qtsvg-5
-           mpv
            youtube-dl))
     (home-page "https://apps.kde.org/plasmatube/")
     (synopsis "Kirigami YouTube video player")
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 2afce6c667..b23eaaadfc 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -33948,7 +33948,7 @@ (define-public python-mpv
                    (setenv "HOME" (getcwd)))))))
     (native-inputs
      (list python-xvfbwrapper)) ; needed for tests only
-    (inputs (list mpv))
+    (inputs (list libmpv))
     (propagated-inputs (list python-pillow)) ; for raw screenshots
     (home-page "https://github.com/jaseg/python-mpv")
     (synopsis "Python interface to the mpv media player")
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 6da4897a57..b532181225 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -867,7 +867,7 @@ (define-public celluloid
       pkg-config
       python-wrapper))             ; for generate-authors.py
     (inputs
-     (list gtk libadwaita libepoxy mpv))
+     (list gtk libadwaita libepoxy libmpv))
     (home-page "https://github.com/celluloid-player/celluloid")
     (synopsis "GTK+ frontend for the mpv media player")
     (description "Celluloid is a simple GTK+ frontend for the mpv media player.
@@ -2367,8 +2367,7 @@ (define-public mpv
               ;; Set PYTHONHASHSEED as a workaround for deterministic results.
               (setenv "PYTHONHASHSEED" "1"))))
       #:configure-flags
-      #~(list "-Dlibmpv=true"
-              "-Dcdda=enabled"
+      #~(list "-Dcdda=enabled"
               "-Ddvdnav=enabled"
               "-Dbuild-date=false")))
     (native-inputs
@@ -2422,6 +2421,23 @@ (define-public mpv
 projects while introducing many more.")
     (license license:gpl2+)))
 
+(define-public libmpv
+  (package
+    (inherit mpv)
+    (name "libmpv")
+    (arguments
+     (substitute-keyword-arguments (package-arguments mpv)
+       ((#:configure-flags flags ''())
+        #~(cons* "-Dcplayer=false"
+                 "-Dlibmpv=true"
+                 #$flags))))
+    (native-inputs
+     (modify-inputs (package-native-inputs mpv)
+       (delete "perl" "python-docutils")))
+    (propagated-inputs (package-inputs mpv))
+    (inputs '())
+    (synopsis "mpv media player client library")))
+
 (define-public smplayer
   (package
     (name "smplayer")
@@ -2524,7 +2540,7 @@ (define-public mpv-mpris
     (native-inputs
      (list pkg-config))
     (inputs
-     (list ffmpeg glib mpv))
+     (list ffmpeg glib libmpv))
     (home-page "https://github.com/hoyon/mpv-mpris")
     (synopsis "MPRIS plugin for mpv")
     (description "This package provides an @dfn{MPRIS} (Media Player Remote

base-commit: be1d05c10766a979dd0720b677889ed950d3b895
-- 
2.41.0





Acknowledgement sent to Hilton Chain <hako@HIDDEN>:
New bug report received and forwarded. Copy sent to lars@HIDDEN, marius@HIDDEN, me@HIDDEN, jgart@HIDDEN, guix-patches@HIDDEN. Full text available.
Report forwarded to lars@HIDDEN, marius@HIDDEN, me@HIDDEN, jgart@HIDDEN, guix-patches@HIDDEN:
bug#68250; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 20 Jan 2024 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.