GNU bug report logs - #68366
[PATCH 0/1] guix: cmake-build-system: Handle unknown systems.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68366 in the body.
You can then email your comments to 68366 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
To: guix-patches <at> gnu.org
Cc: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
Subject: [PATCH 0/1] guix: cmake-build-system: Handle unknown systems.
Date: Wed, 10 Jan 2024 12:39:21 +0100

Hello,

This patch series sets `-DCMAKE_SYSTEM_NAME=Generic' when the system
name is not known, else set it to Linux or Windows when applicable.

Causes a rebuild of all packages depending on CMAKE-BUILD-SYSTEM as a
result, but this is necessary to build packages for bare-metal
architectures, e.g. for `avr' or `or1k-elf'.

Cheers,

Jean-Pierre De Jesus DIAZ (1):
  guix: cmake-build-system: Handle unknown systems.

 guix/build/cmake-build-system.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)


base-commit: 537768018ee03a6a9a5562022a16b47ac287d131
-- 
2.41.0

Message #8 received at 68366 <at> debbugs.gnu.org (full text, mbox):

From: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
To: 68366 <at> debbugs.gnu.org
Cc: Jean-Pierre De Jesus DIAZ <me <at> jeandudey.tech>
Subject: [PATCH 1/1] guix: cmake-build-system: Handle unknown systems.
Date: Wed, 10 Jan 2024 12:40:28 +0100

From: Jean-Pierre De Jesus DIAZ <me <at> jeandudey.tech>

* guix/build/cmake-build-system.scm (configure): Use Generic as the
  system name if the system is unknown.

Change-Id: Ifd4a618ef67eb420b02d48f05291571aea44e46e
---
 guix/build/cmake-build-system.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/guix/build/cmake-build-system.scm b/guix/build/cmake-build-system.scm
index d1ff5071be..6790e1db2b 100644
--- a/guix/build/cmake-build-system.scm
+++ b/guix/build/cmake-build-system.scm
@@ -69,9 +69,12 @@ (define* (configure #:key outputs (configure-flags '()) (out-of-source? #t)
                                              target "-gcc")
                               (string-append "-DCMAKE_CXX_COMPILER="
                                              target "-g++")
-                              (if (string-contains target "mingw")
-                                  "-DCMAKE_SYSTEM_NAME=Windows"
-                                  "-DCMAKE_SYSTEM_NAME=Linux"))
+                              (cond ((string-contains target "mingw")
+                                     "-DCMAKE_SYSTEM_NAME=Windows")
+                                    ((string-contains target "linux")
+                                     "-DCMAKE_SYSTEM_NAME=Linux")
+                                    (else
+                                     "-DCMAKE_SYSTEM_NAME=Generic")))
                         '())
                   ,@configure-flags)))
       (format #t "running 'cmake' with arguments ~s~%" args)
-- 
2.41.0

Message #13 received at 68366-done <at> debbugs.gnu.org (full text, mbox):

From: Dariqq <dariqq <at> posteo.net>
To: 72697-done <at> debbugs.gnu.org, 68366-done <at> debbugs.gnu.org
Subject: Closing bugs
Date: Tue, 14 Jan 2025 20:07:43 +0000

Hello,

I sent https://issues.guix.gnu.org/72751 to move the cross compile logic 
out of the build side code, also adding GNU as a CMAKE_SYSTEM_NAME with 
a  fallback of Generic.

Because this no longer lives in build code it should now be easier to 
add a new SYSTEM_NAME without recompiling the cmake world.

This is now in master.
 ad672d80d7 * build-system: cmake: Rework cross compilation

So I am closing these.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.