GNU bug report logs - #68401
30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Emanuel Berg <incal@HIDDEN>; Keywords: patch; merged with #68395; dated Fri, 12 Jan 2024 10:44:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 68401 <at> debbugs.gnu.org:


Received: (at 68401) by debbugs.gnu.org; 19 Jan 2024 02:59:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 18 21:59:03 2024
Received: from localhost ([127.0.0.1]:57109 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rQf5x-0007uE-Md
	for submit <at> debbugs.gnu.org; Thu, 18 Jan 2024 21:59:03 -0500
Received: from mail-108-mta6.mxroute.com ([136.175.108.6]:37585)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jp@HIDDEN>) id 1rQf5u-0007u4-Vs
 for 68401 <at> debbugs.gnu.org; Thu, 18 Jan 2024 21:59:00 -0500
Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com)
 (Authenticated sender: mN4UYu2MZsgR)
 by mail-108-mta6.mxroute.com (ZoneMTA) with ESMTPSA id 18d1fa8394d0003727.002
 for <68401 <at> debbugs.gnu.org>
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
 Fri, 19 Jan 2024 02:58:54 +0000
X-Zone-Loop: d6346032d40c15b211a58f9163a046ff31e0400c1847
X-Originating-IP: [136.175.111.2]
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me
 ; s=x;
 h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:
 Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
 Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
 :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
 List-Post:List-Owner:List-Archive;
 bh=6YBlaKpmyE4W9/4HR/zZKgieeTWGag9tQWC47gWCeI8=; b=KuCO1594tefUkhfIzEnRF4xCAO
 kGqqCBZ3PV9io/OMjLvHoSVyD57J/AAmBiMXTvWbnlDlep81QHIJtOlv789Fw+P5cjqYFtDTLjOpb
 SsdSh5BLhFRLUhWkOBBYXVSLwcclWPN4Dq4YpxvmAf/4d2Wf9g7E6tjtHWOVHqU0v+SFxlBMSBtlF
 bOEAqkNhAXVJPkxNxgtP2VGc6syyDJF6OSJCEeIQApOmDA5d/xWAjGVIKUisRJKnWP3HudA/Y+f8M
 qCrZnh7OCx6lRe6gHeUb+fMn6NbRXHPPi+fMdzlvNkbYIbJBO5Wh7odXFGojtul1e49WypfaNZwZ3
 HLcBhgLw==;
From: "J.P." <jp@HIDDEN>
To: 68401 <at> debbugs.gnu.org
Subject: Re: bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG',
 `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt
In-Reply-To: <87wmseoskl.fsf@HIDDEN> (Emanuel Berg's message of "Sat,
 13 Jan 2024 03:50:02 +0100")
References: <87v87yvnly.fsf@HIDDEN> <834jfikb4d.fsf@HIDDEN>
 <87mstavias.fsf@HIDDEN> <87wmseoskl.fsf@HIDDEN>
Date: Thu, 18 Jan 2024 18:58:51 -0800
Message-ID: <87plxyowpg.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Authenticated-Id: masked@HIDDEN
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68401
Cc: Emanuel Berg <incal@HIDDEN>, emacs-erc@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain

Emanuel Berg <incal@HIDDEN> writes:

>> From fa8ae9dcc306d16cccdd6aa7c2bac242b90adbdb Mon Sep 17 00:00:00 2001
> From: Emanuel Berg <incal@HIDDEN>
> Date: Sat, 13 Jan 2024 03:40:05 +0100
> Subject: [PATCH] Functions for ERC.

Emacs doesn't seem to be very picky about a commit's subject line, but
I'd prefer those for ERC that aren't mechanical or administrative in
nature to be somewhat unique and distinguishable at a glance, such as

  Make erc-cmd-AMSG session-local, add /GMSG /AME /GME

> `erc-cmd-GMSG', `erc-cmd-GME' and `erc-cmd-AME' was added.
> `erc-cmd-AMSG' was changed so that it does what the docstring says.
> * lisp/erc/erc.el: functions were added/modified to/in this file.
>
> (bug#68401)

I believe the guidelines call for a commit body to be formatted as a
change log entry, for example:

  * lisp/erc/erc.el (erc-cmd-AMSG): Make good on behavior described in
  the doc string by limiting damage to the current connection.
  (erc-cmd-GMSG, erc-cmd-GME, erc-cmd-AME): New functions, all IRC
  "slash commands".  (Bug#68401)

> ---
>  lisp/erc/erc.el | 38 +++++++++++++++++++++++++++++++++-----
>  1 file changed, 33 insertions(+), 5 deletions(-)
>
> diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
> index 478683a77f5..aeb7722b563 100644
> --- a/lisp/erc/erc.el
> +++ b/lisp/erc/erc.el
> @@ -4016,16 +4016,44 @@ erc--split-string-shell-cmd
>  ;;                    Input commands handlers
>  ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
>  
> -(defun erc-cmd-AMSG (line)
> -  "Send LINE to all channels of the current server that you are on."
> -  (interactive "sSend to all channels you're on: ")
> +(defun erc-cmd-GMSG (line)
> +  "Send LINE to all channels on all networks you are on.
> +Interactively, prompt for the line of text to send."
> +  (interactive "sSend to all channels: ")

I question the wisdom of having new slash commands serve double duty as
interactive Emacs commands (at least those handling chat input). This
reservation has nothing to do with M-x erc-cmd-FOO <RET> being less
faithful (or whatever) to the traditional IRC experience than /FOO
<RET>. Rather, it stems from a need to prioritize consistent feedback
and promote maintainability by only having a single path for chat input
to reach the server (except under special circumstances).

Normally, when a user submits chat input at the prompt, ERC engages in a
series of validation checks before pushing a message out the door. These
steps are bypassed when someone invokes what's normally a slash command
via M-x. For example, if you /DISCONNECT and issue an /AMSG at the
prompt, you'll see "Process not running" in the echo area, and the input
will remain there for further editing, killing, etc. However, if you run
M-x erc-cmd-AMSG <RET>, the message will be inserted in all target
buffers, even though nothing is actually sent, which is misleading.
Obviously, we can't make `erc-cmd-AMSG' non-interactive because it's
been `commandp' forever. But new related commands don't have to follow
its (IMO flawed) example.

As far as counterarguments go, the only one that comes to mind for
making these `commandp' is that doing so also makes managing interactive
menus for modules like `bufbar', `nickbar', and `button' easier. For
example, at first glance, making `erc-cmd-KICK' interactive would appear
to streamline its inclusion in `erc-nick-popup-alist' and obviate the
need for an `erc-button-cmd-KICK'. However, if you look closely at this
arrangement, you'll see that even if `erc-cmd-KICK' were made a proper
Emacs command, a button-specific wrapper would still be necessary
because it makes special accommodations for the potential lack of a
channel context from which to draw membership rolls for completion. Such
a thing isn't necessary when issuing a /KICK <TAB> at the prompt because
the function `pcomplete/erc-mode/KICK' knows it's already running in a
channel.

>    (setq line (erc-trim-string line))

It might be nice to remove at most one space, for cases where a user
wants to send preformatted text. OTOH, normal /MSG doesn't do this, so
perhaps we shouldn't here either.

>    (erc-with-all-buffers-of-server nil
> -    (lambda ()
> -      (erc-channel-p (erc-default-target)))
> +    (lambda () (erc-channel-p (erc-default-target)))
> +    (erc-send-message line)))

Without first checking for connectivity, we run into another situation
in which messages may be inserted but not sent, similar to the bit about
commands being potentially "misleading," above. The most obvious way to
solve this is to check for "physical" connectivity with something like:

  (erc-with-all-buffers-of-server nil #'erc-server-process-alive
    (when (and erc--target (erc--current-buffer-joined-p))
      (erc-send-message line))))

Alternatively, you can check for "logical" connectivity, which is
probably more in keeping with traditional design principles:

  (erc-with-all-buffers-of-server nil nil
    (when (and erc-server-connected erc--target (erc--current-buffer-joined-p))
      (erc-send-message line))))

One minor downside of this second method is that IRC adjacent protocols
and aberrant proxy servers that happen to skip 376/422 and also provide
some (possibly &local) "control channel" won't be detected. (BTW, you
won't be needing the `erc--target' in either example if you rebase atop
the latest master.)

> +(put 'erc-cmd-GMSG 'do-not-parse-args t)
> +
> +(defun erc-cmd-AMSG (line)
> +  "Send LINE to all channels of the current network.
> +Interactively, prompt for the line of text to send."
> +  (interactive "sSend to all channels on this network: ")
> +  (setq line (erc-trim-string line))
> +  (erc-with-all-buffers-of-server erc-server-process
> +    (lambda () (erc-channel-p (erc-default-target)))

         ^ Indentation. This macro is declared "indent 2"

>      (erc-send-message line)))
>  (put 'erc-cmd-AMSG 'do-not-parse-args t)
>  
> +(defun erc-cmd-GME (line)
> +  "Send LINE as an action to all channels on all networks you are on.
> +Interactively, prompt for the line of text to send."
> +  (interactive "sSend action to all channels: ")

This command currently fails when invoked interactively. For example, if
I run M-x erc-cmd-GME <RET> hi <RET> from any ERC buffer belonging to a
connected session, nothing appears in the server logs or any ERC buffer.
This needs addressing if you're intent on keeping these interactive,
which I'm rather against for reasons previously noted.

> +  (erc-with-all-buffers-of-server nil
> +    (lambda () (erc-channel-p (erc-default-target)))
> +    (erc-cmd-ME line) ))

This currently suffers from the same problem as /GMSG regarding
disconnected buffers. However you address this, it's probably best to
use the same approach for fixing both functions.

> +(put 'erc-cmd-GME 'do-not-parse-args t)
> +
> +(defun erc-cmd-AME (line)
> +  "Send LINE as an action to all channels on the current network.
> +Interactively, prompt for the line of text to send."
> +  (interactive "sSend action to all channels on this network: ")

This command also appears do to nothing when invoked via M-x.

> +  (erc-with-all-buffers-of-server erc-server-process
> +    (lambda () (erc-channel-p (erc-default-target)))

         ^ Indentation again.

> +    (erc-cmd-ME line) ))
> +(put 'erc-cmd-AME 'do-not-parse-args t)
> +
>  (defun erc-cmd-SAY (line)
>    "Send LINE to the current query or channel as a message, not a command.
>  
> -- 
> 2.39.2

The attached patch is a unit test for all four commands. It doesn't
bother asserting M-x behavior (because see above). Please try to make it
pass without changing the test itself (unless there's a bug).

  $ git am /tmp/0002-5.x-Add...etc.patch

  $ make -C test lisp/erc/erc-scenarios-misc-commands.log \
    SELECTOR=erc-scenarios-misc-commands--AMSG-GMSG-AME-GME


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0002-5.x-Add-tests-for-ERC-slash-commands-AMSG-GMSG-etc.patch

From 0dfe03ad58e6d1edd47eace6faddeeb1733f6b37 Mon Sep 17 00:00:00 2001
From: "F. Jason Park" <jp@HIDDEN>
Date: Mon, 15 Jan 2024 22:40:44 -0800
Subject: [PATCH 2/2] [5.x] Add tests for ERC slash commands /AMSG, /GMSG, etc.

* test/lisp/erc/erc-scenarios-misc-commands.el
(erc-scenarios-misc-commands--AMSG-GMSG-AME-GME): New test.
* test/lisp/erc/resources/commands/amsg-barnet.eld: New file.
* test/lisp/erc/resources/commands/amsg-foonet.eld: New file.
(Bug#68401)
---
 test/lisp/erc/erc-scenarios-misc-commands.el  | 84 +++++++++++++++++++
 .../erc/resources/commands/amsg-barnet.eld    | 52 ++++++++++++
 .../erc/resources/commands/amsg-foonet.eld    | 52 ++++++++++++
 3 files changed, 188 insertions(+)
 create mode 100644 test/lisp/erc/resources/commands/amsg-barnet.eld
 create mode 100644 test/lisp/erc/resources/commands/amsg-foonet.eld

diff --git a/test/lisp/erc/erc-scenarios-misc-commands.el b/test/lisp/erc/erc-scenarios-misc-commands.el
index d6ed53b5358..c6bb610b9df 100644
--- a/test/lisp/erc/erc-scenarios-misc-commands.el
+++ b/test/lisp/erc/erc-scenarios-misc-commands.el
@@ -123,4 +123,88 @@ erc-scenarios-misc-commands--VHOST
         (should (string= (erc-server-user-host (erc-get-server-user "tester"))
                          "some.host.test.cc"))))))
 
+;; This tests four related slash commands, /AMSG, /GMSG, /AME, /GME,
+;; the latter three introduced by bug#68401.  It mainly asserts
+;; correct routing behavior, especially not sending or inserting
+;; messages in buffers belonging to disconnected sessions.  Left
+;; unaddressed are interactions with the `command-indicator' module
+;; (`erc-noncommands-list') and whatever future `echo-message'
+;; implementation manifests out of bug#49860.
+(ert-deftest erc-scenarios-misc-commands--AMSG-GMSG-AME-GME ()
+  (erc-scenarios-common-with-cleanup
+      ((erc-scenarios-common-dialog "commands")
+       (erc-server-flood-penalty 0.1)
+       (dumb-server-foonet (erc-d-run "localhost" t "srv-foonet" 'amsg-foonet))
+       (dumb-server-barnet (erc-d-run "localhost" t "srv-barnet" 'amsg-barnet))
+       (expect (erc-d-t-make-expecter)))
+
+    (ert-info ("Connect to foonet and join #foo")
+      (with-current-buffer
+          (erc :server "127.0.0.1"
+               :port (process-contact dumb-server-foonet :service)
+               :nick "tester")
+        (funcall expect 10 "debug mode")
+        (erc-cmd-JOIN "#foo")))
+
+    (ert-info ("Connect to barnet and join #bar")
+      (with-current-buffer
+          (erc :server "127.0.0.1"
+               :port (process-contact dumb-server-barnet :service)
+               :nick "tester")
+        (funcall expect 10 "debug mode")
+        (erc-cmd-JOIN "#bar")))
+
+    (with-current-buffer (erc-d-t-wait-for 10 (get-buffer "#foo"))
+      (funcall expect 10 "welcome"))
+    (with-current-buffer (erc-d-t-wait-for 10 (get-buffer "#bar"))
+      (funcall expect 10 "welcome"))
+
+    (ert-info ("/AMSG only sent to issuing context's server")
+      (with-current-buffer "foonet"
+        (erc-scenarios-common-say "/amsg 1 foonet only"))
+      (with-current-buffer "barnet"
+        (erc-scenarios-common-say "/amsg 2 barnet only"))
+      (with-current-buffer "#foo"
+        (funcall expect 10 "<tester> 1 foonet only")
+        (funcall expect 10 "<alice> bob: Our queen and all"))
+      (with-current-buffer "#bar"
+        (funcall expect 10 "<tester> 2 barnet only")
+        (funcall expect 10 "<joe> mike: And secretly to greet")))
+
+    (ert-info ("/AME only sent to issuing context's server")
+      (with-current-buffer "foonet"
+        (erc-scenarios-common-say "/ame 3 foonet only"))
+      (with-current-buffer "barnet"
+        (erc-scenarios-common-say "/ame 4 barnet only"))
+      (with-current-buffer "#foo"
+        (funcall expect 10 "* tester 3 foonet only")
+        (funcall expect 10 "<alice> bob: You have discharged this"))
+      (with-current-buffer "#bar"
+        (funcall expect 10 "* tester 4 barnet only")
+        (funcall expect 10 "<joe> mike: That same Berowne")))
+
+    (ert-info ("/GMSG sent to all servers")
+      (with-current-buffer "foonet"
+        (erc-scenarios-common-say "/gmsg 5 all nets"))
+      (with-current-buffer "#bar"
+        (funcall expect 10 "<tester> 5 all nets")
+        (funcall expect 10 "<joe> mike: Mehercle! if their sons")))
+
+    (ert-info ("/GMSG sent only to connected servers")
+      (with-current-buffer "barnet"
+        (erc-cmd-QUIT "")
+        (funcall expect 10 "ERC finished"))
+      (with-current-buffer "#foo"
+        (funcall expect 10 "<tester> 5 all nets")
+        (funcall expect 10 "<alice> bob: Stand you!"))
+      (with-current-buffer "foonet"
+        (erc-scenarios-common-say "/gmsg 6 all live nets"))
+      ;; Message *not* inserted in disconnected buffer.
+      (with-current-buffer "#bar"
+        (funcall expect -0.1 "<tester> 6 all live nets")))
+
+    (with-current-buffer "#foo"
+      (funcall expect 10 "<tester> 6 all live nets")
+      (funcall expect 10 "<bob> alice: Live, and be prosperous;"))))
+
 ;;; erc-scenarios-misc-commands.el ends here
diff --git a/test/lisp/erc/resources/commands/amsg-barnet.eld b/test/lisp/erc/resources/commands/amsg-barnet.eld
new file mode 100644
index 00000000000..a1d58b3d402
--- /dev/null
+++ b/test/lisp/erc/resources/commands/amsg-barnet.eld
@@ -0,0 +1,52 @@
+;; -*- mode: lisp-data; -*-
+((nick 10 "NICK tester"))
+((user 10 "USER user 0 * :unknown")
+ (0 ":irc.barnet.org 001 tester :Welcome to the barnet IRC Network tester")
+ (0 ":irc.barnet.org 002 tester :Your host is irc.barnet.org, running version oragono-2.6.0-7481bf0385b95b16")
+ (0 ":irc.barnet.org 003 tester :This server was created Tue, 04 May 2021 05:06:19 UTC")
+ (0 ":irc.barnet.org 004 tester irc.barnet.org oragono-2.6.0-7481bf0385b95b16 BERTZios CEIMRUabefhiklmnoqstuv Iabefhkloqv")
+ (0 ":irc.barnet.org 005 tester AWAYLEN=390 BOT=B CASEMAPPING=ascii CHANLIMIT=#:100 CHANMODES=Ibe,k,fl,CEMRUimnstu CHANNELLEN=64 CHANTYPES=# ELIST=U EXCEPTS EXTBAN=,m FORWARD=f INVEX KICKLEN=390 :are supported by this server")
+ (0 ":irc.barnet.org 005 tester MAXLIST=beI:60 MAXTARGETS=4 MODES MONITOR=100 NETWORK=barnet NICKLEN=32 PREFIX=(qaohv)~&@%+ STATUSMSG=~&@%+ TARGMAX=NAMES:1,LIST:1,KICK:1,WHOIS:1,USERHOST:10,PRIVMSG:4,TAGMSG:4,NOTICE:4,MONITOR:100 TOPICLEN=390 UTF8MAPPING=rfc8265 UTF8ONLY WHOX :are supported by this server")
+ (0 ":irc.barnet.org 005 tester draft/CHATHISTORY=100 :are supported by this server")
+ (0 ":irc.barnet.org 251 tester :There are 0 users and 3 invisible on 1 server(s)")
+ (0 ":irc.barnet.org 252 tester 0 :IRC Operators online")
+ (0 ":irc.barnet.org 253 tester 0 :unregistered connections")
+ (0 ":irc.barnet.org 254 tester 1 :channels formed")
+ (0 ":irc.barnet.org 255 tester :I have 3 clients and 0 servers")
+ (0 ":irc.barnet.org 265 tester 3 3 :Current local users 3, max 3")
+ (0 ":irc.barnet.org 266 tester 3 3 :Current global users 3, max 3")
+ (0 ":irc.barnet.org 422 tester :MOTD File is missing"))
+
+((mode-user 10 "MODE tester +i")
+ (0 ":irc.barnet.org 221 tester +i")
+ (0 ":irc.barnet.org NOTICE tester :This server is in debug mode and is logging all user I/O. If you do not wish for everything you send to be readable by the server owner(s), please disconnect."))
+
+((join 10 "JOIN #bar")
+ (0 ":tester!~u@HIDDEN JOIN #bar")
+ (0 ":irc.barnet.org 353 tester = #bar :@mike joe tester")
+ (0 ":irc.barnet.org 366 tester #bar :End of NAMES list"))
+
+((mode-bar 10 "MODE #bar")
+ (0 ":irc.barnet.org 324 tester #bar +nt")
+ (0 ":irc.barnet.org 329 tester #bar 1620104779")
+ (0.1 ":mike!~u@HIDDEN PRIVMSG #bar :tester, welcome!")
+ (0.1 ":joe!~u@HIDDEN PRIVMSG #bar :tester, welcome!")
+ (0.1 ":mike!~u@HIDDEN PRIVMSG #bar :joe: Whipp'd first, sir, and hang'd after.")
+ (0.1 ":joe!~u@HIDDEN PRIVMSG #bar :mike: We have yet many among us can gripe as hard as Cassibelan; I do not say I am one, but I have a hand. Why tribute ? why should we pay tribute ? If C sar can hide the sun from us with a blanket, or put the moon in his pocket, we will pay him tribute for light; else, sir, no more tribute, pray you now."))
+
+((privmsg-2 10 "PRIVMSG #bar :2 barnet only")
+ (0.1 ":mike!~u@HIDDEN PRIVMSG #bar :joe: Double and treble admonition, and still forfeit in the same kind ? This would make mercy swear, and play the tyrant.")
+ (0.1 ":joe!~u@HIDDEN PRIVMSG #bar :mike: And secretly to greet the empress' friends."))
+
+((privmsg-4 10 "PRIVMSG #bar :\1ACTION 4 barnet only\1")
+ (0.1 ":mike!~u@HIDDEN PRIVMSG #bar :joe: You have not been inquired after: I have sat here all day.")
+ (0.1 ":joe!~u@HIDDEN PRIVMSG #bar :mike: That same Berowne I'll torture ere I go."))
+
+((privmsg-5 10 "PRIVMSG #bar :5 all nets")
+ (0.1 ":mike!~u@HIDDEN PRIVMSG #bar :joe: For mine own part,no offence to the general, nor any man of quality,I hope to be saved.")
+ (0.1 ":joe!~u@HIDDEN PRIVMSG #bar :mike: Mehercle! if their sons be ingenuous, they shall want no instruction; if their daughters be capable, I will put it to them. But, vir sapit qui pauca loquitur. A soul feminine saluteth us."))
+
+((quit 5 "QUIT :\2ERC\2")
+ (0 ":tester!~u@HIDDEN QUIT :Quit"))
+
+((drop 0 DROP))
diff --git a/test/lisp/erc/resources/commands/amsg-foonet.eld b/test/lisp/erc/resources/commands/amsg-foonet.eld
new file mode 100644
index 00000000000..d5cf15ddf7c
--- /dev/null
+++ b/test/lisp/erc/resources/commands/amsg-foonet.eld
@@ -0,0 +1,52 @@
+;; -*- mode: lisp-data; -*-
+((nick 10 "NICK tester"))
+((user 10 "USER user 0 * :unknown")
+ (0 ":irc.foonet.org 001 tester :Welcome to the foonet IRC Network tester")
+ (0 ":irc.foonet.org 002 tester :Your host is irc.foonet.org, running version oragono-2.6.0-7481bf0385b95b16")
+ (0 ":irc.foonet.org 003 tester :This server was created Tue, 04 May 2021 05:06:18 UTC")
+ (0 ":irc.foonet.org 004 tester irc.foonet.org oragono-2.6.0-7481bf0385b95b16 BERTZios CEIMRUabefhiklmnoqstuv Iabefhkloqv")
+ (0 ":irc.foonet.org 005 tester AWAYLEN=390 BOT=B CASEMAPPING=ascii CHANLIMIT=#:100 CHANMODES=Ibe,k,fl,CEMRUimnstu CHANNELLEN=64 CHANTYPES=# ELIST=U EXCEPTS EXTBAN=,m FORWARD=f INVEX KICKLEN=390 :are supported by this server")
+ (0 ":irc.foonet.org 005 tester MAXLIST=beI:60 MAXTARGETS=4 MODES MONITOR=100 NETWORK=foonet NICKLEN=32 PREFIX=(qaohv)~&@%+ STATUSMSG=~&@%+ TARGMAX=NAMES:1,LIST:1,KICK:1,WHOIS:1,USERHOST:10,PRIVMSG:4,TAGMSG:4,NOTICE:4,MONITOR:100 TOPICLEN=390 UTF8MAPPING=rfc8265 UTF8ONLY WHOX :are supported by this server")
+ (0 ":irc.foonet.org 005 tester draft/CHATHISTORY=100 :are supported by this server")
+ (0 ":irc.foonet.org 251 tester :There are 0 users and 3 invisible on 1 server(s)")
+ (0 ":irc.foonet.org 252 tester 0 :IRC Operators online")
+ (0 ":irc.foonet.org 253 tester 0 :unregistered connections")
+ (0 ":irc.foonet.org 254 tester 1 :channels formed")
+ (0 ":irc.foonet.org 255 tester :I have 3 clients and 0 servers")
+ (0 ":irc.foonet.org 265 tester 3 3 :Current local users 3, max 3")
+ (0 ":irc.foonet.org 266 tester 3 3 :Current global users 3, max 3")
+ (0 ":irc.foonet.org 422 tester :MOTD File is missing"))
+
+((mode-user 10 "MODE tester +i")
+ (0 ":irc.foonet.org 221 tester +i")
+ (0 ":irc.foonet.org NOTICE tester :This server is in debug mode and is logging all user I/O. If you do not wish for everything you send to be readable by the server owner(s), please disconnect."))
+
+((join 10 "JOIN #foo")
+ (0 ":tester!~u@HIDDEN JOIN #foo")
+ (0 ":irc.foonet.org 353 tester = #foo :alice tester @bob")
+ (0 ":irc.foonet.org 366 tester #foo :End of NAMES list"))
+
+((mode-foo 10 "MODE #foo")
+ (0 ":irc.foonet.org 324 tester #foo +nt")
+ (0 ":irc.foonet.org 329 tester #foo 1620104779")
+ (0.1 ":bob!~u@HIDDEN PRIVMSG #foo :tester, welcome!")
+ (0.1 ":alice!~u@HIDDEN PRIVMSG #foo :tester, welcome!")
+ (0.1 ":bob!~u@HIDDEN PRIVMSG #foo :alice: But, as it seems, did violence on herself.")
+ (0.1 ":alice!~u@HIDDEN PRIVMSG #foo :bob: Well, this is the forest of Arden."))
+
+((privmsg-1 10 "PRIVMSG #foo :1 foonet only")
+ (0.1 ":bob!~u@HIDDEN PRIVMSG #foo :alice: Signior Iachimo will not from it. Pray, let us follow 'em.")
+ (0.1 ":alice!~u@HIDDEN PRIVMSG #foo :bob: Our queen and all her elves come here anon."))
+
+((privmsg-3 10 "PRIVMSG #foo :\1ACTION 3 foonet only\1")
+ (0.1 ":bob!~u@HIDDEN PRIVMSG #foo :alice: The ground is bloody; search about the churchyard.")
+ (0.1 ":alice!~u@HIDDEN PRIVMSG #foo :bob: You have discharged this honestly: keep it to yourself. Many likelihoods informed me of this before, which hung so tottering in the balance that I could neither believe nor misdoubt. Pray you, leave me: stall this in your bosom; and I thank you for your honest care. I will speak with you further anon."))
+
+((privmsg-5 10 "PRIVMSG #foo :5 all nets")
+ (0.1 ":bob!~u@HIDDEN PRIVMSG #foo :alice: Give me that mattock, and the wrenching iron.")
+ (0.1 ":alice!~u@HIDDEN PRIVMSG #foo :bob: Stand you! You have land enough of your own; but he added to your having, gave you some ground."))
+
+((privmsg-6 10 "PRIVMSG #foo :6 all live nets")
+ (0.1 ":bob!~u@HIDDEN PRIVMSG #foo :alice: Excellent workman! Thou canst not paint a man so bad as is thyself.")
+ (0.1 ":alice!~u@HIDDEN PRIVMSG #foo :bob: And will you, being a man of your breeding, be married under a bush, like a beggar ? Get you to church, and have a good priest that can tell you what marriage is: this fellow will but join you together as they join wainscot; then one of you will prove a shrunk panel, and like green timber, warp, warp.")
+ (0.1 ":bob!~u@HIDDEN PRIVMSG #foo :alice: Live, and be prosperous; and farewell, good fellow."))
-- 
2.42.0


--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#68401; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 14 Jan 2024 09:11:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 14 04:11:34 2024
Received: from localhost ([127.0.0.1]:41672 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOwWk-0004jY-D2
	for submit <at> debbugs.gnu.org; Sun, 14 Jan 2024 04:11:34 -0500
Received: from lists.gnu.org ([2001:470:142::17]:43024)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOwWi-0004jL-1K
 for submit <at> debbugs.gnu.org; Sun, 14 Jan 2024 04:11:32 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOwWd-0003EH-IU
 for bug-gnu-emacs@HIDDEN; Sun, 14 Jan 2024 04:11:27 -0500
Received: from ciao.gmane.io ([116.202.254.214])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOwWb-0001tJ-SE
 for bug-gnu-emacs@HIDDEN; Sun, 14 Jan 2024 04:11:27 -0500
Received: from list by ciao.gmane.io with local (Exim 4.92)
 (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOwWX-0001Pb-NE
 for bug-gnu-emacs@HIDDEN; Sun, 14 Jan 2024 10:11:21 +0100
X-Injected-Via-Gmane: http://gmane.org/
Mail-Followup-To: bug-gnu-emacs@HIDDEN
To: bug-gnu-emacs@HIDDEN
From: Emanuel Berg <incal@HIDDEN>
Subject: Re: bug#68401: 30.0.50;
 ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME',
 `erc-cmd-AME'. 2nd attempt
Followup-To: gmane.emacs.bugs,gmane.emacs.erc.general
Date: Sun, 14 Jan 2024 10:11:04 +0100
Message-ID: <87frz0p9ef.fsf@HIDDEN>
References: <87v87yvnly.fsf@HIDDEN>
 <834jfikb4d.fsf__6528.35318339697$1705061373$gmane$org@HIDDEN>
 <87edemvdw6.fsf@HIDDEN> <83mstaipk7.fsf@HIDDEN>
 <8734v2ugqm.fsf@HIDDEN> <87zfxat14v.fsf@HIDDEN>
 <83o7dphf3e.fsf@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain
User-Agent: Gnus/5.13 (Gnus v5.13)
Cancel-Lock: sha1:hBqdaVXIb5YUxdyZgEUwNmJMNac=
Mail-Copies-To: never
Received-SPF: pass client-ip=116.202.254.214;
 envelope-from=geb-bug-gnu-emacs@HIDDEN; helo=ciao.gmane.io
X-Spam_score_int: -16
X-Spam_score: -1.7
X-Spam_bar: -
X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9,
 HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: submit
Cc: emacs-erc@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

Eli Zaretskii wrote:

>> I didn't find a command to change the commit message of the
>> patch
>
> The command you are looking for is
>
>   git commit --amend

Thank you and JP for the help with git commands, here are the
commands I accumulated only working on this small patch.

But I think it doesn't take that long to become fluent with
the git basics, after that overhead efforts are
less frustrating.

If one wants to `untabify' files on `save-buffer', but not in
cases like this, this is more tricky but as a poor man's
solution one can add exceptions to the function that does it,
like this

(defun untab-all ()
  (unless (member major-mode '(emacs-lisp-mode
                               makefile-gmake-mode
                               makefile-mode) ) ; exceptions
    (untabify (point-min) (point-max)))
  nil)

That last `nil' indicates it did not write the buffer to the
disk, used by `before-save-hook' - so it is useful, even tho
it looks funky in a defun.

$ git checkout -b ib master
...
$ git commit -a

$ git format-patch master -M -o .ib
M-x erc-bug RET
Tags: patch
C-c C-a (`mml-attach-file')
C-c C-c (`message-send-and-exit')

$ git log
$ git format-patch -2 HEAD --stdout > last-two.patch

$ git commit --amend

$ git branch
$ git branch -D ib

-- 
underground experts united
https://dataswamp.org/~incal





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#68401; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 13 Jan 2024 07:23:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 13 02:23:35 2024
Received: from localhost ([127.0.0.1]:38269 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOYMc-0005lW-KK
	for submit <at> debbugs.gnu.org; Sat, 13 Jan 2024 02:23:35 -0500
Received: from lists.gnu.org ([2001:470:142::17]:60542)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rOYMa-0005lI-KK
 for submit <at> debbugs.gnu.org; Sat, 13 Jan 2024 02:23:29 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rOYMW-000102-9a
 for bug-gnu-emacs@HIDDEN; Sat, 13 Jan 2024 02:23:24 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rOYMV-0006Bw-11; Sat, 13 Jan 2024 02:23:23 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=GQbPX2pqk9Ez+18miIZbRRBaDdeudl+gUl6MYbgxZ38=; b=pN3eRUUUwCe+
 qULQcUIasskA8IvZH63VE8xNkSG4prjwYeUz/8yBdN8iqTmSM+2U4UTdaQKJN/kHHSYk2AjBcbAE7
 tZDLYIsnzO6XhJlLg1wUvMjH2kNGOXqpVraKK0w5zrC7+GFCKS24kjke5m9n2914vxPDmyuMECnmo
 pkdLeQiY+x4Rp9TdvBUGmylX60H9cn5D6G6rENSjDd3zvS9WcEw3SX1rKqx0Us+TcwbEvjeuogPA8
 YtBKgcYp8Xf01jFJMmaJYfPF7R+HZn+r1PHBq3lO7cCES5X19293qSWXgbI/nR0lohsGISm0N/n84
 uHFywbyqoeNImvTNWmFbDA==;
Date: Sat, 13 Jan 2024 09:23:01 +0200
Message-Id: <83o7dphf3e.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Emanuel Berg <incal@HIDDEN>
In-Reply-To: <87zfxat14v.fsf@HIDDEN> (message from Emanuel Berg on Sat, 
 13 Jan 2024 03:31:28 +0100)
Subject: Re: bug#68401: 30.0.50;
 ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME',
 `erc-cmd-AME'. 2nd attempt
References: <87v87yvnly.fsf@HIDDEN>
 <834jfikb4d.fsf__6528.35318339697$1705061373$gmane$org@HIDDEN>
 <87edemvdw6.fsf@HIDDEN> <83mstaipk7.fsf@HIDDEN>
 <8734v2ugqm.fsf@HIDDEN> <87zfxat14v.fsf@HIDDEN>
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: submit
Cc: bug-gnu-emacs@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

> From: Emanuel Berg <incal@HIDDEN>
> Date: Sat, 13 Jan 2024 03:31:28 +0100
> 
> I didn't find a command to change the commit message of the
> patch

The command you are looking for is

  git commit --amend




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#68401; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 13 Jan 2024 02:46:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 12 21:46:03 2024
Received: from localhost ([127.0.0.1]:38063 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOU26-0000K9-W9
	for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 21:46:03 -0500
Received: from lists.gnu.org ([2001:470:142::17]:35162)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOU23-00007n-T4
 for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 21:46:01 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOU1z-0008C2-2j
 for bug-gnu-emacs@HIDDEN; Fri, 12 Jan 2024 21:45:55 -0500
Received: from ciao.gmane.io ([116.202.254.214])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOU1x-0001OC-9s
 for bug-gnu-emacs@HIDDEN; Fri, 12 Jan 2024 21:45:54 -0500
Received: from list by ciao.gmane.io with local (Exim 4.92)
 (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOU1u-0006QG-WD
 for bug-gnu-emacs@HIDDEN; Sat, 13 Jan 2024 03:45:51 +0100
X-Injected-Via-Gmane: http://gmane.org/
Mail-Followup-To: bug-gnu-emacs@HIDDEN
To: bug-gnu-emacs@HIDDEN
From: Emanuel Berg <incal@HIDDEN>
Subject: Re: bug#68401: 30.0.50;
 ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME',
 `erc-cmd-AME'. 2nd attempt
Date: Sat, 13 Jan 2024 03:45:43 +0100
Message-ID: <874jfiq7c8.fsf@HIDDEN>
References: <87v87yvnly.fsf@HIDDEN>
 <834jfikb4d.fsf__6528.35318339697$1705061373$gmane$org@HIDDEN>
 <87edemvdw6.fsf@HIDDEN> <83mstaipk7.fsf@HIDDEN>
 <8734v2ugqm.fsf@HIDDEN> <87zfxat14v.fsf@HIDDEN>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
User-Agent: Gnus/5.13 (Gnus v5.13)
Cancel-Lock: sha1:Zsos+piUzgA+0QsLqZDWe/pd6PI=
Mail-Copies-To: never
Received-SPF: pass client-ip=116.202.254.214;
 envelope-from=geb-bug-gnu-emacs@HIDDEN; helo=ciao.gmane.io
X-Spam_score_int: -16
X-Spam_score: -1.7
X-Spam_bar: -
X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9,
 HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

--=-=-=
Content-Type: text/plain

>>>> To create one patch out of all the commits?
>>>
>>> Yes, please.
>>
>> Maybe it can be done like this. 
>>
>> $ git format-patch -2 HEAD --stdout > 0001-all.patch
>
> I didn't find a command to change the commit message of the
> patch but I think one can just as well do that manually by
> editing the patch like any other file.
>
> Here is the modified version with everything, I think.

Re-did everything since that patch still consists of
two patches. Now everything should be in one piece, in one
patch.


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment; filename=0001-Functions-for-ERC.patch

From fa8ae9dcc306d16cccdd6aa7c2bac242b90adbdb Mon Sep 17 00:00:00 2001
From: Emanuel Berg <incal@HIDDEN>
Date: Sat, 13 Jan 2024 03:40:05 +0100
Subject: [PATCH] Functions for ERC.

`erc-cmd-GMSG', `erc-cmd-GME' and `erc-cmd-AME' was added.
`erc-cmd-AMSG' was changed so that it does what the docstring says.
* lisp/erc/erc.el: functions were added/modified to/in this file.

(bug#68401)
---
 lisp/erc/erc.el | 38 +++++++++++++++++++++++++++++++++-----
 1 file changed, 33 insertions(+), 5 deletions(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index 478683a77f5..aeb7722b563 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -4016,16 +4016,44 @@ erc--split-string-shell-cmd
 ;;                    Input commands handlers
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 
-(defun erc-cmd-AMSG (line)
-  "Send LINE to all channels of the current server that you are on."
-  (interactive "sSend to all channels you're on: ")
+(defun erc-cmd-GMSG (line)
+  "Send LINE to all channels on all networks you are on.
+Interactively, prompt for the line of text to send."
+  (interactive "sSend to all channels: ")
   (setq line (erc-trim-string line))
   (erc-with-all-buffers-of-server nil
-    (lambda ()
-      (erc-channel-p (erc-default-target)))
+    (lambda () (erc-channel-p (erc-default-target)))
+    (erc-send-message line)))
+(put 'erc-cmd-GMSG 'do-not-parse-args t)
+
+(defun erc-cmd-AMSG (line)
+  "Send LINE to all channels of the current network.
+Interactively, prompt for the line of text to send."
+  (interactive "sSend to all channels on this network: ")
+  (setq line (erc-trim-string line))
+  (erc-with-all-buffers-of-server erc-server-process
+    (lambda () (erc-channel-p (erc-default-target)))
     (erc-send-message line)))
 (put 'erc-cmd-AMSG 'do-not-parse-args t)
 
+(defun erc-cmd-GME (line)
+  "Send LINE as an action to all channels on all networks you are on.
+Interactively, prompt for the line of text to send."
+  (interactive "sSend action to all channels: ")
+  (erc-with-all-buffers-of-server nil
+    (lambda () (erc-channel-p (erc-default-target)))
+    (erc-cmd-ME line) ))
+(put 'erc-cmd-GME 'do-not-parse-args t)
+
+(defun erc-cmd-AME (line)
+  "Send LINE as an action to all channels on the current network.
+Interactively, prompt for the line of text to send."
+  (interactive "sSend action to all channels on this network: ")
+  (erc-with-all-buffers-of-server erc-server-process
+    (lambda () (erc-channel-p (erc-default-target)))
+    (erc-cmd-ME line) ))
+(put 'erc-cmd-AME 'do-not-parse-args t)
+
 (defun erc-cmd-SAY (line)
   "Send LINE to the current query or channel as a message, not a command.
 
-- 
2.39.2


--=-=-=
Content-Type: text/plain


-- 
underground experts united
https://dataswamp.org/~incal

--=-=-=--





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#68401; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 13 Jan 2024 02:31:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 12 21:31:47 2024
Received: from localhost ([127.0.0.1]:38059 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOToJ-0006T6-48
	for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 21:31:47 -0500
Received: from lists.gnu.org ([2001:470:142::17]:41444)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOToH-0006OO-DN
 for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 21:31:46 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOToD-0004UU-A9
 for bug-gnu-emacs@HIDDEN; Fri, 12 Jan 2024 21:31:41 -0500
Received: from ciao.gmane.io ([116.202.254.214])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOToB-0001kl-8g
 for bug-gnu-emacs@HIDDEN; Fri, 12 Jan 2024 21:31:41 -0500
Received: from list by ciao.gmane.io with local (Exim 4.92)
 (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOTo8-000AA3-87
 for bug-gnu-emacs@HIDDEN; Sat, 13 Jan 2024 03:31:36 +0100
X-Injected-Via-Gmane: http://gmane.org/
Mail-Followup-To: bug-gnu-emacs@HIDDEN
To: bug-gnu-emacs@HIDDEN
From: Emanuel Berg <incal@HIDDEN>
Subject: Re: bug#68401: 30.0.50;
 ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME',
 `erc-cmd-AME'. 2nd attempt
Date: Sat, 13 Jan 2024 03:31:28 +0100
Message-ID: <87zfxat14v.fsf@HIDDEN>
References: <87v87yvnly.fsf@HIDDEN>
 <834jfikb4d.fsf__6528.35318339697$1705061373$gmane$org@HIDDEN>
 <87edemvdw6.fsf@HIDDEN> <83mstaipk7.fsf@HIDDEN>
 <8734v2ugqm.fsf@HIDDEN>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
User-Agent: Gnus/5.13 (Gnus v5.13)
Cancel-Lock: sha1:dpAUVrg/sbxceW0GDhma72L4v9o=
Mail-Copies-To: never
Received-SPF: pass client-ip=116.202.254.214;
 envelope-from=geb-bug-gnu-emacs@HIDDEN; helo=ciao.gmane.io
X-Spam_score_int: -16
X-Spam_score: -1.7
X-Spam_bar: -
X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9,
 HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

--=-=-=
Content-Type: text/plain

>>> To create one patch out of all the commits?
>>
>> Yes, please.
>
> Maybe it can be done like this. 
>
> $ git format-patch -2 HEAD --stdout > 0001-all.patch

I didn't find a command to change the commit message of the
patch but I think one can just as well do that manually by
editing the patch like any other file.

Here is the modified version with everything, I think.


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment; filename=0001-all.patch

From a2345b8eb22af2d5a052c1e22a19aeffc48544b2 Mon Sep 17 00:00:00 2001
From: Emanuel Berg <incal@HIDDEN>
Date: Fri, 12 Jan 2024 11:37:28 +0100
Subject: [PATCH 1/2] Functions for ERC.

`erc-cmd-GMSG', `erc-cmd-GME' and `erc-cmd-AME' was added.
`erc-cmd-AMSG' was changed so that it does what the docstring says.
* lisp/erc/erc.el: functions were added/modified to/in this file.

bug#68401
---
 lisp/erc/erc.el | 34 +++++++++++++++++++++++++++++-----
 1 file changed, 29 insertions(+), 5 deletions(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index 478683a77f5..06791bce520 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -4016,16 +4016,40 @@ erc--split-string-shell-cmd
 ;;                    Input commands handlers
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

-(defun erc-cmd-AMSG (line)
-  "Send LINE to all channels of the current server that you are on."
-  (interactive "sSend to all channels you're on: ")
+(defun erc-cmd-GMSG (line)
+  "Send LINE to all channels on all networks you are on."
+  (interactive "sSend to all channels: ")
   (setq line (erc-trim-string line))
   (erc-with-all-buffers-of-server nil
-    (lambda ()
-      (erc-channel-p (erc-default-target)))
+    (lambda () (erc-channel-p (erc-default-target)))
+    (erc-send-message line)))
+(put 'erc-cmd-GMSG 'do-not-parse-args t)
+
+(defun erc-cmd-AMSG (line)
+  "Send LINE to all channels of the current network."
+  (interactive "sSend to all channels on this network: ")
+  (setq line (erc-trim-string line))
+  (erc-with-all-buffers-of-server erc-server-process
+    (lambda () (erc-channel-p (erc-default-target)))
     (erc-send-message line)))
 (put 'erc-cmd-AMSG 'do-not-parse-args t)

+(defun erc-cmd-GME (line)
+  "Send LINE as an action to all channels on all networks you are on."
+  (interactive "sSend action to all channels: ")
+  (erc-with-all-buffers-of-server nil
+    (lambda () (erc-channel-p (erc-default-target)))
+    (erc-cmd-ME line) ))
+(put 'erc-cmd-GME 'do-not-parse-args t)
+
+(defun erc-cmd-AME (line)
+  "Send LINE as an action to all channels on the current network."
+  (interactive "sSend action to all channels on this network: ")
+  (erc-with-all-buffers-of-server erc-server-process
+    (lambda () (erc-channel-p (erc-default-target)))
+    (erc-cmd-ME line) ))
+(put 'erc-cmd-AME 'do-not-parse-args t)
+
 (defun erc-cmd-SAY (line)
   "Send LINE to the current query or channel as a message, not a command.

--
2.39.2


From 73f3cc5072bb8cc95ce5367cb8aef74e5b047f0d Mon Sep 17 00:00:00 2001
From: Emanuel Berg <incal@HIDDEN>
Date: Fri, 12 Jan 2024 15:03:10 +0100
Subject: [PATCH 2/2] Docstrings for interactive use added.

* lisp/erc/erc.el: docstrings added here

bug#68401

---
 lisp/erc/erc.el | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index 06791bce520..aeb7722b563 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -4017,7 +4017,8 @@ erc--split-string-shell-cmd
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

 (defun erc-cmd-GMSG (line)
-  "Send LINE to all channels on all networks you are on."
+  "Send LINE to all channels on all networks you are on.
+Interactively, prompt for the line of text to send."
   (interactive "sSend to all channels: ")
   (setq line (erc-trim-string line))
   (erc-with-all-buffers-of-server nil
@@ -4026,7 +4027,8 @@ erc-cmd-GMSG
 (put 'erc-cmd-GMSG 'do-not-parse-args t)

 (defun erc-cmd-AMSG (line)
-  "Send LINE to all channels of the current network."
+  "Send LINE to all channels of the current network.
+Interactively, prompt for the line of text to send."
   (interactive "sSend to all channels on this network: ")
   (setq line (erc-trim-string line))
   (erc-with-all-buffers-of-server erc-server-process
@@ -4035,7 +4037,8 @@ erc-cmd-AMSG
 (put 'erc-cmd-AMSG 'do-not-parse-args t)

 (defun erc-cmd-GME (line)
-  "Send LINE as an action to all channels on all networks you are on."
+  "Send LINE as an action to all channels on all networks you are on.
+Interactively, prompt for the line of text to send."
   (interactive "sSend action to all channels: ")
   (erc-with-all-buffers-of-server nil
     (lambda () (erc-channel-p (erc-default-target)))
@@ -4043,7 +4046,8 @@ erc-cmd-GME
 (put 'erc-cmd-GME 'do-not-parse-args t)

 (defun erc-cmd-AME (line)
-  "Send LINE as an action to all channels on the current network."
+  "Send LINE as an action to all channels on the current network.
+Interactively, prompt for the line of text to send."
   (interactive "sSend action to all channels on this network: ")
   (erc-with-all-buffers-of-server erc-server-process
     (lambda () (erc-channel-p (erc-default-target)))
--
2.39.2

--=-=-=
Content-Type: text/plain


-- 
underground experts united
https://dataswamp.org/~incal

--=-=-=--





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#68401; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 13 Jan 2024 02:09:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 12 21:09:38 2024
Received: from localhost ([127.0.0.1]:38045 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOTSr-0000dH-MF
	for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 21:09:38 -0500
Received: from lists.gnu.org ([2001:470:142::17]:37116)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOTSp-0000d3-9B
 for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 21:09:36 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOTSZ-0000kL-Rt
 for bug-gnu-emacs@HIDDEN; Fri, 12 Jan 2024 21:09:20 -0500
Received: from ciao.gmane.io ([116.202.254.214])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOTSW-0005wb-1m
 for bug-gnu-emacs@HIDDEN; Fri, 12 Jan 2024 21:09:19 -0500
Received: from list by ciao.gmane.io with local (Exim 4.92)
 (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOTST-0004S9-67
 for bug-gnu-emacs@HIDDEN; Sat, 13 Jan 2024 03:09:13 +0100
X-Injected-Via-Gmane: http://gmane.org/
Mail-Followup-To: bug-gnu-emacs@HIDDEN
To: bug-gnu-emacs@HIDDEN
From: Emanuel Berg <incal@HIDDEN>
Subject: Re: bug#68401: 30.0.50;
 ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME',
 `erc-cmd-AME'. 2nd attempt
Date: Sat, 13 Jan 2024 03:09:05 +0100
Message-ID: <8734v2ugqm.fsf@HIDDEN>
References: <87v87yvnly.fsf@HIDDEN>
 <834jfikb4d.fsf__6528.35318339697$1705061373$gmane$org@HIDDEN>
 <87edemvdw6.fsf@HIDDEN> <83mstaipk7.fsf@HIDDEN>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
User-Agent: Gnus/5.13 (Gnus v5.13)
Cancel-Lock: sha1:xj51JyjyrrwWgn4Fe3TiocNnAvk=
Mail-Copies-To: never
Received-SPF: pass client-ip=116.202.254.214;
 envelope-from=geb-bug-gnu-emacs@HIDDEN; helo=ciao.gmane.io
X-Spam_score_int: -16
X-Spam_score: -1.7
X-Spam_bar: -
X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9,
 HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

--=-=-=
Content-Type: text/plain

Eli Zaretskii wrote:

>> To create one patch out of all the commits?
>
> Yes, please.

Maybe it can be done like this. 

$ git format-patch -2 HEAD --stdout > 0001-all.patch


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment; filename=0001-all.patch

From a2345b8eb22af2d5a052c1e22a19aeffc48544b2 Mon Sep 17 00:00:00 2001
From: Emanuel Berg <incal@HIDDEN>
Date: Fri, 12 Jan 2024 11:37:28 +0100
Subject: [PATCH 1/2] `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME',
 `erc-cmd-AME'.

---
 lisp/erc/erc.el | 34 +++++++++++++++++++++++++++++-----
 1 file changed, 29 insertions(+), 5 deletions(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index 478683a77f5..06791bce520 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -4016,16 +4016,40 @@ erc--split-string-shell-cmd
 ;;                    Input commands handlers
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 
-(defun erc-cmd-AMSG (line)
-  "Send LINE to all channels of the current server that you are on."
-  (interactive "sSend to all channels you're on: ")
+(defun erc-cmd-GMSG (line)
+  "Send LINE to all channels on all networks you are on."
+  (interactive "sSend to all channels: ")
   (setq line (erc-trim-string line))
   (erc-with-all-buffers-of-server nil
-    (lambda ()
-      (erc-channel-p (erc-default-target)))
+    (lambda () (erc-channel-p (erc-default-target)))
+    (erc-send-message line)))
+(put 'erc-cmd-GMSG 'do-not-parse-args t)
+
+(defun erc-cmd-AMSG (line)
+  "Send LINE to all channels of the current network."
+  (interactive "sSend to all channels on this network: ")
+  (setq line (erc-trim-string line))
+  (erc-with-all-buffers-of-server erc-server-process
+    (lambda () (erc-channel-p (erc-default-target)))
     (erc-send-message line)))
 (put 'erc-cmd-AMSG 'do-not-parse-args t)
 
+(defun erc-cmd-GME (line)
+  "Send LINE as an action to all channels on all networks you are on."
+  (interactive "sSend action to all channels: ")
+  (erc-with-all-buffers-of-server nil
+    (lambda () (erc-channel-p (erc-default-target)))
+    (erc-cmd-ME line) ))
+(put 'erc-cmd-GME 'do-not-parse-args t)
+
+(defun erc-cmd-AME (line)
+  "Send LINE as an action to all channels on the current network."
+  (interactive "sSend action to all channels on this network: ")
+  (erc-with-all-buffers-of-server erc-server-process
+    (lambda () (erc-channel-p (erc-default-target)))
+    (erc-cmd-ME line) ))
+(put 'erc-cmd-AME 'do-not-parse-args t)
+
 (defun erc-cmd-SAY (line)
   "Send LINE to the current query or channel as a message, not a command.
 
-- 
2.39.2


From 73f3cc5072bb8cc95ce5367cb8aef74e5b047f0d Mon Sep 17 00:00:00 2001
From: Emanuel Berg <incal@HIDDEN>
Date: Fri, 12 Jan 2024 15:03:10 +0100
Subject: [PATCH 2/2] Docstrings for interactive use.

---
 lisp/erc/erc.el | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index 06791bce520..aeb7722b563 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -4017,7 +4017,8 @@ erc--split-string-shell-cmd
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 
 (defun erc-cmd-GMSG (line)
-  "Send LINE to all channels on all networks you are on."
+  "Send LINE to all channels on all networks you are on.
+Interactively, prompt for the line of text to send."
   (interactive "sSend to all channels: ")
   (setq line (erc-trim-string line))
   (erc-with-all-buffers-of-server nil
@@ -4026,7 +4027,8 @@ erc-cmd-GMSG
 (put 'erc-cmd-GMSG 'do-not-parse-args t)
 
 (defun erc-cmd-AMSG (line)
-  "Send LINE to all channels of the current network."
+  "Send LINE to all channels of the current network.
+Interactively, prompt for the line of text to send."
   (interactive "sSend to all channels on this network: ")
   (setq line (erc-trim-string line))
   (erc-with-all-buffers-of-server erc-server-process
@@ -4035,7 +4037,8 @@ erc-cmd-AMSG
 (put 'erc-cmd-AMSG 'do-not-parse-args t)
 
 (defun erc-cmd-GME (line)
-  "Send LINE as an action to all channels on all networks you are on."
+  "Send LINE as an action to all channels on all networks you are on.
+Interactively, prompt for the line of text to send."
   (interactive "sSend action to all channels: ")
   (erc-with-all-buffers-of-server nil
     (lambda () (erc-channel-p (erc-default-target)))
@@ -4043,7 +4046,8 @@ erc-cmd-GME
 (put 'erc-cmd-GME 'do-not-parse-args t)
 
 (defun erc-cmd-AME (line)
-  "Send LINE as an action to all channels on the current network."
+  "Send LINE as an action to all channels on the current network.
+Interactively, prompt for the line of text to send."
   (interactive "sSend action to all channels on this network: ")
   (erc-with-all-buffers-of-server erc-server-process
     (lambda () (erc-channel-p (erc-default-target)))
-- 
2.39.2


--=-=-=
Content-Type: text/plain


-- 
underground experts united
https://dataswamp.org/~incal

--=-=-=--





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#68401; Package emacs. Full text available.
Merged 68395 68401. Request was from "J.P." <jp@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 68401 <at> debbugs.gnu.org:


Received: (at 68401) by debbugs.gnu.org; 12 Jan 2024 14:39:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 12 09:39:40 2024
Received: from localhost ([127.0.0.1]:35301 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOIh9-0000cZ-QK
	for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 09:39:40 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:41458)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rOIh6-0000cL-QS
 for 68401 <at> debbugs.gnu.org; Fri, 12 Jan 2024 09:39:38 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rOIh2-0007Up-If; Fri, 12 Jan 2024 09:39:32 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=P3uVEflA9hiospbLmtn7smh5cC5JRePC9GCFlLJotF8=; b=sBLdXOMaGc0u
 R2esfs2leoE36sEOp5fBW5nWhzlLepF8FomDybKBND8GRoI/owo4wax1hNKtWTaRyX8Zx3diTh6Jw
 V6OXrQBHi7X287gIlYXztPLLv7RPvy+KrZMtGbNbPTEdkWFmsci9tYAm0nsE6/p9UwUWw/IjEeczJ
 55+uLZSukR5nYW0FFoeOP61TRBrTnMy99p3LSCi9FEwquVQsB2Shxp9O12NG0aR+oDYbAUBQEHRdZ
 ox1lc12/v/bTFuMQiV3V8ZRTGoO9SoDnXEdquP0cyLvHWEONUJBhZLwlis/2CWq3nP0LFQmyeho07
 42o6niER2k7ZVJB0hPAHHw==;
Date: Fri, 12 Jan 2024 16:39:20 +0200
Message-Id: <83mstaipk7.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Emanuel Berg <incal@HIDDEN>
In-Reply-To: <87edemvdw6.fsf@HIDDEN> (message from Emanuel Berg on Fri, 
 12 Jan 2024 15:12:57 +0100)
Subject: Re: bug#68401: 30.0.50;
 ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME',
 `erc-cmd-AME'. 2nd attempt
References: <87v87yvnly.fsf@HIDDEN>
 <834jfikb4d.fsf__6528.35318339697$1705061373$gmane$org@HIDDEN>
 <87edemvdw6.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68401
Cc: 68401 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Emanuel Berg <incal@HIDDEN>
> Date: Fri, 12 Jan 2024 15:12:57 +0100
> 
> Eli Zaretskii wrote:
> 
> > Our style is also to mention the interactive prompts in the
> > doc string:
> >
> >     "Send LINE to all channels on all networks you are on.
> >   Interactively, prompt for the line of text to send."
> 
> Here is a patch adding that, maybe if you apply it
> sequentially after the first it will work?

It will, but it would be more convenient to have a single patch.

> To create one patch out of all the commits?

Yes, please.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#68401; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 12 Jan 2024 14:30:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 12 09:30:58 2024
Received: from localhost ([127.0.0.1]:35280 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOIYk-0007qG-1t
	for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 09:30:58 -0500
Received: from lists.gnu.org ([2001:470:142::17]:38612)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOIYi-0007gI-5N
 for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 09:30:57 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOIYc-0006DI-VQ
 for bug-gnu-emacs@HIDDEN; Fri, 12 Jan 2024 09:30:50 -0500
Received: from ciao.gmane.io ([116.202.254.214])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOIYb-0003OS-7S
 for bug-gnu-emacs@HIDDEN; Fri, 12 Jan 2024 09:30:50 -0500
Received: from list by ciao.gmane.io with local (Exim 4.92)
 (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOIYX-0001cd-V0
 for bug-gnu-emacs@HIDDEN; Fri, 12 Jan 2024 15:30:45 +0100
X-Injected-Via-Gmane: http://gmane.org/
Mail-Followup-To: bug-gnu-emacs@HIDDEN
To: bug-gnu-emacs@HIDDEN
From: Emanuel Berg <incal@HIDDEN>
Subject: Re: bug#68401: 30.0.50;
 ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME',
 `erc-cmd-AME'. 2nd attempt
Followup-To: gmane.emacs.bugs,gmane.emacs.erc.general
Date: Fri, 12 Jan 2024 15:30:30 +0100
Message-ID: <87bk9qvd2x.fsf@HIDDEN>
References: <87v87yvnly.fsf@HIDDEN> <834jfikb4d.fsf@HIDDEN>
 <87ply6vidl.fsf@HIDDEN> <83wmseir8i.fsf@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain
User-Agent: Gnus/5.13 (Gnus v5.13)
Cancel-Lock: sha1:1fBOHDzsibO9wF+VVRlA3LCk/iM=
Mail-Copies-To: never
Received-SPF: pass client-ip=116.202.254.214;
 envelope-from=geb-bug-gnu-emacs@HIDDEN; helo=ciao.gmane.io
X-Spam_score_int: -16
X-Spam_score: -1.7
X-Spam_bar: -
X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9,
 HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: submit
Cc: emacs-erc@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

Eli Zaretskii wrote:

> The other aspects are also required, and that's why they are
> described in CONTRIBUTE. We expect the contributors to
> follow those conventions, and we point out any deviations
> from them as part of the patch review process.

Yeah, if this is how you choose to spend your time being
active with Emacs, count me out. This kind of inefficiency is
alien to modern society.

Maybe someone is writing an interactive tool to produce
correct commit messages, if so I'll wait for that.

-- 
underground experts united
https://dataswamp.org/~incal





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#68401; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 12 Jan 2024 14:13:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 12 09:13:18 2024
Received: from localhost ([127.0.0.1]:35242 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOIHe-00030Q-0G
	for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 09:13:18 -0500
Received: from lists.gnu.org ([2001:470:142::17]:34852)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOIHa-000307-PD
 for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 09:13:16 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOIHW-0005d5-MU
 for bug-gnu-emacs@HIDDEN; Fri, 12 Jan 2024 09:13:10 -0500
Received: from ciao.gmane.io ([116.202.254.214])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOIHU-0002zY-Gy
 for bug-gnu-emacs@HIDDEN; Fri, 12 Jan 2024 09:13:10 -0500
Received: from list by ciao.gmane.io with local (Exim 4.92)
 (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1rOIHR-0008Yi-RH
 for bug-gnu-emacs@HIDDEN; Fri, 12 Jan 2024 15:13:05 +0100
X-Injected-Via-Gmane: http://gmane.org/
Mail-Followup-To: bug-gnu-emacs@HIDDEN
To: bug-gnu-emacs@HIDDEN
From: Emanuel Berg <incal@HIDDEN>
Subject: Re: bug#68401: 30.0.50;
 ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME',
 `erc-cmd-AME'. 2nd attempt
Date: Fri, 12 Jan 2024 15:12:57 +0100
Message-ID: <87edemvdw6.fsf@HIDDEN>
References: <87v87yvnly.fsf@HIDDEN>
 <834jfikb4d.fsf__6528.35318339697$1705061373$gmane$org@HIDDEN>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
User-Agent: Gnus/5.13 (Gnus v5.13)
Cancel-Lock: sha1:AHyAb5fhQVocpACSFva9ycnALO4=
Mail-Copies-To: never
Received-SPF: pass client-ip=116.202.254.214;
 envelope-from=geb-bug-gnu-emacs@HIDDEN; helo=ciao.gmane.io
X-Spam_score_int: -16
X-Spam_score: -1.7
X-Spam_bar: -
X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9,
 HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

--=-=-=
Content-Type: text/plain

Eli Zaretskii wrote:

> Our style is also to mention the interactive prompts in the
> doc string:
>
>     "Send LINE to all channels on all networks you are on.
>   Interactively, prompt for the line of text to send."

Here is a patch adding that, maybe if you apply it
sequentially after the first it will work?

I looked for a way to merge the two patches into one but
didn't find one, but I take it that is possible with git?
To create one patch out of all the commits?


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=0002-Docstrings-for-interactive-use.patch

From 73f3cc5072bb8cc95ce5367cb8aef74e5b047f0d Mon Sep 17 00:00:00 2001
From: Emanuel Berg <incal@HIDDEN>
Date: Fri, 12 Jan 2024 15:03:10 +0100
Subject: [PATCH 2/2] Docstrings for interactive use.

---
 lisp/erc/erc.el | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index 06791bce520..aeb7722b563 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -4017,7 +4017,8 @@ erc--split-string-shell-cmd
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 
 (defun erc-cmd-GMSG (line)
-  "Send LINE to all channels on all networks you are on."
+  "Send LINE to all channels on all networks you are on.
+Interactively, prompt for the line of text to send."
   (interactive "sSend to all channels: ")
   (setq line (erc-trim-string line))
   (erc-with-all-buffers-of-server nil
@@ -4026,7 +4027,8 @@ erc-cmd-GMSG
 (put 'erc-cmd-GMSG 'do-not-parse-args t)
 
 (defun erc-cmd-AMSG (line)
-  "Send LINE to all channels of the current network."
+  "Send LINE to all channels of the current network.
+Interactively, prompt for the line of text to send."
   (interactive "sSend to all channels on this network: ")
   (setq line (erc-trim-string line))
   (erc-with-all-buffers-of-server erc-server-process
@@ -4035,7 +4037,8 @@ erc-cmd-AMSG
 (put 'erc-cmd-AMSG 'do-not-parse-args t)
 
 (defun erc-cmd-GME (line)
-  "Send LINE as an action to all channels on all networks you are on."
+  "Send LINE as an action to all channels on all networks you are on.
+Interactively, prompt for the line of text to send."
   (interactive "sSend action to all channels: ")
   (erc-with-all-buffers-of-server nil
     (lambda () (erc-channel-p (erc-default-target)))
@@ -4043,7 +4046,8 @@ erc-cmd-GME
 (put 'erc-cmd-GME 'do-not-parse-args t)
 
 (defun erc-cmd-AME (line)
-  "Send LINE as an action to all channels on the current network."
+  "Send LINE as an action to all channels on the current network.
+Interactively, prompt for the line of text to send."
   (interactive "sSend action to all channels on this network: ")
   (erc-with-all-buffers-of-server erc-server-process
     (lambda () (erc-channel-p (erc-default-target)))
-- 
2.39.2


--=-=-=
Content-Type: text/plain


-- 
underground experts united
https://dataswamp.org/~incal

--=-=-=--





Information forwarded to bug-gnu-emacs@HIDDEN:
bug#68401; Package emacs. Full text available.

Message received at 68401 <at> debbugs.gnu.org:


Received: (at 68401) by debbugs.gnu.org; 12 Jan 2024 14:03:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 12 09:03:32 2024
Received: from localhost ([127.0.0.1]:35221 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOI8C-0002k3-Gm
	for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 09:03:32 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:54220)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rOI87-0002jl-KL
 for 68401 <at> debbugs.gnu.org; Fri, 12 Jan 2024 09:03:31 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rOI83-0006Uu-8U; Fri, 12 Jan 2024 09:03:23 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=LGbV2LH+8l72Y8aZe2ecGkvmAV35lL2An90kavpWhhY=; b=hJSkUTU23NbI
 T6hdbvfIPTedS9ycBGjqdTISfYJ496nbSJpWVbD3l5vKrmBCc1UMgto6+O4QnJwYe1ARxVOhJ/gum
 +SN8VtAqeivzw/n37BP7zQz8oT0oVUWQWtqhW+QKp5NciLKx5b5LXRXk8Y2vG13zypdKxpLrM/GJF
 8oNWdpK4jcSTJ6hou1Gc8wg+r/l6aRT9nyhQ5G/8QvzW6vczPSIJ1ZlgKQ+0RKOjJLmn3ahm81368
 WNJ+zLu2tW7RmTRnsgZxPcwhEcsEO0FbG6DLJdUPP83XMTVnkVfz6QnMjgCpduQD4tQjvx377cuPq
 p+Tf+ifKNoATH/H80Yulkg==;
Date: Fri, 12 Jan 2024 16:03:09 +0200
Message-Id: <83wmseir8i.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Emanuel Berg <incal@HIDDEN>
In-Reply-To: <87ply6vidl.fsf@HIDDEN> (message from Emanuel Berg on Fri, 
 12 Jan 2024 13:36:06 +0100)
Subject: Re: bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG',
 `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt
References: <87v87yvnly.fsf@HIDDEN> <834jfikb4d.fsf@HIDDEN>
 <87ply6vidl.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68401
Cc: emacs-erc@HIDDEN, 68401 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Emanuel Berg <incal@HIDDEN>
> Cc: 68401 <at> debbugs.gnu.org,  emacs-erc@HIDDEN
> Date: Fri, 12 Jan 2024 13:36:06 +0100
> 
> Eli Zaretskii wrote:
> 
> > This only gives the header line of a commit log message, but
> > the "meat" is missing. Here's a random example of a valid
> 
> It is valid, I know that since 'git commit' complained several
> times of non-empty lines, too long lines etc.

That's just the beginning of good commit log messages.  The other
aspects are also required, and that's why they are described in
CONTRIBUTE.  We expect the contributors to follow those conventions,
and we point out any deviations from them as part of the patch review
process.

> > Our style is also to mention the interactive prompts in the
> > doc string:
> >
> >     "Send LINE to all channels on all networks you are on.
> >   Interactively, prompt for the line of text to send."
> 
> If so the tools should say so but they don't. This is too
> inefficient for modern society.

Likewise here: we request that contributors adhere to our conventions,
even if the automated tools didn't yet catch up.  That's why patch
review requires human participation, instead of being an automated
process: the tools are not yet powerful enough to make it completely
computerized.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#68401; Package emacs. Full text available.

Message received at 68401 <at> debbugs.gnu.org:


Received: (at 68401) by debbugs.gnu.org; 12 Jan 2024 12:36:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 12 07:36:13 2024
Received: from localhost ([127.0.0.1]:35104 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOGlh-00011y-Kw
	for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 07:36:13 -0500
Received: from srv.dataswamp.org
 ([95.217.107.122]:2761 helo=dataswamp.org ident=hhs8vmowhltr5sxvum1l)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <incal@HIDDEN>) id 1rOGlc-00011l-BX
 for 68401 <at> debbugs.gnu.org; Fri, 12 Jan 2024 07:36:11 -0500
Received: from dataswamp.org (localhost [127.0.0.1])
 by dataswamp.org (OpenSMTPD) with ESMTP id 52b88cba;
 Fri, 12 Jan 2024 12:36:08 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=dataswamp.org; h=from:to
 :cc:subject:in-reply-to:references:date:message-id:mime-version
 :content-type; s=9287606; bh=eGHdUmpuJjj2Hbq25p7AU8D5v7g=; b=jtf
 Bg444sNSmuYaedWEeuXq6FJl7NmsqGWGQ1ItpnNFDeKlnVMmW9aPgMO0zwulyKUm
 grnn8WIaf6rmwLFwUexJR7B1/s/WRTf1tMwUkWe1rtebzQ1913nqG3V6WNqW7FJk
 NvHmSeQYnv1f/c4AnwRYDV9BB64q+Sqyh/zQ4Klo=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=dataswamp.org; h=from:to:cc
 :subject:in-reply-to:references:date:message-id:mime-version
 :content-type; q=dns; s=9287606; b=pCbAX0zGIeeFoDPeWCE7qXMYYbrXq
 PC/4Fyj7GtDqIsrMBno2l6X5EKam4DwxQgvf3DsyK2LdDjtnSmwLvbZzbyJVgLkM
 to5mWUsyxdWL/gIpf4BeaBw7dUUIKPs/rLljAT+X+Rxjh+G46RAE9gDw2je8ifrN
 gqzgxsGvJxXw+I=
Received: from ebc (localhost [127.0.0.1])
 by dataswamp.org (OpenSMTPD) with ESMTP id 297320a6;
 Fri, 12 Jan 2024 12:36:08 +0000 (UTC)
From: Emanuel Berg <incal@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG',
 `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt
In-Reply-To: <834jfikb4d.fsf@HIDDEN> (Eli Zaretskii's message of "Fri, 12 Jan
 2024 14:08:18 +0200")
References: <87v87yvnly.fsf@HIDDEN> <834jfikb4d.fsf@HIDDEN>
Mail-Copies-To: never
Date: Fri, 12 Jan 2024 13:36:06 +0100
Message-ID: <87ply6vidl.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68401
Cc: emacs-erc@HIDDEN, 68401 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii wrote:

> This only gives the header line of a commit log message, but
> the "meat" is missing. Here's a random example of a valid

It is valid, I know that since 'git commit' complained several
times of non-empty lines, too long lines etc.

> Our style is also to mention the interactive prompts in the
> doc string:
>
>     "Send LINE to all channels on all networks you are on.
>   Interactively, prompt for the line of text to send."

If so the tools should say so but they don't. This is too
inefficient for modern society.

-- 
underground experts united
https://dataswamp.org/~incal




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#68401; Package emacs. Full text available.

Message received at 68401 <at> debbugs.gnu.org:


Received: (at 68401) by debbugs.gnu.org; 12 Jan 2024 12:08:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 12 07:08:45 2024
Received: from localhost ([127.0.0.1]:35075 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOGL7-0003SW-JM
	for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 07:08:45 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:45116)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rOGL5-0003SJ-Ei
 for 68401 <at> debbugs.gnu.org; Fri, 12 Jan 2024 07:08:44 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rOGL0-0007K5-7N; Fri, 12 Jan 2024 07:08:39 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=y0YCLd1j8/M1hZyLGJQqk9v11/EHfyiJpKK+pS7TlWI=; b=qvclRgQaoy4y
 5qH/RdQAovEVnhthDVH0fO8qzcYN10A6t/3WrUTrFLL2oh+36qNaToYIqvYQdOjDnJKrXQaIYvw0m
 LrUDj7ozjKWV71KBj2Dex+h7s3NmpqFOEm/89vGFn5AXWjrEKuAeFMlroUB/WXUeDv4cTg0l0qDRl
 V3TyqG+EqkgKGoPSOOgO5MCFbg/SGQUGOk9aUPfQs4xVNN42nyH//RelNRKzPOK5IQJ3hKropnfuN
 Zfdi6NdCAoWEohAwHcBVXJCRk0SISWCv6hk910gLzeXy0idgFx+7QPnult9xdkxKmlehU45B4FPN1
 Z9iI0yFT0a4u98q59Pvn0w==;
Date: Fri, 12 Jan 2024 14:08:18 +0200
Message-Id: <834jfikb4d.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Emanuel Berg <incal@HIDDEN>
In-Reply-To: <87v87yvnly.fsf@HIDDEN> (message from Emanuel Berg on Fri, 
 12 Jan 2024 11:43:05 +0100)
Subject: Re: bug#68401: 30.0.50;
 ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME',
 `erc-cmd-AME'. 2nd attempt
References: <87v87yvnly.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68401
Cc: emacs-erc@HIDDEN, 68401 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: emacs-erc@HIDDEN
> From: Emanuel Berg <incal@HIDDEN>
> Tags: patch
> Date: Fri, 12 Jan 2024 11:43:05 +0100
> 
> Patch without whitespace changes.

It still lacks a log message according to our conventions.

> >From a2345b8eb22af2d5a052c1e22a19aeffc48544b2 Mon Sep 17 00:00:00 2001
> From: Emanuel Berg <incal@HIDDEN>
> Date: Fri, 12 Jan 2024 11:37:28 +0100
> Subject: [PATCH] `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'.

This only gives the header line of a commit log message, but the
"meat" is missing.  Here's a random example of a valid commit log
message (you can see more by typing "git log" from the shell prompt or
"C-x v L" inside Emacs):

    Implement missing functions for custom-icon widget

    * lisp/cus-edit.el (custom-icon-reset-saved, custom-icon-mark-to-save)
    (custom-icon-state-set-and-redraw, custom-icon-reset-standard)
    (custom-icon-mark-to-reset-standard): New functions.
    (custom-icon, custom-icon-extended-menu): Register and add them to the
    menu.  (Bug#66947)

See CONTRIBUTE for more information about our conventions in this
regard.

> -(defun erc-cmd-AMSG (line)
> -  "Send LINE to all channels of the current server that you are on."
> -  (interactive "sSend to all channels you're on: ")
> +(defun erc-cmd-GMSG (line)
> +  "Send LINE to all channels on all networks you are on."
> +  (interactive "sSend to all channels: ")

Our style is also to mention the interactive prompts in the doc
string:

    "Send LINE to all channels on all networks you are on.
  Interactively, prompt for the line of text to send."

> +(defun erc-cmd-AMSG (line)
> +  "Send LINE to all channels of the current network."

Same here.

> +(defun erc-cmd-GME (line)
> +  "Send LINE as an action to all channels on all networks you are on."

And here.

> +(defun erc-cmd-AME (line)
> +  "Send LINE as an action to all channels on the current network."

And here.

Thanks.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#68401; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 12 Jan 2024 10:43:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 12 05:43:22 2024
Received: from localhost ([127.0.0.1]:35006 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rOF0T-0000hN-NG
	for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 05:43:22 -0500
Received: from lists.gnu.org ([2001:470:142::17]:37158)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <incal@HIDDEN>) id 1rOF0O-0000gf-5i
 for submit <at> debbugs.gnu.org; Fri, 12 Jan 2024 05:43:19 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <incal@HIDDEN>)
 id 1rOF0K-0001qt-Ei
 for bug-gnu-emacs@HIDDEN; Fri, 12 Jan 2024 05:43:12 -0500
Received: from srv.dataswamp.org ([95.217.107.122] helo=dataswamp.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <incal@HIDDEN>)
 id 1rOF0H-0006J0-5Z
 for bug-gnu-emacs@HIDDEN; Fri, 12 Jan 2024 05:43:12 -0500
Received: from dataswamp.org (localhost [127.0.0.1])
 by dataswamp.org (OpenSMTPD) with ESMTP id 1d9858c2
 for <bug-gnu-emacs@HIDDEN>; Fri, 12 Jan 2024 10:43:05 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=dataswamp.org; h=from:to
 :subject:date:message-id:mime-version:content-type; s=9287606;
 bh=IQiKkS0IMn46DGbVe2txJjdrxdc=; b=Ok3K8kANxEESDfDPFNvjZ5ZpFkvm
 W2echFAkkDc0AK/T7+4LhqMAYg/9oDd+RicxRtFZpV3dywB2zNveFFxFWIAHs64K
 0bz4gSbc6hXWu6g2Sa0DWUucbFm3ZJniR1zHBbW6KVRON0RVtG86vORazp71X5Pe
 oCvZtb7aqXmu+C8=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=dataswamp.org; h=from:to
 :subject:date:message-id:mime-version:content-type; q=dns; s=
 9287606; b=vbLr89h0JKwk6yb5EPKmK9OJHVybl/TfOEfq0pvkkLSwdMmPayPa3
 c9/rEr4bAb1+rKpy0b2r2+PNJask0DAzUvYgT+tPUdEkK4eKDfunEHf7VLwgvXqd
 HdMWpOG0d3ww2Tu/MEUcwy3oWSeAgt+cwL6cizyBpoiRvrxOActkBc=
Received: from ebc (localhost [127.0.0.1])
 by dataswamp.org (OpenSMTPD) with ESMTP id 254ab436
 for <bug-gnu-emacs@HIDDEN>; Fri, 12 Jan 2024 10:43:05 +0000 (UTC)
From: Emanuel Berg <incal@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG',
 `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt
X-Debbugs-CC: emacs-erc@HIDDEN
Mail-Copies-To: never
Tags: patch
Date: Fri, 12 Jan 2024 11:43:05 +0100
Message-ID: <87v87yvnly.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=95.217.107.122; envelope-from=incal@HIDDEN;
 helo=dataswamp.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--=-=-=
Content-Type: text/plain


Patch without whitespace changes.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, cairo
 version 1.16.0) of 2024-01-09 built on ebc
Repository revision: 774c8ec74c98d69d56b2511a613145f2b69fb2eb
Repository branch: master
System Description: Debian GNU/Linux 12 (bookworm)

Configured using:
 'configure --enable-link-time-optimization
 --with-native-compilation=aot --with-x-toolkit=no
 --without-compress-install'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS
HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2
M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY OLDXMENU PDUMPER
PNG RSVG SECCOMP SOUND THREADS TIFF WEBP X11 XDBE XIM XINPUT2
XPM ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Text

Minor modes in effect:
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-netsplit-mode: t
  erc-menu-mode: t
  erc-list-mode: t
  erc-imenu-mode: t
  erc-match-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-log-mode: t
  erc-autojoin-mode: t
  erc-irccontrols-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-networks-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  transient-mark-mode: t
  auto-composition-mode: linux
  auto-compression-mode: t
  abbrev-mode: t

Load-path shadows:
/home/incal/quicklisp/dists/quicklisp/software/slime-v2.28/slime-tests hides /home/incal/.emacs.d/elpa/slime-20231218.2206/slime-tests
/home/incal/quicklisp/dists/quicklisp/software/slime-v2.28/slime hides /home/incal/.emacs.d/elpa/slime-20231218.2206/slime
/home/incal/quicklisp/dists/quicklisp/software/slime-v2.28/slime-autoloads hides /home/incal/.emacs.d/elpa/slime-20231218.2206/slime-autoloads
~/.emacs.d/emacs-init/version hides /usr/local/share/emacs/30.0.50/lisp/version
~/.emacs.d/lisp/abbrev hides /usr/local/share/emacs/30.0.50/lisp/abbrev

Features:
(smerge-mode shadow emacsbug bug-reference erc-ibuffer
ibuf-ext ibuffer ibuffer-loaddefs erc-notify erc-page
erc-services erc-sound erc-speedbar speedbar ezimage dframe
erc-truncate erc-xdcc erc-dcc w3m-save nnfolder completion
dos-w32 find-cmd find-dired ada-eglot elint cl-print ada-mode
ada-imenu align ada-skel wisi-skel eglot external-completion
jsonrpc flymake diff ert ewoc ada-indent-user-options ada-core
uniquify-files ada-mode-autoloads uniquify-files-autoloads
gnat-compiler gnat-compiler-autoloads skeleton
wisi-process-parse wisi-prj wisi wisi-fringe semantic/lex
semantic/fw mode-local find-file wisi-parse-common
wisi-autoloads loaddefs-gen tar-mode url-cache url-http
url-auth url-gw finder-inf conf-mode flow-fill mm-archive grep
vc-hg vc-git vc-bzr vc-dispatcher python w3m-symbol w3m-filter
canlock shortdoc qp display-line-numbers tabify mailalias
mule-util mail-extr textsec uni-scripts idna-mapping
ucs-normalize uni-confusable textsec-check gnus-async
gnus-bcklg gnus-dup gnus-ml disp-table cursor-sensor pop3
utf-7 nndraft nnmh nnml gnus-agent nnvirtual nntp gnus-cache
network-stream erc-track erc-netsplit erc-menu erc-list
erc-imenu term/linux cus-start global-keys yank xsel
wrap-search wood w3m-version w3m-unisearch w3m-survivor
w3m-sem w3m-keys w3m-swamp w3m-incal w3m-session vt version
variance todo-did time-cmp pcase test-face survivor summary
str-to-bits street today stats sort-list sort-incal sort
slime-incal slime-fancy slime-indentation slime-cl-indent
cl-indent slime-trace-dialog slime-fontifying-fu
slime-package-fu slime-references slime-compiler-notes-tree
advice slime-scratch slime-macrostep macrostep slime-mdot-fu
slime-enclosing-context slime-fuzzy slime-fancy-trace
slime-fancy-inspector slime-c-p-c slime-editing-commands
slime-autodoc slime-banner signal show-command sequence-string
scale restart replace-list remote ref-lines re-make-list
random quote-ref psea printer lpr piles package-style checkdoc
lisp-mnt ny negative-subtraction navigate-fs-keys tramp-cmds
tramp-cache tramp-sh native comp comp-cstr cl-extra model-ttt
model mode-by-filename misc-incal minor-modes t-mouse messages
message-incal message-header moggle measure match-data-format
man-incal mailrc mail mail-zoho mail-to-many mail-insert
mail-dataswamp list list-quoted-functions lisp-incal regexp
inf-lisp ielm linux-shell lights latex tex-mode kill kill-path
keys iterate-files info-incal html mhtml-mode cus-edit js
c-ts-common hex help-incal help-fns radix-tree debug backtrace
gnus-server gnus-score-incal gnus-incal-minimal smtpmail cite
frame-size fill-incal file tramp trampver tramp-integration
tramp-message help-mode tramp-compat tramp-loaddefs face
w3m-form slime-presentations slime-repl slime-parse bridge
slime etags fileloop xref project arc-mode archive-mode
hyperspec sh-script executable org ob ob-tangle ob-ref ob-lob
ob-table ob-exp org-macro org-src ob-comint org-pcomplete
org-list org-footnote org-faces org-entities org-version
ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold
org-fold-core org-keys oc org-loaddefs find-func cal-menu
calendar cal-loaddefs org-compat org-macs man gnus-cite
gemini-mode time-stamp ffap erc-match diff-mode easy-mmode
apt-sources-list apropos erc-show-modes erc-misc erc-man
erc-log-incal cus-load erc-connect epwgen enum emacs-shell
shell eshell em-hist esh-mode esh-var esh-cmd generator
esh-ext esh-proc esh-io esh-arg esh-module esh-groups esh-opt
esh-util elpher-incal bookmark pp socks nsm elpher elpa elisp
revert-buffer ide nroff-mode css-mode treesit smie sgml-mode
facemenu imenu eww xdg url-queue mm-url markdown-mode color
noutline outline make-mode quit gnus-incal group group-summary
find-command-zsh get-search-string erc-incal warnings
erc-spell erc-ring erc-pcomplete pcomplete erc-log erc-kill
erc-join erc-iterate erc-scroll erc-goodies erc-element
erc-button erc-fill erc-stamp erc format-spec erc-backend
erc-networks erc-common erc-compat erc-loaddefs gnus-score
score-mode elide-head edit window-incal window-other tabs
sudo-user-path echo-message ecat-incal dope dired-kill-ext
dired-aux dired-jump-target dired-incal w3m-url files-x
custom-vars search-regexp-in-files counter count console-keys
compilation-incal comic-book-insult color-incal char caps-back
c-and-cpp compile-incal compile comint ansi-osc ansi-color
ring cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles
cc-align cc-engine cc-vars cc-defs buffer-menu
switch-to-buffer switch-to-buffer-regexp buc browse gnus-srvr
bmi bike math perm spell ispell dwim bibtex-next-volume
bibtex-incal bibtex-field bibtex-book bibtex-autokey-insert
issn-verify isbn-verify bibtex batch audio article
w3m-download w3m-search file-write-to w3m-bookmark-more
w3m-tabs w3m-bookmark w3m doc-view filenotify jka-compr
image-mode exif timezone w3m-hist bookmark-w3m w3m-ems
w3m-favicon w3m-image w3m-fb tab-line icons w3m-proc w3m-util
thingatpt super scroll mode-line gnus-msg gnus-art mm-uu
mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr
pixel-fill kinsoku url-file svg dom gnus-group gnus-undo
gnus-start gnus-dbus dbus comp-run comp-common xml gnus-cloud
nnimap nnmail mail-source utf7 nnoo parse-time iso8601
gnus-spec gnus-int gnus-range message sendmail yank-media puny
dired dired-loaddefs rfc822 mml mml-sec epa derived epg
rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse
rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils
mailheader gnus-win gnus nnheader gnus-util
text-property-search time-date mail-utils range mm-util
mail-prsvr wid-edit close align-incal string align-from-left
abc rx elpher-autoloads gemini-mode-autoloads
go-mode-autoloads lua-mode-autoloads markdown-mode-autoloads
info slime-autoloads macrostep-autoloads sml-mode-autoloads
w3m-load w3m-autoloads package browse-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util mailcap url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs
password-cache json subr-x map byte-opt gv bytecomp
byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl
tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd touch-screen tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer
nadvice seq simple cl-generic indonesian philippine cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet
lao korean japanese eucjp-ms cp51932 hebrew greek romanian
slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button
loaddefs theme-loaddefs faces cus-face macroexp files window
text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget keymap hashtable-print-readable backquote
threads dbusbind inotify lcms2 dynamic-setting
system-font-setting font-render-setting cairo xinput2
x multi-tty move-toolbar make-network-process native-compile
emacs)

Memory information:
((conses 16 2284289 476222) (symbols 48 77310 39)
 (strings 32 428481 14571) (string-bytes 1 19241578)
 (vectors 16 138642) (vector-slots 8 3896275 228053)
 (floats 8 972 4000) (intervals 56 61703 8137)
 (buffers 976 291))


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=0001-erc-cmd-GMSG-erc-cmd-AMSG-erc-cmd-GME-erc-cmd-AME.patch

From a2345b8eb22af2d5a052c1e22a19aeffc48544b2 Mon Sep 17 00:00:00 2001
From: Emanuel Berg <incal@HIDDEN>
Date: Fri, 12 Jan 2024 11:37:28 +0100
Subject: [PATCH] `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'.

---
 lisp/erc/erc.el | 34 +++++++++++++++++++++++++++++-----
 1 file changed, 29 insertions(+), 5 deletions(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index 478683a77f5..06791bce520 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -4016,16 +4016,40 @@ erc--split-string-shell-cmd
 ;;                    Input commands handlers
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 
-(defun erc-cmd-AMSG (line)
-  "Send LINE to all channels of the current server that you are on."
-  (interactive "sSend to all channels you're on: ")
+(defun erc-cmd-GMSG (line)
+  "Send LINE to all channels on all networks you are on."
+  (interactive "sSend to all channels: ")
   (setq line (erc-trim-string line))
   (erc-with-all-buffers-of-server nil
-    (lambda ()
-      (erc-channel-p (erc-default-target)))
+    (lambda () (erc-channel-p (erc-default-target)))
+    (erc-send-message line)))
+(put 'erc-cmd-GMSG 'do-not-parse-args t)
+
+(defun erc-cmd-AMSG (line)
+  "Send LINE to all channels of the current network."
+  (interactive "sSend to all channels on this network: ")
+  (setq line (erc-trim-string line))
+  (erc-with-all-buffers-of-server erc-server-process
+    (lambda () (erc-channel-p (erc-default-target)))
     (erc-send-message line)))
 (put 'erc-cmd-AMSG 'do-not-parse-args t)
 
+(defun erc-cmd-GME (line)
+  "Send LINE as an action to all channels on all networks you are on."
+  (interactive "sSend action to all channels: ")
+  (erc-with-all-buffers-of-server nil
+    (lambda () (erc-channel-p (erc-default-target)))
+    (erc-cmd-ME line) ))
+(put 'erc-cmd-GME 'do-not-parse-args t)
+
+(defun erc-cmd-AME (line)
+  "Send LINE as an action to all channels on the current network."
+  (interactive "sSend action to all channels on this network: ")
+  (erc-with-all-buffers-of-server erc-server-process
+    (lambda () (erc-channel-p (erc-default-target)))
+    (erc-cmd-ME line) ))
+(put 'erc-cmd-AME 'do-not-parse-args t)
+
 (defun erc-cmd-SAY (line)
   "Send LINE to the current query or channel as a message, not a command.
 
-- 
2.39.2


--=-=-=
Content-Type: text/plain


-- 
underground experts united
https://dataswamp.org/~incal

--=-=-=--




Acknowledgement sent to Emanuel Berg <incal@HIDDEN>:
New bug report received and forwarded. Copy sent to emacs-erc@HIDDEN, bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to emacs-erc@HIDDEN, bug-gnu-emacs@HIDDEN:
bug#68401; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 20 Jan 2024 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.