GNU bug report logs - #68402
[elpa/csv-mode] [PATCH] Add option to turn off the "Region OK?" prompt

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68402 in the body.
You can then email your comments to 68402 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: [elpa/csv-mode] [PATCH] Add option to turn off the "Region OK?" prompt
Date: Fri, 12 Jan 2024 14:52:31 +0100

[Message part 1 (text/plain, inline)]

Hi.

Attached is a proposed patch adding a new option to turn off the
"Region OK?" prompt in interactive csv-mode commands.

[0001-Add-option-to-turn-off-the-Region-OK-prompt.patch (text/x-diff, attachment)]

Message #8 received at 68402 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Simen Heggestøyl <simenheg <at> runbox.com>
Cc: monnier <at> iro.umontreal.ca, 68402 <at> debbugs.gnu.org
Subject: Re: bug#68402: [elpa/csv-mode] [PATCH] Add option to turn off the
 "Region OK?" prompt
Date: Fri, 12 Jan 2024 16:14:41 +0200

> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Date: Fri, 12 Jan 2024 14:52:31 +0100
> From:  Simen Heggestøyl via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Attached is a proposed patch adding a new option to turn off the
> "Region OK?" prompt in interactive csv-mode commands.

Thanks.

> +(defcustom csv-confirm-region t
> +  "If non-nil, confirm that region is OK in interactive commands."
> +  :type 'boolean)
> +

New defcustoms should have a :version tag.

Do we need to call this out in NEWS?

Message #11 received at 68402 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: monnier <at> iro.umontreal.ca, 68402 <at> debbugs.gnu.org
Subject: Re: bug#68402: [elpa/csv-mode] [PATCH] Add option to turn off the
 "Region OK?" prompt
Date: Fri, 12 Jan 2024 16:47:25 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> New defcustoms should have a :version tag.

Even in GNU ELPA?

> Do we need to call this out in NEWS?

I don't think so, given that csv-mode lives in GNU ELPA?

-- Simen

Message #14 received at 68402 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Simen Heggestøyl <simenheg <at> runbox.com>
Cc: monnier <at> iro.umontreal.ca, 68402 <at> debbugs.gnu.org
Subject: Re: bug#68402: [elpa/csv-mode] [PATCH] Add option to turn off the
 "Region OK?" prompt
Date: Fri, 12 Jan 2024 17:52:07 +0200

> From: Simen Heggestøyl <simenheg <at> runbox.com>
> Cc: 68402 <at> debbugs.gnu.org,  monnier <at> iro.umontreal.ca
> Date: Fri, 12 Jan 2024 16:47:25 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > New defcustoms should have a :version tag.
> 
> Even in GNU ELPA?

I thought ELPA packages have their versions?

Is there a way to tell customize-changed that a defcustom of an ELPA
package is new or changed since the last version?

> > Do we need to call this out in NEWS?
> 
> I don't think so, given that csv-mode lives in GNU ELPA?

Right, sorry.

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Simen Heggestøyl <simenheg <at> runbox.com>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: [elpa/csv-mode] [PATCH] Add option to turn off the "Region OK?"
 prompt
Date: Sun, 14 Jan 2024 20:38:04 -0500

> Attached is a proposed patch adding a new option to turn off the
> "Region OK?" prompt in interactive csv-mode commands.

Thanks, pushed,


        Stefan

Message #20 received at 68402 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: monnier <at> iro.umontreal.ca, 68402 <at> debbugs.gnu.org
Subject: Re: bug#68402: [elpa/csv-mode] [PATCH] Add option to turn off the
 "Region OK?" prompt
Date: Fri, 19 Jan 2024 08:53:42 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Simen Heggestøyl <simenheg <at> runbox.com>
>> Cc: 68402 <at> debbugs.gnu.org,  monnier <at> iro.umontreal.ca
>> Date: Fri, 12 Jan 2024 16:47:25 +0100
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> > New defcustoms should have a :version tag.
>> 
>> Even in GNU ELPA?
>
> I thought ELPA packages have their versions?
>
> Is there a way to tell customize-changed that a defcustom of an ELPA
> package is new or changed since the last version?

As far as I can tell, :version denotes the Emacs version. But maybe
:package-version would have been appropriate to use here? I don't see it
used for any of the other defcustoms in csv-mode, though.

-- Simen

Message #23 received at 68402 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Simen Heggestøyl <simenheg <at> runbox.com>
Cc: monnier <at> iro.umontreal.ca, 68402 <at> debbugs.gnu.org
Subject: Re: bug#68402: [elpa/csv-mode] [PATCH] Add option to turn off the
 "Region OK?" prompt
Date: Fri, 19 Jan 2024 10:13:36 +0200

> From: Simen Heggestøyl <simenheg <at> runbox.com>
> Cc: 68402 <at> debbugs.gnu.org,  monnier <at> iro.umontreal.ca
> Date: Fri, 19 Jan 2024 08:53:42 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: Simen Heggestøyl <simenheg <at> runbox.com>
> >> Cc: 68402 <at> debbugs.gnu.org,  monnier <at> iro.umontreal.ca
> >> Date: Fri, 12 Jan 2024 16:47:25 +0100
> >> 
> >> Eli Zaretskii <eliz <at> gnu.org> writes:
> >> 
> >> > New defcustoms should have a :version tag.
> >> 
> >> Even in GNU ELPA?
> >
> > I thought ELPA packages have their versions?
> >
> > Is there a way to tell customize-changed that a defcustom of an ELPA
> > package is new or changed since the last version?
> 
> As far as I can tell, :version denotes the Emacs version. But maybe
> :package-version would have been appropriate to use here? I don't see it
> used for any of the other defcustoms in csv-mode, though.

Stefan, how does customize-changed deal with defcustoms of ELPA
packages?

Message #26 received at 68402 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Simen Heggestøyl <simenheg <at> runbox.com>,
 68402 <at> debbugs.gnu.org
Subject: Re: bug#68402: [elpa/csv-mode] [PATCH] Add option to turn off the
 "Region OK?" prompt
Date: Fri, 19 Jan 2024 08:03:43 -0500

>> As far as I can tell, :version denotes the Emacs version. But maybe
>> :package-version would have been appropriate to use here? I don't see it
>> used for any of the other defcustoms in csv-mode, though.
>
> Stefan, how does customize-changed deal with defcustoms of ELPA
> packages?

As Simen found out, there's `:package-version` for that.
Many packages don't bother to use it, tho.


        Stefan

Message #33 received at 68402-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Simen Heggestøyl <simenheg <at> runbox.com>,
 68402-done <at> debbugs.gnu.org
Subject: Re: bug#68402: [elpa/csv-mode] [PATCH] Add option to turn off the
 "Region OK?" prompt
Date: Tue, 11 Feb 2025 19:54:29 -0800

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> Attached is a proposed patch adding a new option to turn off the
>> "Region OK?" prompt in interactive csv-mode commands.
>
> Thanks, pushed,

I'm therefore closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.