GNU logs - #68413, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#68413: Ungexp doesn't work on deep lists
Resent-From: Justin Veilleux <terramorpha@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Sat, 13 Jan 2024 01:53:01 +0000
Resent-Message-ID: <handler.68413.B.170511076822972 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 68413 <at> debbugs.gnu.org
From: Justin Veilleux <terramorpha@HIDDEN>
Date: Fri, 12 Jan 2024 20:52:21 -0500
Message-ID: <87v87yvw2y.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=37.120.193.123; envelope-from=terramorpha@HIDDEN;
 helo=mail.cock.li
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)


Hi, I've been using G-expressions for some time and have always been
hindered by `ungexp` not working on deeper lists. For instance, when I
want to embed in a G-expression a list of packages, it works

>(define packages (list coreutils gnu-make ...))
>
> #~(for-each
>    (lambda (f)
>      ... do-something)
>    '#$packages)

But as soon as I use an object in which the file-like objects are
deeper, it fails

> (define packages
>         (list
>          (cons "coreutils" coreutils)
>          (cons "make" gnu-make)
>          ...))
>
> #~(for-each
>    (lambda (f)
>      ... do-something)
>    '#$packages)

If I send a patch to "fix" this, will it be usefull or is there a reason
for this behavior?

Thanks.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Justin Veilleux <terramorpha@HIDDEN>
Subject: bug#68413: Acknowledgement (Ungexp doesn't work on deep lists)
Message-ID: <handler.68413.B.170511076822972.ack <at> debbugs.gnu.org>
References: <87v87yvw2y.fsf@HIDDEN>
X-Gnu-PR-Message: ack 68413
X-Gnu-PR-Package: guix
Reply-To: 68413 <at> debbugs.gnu.org
Date: Sat, 13 Jan 2024 01:53:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 68413 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
68413: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68413
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#68413: Ungexp doesn't work on deep lists
Resent-From: Josselin Poiret <dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Sat, 13 Jan 2024 11:39:01 +0000
Resent-Message-ID: <handler.68413.B68413.170514592630471 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Justin Veilleux <terramorpha@HIDDEN>, 68413 <at> debbugs.gnu.org
From: Josselin Poiret <dev@HIDDEN>
In-Reply-To: <87v87yvw2y.fsf@HIDDEN>
References: <87v87yvw2y.fsf@HIDDEN>
Date: Sat, 13 Jan 2024 12:38:38 +0100
Message-ID: <87ttnhh39d.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi Justin,

Justin Veilleux <terramorpha@HIDDEN> writes:

>> (define packages
>>         (list
>>          (cons "coreutils" coreutils)
>>          (cons "make" gnu-make)
>>          ...))
>>
>> #~(for-each
>>    (lambda (f)
>>      ... do-something)
>>    '#$packages)
>
> If I send a patch to "fix" this, will it be usefull or is there a reason
> for this behavior?

I think IMO that it's a bug, but it's also quite tricky to properly
traverse deep structures like this.  The bug comes from the fact that in
gexp->sexp, we traverse lists by matching the reference with (refs ...),
but that doesn't match if the reference is a pair instead.  Then, it
tries to match with ($ <gexp-input> (? self-quoting? x)), which does
match since self-quoting? apparently returns #t on a pair, whether or
not its constituents are also self-quoting.

Best,
=2D-=20
Josselin Poiret

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQHEBAEBCAAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmWidj4QHGRldkBqcG9p
cmV0Lnh5egAKCRBQXkC5Fhcaij9YDACaNDfeMZsVBnnXyeSYtPhNu3VfkcN1UGZk
sr3n9lFm8dnSJ5buUVNo5vXm34xgwuG+QrNe682Hmd8oj/Hn/oSTCcFn9+jkFpn4
QX7N30P+Rn9fXoB2tpj5B64pv6ITl3jL8Tkw5+l3EZKp4Mrl6QgfOrv8talCj3jv
GDgPNuh+siek7S7u57HZNY5Re9gvhNvNE5XGMmCF47QQcfM76jnmojnxYDSw/aaK
DexShbr/BWwkqSQn0VcinoJ+ASCy/tymqg2Vf/ooaMDDgGWEuz0N1C35qJRkp0GR
DYXn+ffoaHmRqqJpuAfFwInIi4sFFC7OWWlgiRYfRXjniO7JB/wpUKi7xZ9ay3t5
+yK08wlnEAblRPnaS7x0fYhCUIJn5u5goBoGz86oghh05wNM+wuG4pf0WMqRlOww
YF+XG0jrad6JrpC370epzDo/Z5qtJLwp5weDUqs8Q1J0wRyEokbYke+PGiqorLVs
UnPVdmrIYdeTZApTb4olaUXFsJZjgLY=
=PxKF
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to bug-guix@HIDDEN:

Subject: bug#68413: Ungexp doesn't work on deep lists
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Mon, 15 Jan 2024 09:47:02 +0000
Resent-Message-ID: <handler.68413.B68413.170531201226492 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Josselin Poiret <dev@HIDDEN>
Cc: Justin Veilleux <terramorpha@HIDDEN>, 68413 <at> debbugs.gnu.org
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
In-Reply-To: <87ttnhh39d.fsf@HIDDEN> (Josselin Poiret's message of "Sat, 
 13 Jan 2024 12:38:38 +0100")
References: <87v87yvw2y.fsf@HIDDEN> <87ttnhh39d.fsf@HIDDEN>
Date: Mon, 15 Jan 2024 10:46:42 +0100
Message-ID: <87le8rj5dp.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

Josselin Poiret <dev@HIDDEN> skribis:

> Justin Veilleux <terramorpha@HIDDEN> writes:
>
>>> (define packages
>>>         (list
>>>          (cons "coreutils" coreutils)
>>>          (cons "make" gnu-make)
>>>          ...))
>>>
>>> #~(for-each
>>>    (lambda (f)
>>>      ... do-something)
>>>    '#$packages)
>>
>> If I send a patch to "fix" this, will it be usefull or is there a reason
>> for this behavior?
>
> I think IMO that it's a bug, but it's also quite tricky to properly
> traverse deep structures like this.  The bug comes from the fact that in
> gexp->sexp, we traverse lists by matching the reference with (refs ...),
> but that doesn't match if the reference is a pair instead.  Then, it
> tries to match with ($ <gexp-input> (? self-quoting? x)), which does
> match since self-quoting? apparently returns #t on a pair, whether or
> not its constituents are also self-quoting.

Actually, what bug are we talking about?  It seems to work for me with
this example:

--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> (define packages `(("coreutils" ,coreutils) ("make" ,g=
nu-make)))
scheme@(guile-user)> ,build (scheme-file "foo" #~(begin '#$packages))
building /gnu/store/lq9gvbilv0y2nph00zxk6bn3lvcgdxqq-foo.drv...
$7 =3D "/gnu/store/9ryh6v80jvjv3kwx0q782h26h9gbaclj-foo"
scheme@(guile-user)> (call-with-input-file $7 get-string-all)
$8 =3D "(begin (quote ((\"coreutils\" \"/gnu/store/mppp9hwxizx9g9pikwcvvshb=
2ffxyq7p-coreutils-9.1\") (\"make\" \"/gnu/store/9fadhs5qmwl5x7f669a0v39b3r=
yrmmf1-make-4.3\"))))"
--8<---------------cut here---------------end--------------->8---

One of the design decisions for gexps was to ensure that substituting a
file-like object by its file name would be O(1) in most cases.

Substitution in lists as in the example above is supported, but
primarily for backward compatibility.  It should be avoided when
possible because it=E2=80=99s inefficient: =E2=80=98gexp->sexp=E2=80=99 nee=
ds to traverse the
whole list/tree in search of potential candidates.

Thanks,
Ludo=E2=80=99.

Message sent to bug-guix@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#68413: Ungexp doesn't work on deep lists
Resent-From: Josselin Poiret <dev@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Mon, 15 Jan 2024 16:29:01 +0000
Resent-Message-ID: <handler.68413.B68413.170533613813563 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 68413
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: Justin Veilleux <terramorpha@HIDDEN>, 68413 <at> debbugs.gnu.org
Received: via spool by 68413-submit <at> debbugs.gnu.org id=B68413.170533613813563
          (code B ref 68413); Mon, 15 Jan 2024 16:29:01 +0000
Received: (at 68413) by debbugs.gnu.org; 15 Jan 2024 16:28:58 +0000
Received: from localhost ([127.0.0.1]:46740 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rPPpZ-0003Wh-Vn
	for submit <at> debbugs.gnu.org; Mon, 15 Jan 2024 11:28:58 -0500
Received: from jpoiret.xyz ([206.189.101.64]:42058)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dev@HIDDEN>) id 1rPPpY-0003WY-AM
 for 68413 <at> debbugs.gnu.org; Mon, 15 Jan 2024 11:28:57 -0500
Received: from authenticated-user (jpoiret.xyz [206.189.101.64])
 by jpoiret.xyz (Postfix) with ESMTPA id B1211184D5F;
 Mon, 15 Jan 2024 16:28:53 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim;
 t=1705336134;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=nbKBSxWSTrr0s0buhajTOOebNQMohPuQO6+S1JL4/m4=;
 b=pihc2Y6ptgDnCd1PajrBMcW1N1vdr9NNzomkCJ+cmrvCw+jxhBTbrM5F1OYpxkOy58tFmC
 amlnWSOWPTk4jdmVLGcqnREW4SZE95tQWcYK6A/EcrM7vvVyv1YThQMwZ3DQwa+q5FF2P4
 tS5npDMASaaM4RMTOZUAjUBsm1zoqtMx9CbAklt4KhBoBFYSXRXtklQFDVX5atU09bdD+E
 OhohmsZWBJxBaa48+szvHokXi+OfO75MG2NIzjZVXkR9mI7KJBQzgC7ES3po/wIf7Yg/GO
 YNGb+shvwReifNXn0EHDtMp7v39VikNITUgGCAfGaCnCW0lWAdtetUXwCCaB2A==
From: Josselin Poiret <dev@HIDDEN>
In-Reply-To: <87le8rj5dp.fsf@HIDDEN>
References: <87v87yvw2y.fsf@HIDDEN> <87ttnhh39d.fsf@HIDDEN>
 <87le8rj5dp.fsf@HIDDEN>
Date: Mon, 15 Jan 2024 17:28:47 +0100
Message-ID: <87bk9m1ry8.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha256; protocol="application/pgp-signature"
X-Spamd-Bar: --
Authentication-Results: jpoiret.xyz;
 auth=pass smtp.auth=jpoiret@HIDDEN smtp.mailfrom=dev@HIDDEN
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Ludo,

Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

> Actually, what bug are we talking about?  It seems to work for me with
> this example:
>
> --8<---------------cut here---------------start------------->8---
> scheme@(guile-user)> (define packages `(("coreutils" ,coreutils) ("make" =
,gnu-make)))
> scheme@(guile-user)> ,build (scheme-file "foo" #~(begin '#$packages))
> building /gnu/store/lq9gvbilv0y2nph00zxk6bn3lvcgdxqq-foo.drv...
> $7 =3D "/gnu/store/9ryh6v80jvjv3kwx0q782h26h9gbaclj-foo"
> scheme@(guile-user)> (call-with-input-file $7 get-string-all)
> $8 =3D "(begin (quote ((\"coreutils\" \"/gnu/store/mppp9hwxizx9g9pikwcvvs=
hb2ffxyq7p-coreutils-9.1\") (\"make\" \"/gnu/store/9fadhs5qmwl5x7f669a0v39b=
3ryrmmf1-make-4.3\"))))"
> --8<---------------cut here---------------end--------------->8---
>
> One of the design decisions for gexps was to ensure that substituting a
> file-like object by its file name would be O(1) in most cases.
>
> Substitution in lists as in the example above is supported, but
> primarily for backward compatibility.  It should be avoided when
> possible because it=E2=80=99s inefficient: =E2=80=98gexp->sexp=E2=80=99 n=
eeds to traverse the
> whole list/tree in search of potential candidates.

Notice that OP's example uses `(("thing" . ,package)), ie. lists of
pairs and not lists of lists, as in your case!

Best,
=2D-=20
Josselin Poiret

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQHEBAEBCAAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmWlXT8QHGRldkBqcG9p
cmV0Lnh5egAKCRBQXkC5FhcairojC/9CurDR/TEqvZIn0O5WeT385pUtJ2PgC0GY
qsCzJQxvQN3LwMRmK+Lp3J5jvHKkMCqh6ufyc5FhrsSaiWS6Il0dfzLhwfqwnAFz
18iw46Q/8CQ8myxxa0rCxuwQEBmy6vMfl1We56wGC8UPChM9QRXWbthv/1TLctCD
yhKYv4nDjkpkT/nf/EhTOrdCeTuzve7CUkeud21uQ7q+bYLRkXnUfoHDQ+qIan3m
SuYnnUDLPfzVJSZuxTxQ+DeI4TNFibrkwWzpGgsjFE4PcqDkgcRCe9oPF20XcmJA
S9IzPcRF34bzp3IHipU5JmlRXYwGJriAAI5sImpm0jq2DaKHGshd9hwYUzw1obR5
0CLPpM/yksZOX2H2z3L5UZTnSZENs49k/LfR6LQpU2sDAsk0OE+ODoGgzQ0AYxJ8
EZxCn3TatNpZIxEmrLubqpCT0c5gXZU/NmJnQ2PPhDcDbtt2iupMhFMBjTifnTXG
wFrQJHKdWWLhwLBjdStzgXcPznlk888=
=lsmz
-----END PGP SIGNATURE-----
--=-=-=--

Last modified: Sat, 20 Jan 2024 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.