GNU bug report logs - #68552
[PATCH] gnu: Add duckdb.

Previous Next

Package: guix-patches;

Reported by: Greg Hogan <code <at> greghogan.com>

Date: Wed, 17 Jan 2024 21:51:02 UTC

Severity: normal

Tags: patch

Done: Sharlatan Hellseher <sharlatanus <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68552 in the body.
You can then email your comments to 68552 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#68552; Package guix-patches. (Wed, 17 Jan 2024 21:51:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Greg Hogan <code <at> greghogan.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 17 Jan 2024 21:51:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: guix-patches <at> gnu.org
Cc: Greg Hogan <code <at> greghogan.com>
Subject: [PATCH] gnu: Add duckdb.
Date: Wed, 17 Jan 2024 21:49:18 +0000
There exists a package python-duckdb, and this patch adds a package for
the CLI and C++ libraries.

* gnu/packages/cpp.scm (duckdb): New variable.
---
 gnu/packages/cpp.scm | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index ecd3e4afac..420d9e8708 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -14,7 +14,7 @@
 ;;; Copyright © 2020, 2022 Marius Bakke <marius <at> gnu.org>
 ;;; Copyright © 2020 Michael Rohleder <mike <at> rohleder.de>
 ;;; Copyright © 2020 Alexandros Theodotou <alex <at> zrythm.org>
-;;; Copyright © 2020-2022 Greg Hogan <code <at> greghogan.com>
+;;; Copyright © 2020-2022, 2024 Greg Hogan <code <at> greghogan.com>
 ;;; Copyright © 2020 Brett Gilio <brettg <at> gnu.org>
 ;;; Copyright © 2020 Milkey Mouse <milkeymouse <at> meme.institute>
 ;;; Copyright © 2021 Raghav Gururajan <rg <at> raghavgururajan.name>
@@ -3064,3 +3064,30 @@ (define-public tl-optional
 the std::optional for C++11/14/17, with support for monadic operations added in
 C++23.")
     (license license:cc0)))
+
+(define-public duckdb
+  (package
+    (name "duckdb")
+    (version "0.9.2")
+    (source
+      (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/duckdb/duckdb")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0dbsxyiz7c8sxflbfj87qv0b2s69zk802vsk5h00ra8w8fcbqlj0"))
+       (modules '((guix build utils)))
+       (snippet
+        #~(begin
+            ;; There is no git checkout from which to read the version tag.
+            (substitute* "CMakeLists.txt"
+              (("set\\(DUCKDB_VERSION \"[^\"]*\"")
+               (string-append "set(DUCKDB_VERSION \"v" #$version "-dev0\"")))))))
+    (build-system cmake-build-system)
+    (synopsis "DuckDB embedded database")
+    (description "DuckDB is an in-process SQL OLAP database management system.")
+    (home-page "https://duckdb.org")
+    (license license:expat)))

base-commit: 692272661548eb2a46aaa818175b1a39b3fc9ffa
-- 
2.40.1





Information forwarded to guix-patches <at> gnu.org:
bug#68552; Package guix-patches. (Sat, 20 Jan 2024 12:50:02 GMT) Full text and rfc822 format available.

Message #8 received at 68552 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 68552 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add duckdb.
Date: Sat, 20 Jan 2024 12:48:44 +0000
[Message part 1 (text/plain, inline)]
Hi,

Thank you for the patch.

There is one minor lint warnings in QA, and maybe it more suitable for
databases module (based on description)?

Thanks,
Oleg
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#68552; Package guix-patches. (Tue, 30 Jan 2024 17:11:01 GMT) Full text and rfc822 format available.

Message #11 received at 68552 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: 68552 <at> debbugs.gnu.org
Cc: Greg Hogan <code <at> greghogan.com>
Subject: [PATCH v2] gnu: Add duckdb.
Date: Tue, 30 Jan 2024 17:08:49 +0000
Per the review, v2 updates the synopsis and description and moves the
patch to databases.scm.

* gnu/packages/databases.scm (duckdb): New variable.

Change-Id: Ic689dbd4bb91a2c806f846464e2af95be50cd069
---
 gnu/packages/databases.scm | 35 ++++++++++++++++++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index b56767d311..20766aeb55 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -46,7 +46,7 @@
 ;;; Copyright © 2020 Vinicius Monego <monego <at> posteo.net>
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll <at> gmail.com>
 ;;; Copyright © 2021 Sharlatan Hellseher <sharlatanus <at> gmail.com>
-;;; Copyright © 2021 Greg Hogan <code <at> greghogan.com>
+;;; Copyright © 2021, 2024 Greg Hogan <code <at> greghogan.com>
 ;;; Copyright © 2021 David Larsson <david.larsson <at> selfhosted.xyz>
 ;;; Copyright © 2021 Pjotr Prins <pjotr.guix <at> thebird.nl>
 ;;; Copyright © 2021 Bonface Munyoki Kilyungi <me <at> bonfacemunyoki.com>
@@ -5329,3 +5329,36 @@ (define-public datasette
 It helps people take data of any shape or size and publish that as an
 interactive, explorable website and accompanying API.")
     (license license:asl2.0)))
+
+(define-public duckdb
+  (package
+    (name "duckdb")
+    (version "0.9.2")
+    (source
+      (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/duckdb/duckdb")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0dbsxyiz7c8sxflbfj87qv0b2s69zk802vsk5h00ra8w8fcbqlj0"))
+       (modules '((guix build utils)))
+       (snippet
+        #~(begin
+            ;; There is no git checkout from which to read the version tag.
+            (substitute* "CMakeLists.txt"
+              (("set\\(DUCKDB_VERSION \"[^\"]*\"")
+               (string-append "set(DUCKDB_VERSION \"v" #$version "-dev0\"")))))))
+    (build-system cmake-build-system)
+    (synopsis "In-process SQL OLAP database management system")
+    (description "CLI and C/C++ source libraries for DuckDB, a relational
+(table-oriented) @acronym{DBMS, Database Management System} that supports
+@acronym{SQL, Structured Query Language}, contains a columnar-vectorized query
+execution engine, and provides transactional @acronym{ACID, Atomicity
+Consistency Isolation and Durability} guarantees via bulk-optimized
+@acronym{MVCC, Multi-Version Concurrency Control}.  Data can be stored in
+persistent, single-file databases with support for secondary indexes.")
+    (home-page "https://duckdb.org")
+    (license license:expat)))

base-commit: c2935acbfc7388f0f3eb3f783c8e54b8b05a2983
-- 
2.43.0





Reply sent to Sharlatan Hellseher <sharlatanus <at> gmail.com>:
You have taken responsibility. (Wed, 14 Feb 2024 12:15:02 GMT) Full text and rfc822 format available.

Notification sent to Greg Hogan <code <at> greghogan.com>:
bug acknowledged by developer. (Wed, 14 Feb 2024 12:15:02 GMT) Full text and rfc822 format available.

Message #16 received at 68552-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 68552-done <at> debbugs.gnu.org
Cc: Greg Hogan <code <at> greghogan.com>
Subject: [PATCH] gnu: Add duckdb.
Date: Wed, 14 Feb 2024 12:13:21 +0000
[Message part 1 (text/plain, inline)]
Hi Greg,

I've pushed it as 3fa4a8baf3fb735a09ed915abd4f61600e2d77e2 to master.

There is a new released published on 2024-02-13
https://github.com/duckdb/duckdb/releases/tag/v0.10.0. I tried to update
it but it requires more work as it failed to build.

If you have some spare time, may you take a look at it please?

Thanks,
Oleg
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#68552; Package guix-patches. (Wed, 14 Feb 2024 13:57:02 GMT) Full text and rfc822 format available.

Message #19 received at 68552-done <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 68552-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add duckdb.
Date: Wed, 14 Feb 2024 08:54:54 -0500
On Wed, Feb 14, 2024 at 7:13 AM Sharlatan Hellseher
<sharlatanus <at> gmail.com> wrote:
>
>
> Hi Greg,
>
> I've pushed it as 3fa4a8baf3fb735a09ed915abd4f61600e2d77e2 to master.
>
> There is a new released published on 2024-02-13
> https://github.com/duckdb/duckdb/releases/tag/v0.10.0. I tried to update
> it but it requires more work as it failed to build.
>
> If you have some spare time, may you take a look at it please?
>
> Thanks,
> Oleg

Oleg,

Thanks for the commit. I happened upon the update yesterday and also
tried the simple version update, hitting the same issue as you. I'll
try to look at it again sometime.

Greg




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 14 Mar 2024 11:24:14 GMT) Full text and rfc822 format available.

This bug report was last modified 134 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.