GNU bug report logs - #68624
[PATCH] Decode errno for encoding errors.

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 21 Jan 2024 03:45:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 20 22:45:54 2024
Received: from localhost ([127.0.0.1]:36254 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rROmP-00082m-N0
	for submit <at> debbugs.gnu.org; Sat, 20 Jan 2024 22:45:54 -0500
Received: from lists.gnu.org ([2001:470:142::17]:45226)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <felix.lechner@HIDDEN>) id 1rROmK-00082S-EC
 for submit <at> debbugs.gnu.org; Sat, 20 Jan 2024 22:45:52 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <felix.lechner@HIDDEN>)
 id 1rROmA-0000dY-6A
 for bug-guile@HIDDEN; Sat, 20 Jan 2024 22:45:38 -0500
Received: from sail-ipv4.us-core.com ([208.82.101.137])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
 (Exim 4.90_1) (envelope-from <felix.lechner@HIDDEN>)
 id 1rROm7-00046f-Hb
 for bug-guile@HIDDEN; Sat, 20 Jan 2024 22:45:37 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=dZFAygPCV4C454f
 Hi8VCVZTpqXlJHvtPHrawX/Vkhlo=; h=date:subject:cc:to:from;
 d=lease-up.com; b=iziunukq8MkwUZiWcoCwcjH3R0Es5SbywywGNK8+kqQsFnocLqCL
 x/QG6vKVf44p6Us6RhJnAJgbaZn2z/zmtdRjKfq7YcMrqBE/Cv/oTaqN2aDceV2446gVOS
 FKLEF5CJS+0tVh9w9tBKBZDZGZBLToLedaW4IBs4bMMT+kg6Y=
Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id c8d69100
 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); 
 Sun, 21 Jan 2024 03:45:31 +0000 (UTC)
Received: from localhost (localhost [local])
 by localhost (OpenSMTPD) with ESMTPA id 6d86577a;
 Sun, 21 Jan 2024 03:45:30 +0000 (UTC)
From: Felix Lechner <felix.lechner@HIDDEN>
To: bug-guile@HIDDEN
Subject: [PATCH] Decode errno for encoding errors.
Date: Sat, 20 Jan 2024 19:38:26 -0800
Message-ID: <20240121034401.17992-2-felix.lechner@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=208.82.101.137;
 envelope-from=felix.lechner@HIDDEN; helo=sail-ipv4.us-core.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01,
 UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: * libguile/strings.c (scm_encoding_error): Decode errno. ---
 Hi, Even experienced users do not memorize errno values. [1][2] Why not decode
 them as a courtesy? 
 Content analysis details:   (1.2 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
 mail domains are different
 0.9 SPF_FAIL               SPF: sender does not match SPF record (fail)
 [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;
 id=felix.lechner%40us-core.com; ip=2001%3A470%3A142%3A%3A17;
 r=debbugs.gnu.org]
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 0.0 UNPARSEABLE_RELAY      Informational: message has unparseable relay
 lines -0.0 T_SCC_BODY_TEXT_LINE   No description available.
X-Debbugs-Envelope-To: submit
Cc: Felix Lechner <felix.lechner@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)

* libguile/strings.c (scm_encoding_error): Decode errno.
---

Hi,

Even experienced users do not memorize errno values. [1][2] Why not
decode them as a courtesy?

Kind regards
Felix Lechner

[1] https://debbugs.gnu.org/62590
[2] https://debbugs.gnu.org/59510

libguile/strings.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libguile/strings.c b/libguile/strings.c
index 5eebb3300..ba69bd65e 100644
--- a/libguile/strings.c
+++ b/libguile/strings.c
@@ -1468,7 +1468,7 @@ scm_encoding_error (const char *subr, int err, const char *message,
   scm_throw (scm_encoding_error_key,
 	     scm_list_n (scm_from_latin1_string (subr),
 			 scm_from_latin1_string (message),
-			 scm_from_int (err),
+			 scm_strerror (err),
 			 port, chr,
 			 SCM_UNDEFINED));
 }

base-commit: d8df317bafcdd9fcfebb636433c4871f2fab28b2
-- 
2.41.0