GNU bug report logs - #68682
[PATCH] gnu: maths: arpack-ng: Modify build settings.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Romain GARBAGE <romain.garbage@HIDDEN>; Keywords: patch; dated Wed, 24 Jan 2024 08:49:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 68682 <at> debbugs.gnu.org:


Received: (at 68682) by debbugs.gnu.org; 11 Feb 2024 08:05:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 11 03:05:38 2024
Received: from localhost ([127.0.0.1]:57411 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rZ4qH-0003pd-RH
	for submit <at> debbugs.gnu.org; Sun, 11 Feb 2024 03:05:38 -0500
Received: from hera.aquilenet.fr ([2a0c:e300::1]:41868)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <andreas@HIDDEN>) id 1rZ4qF-0003pC-Gn
 for 68682 <at> debbugs.gnu.org; Sun, 11 Feb 2024 03:05:36 -0500
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 0D3D615F;
 Sun, 11 Feb 2024 08:55:16 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id MZRIGj3ju504; Sun, 11 Feb 2024 08:55:15 +0100 (CET)
Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 7234F112;
 Sun, 11 Feb 2024 08:55:15 +0100 (CET)
Date: Sun, 11 Feb 2024 08:55:13 +0100
From: Andreas Enge <andreas@HIDDEN>
To: Ludovic =?iso-8859-15?Q?Court=E8s?= <ludo@HIDDEN>
Subject: Re: [bug#68682] [PATCH v2 1/2] gnu: arpack-ng: Add preprocessor flag.
Message-ID: <Zch9YXUwmqr0qJbo@jurong>
References: <4284df7d0499bb5b6a46d29d6e7f858fd3baa896.1706085982.git.romain.garbage@HIDDEN>
 <829f35a88d7b87aa8656241f6fc847567e312a12.1706113729.git.andreas@HIDDEN>
 <87ttmggewd.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87ttmggewd.fsf@HIDDEN>
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68682
Cc: Romain GARBAGE <romain.garbage@HIDDEN>,
 Sharlatan Hellseher <sharlatanus@HIDDEN>, 68682 <at> debbugs.gnu.org,
 Eric Bavier <bavier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

Am Sat, Feb 10, 2024 at 10:58:42PM +0100 schrieb Ludovic CourtŤs:
> This seems to be mostly ready to push:
>   https://qa.guix.gnu.org/issue/68682

it has quite a few dependent packages, so I am waiting for QA to
handle it.

Andreas





Information forwarded to guix-patches@HIDDEN:
bug#68682; Package guix-patches. Full text available.

Message received at 68682 <at> debbugs.gnu.org:


Received: (at 68682) by debbugs.gnu.org; 10 Feb 2024 21:59:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 10 16:59:09 2024
Received: from localhost ([127.0.0.1]:44957 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rYvNN-0003ib-21
	for submit <at> debbugs.gnu.org; Sat, 10 Feb 2024 16:59:09 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:45170)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1rYvNK-0003hh-AV
 for 68682 <at> debbugs.gnu.org; Sat, 10 Feb 2024 16:59:06 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1rYvMy-0008Lm-Cv; Sat, 10 Feb 2024 16:58:44 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=80/MB26eOgOkQPx2542kWzxt55rWOwsktC6QDFcN5E4=; b=aSV3NklZPtjlnISooWm8
 cxAXcKe99NXTsmvj+MijWgnU+9K4CQUuM93tgdHBkiOkVRSL20u0yeudQmvA+rJzLP3ZAgVP4cYse
 4wjMfM6KOnVwUUN9FF53E/yQuqu22VRnww4UByRVpk0Jo1KnE2bTKFL0By9Ai6bEbPfdFN/lVR8Ge
 EZNWLDBQH61fnjR14PGoz1uSASM0yxEVTWeI1PVGlZ9p4OrlltLrbaekyfE5qEwOqEj3Aed+n3tqZ
 ot0Lxo50Eznrq3dFQdHEY9DuW1Us9pcMmO2n+UcwHqbMVy3xZtDzJm1qVwPwDCmC2SeJene/SsQfR
 w7FhKG3NBGUuOg==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Andreas Enge <andreas@HIDDEN>
Subject: Re: [bug#68682] [PATCH v2 1/2] gnu: arpack-ng: Add preprocessor flag.
In-Reply-To: <829f35a88d7b87aa8656241f6fc847567e312a12.1706113729.git.andreas@HIDDEN>
 (Andreas Enge's message of "Wed, 24 Jan 2024 17:28:48 +0100")
References: <4284df7d0499bb5b6a46d29d6e7f858fd3baa896.1706085982.git.romain.garbage@HIDDEN>
 <829f35a88d7b87aa8656241f6fc847567e312a12.1706113729.git.andreas@HIDDEN>
Date: Sat, 10 Feb 2024 22:58:42 +0100
Message-ID: <87ttmggewd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68682
Cc: Romain GARBAGE <romain.garbage@HIDDEN>,
 Sharlatan Hellseher <sharlatanus@HIDDEN>, 68682 <at> debbugs.gnu.org,
 Eric Bavier <bavier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Andreas Enge <andreas@HIDDEN> skribis:

> From: Romain GARBAGE <romain.garbage@HIDDEN>
>
> * gnu/packages/maths.scm (arpack-ng): Add configure flag for building
>   ISO C binding headers.
>
> Change-Id: Iddfd67094ffafc3cabd88353e3839e5e903b804a
> Signed-off-by: Andreas Enge <andreas@HIDDEN>

[...]

> * gnu/packages/maths.scm (arpack-ng): Update to 3.9.1. Drop patch.
> * gnu/packages/patches/arpack-ng-propagate-rng-state.patch: Remove file.
> * gnu/packages/maths.scm (dist_patch_DATA): Unregister patch.
>
> Change-Id: I33a666c3a88fb2f6791c8d698eeb054a831103fc

Hi Andreas!

This seems to be mostly ready to push:

  https://qa.guix.gnu.org/issue/68682

Ludo=E2=80=99.




Information forwarded to guix-patches@HIDDEN:
bug#68682; Package guix-patches. Full text available.

Message received at 68682 <at> debbugs.gnu.org:


Received: (at 68682) by debbugs.gnu.org; 24 Jan 2024 16:30:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 24 11:30:01 2024
Received: from localhost ([127.0.0.1]:46384 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rSg8V-0001kQ-LC
	for submit <at> debbugs.gnu.org; Wed, 24 Jan 2024 11:30:00 -0500
Received: from hera.aquilenet.fr ([2a0c:e300::1]:39260)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <andreas@HIDDEN>) id 1rSg8E-0001ja-SE
 for 68682 <at> debbugs.gnu.org; Wed, 24 Jan 2024 11:29:58 -0500
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 19EBE1029;
 Wed, 24 Jan 2024 17:29:32 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id Dm2b5TKnLVo1; Wed, 24 Jan 2024 17:29:30 +0100 (CET)
Received: from jurong.lan (unknown [IPv6:2001:861:c4:f2f0::c64])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 93A96319;
 Wed, 24 Jan 2024 17:29:30 +0100 (CET)
From: Andreas Enge <andreas@HIDDEN>
To: 68682 <at> debbugs.gnu.org
Subject: [PATCH v2 2/2] gnu: arpack-ng: Update to 3.9.1.
Date: Wed, 24 Jan 2024 17:28:49 +0100
Message-ID: <8a18b85223f30c3f7552804d420d43c8e936e017.1706113729.git.andreas@HIDDEN>
X-Mailer: git-send-email 2.41.0
In-Reply-To: <829f35a88d7b87aa8656241f6fc847567e312a12.1706113729.git.andreas@HIDDEN>
References: <829f35a88d7b87aa8656241f6fc847567e312a12.1706113729.git.andreas@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Andreas Enge <andreas@HIDDEN>, Eric Bavier <bavier@HIDDEN>,
 Sharlatan Hellseher <sharlatanus@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68682
Cc: Andreas Enge <andreas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/maths.scm (arpack-ng): Update to 3.9.1. Drop patch.
* gnu/packages/patches/arpack-ng-propagate-rng-state.patch: Remove file.
* gnu/packages/maths.scm (dist_patch_DATA): Unregister patch.

Change-Id: I33a666c3a88fb2f6791c8d698eeb054a831103fc
---
 gnu/local.mk                                  |   3 +-
 gnu/packages/maths.scm                        |   5 +-
 .../arpack-ng-propagate-rng-state.patch       | 523 ------------------
 3 files changed, 3 insertions(+), 528 deletions(-)
 delete mode 100644 gnu/packages/patches/arpack-ng-propagate-rng-state.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index c20e93390d..38a2d8d2e3 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1,6 +1,6 @@
 # GNU Guix --- Functional package management for GNU
 # Copyright © 2012-2024 Ludovic Courtès <ludo@HIDDEN>
-# Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2022, 2023 Andreas Enge <andreas@HIDDEN>
+# Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2022, 2023, 2024 Andreas Enge <andreas@HIDDEN>
 # Copyright © 2016 Mathieu Lirzin <mthl@HIDDEN>
 # Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021 Mark H Weaver <mhw@HIDDEN>
 # Copyright © 2016 Chris Marusich <cmmarusich@HIDDEN>
@@ -927,7 +927,6 @@ dist_patch_DATA =						\
   %D%/packages/patches/apr-skip-getservbyname-test.patch	\
   %D%/packages/patches/aria2-unbundle-wslay.patch		\
   %D%/packages/patches/ark-skip-xar-test.patch			\
-  %D%/packages/patches/arpack-ng-propagate-rng-state.patch	\
   %D%/packages/patches/asli-use-system-libs.patch		\
   %D%/packages/patches/aspell-CVE-2019-25051.patch		\
   %D%/packages/patches/aspell-default-dict-dir.patch		\
diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 16cd3454ae..a6a2f4aecb 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -1053,7 +1053,7 @@ (define-public vinci
 (define-public arpack-ng
   (package
     (name "arpack-ng")
-    (version "3.9.0")
+    (version "3.9.1")
     (home-page "https://github.com/opencollab/arpack-ng")
     (source (origin
               (method git-fetch)
@@ -1061,8 +1061,7 @@ (define-public arpack-ng
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "09smxilyn8v9xs3kpx3nlj2s7ql3v8z40mpc09kccbb6smyd35iv"))
-              (patches (search-patches "arpack-ng-propagate-rng-state.patch"))))
+                "0bbw6a48py9fjlif2n4x75skyjskq2hghffjqzm85wnsnsjdlaqw"))))
     (build-system cmake-build-system)
     (arguments
      '(#:configure-flags '("-DICB=ON")))
diff --git a/gnu/packages/patches/arpack-ng-propagate-rng-state.patch b/gnu/packages/patches/arpack-ng-propagate-rng-state.patch
deleted file mode 100644
index 4466bb8e50..0000000000
--- a/gnu/packages/patches/arpack-ng-propagate-rng-state.patch
+++ /dev/null
@@ -1,523 +0,0 @@
-Fix a bug that manifests while running the test suite of 'python-igraph':
-
-  https://github.com/opencollab/arpack-ng/issues/401
-  https://github.com/opencollab/arpack-ng/pull/414
-
-From d885b7be4ecdc9c1496f2d6f256f6c0d34962459 Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?Szabolcs=20Horva=CC=81t?= <szhorvat@HIDDEN>
-Date: Sun, 9 Apr 2023 16:36:35 +0200
-Subject: [PATCH] fix: ensure that LAPACK RNG state is propagated
-
- - fixes #401, #410, #411
- - restores 'inits' variable removed in ce2e69a849da1d10dad5d6d3ec4db6120b3ecf50, ensuring that the RNG state is propagated
- - reverts e0d67054f573da351f12a226f7c7cc65a690ef3d to ensure that seed is different on each parallel thread
- - updates seed initialization of parallel pdgetv0/psgetv0 so that they match that of pzgetv0/pcgetv0
----
- PARPACK/SRC/MPI/pcgetv0.f | 48 +++++++++++++++++++++++----------------
- PARPACK/SRC/MPI/pdgetv0.f | 40 ++++++++++++++++++++++++++------
- PARPACK/SRC/MPI/psgetv0.f | 43 ++++++++++++++++++++++++++---------
- PARPACK/SRC/MPI/pzgetv0.f | 48 +++++++++++++++++++++++----------------
- SRC/cgetv0.f              | 21 ++++++++++++-----
- SRC/dgetv0.f              | 21 ++++++++++++-----
- SRC/sgetv0.f              | 21 ++++++++++++-----
- SRC/zgetv0.f              | 21 ++++++++++++-----
- 8 files changed, 183 insertions(+), 80 deletions(-)
-
-diff --git a/PARPACK/SRC/MPI/pcgetv0.f b/PARPACK/SRC/MPI/pcgetv0.f
-index 59e3d1658..24fe8a0f1 100644
---- a/PARPACK/SRC/MPI/pcgetv0.f
-+++ b/PARPACK/SRC/MPI/pcgetv0.f
-@@ -176,13 +176,13 @@ subroutine pcgetv0
- c     | Local Scalars & Arrays |
- c     %------------------------%
- c
--      logical    first, orth
-+      logical    first, inits, orth
-       integer    idist, iseed(4), iter, msglvl, jj, myid, igen
-       Real
-      &           rnorm0
-       Complex
-      &           cnorm, cnorm2
--      save       first, iseed, iter, msglvl, orth, rnorm0
-+      save       first, iseed, inits, iter, msglvl, orth, rnorm0
- c
-       Complex
-      &           cnorm_buf, buf2(1)
-@@ -203,6 +203,12 @@ subroutine pcgetv0
-      &           ccdotc
-       external   ccdotc, pscnorm2, slapy2
- c
-+c     %-----------------%
-+c     | Data Statements |
-+c     %-----------------%
-+c
-+      data       inits /.true./
-+c
- c     %-----------------------%
- c     | Executable Statements |
- c     %-----------------------%
-@@ -213,26 +219,30 @@ subroutine pcgetv0
- c     | random number generator           |
- c     %-----------------------------------%
- c
-+      if (inits) then
- c
--c     %-----------------------------------%
--c     | Generate a seed on each processor |
--c     | using process id (myid).          |
--c     | Note: the seed must be between 1  |
--c     | and 4095.  iseed(4) must be odd.  |
--c     %-----------------------------------%
-+c        %-----------------------------------%
-+c        | Generate a seed on each processor |
-+c        | using process id (myid).          |
-+c        | Note: the seed must be between 1  |
-+c        | and 4095.  iseed(4) must be odd.  |
-+c        %-----------------------------------%
- c
--      call MPI_COMM_RANK(comm, myid, ierr)
--      igen = 1000 + 2*myid + 1
--      if (igen .gt. 4095) then
--         write(0,*) 'Error in p_getv0: seed exceeds 4095!'
--      end if
-+         call MPI_COMM_RANK(comm, myid, ierr)
-+         igen = 1000 + 2*myid + 1
-+         if (igen .gt. 4095) then
-+            write(0,*) 'Error in p_getv0: seed exceeds 4095!'
-+         end if
-+c
-+         iseed(1) = igen/1000
-+         igen     = mod(igen,1000)
-+         iseed(2) = igen/100
-+         igen     = mod(igen,100)
-+         iseed(3) = igen/10
-+         iseed(4) = mod(igen,10)
- c
--      iseed(1) = igen/1000
--      igen     = mod(igen,1000)
--      iseed(2) = igen/100
--      igen     = mod(igen,100)
--      iseed(3) = igen/10
--      iseed(4) = 7
-+         inits = .false.
-+      end if
- c
-       if (ido .eq.  0) then
- c
-diff --git a/PARPACK/SRC/MPI/pdgetv0.f b/PARPACK/SRC/MPI/pdgetv0.f
-index 0f348b820..5a1956997 100644
---- a/PARPACK/SRC/MPI/pdgetv0.f
-+++ b/PARPACK/SRC/MPI/pdgetv0.f
-@@ -177,11 +177,11 @@ subroutine pdgetv0
- c     | Local Scalars & Arrays |
- c     %------------------------%
- c
--      logical    first, orth
--      integer    idist, iseed(4), iter, msglvl, jj
-+      logical    first, inits, orth
-+      integer    idist, iseed(4), iter, msglvl, jj, myid, igen
-       Double precision
-      &           rnorm0, buf2(1)
--      save       first, iseed, iter, msglvl, orth, rnorm0
-+      save       first, iseed, inits, iter, msglvl, orth, rnorm0
- c
-       Double precision
-      &           rnorm_buf
-@@ -206,6 +206,12 @@ subroutine pdgetv0
- c
-       intrinsic    abs, sqrt
- c
-+c     %-----------------%
-+c     | Data Statements |
-+c     %-----------------%
-+c
-+      data       inits /.true./
-+c
- c     %-----------------------%
- c     | Executable Statements |
- c     %-----------------------%
-@@ -216,10 +222,30 @@ subroutine pdgetv0
- c     | random number generator           |
- c     %-----------------------------------%
- c
--      iseed(1) = 1
--      iseed(2) = 3
--      iseed(3) = 5
--      iseed(4) = 7
-+      if (inits) then
-+c
-+c        %-----------------------------------%
-+c        | Generate a seed on each processor |
-+c        | using process id (myid).          |
-+c        | Note: the seed must be between 1  |
-+c        | and 4095.  iseed(4) must be odd.  |
-+c        %-----------------------------------%
-+c
-+         call MPI_COMM_RANK(comm, myid, ierr)
-+         igen = 1000 + 2*myid + 1
-+         if (igen .gt. 4095) then
-+            write(0,*) 'Error in p_getv0: seed exceeds 4095!'
-+         end if
-+c
-+         iseed(1) = igen/1000
-+         igen     = mod(igen,1000)
-+         iseed(2) = igen/100
-+         igen     = mod(igen,100)
-+         iseed(3) = igen/10
-+         iseed(4) = mod(igen,10)
-+c
-+         inits = .false.
-+      end if
- c
-       if (ido .eq.  0) then
- c
-diff --git a/PARPACK/SRC/MPI/psgetv0.f b/PARPACK/SRC/MPI/psgetv0.f
-index d79a513b2..078e4fa8c 100644
---- a/PARPACK/SRC/MPI/psgetv0.f
-+++ b/PARPACK/SRC/MPI/psgetv0.f
-@@ -177,11 +177,11 @@ subroutine psgetv0
- c     | Local Scalars & Arrays |
- c     %------------------------%
- c
--      logical    first, orth
--      integer    idist, iseed(4), iter, msglvl, jj
-+      logical    first, inits, orth
-+      integer    idist, iseed(4), iter, msglvl, jj, myid, igen
-       Real
-      &           rnorm0
--      save       first, iseed, iter, msglvl, orth, rnorm0
-+      save       first, iseed, inits, iter, msglvl, orth, rnorm0
- c
-       Real
-      &           rnorm_buf
-@@ -206,20 +206,41 @@ subroutine psgetv0
- c
-       intrinsic    abs, sqrt
- c
-+c     %-----------------%
-+c     | Data Statements |
-+c     %-----------------%
-+c
-+      data       inits /.true./
-+c
- c     %-----------------------%
- c     | Executable Statements |
- c     %-----------------------%
- c
- c
--c     %-----------------------------------%
--c     | Initialize the seed of the LAPACK |
--c     | random number generator           |
--c     %-----------------------------------%
-+      if (inits) then
- c
--      iseed(1) = 1
--      iseed(2) = 3
--      iseed(3) = 5
--      iseed(4) = 7
-+c        %-----------------------------------%
-+c        | Generate a seed on each processor |
-+c        | using process id (myid).          |
-+c        | Note: the seed must be between 1  |
-+c        | and 4095.  iseed(4) must be odd.  |
-+c        %-----------------------------------%
-+c
-+         call MPI_COMM_RANK(comm, myid, ierr)
-+         igen = 1000 + 2*myid + 1
-+         if (igen .gt. 4095) then
-+            write(0,*) 'Error in p_getv0: seed exceeds 4095!'
-+         end if
-+c
-+         iseed(1) = igen/1000
-+         igen     = mod(igen,1000)
-+         iseed(2) = igen/100
-+         igen     = mod(igen,100)
-+         iseed(3) = igen/10
-+         iseed(4) = mod(igen,10)
-+c
-+         inits = .false.
-+      end if
- c
-       if (ido .eq.  0) then
- c
-diff --git a/PARPACK/SRC/MPI/pzgetv0.f b/PARPACK/SRC/MPI/pzgetv0.f
-index 731fb319f..94fb705f3 100644
---- a/PARPACK/SRC/MPI/pzgetv0.f
-+++ b/PARPACK/SRC/MPI/pzgetv0.f
-@@ -176,13 +176,13 @@ subroutine pzgetv0
- c     | Local Scalars & Arrays |
- c     %------------------------%
- c
--      logical    first, orth
-+      logical    first, inits, orth
-       integer    idist, iseed(4), iter, msglvl, jj, myid, igen
-       Double precision
-      &           rnorm0
-       Complex*16
-      &           cnorm, cnorm2
--      save       first, iseed, iter, msglvl, orth, rnorm0
-+      save       first, iseed, inits, iter, msglvl, orth, rnorm0
- c
-       Complex*16
-      &           cnorm_buf, buf2(1)
-@@ -203,6 +203,12 @@ subroutine pzgetv0
-      &           zzdotc
-       external   zzdotc , pdznorm2 , dlapy2
- c
-+c     %-----------------%
-+c     | Data Statements |
-+c     %-----------------%
-+c
-+      data       inits /.true./
-+c
- c     %-----------------------%
- c     | Executable Statements |
- c     %-----------------------%
-@@ -213,26 +219,30 @@ subroutine pzgetv0
- c     | random number generator           |
- c     %-----------------------------------%
- c
-+      if (inits) then
- c
--c     %-----------------------------------%
--c     | Generate a seed on each processor |
--c     | using process id (myid).          |
--c     | Note: the seed must be between 1  |
--c     | and 4095.  iseed(4) must be odd.  |
--c     %-----------------------------------%
-+c        %-----------------------------------%
-+c        | Generate a seed on each processor |
-+c        | using process id (myid).          |
-+c        | Note: the seed must be between 1  |
-+c        | and 4095.  iseed(4) must be odd.  |
-+c        %-----------------------------------%
- c
--      call MPI_COMM_RANK(comm, myid, ierr)
--      igen = 1000 + 2*myid + 1
--      if (igen .gt. 4095) then
--         write(0,*) 'Error in p_getv0: seed exceeds 4095!'
--      end if
-+         call MPI_COMM_RANK(comm, myid, ierr)
-+         igen = 1000 + 2*myid + 1
-+         if (igen .gt. 4095) then
-+            write(0,*) 'Error in p_getv0: seed exceeds 4095!'
-+         end if
-+c
-+         iseed(1) = igen/1000
-+         igen     = mod(igen,1000)
-+         iseed(2) = igen/100
-+         igen     = mod(igen,100)
-+         iseed(3) = igen/10
-+         iseed(4) = mod(igen,10)
- c
--      iseed(1) = igen/1000
--      igen     = mod(igen,1000)
--      iseed(2) = igen/100
--      igen     = mod(igen,100)
--      iseed(3) = igen/10
--      iseed(4) = 7
-+         inits = .false.
-+      end if
- c
-       if (ido .eq.  0) then
- c
-diff --git a/SRC/cgetv0.f b/SRC/cgetv0.f
-index b49e66708..c231eadcb 100644
---- a/SRC/cgetv0.f
-+++ b/SRC/cgetv0.f
-@@ -156,13 +156,13 @@ subroutine cgetv0
- c     | Local Scalars & Arrays |
- c     %------------------------%
- c
--      logical    first, orth
-+      logical    first, inits, orth
-       integer    idist, iseed(4), iter, msglvl, jj
-       Real
-      &           rnorm0
-       Complex
-      &           cnorm
--      save       first, iseed, iter, msglvl, orth, rnorm0
-+      save       first, iseed, inits, iter, msglvl, orth, rnorm0
- c
- c     %----------------------%
- c     | External Subroutines |
-@@ -180,6 +180,12 @@ subroutine cgetv0
-      &           ccdotc
-       external   ccdotc, scnrm2, slapy2
- c
-+c     %-----------------%
-+c     | Data Statements |
-+c     %-----------------%
-+c
-+      data       inits /.true./
-+c
- c     %-----------------------%
- c     | Executable Statements |
- c     %-----------------------%
-@@ -190,10 +196,13 @@ subroutine cgetv0
- c     | random number generator           |
- c     %-----------------------------------%
- c
--      iseed(1) = 1
--      iseed(2) = 3
--      iseed(3) = 5
--      iseed(4) = 7
-+      if (inits) then
-+          iseed(1) = 1
-+          iseed(2) = 3
-+          iseed(3) = 5
-+          iseed(4) = 7
-+          inits = .false.
-+      end if
- c
-       if (ido .eq.  0) then
- c
-diff --git a/SRC/dgetv0.f b/SRC/dgetv0.f
-index 8be4fa26d..1d6dc01bd 100644
---- a/SRC/dgetv0.f
-+++ b/SRC/dgetv0.f
-@@ -157,11 +157,11 @@ subroutine dgetv0
- c     | Local Scalars & Arrays |
- c     %------------------------%
- c
--      logical    first, orth
-+      logical    first, inits, orth
-       integer    idist, iseed(4), iter, msglvl, jj
-       Double precision
-      &           rnorm0
--      save       first, iseed, iter, msglvl, orth, rnorm0
-+      save       first, iseed, inits, iter, msglvl, orth, rnorm0
- c
- c     %----------------------%
- c     | External Subroutines |
-@@ -183,6 +183,12 @@ subroutine dgetv0
- c
-       intrinsic    abs, sqrt
- c
-+c     %-----------------%
-+c     | Data Statements |
-+c     %-----------------%
-+c
-+      data       inits /.true./
-+c
- c     %-----------------------%
- c     | Executable Statements |
- c     %-----------------------%
-@@ -193,10 +199,13 @@ subroutine dgetv0
- c     | random number generator           |
- c     %-----------------------------------%
- c
--      iseed(1) = 1
--      iseed(2) = 3
--      iseed(3) = 5
--      iseed(4) = 7
-+      if (inits) then
-+          iseed(1) = 1
-+          iseed(2) = 3
-+          iseed(3) = 5
-+          iseed(4) = 7
-+          inits = .false.
-+      end if
- c
-       if (ido .eq.  0) then
- c
-diff --git a/SRC/sgetv0.f b/SRC/sgetv0.f
-index 26130a014..d861b2d6d 100644
---- a/SRC/sgetv0.f
-+++ b/SRC/sgetv0.f
-@@ -157,11 +157,11 @@ subroutine sgetv0
- c     | Local Scalars & Arrays |
- c     %------------------------%
- c
--      logical    first, orth
-+      logical    first, inits, orth
-       integer    idist, iseed(4), iter, msglvl, jj
-       Real
-      &           rnorm0
--      save       first, iseed, iter, msglvl, orth, rnorm0
-+      save       first, iseed, inits, iter, msglvl, orth, rnorm0
- c
- c     %----------------------%
- c     | External Subroutines |
-@@ -183,6 +183,12 @@ subroutine sgetv0
- c
-       intrinsic    abs, sqrt
- c
-+c     %-----------------%
-+c     | Data Statements |
-+c     %-----------------%
-+c
-+      data       inits /.true./
-+c
- c     %-----------------------%
- c     | Executable Statements |
- c     %-----------------------%
-@@ -193,10 +199,13 @@ subroutine sgetv0
- c     | random number generator           |
- c     %-----------------------------------%
- c
--      iseed(1) = 1
--      iseed(2) = 3
--      iseed(3) = 5
--      iseed(4) = 7
-+      if (inits) then
-+          iseed(1) = 1
-+          iseed(2) = 3
-+          iseed(3) = 5
-+          iseed(4) = 7
-+          inits = .false.
-+      end if
- c
-       if (ido .eq.  0) then
- c
-diff --git a/SRC/zgetv0.f b/SRC/zgetv0.f
-index cc13c3cfb..1fbd50851 100644
---- a/SRC/zgetv0.f
-+++ b/SRC/zgetv0.f
-@@ -156,13 +156,13 @@ subroutine zgetv0
- c     | Local Scalars & Arrays |
- c     %------------------------%
- c
--      logical    first, orth
-+      logical    first, inits, orth
-       integer    idist, iseed(4), iter, msglvl, jj
-       Double precision
-      &           rnorm0
-       Complex*16
-      &           cnorm
--      save       first, iseed, iter, msglvl, orth, rnorm0
-+      save       first, iseed, inits, iter, msglvl, orth, rnorm0
- c
- c     %----------------------%
- c     | External Subroutines |
-@@ -180,6 +180,12 @@ subroutine zgetv0
-      &           zzdotc
-       external   zzdotc, dznrm2, dlapy2
- c
-+c     %-----------------%
-+c     | Data Statements |
-+c     %-----------------%
-+c
-+      data       inits /.true./
-+c
- c     %-----------------------%
- c     | Executable Statements |
- c     %-----------------------%
-@@ -190,10 +196,13 @@ subroutine zgetv0
- c     | random number generator           |
- c     %-----------------------------------%
- c
--      iseed(1) = 1
--      iseed(2) = 3
--      iseed(3) = 5
--      iseed(4) = 7
-+      if (inits) then
-+          iseed(1) = 1
-+          iseed(2) = 3
-+          iseed(3) = 5
-+          iseed(4) = 7
-+          inits = .false.
-+      end if
- c
-       if (ido .eq.  0) then
- c
-- 
2.41.0





Information forwarded to andreas@HIDDEN, bavier@HIDDEN, sharlatanus@HIDDEN, guix-patches@HIDDEN:
bug#68682; Package guix-patches. Full text available.

Message received at 68682 <at> debbugs.gnu.org:


Received: (at 68682) by debbugs.gnu.org; 24 Jan 2024 16:29:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 24 11:29:46 2024
Received: from localhost ([127.0.0.1]:46382 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rSg8G-0001jo-6e
	for submit <at> debbugs.gnu.org; Wed, 24 Jan 2024 11:29:46 -0500
Received: from hera.aquilenet.fr ([2a0c:e300::1]:35130)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <andreas@HIDDEN>) id 1rSg8C-0001jV-3a
 for 68682 <at> debbugs.gnu.org; Wed, 24 Jan 2024 11:29:41 -0500
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 3BB151028;
 Wed, 24 Jan 2024 17:29:28 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id ELHopnlyBx3d; Wed, 24 Jan 2024 17:29:27 +0100 (CET)
Received: from jurong.lan (unknown [IPv6:2001:861:c4:f2f0::c64])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id B41C7319;
 Wed, 24 Jan 2024 17:29:27 +0100 (CET)
From: Andreas Enge <andreas@HIDDEN>
To: 68682 <at> debbugs.gnu.org
Subject: [PATCH v2 1/2] gnu: arpack-ng: Add preprocessor flag.
Date: Wed, 24 Jan 2024 17:28:48 +0100
Message-ID: <829f35a88d7b87aa8656241f6fc847567e312a12.1706113729.git.andreas@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
X-Debbugs-Cc: Andreas Enge <andreas@HIDDEN>, Eric Bavier <bavier@HIDDEN>,
 Sharlatan Hellseher <sharlatanus@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68682
Cc: Andreas Enge <andreas@HIDDEN>, Romain GARBAGE <romain.garbage@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

From: Romain GARBAGE <romain.garbage@HIDDEN>

* gnu/packages/maths.scm (arpack-ng): Add configure flag for building
  ISO C binding headers.

Change-Id: Iddfd67094ffafc3cabd88353e3839e5e903b804a
Signed-off-by: Andreas Enge <andreas@HIDDEN>
---
 gnu/packages/maths.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index ada828cb3f..16cd3454ae 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -1064,6 +1064,8 @@ (define-public arpack-ng
                 "09smxilyn8v9xs3kpx3nlj2s7ql3v8z40mpc09kccbb6smyd35iv"))
               (patches (search-patches "arpack-ng-propagate-rng-state.patch"))))
     (build-system cmake-build-system)
+    (arguments
+     '(#:configure-flags '("-DICB=ON")))
     (native-inputs
      (list pkg-config))
     (inputs

base-commit: 2c5faa9ab88a2b6415bfb1ddbcdc9f8eb9c88d74
-- 
2.41.0





Information forwarded to andreas@HIDDEN, bavier@HIDDEN, sharlatanus@HIDDEN, guix-patches@HIDDEN:
bug#68682; Package guix-patches. Full text available.

Message received at 68682 <at> debbugs.gnu.org:


Received: (at 68682) by debbugs.gnu.org; 24 Jan 2024 16:22:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 24 11:22:06 2024
Received: from localhost ([127.0.0.1]:46376 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rSg0s-0001YO-7q
	for submit <at> debbugs.gnu.org; Wed, 24 Jan 2024 11:22:06 -0500
Received: from hera.aquilenet.fr ([2a0c:e300::1]:48422)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <andreas@HIDDEN>) id 1rSg0q-0001Xs-CF
 for 68682 <at> debbugs.gnu.org; Wed, 24 Jan 2024 11:22:05 -0500
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 313AC3C9;
 Wed, 24 Jan 2024 17:21:51 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id aAtAZyF01Xe3; Wed, 24 Jan 2024 17:21:50 +0100 (CET)
Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 90DF0319;
 Wed, 24 Jan 2024 17:21:50 +0100 (CET)
Date: Wed, 24 Jan 2024 17:21:49 +0100
From: Andreas Enge <andreas@HIDDEN>
To: Romain Garbage <romain.garbage@HIDDEN>
Subject: Re: [bug#68682] [PATCH] gnu: maths: arpack-ng: Modify build settings.
Message-ID: <ZbE5Hd-z3uVmuube@jurong>
References: <4284df7d0499bb5b6a46d29d6e7f858fd3baa896.1706085982.git.romain.garbage@HIDDEN>
 <ZbEY9eCjz3yOfJd6@jurong> <878r4evl6f.fsf@HIDDEN>
 <971019240.17863501.1706112290823.JavaMail.zimbra@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <971019240.17863501.1706112290823.JavaMail.zimbra@HIDDEN>
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68682
Cc: Ludovic Courtes <ludovic.courtes@HIDDEN>,
 Sharlatan Hellseher <sharlatanus@HIDDEN>, 68682 <at> debbugs.gnu.org,
 Efraim Flashner <efraim@HIDDEN>, Eric Bavier <bavier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Am Wed, Jan 24, 2024 at 05:04:50PM +0100 schrieb Romain Garbage:
> To me, it doesn't seem that the '-DBUILD_SHARED_LIBS=ON' option is necessary, but I might miss something.
> What do you think?

I agree it is not necessary; in Changes concerning arpack-ng 3.8.0:
 * Only build shared libraries by default.  To build static libraries, use
   --enable-static (autotools) or -DBUILD_SHARED_LIBS=OFF (cmake).

I will send a modified patch to this bug, and although I think this change
is completely harmless, I would suggest to let QA build the dependent
packages before applying it.

Andreas





Information forwarded to guix-patches@HIDDEN:
bug#68682; Package guix-patches. Full text available.

Message received at 68682 <at> debbugs.gnu.org:


Received: (at 68682) by debbugs.gnu.org; 24 Jan 2024 16:05:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 24 11:05:05 2024
Received: from localhost ([127.0.0.1]:46350 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rSfkP-00011G-9m
	for submit <at> debbugs.gnu.org; Wed, 24 Jan 2024 11:05:05 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:11984)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <romain.garbage@HIDDEN>) id 1rSfkM-00010c-Oy
 for 68682 <at> debbugs.gnu.org; Wed, 24 Jan 2024 11:05:04 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc;
 h=date:from:to:cc:message-id:in-reply-to:references:
 subject:mime-version:content-transfer-encoding;
 bh=95gB6eANIskK2+/o1ik4ZmwEz493Wkr79WVQpYFkn0I=;
 b=PWhfMiSDPzWOEpiaVJe6Fn5/lta1gZnuEmuu7j48ezw/77DCHZ7Wr48g
 OuT/1wJdMKvKo6/bmHRs9gCdAzJC3yA11Taj6DYNS9JTWZnEaSTvV4Qw+
 YXd6e0rB2ElMvD+JevC56YbimAgynQxOotWubGKytLVGe3U03mS63bTE7 E=;
Authentication-Results: mail2-relais-roc.national.inria.fr;
 dkim=none (message not signed) header.i=none;
 spf=Pass smtp.mailfrom=romain.garbage@HIDDEN;
 spf=None smtp.helo=postmaster@HIDDEN
Received-SPF: Pass (mail2-relais-roc.national.inria.fr: domain of
 romain.garbage@HIDDEN designates 128.93.142.32 as permitted
 sender) identity=mailfrom; client-ip=128.93.142.32;
 receiver=mail2-relais-roc.national.inria.fr;
 envelope-from="romain.garbage@HIDDEN";
 x-sender="romain.garbage@HIDDEN"; x-conformance=spf_only;
 x-record-type="v=spf1"; x-record-text="v=spf1
 include:mailout.safebrands.com a:basic-mail.safebrands.com
 a:basic-mail01.safebrands.com a:basic-mail02.safebrands.com
 ip4:128.93.142.0/24 ip4:192.134.164.0/24 ip4:128.93.162.160
 ip4:89.107.174.7 mx ~all"
Received-SPF: None (mail2-relais-roc.national.inria.fr: no sender
 authenticity information available from domain of
 postmaster@HIDDEN) identity=helo;
 client-ip=128.93.142.32;
 receiver=mail2-relais-roc.national.inria.fr;
 envelope-from="romain.garbage@HIDDEN";
 x-sender="postmaster@HIDDEN"; x-conformance=spf_only
X-IronPort-AV: E=Sophos;i="6.05,216,1701126000"; d="scan'208";a="148437392"
X-MGA-submission: =?us-ascii?q?MDHSJLzTgb2KJTaRNNct4P3tnT319mZD0R3CCC?=
 =?us-ascii?q?aTm6M02/+FBCG0PnXjS8+H9tvGeZrzInmxZoUwlsVq1FZftjzd/2HnhV?=
 =?us-ascii?q?3kJD3Du7l9THWzhPAHI6zQu0djdEcxp3t5JM1ABc58A9otkwZIQBR99a?=
 =?us-ascii?q?EC19l2cp95aUcJmynCtAi9+g=3D=3D?=
Received: from zcs-store5.inria.fr ([128.93.142.32])
 by mail2-relais-roc.national.inria.fr with ESMTP; 24 Jan 2024 17:04:51 +0100
Date: Wed, 24 Jan 2024 17:04:50 +0100 (CET)
From: Romain Garbage <romain.garbage@HIDDEN>
To: Ludovic Courtes <ludovic.courtes@HIDDEN>
Message-ID: <971019240.17863501.1706112290823.JavaMail.zimbra@HIDDEN>
In-Reply-To: <878r4evl6f.fsf@HIDDEN>
References: <4284df7d0499bb5b6a46d29d6e7f858fd3baa896.1706085982.git.romain.garbage@HIDDEN>
 <ZbEY9eCjz3yOfJd6@jurong> <878r4evl6f.fsf@HIDDEN>
Subject: Re: [bug#68682] [PATCH] gnu: maths: arpack-ng: Modify build settings.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Originating-IP: [193.50.110.153]
X-Mailer: Zimbra 8.8.15_GA_4581 (ZimbraWebClient - FF115
 (Linux)/8.8.15_GA_4581)
Thread-Topic: maths: arpack-ng: Modify build settings.
Thread-Index: 1JwDey5/7j6KSo5azVRjT/Z8LnfKXA==
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: 68682
Cc: Andreas Enge <andreas@HIDDEN>, Sharlatan Hellseher <sharlatanus@HIDDEN>,
 68682 <at> debbugs.gnu.org, Efraim Flashner <efraim@HIDDEN>,
 Eric Bavier <bavier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Hello :)

----- Mail original -----
> De: "Ludovic Courtes" <ludovic.courtes@HIDDEN>
> =C3=80: "Andreas Enge" <andreas@HIDDEN>
> Cc: "Romain Garbage" <romain.garbage@HIDDEN>, "Eric Bavier" <bavier@pos=
teo.net>, "Sharlatan Hellseher"
> <sharlatanus@HIDDEN>, 68682 <at> debbugs.gnu.org, "Efraim Flashner" <efraim=
@flashner.co.il>
> Envoy=C3=A9: Mercredi 24 Janvier 2024 14:51:52
> Objet: Re: [bug#68682] [PATCH] gnu: maths: arpack-ng: Modify build settin=
gs.

> Hi!  :-)
>=20
> Andreas Enge <andreas@HIDDEN> skribis:
>=20
>> I see that the ISO C binding flag installs additional headers, but I do =
not
>> see why the flag for building shared libraries would be needed. In the c=
urrent
>> arpack-ng, there is already a shared library in the lib/ subdirectory.
>>
>> Could you explain how adding the flag makes a difference?
>=20
> The goal should be to build shared libraries only.  If that=E2=80=99s alr=
eady
> happening without passing =E2=80=98-DBUILD_SHARED_LIBS=3DON=E2=80=99, I a=
gree we can drop
> it, in an effort to keep the package definition minimal.
>=20
> Romain, could you confirm that =E2=80=98-DBUILD_SHARED_LIBS=3DON=E2=80=99=
 is indeed
> unnecessary and send a new version without it if it is?

I built the package with and without '-DBUILD_SHARED_LIBS=3DON' and compare=
d the outputs:
```
$ diff -r /gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0 /gnu/=
store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack-ng-3.9.0
Binary files /gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0/li=
b/libarpack.so and /gnu/store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack-ng-3.=
9.0/lib/libarpack.so differ
Binary files /gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0/li=
b/libarpack.so.2 and /gnu/store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack-ng-=
3.9.0/lib/libarpack.so.2 differ
Binary files /gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0/li=
b/libarpack.so.2.1.0 and /gnu/store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack=
-ng-3.9.0/lib/libarpack.so.2.1.0 differ
diff -r /gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0/lib/pkg=
config/arpack.pc /gnu/store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack-ng-3.9.=
0/lib/pkgconfig/arpack.pc
1c1
< prefix=3D/gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0
---
> prefix=3D/gnu/store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack-ng-3.9.0
3,4c3,4
< libdir=3D/gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0/lib
< includedir=3D/gnu/store/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng-3.9.0/=
include/arpack-ng
---
> libdir=3D/gnu/store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack-ng-3.9.0/lib
> includedir=3D/gnu/store/5hbj4pza16d0vbmam0rmyx5h6z50fgqi-arpack-ng-3.9.0/=
include/arpack-ng

$  diff -u /tmp/*arpack-ng # these files contain the output of 'ldd /gnu/st=
ore/*arpack-ng/lib/libarpack.so'
+++ /tmp/wsx55w6bbak6sa3g6c8lwm3bliipkhy1-arpack-ng=092024-01-24 16:53:44.8=
05910227 +0100
@@ -1,9 +1,9 @@
-=09linux-vdso.so.1 (0x00007ffe84d4b000)
-=09libblas.so.3 =3D> /gnu/store/p34bwhh7lb9lsa8vd5w7bs5v599iayag-lapack-3.=
9.0/lib/libblas.so.3 (0x00007f9208982000)
-=09liblapack.so.3 =3D> /gnu/store/p34bwhh7lb9lsa8vd5w7bs5v599iayag-lapack-=
3.9.0/lib/liblapack.so.3 (0x00007f9208200000)
-=09libgfortran.so.5 =3D> /gnu/store/ldkp6a8cpl35vfs8bgnirhw12f76q414-gfort=
ran-11.3.0-lib/lib/libgfortran.so.5 (0x00007f9207e00000)
-=09libm.so.6 =3D> /gnu/store/ln6hxqjvz6m9gdd9s97pivlqck7hzs99-glibc-2.35/l=
ib/libm.so.6 (0x00007f92088a5000)
-=09libgcc_s.so.1 =3D> /gnu/store/ldkp6a8cpl35vfs8bgnirhw12f76q414-gfortran=
-11.3.0-lib/lib/libgcc_s.so.1 (0x00007f92081e6000)
-=09libquadmath.so.0 =3D> /gnu/store/ldkp6a8cpl35vfs8bgnirhw12f76q414-gfort=
ran-11.3.0-lib/lib/libquadmath.so.0 (0x00007f920819d000)
-=09libc.so.6 =3D> /gnu/store/ln6hxqjvz6m9gdd9s97pivlqck7hzs99-glibc-2.35/l=
ib/libc.so.6 (0x00007f9207c04000)
-=09/gnu/store/ln6hxqjvz6m9gdd9s97pivlqck7hzs99-glibc-2.35/lib/ld-linux-x86=
-64.so.2 (0x00007f9208a22000)
+=09linux-vdso.so.1 (0x00007ffdb2fb5000)
+=09libblas.so.3 =3D> /gnu/store/p34bwhh7lb9lsa8vd5w7bs5v599iayag-lapack-3.=
9.0/lib/libblas.so.3 (0x00007f0e9f582000)
+=09liblapack.so.3 =3D> /gnu/store/p34bwhh7lb9lsa8vd5w7bs5v599iayag-lapack-=
3.9.0/lib/liblapack.so.3 (0x00007f0e9ee00000)
+=09libgfortran.so.5 =3D> /gnu/store/ldkp6a8cpl35vfs8bgnirhw12f76q414-gfort=
ran-11.3.0-lib/lib/libgfortran.so.5 (0x00007f0e9ea00000)
+=09libm.so.6 =3D> /gnu/store/ln6hxqjvz6m9gdd9s97pivlqck7hzs99-glibc-2.35/l=
ib/libm.so.6 (0x00007f0e9f4a5000)
+=09libgcc_s.so.1 =3D> /gnu/store/ldkp6a8cpl35vfs8bgnirhw12f76q414-gfortran=
-11.3.0-lib/lib/libgcc_s.so.1 (0x00007f0e9ede6000)
+=09libquadmath.so.0 =3D> /gnu/store/ldkp6a8cpl35vfs8bgnirhw12f76q414-gfort=
ran-11.3.0-lib/lib/libquadmath.so.0 (0x00007f0e9ed9d000)
+=09libc.so.6 =3D> /gnu/store/ln6hxqjvz6m9gdd9s97pivlqck7hzs99-glibc-2.35/l=
ib/libc.so.6 (0x00007f0e9e804000)
+=09/gnu/store/ln6hxqjvz6m9gdd9s97pivlqck7hzs99-glibc-2.35/lib/ld-linux-x86=
-64.so.2 (0x00007f0e9f622000)
```

To me, it doesn't seem that the '-DBUILD_SHARED_LIBS=3DON' option is necess=
ary, but I might miss something.

What do you think?

Cheers,
Romain




Information forwarded to guix-patches@HIDDEN:
bug#68682; Package guix-patches. Full text available.

Message received at 68682 <at> debbugs.gnu.org:


Received: (at 68682) by debbugs.gnu.org; 24 Jan 2024 14:52:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 24 09:52:11 2024
Received: from localhost ([127.0.0.1]:44850 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rSebq-0001c9-Ue
	for submit <at> debbugs.gnu.org; Wed, 24 Jan 2024 09:52:11 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:18965)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludovic.courtes@HIDDEN>) id 1rSebm-0001bb-0t
 for 68682 <at> debbugs.gnu.org; Wed, 24 Jan 2024 09:52:10 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc;
 h=from:to:cc:subject:in-reply-to:references:date:
 message-id:mime-version:content-transfer-encoding;
 bh=qMZIAei0sVG1tJdPaIvfUUdWCzo5jhJQ4T0jYqHdXVk=;
 b=cB2LDOZXO97DUB6v+4lfz5S0xGWQv1qp+ebqJCH63d4u/CSq3x20sYcO
 HQ0xHCTZxrenlt5aHiJhcs0N1FyvWRmC5TrRKWXWStsQRdmJMLeoT4EQj
 ItW6wvpm0mTWWoPb6cprQxEJUMKjWVtLfqgz/zEvcLVopomjbwcRKPben 4=;
Authentication-Results: mail2-relais-roc.national.inria.fr;
 dkim=none (message not signed) header.i=none;
 spf=SoftFail smtp.mailfrom=ludovic.courtes@HIDDEN;
 dmarc=fail (p=none dis=none) d=inria.fr
X-IronPort-AV: E=Sophos;i="6.05,216,1701126000"; d="scan'208";a="148420230"
Received: from 91-160-117-201.subs.proxad.net (HELO ribbon) ([91.160.117.201])
 by mail2-relais-roc.national.inria.fr with
 ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2024 15:51:53 +0100
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludovic.courtes@HIDDEN>
To: Andreas Enge <andreas@HIDDEN>
Subject: Re: [bug#68682] [PATCH] gnu: maths: arpack-ng: Modify build settings.
In-Reply-To: <ZbEY9eCjz3yOfJd6@jurong> (Andreas Enge's message of "Wed, 24 Jan
 2024 15:04:37 +0100")
References: <4284df7d0499bb5b6a46d29d6e7f858fd3baa896.1706085982.git.romain.garbage@HIDDEN>
 <ZbEY9eCjz3yOfJd6@jurong>
Date: Wed, 24 Jan 2024 15:51:52 +0100
Message-ID: <878r4evl6f.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 68682
Cc: Romain GARBAGE <romain.garbage@HIDDEN>,
 Sharlatan Hellseher <sharlatanus@HIDDEN>, 68682 <at> debbugs.gnu.org,
 Efraim Flashner <efraim@HIDDEN>, Eric Bavier <bavier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi!  :-)

Andreas Enge <andreas@HIDDEN> skribis:

> I see that the ISO C binding flag installs additional headers, but I do n=
ot
> see why the flag for building shared libraries would be needed. In the cu=
rrent
> arpack-ng, there is already a shared library in the lib/ subdirectory.
>
> Could you explain how adding the flag makes a difference?

The goal should be to build shared libraries only.  If that=E2=80=99s alrea=
dy
happening without passing =E2=80=98-DBUILD_SHARED_LIBS=3DON=E2=80=99, I agr=
ee we can drop
it, in an effort to keep the package definition minimal.

Romain, could you confirm that =E2=80=98-DBUILD_SHARED_LIBS=3DON=E2=80=99 i=
s indeed
unnecessary and send a new version without it if it is?

Thanks,
Ludo=E2=80=99.




Information forwarded to guix-patches@HIDDEN:
bug#68682; Package guix-patches. Full text available.

Message received at 68682 <at> debbugs.gnu.org:


Received: (at 68682) by debbugs.gnu.org; 24 Jan 2024 14:08:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 24 09:08:18 2024
Received: from localhost ([127.0.0.1]:44796 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rSdvN-0000QR-Mc
	for submit <at> debbugs.gnu.org; Wed, 24 Jan 2024 09:08:17 -0500
Received: from hera.aquilenet.fr ([2a0c:e300::1]:59960)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <andreas@HIDDEN>) id 1rSdvL-0000QB-MH
 for 68682 <at> debbugs.gnu.org; Wed, 24 Jan 2024 09:08:16 -0500
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id F3286101A;
 Wed, 24 Jan 2024 15:08:01 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id axqByAewHVcw; Wed, 24 Jan 2024 15:08:01 +0100 (CET)
Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 52F6B2B2;
 Wed, 24 Jan 2024 15:08:01 +0100 (CET)
Date: Wed, 24 Jan 2024 15:07:59 +0100
From: Andreas Enge <andreas@HIDDEN>
To: Romain GARBAGE <romain.garbage@HIDDEN>
Subject: Re: [bug#68682] [PATCH] gnu: maths: arpack-ng: Modify build settings.
Message-ID: <ZbEZv1o1C1pldUCi@jurong>
References: <4284df7d0499bb5b6a46d29d6e7f858fd3baa896.1706085982.git.romain.garbage@HIDDEN>
 <ZbEY9eCjz3yOfJd6@jurong>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZbEY9eCjz3yOfJd6@jurong>
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68682
Cc: Eric Bavier <bavier@HIDDEN>,
 Sharlatan Hellseher <sharlatanus@HIDDEN>, 68682 <at> debbugs.gnu.org,
 Efraim Flashner <efraim@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

PPS: There is a new minor version 3.9.1, maybe we could take the opportunity
     that the QA build farm will build out all dependencies to update in
     a separate commit with a patchset attached to this bug.





Information forwarded to guix-patches@HIDDEN:
bug#68682; Package guix-patches. Full text available.

Message received at 68682 <at> debbugs.gnu.org:


Received: (at 68682) by debbugs.gnu.org; 24 Jan 2024 14:04:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 24 09:04:54 2024
Received: from localhost ([127.0.0.1]:44792 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rSds6-0000L0-4P
	for submit <at> debbugs.gnu.org; Wed, 24 Jan 2024 09:04:54 -0500
Received: from hera.aquilenet.fr ([185.233.100.1]:57204)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <andreas@HIDDEN>) id 1rSds3-0000Kk-Ou
 for 68682 <at> debbugs.gnu.org; Wed, 24 Jan 2024 09:04:52 -0500
Received: from localhost (localhost [127.0.0.1])
 by hera.aquilenet.fr (Postfix) with ESMTP id 454F3FF8;
 Wed, 24 Jan 2024 15:04:39 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
 by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id qFWjGGgosC_o; Wed, 24 Jan 2024 15:04:38 +0100 (CET)
Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64])
 by hera.aquilenet.fr (Postfix) with ESMTPSA id 7CE3B348;
 Wed, 24 Jan 2024 15:04:38 +0100 (CET)
Date: Wed, 24 Jan 2024 15:04:37 +0100
From: Andreas Enge <andreas@HIDDEN>
To: Romain GARBAGE <romain.garbage@HIDDEN>
Subject: Re: [bug#68682] [PATCH] gnu: maths: arpack-ng: Modify build settings.
Message-ID: <ZbEY9eCjz3yOfJd6@jurong>
References: <4284df7d0499bb5b6a46d29d6e7f858fd3baa896.1706085982.git.romain.garbage@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4284df7d0499bb5b6a46d29d6e7f858fd3baa896.1706085982.git.romain.garbage@HIDDEN>
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 68682
Cc: Eric Bavier <bavier@HIDDEN>,
 Sharlatan Hellseher <sharlatanus@HIDDEN>, 68682 <at> debbugs.gnu.org,
 Efraim Flashner <efraim@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello Romain,

Am Wed, Jan 24, 2024 at 09:46:22AM +0100 schrieb Romain GARBAGE:
> * gnu/packages/maths.scm (arpack-ng): Add configure flags for building
>   the shared library and the iso C bindings.

thanks for sending the patch!

I see that the ISO C binding flag installs additional headers, but I do not
see why the flag for building shared libraries would be needed. In the current
arpack-ng, there is already a shared library in the lib/ subdirectory.

Could you explain how adding the flag makes a difference?

Andreas

PS: Concerning the commit message, we usually do not mention the module
    and just start by "gnu: arpack-ng:" without "maths:".





Information forwarded to guix-patches@HIDDEN:
bug#68682; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 24 Jan 2024 08:48:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 24 03:48:21 2024
Received: from localhost ([127.0.0.1]:44423 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rSYvk-0002B3-Qp
	for submit <at> debbugs.gnu.org; Wed, 24 Jan 2024 03:48:21 -0500
Received: from lists.gnu.org ([2001:470:142::17]:49690)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <romain.garbage@HIDDEN>) id 1rSYvj-0002AM-BE
 for submit <at> debbugs.gnu.org; Wed, 24 Jan 2024 03:48:19 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <romain.garbage@HIDDEN>)
 id 1rSYvY-00061n-NU
 for guix-patches@HIDDEN; Wed, 24 Jan 2024 03:48:08 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <romain.garbage@HIDDEN>)
 id 1rSYvW-000545-LQ
 for guix-patches@HIDDEN; Wed, 24 Jan 2024 03:48:08 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc;
 h=from:to:cc:subject:date:message-id:mime-version:
 content-transfer-encoding;
 bh=4lzVwuFGx0xODNBgy3c87dXAdpB/XxGZqwMFB3Fahk0=;
 b=QF00zHYSyWbkHG46I9TfvRjF+7G7Chg0lsx8t/Jm52HwmFthahHefcfw
 7/vU5WfJiFVRe6zdHrtsG/Lj/I1ZseiibuT+te/1xfxLF0Rt8PCEIcC9z
 VLoaS4zRml7oP0u0tNK1ygP33PrwEk1Bb4/70YeswfvnrRFlCMrUICNXA w=;
Authentication-Results: mail2-relais-roc.national.inria.fr;
 dkim=none (message not signed) header.i=none;
 spf=SoftFail smtp.mailfrom=romain.garbage@HIDDEN;
 spf=None smtp.helo=postmaster@HIDDEN
Received-SPF: SoftFail (mail2-relais-roc.national.inria.fr:
 domain of romain.garbage@HIDDEN is inclined to not
 designate 193.50.110.153 as permitted sender)
 identity=mailfrom; client-ip=193.50.110.153;
 receiver=mail2-relais-roc.national.inria.fr;
 envelope-from="romain.garbage@HIDDEN";
 x-sender="romain.garbage@HIDDEN"; x-conformance=spf_only;
 x-record-type="v=spf1"; x-record-text="v=spf1
 include:mailout.safebrands.com a:basic-mail.safebrands.com
 a:basic-mail01.safebrands.com a:basic-mail02.safebrands.com
 ip4:128.93.142.0/24 ip4:192.134.164.0/24 ip4:128.93.162.160
 ip4:89.107.174.7 mx ~all"
Received-SPF: None (mail2-relais-roc.national.inria.fr: no sender
 authenticity information available from domain of
 postmaster@HIDDEN) identity=helo;
 client-ip=193.50.110.153;
 receiver=mail2-relais-roc.national.inria.fr;
 envelope-from="romain.garbage@HIDDEN";
 x-sender="postmaster@HIDDEN";
 x-conformance=spf_only
X-IronPort-AV: E=Sophos;i="6.05,216,1701126000"; d="scan'208";a="148329684"
Received: from unknown (HELO guix-A102.bordeaux.inria.fr) ([193.50.110.153])
 by mail2-relais-roc.national.inria.fr with
 ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2024 09:48:00 +0100
From: Romain GARBAGE <romain.garbage@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: maths: arpack-ng: Modify build settings.
Date: Wed, 24 Jan 2024 09:46:22 +0100
Message-ID: <4284df7d0499bb5b6a46d29d6e7f858fd3baa896.1706085982.git.romain.garbage@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
X-Debbugs-Cc: Andreas Enge <andreas@HIDDEN>,
 Efraim Flashner <efraim@HIDDEN>, Eric Bavier <bavier@HIDDEN>,
 Sharlatan Hellseher <sharlatanus@HIDDEN>
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=192.134.164.83;
 envelope-from=romain.garbage@HIDDEN; helo=mail2-relais-roc.national.inria.fr
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: submit
Cc: Romain GARBAGE <romain.garbage@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/maths.scm (arpack-ng): Add configure flags for building
  the shared library and the iso C bindings.

Change-Id: Iddfd67094ffafc3cabd88353e3839e5e903b804a
---
 gnu/packages/maths.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index ada828cb3f..7d92dbcdaf 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -1064,6 +1064,8 @@ (define-public arpack-ng
                 "09smxilyn8v9xs3kpx3nlj2s7ql3v8z40mpc09kccbb6smyd35iv"))
               (patches (search-patches "arpack-ng-propagate-rng-state.patch"))))
     (build-system cmake-build-system)
+    (arguments
+     '(#:configure-flags '("-DBUILD_SHARED_LIBS=ON" "-DICB=ON")))
     (native-inputs
      (list pkg-config))
     (inputs

base-commit: e3f4ab49b1b756d3356b142db935b684e6877346
-- 
2.41.0





Acknowledgement sent to Romain GARBAGE <romain.garbage@HIDDEN>:
New bug report received and forwarded. Copy sent to andreas@HIDDEN, efraim@HIDDEN, bavier@HIDDEN, sharlatanus@HIDDEN, guix-patches@HIDDEN. Full text available.
Report forwarded to andreas@HIDDEN, efraim@HIDDEN, bavier@HIDDEN, sharlatanus@HIDDEN, guix-patches@HIDDEN:
bug#68682; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 11 Feb 2024 08:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.