GNU bug report logs - #68803
[PATCH] Substitute all emacsclient occurrences

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68803 in the body.
You can then email your comments to 68803 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lin Jian <me <at> linj.tech>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Substitute all emacsclient occurrences
Date: Tue, 30 Jan 2024 06:15:51 +0800

[Message part 1 (text/plain, inline)]

Tags: patch

After commit "From .desktop files, reuse a frame or start a new
Emacs as required" on 2021-06-30, there are two emacsclient
occurrences for the Exec key of etc/emacsclient.desktop.

Before this change, only the first occurrence is substituted.

I propose a patch to substitute all emacsclient occurrences.

In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.18.0, Xaw3d scroll bars)
Windowing system distributor 'The X.Org Foundation', version 11.0.12101010
System Description: NixOS 24.05 (Uakari)

Configured using:
 'configure
 --prefix=/nix/store/mzdvpxzkhlryxmbxwbih7bgvkzkw1ly7-emacs-29.1
 --disable-build-details --with-modules --with-x-toolkit=lucid
 --with-xft --with-cairo --with-compress-install
 --with-toolkit-scroll-bars --with-native-compilation
 --without-imagemagick --without-small-ja-dic --with-tree-sitter
 --with-xinput2 --without-xwidgets'

[0001-Substitute-all-emacsclient-occurrences.patch (text/patch, attachment)]

Message #12 received at 68803-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Lin Jian <me <at> linj.tech>
Cc: 68803-done <at> debbugs.gnu.org
Subject: Re: bug#68803: [PATCH] Substitute all emacsclient occurrences
Date: Tue, 11 Feb 2025 19:53:36 -0800

Version: 31.1

Lin Jian <me <at> linj.tech> writes:

> Tags: patch
>
> After commit "From .desktop files, reuse a frame or start a new
> Emacs as required" on 2021-06-30, there are two emacsclient
> occurrences for the Exec key of etc/emacsclient.desktop.
>
> Before this change, only the first occurrence is substituted.
>
> I propose a patch to substitute all emacsclient occurrences.

Thanks for the patch, and sorry here also for the delay in reviewing.

Installed on master as commit a73a1e00523.  I'm consequently closing
this bug report.

Message #15 received at 68803-done <at> debbugs.gnu.org (full text, mbox):

From: Lin Jian <me <at> linj.tech>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 68803-done <at> debbugs.gnu.org
Subject: Re: bug#68803: [PATCH] Substitute all emacsclient occurrences
Date: Wed, 12 Feb 2025 12:26:54 +0800

I am surprised and happy to see my two trivial patches merged one year
after they were proposed.  Thank you, Stefan.

BTW, do you have any suggestions about getting patches reviewed and
merged sooner?  One year for trivial patches to be merged seems a bit
long to me.

Message #18 received at 68803 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Lin Jian <me <at> linj.tech>
Cc: 68803 <at> debbugs.gnu.org
Subject: Re: bug#68803: [PATCH] Substitute all emacsclient occurrences
Date: Tue, 11 Feb 2025 21:07:18 -0800

Lin Jian <me <at> linj.tech> writes:

> I am surprised and happy to see my two trivial patches merged one year
> after they were proposed.  Thank you, Stefan.
>
> BTW, do you have any suggestions about getting patches reviewed and
> merged sooner?  One year for trivial patches to be merged seems a bit
> long to me.

Fundamentally, the reason is that we just don't have enough people on
board that are reviewing patches.  We are all volunteers and Emacs is a
very large project.  This means that we sometimes miss things, or let
them fall by the wayside, when we perhaps shouldn't have.

Do feel free to ping us after say a month or two, if we didn't get to
one of your patches.  You can also help make our job easier by providing
additional details, such as briefly detailing any testing done, writing
a clear yet succinct rationale for why the patch is right, and so on.

Thanks again for contributing to Emacs.

Message #21 received at 68803 <at> debbugs.gnu.org (full text, mbox):

From: Lin Jian <me <at> linj.tech>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 68803 <at> debbugs.gnu.org
Subject: Re: bug#68803: [PATCH] Substitute all emacsclient occurrences
Date: Wed, 12 Feb 2025 13:30:01 +0800

Stefan Kangas <stefankangas <at> gmail.com> writes:

>
> Do feel free to ping us after say a month or two, if we didn't get to
> one of your patches.

What is the right way to ping related people?

Message #24 received at 68803 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Lin Jian <me <at> linj.tech>
Cc: 68803 <at> debbugs.gnu.org
Subject: Re: bug#68803: [PATCH] Substitute all emacsclient occurrences
Date: Tue, 11 Feb 2025 21:50:08 -0800

Lin Jian <me <at> linj.tech> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>>
>> Do feel free to ping us after say a month or two, if we didn't get to
>> one of your patches.
>
> What is the right way to ping related people?

Just write to the bug tracker, i.e. the NNNNN <at> debbugs.gnu.org address
that was assigned to track the patch.

If the patch is for some specific package, you can also check the
"Maintainer" at the top of the file and make sure to Cc that person.

Message #27 received at 68803 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 68803 <at> debbugs.gnu.org, me <at> linj.tech
Subject: Re: bug#68803: [PATCH] Substitute all emacsclient occurrences
Date: Wed, 12 Feb 2025 15:49:01 +0200

> Cc: 68803 <at> debbugs.gnu.org
> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Tue, 11 Feb 2025 21:07:18 -0800
> 
> Lin Jian <me <at> linj.tech> writes:
> 
> > I am surprised and happy to see my two trivial patches merged one year
> > after they were proposed.  Thank you, Stefan.
> >
> > BTW, do you have any suggestions about getting patches reviewed and
> > merged sooner?  One year for trivial patches to be merged seems a bit
> > long to me.
> 
> Fundamentally, the reason is that we just don't have enough people on
> board that are reviewing patches.  We are all volunteers and Emacs is a
> very large project.  This means that we sometimes miss things, or let
> them fall by the wayside, when we perhaps shouldn't have.

That is true, but I think in this particular case the main problem is
that we have zero people on board who know enough about these desktop
files and routinely review patches in that area.

IOW, the time it takes to review a patch depends on the relevant
expertise we have handy much more than on the number of people who
routinely review patches.  Patches in many other areas are reviewed
and acted upon within days.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.