GNU bug report logs - #68804
[PATCH] Remove an unneeded sed command for emacs.service

Previous Next

Package: emacs;

Reported by: Lin Jian <me <at> linj.tech>

Date: Mon, 29 Jan 2024 22:22:02 UTC

Severity: wishlist

Tags: patch

Fixed in version 31.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68804 in the body.
You can then email your comments to 68804 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#68804; Package emacs. (Mon, 29 Jan 2024 22:22:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Lin Jian <me <at> linj.tech>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 29 Jan 2024 22:22:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lin Jian <me <at> linj.tech>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Remove an unneeded sed command for emacs.service
Date: Tue, 30 Jan 2024 06:19:09 +0800

[Message part 1 (text/plain, inline)]
Tags: patch


After commit e5348f125ff03ac70713e5b227f9e51f759a587b on
2020-12-14, there is no ExecStop in etc/emacs.service.

So there is no need to use sed to substitute emacsclient for the
ExecStop key.

I propose a patch to remove this unneeded sed command.

In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.18.0, Xaw3d scroll bars)
Windowing system distributor 'The X.Org Foundation', version 11.0.12101010
System Description: NixOS 24.05 (Uakari)

Configured using:
 'configure
 --prefix=/nix/store/mzdvpxzkhlryxmbxwbih7bgvkzkw1ly7-emacs-29.1
 --disable-build-details --with-modules --with-x-toolkit=lucid
 --with-xft --with-cairo --with-compress-install
 --with-toolkit-scroll-bars --with-native-compilation
 --without-imagemagick --without-small-ja-dic --with-tree-sitter
 --with-xinput2 --without-xwidgets'


[0001-Remove-an-unneeded-sed-command-for-emacs.service.patch (text/patch, attachment)]
Severity set to 'wishlist' from 'normal' Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Tue, 30 Jan 2024 00:43:02 GMT) Full text and rfc822 format available.
Reply sent to Stefan Kangas <stefankangas <at> gmail.com>:
You have taken responsibility. (Wed, 12 Feb 2025 03:46:01 GMT) Full text and rfc822 format available.
Notification sent to Lin Jian <me <at> linj.tech>:
bug acknowledged by developer. (Wed, 12 Feb 2025 03:46:01 GMT) Full text and rfc822 format available.

Message #12 received at 68804-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Lin Jian <me <at> linj.tech>
Cc: 68804-done <at> debbugs.gnu.org
Subject: Re: bug#68804: [PATCH] Remove an unneeded sed command for
 emacs.service
Date: Tue, 11 Feb 2025 19:45:44 -0800

Version: 31.1

Lin Jian <me <at> linj.tech> writes:

> After commit e5348f125ff03ac70713e5b227f9e51f759a587b on
> 2020-12-14, there is no ExecStop in etc/emacs.service.
>
> So there is no need to use sed to substitute emacsclient for the
> ExecStop key.
>
> I propose a patch to remove this unneeded sed command.

Thanks for the patch, and sorry for the delay in reviewing it.

Installed on master as commit 9e3359475f1.  I'm consequently closing
this bug report.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 12 Mar 2025 11:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 111 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.