GNU bug report logs - #68848
New home-dotfiles-service-type creates extra toplevel directories

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68848 in the body.
You can then email your comments to 68848 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Janneke Nieuwenhuizen <janneke <at> gnu.org>
To: bug-guix <at> gnu.org
Cc: Giacomo Leidi <goodoldpaul <at> autistici.org>,
 Ludovic Courtès  <ludo <at> gnu.org>
Subject: New home-dotfiles-service-type creates extra toplevel directories
Date: Wed, 31 Jan 2024 13:17:25 +0100

Hi,

When I follow the documentation, and have

    dotfiles/guix/.config/guix/channels.scm

that shows suing tree -a ./dotfiles

    dotfiles
    └── guix
        └── .config
            └── guix
                └── channels.scm

similar to the documentaion, and using

    (service home-dotfiles-service-type
             (home-dotfiles-configuration
               (directories (list "./dotfiles"))))

creates

    ~/guix/.config/guix/channels.scm

an extra toplevel `guix" directory!

What gives?

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke <at> gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Giacomo <goodoldpaul <at> autistici.org>
To: Janneke Nieuwenhuizen <janneke <at> gnu.org>, bug-guix <at> gnu.org
Cc: ludo <at> gnu.org, sarg <at> sarg.org.ru, 60521 <at> debbugs.gnu.org
Subject: Re: New home-dotfiles-service-type creates extra toplevel directories
Date: Wed, 31 Jan 2024 13:31:52 +0100

[Message part 1 (text/plain, inline)]

Hi Janneke, thank you for the report. I already pointed out this at https://issues.guix.gnu.org/60521 . there was a fix that was removed by a misunderstanding on the requirements of the service since the code contradicts documentation as you pointed out . It should be pretty easy to apply the fix from 60521.

Thank you

Giacomo

Il 31 gennaio 2024 13:17:25 CET, Janneke Nieuwenhuizen <janneke <at> gnu.org> ha scritto:
>Hi,
>
>When I follow the documentation, and have
>
>    dotfiles/guix/.config/guix/channels.scm
>
>that shows suing tree -a ./dotfiles
>
>    dotfiles
>    └── guix
>        └── .config
>            └── guix
>                └── channels.scm
>
>similar to the documentaion, and using
>
>    (service home-dotfiles-service-type
>             (home-dotfiles-configuration
>               (directories (list "./dotfiles"))))
>
>creates
>
>    ~/guix/.config/guix/channels.scm
>
>an extra toplevel `guix" directory!
>
>What gives?
>
>Greetings,
>Janneke
>
>-- 
>Janneke Nieuwenhuizen <janneke <at> gnu.org>  | GNU LilyPond https://LilyPond.org
>Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com

[Message part 2 (text/html, inline)]

Message #11 received at 68848 <at> debbugs.gnu.org (full text, mbox):

From: paul <goodoldpaul <at> autistici.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Sergey Trofimov <sarg <at> sarg.org.ru>, 68848 <at> debbugs.gnu.org, janneke <at> gnu.org
Subject: gnu: home: dotfiles: Avoid creating extra directory in $HOME.
Date: Wed, 31 Jan 2024 23:15:47 +0100

Hello,

I'm sending a patch supposed to fix https://issues.guix.gnu.org/68848  . 
Please let me know if this is ok for you and fixes your issues.


Thank you,


giacomo

Message #16 received at 68848-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Giacomo Leidi <goodoldpaul <at> autistici.org>
Cc: paren <at> disroot.org, 68848-done <at> debbugs.gnu.org,
 Andrew Tropin <andrew <at> trop.in>, 68857-done <at> debbugs.gnu.org
Subject: Re: bug#68857: gnu: home: dotfiles: Avoid creating extra directory
 in $HOME.
Date: Wed, 06 Mar 2024 23:15:03 +0100

Hi,

Giacomo Leidi <goodoldpaul <at> autistici.org> skribis:

> The current implementation of the home-dotfiles-service-type contradicts
> the Guix manual (see https://issues.guix.gnu.org/68848 ). This patch
> properly implements both the plain and Stow dotfiles directory layouts.
>
> It does so by refactoring home-dotfiles-configuration adding a new
> packages field to support GNU Stow's users workflow and introducing
> a new layout field to switch between the two directory layouts.
>
> * gnu/home/services/dotfiles (home-dotfiles-configuration): Migrate to
> (gnu services configuration);
> [packages]: new field;
> [layout]: new field;
> (strip-stow-dotfile): new variable;
> (strip-plain-dotfile): new variable;
> (home-dotfiles-configuration->files): use the new fields;
> [directory-contents]: allow for
> selecting a subset of application dotfile directories;
> * doc/guix.texi: document the new layouts.
>
> Change-Id: I2e96037608353e360828290f055ec5271cfdfd48

Applied, thanks again!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.