GNU bug report logs - #68869
[PATCH] channels: Fix typos.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68869 in the body.
You can then email your comments to 68869 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Rostislav Svoboda <Rostislav.Svoboda <at> gmail.com>
Subject: [PATCH] channels: Fix typos.
Date: Thu,  1 Feb 2024 13:42:27 +0100

* guix/channels.scm (authenticate-channel): Pluralise commit numbers.

Change-Id: I7759607f37405e6d3bd4b7f5958fd11d908db204
---
 guix/channels.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/guix/channels.scm b/guix/channels.scm
index 1b07eb5221..a0df5459d4 100644
--- a/guix/channels.scm
+++ b/guix/channels.scm
@@ -3,6 +3,8 @@
 ;;; Copyright © 2018 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2019 Jan (janneke) Nieuwenhuizen <janneke <at> gnu.org>
 ;;; Copyright © 2021 Brice Waegeneire <brice <at> waegenei.re>
+;;; Copyright © 2024 Julien Lepiller <julien <at> lepiller.eu>
+;;; Copyright © 2024 Rostislav Svoboda <Rostislav.Svoboda <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -361,8 +363,11 @@ (define* (authenticate-channel channel checkout commit
 
   (define (make-reporter start-commit end-commit commits)
     (format (current-error-port)
-            (G_ "Authenticating channel '~a', commits ~a to ~a (~h new \
-commits)...~%")
+            (N_ "Authenticating channel '~a', commits ~a to ~a (~h new \
+commit)...~%"
+                "Authenticating channel '~a', commits ~a to ~a (~h new \
+commits)...~%"
+                (length commits))
             (channel-name channel)
             (commit-short-id start-commit)
             (commit-short-id end-commit)

base-commit: 7bf8b7c33304d6e69f36190f0444576da1863efc
-- 
2.41.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dale Mellor <guix-devel-0brg6a <at> rdmp.org>
To: 68869 <at> debbugs.gnu.org
Cc: Dale Mellor <guix-devel-0brg6a <at> rdmp.org>,
 Rostislav Svoboda <rostislav.svoboda <at> gmail.com>, guix-patches <at> gnu.org
Subject: [PATCH v2] guix: channels: Fix typos.
Date: Sun, 12 May 2024 09:34:29 +0100

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>

* guix/channels.scm (authenticate-channel): Pluralise commit numbers.

Review:
  * Microscopic documentation change, harmless, but will invoke some i18n
    activity
  * Not sure this justifies adding two names to the copyright holders list, if
    any at all?
  * Works for me

Reviewed-by: Dale Mellor <guix-devel-0brg6a <at> rdmp.org>
Change-Id: I7759607f37405e6d3bd4b7f5958fd11d908db204
---
 guix/channels.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/guix/channels.scm b/guix/channels.scm
index 51024dcad4..0d7bc541cc 100644
--- a/guix/channels.scm
+++ b/guix/channels.scm
@@ -3,6 +3,8 @@
 ;;; Copyright © 2018 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2019 Jan (janneke) Nieuwenhuizen <janneke <at> gnu.org>
 ;;; Copyright © 2021 Brice Waegeneire <brice <at> waegenei.re>
+;;; Copyright © 2024 Julien Lepiller <julien <at> lepiller.eu>
+;;; Copyright © 2024 Rostislav Svoboda <Rostislav.Svoboda <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -364,8 +366,11 @@ (define keyring-reference
 
   (define (make-reporter start-commit end-commit commits)
     (format (current-error-port)
-            (G_ "Authenticating channel '~a', commits ~a to ~a (~h new \
-commits)...~%")
+            (N_ "Authenticating channel '~a', commits ~a to ~a (~h new \
+commit)...~%"
+                "Authenticating channel '~a', commits ~a to ~a (~h new \
+commits)...~%"
+                (length commits))
             (channel-name channel)
             (commit-short-id start-commit)
             (commit-short-id end-commit)
-- 
2.41.0

Message #16 received at 68869-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Dale Mellor <guix-devel-0brg6a <at> rdmp.org>
Cc: 68869-done <at> debbugs.gnu.org, rostislav.svoboda <at> gmail.com
Subject: Re: [bug#68869] [PATCH v2] guix: channels: Fix typos.
Date: Mon, 13 May 2024 09:21:28 +0100

[Message part 1 (text/plain, inline)]

Dale Mellor <guix-devel-0brg6a <at> rdmp.org> writes:

> From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
>
> * guix/channels.scm (authenticate-channel): Pluralise commit numbers.
>
> Review:
>   * Microscopic documentation change, harmless, but will invoke some i18n
>     activity
>   * Not sure this justifies adding two names to the copyright holders list, if
>     any at all?
>   * Works for me
>
> Reviewed-by: Dale Mellor <guix-devel-0brg6a <at> rdmp.org>
> Change-Id: I7759607f37405e6d3bd4b7f5958fd11d908db204
> ---
>  guix/channels.scm | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

Thanks both, I've tweaked the commit message and pushed this to master
as e5fa18b6285c59b6e9f8debe0ffde9ef5055f3a2.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.