GNU bug report logs - #68890
[PATCH] gnu: pspp: Update to 2.0.0

Previous Next

Package: guix-patches;

Reported by: Andy Tai <atai <at> atai.org>

Date: Fri, 2 Feb 2024 07:36:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68890 in the body.
You can then email your comments to 68890 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#68890; Package guix-patches. (Fri, 02 Feb 2024 07:36:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Andy Tai <atai <at> atai.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 02 Feb 2024 07:36:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: guix-patches <at> gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH] gnu: pspp: Update to 2.0.0
Date: Thu,  1 Feb 2024 23:34:40 -0800

* gnu/packages/statistics.scm (pspp): Update to 2.0.0

Change-Id: I9feeab72789347033d2df8f23bda9ea27aaa7dd9
---
 gnu/packages/statistics.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 974b51e14e..2e55a1edf9 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -114,7 +114,7 @@ (define-module (gnu packages statistics)
 (define-public pspp
   (package
     (name "pspp")
-    (version "1.4.1")
+    (version "2.0.0")
     (source
      (origin
       (method url-fetch)
@@ -122,7 +122,7 @@ (define-public pspp
                           version ".tar.gz"))
       (sha256
        (base32
-        "0lqrash677b09zxdlxp89z6k02y4i23mbqg83956dwl69wc53dan"))))
+        "1pyqlab9kw65wxc8pilcwb64l18w37xxdg3r6n287c7mda4cpxm8"))))
     (build-system gnu-build-system)
     (arguments
      (list #:phases
@@ -148,7 +148,7 @@ (define-public pspp
            `(,glib "bin") ;for glib-genmarshal
            perl
            pkg-config
-           python-2 ;for tests
+           python-3 ;for tests
            texinfo))
     (home-page "https://www.gnu.org/software/pspp/")
     (synopsis "Statistical analysis")

base-commit: 88e8b807d6af3cf2902909d295cd3194aa7ea684
prerequisite-patch-id: c66f8f7565e88c54c25fe3b0fe42ca5e408609e1
prerequisite-patch-id: c4597470d2ce37f6458ac45f758903fb8083198c
-- 
2.41.0
Information forwarded to guix-patches <at> gnu.org:
bug#68890; Package guix-patches. (Thu, 22 Feb 2024 23:58:01 GMT) Full text and rfc822 format available.

Message #8 received at 68890 <at> debbugs.gnu.org (full text, mbox):

From: Skyler Ferris <skyvine <at> protonmail.com>
To: 68890 <at> debbugs.gnu.org, atai <at> atai.org
Subject: Re: [PATCH] gnu: pspp: Update to 2.0.0
Date: Thu, 22 Feb 2024 23:56:43 +0000

Hi Andy,

I just wanted to check if you have seen the QA status on this patch? It 
looks like it fails to build. From the build log for x86_64 
(https://bordeaux.guix.gnu.org/build/4984d142-a7f3-43da-8dc7-2b32e7781bfd/log), 
there is one test failing:

1596: tex non-ascii                                   FAILED (tex.at:280)
...
## ------------- ##
## Test results. ##
## ------------- ##

ERROR: 1621 tests were run,
1 failed unexpectedly.
8 tests were skipped.

Regards,
Skyler
Information forwarded to guix-patches <at> gnu.org:
bug#68890; Package guix-patches. (Fri, 23 Feb 2024 00:39:02 GMT) Full text and rfc822 format available.

Message #11 received at 68890 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Skyler Ferris <skyvine <at> protonmail.com>
Cc: 68890 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: pspp: Update to 2.0.0
Date: Thu, 22 Feb 2024 16:35:57 -0800

yes, I have. Sorry I have not had the time to come back to this.  Will
try to get to it soon


On Thu, Feb 22, 2024 at 3:57 PM Skyler Ferris <skyvine <at> protonmail.com> wrote:
>
> Hi Andy,
>
> I just wanted to check if you have seen the QA status on this patch? It
> looks like it fails to build. From the build log for x86_64
> (https://bordeaux.guix.gnu.org/build/4984d142-a7f3-43da-8dc7-2b32e7781bfd/log),
> there is one test failing:
>
> 1596: tex non-ascii                                   FAILED (tex.at:280)
> ...
> ## ------------- ##
> ## Test results. ##
> ## ------------- ##
>
> ERROR: 1621 tests were run,
> 1 failed unexpectedly.
> 8 tests were skipped.
>
> Regards,
> Skyler
>
Information forwarded to guix-patches <at> gnu.org:
bug#68890; Package guix-patches. (Fri, 23 Feb 2024 21:56:02 GMT) Full text and rfc822 format available.

Message #14 received at 68890 <at> debbugs.gnu.org (full text, mbox):

From: Skyler Ferris <skyvine <at> protonmail.com>
To: Andy Tai <atai <at> atai.org>
Cc: 68890 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: pspp: Update to 2.0.0
Date: Fri, 23 Feb 2024 21:20:56 +0000

On 2/22/24 16:35, Andy Tai wrote:
> yes, I have. Sorry I have not had the time to come back to this.  Will
> try to get to it soon
>
Sounds good. Just to make sure I'm communicating clearl, I sent that 
email because I was looking at the QA dashboard and thought it would be 
useful to make sure you were aware of it to avoid a situation where 
somebody comes along in a month to send essentially the same email, but 
later. I did not mean to communicate that I have a particularly urgent 
need for this patch.
Information forwarded to guix-patches <at> gnu.org:
bug#68890; Package guix-patches. (Sun, 25 Feb 2024 09:11:02 GMT) Full text and rfc822 format available.

Message #17 received at 68890 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 68890 <at> debbugs.gnu.org,
	skyvine <at> protonmail.com
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH v2] gnu: pspp: Update to 2.0.0
Date: Sun, 25 Feb 2024 01:04:01 -0800

* gnu/packages/statistics.scm (pspp): Update to 2.0.0
  [arguments](phases): Patch test case to skip failed test due to locale

Change-Id: I9feeab72789347033d2df8f23bda9ea27aaa7dd9
---
 gnu/packages/statistics.scm | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 01d5e25a1a..b77f167c03 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -115,7 +115,7 @@ (define-module (gnu packages statistics)
 (define-public pspp
   (package
     (name "pspp")
-    (version "1.4.1")
+    (version "2.0.0")
     (source
      (origin
       (method url-fetch)
@@ -123,12 +123,18 @@ (define-public pspp
                           version ".tar.gz"))
       (sha256
        (base32
-        "0lqrash677b09zxdlxp89z6k02y4i23mbqg83956dwl69wc53dan"))))
+        "1pyqlab9kw65wxc8pilcwb64l18w37xxdg3r6n287c7mda4cpxm8"))))
     (build-system gnu-build-system)
     (arguments
      (list #:phases
            #~(modify-phases %standard-phases
-               (add-before 'check 'prepare-tests
+         (add-after 'unpack 'patch-test-suite
+				 (lambda _
+				   (substitute* "tests/output/tex.at"
+					   (("AT_CHECK\\(\\[LC_ALL=C.UTF-8 pspp")
+						   "dnl AT_CHECK([LC_ALL=C.UTF-8 pspp"))
+					 #t))
+         (add-before 'check 'prepare-tests
                  ;; Prevent irrelevant errors that cause test output mismatches:
                  ;; ‘Fontconfig error: No writable cache directories’
                  (lambda _
@@ -149,7 +155,7 @@ (define-public pspp
            `(,glib "bin") ;for glib-genmarshal
            perl
            pkg-config
-           python-2 ;for tests
+           python-3 ;for tests
            texinfo))
     (home-page "https://www.gnu.org/software/pspp/")
     (synopsis "Statistical analysis")

base-commit: 05bbe9993f687da1fd684a31474c621f2a1c37b2
-- 
2.34.1
Information forwarded to guix-patches <at> gnu.org:
bug#68890; Package guix-patches. (Sun, 25 Feb 2024 15:08:01 GMT) Full text and rfc822 format available.

Message #20 received at 68890 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Andy Tai <atai <at> atai.org>
Cc: 68890 <at> debbugs.gnu.org, skyvine <at> protonmail.com
Subject: Re: [bug#68890] [PATCH v2] gnu: pspp: Update to 2.0.0
Date: Sun, 25 Feb 2024 16:06:25 +0100

Hello,

Andy Tai <atai <at> atai.org> writes:

> * gnu/packages/statistics.scm (pspp): Update to 2.0.0
>   [arguments](phases): Patch test case to skip failed test due to locale
>
> Change-Id: I9feeab72789347033d2df8f23bda9ea27aaa7dd9
> ---
>  gnu/packages/statistics.scm | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index 01d5e25a1a..b77f167c03 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -115,7 +115,7 @@ (define-module (gnu packages statistics)
>  (define-public pspp
>    (package
>      (name "pspp")
> -    (version "1.4.1")
> +    (version "2.0.0")
>      (source
>       (origin
>        (method url-fetch)
> @@ -123,12 +123,18 @@ (define-public pspp
>                            version ".tar.gz"))
>        (sha256
>         (base32
> -        "0lqrash677b09zxdlxp89z6k02y4i23mbqg83956dwl69wc53dan"))))
> +        "1pyqlab9kw65wxc8pilcwb64l18w37xxdg3r6n287c7mda4cpxm8"))))
>      (build-system gnu-build-system)
>      (arguments
>       (list #:phases
>             #~(modify-phases %standard-phases
> -               (add-before 'check 'prepare-tests
> +         (add-after 'unpack 'patch-test-suite
> +				 (lambda _
> +				   (substitute* "tests/output/tex.at"
> +					   (("AT_CHECK\\(\\[LC_ALL=C.UTF-8 pspp")
> +						   "dnl AT_CHECK([LC_ALL=C.UTF-8 pspp"))
> +					 #t))

Nitpick: trailing #T are no longer recommended at the end of phases. You
can remove this one.

> +         (add-before 'check 'prepare-tests
>                   ;; Prevent irrelevant errors that cause test output mismatches:
>                   ;; ‘Fontconfig error: No writable cache directories’
>                   (lambda _
> @@ -149,7 +155,7 @@ (define-public pspp
>             `(,glib "bin") ;for glib-genmarshal
>             perl
>             pkg-config
> -           python-2 ;for tests
> +           python-3 ;for tests

This change should appear in the commit message.

Regards,
-- 
Nicolas Goaziou
Information forwarded to guix-patches <at> gnu.org:
bug#68890; Package guix-patches. (Sun, 25 Feb 2024 18:10:01 GMT) Full text and rfc822 format available.

Message #23 received at 68890 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 68890 <at> debbugs.gnu.org,
	skyvine <at> protonmail.com,
	mail <at> nicolasgoaziou.fr
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH v3] gnu: pspp: Update to 2.0.0
Date: Sun, 25 Feb 2024 10:07:42 -0800

* gnu/packages/statistics.scm (pspp): Update to 2.0.0
  [arguments](phases): Patch test case to skip failed test due to locale
  [native-inputs]: Switch from Python 2 to Python 3

Change-Id: I9feeab72789347033d2df8f23bda9ea27aaa7dd9
---
 gnu/packages/statistics.scm | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 01d5e25a1a..a22a36d18a 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -115,7 +115,7 @@ (define-module (gnu packages statistics)
 (define-public pspp
   (package
     (name "pspp")
-    (version "1.4.1")
+    (version "2.0.0")
     (source
      (origin
       (method url-fetch)
@@ -123,12 +123,17 @@ (define-public pspp
                           version ".tar.gz"))
       (sha256
        (base32
-        "0lqrash677b09zxdlxp89z6k02y4i23mbqg83956dwl69wc53dan"))))
+        "1pyqlab9kw65wxc8pilcwb64l18w37xxdg3r6n287c7mda4cpxm8"))))
     (build-system gnu-build-system)
     (arguments
      (list #:phases
            #~(modify-phases %standard-phases
-               (add-before 'check 'prepare-tests
+         (add-after 'unpack 'patch-test-suite
+				 (lambda _
+				   (substitute* "tests/output/tex.at"
+					   (("AT_CHECK\\(\\[LC_ALL=C.UTF-8 pspp")
+						   "dnl AT_CHECK([LC_ALL=C.UTF-8 pspp"))))
+         (add-before 'check 'prepare-tests
                  ;; Prevent irrelevant errors that cause test output mismatches:
                  ;; ‘Fontconfig error: No writable cache directories’
                  (lambda _
@@ -149,7 +154,7 @@ (define-public pspp
            `(,glib "bin") ;for glib-genmarshal
            perl
            pkg-config
-           python-2 ;for tests
+           python-3 ;for tests
            texinfo))
     (home-page "https://www.gnu.org/software/pspp/")
     (synopsis "Statistical analysis")

base-commit: 05bbe9993f687da1fd684a31474c621f2a1c37b2
-- 
2.34.1
Information forwarded to guix-patches <at> gnu.org:
bug#68890; Package guix-patches. (Sun, 25 Feb 2024 23:48:01 GMT) Full text and rfc822 format available.

Message #26 received at 68890 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 68890 <at> debbugs.gnu.org,
	skyvine <at> protonmail.com,
	mail <at> nicolasgoaziou.fr
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH v4] gnu: pspp: Update to 2.0.0
Date: Sun, 25 Feb 2024 15:45:54 -0800

* gnu/packages/statistics.scm (pspp): Update to 2.0.0
  [arguments](phases): Patch test case to make pass due to locale
  [native-inputs]: Switch from Python 2 to Python 3

Change-Id: I9feeab72789347033d2df8f23bda9ea27aaa7dd9
---
 gnu/packages/statistics.scm | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 01d5e25a1a..05bdb589f7 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -115,7 +115,7 @@ (define-module (gnu packages statistics)
 (define-public pspp
   (package
     (name "pspp")
-    (version "1.4.1")
+    (version "2.0.0")
     (source
      (origin
       (method url-fetch)
@@ -123,12 +123,17 @@ (define-public pspp
                           version ".tar.gz"))
       (sha256
        (base32
-        "0lqrash677b09zxdlxp89z6k02y4i23mbqg83956dwl69wc53dan"))))
+        "1pyqlab9kw65wxc8pilcwb64l18w37xxdg3r6n287c7mda4cpxm8"))))
     (build-system gnu-build-system)
     (arguments
      (list #:phases
            #~(modify-phases %standard-phases
-               (add-before 'check 'prepare-tests
+         (add-after 'unpack 'patch-test-suite
+				 (lambda _
+				   (substitute* "tests/output/tex.at"
+					   (("AT_CHECK\\(\\[LC_ALL=C.UTF-8 pspp")
+						   "AT_CHECK([LC_ALL=en_US.UTF-8 pspp"))))
+         (add-before 'check 'prepare-tests
                  ;; Prevent irrelevant errors that cause test output mismatches:
                  ;; ‘Fontconfig error: No writable cache directories’
                  (lambda _
@@ -149,7 +154,7 @@ (define-public pspp
            `(,glib "bin") ;for glib-genmarshal
            perl
            pkg-config
-           python-2 ;for tests
+           python-3 ;for tests
            texinfo))
     (home-page "https://www.gnu.org/software/pspp/")
     (synopsis "Statistical analysis")

base-commit: 05bbe9993f687da1fd684a31474c621f2a1c37b2
-- 
2.34.1
Information forwarded to guix-patches <at> gnu.org:
bug#68890; Package guix-patches. (Mon, 26 Feb 2024 19:51:02 GMT) Full text and rfc822 format available.

Message #29 received at 68890 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 68890 <at> debbugs.gnu.org
Subject: passes QA
Date: Mon, 26 Feb 2024 11:48:30 -0800

[Message part 1 (text/plain, inline)]
patch passes Guix QA: https://qa.guix.gnu.org/issue/68890

[Message part 2 (text/html, inline)]
Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Tue, 27 Feb 2024 10:23:02 GMT) Full text and rfc822 format available.
Notification sent to Andy Tai <atai <at> atai.org>:
bug acknowledged by developer. (Tue, 27 Feb 2024 10:23:02 GMT) Full text and rfc822 format available.

Message #34 received at 68890-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Andy Tai <atai <at> atai.org>
Cc: mail <at> nicolasgoaziou.fr, 68890-done <at> debbugs.gnu.org, skyvine <at> protonmail.com
Subject: Re: [bug#68890] [PATCH v4] gnu: pspp: Update to 2.0.0
Date: Tue, 27 Feb 2024 11:21:56 +0100

Andy Tai <atai <at> atai.org> skribis:

> * gnu/packages/statistics.scm (pspp): Update to 2.0.0
>   [arguments](phases): Patch test case to make pass due to locale
>   [native-inputs]: Switch from Python 2 to Python 3
>
> Change-Id: I9feeab72789347033d2df8f23bda9ea27aaa7dd9

[...]

>             #~(modify-phases %standard-phases
> -               (add-before 'check 'prepare-tests
> +         (add-after 'unpack 'patch-test-suite
> +				 (lambda _
> +				   (substitute* "tests/output/tex.at"
> +					   (("AT_CHECK\\(\\[LC_ALL=C.UTF-8 pspp")
> +						   "AT_CHECK([LC_ALL=en_US.UTF-8 pspp"))))

I adjusted indentation here and applied it, thanks!
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 27 Mar 2024 11:24:21 GMT) Full text and rfc822 format available.
This bug report was last modified 121 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.