GNU bug report logs - #68891
[PATCH] gnu: emacs-org-board: Update to 1138-2.500fe02.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68891 in the body.
You can then email your comments to 68891 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH] gnu: emacs-org-board: Update to 1138-2.500fe02.
Date: Fri,  2 Feb 2024 09:45:16 +0100

* gnu/packages/emacs-xyz.scm (emacs-org-board): Update to 1138-2.500fe02.
---
 gnu/packages/emacs-xyz.scm | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c7e6852194..3e6d09c509 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27782,8 +27782,8 @@ (define-public emacs-cpreproc-openvdb
    (license license:gpl3+)))
 
 (define-public emacs-org-board
-  (let ((commit "1393bd46d11a81328ed4fb8471831415a3efe224")
-        (revision "1"))
+  (let ((commit "500fe02bc114e5b535a2eb2ab73954d79428168f")
+        (revision "2"))
     (package
       (name "emacs-org-board")
       (version (git-version "1138" revision commit))
@@ -27795,7 +27795,7 @@ (define-public emacs-org-board
                 (file-name (git-file-name name version))
                 (sha256
                  (base32
-                  "1kryrg988c3sbxyp1sdgc6xdv2iz6kiflpzn2rw4z3l4grzab53b"))))
+                  "1mcghw9mmlyqsgxk97hd57495sfx8dp6ig7qgs5xn2b2k0ygv4vf"))))
       (build-system emacs-build-system)
       (arguments
        (list
@@ -27805,11 +27805,9 @@ (define-public emacs-org-board
               (lambda* (#:key inputs #:allow-other-keys)
                 (emacs-substitute-variables "org-board.el"
                   ("org-board-wget-program"
-                   (search-input-file inputs "/bin/wget"))))))))
-      (inputs
-       (list wget))
+                   (search-input-file inputs "/bin/wget2"))))))))
       (propagated-inputs
-       (list emacs-org emacs-ztree))
+       (list emacs-ztree wget2))
       (home-page "https://github.com/charlesroelli/org-board")
       (synopsis "Bookmarking and web archival system for Org mode")
       (description

base-commit: c692808a5e1413480162be1406186a63bd92651c
-- 
2.41.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: guix-patches <at> gnu.org, 68891 <at> debbugs.gnu.org
Subject: Re: [bug#68891] [PATCH] gnu: emacs-org-board: Update to
 1138-2.500fe02.
Date: Tue, 13 Feb 2024 11:21:06 +0000

[Message part 1 (text/plain, inline)]

Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-board): Update to 1138-2.500fe02.
> ---
>  gnu/packages/emacs-xyz.scm | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index c7e6852194..3e6d09c509 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -27782,8 +27782,8 @@ (define-public emacs-cpreproc-openvdb
>     (license license:gpl3+)))
>  
>  (define-public emacs-org-board
> -  (let ((commit "1393bd46d11a81328ed4fb8471831415a3efe224")
> -        (revision "1"))
> +  (let ((commit "500fe02bc114e5b535a2eb2ab73954d79428168f")
> +        (revision "2"))
>      (package
>        (name "emacs-org-board")
>        (version (git-version "1138" revision commit))
> @@ -27795,7 +27795,7 @@ (define-public emacs-org-board
>                  (file-name (git-file-name name version))
>                  (sha256
>                   (base32
> -                  "1kryrg988c3sbxyp1sdgc6xdv2iz6kiflpzn2rw4z3l4grzab53b"))))
> +                  "1mcghw9mmlyqsgxk97hd57495sfx8dp6ig7qgs5xn2b2k0ygv4vf"))))
>        (build-system emacs-build-system)
>        (arguments
>         (list
> @@ -27805,11 +27805,9 @@ (define-public emacs-org-board
>                (lambda* (#:key inputs #:allow-other-keys)
>                  (emacs-substitute-variables "org-board.el"
>                    ("org-board-wget-program"
> -                   (search-input-file inputs "/bin/wget"))))))))
> -      (inputs
> -       (list wget))
> +                   (search-input-file inputs "/bin/wget2"))))))))
>        (propagated-inputs
> -       (list emacs-org emacs-ztree))
> +       (list emacs-ztree wget2))

Thanks for the patch, these changes around wget/wget2 look confusing to
me though.

The reason for the emacs-substitute-variables bit is to allow wget to
just be an input rather than a propagated input, but you're making wget2
a propagated input here. This change and the motivation behind it is
also missing from the commit message.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: guix-patches <at> gnu.org, 68891 <at> debbugs.gnu.org
Subject: Re: [bug#68891] [PATCH] gnu: emacs-org-board: Update to
 1138-2.500fe02.
Date: Tue, 13 Feb 2024 14:18:02 +0100

>mar. 13 févr. 2024 at 11:21, Christopher Baines <mail <at> cbaines.net> wrote:

> Thanks for the patch, these changes around wget/wget2 look confusing to
> me though.
>
> The reason for the emacs-substitute-variables bit is to allow wget to
> just be an input rather than a propagated input, but you're making wget2
> a propagated input here. This change and the motivation behind it is
> also missing from the commit message.

When one installs emacs-org-board, wget2-2.1.0 gets installed along with
it as for emacs-substitute-variables, as you say, and the variable
org-board-wget-program is bound to this hardcoded value.

Once one decides to upgrade wget2 to something different (say, in a
different profile), this logic breaks. User needs to manually bind
org-board-wget-program to whatever wget2 is after upgrading. At this
point, wget2 becomes a native-input requirement.

Please, correct me if I’m wrong.

Cayetano

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Cc: Christopher Baines <mail <at> cbaines.net>, csantosb <at> inventati.org,
 68891 <at> debbugs.gnu.org
Subject: Re: [bug#68891] [PATCH] gnu: emacs-org-board: Update to
 1138-2.500fe02.
Date: Thu, 22 Feb 2024 11:52:46 +0100

Hello,

Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org> writes:

> When one installs emacs-org-board, wget2-2.1.0 gets installed along with
> it as for emacs-substitute-variables, as you say, and the variable
> org-board-wget-program is bound to this hardcoded value.

Correct.

> Once one decides to upgrade wget2 to something different (say, in a
> different profile), this logic breaks. User needs to manually bind
> org-board-wget-program to whatever wget2 is after upgrading. At this
> point, wget2 becomes a native-input requirement.

This is not correct. No action is required from the user.
`org-board-wget-program' still points to the wget program defined as an
input to emacs-org-board, and will still be used at run time.

Of course, the user still can point `org-board-wget-program' to their
new and shiny wget binary, but this is not required.

I also suggest to keep wget (or wget2) as an input and use
`emacs-substitute-variables'.

Regards,
-- 
Nicolas Goaziou

Message #26 received at 68891 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 68891 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v1] gnu: emacs-org-board: Update to 1138-2.500fe02.
Date: Tue, 12 Nov 2024 15:12:32 +0100

* gnu/packages/emacs-xyz.scm (emacs-org-board): Update to 1138-2.500fe02.

Change-Id: Ifb8abdb02170a2183c5a023604c1f0d427781759
---

Update to latest.

- emacs-org is part of emacs now, no need to pull latest

 gnu/packages/emacs-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b3517b7bd9..5efbd543ac 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -29399,8 +29399,8 @@ (define-public emacs-cpreproc-openvdb
    (license license:gpl3+)))
 
 (define-public emacs-org-board
-  (let ((commit "1393bd46d11a81328ed4fb8471831415a3efe224")
-        (revision "1"))
+  (let ((commit "500fe02bc114e5b535a2eb2ab73954d79428168f")
+        (revision "2"))
     (package
       (name "emacs-org-board")
       (version (git-version "1138" revision commit))
@@ -29412,7 +29412,7 @@ (define-public emacs-org-board
                 (file-name (git-file-name name version))
                 (sha256
                  (base32
-                  "1kryrg988c3sbxyp1sdgc6xdv2iz6kiflpzn2rw4z3l4grzab53b"))))
+                  "1mcghw9mmlyqsgxk97hd57495sfx8dp6ig7qgs5xn2b2k0ygv4vf"))))
       (build-system emacs-build-system)
       (arguments
        (list
@@ -29426,7 +29426,7 @@ (define-public emacs-org-board
       (inputs
        (list wget))
       (propagated-inputs
-       (list emacs-org emacs-ztree))
+       (list emacs-ztree))
       (home-page "https://github.com/charlesroelli/org-board")
       (synopsis "Bookmarking and web archival system for Org mode")
       (description

base-commit: 40625c213ad2007f70117518a7cc290d367e652a
--
2.46.0

Message #29 received at 68891 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: GNU bug tracker automated control server <control <at> debbugs.gnu.org>
Cc: 68891 <at> debbugs.gnu.org
Subject: Control message for bug #68891
Date: Tue, 19 Nov 2024 11:36:01 +0100

user guix
usertag 68891 + patch-hackers-review-list
thanks

--
Cayetano Santos

Message #32 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Cc: 68891-done <at> debbugs.gnu.org
Subject: Re: [bug#68891] [PATCH v1] gnu: emacs-org-board: Update to
 1138-2.500fe02.
Date: Fri, 03 Jan 2025 12:08:00 +0100

Hello,

Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-board): Update to
> 1138-2.500fe02.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.