GNU bug report logs - #68919
30.0.50; etc/w32-feature.el: tests do not work under --batch

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: minor; Reported by: Corwin Brust <corwin@HIDDEN>; Keywords: patch; Done: Corwin Brust <corwin@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 68919-done <at> debbugs.gnu.org:

Received: (at 68919-done) by debbugs.gnu.org; 24 Dec 2024 03:28:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 23 22:28:48 2024
Received: from localhost ([127.0.0.1]:58856 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tPvbD-0004Yz-Kr
	for submit <at> debbugs.gnu.org; Mon, 23 Dec 2024 22:28:47 -0500
Received: from mail-oo1-f51.google.com ([209.85.161.51]:38500)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mplscorwin@HIDDEN>) id 1tPvbA-0004Yj-Nv
 for 68919-done <at> debbugs.gnu.org; Mon, 23 Dec 2024 22:28:45 -0500
Received: by mail-oo1-f51.google.com with SMTP id
 006d021491bc7-5f3610c395dso473627eaf.2
 for <68919-done <at> debbugs.gnu.org>; Mon, 23 Dec 2024 19:28:44 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1735010919; x=1735615719;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=S2PezEt62AeJ4CpFFAtG30vJ1nkNhd9BxGXpDgEvw4k=;
 b=AUFyi6nvPscTVn9oaalFALdRxnB6tXh2ji9juwT6eSC/JOxKYNFqMwok/5354xvIju
 B88VMXo8GYMoJzFbBWdgblL32AZggWr3Cqf9VBmeZaivVwE9mr6Uaj0tSKJDOj5tkjAR
 O10/CvZiGl4qDZb90mj0/RbiGyCHNOlYIpNeUB+qIJgaQ93kBvmf5bcFaMdYC5cigyxs
 W3uAV1jv7IGauCkAuXLR8iU1qE1d6XyWAwzCFuoqMgNrJSEpv7CXV+d/VxdZGPFwendA
 vG0vbuWlzMCbKW9vUZIGGSUmQLuVmbrO/FQy/jdB/NNAs/HMD8LgLTt6nLskV0oU1flL
 Bcjg==
X-Forwarded-Encrypted: i=1;
 AJvYcCWH97xMp28zlmJwCZIUsWhvT0cMYtyXx6+hxs2CE5fxBLJqlH25jyedgVh4P6p+Be2yh48zt59d7JC5 <at> debbugs.gnu.org
X-Gm-Message-State: AOJu0Yw69Z4xDU81j1hw4iuHdM629H+deR9HZ4LDlWzqCDbO0LdOzFmK
 pjCi7Pjk3jLWHQeKUyVEdrFTpq6Fr8Mv8jTP+8Mhme4dYtJ18w/WJWdZvAPd2jAwG++ZcICUcmi
 gHYblMeSNnxRRXlD5BGEqMv0oy+4=
X-Gm-Gg: ASbGncsVVmLNvAGU4Q2j6OGHI2UtizRoK77aFWyqgswsCIyZbd/AWBUqNzy+8BIWYSt
 aSJx2UCTuy8RfbWSaMG9RZvwXA277WTtmxj+T
X-Google-Smtp-Source: AGHT+IGLK9GyyoIgFsMCRH02lj746FX9n6NTsLoUtL/IICgWtEAO27iXboYKgG3vlV569sWz6fXKk1zshHorhqSllQA=
X-Received: by 2002:a05:6830:25d3:b0:71e:f1:3ec with SMTP id
 46e09a7af769-720ff8e9b4amr3794497a34.7.1735010919024; Mon, 23 Dec 2024
 19:28:39 -0800 (PST)
MIME-Version: 1.0
References: <CAJf-WoQ3J=CgwAhutKcFODiq4Edt_GJnMf8OTQV52Bv5DNzdWw@HIDDEN>
 <f36c392d94c88e7a59dca47a57d63c27@HIDDEN> <86h6io3dvb.fsf@HIDDEN>
 <CAJf-WoQ54tuQNjTK_H+vUCCA8KKpbQxbbkEVDsSYkFBF7Vw1FQ@HIDDEN>
 <864jeo2qg8.fsf@HIDDEN>
 <CADwFkmksUqPkqqP87wMwtA6EqdB2Epd2RAu8Fag2QG=QF82xhw@HIDDEN>
In-Reply-To: <CADwFkmksUqPkqqP87wMwtA6EqdB2Epd2RAu8Fag2QG=QF82xhw@HIDDEN>
From: Corwin Brust <corwin@HIDDEN>
Date: Mon, 23 Dec 2024 21:28:28 -0600
Message-ID: <CAJf-WoS=cY8ctCS7qtVNiwSTGnRaPyEEZWZDuXPnyM6NvM4qLw@HIDDEN>
Subject: Re: bug#68919: 30.0.50;
 etc/w32-feature.el: tests do not work under --batch
To: Stefan Kangas <stefankangas@HIDDEN>, 68919-done <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: 68919-done
Cc: Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

On Mon, Dec 23, 2024 at 9:05=E2=80=AFPM Stefan Kangas <stefankangas@HIDDEN=
om> wrote:
>
> Eli Zaretskii <eliz@HIDDEN> writes:
>
> >> From: Corwin Brust <corwin@HIDDEN>
> >> Date: Sun, 4 Feb 2024 09:25:32 -0600
> >> Cc: 68919 <at> debbugs.gnu.org
> >>
> >> On Sun, Feb 4, 2024 at 1:08=E2=80=AFAM Eli Zaretskii <eliz@HIDDEN> wr=
ote:
> >> >
> >> > We can do better than this, I think.  The following works in batch
> >> > mode:
> >> >
> >> >   emacs -batch --eval "(message \"%s\" (get 'uniscribe 'font-driver-=
superseded-by))"
> >> >    =3D> harfbuzz
> >> >
> >>
> >> Thank you, Eli - let me know if this is better.
> >
> > LGTM, thanks.
>
> Corwin, could you please install this patch and close this bug?
>

Done with 0e43e35f96e..c29b798537e  emacs-30 -> emacs-30.
Thank you.

> >
> >> (Should we continue using frame-parameters in when display-graphic-p
> >> is t?  I assume not; this works in both cases and is thus better
> >> because it's simpler, or so I have thought.)
> >
> > Yes, for this particular feature there's no need to use
> > frame-parameters anymore, since the above test works in all kinds of
> > session.
>
> Not sure what to do about this part.
>

Nothing to be done, I believe. Here I think Eli confirms I was correct
to ignore `display-graphic-p' because the font-driver-superseded-by
will only eq harfbuz when Emacs was both built with support for
harfbuzz -and- actually succeeded in loading the DLL in the run-time,
(so I guess we load that DLL even in batch mode :)

Notification sent to Corwin Brust <corwin@HIDDEN>:
bug acknowledged by developer. Full text available.

Reply sent to Corwin Brust <corwin@HIDDEN>:
You have taken responsibility. Full text available.