GNU bug report logs - #68956
M-q → Invalid predicate, see ‘treesit-thing-settings’ for valid forms for a predicate: nil

Previous Next

To reply to this bug, email your comments to 68956 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dominique Quatravaux <dominique <at> quatravaux.org>
To: bug-gnu-emacs <at> gnu.org
Subject: M-q → Invalid predicate, see ‘treesit-thing-settings’ for valid forms for a predicate: nil
Date: Tue, 6 Feb 2024 18:32:27 +0100

[Message part 1 (text/plain, inline)]

When invoking `prog-fill-reindent-defun' from inside a bash-ts-mode buffer,
an exception (regardless of where point is), an error is raised that reads

Invalid predicate, see ‘treesit-thing-settings’ for valid forms for a
predicate: nil

Investigation reveals that `prog-fill-reindent-defun' calls
`treesit-node-match-p' with 'text as the second argument, which can only
succeed if `(assq 'text (assq 'bash treesit-thing-settings))' is non-nil;
whereas the corresponding setting for `treesit-thing-settings' prepared by
`bash-ts-mode', doesn't provide a value for 'text (only for 'sentence).

--
 Dominique Quatravaux
 dominique <at> quatravaux.org

[Message part 2 (text/html, inline)]

Message #8 received at 68956 <at> debbugs.gnu.org (full text, mbox):

From: Dominique Quatravaux <dominique <at> quatravaux.org>
To: 68956 <at> debbugs.gnu.org
Subject: Workaround
Date: Tue, 6 Feb 2024 18:44:18 +0100

[Message part 1 (text/plain, inline)]

I had success applying the following workaround:

(advice-add 'bash-ts-mode
            :after (lambda (&rest ignored)
                     (when-let ((bash-things (assq 'bash
treesit-thing-settings)))
                       (setf (alist-get 'text (cdr bash-things))
'(sentence)))))

Now M-q does the right thing for me everywhere in bash-ts-mode.

--
 Dominique Quatravaux
 dominique <at> quatravaux.org

[Message part 2 (text/html, inline)]

Message #11 received at 68956 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dominique Quatravaux <dominique <at> quatravaux.org>,
 Yuan Fu <casouri <at> gmail.com>
Cc: 68956 <at> debbugs.gnu.org
Subject: Re: bug#68956: M-q → Invalid predicate, see
 ‘treesit-thing-settings’ for valid forms for a
 predicate: nil
Date: Sat, 10 Feb 2024 10:44:01 +0200

> From: Dominique Quatravaux <dominique <at> quatravaux.org>
> Date: Tue, 6 Feb 2024 18:32:27 +0100
> 
> When invoking `prog-fill-reindent-defun' from inside a bash-ts-mode buffer, an exception (regardless of where
> point is), an error is raised that reads
> 
> Invalid predicate, see ‘treesit-thing-settings’ for valid forms for a predicate: nil
> 
> Investigation reveals that `prog-fill-reindent-defun' calls `treesit-node-match-p' with 'text as the second
> argument, which can only succeed if `(assq 'text (assq 'bash treesit-thing-settings))' is non-nil; whereas the
> corresponding setting for `treesit-thing-settings' prepared by `bash-ts-mode', doesn't provide a value for 'text
> (only for 'sentence).
> 
> I had success applying the following workaround:
> 
> (advice-add 'bash-ts-mode
>             :after (lambda (&rest ignored)
>                      (when-let ((bash-things (assq 'bash treesit-thing-settings)))
>                        (setf (alist-get 'text (cdr bash-things)) '(sentence)))))
> 
> Now M-q does the right thing for me everywhere in bash-ts-mode.

Yuan, any comments or ideas?

Thanks.

Message #14 received at 68956 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: casouri <at> gmail.com
Cc: dominique <at> quatravaux.org, 68956 <at> debbugs.gnu.org
Subject: Re: bug#68956: M-q → Invalid predicate,
 see ‘treesit-thing-settings’ for valid
 forms for a predicate: nil
Date: Sat, 24 Feb 2024 11:32:10 +0200

Ping!  Yuan, any comments?

> Cc: 68956 <at> debbugs.gnu.org
> Date: Sat, 10 Feb 2024 10:44:01 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Dominique Quatravaux <dominique <at> quatravaux.org>
> > Date: Tue, 6 Feb 2024 18:32:27 +0100
> > 
> > When invoking `prog-fill-reindent-defun' from inside a bash-ts-mode buffer, an exception (regardless of where
> > point is), an error is raised that reads
> > 
> > Invalid predicate, see ‘treesit-thing-settings’ for valid forms for a predicate: nil
> > 
> > Investigation reveals that `prog-fill-reindent-defun' calls `treesit-node-match-p' with 'text as the second
> > argument, which can only succeed if `(assq 'text (assq 'bash treesit-thing-settings))' is non-nil; whereas the
> > corresponding setting for `treesit-thing-settings' prepared by `bash-ts-mode', doesn't provide a value for 'text
> > (only for 'sentence).
> > 
> > I had success applying the following workaround:
> > 
> > (advice-add 'bash-ts-mode
> >             :after (lambda (&rest ignored)
> >                      (when-let ((bash-things (assq 'bash treesit-thing-settings)))
> >                        (setf (alist-get 'text (cdr bash-things)) '(sentence)))))
> > 
> > Now M-q does the right thing for me everywhere in bash-ts-mode.
> 
> Yuan, any comments or ideas?
> 
> Thanks.
> 
> 
> 
> 

Message #17 received at 68956 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 68956 <at> debbugs.gnu.org
Subject: Re: bug#68956: M-q → Invalid predicate, see  ‘treesit-thing-settings’ for valid forms for a  predicate: nil
Date: Tue, 9 Apr 2024 23:03:21 -0700

[Adding the bug tracker back, forgot to replay-all]

> On Apr 8, 2024, at 8:42 PM, Yuan Fu <casouri <at> gmail.com> wrote:
> 
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
>>> Cc: 68956 <at> debbugs.gnu.org
>>> Date: Sat, 10 Feb 2024 10:44:01 +0200
>>> From: Eli Zaretskii <eliz <at> gnu.org>
>>> 
>>>> From: Dominique Quatravaux <dominique <at> quatravaux.org>
>>>> Date: Tue, 6 Feb 2024 18:32:27 +0100
>>>> 
>>>> When invoking `prog-fill-reindent-defun' from inside a bash-ts-mode buffer, an exception (regardless of where
>>>> point is), an error is raised that reads
>>>> 
>>>> Invalid predicate, see ‘treesit-thing-settings’ for valid forms for a predicate: nil
>>>> 
>>>> Investigation reveals that `prog-fill-reindent-defun' calls `treesit-node-match-p' with 'text as the second
>>>> argument, which can only succeed if `(assq 'text (assq 'bash treesit-thing-settings))' is non-nil; whereas the
>>>> corresponding setting for `treesit-thing-settings' prepared by `bash-ts-mode', doesn't provide a value for 'text
>>>> (only for 'sentence).
>>>> 
>>>> I had success applying the following workaround:
>>>> 
>>>> (advice-add 'bash-ts-mode
>>>>            :after (lambda (&rest ignored)
>>>>                     (when-let ((bash-things (assq 'bash treesit-thing-settings)))
>>>>                       (setf (alist-get 'text (cdr bash-things)) '(sentence)))))
>>>> 
>>>> Now M-q does the right thing for me everywhere in bash-ts-mode.
>>> 
>>> Yuan, any comments or ideas?
>>> 
>>> Thanks.
> 
> Sorry for the delay. Dominique, what version are you using? I can see
> that this is fixed on master[1], but not on emacs-29, perhaps due to
> the size of the change.
> 
> [1] b392d05089014ac6d41e35a016d46f496964f879
> 
> Yuan

Message #20 received at 68956 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>,
 Dominique Quatravaux <dominique <at> quatravaux.org>
Cc: 68956 <at> debbugs.gnu.org
Subject: Re: bug#68956: M-q → Invalid predicate, see
 ‘treesit-thing-settings’ for valid forms for a
 predicate: nil
Date: Wed, 10 Apr 2024 13:51:33 +0300

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Tue, 9 Apr 2024 23:03:21 -0700
> Cc: 68956 <at> debbugs.gnu.org
> 
> [Adding the bug tracker back, forgot to replay-all]

And it might be a good idea to add Dominique as well ;-)

> 
> > On Apr 8, 2024, at 8:42 PM, Yuan Fu <casouri <at> gmail.com> wrote:
> > 
> > 
> > Eli Zaretskii <eliz <at> gnu.org> writes:
> > 
> >>> Cc: 68956 <at> debbugs.gnu.org
> >>> Date: Sat, 10 Feb 2024 10:44:01 +0200
> >>> From: Eli Zaretskii <eliz <at> gnu.org>
> >>> 
> >>>> From: Dominique Quatravaux <dominique <at> quatravaux.org>
> >>>> Date: Tue, 6 Feb 2024 18:32:27 +0100
> >>>> 
> >>>> When invoking `prog-fill-reindent-defun' from inside a bash-ts-mode buffer, an exception (regardless of where
> >>>> point is), an error is raised that reads
> >>>> 
> >>>> Invalid predicate, see ‘treesit-thing-settings’ for valid forms for a predicate: nil
> >>>> 
> >>>> Investigation reveals that `prog-fill-reindent-defun' calls `treesit-node-match-p' with 'text as the second
> >>>> argument, which can only succeed if `(assq 'text (assq 'bash treesit-thing-settings))' is non-nil; whereas the
> >>>> corresponding setting for `treesit-thing-settings' prepared by `bash-ts-mode', doesn't provide a value for 'text
> >>>> (only for 'sentence).
> >>>> 
> >>>> I had success applying the following workaround:
> >>>> 
> >>>> (advice-add 'bash-ts-mode
> >>>>            :after (lambda (&rest ignored)
> >>>>                     (when-let ((bash-things (assq 'bash treesit-thing-settings)))
> >>>>                       (setf (alist-get 'text (cdr bash-things)) '(sentence)))))
> >>>> 
> >>>> Now M-q does the right thing for me everywhere in bash-ts-mode.
> >>> 
> >>> Yuan, any comments or ideas?
> >>> 
> >>> Thanks.
> > 
> > Sorry for the delay. Dominique, what version are you using? I can see
> > that this is fixed on master[1], but not on emacs-29, perhaps due to
> > the size of the change.
> > 
> > [1] b392d05089014ac6d41e35a016d46f496964f879
> > 
> > Yuan
> 
> 

Message #23 received at 68956 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: dominique <at> quatravaux.org
Cc: 68956 <at> debbugs.gnu.org, casouri <at> gmail.com
Subject: Re: bug#68956: M-q → Invalid predicate,
 see ‘treesit-thing-settings’ for valid
 forms for a predicate: nil
Date: Sat, 20 Apr 2024 10:45:19 +0300

Ping!  Dominique, could you please answer Yuan's question below?

> Cc: 68956 <at> debbugs.gnu.org
> Date: Wed, 10 Apr 2024 13:51:33 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Yuan Fu <casouri <at> gmail.com>
> > Date: Tue, 9 Apr 2024 23:03:21 -0700
> > Cc: 68956 <at> debbugs.gnu.org
> > 
> > [Adding the bug tracker back, forgot to replay-all]
> 
> And it might be a good idea to add Dominique as well ;-)
> 
> > 
> > > On Apr 8, 2024, at 8:42 PM, Yuan Fu <casouri <at> gmail.com> wrote:
> > > 
> > > 
> > > Eli Zaretskii <eliz <at> gnu.org> writes:
> > > 
> > >>> Cc: 68956 <at> debbugs.gnu.org
> > >>> Date: Sat, 10 Feb 2024 10:44:01 +0200
> > >>> From: Eli Zaretskii <eliz <at> gnu.org>
> > >>> 
> > >>>> From: Dominique Quatravaux <dominique <at> quatravaux.org>
> > >>>> Date: Tue, 6 Feb 2024 18:32:27 +0100
> > >>>> 
> > >>>> When invoking `prog-fill-reindent-defun' from inside a bash-ts-mode buffer, an exception (regardless of where
> > >>>> point is), an error is raised that reads
> > >>>> 
> > >>>> Invalid predicate, see ‘treesit-thing-settings’ for valid forms for a predicate: nil
> > >>>> 
> > >>>> Investigation reveals that `prog-fill-reindent-defun' calls `treesit-node-match-p' with 'text as the second
> > >>>> argument, which can only succeed if `(assq 'text (assq 'bash treesit-thing-settings))' is non-nil; whereas the
> > >>>> corresponding setting for `treesit-thing-settings' prepared by `bash-ts-mode', doesn't provide a value for 'text
> > >>>> (only for 'sentence).
> > >>>> 
> > >>>> I had success applying the following workaround:
> > >>>> 
> > >>>> (advice-add 'bash-ts-mode
> > >>>>            :after (lambda (&rest ignored)
> > >>>>                     (when-let ((bash-things (assq 'bash treesit-thing-settings)))
> > >>>>                       (setf (alist-get 'text (cdr bash-things)) '(sentence)))))
> > >>>> 
> > >>>> Now M-q does the right thing for me everywhere in bash-ts-mode.
> > >>> 
> > >>> Yuan, any comments or ideas?
> > >>> 
> > >>> Thanks.
> > > 
> > > Sorry for the delay. Dominique, what version are you using? I can see
> > > that this is fixed on master[1], but not on emacs-29, perhaps due to
> > > the size of the change.
> > > 
> > > [1] b392d05089014ac6d41e35a016d46f496964f879
> > > 
> > > Yuan
> > 
> > 
> 
> 
> 
> 

Message #26 received at 68956 <at> debbugs.gnu.org (full text, mbox):

From: Dominique Quatravaux <dominique <at> quatravaux.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 68956 <at> debbugs.gnu.org, casouri <at> gmail.com
Subject: Re: bug#68956: M-q → Invalid predicate, see ‘treesit-thing-settings’ for valid forms for a predicate: nil
Date: Mon, 22 Apr 2024 12:53:52 +0200

[Message part 1 (text/plain, inline)]

Le sam. 20 avr. 2024 à 09:45, Eli Zaretskii <eliz <at> gnu.org> a écrit :

> Ping!  Dominique, could you please answer Yuan's question below?
>


Dear Eli, dear Yuan, I just rebuilt my Emacs to version
4d9629b087fe6df941b553c6931b2f8996901e21 and indeed M-q doesn't crash
anymore.

Please feel free to close bug#68956.

Many thanks,

--
 Dominique Quatravaux
 dominique <at> quatravaux.org

[Message part 2 (text/html, inline)]

Message #31 received at 68956-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dominique Quatravaux <dominique <at> quatravaux.org>
Cc: casouri <at> gmail.com, 68956-done <at> debbugs.gnu.org
Subject: Re: bug#68956: M-q → Invalid predicate, see
 ‘treesit-thing-settings’ for valid forms for a
 predicate: nil
Date: Mon, 22 Apr 2024 13:55:45 +0300

> From: Dominique Quatravaux <dominique <at> quatravaux.org>
> Date: Mon, 22 Apr 2024 12:53:52 +0200
> Cc: casouri <at> gmail.com, 68956 <at> debbugs.gnu.org
> 
> Le sam. 20 avr. 2024 à 09:45, Eli Zaretskii <eliz <at> gnu.org> a écrit :
> 
>  Ping!  Dominique, could you please answer Yuan's question below?
> 
> Dear Eli, dear Yuan, I just rebuilt my Emacs to version 4d9629b087fe6df941b553c6931b2f8996901e21 and
> indeed M-q doesn't crash anymore.
> 
> Please feel free to close bug#68956.

Thanks, closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.