GNU logs - #68994, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#68994] [PATCH] adding xmake
Resent-From: miro <firat-23@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 08 Feb 2024 17:50:01 +0000
Resent-Message-ID: <handler.68994.B.170741458617641 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 68994 <at> debbugs.gnu.org
Cc: miro <firat-23@HIDDEN>
From: miro <firat-23@HIDDEN>
Date: Thu,  8 Feb 2024 17:34:25 +0100
Message-ID: <GV1PR10MB6707DF43EFED065AE3C48439FE442@HIDDEN>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: GV1PR10MB6707:EE_|VI1PR10MB3197:EE_
X-MS-Office365-Filtering-Correlation-Id: f9b4896f-6484-46bd-f781-08dc28c401e0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: CITJu6zzi/4YK8M3yGhB9d2R0Mau3k74UcSWzRNIotCwAQ9bBC2AdbzefVdf7RhcpAUIlD0iL4BrP9uOLBZhoaSvBX+9rB1eDVzZIm5nK0w/eIpgbCCJpIqx4UmZpl6pymcmL14fOi1ZwLa0fQcfGkj1Sc19ViMjd/PKYT/B6+30uJIKZU4mtjp18J7nnNCCzoGf4muH3LCszcWa1pbuCYlkoLuPPakng15yYrzVlUVgnsjGzvqB8M0FV88lDgMllER4NsroMxzjJGAKTsBa0+0RlcBTo5q7IvQfjp6suJnQweXSLQUuMZuqrKn90oJ9SWlqcgfegQ5n2SVG3MW+DAw7t14mLQ52RxoPv9/VjwRQKQQTAFeghNdk8eVtRuAT4ZbuG4mOy1ytuoczpck/AM9mF1D0gETlPTSZ4cNI3VXChHXKbT0c34Hm7rD/yIZE6FLwzLQDtcB5ulibutRXlUybwRVW6XHZnHPKFiCzm8tSIzeP1Y41tIz5e7JkzHSfNhCYYDHWztaWD6bh2fjJ1wOu03yaJt5nrWBcCDrY5uOBjDlEaUGJ/Tw9JT8lTh1vNiaagwOalW1v2adKanEj7iQQQIudue+S8wBnottW8u28IxUIkSIyFLKauqHnZn27
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: uyzC2kEx9XYkEtQNCbCT3nVceLt/Hs0cQiLXTjixs8KGrsukdJLBfdNjNMatNdaUHtWJ9HeNfE7R0iSqiiWdqOpw8KKXzDroHQYBdfidlz5QEqc14+4FhA/EvqPjeh4o81LzIpz7058/Vsncl1xLhENaTZEiUHlziiiWovQ+NQvvwuHSYpgMbT+cyVJfJ3UGKcrnWqW18gh+oJYEfu8ZW8Xawbcbsil/KgicqjSdmF1WDmwcHCVHBR1Hvz/GNn7cJtg6qMr+VLvurPq9QvFpfQz1XHzPNi3yz4vuVnmHtzu36WD9Ux6V2bLcoYOHvu071kX+V6KVegTa20STLomn7xXj5gbm8GHaAFcS5VVBkeX1A8ntmvo5eUwXEjLhzwdsYes4IEbw3dq4RrG/QrNGWAOnzQDSoRwjzwv0PUUYRGbkQMYEWPRiuV2om/u+9OVGWBZsssWhgwXCFTzI/rVDcom626KmZY79W8aAkE9uUHrOxftxYG+emS9bqgaFtOUfwDDByUSUD5sE+4qkqY2n/BOoVifwSk2+FY0qSTEZzdZmJYojZPllam5/EKh1srELltPGU3mimWkcQq9MNZx86Snb+LHdq8JhH1ZD7DlirWUeokrzHSO31PL3T0r44hvkNgmZI9+uoYy67QdKPsytr/eQaLT+dJSbMURb/v1IdXJIEAt0pAwYwjlO+hJj2GK8fUTdbvTzUNyoYahxrCV1H4HkSD0NiaD+PM7rSHN8dY4tAO4fYUoKh5JgIN7Rif5vgZJ2Clgm0FGVrzv/toIlf2dWnaQLPAgv/6z8BHfvYrqlOONIsbLkdAfk8/gDwdIgMAXVeFQURymEc52SiysVb/hJi+UK2yMG6L9jDy4uZziKHuEOeoWU/8O8bJan62LOVPBRSGeN5c67HlzcaurhnD8ki8gHnaz88H8o6gPd1TrQqxguZWsW4qGt6Ev2n1hC+jNn/rKI8nbud7o9n165FMwSUi3CMDdqRM7fepiby6VMD9vQg9feu/3FQzEHA5YXOHsP5OVKlwo1NMgFA/EeamXcBP3+sQ+/OcfUY5MemuZdotvVvYArF/gIT+q+C3urQCHlqV855KIZ2zOT1zpiAoj5QFD6GD1iN1GoTSQ2JUqymz47XF66v5oXxAxil5DAZiHOsoKR8joD6uJukFxdgC8okYb6S76XaIPV5iqVCRnlEH6QmX+8EluDuC7nxElm4yMaZwNIKOweYngCnCsgTQ==
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-6b909.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: f9b4896f-6484-46bd-f781-08dc28c401e0
X-MS-Exchange-CrossTenant-AuthSource: GV1PR10MB6707.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 16:35:49.3010 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB3197
Received-SPF: pass client-ip=2a01:111:f400:7e1a::815;
 envelope-from=firat-23@HIDDEN;
 helo=EUR05-DB8-obe.outbound.protection.outlook.com
X-Spam_score_int: -16
X-Spam_score: -1.7
X-Spam_bar: -
X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25,
 FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: --- gnu/packages/build-tools.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+) diff --git a/gnu/packages/build-tools.scm
 b/gnu/packages/build-tools.scm index 15d88ded80..b6869524f0 100644 ---
 a/gnu/packages/build-tools.scm
 +++ b/gnu/packages/build-tools.scm @@ -15,6 +15,7 @@ ;;; [...] 
 Content analysis details:   (1.2 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends
 in digit (firat-23[at]hotmail.fr)
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (firat-23[at]hotmail.fr)
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
 0.0 SPOOFED_FREEMAIL       No description available.
X-Mailman-Approved-At: Thu, 08 Feb 2024 12:49:44 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)

---
 gnu/packages/build-tools.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-tools.scm
index 15d88ded80..b6869524f0 100644
--- a/gnu/packages/build-tools.scm
+++ b/gnu/packages/build-tools.scm
@@ -15,6 +15,7 @@
 ;;; Copyright © 2021 qblade <qblade@HIDDEN>
 ;;; Copyright © 2021, 2023 Maxim Cournoyer <maxim.cournoyer@HIDDEN>
 ;;; Copyright © 2022, 2023 Juliana Sims <juli@HIDDEN>
+;;; Copyright © 2024 Firat Yildirim <firat-23@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1013,3 +1014,24 @@ (define-public pdpmake
     ;; pdpmake is distributed under the public domain, but the sources include
     ;; tests under the GPL license version 2.
     (license (list license:gpl2 license:public-domain))))
+
+(define-public xmake
+  (package
+    (name "xmake")
+    (version "2.8.6")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/xmake-io/xmake.git")
+	     (recursive? #t)
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256 "1rz7f37rps5s81mylxrn04jpd4q17dfbmz0rrdxg1wybxnpgb8il")))
+    (arguments
+     `(#:tests? #f))
+    (build-system gnu-build-system)
+    (home-page "https://xmake.io/")
+    (synopsis "Cross-platform build utility based on Lua")
+    (description "Xmake is a cross-platform build utility based on Lua.")
+    (license gpl3+)))

base-commit: a903558577d249354aa74bbd6aab897235a7602b
-- 
2.34.1

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: miro <firat-23@HIDDEN>
Subject: bug#68994: Acknowledgement ([PATCH] adding xmake)
Message-ID: <handler.68994.B.170741458617641.ack <at> debbugs.gnu.org>
References: <GV1PR10MB6707DF43EFED065AE3C48439FE442@HIDDEN>
X-Gnu-PR-Message: ack 68994
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 68994 <at> debbugs.gnu.org
Date: Thu, 08 Feb 2024 17:50:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 68994 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
68994: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68994
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#68994] [PATCH] adding xmake
Resent-From: Mathieu Othacehe <othacehe@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 09 Feb 2024 15:43:01 +0000
Resent-Message-ID: <handler.68994.B68994.170749335222388 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: miro <firat-23@HIDDEN>
Cc: 68994 <at> debbugs.gnu.org
From: Mathieu Othacehe <othacehe@HIDDEN>
In-Reply-To: <GV1PR10MB6707DF43EFED065AE3C48439FE442@HIDDEN>
 (miro's message of "Thu, 8 Feb 2024 17:34:25 +0100")
References: <GV1PR10MB6707DF43EFED065AE3C48439FE442@HIDDEN>
Date: Fri, 09 Feb 2024 16:42:01 +0100
Message-ID: <871q9lzlti.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>


Hello,

Thanks for this patch.

> ---
>  gnu/packages/build-tools.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)

You are missing a commit message here. The commit message should follow
the conventions explained here:
https://www.gnu.org/prep/standards/html_node/Change-Logs.html

You can also have a look the `git log` for examples.

> +(define-public xmake
> +  (package
> +    (name "xmake")
> +    (version "2.8.6")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/xmake-io/xmake.git")
> +	     (recursive? #t)

        ^
        that's a tabulation

Reported by `guix lint`:

gnu/packages/build-tools.scm:1027:0: xmake@HIDDEN: tabulation on line 1027, column 0

> +    (arguments
> +     `(#:tests? #f))

There is a test directory so the tests should not be disabled.

> +    (home-page "https://xmake.io/")

`guix lint` reports that:

gnu/packages/build-tools.scm:1023:5: xmake@HIDDEN: permanent redirect
from https://github.com/xmake-io/xmake.git to
https://github.com/xmake-io/xmake

> +    (synopsis "Cross-platform build utility based on Lua")
> +    (description "Xmake is a cross-platform build utility based on Lua.")

Please expand a bit on that description. What are the features of xmake
for instance?

> +    (license gpl3+)))

There's an issue preventing this from compiling. You should use
licence:gpl3+. By the way, it seems to be license:asl2.0 rather than
license:gplv3+.

Please make sure that `make` reports no error on your package.

Don't hesitate to ask if some remarks are unclear :)

Thanks,

Mathieu

Last modified: Fri, 9 Feb 2024 15:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.