GNU bug report logs - #69006
[PATCH 1/2] gnu: reproc: Enable reproc++.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69006 in the body.
You can then email your comments to 69006 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Paul A. Patience" <paul <at> apatience.com>
To: guix-patches <at> gnu.org
Cc: "Paul A. Patience" <paul <at> apatience.com>
Subject: [PATCH 1/2] gnu: reproc: Enable reproc++.
Date: Fri, 09 Feb 2024 19:17:15 +0000

* gnu/packages/cpp.scm (reproc)[arguments]<#:configure-flags>: Add
-DREPROC++=ON.

Change-Id: I2bf6c4c45df6a1ca5569ce1cf63c42905cc336d0
---
 gnu/packages/cpp.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 62a1923571..785b001629 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -1058,7 +1058,8 @@ (define-public reproc
       ;; No tests.
     `(#:tests? #f
       ;; Build the shared library instead of a static one.
-      #:configure-flags `("-DBUILD_SHARED_LIBS=1")))
+      #:configure-flags `("-DBUILD_SHARED_LIBS=1"
+                          "-DREPROC++=ON")))
    (native-inputs
     (list pkg-config))
    (synopsis "Process IO library")

base-commit: 570ef13a87bb54d3410c431700ba78316a2641e2
-- 
2.41.0

Message #8 received at 69006 <at> debbugs.gnu.org (full text, mbox):

From: "Paul A. Patience" <paul <at> apatience.com>
To: 69006 <at> debbugs.gnu.org
Cc: "Paul A. Patience" <paul <at> apatience.com>
Subject: [PATCH 2/2] gnu: reproc: Improve package style.
Date: Fri, 09 Feb 2024 20:02:12 +0000

* gnu/packages/cpp.scm (reproc)[arguments]: Use G-expressions.
<#:configure-flags>: Remove unnecessary comment and enable CMake
variable with ON rather than 1.

Change-Id: Ic5e6747e7978a40d1aab66b4c3634342736c0bcf
---
 gnu/packages/cpp.scm | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 785b001629..4523ce2b04 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -1055,11 +1055,9 @@ (define-public reproc
           (base32 "09xnf8hmld1fk8j33zwlz1qcxnjdx1ncbg62csic9va4m1wc2v1d"))))
    (build-system cmake-build-system)
    (arguments
-      ;; No tests.
-    `(#:tests? #f
-      ;; Build the shared library instead of a static one.
-      #:configure-flags `("-DBUILD_SHARED_LIBS=1"
-                          "-DREPROC++=ON")))
+    (list #:tests? #f     ; No tests.
+          #:configure-flags #~(list "-DBUILD_SHARED_LIBS=ON"
+                                    "-DREPROC++=ON")))
    (native-inputs
     (list pkg-config))
    (synopsis "Process IO library")
-- 
2.41.0

Message #13 received at 69006-done <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: "Paul A. Patience" <paul <at> apatience.com>
Cc: 69006-done <at> debbugs.gnu.org
Subject: Re: [bug#69006] [PATCH 1/2] gnu: reproc: Enable reproc++.
Date: Fri, 01 Mar 2024 14:22:29 +0800

Hi Paul,

On Sat, 10 Feb 2024 03:17:15 +0800,
Paul A. Patience wrote:
>
> * gnu/packages/cpp.scm (reproc)[arguments]<#:configure-flags>: Add
> -DREPROC++=ON.
>
> Change-Id: I2bf6c4c45df6a1ca5569ce1cf63c42905cc336d0
> ---
>  gnu/packages/cpp.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied as b18c003c6908b6d7bc6d63ee4451b5b5cdb6f17c and
a1bf3139a0eefef839542b330e36de824e6541a4, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.