GNU bug report logs - #69017
30.0.50; [debbugs] Make compilation step optional in debbugs-gnu-apply-patch

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Eric Abrahamsen <eric@HIDDEN>; dated Sat, 10 Feb 2024 17:54:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 69017 <at> debbugs.gnu.org:


Received: (at 69017) by debbugs.gnu.org; 10 Feb 2024 20:53:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 10 15:53:09 2024
Received: from localhost ([127.0.0.1]:40704 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rYuLU-0003XH-O7
	for submit <at> debbugs.gnu.org; Sat, 10 Feb 2024 15:53:09 -0500
Received: from mail.ericabrahamsen.net ([52.70.2.18]:59240)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eric@HIDDEN>) id 1rYuLS-0003Wb-8P
 for 69017 <at> debbugs.gnu.org; Sat, 10 Feb 2024 15:53:07 -0500
Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65])
 (Authenticated sender: eric@HIDDEN)
 by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 5A2C7FA0B2;
 Sat, 10 Feb 2024 20:52:43 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net;
 s=mail; t=1707598363;
 bh=UYZKwQycsxxzqH7TfBejX3h1wVrLITIwwLV17tcWyx0=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=LqhM5HAcAL3e1k6UhtGNWCqBmGxKLpx/sFhS7jGgMBvH2P/2C50u7Sh10mK2KswtF
 3cg/v7QN6aPnqyvMpxwBL7sHiwxeLQNcmsY6cAWR6Asajf4X/KbGqChMZOBYXomVDw
 ZOfrkiQltE6rh2ZJJLsw2YsfVK8h2ZMZuU1qU8uY=
From: Eric Abrahamsen <eric@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#69017: 30.0.50; [debbugs] Make compilation step optional in
 debbugs-gnu-apply-patch
In-Reply-To: <867cjct6as.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 10 Feb
 2024 22:26:03 +0200")
References: <877cjcz04e.fsf@HIDDEN> <87plx4b14w.fsf@HIDDEN>
 <87il2wxgwd.fsf@HIDDEN> <86bk8ot8zx.fsf@HIDDEN>
 <87eddkxf9b.fsf@HIDDEN> <867cjct6as.fsf@HIDDEN>
Date: Sat, 10 Feb 2024 12:52:42 -0800
Message-ID: <878r3sxcrp.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 69017
Cc: michael.albinus@HIDDEN, 69017 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

--=-=-=
Content-Type: text/plain

Eli Zaretskii <eliz@HIDDEN> writes:

>> From: Eric Abrahamsen <eric@HIDDEN>
>> Cc: michael.albinus@HIDDEN,  69017 <at> debbugs.gnu.org
>> Date: Sat, 10 Feb 2024 11:58:56 -0800
>> 
>> Eli Zaretskii <eliz@HIDDEN> writes:
>> 
>> >> Cc: 69017 <at> debbugs.gnu.org
>> >> From: Eric Abrahamsen <eric@HIDDEN>
>> >> Date: Sat, 10 Feb 2024 11:23:30 -0800
>> >> 
>> >> Out of curiosity, do you use any convenience functions for applying
>> >> patches from email->repository?
>> >
>> > I use M-|, FWIW.
>> 
>> That's what I was trying to avoid! You're the one who has to handle
>> attachments vs inline, type out the directory location, decide between
>> "git am" and "git apply", etc...
>> 
>> If you're doing it 50 times a day, maybe the muscle memory (or command
>> history) means it's not a big deal.
>
> Emacs remembers the command history, so all I have to do is press <UP>
> a few times, after I type M-|, then type RET.
>
> And some figuring out is still up to you, because patches could be for
> the release branch or for the master (and maybe for a few more
> branches), so you'd need some "cd foo" before "git am".  I have a
> command for master and for the release branch, and I need to decide
> which one to use in each case.  That cannot be automated.

Yup, that makes plenty of sense. Your situation is more complicated than
mine, no surprise there!

I've attached the minimum workable approach, which just lets the user
set the compile command to nil to skip compilation, and the relevant
window rearrangements afterwards.

A fuller solution might be a "after-apply-patch-actions" option, that takes a
list like '(compile vc). That could obviate
`debbugs-gnu-apply-patch-prefers-magit' because you could just set the
list to '(compile magit) instead. But that would require a pretty
thorough reworking of the window munging code that comes at the end, and
I'd like to just keep this simple.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Don-t-compile-after-applying-a-patch-if-compile-comm.patch

From 861d000d35f8ed90ed47ce7cff980157d1329408 Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <eric@HIDDEN>
Date: Sat, 10 Feb 2024 12:38:31 -0800
Subject: [PATCH] Don't compile after applying a patch, if compile command is
 nil

* debbugs-gnu.el (debbugs-gnu-apply-patch): Allow the user to set
debbugs-gnu-compile-command to nil to skip the compile step.
---
 debbugs-gnu.el | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/debbugs-gnu.el b/debbugs-gnu.el
index a5453334cd..f4f1fce7da 100644
--- a/debbugs-gnu.el
+++ b/debbugs-gnu.el
@@ -2612,12 +2612,13 @@ If SELECTIVELY, query the user before applying the patch."
       (insert-file-contents-literally rej))
     (goto-char (point-max))
     (save-some-buffers t)
-    (require 'compile)
-    (mapc #'kill-process compilation-in-progress)
-    (compile
-     (format "cd %s; %s"
-	     debbugs-gnu-current-directory
-	     debbugs-gnu-compile-command))
+    (when debbugs-gnu-compile-command
+      (require 'compile)
+      (mapc #'kill-process compilation-in-progress)
+      (compile
+       (format "cd %s; %s"
+	       debbugs-gnu-current-directory
+	       debbugs-gnu-compile-command)))
     (let (buf)
       (if (debbugs-gnu-apply-patch-prefers-magit)
           (progn
@@ -2637,11 +2638,12 @@ If SELECTIVELY, query the user before applying the patch."
       (delete-other-windows)
       (switch-to-buffer output-buffer)
       (split-window)
-      (split-window)
-      (other-window 1)
-      (switch-to-buffer "*compilation*")
-      (goto-char (point-max))
-      (other-window 1)
+      (when debbugs-gnu-compile-command
+       (split-window)
+       (other-window 1)
+       (switch-to-buffer "*compilation*")
+       (goto-char (point-max))
+       (other-window 1))
       (switch-to-buffer buf)
       (goto-char (point-min)))))
 
-- 
2.43.0


--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69017; Package emacs. Full text available.

Message received at 69017 <at> debbugs.gnu.org:


Received: (at 69017) by debbugs.gnu.org; 10 Feb 2024 20:26:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 10 15:26:33 2024
Received: from localhost ([127.0.0.1]:38990 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rYtvk-0002HM-Ji
	for submit <at> debbugs.gnu.org; Sat, 10 Feb 2024 15:26:33 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:39714)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rYtvj-0002H3-6a
 for 69017 <at> debbugs.gnu.org; Sat, 10 Feb 2024 15:26:32 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rYtvK-0000Ip-6X; Sat, 10 Feb 2024 15:26:06 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=Gs02VUhTExDtb+hDZQumYnCcBNlz9i0NykMup1aMQsU=; b=ilOdPVyNngRB
 c3q3A+MyVqGwmpKD1fkDZhFJPRDjWNBTM5rPSwVsTUtfR5Vt9mLHUIYN7Ot8yR+azzf0krNYbT6nK
 5GikMijGoibxj1nEQtRW7W/1F6PmitZlKl/ArUGID/sDmoeXI3fDlzJUwyhTkOfWiefE/k47YQ5DH
 2oq19RqhR4UVlYwuY+fYDZUs4Gem/8YW8Mt4DZz4s+pzNiALtbuPfDmTdlmehwxSxOUFXUKegaMlk
 MyShDV5w4zbZY7pzTf3XBSM3s3gfVae1y1FQI/Sf7qahDSBrIxCsaXXyiE54knA/JiCI4Xlj/1WEe
 fTTexuiDDledmsSz1Z/o2g==;
Date: Sat, 10 Feb 2024 22:26:03 +0200
Message-Id: <867cjct6as.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Eric Abrahamsen <eric@HIDDEN>
In-Reply-To: <87eddkxf9b.fsf@HIDDEN> (message from Eric Abrahamsen
 on Sat, 10 Feb 2024 11:58:56 -0800)
Subject: Re: bug#69017: 30.0.50; [debbugs] Make compilation step optional in
 debbugs-gnu-apply-patch
References: <877cjcz04e.fsf@HIDDEN> <87plx4b14w.fsf@HIDDEN>
 <87il2wxgwd.fsf@HIDDEN> <86bk8ot8zx.fsf@HIDDEN>
 <87eddkxf9b.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 69017
Cc: michael.albinus@HIDDEN, 69017 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Eric Abrahamsen <eric@HIDDEN>
> Cc: michael.albinus@HIDDEN,  69017 <at> debbugs.gnu.org
> Date: Sat, 10 Feb 2024 11:58:56 -0800
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> >> Cc: 69017 <at> debbugs.gnu.org
> >> From: Eric Abrahamsen <eric@HIDDEN>
> >> Date: Sat, 10 Feb 2024 11:23:30 -0800
> >> 
> >> Out of curiosity, do you use any convenience functions for applying
> >> patches from email->repository?
> >
> > I use M-|, FWIW.
> 
> That's what I was trying to avoid! You're the one who has to handle
> attachments vs inline, type out the directory location, decide between
> "git am" and "git apply", etc...
> 
> If you're doing it 50 times a day, maybe the muscle memory (or command
> history) means it's not a big deal.

Emacs remembers the command history, so all I have to do is press <UP>
a few times, after I type M-|, then type RET.

And some figuring out is still up to you, because patches could be for
the release branch or for the master (and maybe for a few more
branches), so you'd need some "cd foo" before "git am".  I have a
command for master and for the release branch, and I need to decide
which one to use in each case.  That cannot be automated.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69017; Package emacs. Full text available.

Message received at 69017 <at> debbugs.gnu.org:


Received: (at 69017) by debbugs.gnu.org; 10 Feb 2024 19:59:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 10 14:59:22 2024
Received: from localhost ([127.0.0.1]:37086 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rYtVS-0006hl-E2
	for submit <at> debbugs.gnu.org; Sat, 10 Feb 2024 14:59:22 -0500
Received: from mail.ericabrahamsen.net ([52.70.2.18]:49922)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eric@HIDDEN>) id 1rYtVP-0006hO-Sx
 for 69017 <at> debbugs.gnu.org; Sat, 10 Feb 2024 14:59:20 -0500
Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65])
 (Authenticated sender: eric@HIDDEN)
 by mail.ericabrahamsen.net (Postfix) with ESMTPSA id B4E58FA0B2;
 Sat, 10 Feb 2024 19:58:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net;
 s=mail; t=1707595138;
 bh=X+E5o4n7P4Sj9jiXzh/PhGvwgRlUkV0Mo3ucDixNgHE=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=eB05iIX9UInr7zVicW8nwGN9a6lNbd45bbRD2comg9vok2RxR3OqqQW5W4sajX8uj
 NOhZUYI9S0jgv8dV8ilu8/2GRkKDMZfvreZCg2V+1sImtntFny2YoL6Ou/Y88zAKQX
 cVf5lQp0TK1xNP4W9GP6LkenyJRhHzFEHe45NVjQ=
From: Eric Abrahamsen <eric@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#69017: 30.0.50; [debbugs] Make compilation step optional in
 debbugs-gnu-apply-patch
In-Reply-To: <86bk8ot8zx.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 10 Feb
 2024 21:27:46 +0200")
References: <877cjcz04e.fsf@HIDDEN> <87plx4b14w.fsf@HIDDEN>
 <87il2wxgwd.fsf@HIDDEN> <86bk8ot8zx.fsf@HIDDEN>
Date: Sat, 10 Feb 2024 11:58:56 -0800
Message-ID: <87eddkxf9b.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 69017
Cc: michael.albinus@HIDDEN, 69017 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Eli Zaretskii <eliz@HIDDEN> writes:

>> Cc: 69017 <at> debbugs.gnu.org
>> From: Eric Abrahamsen <eric@HIDDEN>
>> Date: Sat, 10 Feb 2024 11:23:30 -0800
>> 
>> Out of curiosity, do you use any convenience functions for applying
>> patches from email->repository?
>
> I use M-|, FWIW.

That's what I was trying to avoid! You're the one who has to handle
attachments vs inline, type out the directory location, decide between
"git am" and "git apply", etc...

If you're doing it 50 times a day, maybe the muscle memory (or command
history) means it's not a big deal.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69017; Package emacs. Full text available.

Message received at 69017 <at> debbugs.gnu.org:


Received: (at 69017) by debbugs.gnu.org; 10 Feb 2024 19:28:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 10 14:28:11 2024
Received: from localhost ([127.0.0.1]:35420 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rYt1H-0005DH-1C
	for submit <at> debbugs.gnu.org; Sat, 10 Feb 2024 14:28:11 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:54676)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rYt1F-0005Cp-8e
 for 69017 <at> debbugs.gnu.org; Sat, 10 Feb 2024 14:28:10 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rYt0u-0007jZ-5y; Sat, 10 Feb 2024 14:27:48 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=innOIWcir2m8xFUOChCFBNv77F+NwL+PgQNDXuUoH80=; b=fOGDlDzSJ1hZ
 SuZLA1zGnsDZhQh5XO9NvqKEPyvZHAr2jFc3PJBBcKOGY/129aRQ+V+hHh0i8WXagVdm4/rDXAjrr
 TsuAYRE4VnPWSswtB0PxYb/rGPiXDHLbKaQM5v2mRAia6klAXks1pr2CdTAoOrbGEgmynYHzTbxRA
 Mp20Dr4/mABPxtYlPtDzaGr4SP9hOx5yqQ0jTS00jP2ABrjMTVldsdAPl/GOmxRBK1AJecJ2HeRDz
 yDP3AgcodImG/2s0odSRbrG+E2YeSd1biyoaM8kM8uyfRAZvdOV6mn8wtF7vq5oPwibeSSVucE1CY
 vJXCq6GiY2ZEk/0QTNwbsw==;
Date: Sat, 10 Feb 2024 21:27:46 +0200
Message-Id: <86bk8ot8zx.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Eric Abrahamsen <eric@HIDDEN>
In-Reply-To: <87il2wxgwd.fsf@HIDDEN> (message from Eric Abrahamsen
 on Sat, 10 Feb 2024 11:23:30 -0800)
Subject: Re: bug#69017: 30.0.50;
 [debbugs] Make compilation step optional in debbugs-gnu-apply-patch
References: <877cjcz04e.fsf@HIDDEN> <87plx4b14w.fsf@HIDDEN>
 <87il2wxgwd.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 69017
Cc: michael.albinus@HIDDEN, 69017 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 69017 <at> debbugs.gnu.org
> From: Eric Abrahamsen <eric@HIDDEN>
> Date: Sat, 10 Feb 2024 11:23:30 -0800
> 
> Out of curiosity, do you use any convenience functions for applying
> patches from email->repository?

I use M-|, FWIW.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69017; Package emacs. Full text available.

Message received at 69017 <at> debbugs.gnu.org:


Received: (at 69017) by debbugs.gnu.org; 10 Feb 2024 19:23:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 10 14:23:55 2024
Received: from localhost ([127.0.0.1]:35061 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rYsx8-0004yW-Vj
	for submit <at> debbugs.gnu.org; Sat, 10 Feb 2024 14:23:55 -0500
Received: from mail.ericabrahamsen.net ([52.70.2.18]:60738)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eric@HIDDEN>) id 1rYsx7-0004y4-7L
 for 69017 <at> debbugs.gnu.org; Sat, 10 Feb 2024 14:23:53 -0500
Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65])
 (Authenticated sender: eric@HIDDEN)
 by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 64AC9FA0B2;
 Sat, 10 Feb 2024 19:23:31 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net;
 s=mail; t=1707593011;
 bh=nRPM0XevELi0ieHW+CMQ1M4MmNlsYKD88bUgoRY5Sog=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=YtnWCtSBVkDQlpMe8OvujQe9QbwH9Sax6ALvYsKBJYeiVaAXLtWqjOvCRoYOjiyYp
 vIFfnfVWZD+rao6kcNvk4d+uDd8xF8sevXNMuWIplTu2hhEcF7EAnF4t9zjWfbYsfj
 CKee/evskDymjAme8sx2AcP7hCKR0DNjYMkbIobM=
From: Eric Abrahamsen <eric@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#69017: 30.0.50; [debbugs] Make compilation step optional in
 debbugs-gnu-apply-patch
In-Reply-To: <87plx4b14w.fsf@HIDDEN> (Michael Albinus's message of "Sat, 10
 Feb 2024 19:54:55 +0100")
References: <877cjcz04e.fsf@HIDDEN> <87plx4b14w.fsf@HIDDEN>
Date: Sat, 10 Feb 2024 11:23:30 -0800
Message-ID: <87il2wxgwd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 69017
Cc: 69017 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


On 02/10/24 19:54 PM, Michael Albinus wrote:
> Eric Abrahamsen <eric@HIDDEN> writes:
>
> Hi Eric,
>
>> I've started using `debbugs-gnu-apply-patch' regularly, and find it
>> enormously useful -- it's particularly nice that it handles both inline
>> patches and attachments.
>>
>> I don't love the automatic compilation step, though. I pretty much never
>> want to go straight to compilation; it is very long; and the windows are
>> a mess until it finishes. Even the magit/vc step afterwards is often not
>> what I want, as I have Magit already open on Emacs somewhere else.
>>
>> How about some sort of custom option to control this? Either
>> specifically compile-after-apply, or maybe a list of post-apply-actions,
>> something like that?
>
> I don't use `debbugs-gnu-apply-patch' by myself, so I have no opinion
> about. It was written by Lars for his own workflow.

Out of curiosity, do you use any convenience functions for applying
patches from email->repository?

> No objections from my side, if you make some optional changes. And
> please document them in debbugs-ug.texi.

Okay! Thanks. I have a quick question: the :version tags on the
defcustoms in debbug-gnu.el all seem to refer to Emacs versions,
shouldn't they refer to debbugs package versions? Or is this also a Lars
thing?

Thanks,
Eric




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69017; Package emacs. Full text available.

Message received at 69017 <at> debbugs.gnu.org:


Received: (at 69017) by debbugs.gnu.org; 10 Feb 2024 19:00:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 10 14:00:35 2024
Received: from localhost ([127.0.0.1]:33640 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rYsaZ-0003vl-AJ
	for submit <at> debbugs.gnu.org; Sat, 10 Feb 2024 14:00:35 -0500
Received: from mout.gmx.net ([212.227.15.18]:44737)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1rYsaW-0003vH-DD
 for 69017 <at> debbugs.gnu.org; Sat, 10 Feb 2024 14:00:33 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417;
 t=1707591610; x=1708196410; i=michael.albinus@HIDDEN;
 bh=8tCTF0oKNbO/2+U6zayrBSfs7I8lzkwC6fvIhgEMDkY=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:
 Date;
 b=JTu5xoecB/XTGsOhg93THqC9VIpY6+jSo2zy7yot5iAaKmzmidI6SwcFRdVvf0/X
 eKceDI+csqVlC0aw34r1C/9UkgMfr2l+aqvZ71SqRyjqzkT/DI/6lOU86kqzCQa5n
 AxKi/KCRbmwWZabXY/BYbiz+gerW7l61S1D77WWACej2Idcn5kT5poZCI/VgdrUP5
 n0z7sJn6iM7+2DXb1Jk0g+37+s7MgQXDkzsT29eh7+qUVnS75fy2yGIzMip7fWDtx
 yIn7c1tWCyf1HCjwgmrljRFAzqYNrzIUpOVcYda3Q0u21RI5+XmR9IOabujz7jx7V
 EFzPBxt0pR9aP5LJow==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx005
 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MtfJd-1qi9Yl47Bf-00v9p0; Sat, 10
 Feb 2024 19:54:57 +0100
From: Michael Albinus <michael.albinus@HIDDEN>
To: Eric Abrahamsen <eric@HIDDEN>
Subject: Re: bug#69017: 30.0.50; [debbugs] Make compilation step optional in
 debbugs-gnu-apply-patch
In-Reply-To: <877cjcz04e.fsf@HIDDEN> (Eric Abrahamsen's message of
 "Sat, 10 Feb 2024 09:42:57 -0800")
References: <877cjcz04e.fsf@HIDDEN>
Date: Sat, 10 Feb 2024 19:54:55 +0100
Message-ID: <87plx4b14w.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:K6FSlw+FCRBtjBunS3le2aVp/J5VAI6JFMurJdniqmlFByh9WVK
 qAu4c1fnDogvHzEceMv+MVJ37rrCBZVamkd7Yt6+2xbNwkNtF4br+KxvsDUBCGB+rN6+0nc
 gCbuYoJ3SM12Sb3NwQlpz6UXxyHHTDtFqadNpKSGUAzSVvlOQYZ+W5dYxXTU1aw2c2274/z
 Df9Th+5DiQ5c513+hkwHQ==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:XK9l3y3GuKM=;XfdaXM7vB/4xdqRVsK//R6tAmoq
 iAZ4HK5CT8m7cDhtWwZ3QQfsg+b5KSekc+9AA9b4VldBjlq8v8sQujQxR+EZ+Z4NJlqS/88Cu
 FKlxi2GNqUdvE7DHN4HH07GrJEGhaB8j2R32EfjuvSmXSF+HGS3LwyH8uKC+m4TVSJpKDkU5L
 E2BBepoV94nkg40cUtMOso8sVTDqEY71OVv2G9HOx06bIq7cBVf3DCITp4kzRj67lKegaSSI+
 gCIKxdoLFpo7A8Rn7L6ehRm3oF/LnAUh13EIjT0T+K4iB6NzT2gcup6jzkFBNGsWjS7E+C43u
 GDFJfKYDzsLkBKQ6ca8C4w0EROzwyBPsidAfd2+juTwMVbwRIW0diDQfWaN3rbFRY9RLvJ8Te
 zhM100F7AiGbj9OpzfVE1UAgylxTHt1c5iRHyrT10R83UvQ2csL9SpvO9OoxUupKeVGVnOfZX
 BK5pa9i1cS+5EOmmuVIuyPwrXQMZu5SIB337GhYLcSP4D1nA3HFymUllhRzrX1S+Ov8w1dll/
 GqacoZ+DWOu9DJGxwc6j3ySSkbFbQno0lPPRBzKALP+TbqnpIPNhe+/wZVC4mjcNYidqyETXg
 PqlNuCP+G5f21ch8eBEcXIZKt98B876/ilX9PLM6x5KJqxgKu6iK8lYy9IQRwmyOR1AF/OBtO
 sAXQ+1liZzEWUZgEgYAXEUzAzZuJOXa523hXHTrX6B9CkwdLB0xhp9txECrQ8Typ5hE7CsbQF
 CfSTGGRo+CP8rUa3gBK3XhCGUjKIbGY9lUd3grH5qM6DScYeV+sa2JMG+PvzBfUzu3MuEvovH
 daYExicRBrJQvTtfIujw8+cN2b9JR7aLMzToxHCe8GsfxnMSNbW0AA0EXVno40fcIz
X-Spam-Score: 2.9 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Eric Abrahamsen writes: Hi Eric,
 > I've started using `debbugs-gnu-apply-patch'
 regularly, and find it > enormously useful -- it's particularly nice that
 it handles both inline > patches and attachments. > > I don't love the
 automati [...] 
 Content analysis details:   (2.9 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
 [185.89.39.16 listed in zen.spamhaus.org]
 0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
 [212.227.15.18 listed in wl.mailspike.net]
 -0.0 SPF_PASS               SPF: sender matches SPF record
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (michael.albinus[at]gmx.de)
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
 low trust [212.227.15.18 listed in list.dnswl.org]
 0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
X-Debbugs-Envelope-To: 69017
Cc: 69017 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.9 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Eric Abrahamsen writes: Hi Eric, > I've started using `debbugs-gnu-apply-patch'
    regularly, and find it > enormously useful -- it's particularly nice that
    it handles both inline > patches and attachments. > > I don't love the automati
    [...] 
 
 Content analysis details:   (1.9 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
                             [212.227.15.18 listed in wl.mailspike.net]
  3.6 RCVD_IN_SBL_CSS        RBL: Received via a relay in Spamhaus SBL-CSS
                             [185.89.39.16 listed in zen.spamhaus.org]
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
                             low trust
                             [212.227.15.18 listed in list.dnswl.org]
 -0.0 SPF_PASS               SPF: sender matches SPF record
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (michael.albinus[at]gmx.de)
  0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
  0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

Eric Abrahamsen <eric@HIDDEN> writes:

Hi Eric,

> I've started using `debbugs-gnu-apply-patch' regularly, and find it
> enormously useful -- it's particularly nice that it handles both inline
> patches and attachments.
>
> I don't love the automatic compilation step, though. I pretty much never
> want to go straight to compilation; it is very long; and the windows are
> a mess until it finishes. Even the magit/vc step afterwards is often not
> what I want, as I have Magit already open on Emacs somewhere else.
>
> How about some sort of custom option to control this? Either
> specifically compile-after-apply, or maybe a list of post-apply-actions,
> something like that?

I don't use `debbugs-gnu-apply-patch' by myself, so I have no opinion
about. It was written by Lars for his own workflow.

No objections from my side, if you make some optional changes. And
please document them in debbugs-ug.texi.

> Thanks,
> Eric

Best regards, Michael.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#69017; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 10 Feb 2024 17:53:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 10 12:53:41 2024
Received: from localhost ([127.0.0.1]:58007 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rYrXo-0006c0-PX
	for submit <at> debbugs.gnu.org; Sat, 10 Feb 2024 12:53:41 -0500
Received: from lists.gnu.org ([2001:470:142::17]:42314)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eric@HIDDEN>) id 1rYrXn-0006bR-G1
 for submit <at> debbugs.gnu.org; Sat, 10 Feb 2024 12:53:39 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eric@HIDDEN>)
 id 1rYrNV-0007e8-CI
 for bug-gnu-emacs@HIDDEN; Sat, 10 Feb 2024 12:43:02 -0500
Received: from mail.ericabrahamsen.net ([52.70.2.18])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eric@HIDDEN>)
 id 1rYrNU-0006wJ-1l
 for bug-gnu-emacs@HIDDEN; Sat, 10 Feb 2024 12:43:01 -0500
Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65])
 (Authenticated sender: eric@HIDDEN)
 by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 5D3F7FA0B2
 for <bug-gnu-emacs@HIDDEN>; Sat, 10 Feb 2024 17:42:58 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net;
 s=mail; t=1707586978;
 bh=M2EA0qbADBmF7n+EjTPNHQFZ9SnzncGLs3AA//fiMbg=;
 h=From:To:Subject:Date:From;
 b=pA1+wSEc/hctpyD0xWtxqaDbxzshC6TGO+H8T636+cQtZ2tBKp7li7SzTm+RWxxoj
 1e+1+6/pN0sqrgnjiDs0rjLa5LT5Wn10KlDcDyFd84o3ZP7ZoZL8a5x2aXVo+E/rmM
 v2YEbMYXoPAwD5R+HLTn+jLeiDofZOWUCrEBbC7o=
From: Eric Abrahamsen <eric@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 30.0.50; [debbugs] Make compilation step optional in
 debbugs-gnu-apply-patch
X-Debbugs-Cc: 
Date: Sat, 10 Feb 2024 09:42:57 -0800
Message-ID: <877cjcz04e.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@HIDDEN;
 helo=mail.ericabrahamsen.net
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)


I've started using `debbugs-gnu-apply-patch' regularly, and find it
enormously useful -- it's particularly nice that it handles both inline
patches and attachments.

I don't love the automatic compilation step, though. I pretty much never
want to go straight to compilation; it is very long; and the windows are
a mess until it finishes. Even the magit/vc step afterwards is often not
what I want, as I have Magit already open on Emacs somewhere else.

How about some sort of custom option to control this? Either
specifically compile-after-apply, or maybe a list of post-apply-actions,
something like that?

Thanks,
Eric




Acknowledgement sent to Eric Abrahamsen <eric@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#69017; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 10 Feb 2024 21:00:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.