Eli Zaretskii <eliz@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 69067) by debbugs.gnu.org; 12 Feb 2024 14:44:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 12 09:44:05 2024 Received: from localhost ([127.0.0.1]:60539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rZXXO-00050J-MW for submit <at> debbugs.gnu.org; Mon, 12 Feb 2024 09:44:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rZXXL-0004zE-Qz; Mon, 12 Feb 2024 09:44:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rZX2T-0002ha-8c; Mon, 12 Feb 2024 09:12:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fWckrno8aHxGfF3edgwGXCOd7+RS3QkgDB9bcy5vzLY=; b=fEQMgM3rmczD 3EobM72jjz/IdiDUg+7TTk2L5RLwb1/+HQEkdETRME9cixJSlv03y+bLSiOeAz2jfYAtP1IC8GGxd NLEzAkZjVpJ7+Xgr0CoIscmnPbjEQXhYsKOTTypaQLIJe+kEPVaapx9/0uVg13NKKSlnBYAJWNpIV 7sKJ5+GWQiSRUANmxF0HVZQ+5xALI9f64tLidUZChaMPj5Dg9pl9CpgUSvgevSRFzj9VvKBsfFOpZ wt75Y4mDpNE3tBQIbnFwBGOQUKTMl7/mAabk03Nl+myvpBzXbSW81IlXrmxrFLYzod3awecRXmD4q ZKOv7yTr9d7tNU2Wbacd5w==; Date: Mon, 12 Feb 2024 16:12:02 +0200 Message-Id: <8634txsrf1.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Evgeny Gagauz <evgenij.gagauz@HIDDEN> In-Reply-To: <20240212005630.1298-1-evgenij.gagauz@HIDDEN> (message from Evgeny Gagauz on Mon, 12 Feb 2024 01:56:30 +0100) Subject: Re: bug#69067: [PATCH] Fix compilation filtration if carriage is moved References: <20240212005630.1298-1-evgenij.gagauz@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69067 Cc: 69067 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) merge 69067 69066 thanks > Cc: Evgeny Gagauz <evgenij.gagauz@HIDDEN> > From: Evgeny Gagauz <evgenij.gagauz@HIDDEN> > Date: Mon, 12 Feb 2024 01:56:30 +0100 > > * lisp/progmodes/compile.el (compilation-filter): If a process produces > carriage cotrol characters then `compilation-filter-start' could point > to a wrong place after applying `comint-carriage-motion' > function. So its value is recalculated. This is a duplicate of bug#69066. Merging.
bug-gnu-emacs@HIDDEN:bug#69067; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 12 Feb 2024 05:35:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 12 00:35:08 2024
Received: from localhost ([127.0.0.1]:55930 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rZOyB-0001GV-VD
for submit <at> debbugs.gnu.org; Mon, 12 Feb 2024 00:35:08 -0500
Received: from lists.gnu.org ([2001:470:142::17]:42638)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <evgenij.gagauz@HIDDEN>) id 1rZKd4-0005K6-4G
for submit <at> debbugs.gnu.org; Sun, 11 Feb 2024 19:57:02 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <evgenij.gagauz@HIDDEN>)
id 1rZKci-0003qT-Az
for bug-gnu-emacs@HIDDEN; Sun, 11 Feb 2024 19:56:40 -0500
Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <evgenij.gagauz@HIDDEN>)
id 1rZKcg-0000ra-S9
for bug-gnu-emacs@HIDDEN; Sun, 11 Feb 2024 19:56:40 -0500
Received: by mail-lf1-x135.google.com with SMTP id
2adb3069b0e04-511570b2f49so3206922e87.1
for <bug-gnu-emacs@HIDDEN>; Sun, 11 Feb 2024 16:56:38 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1707699396; x=1708304196; darn=gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=p2QRk7xFR/1mxbERzN6fSlFOi0oPn/RLDheWZx2futw=;
b=QM2CM6DOmhtx+g/12/Im+9DRKOp1qQ0fdh1WZeccpVeVFn6YFHwhdJf4UdiKaOYyGz
SQUlBRDKwadL+Q2E93HDh7PN9u5Y4U5YSgVkob//i1CH/Kb2cKVI0wr7IObvev49YsRd
nl16feOhvb+SBl/9W2WW3aUyIPPdURS6g/EXJ6FpG4fM4SVE0c6GcF8yeOQGZEjfQcVX
Qn3DtX4bs51tVZYJc2hWybmIhVSV/xol2hO5hv7VjE1jWBcAVpjMnZ7F5B08WU/Y9x9t
BOXEvehMBqHvpw8ABvYl3pFRpDQ4r2WKPOU+gM1usg6C2O5O4G70yfssDTIrhtwgH5Zt
937Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1707699396; x=1708304196;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=p2QRk7xFR/1mxbERzN6fSlFOi0oPn/RLDheWZx2futw=;
b=CMkTvNa9jYavSOfkoIsnBK2gYccGou/9H3YOZ0KjiM1lDEaHrgEaUphr/BArvIE4gH
4PlQofliJIu+tOs/9kuQ+IalBYuvpsRT3OPl8ELYbKFVHQP4IvFFkfpiGPq5IuNMtJ2F
3rHjzdOY3mfLKpFZ/j8lFIzmCeZIlADd0NqOqMHIwHhGQFDRvzJP1A35Hy7jrPoCNHRI
ZyFpMI4/DnxkAMn26I0wYvIippgPRSz8Az8shKiYWEPemYMpdrltpCTHGod1iTmv0/mm
bH+QdfnLnhqKWYPXO571AcRn2ncOPkS7Pv5nabKuo+z9payDwoQAM21vJfu+Wk59qhoG
5WGA==
X-Gm-Message-State: AOJu0YyUvzPXqD4O1478lVV4W5a0Qx+Oa78dNVdIvNLz+sZSDZmziexz
IRbQnhwfqeU+uIamnjf1D0btgFmlHy5K8G+u9pFpvyGkE84sL5/mPpsAQ9Y4PF4=
X-Google-Smtp-Source: AGHT+IFaEKe6dupdWsGbO2asBu3O1fEsMDmTUJgYLZyzbs/Y8RGMY5H1EpWneYUECmAyc3XJzWktLA==
X-Received: by 2002:a19:6404:0:b0:511:67d4:5590 with SMTP id
y4-20020a196404000000b0051167d45590mr1558689lfb.33.1707699395699;
Sun, 11 Feb 2024 16:56:35 -0800 (PST)
Received: from gagauzev-osx2.yandex.net ([2a02:6b8:b081:8032::1:17])
by smtp.gmail.com with ESMTPSA id
t27-20020ac2549b000000b0051185ae815esm513349lfk.110.2024.02.11.16.56.34
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 11 Feb 2024 16:56:34 -0800 (PST)
From: Evgeny Gagauz <evgenij.gagauz@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Fix compilation filtration if carriage is moved
Date: Mon, 12 Feb 2024 01:56:30 +0100
Message-Id: <20240212005630.1298-1-evgenij.gagauz@HIDDEN>
X-Mailer: git-send-email 2.39.3 (Apple Git-145)
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::135;
envelope-from=evgenij.gagauz@HIDDEN; helo=mail-lf1-x135.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Mon, 12 Feb 2024 00:33:03 -0500
Cc: Evgeny Gagauz <evgenij.gagauz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
* lisp/progmodes/compile.el (compilation-filter): If a process produces
carriage cotrol characters then `compilation-filter-start' could point
to a wrong place after applying `comint-carriage-motion'
function. So its value is recalculated.
---
lisp/progmodes/compile.el | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 11d400e145a..90ff414ad41 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -2600,7 +2600,10 @@ and runs `compilation-filter-hook'."
(when compilation-hidden-output
(compilation--hide-output compilation-filter-start))
(unless comint-inhibit-carriage-motion
- (comint-carriage-motion (process-mark proc) (point)))
+ (comint-carriage-motion (process-mark proc) (point))
+ ;; `compilation-filter-start' could be moved after
+ ;; interpreting carriage control characters
+ (setq compilation-filter-start (marker-position (process-mark proc))))
(set-marker (process-mark proc) (point))
;; Update the number of errors in compilation-mode-line-errors
(compilation--ensure-parse (point))
--
2.39.3 (Apple Git-145)
Evgeny Gagauz <evgenij.gagauz@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#69067; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.