GNU bug report logs - #69068
[PATCH] gnu: kitsas: Update to 5.4.1

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Saku Laesvuori <saku@HIDDEN>; Keywords: patch; dated Mon, 12 Feb 2024 07:06:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 69068 <at> debbugs.gnu.org:


Received: (at 69068) by debbugs.gnu.org; 13 Feb 2024 12:18:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 13 07:18:20 2024
Received: from localhost ([127.0.0.1]:42542 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rZrjw-00013E-Eh
	for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 07:18:20 -0500
Received: from vmi571514.contaboserver.net ([75.119.130.101]:44278
 helo=mail.laesvuori.fi) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <saku@HIDDEN>) id 1rZrju-000133-Bo
 for 69068 <at> debbugs.gnu.org; Tue, 13 Feb 2024 07:18:19 -0500
Received: from X-kone (unknown [130.233.144.187])
 by mail.laesvuori.fi (Postfix) with ESMTPSA id 0073F3400E1;
 Tue, 13 Feb 2024 13:18:35 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=laesvuori.fi; s=mail;
 t=1707826716; bh=meAmSi/3IWG1SKzIUWcROlbYKpcngDwM+3mm573wXPk=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To;
 b=K2+v31/jOXNZEZW475VtKhb7xm8NiPGwNiUxMPwUH7PA44AiM2YYyLDHNnxY+Gz8D
 7m4DuvGz6hcw3XjIl7tiT2u6gTgNqoUCJosc3fcIiVj3s4enKCO5j48esECfsSXXva
 uogc/s89JpVlixZKzjS5pU0Q4peMl7BvdsGsxn68=
Date: Tue, 13 Feb 2024 14:17:56 +0200
From: Saku Laesvuori <saku@HIDDEN>
To: Christopher Baines <mail@HIDDEN>
Subject: Re: [bug#69068] [PATCH] gnu: kitsas: Update to 5.4.1
Message-ID: <vhbrghoe6nxihld727nqxmueu2qvya74q2soaycpd2kbfl7vpq@bu2bkm3rl46n>
References: <e21c3633ace452c4d3eaecb8d843674ce1369b99.1707721437.git.saku@HIDDEN>
 <87le7obnxl.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="3gdmtymtotssz4mx"
Content-Disposition: inline
In-Reply-To: <87le7obnxl.fsf@HIDDEN>
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 69068
Cc: 69068 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--3gdmtymtotssz4mx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 13, 2024 at 11:30:50AM +0000, Christopher Baines wrote:
>=20
> Saku Laesvuori via Guix-patches via <guix-patches@HIDDEN> writes:
>=20
> > * gnu/packages/finance.scm (kitsas): Update to 5.4.1.
> >
> > Change-Id: I968579d762ebecef9f9e8b602682587a054c41ad
> > ---
> >  gnu/packages/finance.scm | 13 ++++++++++---
> >  1 file changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
> > index 98a220385b..96e2729dda 100644
> > --- a/gnu/packages/finance.scm
> > +++ b/gnu/packages/finance.scm
> > @@ -1307,7 +1307,7 @@ (define-public keepkey-agent
> >  (define-public kitsas
> >    (package
> >      (name "kitsas")
> > -    (version "4.0.3")
> > +    (version "5.4.1")
> >      (source (origin
> >                (method git-fetch)
> >                (uri (git-reference
> > @@ -1316,17 +1316,24 @@ (define-public kitsas
> >                (file-name (git-file-name name version))
> >                (sha256
> >                 (base32
> > -                "0hrbsqqm6v2pmjq17s7i4akjgclz3d051mg02vcykq80xgxvbkgf"=
))))
> > +                "16zkfpl5d9ia202fqg5vrhjqdw0g6wp044ih6n7nz2hbxj9y3m1z"=
))))
> >      (build-system qt-build-system)
> > -    (inputs (list qtbase-5 libzip poppler-qt5 qtsvg-5))
> > +    (inputs (list libzip qtsvg qtwebengine qt5compat))
> >      (arguments
> >       (list #:tests? #f               ;XXX: some tests fail and others =
segfault
> >             #:test-target "check"
> > +           #:qtbase qtbase
> >             #:phases
> >             #~(modify-phases %standard-phases
> >                 (replace 'configure
> >                   (lambda* _
> >                     (invoke "qmake" "kitsasproject.pro" "CONFIG+=3Drele=
ase")))
> > +               ;; The tests are not maintained and some don't even bui=
ld
> > +               (add-before 'configure 'disable-broken-tests
> > +                 (lambda _
> > +                   (substitute* "kitsasproject.pro"
> > +                     ((" *(unittest|testit).*") "")
> > +                     (("\\\\") ""))))
> >                 (replace 'install
> >                   (lambda* _
> >                     (install-file "kitsas/kitsas"
> >
> > base-commit: f2102cb5b9239be2ed2023b908b726af542e0124
>=20
> The commit message is missing information on the non-version changes to
> the package.

All the changes are part of updating the package. The new version is
built against Qt6 and requires different inputs, which also makes
compiling the tests fail as they are not maintained to work with those
new inputs. Earlier just passing #:tests? #f was sufficient to bypass
them because they compiled fine and only failed when ran.

I can try to write a better commit message if you tell which parts
require their own lines, or you can clarify it yourself when applying.

> In particular, the removal of qtbase from inputs confuses me, is this
> not needed?

It is added implicitly by qt-build-system based on the #:qtbase
argument. I don't know if qt-build-system worked like that when I
submitted the first version of this package, but it probably did and I
just didn't realize it.

--3gdmtymtotssz4mx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEoMkZR3NPB29fCOn/JX0oSiodOjIFAmXLXfQACgkQJX0oSiod
OjLB4Q//QHYlKGNx8asB0DpODqZ0CzbNL/i2QdPVetvNBolZVxlO397ag3u/tl4a
qofXykQs2wzXmCshtYpijf0QHmxvopjn2gqow8qBy2q7WiDFk//yWMhu59HvxaFv
WxGZfoFBJS6Y6Y5Kl9aaP2ktY9U/JUbZp+HEW5tyPeH+XYCr2zs19CHKzF1JYB1M
vChj18itlktjcmdzsIcBgajOnh2mi4hGDcqTOYtMtH05ZDPiAvdoVNOjJqx3OpIp
puzANaygK5rArD82LHwW4A7R4BfK6YtH5H/RxW/JKP8PpC2d7TDeVkLYb2xSvRHy
9oIqb3myI1OHSnmqdWJ0ZOr6wkFXtdO20j+LuCFrGDD1Dl4ifM4TH5Vb+MoTzSR9
uqjG6yLsYd3+v2rmsyYuaHisZvmuHwZtw/Wm2mUplj1lw/mxwLTMSp9YZtI9oZB0
TnWbr6ftfAiosTuyjLwL1MSDzD/5r4jhUHTQNrfeWhkugOljI36qYO5IheZ8ZoJ6
Cql5Dkgy4sRcN2Swpw7OKm8/io2YbZIU4F3CiE7Wx6dgWUpFEehGm+EgMYE8avvp
R4TIPVzFazRDt+uFXYJD5JwMTCd8h8GXsPUxLeffRHh7sIMGUMdFvdGQL87IPNxc
v9GZDW7LvmX4IIPUehIS3xyowRFZR1kVNx6h5KHVSTRxgFylTmw=
=sqFZ
-----END PGP SIGNATURE-----

--3gdmtymtotssz4mx--




Information forwarded to guix-patches@HIDDEN:
bug#69068; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 13 Feb 2024 12:18:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 13 07:18:29 2024
Received: from localhost ([127.0.0.1]:42546 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rZrk4-00013d-UG
	for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 07:18:29 -0500
Received: from lists.gnu.org ([209.51.188.17]:60292)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <saku@HIDDEN>) id 1rZrk2-00013T-S1
 for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 07:18:27 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <saku@HIDDEN>) id 1rZrjj-0002fT-1T
 for guix-patches@HIDDEN; Tue, 13 Feb 2024 07:18:08 -0500
Received: from vmi571514.contaboserver.net ([75.119.130.101]
 helo=mail.laesvuori.fi)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <saku@HIDDEN>) id 1rZrjf-0005D7-43
 for guix-patches@HIDDEN; Tue, 13 Feb 2024 07:18:06 -0500
Received: from X-kone (unknown [130.233.144.187])
 by mail.laesvuori.fi (Postfix) with ESMTPSA id 0073F3400E1;
 Tue, 13 Feb 2024 13:18:35 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=laesvuori.fi; s=mail;
 t=1707826716; bh=meAmSi/3IWG1SKzIUWcROlbYKpcngDwM+3mm573wXPk=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To;
 b=K2+v31/jOXNZEZW475VtKhb7xm8NiPGwNiUxMPwUH7PA44AiM2YYyLDHNnxY+Gz8D
 7m4DuvGz6hcw3XjIl7tiT2u6gTgNqoUCJosc3fcIiVj3s4enKCO5j48esECfsSXXva
 uogc/s89JpVlixZKzjS5pU0Q4peMl7BvdsGsxn68=
Date: Tue, 13 Feb 2024 14:17:56 +0200
From: Saku Laesvuori <saku@HIDDEN>
To: Christopher Baines <mail@HIDDEN>
Subject: Re: [bug#69068] [PATCH] gnu: kitsas: Update to 5.4.1
Message-ID: <vhbrghoe6nxihld727nqxmueu2qvya74q2soaycpd2kbfl7vpq@bu2bkm3rl46n>
References: <e21c3633ace452c4d3eaecb8d843674ce1369b99.1707721437.git.saku@HIDDEN>
 <87le7obnxl.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="3gdmtymtotssz4mx"
Content-Disposition: inline
In-Reply-To: <87le7obnxl.fsf@HIDDEN>
Received-SPF: pass client-ip=75.119.130.101; envelope-from=saku@HIDDEN;
 helo=mail.laesvuori.fi
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_PDS_PRO_TLD=0.01,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: 69068 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)


--3gdmtymtotssz4mx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 13, 2024 at 11:30:50AM +0000, Christopher Baines wrote:
>=20
> Saku Laesvuori via Guix-patches via <guix-patches@HIDDEN> writes:
>=20
> > * gnu/packages/finance.scm (kitsas): Update to 5.4.1.
> >
> > Change-Id: I968579d762ebecef9f9e8b602682587a054c41ad
> > ---
> >  gnu/packages/finance.scm | 13 ++++++++++---
> >  1 file changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
> > index 98a220385b..96e2729dda 100644
> > --- a/gnu/packages/finance.scm
> > +++ b/gnu/packages/finance.scm
> > @@ -1307,7 +1307,7 @@ (define-public keepkey-agent
> >  (define-public kitsas
> >    (package
> >      (name "kitsas")
> > -    (version "4.0.3")
> > +    (version "5.4.1")
> >      (source (origin
> >                (method git-fetch)
> >                (uri (git-reference
> > @@ -1316,17 +1316,24 @@ (define-public kitsas
> >                (file-name (git-file-name name version))
> >                (sha256
> >                 (base32
> > -                "0hrbsqqm6v2pmjq17s7i4akjgclz3d051mg02vcykq80xgxvbkgf"=
))))
> > +                "16zkfpl5d9ia202fqg5vrhjqdw0g6wp044ih6n7nz2hbxj9y3m1z"=
))))
> >      (build-system qt-build-system)
> > -    (inputs (list qtbase-5 libzip poppler-qt5 qtsvg-5))
> > +    (inputs (list libzip qtsvg qtwebengine qt5compat))
> >      (arguments
> >       (list #:tests? #f               ;XXX: some tests fail and others =
segfault
> >             #:test-target "check"
> > +           #:qtbase qtbase
> >             #:phases
> >             #~(modify-phases %standard-phases
> >                 (replace 'configure
> >                   (lambda* _
> >                     (invoke "qmake" "kitsasproject.pro" "CONFIG+=3Drele=
ase")))
> > +               ;; The tests are not maintained and some don't even bui=
ld
> > +               (add-before 'configure 'disable-broken-tests
> > +                 (lambda _
> > +                   (substitute* "kitsasproject.pro"
> > +                     ((" *(unittest|testit).*") "")
> > +                     (("\\\\") ""))))
> >                 (replace 'install
> >                   (lambda* _
> >                     (install-file "kitsas/kitsas"
> >
> > base-commit: f2102cb5b9239be2ed2023b908b726af542e0124
>=20
> The commit message is missing information on the non-version changes to
> the package.

All the changes are part of updating the package. The new version is
built against Qt6 and requires different inputs, which also makes
compiling the tests fail as they are not maintained to work with those
new inputs. Earlier just passing #:tests? #f was sufficient to bypass
them because they compiled fine and only failed when ran.

I can try to write a better commit message if you tell which parts
require their own lines, or you can clarify it yourself when applying.

> In particular, the removal of qtbase from inputs confuses me, is this
> not needed?

It is added implicitly by qt-build-system based on the #:qtbase
argument. I don't know if qt-build-system worked like that when I
submitted the first version of this package, but it probably did and I
just didn't realize it.

--3gdmtymtotssz4mx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEoMkZR3NPB29fCOn/JX0oSiodOjIFAmXLXfQACgkQJX0oSiod
OjLB4Q//QHYlKGNx8asB0DpODqZ0CzbNL/i2QdPVetvNBolZVxlO397ag3u/tl4a
qofXykQs2wzXmCshtYpijf0QHmxvopjn2gqow8qBy2q7WiDFk//yWMhu59HvxaFv
WxGZfoFBJS6Y6Y5Kl9aaP2ktY9U/JUbZp+HEW5tyPeH+XYCr2zs19CHKzF1JYB1M
vChj18itlktjcmdzsIcBgajOnh2mi4hGDcqTOYtMtH05ZDPiAvdoVNOjJqx3OpIp
puzANaygK5rArD82LHwW4A7R4BfK6YtH5H/RxW/JKP8PpC2d7TDeVkLYb2xSvRHy
9oIqb3myI1OHSnmqdWJ0ZOr6wkFXtdO20j+LuCFrGDD1Dl4ifM4TH5Vb+MoTzSR9
uqjG6yLsYd3+v2rmsyYuaHisZvmuHwZtw/Wm2mUplj1lw/mxwLTMSp9YZtI9oZB0
TnWbr6ftfAiosTuyjLwL1MSDzD/5r4jhUHTQNrfeWhkugOljI36qYO5IheZ8ZoJ6
Cql5Dkgy4sRcN2Swpw7OKm8/io2YbZIU4F3CiE7Wx6dgWUpFEehGm+EgMYE8avvp
R4TIPVzFazRDt+uFXYJD5JwMTCd8h8GXsPUxLeffRHh7sIMGUMdFvdGQL87IPNxc
v9GZDW7LvmX4IIPUehIS3xyowRFZR1kVNx6h5KHVSTRxgFylTmw=
=sqFZ
-----END PGP SIGNATURE-----

--3gdmtymtotssz4mx--




Information forwarded to guix-patches@HIDDEN:
bug#69068; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 13 Feb 2024 11:32:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 13 06:32:02 2024
Received: from localhost ([127.0.0.1]:42249 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rZr18-0007Yg-1c
	for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 06:32:02 -0500
Received: from lists.gnu.org ([209.51.188.17]:43070)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1rZr16-0007YR-C9
 for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 06:32:00 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1rZr0l-0007Wt-4P
 for guix-patches@HIDDEN; Tue, 13 Feb 2024 06:31:39 -0500
Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27])
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@HIDDEN>) id 1rZr0j-0003dl-B9
 for guix-patches@HIDDEN; Tue, 13 Feb 2024 06:31:38 -0500
Received: from localhost (unknown [212.132.255.10])
 by mira.cbaines.net (Postfix) with ESMTPSA id 21FA227BBE2;
 Tue, 13 Feb 2024 11:31:36 +0000 (GMT)
Received: from felis (localhost.lan [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id aa2ca4f1;
 Tue, 13 Feb 2024 11:31:35 +0000 (UTC)
References: <e21c3633ace452c4d3eaecb8d843674ce1369b99.1707721437.git.saku@HIDDEN>
User-agent: mu4e 1.10.7; emacs 29.1
From: Christopher Baines <mail@HIDDEN>
To: Saku Laesvuori <saku@HIDDEN>
Subject: Re: [bug#69068] [PATCH] gnu: kitsas: Update to 5.4.1
Date: Tue, 13 Feb 2024 11:30:50 +0000
In-reply-to: <e21c3633ace452c4d3eaecb8d843674ce1369b99.1707721437.git.saku@HIDDEN>
Message-ID: <87le7obnxl.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27;
 envelope-from=mail@HIDDEN; helo=mira.cbaines.net
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_PDS_PRO_TLD=0.01,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: 69068 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=-=-=
Content-Type: text/plain


Saku Laesvuori via Guix-patches via <guix-patches@HIDDEN> writes:

> * gnu/packages/finance.scm (kitsas): Update to 5.4.1.
>
> Change-Id: I968579d762ebecef9f9e8b602682587a054c41ad
> ---
>  gnu/packages/finance.scm | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
> index 98a220385b..96e2729dda 100644
> --- a/gnu/packages/finance.scm
> +++ b/gnu/packages/finance.scm
> @@ -1307,7 +1307,7 @@ (define-public keepkey-agent
>  (define-public kitsas
>    (package
>      (name "kitsas")
> -    (version "4.0.3")
> +    (version "5.4.1")
>      (source (origin
>                (method git-fetch)
>                (uri (git-reference
> @@ -1316,17 +1316,24 @@ (define-public kitsas
>                (file-name (git-file-name name version))
>                (sha256
>                 (base32
> -                "0hrbsqqm6v2pmjq17s7i4akjgclz3d051mg02vcykq80xgxvbkgf"))))
> +                "16zkfpl5d9ia202fqg5vrhjqdw0g6wp044ih6n7nz2hbxj9y3m1z"))))
>      (build-system qt-build-system)
> -    (inputs (list qtbase-5 libzip poppler-qt5 qtsvg-5))
> +    (inputs (list libzip qtsvg qtwebengine qt5compat))
>      (arguments
>       (list #:tests? #f               ;XXX: some tests fail and others segfault
>             #:test-target "check"
> +           #:qtbase qtbase
>             #:phases
>             #~(modify-phases %standard-phases
>                 (replace 'configure
>                   (lambda* _
>                     (invoke "qmake" "kitsasproject.pro" "CONFIG+=release")))
> +               ;; The tests are not maintained and some don't even build
> +               (add-before 'configure 'disable-broken-tests
> +                 (lambda _
> +                   (substitute* "kitsasproject.pro"
> +                     ((" *(unittest|testit).*") "")
> +                     (("\\\\") ""))))
>                 (replace 'install
>                   (lambda* _
>                     (install-file "kitsas/kitsas"
>
> base-commit: f2102cb5b9239be2ed2023b908b726af542e0124

The commit message is missing information on the non-version changes to
the package.

In particular, the removal of qtbase from inputs confuses me, is this
not needed?

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmXLUxZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XeGNQ/9HkhE4DLgiugTZmnIq1p8n7juRqSiinZT
eQ/2KEZ77d5FxrieLUQI5bg+xM0DlTqw7kI54m9cyZpmNydjeMqSpy9hTyVodz49
Makj0S8l8/rFLaL6/iQHWMaBQ5N1N0cLvGOAlTPegImYQFf8tPthAOrjewDds0Zc
TTZNPn2t4P1Vfp44kEYKqegtiVTK8wIP3raVgxd02SClcPSqxATWWxk2uvgx/nuc
Tqa9XwhiPev7TUylNYfKPttweq3xfENzNJqvWLkOweILg3CeJyKAem9joZ8lXiG1
jBn/JoKLw/cIbw6Yg3l+USJRqPj9uTIy/weHAqLvOSfWsU7A6Af2dBew7xPP6m4b
k41yHB5uar9ilLHBYYOpFEVJFJVYzZXlz9XmMSLd4A5jq2fxggwQHruiV/u4x2Oi
f5EZjWRueCQQJFzX88+uiFOBgq8j0IQ/WTTgp2wWnkTJm8VNoQ7YjIaD0gZUfwiz
anBC6Ck7kZ94vFHNC5wHOdQBjkFOR5ktnBKw2XlgG5xF15pKWmROHJCqnGNbhXxc
WBo/Cz7b//X9FFeY4q+B+1up23KgavBgaiWd9FnXzva5ytFLepqUnT+mUImAVH3p
cvw6YohRJqGZwT+iQrYOXVNIaa14n3CQnyy4hhiKfjvYQOf4o0KzhrPmTfcsLtYV
vruVuRT1odA=
=ASbU
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#69068; Package guix-patches. Full text available.

Message received at 69068 <at> debbugs.gnu.org:


Received: (at 69068) by debbugs.gnu.org; 13 Feb 2024 11:31:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 13 06:31:58 2024
Received: from localhost ([127.0.0.1]:42246 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rZr13-0007YB-Lv
	for submit <at> debbugs.gnu.org; Tue, 13 Feb 2024 06:31:57 -0500
Received: from mira.cbaines.net ([212.71.252.8]:43112)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1rZr10-0007Xx-FC
 for 69068 <at> debbugs.gnu.org; Tue, 13 Feb 2024 06:31:55 -0500
Received: from localhost (unknown [212.132.255.10])
 by mira.cbaines.net (Postfix) with ESMTPSA id 21FA227BBE2;
 Tue, 13 Feb 2024 11:31:36 +0000 (GMT)
Received: from felis (localhost.lan [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id aa2ca4f1;
 Tue, 13 Feb 2024 11:31:35 +0000 (UTC)
References: <e21c3633ace452c4d3eaecb8d843674ce1369b99.1707721437.git.saku@HIDDEN>
User-agent: mu4e 1.10.7; emacs 29.1
From: Christopher Baines <mail@HIDDEN>
To: Saku Laesvuori <saku@HIDDEN>
Subject: Re: [bug#69068] [PATCH] gnu: kitsas: Update to 5.4.1
Date: Tue, 13 Feb 2024 11:30:50 +0000
In-reply-to: <e21c3633ace452c4d3eaecb8d843674ce1369b99.1707721437.git.saku@HIDDEN>
Message-ID: <87le7obnxl.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 69068
Cc: 69068 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain


Saku Laesvuori via Guix-patches via <guix-patches@HIDDEN> writes:

> * gnu/packages/finance.scm (kitsas): Update to 5.4.1.
>
> Change-Id: I968579d762ebecef9f9e8b602682587a054c41ad
> ---
>  gnu/packages/finance.scm | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
> index 98a220385b..96e2729dda 100644
> --- a/gnu/packages/finance.scm
> +++ b/gnu/packages/finance.scm
> @@ -1307,7 +1307,7 @@ (define-public keepkey-agent
>  (define-public kitsas
>    (package
>      (name "kitsas")
> -    (version "4.0.3")
> +    (version "5.4.1")
>      (source (origin
>                (method git-fetch)
>                (uri (git-reference
> @@ -1316,17 +1316,24 @@ (define-public kitsas
>                (file-name (git-file-name name version))
>                (sha256
>                 (base32
> -                "0hrbsqqm6v2pmjq17s7i4akjgclz3d051mg02vcykq80xgxvbkgf"))))
> +                "16zkfpl5d9ia202fqg5vrhjqdw0g6wp044ih6n7nz2hbxj9y3m1z"))))
>      (build-system qt-build-system)
> -    (inputs (list qtbase-5 libzip poppler-qt5 qtsvg-5))
> +    (inputs (list libzip qtsvg qtwebengine qt5compat))
>      (arguments
>       (list #:tests? #f               ;XXX: some tests fail and others segfault
>             #:test-target "check"
> +           #:qtbase qtbase
>             #:phases
>             #~(modify-phases %standard-phases
>                 (replace 'configure
>                   (lambda* _
>                     (invoke "qmake" "kitsasproject.pro" "CONFIG+=release")))
> +               ;; The tests are not maintained and some don't even build
> +               (add-before 'configure 'disable-broken-tests
> +                 (lambda _
> +                   (substitute* "kitsasproject.pro"
> +                     ((" *(unittest|testit).*") "")
> +                     (("\\\\") ""))))
>                 (replace 'install
>                   (lambda* _
>                     (install-file "kitsas/kitsas"
>
> base-commit: f2102cb5b9239be2ed2023b908b726af542e0124

The commit message is missing information on the non-version changes to
the package.

In particular, the removal of qtbase from inputs confuses me, is this
not needed?

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmXLUxZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9XeGNQ/9HkhE4DLgiugTZmnIq1p8n7juRqSiinZT
eQ/2KEZ77d5FxrieLUQI5bg+xM0DlTqw7kI54m9cyZpmNydjeMqSpy9hTyVodz49
Makj0S8l8/rFLaL6/iQHWMaBQ5N1N0cLvGOAlTPegImYQFf8tPthAOrjewDds0Zc
TTZNPn2t4P1Vfp44kEYKqegtiVTK8wIP3raVgxd02SClcPSqxATWWxk2uvgx/nuc
Tqa9XwhiPev7TUylNYfKPttweq3xfENzNJqvWLkOweILg3CeJyKAem9joZ8lXiG1
jBn/JoKLw/cIbw6Yg3l+USJRqPj9uTIy/weHAqLvOSfWsU7A6Af2dBew7xPP6m4b
k41yHB5uar9ilLHBYYOpFEVJFJVYzZXlz9XmMSLd4A5jq2fxggwQHruiV/u4x2Oi
f5EZjWRueCQQJFzX88+uiFOBgq8j0IQ/WTTgp2wWnkTJm8VNoQ7YjIaD0gZUfwiz
anBC6Ck7kZ94vFHNC5wHOdQBjkFOR5ktnBKw2XlgG5xF15pKWmROHJCqnGNbhXxc
WBo/Cz7b//X9FFeY4q+B+1up23KgavBgaiWd9FnXzva5ytFLepqUnT+mUImAVH3p
cvw6YohRJqGZwT+iQrYOXVNIaa14n3CQnyy4hhiKfjvYQOf4o0KzhrPmTfcsLtYV
vruVuRT1odA=
=ASbU
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#69068; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 12 Feb 2024 07:05:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 12 02:05:48 2024
Received: from localhost ([127.0.0.1]:33298 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rZQNw-0005wR-4H
	for submit <at> debbugs.gnu.org; Mon, 12 Feb 2024 02:05:48 -0500
Received: from lists.gnu.org ([2001:470:142::17]:56326)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <saku@HIDDEN>) id 1rZQNt-0005w2-Gc
 for submit <at> debbugs.gnu.org; Mon, 12 Feb 2024 02:05:46 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <saku@HIDDEN>) id 1rZQNW-0005Bd-MA
 for guix-patches@HIDDEN; Mon, 12 Feb 2024 02:05:22 -0500
Received: from vmi571514.contaboserver.net ([75.119.130.101]
 helo=mail.laesvuori.fi)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <saku@HIDDEN>) id 1rZQNU-00052y-B1
 for guix-patches@HIDDEN; Mon, 12 Feb 2024 02:05:21 -0500
Received: from X-kone.org.aalto.fi (unknown [130.233.144.131])
 by mail.laesvuori.fi (Postfix) with ESMTPSA id 76777342FBD;
 Mon, 12 Feb 2024 08:05:52 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=laesvuori.fi; s=mail;
 t=1707721552; bh=F3Bf7v7rZNmR01NJLUGi4CrSkUVGVF6dNU25BxScZ+U=;
 h=From:To:Cc:Subject:Date;
 b=fIVQ+2j3YHD4yFqZLJMIMjPlDts0qwqZJ1qEZm+FZLkHKpIsWmVOsNEuQLtsaaR91
 aje1vSLQ79LUmZ7JGXam+U5NNJvYwqkKz3kwAQcLKQNv+q5nNwNIBG4f/MBMAaaV1t
 3bCNB4QCqWRPrigiB/v+6ZPcv/1n+gcJdLNgrJQE=
From: Saku Laesvuori <saku@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: kitsas: Update to 5.4.1
Date: Mon, 12 Feb 2024 09:03:57 +0200
Message-ID: <e21c3633ace452c4d3eaecb8d843674ce1369b99.1707721437.git.saku@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=75.119.130.101; envelope-from=saku@HIDDEN;
 helo=mail.laesvuori.fi
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_PDS_PRO_TLD=0.01,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
Cc: Saku Laesvuori <saku@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

* gnu/packages/finance.scm (kitsas): Update to 5.4.1.

Change-Id: I968579d762ebecef9f9e8b602682587a054c41ad
---
 gnu/packages/finance.scm | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 98a220385b..96e2729dda 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -1307,7 +1307,7 @@ (define-public keepkey-agent
 (define-public kitsas
   (package
     (name "kitsas")
-    (version "4.0.3")
+    (version "5.4.1")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -1316,17 +1316,24 @@ (define-public kitsas
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "0hrbsqqm6v2pmjq17s7i4akjgclz3d051mg02vcykq80xgxvbkgf"))))
+                "16zkfpl5d9ia202fqg5vrhjqdw0g6wp044ih6n7nz2hbxj9y3m1z"))))
     (build-system qt-build-system)
-    (inputs (list qtbase-5 libzip poppler-qt5 qtsvg-5))
+    (inputs (list libzip qtsvg qtwebengine qt5compat))
     (arguments
      (list #:tests? #f               ;XXX: some tests fail and others segfault
            #:test-target "check"
+           #:qtbase qtbase
            #:phases
            #~(modify-phases %standard-phases
                (replace 'configure
                  (lambda* _
                    (invoke "qmake" "kitsasproject.pro" "CONFIG+=release")))
+               ;; The tests are not maintained and some don't even build
+               (add-before 'configure 'disable-broken-tests
+                 (lambda _
+                   (substitute* "kitsasproject.pro"
+                     ((" *(unittest|testit).*") "")
+                     (("\\\\") ""))))
                (replace 'install
                  (lambda* _
                    (install-file "kitsas/kitsas"

base-commit: f2102cb5b9239be2ed2023b908b726af542e0124
-- 
2.41.0





Acknowledgement sent to Saku Laesvuori <saku@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#69068; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Tue, 13 Feb 2024 12:30:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.