Received: (at 69084-done) by debbugs.gnu.org; 1 Mar 2025 03:35:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 28 22:35:02 2025 Received: from localhost ([127.0.0.1]:57352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1toDcy-0003zv-Sw for submit <at> debbugs.gnu.org; Fri, 28 Feb 2025 22:35:01 -0500 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:50586) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1toDcw-0003z8-6R for 69084-done <at> debbugs.gnu.org; Fri, 28 Feb 2025 22:34:58 -0500 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5e04861e7a6so4640273a12.1 for <69084-done <at> debbugs.gnu.org>; Fri, 28 Feb 2025 19:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740800092; x=1741404892; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=RtXIKTRsqW8gHnzVUX4g0u39COx+0fX6TDckF3rl0TM=; b=A/655NuHO7nxkGjiCSLlB1rFuub71XWLJ2UCKDAm1im7oYJ84wj6hJNViYAfeubDcm LF9EcI/s1yxneX1BAeAVYlsdDl7qEyKf9+KepzNMNxpjHdkPpZ8wUt/cZzMo2mtb5jzO JNTzfpAnA1GiAeyNeWqn+LMp+mmUliif5ojUutH6VZp+VkA4FDnIbWiapNeZoJ/3cGPo BC/bKYp4XCeXxwhDMDhNLAtkY65Bebk1pTqMkZkgWYFbJrBQb4SJPHXZ8mQxvaWzTv3I FQpDXVKND6vyiUE7FvXjsxx1vstvZvCXYo0lWlvcUR/X/64sHPPjvRzGFm1Dakax55x1 93Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740800092; x=1741404892; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RtXIKTRsqW8gHnzVUX4g0u39COx+0fX6TDckF3rl0TM=; b=EJDQMrczrdB+zPhfkfMbXxiGGR0nYEPKTXAjBYTkKlZREb8h0w6s5RHZY0GI+Jee3g OBfCcsdth14V86Uh5AOPtVIYxxDGcN5fcOAag4K8pQ9vt471XgNUw/s5OBnWkQr+pTkS UW49QpX/l3qr3jqCbW25jM4LEY/CXaj60RW7H3G2tfNN4VzhhLMO4s+WomKQ3xrKYilV 52YP9wRwfYusQyilWXn3HLcJpNfPp/ET3CXNPSPj/JeOYmtY9MAw/7GM54iRWdRyhI86 n0r8AW+yde5t4aAFVyStudaGuINOZm8/Ajm25JE4J7Sp7XKWhpxdiNYs6Hi2BvnE2IFk IZVg== X-Forwarded-Encrypted: i=1; AJvYcCVJQYQvZYxA7VYXEBFFXonu5T13ULQPa0zAbIYTiLSO2MrfSgDcYflxbrB1HTBylcMl16IW6HOrQGGN <at> debbugs.gnu.org X-Gm-Message-State: AOJu0YzLhO2ciOrzA1BvissS4TO9neYiVXIwLS1s1cp045IF5GPeD6EY dsHIuWTGbCNSVvw1pOcF94aNtFuHW7yF80KE3+xm1LWzWQh3Wtt2+Th8ThqrstSnCcDZGXRDXxL tvq8JjHfrv6qZr/P0f/BGMqWD74/vayKVOmw= X-Gm-Gg: ASbGnctbi1R6isjIhHlyMYGWu4oKitrV4f4plElTw97sTKi95JKhQe/6EMto5Lm+Y/+ Yzu4BxE5rUhLvFztKjt6kruB/Gg1K3FaMJeeZvLlGv+zjYHTTKlw5VPcldb7tTVHCLk3BDaVHV4 ZGCNThsUOQzOZ4ujo8656sA++QJ0U= X-Google-Smtp-Source: AGHT+IFuRSGAcFjL2e1WPnihr/zaiaQY2YFoEHUFfeZnOYFcP/mJas899dvpL4S2M66B810iiSmZeh+/O9lKSMC0vpg= X-Received: by 2002:a17:907:daa:b0:abf:625:b402 with SMTP id a640c23a62f3a-abf25fc489bmr621728366b.24.1740800091896; Fri, 28 Feb 2025 19:34:51 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 28 Feb 2025 19:34:51 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87frxm94yg.fsf@HIDDEN> References: <87ttmd32m6.fsf@HIDDEN> <86il2qw1tq.fsf@HIDDEN> <87frxm94yg.fsf@HIDDEN> MIME-Version: 1.0 Date: Fri, 28 Feb 2025 19:34:51 -0800 X-Gm-Features: AQ5f1Jp2AreMnTaYJal21nbCnEOfzXiKEtUK7zPIoOpm8vwxlqLrHW_h0bdGZl8 Message-ID: <CADwFkm=qHpR=3YxLSKfLwcMW9WdUv_j1+96LRSjXauok-XiqHw@HIDDEN> Subject: Re: bug#69084: 30; check-declare-directory chokes on lock files To: Jonas Bernoulli <jonas@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 69084-done Cc: Eli Zaretskii <eliz@HIDDEN>, 69084-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Jonas Bernoulli <jonas@HIDDEN> writes: > Eli Zaretskii <eliz@HIDDEN> writes: > >>> Date: Mon, 12 Feb 2024 20:26:57 +0100 >>> From: Jonas Bernoulli via "Bug reports for GNU Emacs, >>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> >>> >>> `check-declare-directory' chokes on lock files for libraries: >>> >>> check-declare-scan: Opening input file: No such file or directory, >>> /home/jonas/.config/emacs/lib/forge/lisp/.#forge-pullreq.el >>> >>> This simple change would take care of that: >>> >>> diff --git a/lisp/emacs-lisp/check-declare.el b/lisp/emacs-lisp/check-declare.el >>> @@ -328,7 +328,7 @@ check-declare-directory >>> (setq root (directory-file-name (file-relative-name root))) >>> (or (file-directory-p root) >>> (error "Directory `%s' not found" root)) >>> - (let ((files (directory-files-recursively root "\\.el\\'"))) >>> + (let ((files (directory-files-recursively root "\\`[^.].*\\.el\\'"))) >>> (when files >>> (apply #'check-declare-files files)))) >>> >>> I am not sure this is acceptable as it would also skip over other hidden >>> files. IMO that would be okay; libraries arguably shouldn't be hidden >>> files. >> >> Why not exempt specifically the lock files, i.e. those whose basename >> begins with ".#"? That can be done with an additional test on the >> candidate file names returned by directory-files-recursively. >> >> WDYT? > > I've gone with the approach you suggested. The patch was installed, so I'm closing this bug report.
Jonas Bernoulli <jonas@HIDDEN>:Stefan Kangas <stefankangas@HIDDEN>:Received: (at 69084) by debbugs.gnu.org; 20 Feb 2024 21:55:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 20 16:55:22 2024 Received: from localhost ([127.0.0.1]:46910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rcY5C-00067e-2d for submit <at> debbugs.gnu.org; Tue, 20 Feb 2024 16:55:22 -0500 Received: from mail.hostpark.net ([212.243.197.30]:45546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jonas@HIDDEN>) id 1rcY59-00067N-6V for 69084 <at> debbugs.gnu.org; Tue, 20 Feb 2024 16:55:21 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 9F02D166B0; Tue, 20 Feb 2024 22:54:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from; s=sel2011a; t=1708466091; bh=mIhawWGqDFYz50epr3zYtUer2twmUJt8uOX+7Rp29Uw=; b= 0CTht1+bgZEj8cmoPVDEFwBDgNvRp1+P+pogw+Sum67YzDK/FEp2XXZpHKse5UJB HXhPJrH/RH9msZtHCcfvimMabTP0NwTp5kPg/S4VGsQ12dezk7AwaTYjuZxDF3aP JayZwsE69D78TsV+T1JXlXiwoeuy1e68Vr1TN/eAjbU= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id kmvgNhogL_eF; Tue, 20 Feb 2024 22:54:51 +0100 (CET) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 7B39B1652E; Tue, 20 Feb 2024 22:54:49 +0100 (CET) From: Jonas Bernoulli <jonas@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#69084: 30; check-declare-directory chokes on lock files In-Reply-To: <86il2qw1tq.fsf@HIDDEN> References: <87ttmd32m6.fsf@HIDDEN> <86il2qw1tq.fsf@HIDDEN> Date: Tue, 20 Feb 2024 22:54:47 +0100 Message-ID: <87frxm94yg.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 69084 Cc: 69084 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.6 (---) Eli Zaretskii <eliz@HIDDEN> writes: >> Date: Mon, 12 Feb 2024 20:26:57 +0100 >> From: Jonas Bernoulli via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> >> >> `check-declare-directory' chokes on lock files for libraries: >> >> check-declare-scan: Opening input file: No such file or directory, >> /home/jonas/.config/emacs/lib/forge/lisp/.#forge-pullreq.el >> >> This simple change would take care of that: >> >> diff --git a/lisp/emacs-lisp/check-declare.el b/lisp/emacs-lisp/check-declare.el >> @@ -328,7 +328,7 @@ check-declare-directory >> (setq root (directory-file-name (file-relative-name root))) >> (or (file-directory-p root) >> (error "Directory `%s' not found" root)) >> - (let ((files (directory-files-recursively root "\\.el\\'"))) >> + (let ((files (directory-files-recursively root "\\`[^.].*\\.el\\'"))) >> (when files >> (apply #'check-declare-files files)))) >> >> I am not sure this is acceptable as it would also skip over other hidden >> files. IMO that would be okay; libraries arguably shouldn't be hidden >> files. > > Why not exempt specifically the lock files, i.e. those whose basename > begins with ".#"? That can be done with an additional test on the > candidate file names returned by directory-files-recursively. > > WDYT? I've gone with the approach you suggested.
bug-gnu-emacs@HIDDEN:bug#69084; Package emacs.
Full text available.Received: (at 69084) by debbugs.gnu.org; 15 Feb 2024 08:48:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 15 03:48:32 2024 Received: from localhost ([127.0.0.1]:53967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1raXPz-0000t4-JP for submit <at> debbugs.gnu.org; Thu, 15 Feb 2024 03:48:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1raXPx-0000sI-Fm for 69084 <at> debbugs.gnu.org; Thu, 15 Feb 2024 03:48:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1raXPY-0002nM-9S; Thu, 15 Feb 2024 03:48:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=H+mGEihu4kEouRAobrawJNkldKd8jFEElpCnfUVIwtw=; b=rw8+OsNLIKHR AKojePcBey36L7tMpw4Am+3sUOTx9Xu+cCzEeRUTXNZf+EfQcse/WCSjUOopMRQT2JWAyd6DhSmQm ATxmZJdRNw/Gwlagv4u/0eFyLWEo/sNDQW1DJC+l2Ycb0UgekW8tp+WNuOa0BOVkprbrHWUtAO3q6 VuD0JeR5rZ//miumc9VWQc47mT8UyMk4O67CvlMMKmmCgxNcwY8hEbmccoxDw2uajjrNx9AOv+wOu XhRIKXQUUqp+i1BMz47iVW9LIPrWE2uwpqAA+BIb9GFHhOqE63P8T78K61jBVn5iyI+xnPw9+kdk9 YL2YdY4p50IW+AARtSYTrA==; Date: Thu, 15 Feb 2024 10:48:01 +0200 Message-Id: <86il2qw1tq.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Jonas Bernoulli <jonas@HIDDEN> In-Reply-To: <87ttmd32m6.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#69084: 30; check-declare-directory chokes on lock files References: <87ttmd32m6.fsf@HIDDEN> X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 69084 Cc: 69084 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -5.2 (-----) > Date: Mon, 12 Feb 2024 20:26:57 +0100 > From: Jonas Bernoulli via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > `check-declare-directory' chokes on lock files for libraries: > > check-declare-scan: Opening input file: No such file or directory, > /home/jonas/.config/emacs/lib/forge/lisp/.#forge-pullreq.el > > This simple change would take care of that: > > diff --git a/lisp/emacs-lisp/check-declare.el b/lisp/emacs-lisp/check-declare.el > @@ -328,7 +328,7 @@ check-declare-directory > (setq root (directory-file-name (file-relative-name root))) > (or (file-directory-p root) > (error "Directory `%s' not found" root)) > - (let ((files (directory-files-recursively root "\\.el\\'"))) > + (let ((files (directory-files-recursively root "\\`[^.].*\\.el\\'"))) > (when files > (apply #'check-declare-files files)))) > > I am not sure this is acceptable as it would also skip over other hidden > files. IMO that would be okay; libraries arguably shouldn't be hidden > files. Why not exempt specifically the lock files, i.e. those whose basename begins with ".#"? That can be done with an additional test on the candidate file names returned by directory-files-recursively. WDYT?
bug-gnu-emacs@HIDDEN:bug#69084; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 12 Feb 2024 19:55:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 12 14:55:23 2024
Received: from localhost ([127.0.0.1]:53928 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rZcOf-0006eI-RY
for submit <at> debbugs.gnu.org; Mon, 12 Feb 2024 14:55:22 -0500
Received: from lists.gnu.org ([2001:470:142::17]:54190)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <jonas@HIDDEN>) id 1rZbxq-0004Rr-I0
for submit <at> debbugs.gnu.org; Mon, 12 Feb 2024 14:27:48 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <jonas@HIDDEN>) id 1rZbxP-00026w-SL
for bug-gnu-emacs@HIDDEN; Mon, 12 Feb 2024 14:27:12 -0500
Received: from mail.hostpark.net ([212.243.197.30])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <jonas@HIDDEN>) id 1rZbxM-0005w6-5v
for bug-gnu-emacs@HIDDEN; Mon, 12 Feb 2024 14:27:11 -0500
Received: from localhost (localhost [127.0.0.1])
by mail.hostpark.net (Postfix) with ESMTP id E3B4E162D7
for <bug-gnu-emacs@HIDDEN>; Mon, 12 Feb 2024 20:27:00 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h=
content-type:content-type:mime-version:message-id:date:date
:subject:subject:from:from; s=sel2011a; t=1707766020; bh=n3ZAzWz
qu6oRIvOFngHMMulZMrtUf4hCOdQnfMRpC00=; b=dJn47OYhpNjhPSxCfgo/h3g
XZVOEL3zGoArXmHTgtZzdafI3LluUW3OM5wV0NDFxnID5PI04a1vW/Zhlh/z12CM
2VIfSx2sg291hREBiluFnD8kfs0tihWRvv5D73YuK0YHScGpQPshxGKqbm0c5WFv
yxOonqgvqTJ3g5sWnADU=
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224)
with ESMTP id f0BABZsWACyd for <bug-gnu-emacs@HIDDEN>;
Mon, 12 Feb 2024 20:27:00 +0100 (CET)
Received: from customer (localhost [127.0.0.1])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
SHA256) (No client certificate requested)
by mail.hostpark.net (Postfix) with ESMTPSA id B62BE162D5
for <bug-gnu-emacs@HIDDEN>; Mon, 12 Feb 2024 20:26:59 +0100 (CET)
From: Jonas Bernoulli <jonas@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 30; check-declare-directory chokes on lock files
Date: Mon, 12 Feb 2024 20:26:57 +0100
Message-ID: <87ttmd32m6.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=212.243.197.30; envelope-from=jonas@HIDDEN;
helo=mail.hostpark.net
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)
`check-declare-directory' chokes on lock files for libraries:
check-declare-scan: Opening input file: No such file or directory,
/home/jonas/.config/emacs/lib/forge/lisp/.#forge-pullreq.el
This simple change would take care of that:
diff --git a/lisp/emacs-lisp/check-declare.el b/lisp/emacs-lisp/check-declare.el
@@ -328,7 +328,7 @@ check-declare-directory
(setq root (directory-file-name (file-relative-name root)))
(or (file-directory-p root)
(error "Directory `%s' not found" root))
- (let ((files (directory-files-recursively root "\\.el\\'")))
+ (let ((files (directory-files-recursively root "\\`[^.].*\\.el\\'")))
(when files
(apply #'check-declare-files files))))
I am not sure this is acceptable as it would also skip over other hidden
files. IMO that would be okay; libraries arguably shouldn't be hidden
files.
Cheers,
Jonas
Jonas Bernoulli <jonas@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#69084; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.