GNU bug report logs - #69355
[PATCH] gnu: Add libgrapheme.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69355 in the body.
You can then email your comments to 69355 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: cage <cage-dev <at> twistfold.it>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add libgrapheme.
Date: Sat, 24 Feb 2024 14:24:09 +0100

Change-Id: If19bc5534b8bc3d0aeda4f1e70baa8d42e4948e0
---
 gnu/packages/suckless.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 81e2151854..e71b0e9252 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -1393,3 +1393,33 @@ (define-public 9base
     (description
      "This package provides ported versions of various Plan 9 userland tools
 for Unix.")))
+
+(define-public libgrapheme
+  (package
+    (name "libgrapheme")
+    (version "2.0.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://dl.suckless.org/libgrapheme/libgrapheme-"
+                           version
+                           ".tar.gz"))
+       (sha256
+        (base32 "099i2jm9c25nkbg5420wr12z0gd189gcw5j1ssjmpmbbwzfvv2x6"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:tests? #f
+           #:phases #~(modify-phases %standard-phases
+                        (add-after 'configure 'post-configure
+                          (lambda _
+                            (substitute* "config.mk"
+                              (("ldconfig") "")))))
+           #:make-flags
+           #~(list (string-append "CC=" #$(cc-for-target))
+                   (string-append "PREFIX=" #$output))))
+    (home-page "https://libs.suckless.org/libgrapheme/")
+    (synopsis "Library to handle string according to Unicode standard")
+    (description "Libgrapheme is an extremely simple freestanding C99 library
+providing utilities for properly handling strings
+according to the latest Unicode standard 15.0.0.")
+    (license license:isc)))

base-commit: de24aaf13b17d6c019f3f240fd0eb0e1b8654970
prerequisite-patch-id: aa0b913d42bee51002e7243019d5529984321e91
-- 
2.41.0

Message #8 received at 69355 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: cage <cage-dev <at> twistfold.it>
Cc: 69355 <at> debbugs.gnu.org
Subject: Re: [bug#69355] [PATCH] gnu: Add libgrapheme.
Date: Mon, 26 Feb 2024 11:24:42 -0500

Hi,

cage <cage-dev <at> twistfold.it> writes:

> Change-Id: If19bc5534b8bc3d0aeda4f1e70baa8d42e4948e0
> ---
>  gnu/packages/suckless.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index 81e2151854..e71b0e9252 100644
> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -1393,3 +1393,33 @@ (define-public 9base
>      (description
>       "This package provides ported versions of various Plan 9 userland tools
>  for Unix.")))
> +
> +(define-public libgrapheme
> +  (package
> +    (name "libgrapheme")
> +    (version "2.0.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://dl.suckless.org/libgrapheme/libgrapheme-"
> +                           version
> +                           ".tar.gz"))
> +       (sha256
> +        (base32 "099i2jm9c25nkbg5420wr12z0gd189gcw5j1ssjmpmbbwzfvv2x6"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     (list #:tests? #f

We strive to enable test suites of packages in Guix, as this gives us a
chance to detect breakage across updates.  Its page mentions a 'test'
target to run the conformance and unit tests of libgrapheme.  Did you
try it, via #:test-target "test" ?  (the default is "check", which is
most common).

> +           #:phases #~(modify-phases %standard-phases
> +                        (add-after 'configure 'post-configure
> +                          (lambda _
> +                            (substitute* "config.mk"

Please leave an explanatory comment mentioning that running ldconfig is
not needed on Guix.

> +                              (("ldconfig") "")))))
> +           #:make-flags
> +           #~(list (string-append "CC=" #$(cc-for-target))
> +                   (string-append "PREFIX=" #$output))))
> +    (home-page "https://libs.suckless.org/libgrapheme/")
> +    (synopsis "Library to handle string according to Unicode standard")
> +    (description "Libgrapheme is an extremely simple freestanding C99 library
> +providing utilities for properly handling strings
> +according to the latest Unicode standard 15.0.0.")

nitpick: The paragraph flow seems broken after 'handling strings' --
"M-;" in Emacs would help.

I'd also drop the exact Unicode standard currently targeted, as this
would probably become outdated information soon.

Could you send a v2 with the above changes?

-- 
Thanks,
Maxim

Message #11 received at 69355 <at> debbugs.gnu.org (full text, mbox):

From: cage <cage-dev <at> twistfold.it>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 69355 <at> debbugs.gnu.org
Subject: Re: [bug#69355] [PATCH] gnu: Add libgrapheme.
Date: Tue, 27 Feb 2024 19:51:26 +0100

On Mon, Feb 26, 2024 at 11:24:42AM -0500, Maxim Cournoyer wrote:
> Hi,

Hi!

[...]

> We strive to enable test suites of packages in Guix, as this gives us a
> chance to detect breakage across updates.  Its page mentions a 'test'
> target to run the conformance and unit tests of libgrapheme.  Did you
> try it, via #:test-target "test" ?  (the default is "check", which is
> most common).

I did not  payed the right attention while reading  the README file of
the  package and  I missed  the mentions  of the  tests target  in the
makefile. ^^;

>
> > +           #:phases #~(modify-phases %standard-phases
> > +                        (add-after 'configure 'post-configure
> > +                          (lambda _
> > +                            (substitute* "config.mk"
>
> Please leave an explanatory comment mentioning that running ldconfig is
> not needed on Guix.

sure!

>
> > +                              (("ldconfig") "")))))
> > +           #:make-flags
> > +           #~(list (string-append "CC=" #$(cc-for-target))
> > +                   (string-append "PREFIX=" #$output))))
> > +    (home-page "https://libs.suckless.org/libgrapheme/")
> > +    (synopsis "Library to handle string according to Unicode standard")
> > +    (description "Libgrapheme is an extremely simple freestanding C99 library
> > +providing utilities for properly handling strings
> > +according to the latest Unicode standard 15.0.0.")
>
> nitpick: The paragraph flow seems broken after 'handling strings' --
> "M-;" in Emacs would help.

For some reasons this command does not work for me, i used to use M-q,
i hope the results is acceptable. ^^;

> I'd also drop the exact Unicode standard currently targeted, as this
> would probably become outdated information soon.

Good idea!

> Could you send a v2 with the above changes?

Sure! The new patch is attached below.

Thanks for your comments, let me know if I have addressed, or not, all the issues.
Bye!
C.

---
 gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 81e2151854..b89b3be961 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -1393,3 +1393,36 @@ (define-public 9base
     (description
      "This package provides ported versions of various Plan 9 userland tools
 for Unix.")))
+
+(define-public libgrapheme
+  (package
+    (name "libgrapheme")
+    (version "2.0.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://dl.suckless.org/libgrapheme/libgrapheme-"
+                           version
+                           ".tar.gz"))
+       (sha256
+        (base32 "099i2jm9c25nkbg5420wr12z0gd189gcw5j1ssjmpmbbwzfvv2x6"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:tests? #true
+           #:test-target "test"
+           #:phases #~(modify-phases %standard-phases
+                        (add-after 'configure 'post-configure
+                          (lambda _
+                            ;; removing call of ldconfing in makefile as it is
+                            ;; not actually needed in guix
+                            (substitute* "config.mk"
+                              (("ldconfig") "")))))
+           #:make-flags
+           #~(list (string-append "CC=" #$(cc-for-target))
+                   (string-append "PREFIX=" #$output))))
+    (home-page "https://libs.suckless.org/libgrapheme/")
+    (synopsis "Library to handle string according to Unicode standard.")
+    (description "Libgrapheme is an extremely simple freestanding C99 library
+providing utilities for properly handling strings according to the latest
+Unicode standard.")
+    (license license:isc)))

base-commit: de24aaf13b17d6c019f3f240fd0eb0e1b8654970
prerequisite-patch-id: aa0b913d42bee51002e7243019d5529984321e91
--
2.41.0

Message #16 received at 69355-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: cage <cage-dev <at> twistfold.it>
Cc: 69355-done <at> debbugs.gnu.org
Subject: Re: [bug#69355] [PATCH] gnu: Add libgrapheme.
Date: Sun, 31 Mar 2024 21:26:25 -0400

Hi cage,

cage <cage-dev <at> twistfold.it> writes:

[...]

> ---
>  gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index 81e2151854..b89b3be961 100644


I've added a simple commit message, as autogenerated with 'add...TAB' in
the commit message buffer in Emacs using yasnippet (you could have also
used 'etc/committer.scm').

> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -1393,3 +1393,36 @@ (define-public 9base
>      (description
>       "This package provides ported versions of various Plan 9 userland tools
>  for Unix.")))
> +
> +(define-public libgrapheme
> +  (package
> +    (name "libgrapheme")
> +    (version "2.0.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://dl.suckless.org/libgrapheme/libgrapheme-"
> +                           version
> +                           ".tar.gz"))
> +       (sha256
> +        (base32 "099i2jm9c25nkbg5420wr12z0gd189gcw5j1ssjmpmbbwzfvv2x6"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     (list #:tests? #true
> +           #:test-target "test"
> +           #:phases #~(modify-phases %standard-phases
> +                        (add-after 'configure 'post-configure
> +                          (lambda _
> +                            ;; removing call of ldconfing in makefile as it is
> +                            ;; not actually needed in guix

I punctuated the comment (as a full sentence, starting with a capital
letter and ending with a period).

> +                            (substitute* "config.mk"
> +                              (("ldconfig") "")))))
> +           #:make-flags
> +           #~(list (string-append "CC=" #$(cc-for-target))
> +                   (string-append "PREFIX=" #$output))))
> +    (home-page "https://libs.suckless.org/libgrapheme/")
> +    (synopsis "Library to handle string according to Unicode standard.")

I've changed the synopsis to say what it *is*: "C99 library for Unicode
strings".  Note the lack of a period for the synopsis (it is not a
complete sentence -- I think 'guix lint' would have spotted that).

> +    (description "Libgrapheme is an extremely simple freestanding C99 library
> +providing utilities for properly handling strings according to the latest
> +Unicode standard.")
> +    (license license:isc)))

I've dropped 'extremely' which sounded like marketing, and pushed.

Thanks for your contribution!

-- 
Thanks,
Maxim

Message #19 received at 69355-done <at> debbugs.gnu.org (full text, mbox):

From: cage <cage-dev <at> twistfold.it>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 69355-done <at> debbugs.gnu.org
Subject: Re: [bug#69355] [PATCH] gnu: Add libgrapheme.
Date: Tue, 2 Apr 2024 18:36:40 +0200

On Sun, Mar 31, 2024 at 09:26:25PM -0400, Maxim Cournoyer wrote:
> Hi cage,

Hi!

> cage <cage-dev <at> twistfold.it> writes:
>
> [...]
>
> > ---
> >  gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> >
> > diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> > index 81e2151854..b89b3be961 100644
>
>
> I've added a simple commit message, as autogenerated with 'add...TAB' in
> the commit message buffer in Emacs using yasnippet (you could have also
> used 'etc/committer.scm').

Thanks  for  your suggestion,  i  tried  using  yasnippet but  with  no
luck. :( But i will try again at the next patch, i swear! :D

[...]

> Note the lack of a period for the synopsis (it is not a
> complete sentence -- I think 'guix lint' would have spotted that).

Yes, likely i did not run guix line, this time, sorry! ^^;

[...]
> I've dropped 'extremely' which sounded like marketing, and pushed.

I agree it is inappropriate here.

> Thanks for your contribution!

Thanks to you for fixing the patch!
C.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.