GNU bug report logs - #69368
[PATCH] Allow --zero with --check

Previous Next

To reply to this bug, email your comments to 69368 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Branco <rbranco <at> suse.de>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] Allow --zero with --check
Date: Sat, 24 Feb 2024 20:07:19 +0100

[Message part 1 (text/plain, inline)]

The --zero option is useless if not supported by --check.

Attached patch fixes it.

https://github.com/coreutils/coreutils/pull/81

Best,

R

[md5.diff (text/x-patch, attachment)]

Message #8 received at 69368 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Branco <rbranco <at> suse.de>
To: 69368 <at> debbugs.gnu.org
Subject: [PATCH]: md5sum: Allow --zero with --check
Date: Sun, 25 Feb 2024 11:29:29 +0100

[Message part 1 (text/plain, inline)]

Improved version.

[src-digest.c.diff (text/x-patch, attachment)]

Message #11 received at 69368 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Ricardo Branco <rbranco <at> suse.de>, 69368 <at> debbugs.gnu.org
Subject: Re: bug#69368: [PATCH] Allow --zero with --check
Date: Sun, 25 Feb 2024 11:06:26 +0000

On 24/02/2024 19:07, Ricardo Branco wrote:
> The --zero option is useless if not supported by --check.
> 
> Attached patch fixes it.
> 
> https://github.com/coreutils/coreutils/pull/81

I'm not sure about this.

By adding this support we diverge the checksum file formats supported by check.
I.e. users may inadvertently create such files that are not usable
by any previous version of the checksum utilities.

Also having --check support NUL delimited files
doesn't add any additional functionality, as the checksum files
are already automatically escaped appropriately.

Also NUL delimited checksum files can be harder to manage with other text tools.

--zero was added for the case of piping to other tools
that would find the filename escaping problematic.

cheers,
Pádraig

Message #14 received at 69368 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Branco <rbranco <at> suse.de>
To: Pádraig Brady <P <at> draigBrady.com>, 69368 <at> debbugs.gnu.org
Subject: Re: bug#69368: [PATCH] Allow --zero with --check
Date: Sun, 25 Feb 2024 12:13:17 +0100

On 2/25/24 12:06, Pádraig Brady wrote:
> By adding this support we diverge the checksum file formats supported 
> by check.
> I.e. users may inadvertently create such files that are not usable
> by any previous version of the checksum utilities.

Any user of the --zero flag has already created completely unusable 
check files.

This patch makes them usable.

> Also having --check support NUL delimited files
> doesn't add any additional functionality, as the checksum files
> are already automatically escaped appropriately.

The --zero flag disables file name escaping.

> Also NUL delimited checksum files can be harder to manage with other 
> text tools.

Only text tools that don't have zero flags unlike the ones you mention here:

> --zero was added for the case of piping to other tools
> that would find the filename escaping problematic.


Best,

R

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.