GNU bug report logs - #69472
[PATCH] Added avro-cpp v1.11

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69472 in the body.
You can then email your comments to 69472 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Lenoci, L. (Leonardo)" <l.lenoci <at> science.leidenuniv.nl>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] Added avro-cpp v1.11
Date: Thu, 29 Feb 2024 08:51:50 +0000

gnu: avro-cpp: Added version 1.11

* gnu/packages/serialization.scm (avro-cpp-1.11): Added version 1.11
---
 gnu/packages/serialization.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/serialization.scm
b/gnu/packages/serialization.scm
index 331fae80cf..194a962d38 100644
--- a/gnu/packages/serialization.scm
+++ b/gnu/packages/serialization.scm
@@ -19,6 +19,7 @@
 ;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
 ;;; Copyright © 2024 Paul A. Patience <paul <at> apatience.com>
 ;;; Copyright © 2024 Arun Isaac <arunisaac <at> systemreboot.net>
+;;; Copyright © 2024 Leonardo Lenoci <l.lenoci <at> science.leidenuniv.nl>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -102,6 +103,32 @@ (define-public avro-cpp-1.9
 implement RPC protocols.")
     (license license:asl2.0)))
 
+(define-public avro-cpp-1.11
+  (package
+    (inherit avro-cpp-1.9)
+    (version "1.11.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://archive.apache.org/dist/avro/avro-"
version
+                    "/avro-src-" version ".tar.gz"))
+              (sha256
+               (base32
"0d60vi4s8la0c64zfyydfy21690yf0px5bcsi5d1p8b06al8g9vf"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+        (add-after 'unpack 'chdir
+          (lambda _ (chdir "lang/c++")))
+         ;;; avoid that deprecation warnings with boost v.1.80.0
+         ;;; are treated as errors
+        (add-after 'chdir 'unset-Werror
+          (lambda _
+            (substitute* "CMakeLists.txt"
+              (("-Werror") ""))))       
+        )))
+    ))
+
 (define-public avro-cpp-1.9-for-irods
   (package
     (inherit avro-cpp-1.9)

base-commit: 8c0282cf543fe205a5b89201cd7bb8889121a07c
-- 
2.34.1

Message #8 received at 69472 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: "Lenoci, L. (Leonardo)" <l.lenoci <at> science.leidenuniv.nl>
Cc: 69472 <at> debbugs.gnu.org
Subject: Re: [bug#69472] [PATCH] Added avro-cpp v1.11
Date: Wed, 23 Apr 2025 13:43:10 -0400

On Thu, Feb 29, 2024 at 9:46 AM Lenoci, L. (Leonardo) via Guix-patches
via <guix-patches <at> gnu.org> wrote:
>
> gnu: avro-cpp: Added version 1.11
>
> * gnu/packages/serialization.scm (avro-cpp-1.11): Added version 1.11
> ---
>  gnu/packages/serialization.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/serialization.scm
> b/gnu/packages/serialization.scm
> index 331fae80cf..194a962d38 100644
> --- a/gnu/packages/serialization.scm
> +++ b/gnu/packages/serialization.scm
> @@ -19,6 +19,7 @@
>  ;;; Copyright © 2023 Zheng Junjie <873216071 <at> qq.com>
>  ;;; Copyright © 2024 Paul A. Patience <paul <at> apatience.com>
>  ;;; Copyright © 2024 Arun Isaac <arunisaac <at> systemreboot.net>
> +;;; Copyright © 2024 Leonardo Lenoci <l.lenoci <at> science.leidenuniv.nl>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -102,6 +103,32 @@ (define-public avro-cpp-1.9
>  implement RPC protocols.")
>      (license license:asl2.0)))
>
> +(define-public avro-cpp-1.11
> +  (package
> +    (inherit avro-cpp-1.9)
> +    (version "1.11.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://archive.apache.org/dist/avro/avro-"
> version
> +                    "/avro-src-" version ".tar.gz"))
> +              (sha256
> +               (base32
> "0d60vi4s8la0c64zfyydfy21690yf0px5bcsi5d1p8b06al8g9vf"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +        (add-after 'unpack 'chdir
> +          (lambda _ (chdir "lang/c++")))
> +         ;;; avoid that deprecation warnings with boost v.1.80.0
> +         ;;; are treated as errors
> +        (add-after 'chdir 'unset-Werror
> +          (lambda _
> +            (substitute* "CMakeLists.txt"
> +              (("-Werror") ""))))
> +        )))
> +    ))
> +
>  (define-public avro-cpp-1.9-for-irods
>    (package
>      (inherit avro-cpp-1.9)
>
> base-commit: 8c0282cf543fe205a5b89201cd7bb8889121a07c
> --
> 2.34.1

Why not update the existing avro-cpp package and add the old version
and source fields to the inheriting avro-cpp-1.9-for-irods?

Message #11 received at 69472 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: 69472 <at> debbugs.gnu.org
Cc: Greg Hogan <code <at> greghogan.com>
Subject: [PATCH] gnu: avro-cpp: Update to 1.12.0.
Date: Tue,  6 May 2025 15:34:23 +0000

* gnu/packages/serialization.scm (avro-cpp-1.9): Rename to avro-cpp.
(avro-cpp): Update to 1.12.0.
[source]<uri>: Use Apache mirror.
[arguments]<#:phases>: Add phase to use system fmt.
[inputs]: Add fmt.
(avro-cpp-1.9-for-irods): Inherit from avro-cpp.

Change-Id: Iee70378ad5452ad51757aadb8f6adaf00fc5bab5
---
 gnu/packages/serialization.scm | 34 ++++++++++++++++++++++++----------
 1 file changed, 24 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
index c0f7001fa05..db8e85f411b 100644
--- a/gnu/packages/serialization.scm
+++ b/gnu/packages/serialization.scm
@@ -70,28 +70,34 @@ (define-module (gnu packages serialization)
   #:use-module (gnu packages python-check)
   #:use-module (gnu packages python-science)
   #:use-module (gnu packages python-xyz)
+  #:use-module (gnu packages pretty-print)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages time))
 
-(define-public avro-cpp-1.9
+(define-public avro-cpp
   (package
     (name "avro-cpp")
-    (version "1.9.2")
+    (version "1.12.0")
     (source (origin
               (method url-fetch)
               (uri (string-append
-                    "https://archive.apache.org/dist/avro/avro-" version
+                    "mirror://apache/avro/avro-" version
                     "/avro-src-" version ".tar.gz"))
               (sha256
-               (base32 "0i3fpm7r72yw397qc8yw9ybzk2mxjkv0yk5hnn00ylc1wbd0np73"))))
+               (base32 "0ywg7s7m7ngiddcg78hwb34c49yjzal6glcckinvcik2fr9nmg88"))))
     (build-system cmake-build-system)
     (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'chdir
-           (lambda _ (chdir "lang/c++"))))))
+     (list #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'chdir
+                 (lambda _ (chdir "lang/c++")))
+               (add-after 'chdir 'fix-dependencies
+                 (lambda _
+                   (substitute* "CMakeLists.txt"
+                     (("^FetchContent_MakeAvailable\\(fmt\\)")
+                      "find_package(fmt REQUIRED)")))))))
     (inputs
-     (list boost snappy))
+     (list boost fmt snappy))
     (home-page "https://avro.apache.org/")
     (synopsis "Data serialization system")
     (description "Apache Avro is a data serialization system.  Avro provides:
@@ -109,8 +115,16 @@ (define-public avro-cpp-1.9
 
 (define-public avro-cpp-1.9-for-irods
   (package
-    (inherit avro-cpp-1.9)
+    (inherit avro-cpp)
     (properties `((hidden? . #true)))
+    (version "1.9.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://archive.apache.org/dist/avro/avro-" version
+                    "/avro-src-" version ".tar.gz"))
+              (sha256
+               (base32 "0i3fpm7r72yw397qc8yw9ybzk2mxjkv0yk5hnn00ylc1wbd0np73"))))
     (arguments
      `(#:configure-flags
        '("-DCMAKE_CXX_COMPILER=clang++"

base-commit: fa39695bbc0c5f79838cbca55d55eebd821a8efa
-- 
2.49.0

Message #16 received at 69472-done <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: 69472-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: avro-cpp: Update to 1.12.0.
Date: Tue, 13 May 2025 13:29:53 -0400

On Tue, May 6, 2025 at 11:35 AM Greg Hogan <code <at> greghogan.com> wrote:
>
> * gnu/packages/serialization.scm (avro-cpp-1.9): Rename to avro-cpp.
> (avro-cpp): Update to 1.12.0.
> [source]<uri>: Use Apache mirror.
> [arguments]<#:phases>: Add phase to use system fmt.
> [inputs]: Add fmt.
> (avro-cpp-1.9-for-irods): Inherit from avro-cpp.
>
> Change-Id: Iee70378ad5452ad51757aadb8f6adaf00fc5bab5
> ---
>  gnu/packages/serialization.scm | 34 ++++++++++++++++++++++++----------
>  1 file changed, 24 insertions(+), 10 deletions(-)
>
> diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
> index c0f7001fa05..db8e85f411b 100644
> --- a/gnu/packages/serialization.scm
> +++ b/gnu/packages/serialization.scm
> @@ -70,28 +70,34 @@ (define-module (gnu packages serialization)
>    #:use-module (gnu packages python-check)
>    #:use-module (gnu packages python-science)
>    #:use-module (gnu packages python-xyz)
> +  #:use-module (gnu packages pretty-print)
>    #:use-module (gnu packages qt)
>    #:use-module (gnu packages time))
>
> -(define-public avro-cpp-1.9
> +(define-public avro-cpp
>    (package
>      (name "avro-cpp")
> -    (version "1.9.2")
> +    (version "1.12.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append
> -                    "https://archive.apache.org/dist/avro/avro-" version
> +                    "mirror://apache/avro/avro-" version
>                      "/avro-src-" version ".tar.gz"))
>                (sha256
> -               (base32 "0i3fpm7r72yw397qc8yw9ybzk2mxjkv0yk5hnn00ylc1wbd0np73"))))
> +               (base32 "0ywg7s7m7ngiddcg78hwb34c49yjzal6glcckinvcik2fr9nmg88"))))
>      (build-system cmake-build-system)
>      (arguments
> -     `(#:phases
> -       (modify-phases %standard-phases
> -         (add-after 'unpack 'chdir
> -           (lambda _ (chdir "lang/c++"))))))
> +     (list #:phases
> +           #~(modify-phases %standard-phases
> +               (add-after 'unpack 'chdir
> +                 (lambda _ (chdir "lang/c++")))
> +               (add-after 'chdir 'fix-dependencies
> +                 (lambda _
> +                   (substitute* "CMakeLists.txt"
> +                     (("^FetchContent_MakeAvailable\\(fmt\\)")
> +                      "find_package(fmt REQUIRED)")))))))
>      (inputs
> -     (list boost snappy))
> +     (list boost fmt snappy))
>      (home-page "https://avro.apache.org/")
>      (synopsis "Data serialization system")
>      (description "Apache Avro is a data serialization system.  Avro provides:
> @@ -109,8 +115,16 @@ (define-public avro-cpp-1.9
>
>  (define-public avro-cpp-1.9-for-irods
>    (package
> -    (inherit avro-cpp-1.9)
> +    (inherit avro-cpp)
>      (properties `((hidden? . #true)))
> +    (version "1.9.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://archive.apache.org/dist/avro/avro-" version
> +                    "/avro-src-" version ".tar.gz"))
> +              (sha256
> +               (base32 "0i3fpm7r72yw397qc8yw9ybzk2mxjkv0yk5hnn00ylc1wbd0np73"))))
>      (arguments
>       `(#:configure-flags
>         '("-DCMAKE_CXX_COMPILER=clang++"
>
> base-commit: fa39695bbc0c5f79838cbca55d55eebd821a8efa
> --
> 2.49.0

Pushed as 11cd06a4f7cad2c9c6b827ba6c06909ac20fea0f. I also switched
avro-cpp-1.9-for-irods to use the apache mirror, which does not affect
the derivation.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.