GNU bug report logs - #69514
[PATCH] gnu: python-pandera: Update to 0.18.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69514 in the body.
You can then email your comments to 69514 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: python-pandera: Update to 0.18.0.
Date: Sat, 2 Mar 2024 21:46:03 +0100

* gnu/packages/python-science.scm (python-pandera): Update to 0.18.0.
[source]: Remove snippet.
[arguments]<#:phases>: Add 'fix-tests phase.
---
 gnu/packages/python-science.scm | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/python-science.scm b/gnu/packages/python-science.scm
index b6a116f16b..93b5c5c91d 100644
--- a/gnu/packages/python-science.scm
+++ b/gnu/packages/python-science.scm
@@ -826,7 +826,7 @@ (define-public python-pandarallel
 (define-public python-pandera
   (package
     (name "python-pandera")
-    (version "0.17.2")
+    (version "0.18.0")
     (source
      (origin
        ;; No tests in the PyPI tarball.
@@ -836,14 +836,7 @@ (define-public python-pandera
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1mnqk583z90k1n0z3lfa4rd0ng40v7hqfk7phz5gjmxlzfjbxa1x"))
-       (modules '((guix build utils)))
-       ;; These tests require PySpark and Modin. We need to remove the entire
-       ;; directory, since the conftest.py in these directories contain
-       ;; imports.  (See: https://github.com/pytest-dev/pytest/issues/7452)
-       (snippet '(begin
-                   (delete-file-recursively "tests/pyspark")
-                   (delete-file-recursively "tests/modin")))))
+        (base32 "14b5aij5zjkwvsimg0v00qvp59mhhq7ljim4qghcn432vkg9gh47"))))
     (build-system pyproject-build-system)
     (arguments
      (list
@@ -854,7 +847,16 @@ (define-public python-pandera
                            ;; positives. These tests currently fail.
                            "not test_python_std_list_dict_generics"
                            " and not test_python_std_list_dict_empty_and_none"
-                           " and not test_pandas_modules_importable"))))
+                           " and not test_pandas_modules_importable"))
+      #:phases #~(modify-phases %standard-phases
+                   (add-before 'check 'fix-tests
+                     (lambda _
+                       ;; These tests require PySpark and Modin. We need to
+                       ;; remove the entire directory, since the conftest.py
+                       ;; in these directories contain imports.  (See:
+                       ;; https://github.com/pytest-dev/pytest/issues/7452)
+                       (for-each delete-file-recursively
+                                 '("tests/pyspark" "tests/modin")))))))
     ;; Pandera comes with a lot of extras. We test as many as possible, but do
     ;; not include all of them in the propagated-inputs. Currently, we have to
     ;; skip the pyspark and io tests due to missing packages python-pyspark

base-commit: 6f5ea7ac1acb3d1c53baf7620cca66cc87fe5a73
-- 
2.42.0

Message #8 received at 69514 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: Troy Figiel <troy <at> troyfigiel.com>, 69514 <at> debbugs.gnu.org
Subject: Re: [bug#69514] [PATCH] gnu: python-pandera: Update to 0.18.0.
Date: Fri, 08 Mar 2024 22:44:42 -0800

[Message part 1 (text/plain, inline)]

On 2024-03-02, Troy Figiel wrote:
> diff --git a/gnu/packages/python-science.scm b/gnu/packages/python-science.scm
> index b6a116f16b..93b5c5c91d 100644
> --- a/gnu/packages/python-science.scm
> +++ b/gnu/packages/python-science.scm
...
> @@ -836,14 +836,7 @@ (define-public python-pandera
>               (commit (string-append "v" version))))
>         (file-name (git-file-name name version))
>         (sha256
> -        (base32 "1mnqk583z90k1n0z3lfa4rd0ng40v7hqfk7phz5gjmxlzfjbxa1x"))
> -       (modules '((guix build utils)))
> -       ;; These tests require PySpark and Modin. We need to remove the entire
> -       ;; directory, since the conftest.py in these directories contain
> -       ;; imports.  (See: https://github.com/pytest-dev/pytest/issues/7452)
> -       (snippet '(begin
> -                   (delete-file-recursively "tests/pyspark")
> -                   (delete-file-recursively "tests/modin")))))
> +        (base32 "14b5aij5zjkwvsimg0v00qvp59mhhq7ljim4qghcn432vkg9gh47"))))
>      (build-system pyproject-build-system)
>      (arguments
>       (list
> @@ -854,7 +847,16 @@ (define-public python-pandera
>                             ;; positives. These tests currently fail.
>                             "not test_python_std_list_dict_generics"
>                             " and not test_python_std_list_dict_empty_and_none"
> -                           " and not test_pandas_modules_importable"))))
> +                           " and not test_pandas_modules_importable"))
> +      #:phases #~(modify-phases %standard-phases
> +                   (add-before 'check 'fix-tests
> +                     (lambda _
> +                       ;; These tests require PySpark and Modin. We need to
> +                       ;; remove the entire directory, since the conftest.py
> +                       ;; in these directories contain imports.  (See:
> +                       ;; https://github.com/pytest-dev/pytest/issues/7452)
> +                       (for-each delete-file-recursively
> +                                 '("tests/pyspark" "tests/modin")))))))
>      ;; Pandera comes with a lot of extras. We test as many as possible, but do
>      ;; not include all of them in the propagated-inputs. Currently, we have to
>      ;; skip the pyspark and io tests due to missing packages python-pyspark

Any compelling reason why the test removal should be moved from a
snippet to a phase? The documentation admits to this being an elusive
distinction, not really clearing things up much:

  https://guix.gnu.org/en/manual/devel/en/guix.html#Snippets-versus-Phases

Other than that, this looks like a trivial version bump. :)

Builds fine, no dependents...

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 69514 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: Vagrant Cascadian <vagrant <at> debian.org>, 69514 <at> debbugs.gnu.org
Subject: Re: [bug#69514] [PATCH] gnu: python-pandera: Update to 0.18.0.
Date: Sat, 9 Mar 2024 09:50:51 +0100

Hi vagrant,

On 2024-03-09 07:44, Vagrant Cascadian wrote:
> Any compelling reason why the test removal should be moved from a
> snippet to a phase? The documentation admits to this being an elusive
> distinction, not really clearing things up much:
> 

I read the following as stating we should keep any source code that
could be used to build the package on different systems, including tests
that could be run on other systems:

--8<---------------cut here---------------start------------->8---
The source derived from an origin should produce a source that can be
used to build the package on any system that the upstream package
supports (i.e., act as the corresponding source).
--8<---------------cut here---------------end--------------->8---

Other than that, no reason and either would be fine in my opinion. The
current documentation is more confusing rather than enlightening in this
case.

Best wishes,

Troy

Message #14 received at 69514 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Troy Figiel" <troy <at> troyfigiel.com>, 69514 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: python-pandera: Update to 0.18.0.
Date: Mon, 24 Jun 2024 20:03:27 +0000

Hi Troy,

Thanks for your work on this.

Can you send an updated patch and I'll take another look?

This patch no longer applies cleanly.

all best,

jgart

https://whereis.みんな/

Message #17 received at 69514 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: jgart <jgart <at> dismail.de>, 69514 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: python-pandera: Update to 0.18.0.
Date: Mon, 24 Jun 2024 23:58:04 +0200

Hi jgart,

Sorry, life got in the way.  I will pull in the latest Guix master,
rebase and see if python-pandera still builds.

Best wishes,

Troy

Message #20 received at 69514 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: jgart <jgart <at> dismail.de>, 69514 <at> debbugs.gnu.org
Subject: Re: [bug#69514] [PATCH] gnu: python-pandera: Update to 0.18.0.
Date: Tue, 25 Jun 2024 00:09:27 +0200

Well, these are the nicest issues to solve :-)  It seems python-pandera
was already bumped to 0.18.0 by commit
da9eed295c8737b8563a3472d7a82b34270d181b.  We can close this issue.

Message #25 received at 69514-done <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Troy Figiel" <troy <at> troyfigiel.com>, 69514-done <at> debbugs.gnu.org
Subject: Re: [bug#69514] [PATCH] gnu: python-pandera: Update to 0.18.0.
Date: Mon, 24 Jun 2024 23:11:08 +0000

Thanks for the notice. Ok, closing this issue.

all best,

jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.