GNU logs - #69516, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#69516: 30.0.50; fontify newline and end of headlines in shr
Resent-From: StrawberryTea <look@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 02 Mar 2024 23:32:01 +0000
Resent-Message-ID: <handler.69516.B.170942231022491 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 69516 <at> debbugs.gnu.org
Feedback-ID: id85149b6:Fastmail
From: StrawberryTea <look@HIDDEN>
User-Agent: mu4e 1.12.0; emacs 30.0.50
Date: Sat, 02 Mar 2024 17:31:07 -0600
Message-ID: <87v864yzwk.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=66.111.4.26; envelope-from=look@HIDDEN;
 helo=out2-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.7 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.7 (--)

Hello Emacs developers,

As you know, I love extending my headline backgrounds to the end of the
window. However, shr.el does not do this, understandably because shr.el
was written before the :extend keyword was added.

The following patch hacks around this:

modified   lisp/net/shr.el
@@ -990,16 +990,21 @@ shr-fontize-dom
;; Add face to the region, but avoid putting the font properties on
;; blank text at the start of the line, and the newline at the end, to
;; avoid ugliness.
 (defun shr-add-font (start end type)
+    (when (memq type '(shr-h1 shr-h2 shr-h3 shr-h4 shr-h5 shr-h6))
+      (insert "\n")
+      (setq end (1+ end)))
   (save-excursion
     (goto-char start)
     (while (< (point) end)
       (when (bolp)
         (skip-chars-forward " "))
-      (add-face-text-property (point) (min (line-end-position) end) type t)
+      (add-face-text-property (point) end type t)
       (if (< (line-end-position) end)
           (forward-line 1)
         (goto-char end)))))

But this is a hack, and I would like to see a proper fix in Emacs.

StrawberryTea

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: StrawberryTea <look@HIDDEN>
Subject: bug#69516: Acknowledgement (30.0.50; fontify newline and end of
 headlines in shr)
Message-ID: <handler.69516.B.170942231022491.ack <at> debbugs.gnu.org>
References: <87v864yzwk.fsf@HIDDEN>
X-Gnu-PR-Message: ack 69516
X-Gnu-PR-Package: emacs
Reply-To: 69516 <at> debbugs.gnu.org
Date: Sat, 02 Mar 2024 23:32:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 69516 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
69516: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D69516
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#69516: Acknowledgement (30.0.50; fontify newline and end of headlines in shr)
Resent-From: StrawberryTea <look@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 03 Mar 2024 04:03:02 +0000
Resent-Message-ID: <handler.69516.B69516.170943857017165 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 69516 <at> debbugs.gnu.org
Feedback-ID: id85149b6:Fastmail
From: StrawberryTea <look@HIDDEN>
In-Reply-To: <handler.69516.B.170942231022491.ack <at> debbugs.gnu.org> (GNU bug
 Tracking System's message of "Sat, 02 Mar 2024 23:32:01 +0000")
References: <87v864yzwk.fsf@HIDDEN>
 <handler.69516.B.170942231022491.ack <at> debbugs.gnu.org>
User-Agent: mu4e 1.12.0; emacs 30.0.50
Date: Sat, 02 Mar 2024 22:02:11 -0600
Message-ID: <87msrgm08s.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

As a follow-up to my previous message, this is the correct code to
reproduce the issue:

;; Bootstrap straight
(defvar bootstrap-version)

(let ((bootstrap-file
       (expand-file-name "straight/repos/straight.el/bootstrap.el" user-emacs-directory))
      (bootstrap-version 5))
  (unless (file-exists-p bootstrap-file)
    (with-current-buffer
        (url-retrieve-synchronously "https://raw.githubusercontent.com/raxod502/straight.el/develop/install.el"
                                    'silent 'inhibit-cookies)
      (goto-char (point-max))
      (eval-print-last-sexp)))
  (load bootstrap-file nil 'nomessage))

(straight-use-package 'org)

(require 'org)
(load-theme 'leuven t)

(dolist (face '(org-level-1 org-level-2 org-level-3 org-level-4 org-level-5
                org-level-6 org-level-7 org-level-8))
  (set-face-attribute face nil :extend t))

(setq org-fontify-whole-heading-line t)
(scratch-buffer)
(org-mode)
(insert "* Headline 1\n Hello
* Headline 1\nHello\n")
(run-at-time 1 0 #'org-cycle-global)
(run-at-time 2 0 #'org-cycle-global)
(run-at-time 3 0 #'org-cycle-global)

help-debbugs@HIDDEN (GNU bug Tracking System) writes:

> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
>  bug-gnu-emacs@HIDDEN
>
> If you wish to submit further information on this problem, please
> send it to 69516 <at> debbugs.gnu.org.
>
> Please do not send mail to help-debbugs@HIDDEN unless you wish
> to report a problem with the Bug-tracking system.

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#69516: 30.0.50; fontify newline and end of headlines in shr
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 03 Mar 2024 06:57:01 +0000
Resent-Message-ID: <handler.69516.B69516.17094490174747 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: StrawberryTea <look@HIDDEN>
Cc: 69516 <at> debbugs.gnu.org
Date: Sun, 03 Mar 2024 08:56:16 +0200
Message-Id: <86y1azolbj.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87v864yzwk.fsf@HIDDEN> (message from StrawberryTea on
 Sat, 02 Mar 2024 17:31:07 -0600)
References: <87v864yzwk.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

severity 69516 wishlist
thanks

> From: StrawberryTea <look@HIDDEN>
> Date: Sat, 02 Mar 2024 17:31:07 -0600
> 
> Hello Emacs developers,
> 
> As you know, I love extending my headline backgrounds to the end of the
> window. However, shr.el does not do this, understandably because shr.el
> was written before the :extend keyword was added.
> 
> The following patch hacks around this:
> 
> modified   lisp/net/shr.el
> @@ -990,16 +990,21 @@ shr-fontize-dom
> ;; Add face to the region, but avoid putting the font properties on
> ;; blank text at the start of the line, and the newline at the end, to
> ;; avoid ugliness.
>  (defun shr-add-font (start end type)
> +    (when (memq type '(shr-h1 shr-h2 shr-h3 shr-h4 shr-h5 shr-h6))
> +      (insert "\n")
> +      (setq end (1+ end)))
>    (save-excursion
>      (goto-char start)
>      (while (< (point) end)
>        (when (bolp)
>          (skip-chars-forward " "))
> -      (add-face-text-property (point) (min (line-end-position) end) type t)
> +      (add-face-text-property (point) end type t)
>        (if (< (line-end-position) end)
>            (forward-line 1)
>          (goto-char end)))))
> 
> But this is a hack, and I would like to see a proper fix in Emacs.

Thanks.  Patches for this are welcome, but I think this should be an
optional feature, given that we have lived without it for such a long
time.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 3 Mar 2024 06:56:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Mar 03 01:56:57 2024
Received: from localhost ([127.0.0.1]:39674 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rgfmL-0001EW-9j
	for submit <at> debbugs.gnu.org; Sun, 03 Mar 2024 01:56:57 -0500
Received: from eggs.gnu.org ([209.51.188.92]:55040)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>)
 id 1rgfmI-0001E8-6f; Sun, 03 Mar 2024 01:56:56 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rgflj-0006wv-Tu; Sun, 03 Mar 2024 01:56:19 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=JBMp/+uperVwVQKTGY+EEcQWJRPsMkJCp+m6fuI14Jo=; b=S7NN9eN9jMlz
 BoNocUT8G+JefQzRO7H5Um4rBAfaUZn9EVHLEXxL31oLK2gztfjTp0A9prt98XXeyGCKEXcdmKeer
 hGONGJMMceiVF5LPgwW4dqbk/gJSJy1Q0DmZ144kVbqJrXrU4hAb65vKXHjC/vEn4CV63SG2NE7Zw
 yK7mbVxlDQ4nz+aE8oec9y/vSW8L8cO4OG5dt4+BZwzrM6wMOG5EbruehXuzFNgENdGHaFCONRQ9+
 cSehHzoWlogmKV8rUCtSS2OC77FrMYa2AsfsYiEwxWFP49sAA4PROLR+iZGFjetXZGKUqCFfi6Uf3
 QPnRJchJhzY14VitNVhEbA==;
Date: Sun, 03 Mar 2024 08:56:16 +0200
Message-Id: <86y1azolbj.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: StrawberryTea <look@HIDDEN>
In-Reply-To: <87v864yzwk.fsf@HIDDEN> (message from StrawberryTea on
 Sat, 02 Mar 2024 17:31:07 -0600)
Subject: Re: bug#69516: 30.0.50; fontify newline and end of headlines in shr
References: <87v864yzwk.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
Cc: 69516 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

severity 69516 wishlist
thanks

> From: StrawberryTea <look@HIDDEN>
> Date: Sat, 02 Mar 2024 17:31:07 -0600
> 
> Hello Emacs developers,
> 
> As you know, I love extending my headline backgrounds to the end of the
> window. However, shr.el does not do this, understandably because shr.el
> was written before the :extend keyword was added.
> 
> The following patch hacks around this:
> 
> modified   lisp/net/shr.el
> @@ -990,16 +990,21 @@ shr-fontize-dom
> ;; Add face to the region, but avoid putting the font properties on
> ;; blank text at the start of the line, and the newline at the end, to
> ;; avoid ugliness.
>  (defun shr-add-font (start end type)
> +    (when (memq type '(shr-h1 shr-h2 shr-h3 shr-h4 shr-h5 shr-h6))
> +      (insert "\n")
> +      (setq end (1+ end)))
>    (save-excursion
>      (goto-char start)
>      (while (< (point) end)
>        (when (bolp)
>          (skip-chars-forward " "))
> -      (add-face-text-property (point) (min (line-end-position) end) type t)
> +      (add-face-text-property (point) end type t)
>        (if (< (line-end-position) end)
>            (forward-line 1)
>          (goto-char end)))))
> 
> But this is a hack, and I would like to see a proper fix in Emacs.

Thanks.  Patches for this are welcome, but I think this should be an
optional feature, given that we have lived without it for such a long
time.

Last modified: Sun, 3 Mar 2024 07:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.