GNU logs - #69528, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: No Wayman <iarchivedmywholelife@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 03 Mar 2024 17:26:02 +0000
Resent-Message-ID: <handler.69528.B.17094867105249 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 69528 <at> debbugs.gnu.org
From: No Wayman <iarchivedmywholelife@HIDDEN>
User-Agent: mu4e 1.12.0; emacs 30.0.50
Date: Sun, 03 Mar 2024 12:25:16 -0500
Message-ID: <87edcrtegz.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
Received-SPF: pass client-ip=2607:f8b0:4864:20::72b;
 envelope-from=iarchivedmywholelife@HIDDEN; helo=mail-qk1-x72b.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)


Transient.el was added in 28.1 according to NEWS.
It is not a member of package--builtin-versions for any of the 
following Emacs versions: 28.1, 28.2, 29.1, 29.2.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: No Wayman <iarchivedmywholelife@HIDDEN>
Subject: bug#69528: Acknowledgement (30.0.50; [BUG] transient.el is not a
 member of package--builtin-versions)
Message-ID: <handler.69528.B.17094867105249.ack <at> debbugs.gnu.org>
References: <87edcrtegz.fsf@HIDDEN>
X-Gnu-PR-Message: ack 69528
X-Gnu-PR-Package: emacs
Reply-To: 69528 <at> debbugs.gnu.org
Date: Sun, 03 Mar 2024 17:26:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 69528 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
69528: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D69528
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: No Wayman <iarchivedmywholelife@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 04 Mar 2024 17:23:02 +0000
Resent-Message-ID: <handler.69528.B.170957292616486 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 69528 <at> debbugs.gnu.org
From: No Wayman <iarchivedmywholelife@HIDDEN>
In-Reply-To: <87edcrtegz.fsf@HIDDEN> (No Wayman's message of "Sun, 03 Mar
 2024 12:25:16 -0500")
References: <87edcrtegz.fsf@HIDDEN>
User-Agent: mu4e 1.12.0; emacs 30.0.50
Date: Mon, 04 Mar 2024 12:22:00 -0500
Message-ID: <87sf15rjyf.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
Received-SPF: pass client-ip=2607:f8b0:4864:20::f2e;
 envelope-from=iarchivedmywholelife@HIDDEN; helo=mail-qv1-xf2e.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

No Wayman <iarchivedmywholelife@HIDDEN> writes:

> Transient.el was added in 28.1 according to NEWS.
> It is not a member of package--builtin-versions for any of the 
> following Emacs
> versions: 28.1, 28.2, 29.1, 29.2.

I believe the behavior described here is due to this:
https://www.reddit.com/r/emacs/comments/1b69v1b/let_magit_330_use_builtin_transient/

To summarize, the user has a built-in version of transient.el 
shipped with Emacs 29.2.
They installed magit 3.3.0, which requires transient 0.3.6. 
Instead of package.el seeing magit's transient.el dependency as 
satisfied by the built-in version, it installed the latest 
version.

I've patched Elpaca, which relies on package--builtin-vesrions, 
due to similar complaints about transient.el being pulled in 
despite the built-in version satisfying a dependency.

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Philip Kaludercic <philipk@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 04 Mar 2024 18:43:02 +0000
Resent-Message-ID: <handler.69528.B69528.170957772924882 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: No Wayman <iarchivedmywholelife@HIDDEN>
Cc: 69528 <at> debbugs.gnu.org
From: Philip Kaludercic <philipk@HIDDEN>
In-Reply-To: <87sf15rjyf.fsf@HIDDEN> (No Wayman's message of "Mon, 04 Mar
 2024 12:22:00 -0500")
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
 url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
 preference=signencrypt
Date: Mon, 04 Mar 2024 18:41:26 +0000
Message-ID: <8734t5yh49.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain

No Wayman <iarchivedmywholelife@HIDDEN> writes:

> No Wayman <iarchivedmywholelife@HIDDEN> writes:
>
>> Transient.el was added in 28.1 according to NEWS.
>> It is not a member of package--builtin-versions for any of the
>> following Emacs
>> versions: 28.1, 28.2, 29.1, 29.2.

At least on Emacs 30, (assq 'transient package--builtin-versions) gives
me a non-nil value.  I can confirm that this is the case on the emacs-29
branch.

I suspect this commit resolved the issue, since
`loaddefs-generate--parse-file' only checks the version header, not the
package-version header.

--8<---------------cut here---------------start------------->8---
commit fa5f06c1251ff717d661f05fcd240b4792054aae
Author: Jonas Bernoulli <jonas@HIDDEN>
Date:   Tue Dec 5 20:01:44 2023 +0100

    ; * lisp/transient.el: Set Version instead of Package-Version
    
    `finder-compile-keywords' only considers the "Version" header.

diff --git a/lisp/transient.el b/lisp/transient.el
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -1,35 +1,35 @@
 ;;; transient.el --- Transient commands  -*- lexical-binding:t -*-
 
 ;; Copyright (C) 2018-2023 Free Software Foundation, Inc.
 
 ;; Author: Jonas Bernoulli <jonas@HIDDEN>
 ;; Homepage: https://github.com/magit/transient
 ;; Keywords: extensions
 
-;; Package-Version: 0.5.2
+;; Version: 0.5.2
 ;; Package-Requires: ((emacs "26.1") (compat "29.1.4.4") (seq "2.24"))
 
 ;; SPDX-License-Identifier: GPL-3.0-or-later
 
 ;; This file is part of GNU Emacs.
 
 ;; GNU Emacs is free software: you can redistribute it and/or modify
 ;; it under the terms of the GNU General Public License as published
 ;; by the Free Software Foundation, either version 3 of the License,
 ;; or (at your option) any later version.
 ;;
 ;; GNU Emacs is distributed in the hope that it will be useful,
 ;; but WITHOUT ANY WARRANTY; without even the implied warranty of
 ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 ;; GNU General Public License for more details.
 ;;
 ;; You should have received a copy of the GNU General Public License
 ;; along with this program.  If not, see <https://www.gnu.org/licenses/>.
 
 ;;; Commentary:
 
 ;; Transient is the library used to implement the keyboard-driven menus
 ;; in Magit.  It is distributed as a separate package, so that it can be
 ;; used to implement similar menus in other packages.
 
 ;;; Code:

--8<---------------cut here---------------end--------------->8---

So in general, this patch might be appropriate?


--=-=-=
Content-Type: text/plain
Content-Disposition: inline

diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
index 581053f6304..42f386933dc 100644
--- a/lisp/emacs-lisp/loaddefs-gen.el
+++ b/lisp/emacs-lisp/loaddefs-gen.el
@@ -433,7 +433,8 @@ loaddefs-generate--parse-file
           ;; loaddefs for packages so that `syntax-ppss' later gives
           ;; correct results.
           (emacs-lisp-mode)
-        (let ((version (lm-header "version"))
+        (let ((version (or (lm-header "package-version")
+                           (lm-header "version")))
               package)
           (when (and version
                      (setq version (ignore-errors (version-to-list version)))

--=-=-=
Content-Type: text/plain


>
> I believe the behavior described here is due to this:
> https://www.reddit.com/r/emacs/comments/1b69v1b/let_magit_330_use_builtin_transient/
>
> To summarize, the user has a built-in version of transient.el shipped
> with Emacs 29.2.
> They installed magit 3.3.0, which requires transient 0.3.6. Instead of
> package.el seeing magit's transient.el dependency as satisfied by the
> built-in version, it installed the latest version.
>
> I've patched Elpaca, which relies on package--builtin-vesrions, due to
> similar complaints about transient.el being pulled in despite the
> built-in version satisfying a dependency. 

I suspect that whatever you did, won't help us since this specific issue
will be resolved by the time any package.el-related fix would be published?

-- 
	Philip Kaludercic on peregrine

--=-=-=--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Joseph Turner <joseph@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 05 Mar 2024 06:21:01 +0000
Resent-Message-ID: <handler.69528.B.17096196213150 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Philip Kaludercic <philipk@HIDDEN>
Cc: 69528 <at> debbugs.gnu.org, iarchivedmywholelife@HIDDEN
X-Debbugs-Original-Cc: bug-gnu-emacs@HIDDEN, No Wayman <iarchivedmywholelife@HIDDEN>, 69528 <at> debbugs.gnu.org
Received: via spool by submit <at> debbugs.gnu.org id=B.17096196213150
          (code B ref -1); Tue, 05 Mar 2024 06:21:01 +0000
Received: (at submit) by debbugs.gnu.org; 5 Mar 2024 06:20:21 +0000
Received: from localhost ([127.0.0.1]:45833 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rhOA1-0000oj-2m
	for submit <at> debbugs.gnu.org; Tue, 05 Mar 2024 01:20:21 -0500
Received: from lists.gnu.org ([209.51.188.17]:60372)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joseph@HIDDEN>) id 1rhO9y-0000ob-UF
 for submit <at> debbugs.gnu.org; Tue, 05 Mar 2024 01:20:20 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <joseph@HIDDEN>)
 id 1rhO9T-0000KS-VP
 for bug-gnu-emacs@HIDDEN; Tue, 05 Mar 2024 01:19:48 -0500
Received: from out-177.mta1.migadu.com ([2001:41d0:203:375::b1])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <joseph@HIDDEN>)
 id 1rhO9P-0000hp-SC
 for bug-gnu-emacs@HIDDEN; Tue, 05 Mar 2024 01:19:47 -0500
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; 
 s=key1; t=1709619579;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=U/wSPqUeIi7awFdaUdt9Xlsr7HdUp0mGi1YswaLazYs=;
 b=ld4KcH1ET7TzF7I6g2wEAHEJx5inpL2ZTzTlUcK3fYhH0s8jc3yX+rch0zUVwqTQQSaI+4
 /JGoocOxFpCcJZCfMCWHOsV7ZHUoxu6noU2dy18QLsXteQbviSMGGJwUcZdAJedMusxA5N
 lZDDBaB3QoQm8y9/TzMo7pUthYH8E0Y=
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
From: Joseph Turner <joseph@HIDDEN>
Date: Mon, 04 Mar 2024 22:17:30 -0800
In-reply-to: <8734t5yh49.fsf@HIDDEN>
Message-ID: <87edcp9p54.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Migadu-Flow: FLOW_OUT
Received-SPF: pass client-ip=2001:41d0:203:375::b1;
 envelope-from=joseph@HIDDEN; helo=out-177.mta1.migadu.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=-=-=
Content-Type: text/plain

Philip Kaludercic <philipk@HIDDEN> writes:
> So in general, this patch might be appropriate?
>
> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
> index 581053f6304..42f386933dc 100644
> --- a/lisp/emacs-lisp/loaddefs-gen.el
> +++ b/lisp/emacs-lisp/loaddefs-gen.el
> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file
>            ;; loaddefs for packages so that `syntax-ppss' later gives
>            ;; correct results.
>            (emacs-lisp-mode)
> -        (let ((version (lm-header "version"))
> +        (let ((version (or (lm-header "package-version")
> +                           (lm-header "version")))
>                package)
>            (when (and version
>                       (setq version (ignore-errors (version-to-list version)))
>
>

What about making `lm-version' handle the "package-version" header then
using `lm-version' in loaddefs-generate--parse-file?  See patches.

Joseph


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=0002-Use-lm-version-instead-of-lm-header-version.patch

From e83ee369ae90e5e15b3adca9eab1ded4db864427 Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@HIDDEN>
Date: Mon, 4 Mar 2024 22:15:50 -0800
Subject: [PATCH 2/2] Use lm-version instead of lm-header "version"

bug#69528

* lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate--parse-file)
---
 lisp/emacs-lisp/loaddefs-gen.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
index 581053f6304..6b24f7dc8c7 100644
--- a/lisp/emacs-lisp/loaddefs-gen.el
+++ b/lisp/emacs-lisp/loaddefs-gen.el
@@ -433,7 +433,7 @@ loaddefs-generate--parse-file
           ;; loaddefs for packages so that `syntax-ppss' later gives
           ;; correct results.
           (emacs-lisp-mode)
-        (let ((version (lm-header "version"))
+        (let ((version (lm-version))
               package)
           (when (and version
                      (setq version (ignore-errors (version-to-list version)))
-- 
2.41.0


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=0001-Check-Package-Version-header-in-lm-version-also.patch

From 20db8c9afcb03d8a5acb750fa738c5066e204401 Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@HIDDEN>
Date: Mon, 4 Mar 2024 22:14:26 -0800
Subject: [PATCH 1/2] Check Package-Version: header in lm-version also

* lisp/emacs-lisp/lisp-mnt.el (lm-version)
---
 lisp/emacs-lisp/lisp-mnt.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/emacs-lisp/lisp-mnt.el b/lisp/emacs-lisp/lisp-mnt.el
index f111a77663c..12b23853801 100644
--- a/lisp/emacs-lisp/lisp-mnt.el
+++ b/lisp/emacs-lisp/lisp-mnt.el
@@ -416,6 +416,7 @@ lm-version
 This can be found in an RCS or SCCS header."
   (lm-with-file file
     (or (lm-header "version")
+        (lm-header "package-version")
         (let ((header-max (lm-code-start)))
 	  (goto-char (point-min))
 	  (cond
-- 
2.41.0


--=-=-=--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Joseph Turner <joseph@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 05 Mar 2024 06:21:02 +0000
Resent-Message-ID: <handler.69528.B69528.17096196533200 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Philip Kaludercic <philipk@HIDDEN>
Cc: 69528 <at> debbugs.gnu.org, iarchivedmywholelife@HIDDEN
X-Debbugs-Original-Cc: bug-gnu-emacs@HIDDEN, No Wayman <iarchivedmywholelife@HIDDEN>, 69528 <at> debbugs.gnu.org
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.17096196533200
          (code B ref 69528); Tue, 05 Mar 2024 06:21:02 +0000
Received: (at 69528) by debbugs.gnu.org; 5 Mar 2024 06:20:53 +0000
Received: from localhost ([127.0.0.1]:45836 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rhOAV-0000pX-M3
	for submit <at> debbugs.gnu.org; Tue, 05 Mar 2024 01:20:53 -0500
Received: from out-180.mta1.migadu.com ([95.215.58.180]:62192)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joseph@HIDDEN>) id 1rhOAQ-0000pF-8F
 for 69528 <at> debbugs.gnu.org; Tue, 05 Mar 2024 01:20:49 -0500
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; 
 s=key1; t=1709619579;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=U/wSPqUeIi7awFdaUdt9Xlsr7HdUp0mGi1YswaLazYs=;
 b=ld4KcH1ET7TzF7I6g2wEAHEJx5inpL2ZTzTlUcK3fYhH0s8jc3yX+rch0zUVwqTQQSaI+4
 /JGoocOxFpCcJZCfMCWHOsV7ZHUoxu6noU2dy18QLsXteQbviSMGGJwUcZdAJedMusxA5N
 lZDDBaB3QoQm8y9/TzMo7pUthYH8E0Y=
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
From: Joseph Turner <joseph@HIDDEN>
Date: Mon, 04 Mar 2024 22:17:30 -0800
In-reply-to: <8734t5yh49.fsf@HIDDEN>
Message-ID: <87edcp9p54.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain

Philip Kaludercic <philipk@HIDDEN> writes:
> So in general, this patch might be appropriate?
>
> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
> index 581053f6304..42f386933dc 100644
> --- a/lisp/emacs-lisp/loaddefs-gen.el
> +++ b/lisp/emacs-lisp/loaddefs-gen.el
> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file
>            ;; loaddefs for packages so that `syntax-ppss' later gives
>            ;; correct results.
>            (emacs-lisp-mode)
> -        (let ((version (lm-header "version"))
> +        (let ((version (or (lm-header "package-version")
> +                           (lm-header "version")))
>                package)
>            (when (and version
>                       (setq version (ignore-errors (version-to-list version)))
>
>

What about making `lm-version' handle the "package-version" header then
using `lm-version' in loaddefs-generate--parse-file?  See patches.

Joseph


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=0002-Use-lm-version-instead-of-lm-header-version.patch

From e83ee369ae90e5e15b3adca9eab1ded4db864427 Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@HIDDEN>
Date: Mon, 4 Mar 2024 22:15:50 -0800
Subject: [PATCH 2/2] Use lm-version instead of lm-header "version"

bug#69528

* lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate--parse-file)
---
 lisp/emacs-lisp/loaddefs-gen.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
index 581053f6304..6b24f7dc8c7 100644
--- a/lisp/emacs-lisp/loaddefs-gen.el
+++ b/lisp/emacs-lisp/loaddefs-gen.el
@@ -433,7 +433,7 @@ loaddefs-generate--parse-file
           ;; loaddefs for packages so that `syntax-ppss' later gives
           ;; correct results.
           (emacs-lisp-mode)
-        (let ((version (lm-header "version"))
+        (let ((version (lm-version))
               package)
           (when (and version
                      (setq version (ignore-errors (version-to-list version)))
-- 
2.41.0


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=0001-Check-Package-Version-header-in-lm-version-also.patch

From 20db8c9afcb03d8a5acb750fa738c5066e204401 Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@HIDDEN>
Date: Mon, 4 Mar 2024 22:14:26 -0800
Subject: [PATCH 1/2] Check Package-Version: header in lm-version also

* lisp/emacs-lisp/lisp-mnt.el (lm-version)
---
 lisp/emacs-lisp/lisp-mnt.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/emacs-lisp/lisp-mnt.el b/lisp/emacs-lisp/lisp-mnt.el
index f111a77663c..12b23853801 100644
--- a/lisp/emacs-lisp/lisp-mnt.el
+++ b/lisp/emacs-lisp/lisp-mnt.el
@@ -416,6 +416,7 @@ lm-version
 This can be found in an RCS or SCCS header."
   (lm-with-file file
     (or (lm-header "version")
+        (lm-header "package-version")
         (let ((header-max (lm-code-start)))
 	  (goto-char (point-min))
 	  (cond
-- 
2.41.0


--=-=-=--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Joseph Turner <joseph@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 09 May 2024 06:55:01 +0000
Resent-Message-ID: <handler.69528.B.171523766826161 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Philip Kaludercic <philipk@HIDDEN>
Cc: 69528 <at> debbugs.gnu.org, iarchivedmywholelife@HIDDEN
X-Debbugs-Original-Cc: bug-gnu-emacs@HIDDEN, No Wayman <iarchivedmywholelife@HIDDEN>, 69528 <at> debbugs.gnu.org
Received: via spool by submit <at> debbugs.gnu.org id=B.171523766826161
          (code B ref -1); Thu, 09 May 2024 06:55:01 +0000
Received: (at submit) by debbugs.gnu.org; 9 May 2024 06:54:28 +0000
Received: from localhost ([127.0.0.1]:53444 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s4xff-0006nt-OI
	for submit <at> debbugs.gnu.org; Thu, 09 May 2024 02:54:28 -0400
Received: from lists.gnu.org ([2001:470:142::17]:45034)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joseph@HIDDEN>) id 1s4xfa-0006nX-N6
 for submit <at> debbugs.gnu.org; Thu, 09 May 2024 02:54:25 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <joseph@HIDDEN>)
 id 1s4xf4-0004Qc-8a
 for bug-gnu-emacs@HIDDEN; Thu, 09 May 2024 02:53:50 -0400
Received: from out-174.mta1.migadu.com ([95.215.58.174])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <joseph@HIDDEN>)
 id 1s4xf2-0005IE-0g
 for bug-gnu-emacs@HIDDEN; Thu, 09 May 2024 02:53:50 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; 
 s=key1; t=1715237623;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=EHMj+LLE8x1MyzVijC/CRMo9U6u5nZMk3k0WC3BItxc=;
 b=GZUEXMAepkBc1NcQdOCjRojO303gpk6wvcDfJRNmv7ZEW58B5sPuFk9J87VxnoYI4rYBE7
 Q2RaDnOL8BM7VfXEQDKtrcDgHFuacNGGR0a8TAm18DXSvM7CZ35OpdbpG+G8rYVmvZe/aA
 YLe4u98f/Vy2Qw0W8+LrhDKWpGljyX4=
From: Joseph Turner <joseph@HIDDEN>
In-Reply-To: <87edcp9p54.fsf@HIDDEN> (Joseph Turner's message of
 "Mon, 04 Mar 2024 22:17:30 -0800")
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
Date: Wed, 08 May 2024 23:53:38 -0700
Message-ID: <87r0eb79xp.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
Received-SPF: pass client-ip=95.215.58.174;
 envelope-from=joseph@HIDDEN; helo=out-174.mta1.migadu.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

Joseph Turner <joseph@HIDDEN> writes:

> Philip Kaludercic <philipk@HIDDEN> writes:
>> So in general, this patch might be appropriate?
>>
>> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
>> index 581053f6304..42f386933dc 100644
>> --- a/lisp/emacs-lisp/loaddefs-gen.el
>> +++ b/lisp/emacs-lisp/loaddefs-gen.el
>> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file
>>            ;; loaddefs for packages so that `syntax-ppss' later gives
>>            ;; correct results.
>>            (emacs-lisp-mode)
>> -        (let ((version (lm-header "version"))
>> +        (let ((version (or (lm-header "package-version")
>> +                           (lm-header "version")))
>>                package)
>>            (when (and version
>>                       (setq version (ignore-errors (version-to-list version)))
>>
>>
>
> What about making `lm-version' handle the "package-version" header then
> using `lm-version' in loaddefs-generate--parse-file?  See patches.
>
> Joseph
>
> [2. text/x-diff; 0002-Use-lm-version-instead-of-lm-header-version.patch]...
>
> [3. text/x-diff; 0001-Check-Package-Version-header-in-lm-version-also.patch]...

Ping!

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Joseph Turner <joseph@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 09 May 2024 06:55:02 +0000
Resent-Message-ID: <handler.69528.B69528.171523766526149 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Philip Kaludercic <philipk@HIDDEN>
Cc: 69528 <at> debbugs.gnu.org, iarchivedmywholelife@HIDDEN
X-Debbugs-Original-Cc: bug-gnu-emacs@HIDDEN, No Wayman <iarchivedmywholelife@HIDDEN>, 69528 <at> debbugs.gnu.org
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171523766526149
          (code B ref 69528); Thu, 09 May 2024 06:55:02 +0000
Received: (at 69528) by debbugs.gnu.org; 9 May 2024 06:54:25 +0000
Received: from localhost ([127.0.0.1]:53441 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s4xfa-0006nf-F3
	for submit <at> debbugs.gnu.org; Thu, 09 May 2024 02:54:25 -0400
Received: from out-170.mta1.migadu.com ([2001:41d0:203:375::aa]:49171)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joseph@HIDDEN>) id 1s4xfV-0006nW-7l
 for 69528 <at> debbugs.gnu.org; Thu, 09 May 2024 02:54:20 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; 
 s=key1; t=1715237623;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=EHMj+LLE8x1MyzVijC/CRMo9U6u5nZMk3k0WC3BItxc=;
 b=GZUEXMAepkBc1NcQdOCjRojO303gpk6wvcDfJRNmv7ZEW58B5sPuFk9J87VxnoYI4rYBE7
 Q2RaDnOL8BM7VfXEQDKtrcDgHFuacNGGR0a8TAm18DXSvM7CZ35OpdbpG+G8rYVmvZe/aA
 YLe4u98f/Vy2Qw0W8+LrhDKWpGljyX4=
From: Joseph Turner <joseph@HIDDEN>
In-Reply-To: <87edcp9p54.fsf@HIDDEN> (Joseph Turner's message of
 "Mon, 04 Mar 2024 22:17:30 -0800")
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
Date: Wed, 08 May 2024 23:53:38 -0700
Message-ID: <87r0eb79xp.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Joseph Turner <joseph@HIDDEN> writes:

> Philip Kaludercic <philipk@HIDDEN> writes:
>> So in general, this patch might be appropriate?
>>
>> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
>> index 581053f6304..42f386933dc 100644
>> --- a/lisp/emacs-lisp/loaddefs-gen.el
>> +++ b/lisp/emacs-lisp/loaddefs-gen.el
>> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file
>>            ;; loaddefs for packages so that `syntax-ppss' later gives
>>            ;; correct results.
>>            (emacs-lisp-mode)
>> -        (let ((version (lm-header "version"))
>> +        (let ((version (or (lm-header "package-version")
>> +                           (lm-header "version")))
>>                package)
>>            (when (and version
>>                       (setq version (ignore-errors (version-to-list version)))
>>
>>
>
> What about making `lm-version' handle the "package-version" header then
> using `lm-version' in loaddefs-generate--parse-file?  See patches.
>
> Joseph
>
> [2. text/x-diff; 0002-Use-lm-version-instead-of-lm-header-version.patch]...
>
> [3. text/x-diff; 0001-Check-Package-Version-header-in-lm-version-also.patch]...

Ping!

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 25 May 2024 07:40:02 +0000
Resent-Message-ID: <handler.69528.B69528.171662277726253 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Joseph Turner <joseph@HIDDEN>
Cc: philipk@HIDDEN, 69528 <at> debbugs.gnu.org, iarchivedmywholelife@HIDDEN
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171662277726253
          (code B ref 69528); Sat, 25 May 2024 07:40:02 +0000
Received: (at 69528) by debbugs.gnu.org; 25 May 2024 07:39:37 +0000
Received: from localhost ([127.0.0.1]:41800 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sAm06-0006pN-0c
	for submit <at> debbugs.gnu.org; Sat, 25 May 2024 03:39:37 -0400
Received: from eggs.gnu.org ([209.51.188.92]:34012)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1sAm03-0006pH-S9
 for 69528 <at> debbugs.gnu.org; Sat, 25 May 2024 03:39:32 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1sAlzr-0005hZ-08; Sat, 25 May 2024 03:39:19 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=zC/Lm0fNAA08sW9xs4wKv1HW/PgTyznK4uqH/k9Tukk=; b=S6JxNcXD3gN4
 r7uS8cqX3sIxEGA60i1oF/qHu/0/7m5R/Qi/BwNEqk/3/6RUu9i96JkDOidgRuOz36eW/wyJ+LTVu
 a6tf3dy2L3B0hgbnANjekQ4Ke32DmZ/M7Vfu37D37KGmfSXEnotOWWQZh7e86z84NIO+RaNCQXSrk
 AFwD9uYgKnolYKOFHZPYHJHcZMhNn7QkZzmvs7SonSl1Iw5ZMGN+TuuzydwpqeLrVPjq7K66mn8aj
 yot8mmClLKiIMsAeoHXrEYRdDoOfxxDk4/5iXKo6RDNd0JmYrqk5962Lvs50gHEFs0pFWq/eDkys6
 tc/emWjII317yxnZY2e1uQ==;
Date: Sat, 25 May 2024 10:39:16 +0300
Message-Id: <86bk4u1gt7.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87r0eb79xp.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN)
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <87r0eb79xp.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Ping! Ping!  Philip, can you please chime in?

> Cc: 69528 <at> debbugs.gnu.org, iarchivedmywholelife@HIDDEN
> Date: Wed, 08 May 2024 23:53:38 -0700
> From:  Joseph Turner via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> Joseph Turner <joseph@HIDDEN> writes:
> 
> > Philip Kaludercic <philipk@HIDDEN> writes:
> >> So in general, this patch might be appropriate?
> >>
> >> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
> >> index 581053f6304..42f386933dc 100644
> >> --- a/lisp/emacs-lisp/loaddefs-gen.el
> >> +++ b/lisp/emacs-lisp/loaddefs-gen.el
> >> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file
> >>            ;; loaddefs for packages so that `syntax-ppss' later gives
> >>            ;; correct results.
> >>            (emacs-lisp-mode)
> >> -        (let ((version (lm-header "version"))
> >> +        (let ((version (or (lm-header "package-version")
> >> +                           (lm-header "version")))
> >>                package)
> >>            (when (and version
> >>                       (setq version (ignore-errors (version-to-list version)))
> >>
> >>
> >
> > What about making `lm-version' handle the "package-version" header then
> > using `lm-version' in loaddefs-generate--parse-file?  See patches.
> >
> > Joseph

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Philip Kaludercic <philipk@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 25 May 2024 08:05:02 +0000
Resent-Message-ID: <handler.69528.B69528.171662428327376 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Joseph Turner <joseph@HIDDEN>
Cc: 69528 <at> debbugs.gnu.org, iarchivedmywholelife@HIDDEN
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171662428327376
          (code B ref 69528); Sat, 25 May 2024 08:05:02 +0000
Received: (at 69528) by debbugs.gnu.org; 25 May 2024 08:04:43 +0000
Received: from localhost ([127.0.0.1]:41969 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sAmOQ-00077U-Jq
	for submit <at> debbugs.gnu.org; Sat, 25 May 2024 04:04:43 -0400
Received: from mout02.posteo.de ([185.67.36.66]:42559)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1sAmON-00077O-Ry
 for 69528 <at> debbugs.gnu.org; Sat, 25 May 2024 04:04:41 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id D7B4D240103
 for <69528 <at> debbugs.gnu.org>; Sat, 25 May 2024 10:04:25 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1716624265; bh=3jJlBWVl9c6NqQI5HxGMGzFSwsqWhaugNjNHWowcC3M=;
 h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version:
 Content-Type:From;
 b=H4oq/xqVl3iM3YLKBDprBtKurXVqMbJgIMIXK9sFvTexZI2XcIGzDOJKTnQYYY26c
 mp0Bf1iOhmhXFiv4IJrNwo1awFkjn7PkXwKeJkRhODQNU1EWz5c3tiAJRIqlK9IWJO
 6cBoqZfY3nGCFqMGIxUD8p4rTwLyA/UTmzDgGbHIc7zohVps1VAEb2uf1ShQdtDaUz
 BqvGbKYqvtX5Y1drJTSPNVeExks7Djpzks4x4rLAVhiwpvqmXBGboJU16OP3WVG+XK
 eYm+51Wbej8j0rP+xKq4G+uJ+2eMiPdmRv6sx0CD1eqLRQoSWGEqQuvFuLpDv2lGc3
 vSIZYyzlLMPoQ==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4VmZF4707Zz9rxF;
 Sat, 25 May 2024 10:04:24 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
In-Reply-To: <87edcp9p54.fsf@HIDDEN> (Joseph Turner's message of
 "Mon, 04 Mar 2024 22:17:30 -0800")
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
 url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
 preference=signencrypt
Date: Sat, 25 May 2024 08:04:24 +0000
Message-ID: <878qzypbav.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Joseph Turner <joseph@HIDDEN> writes:

> Philip Kaludercic <philipk@HIDDEN> writes:
>> So in general, this patch might be appropriate?
>>
>> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
>> index 581053f6304..42f386933dc 100644
>> --- a/lisp/emacs-lisp/loaddefs-gen.el
>> +++ b/lisp/emacs-lisp/loaddefs-gen.el
>> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file
>>            ;; loaddefs for packages so that `syntax-ppss' later gives
>>            ;; correct results.
>>            (emacs-lisp-mode)
>> -        (let ((version (lm-header "version"))
>> +        (let ((version (or (lm-header "package-version")
>> +                           (lm-header "version")))
>>                package)
>>            (when (and version
>>                       (setq version (ignore-errors (version-to-list version)))
>>
>>
>
> What about making `lm-version' handle the "package-version" header then
> using `lm-version' in loaddefs-generate--parse-file?  See patches.

My main concern was if we want to have Package-Version always override
Version, but if my patch modified loaddefs-gen, then I don't think there
is much of a difference if we change lisp-mnt instead (in terms of the
generality of the change).

So I am fine with the change, and think we can merge it.  Eli: Is master
still fine for these kinds of changes?

> Joseph
>
>>From e83ee369ae90e5e15b3adca9eab1ded4db864427 Mon Sep 17 00:00:00 2001
> From: Joseph Turner <joseph@HIDDEN>
> Date: Mon, 4 Mar 2024 22:15:50 -0800
> Subject: [PATCH 2/2] Use lm-version instead of lm-header "version"
>
> bug#69528
>
> * lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate--parse-file)
> ---
>  lisp/emacs-lisp/loaddefs-gen.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
> index 581053f6304..6b24f7dc8c7 100644
> --- a/lisp/emacs-lisp/loaddefs-gen.el
> +++ b/lisp/emacs-lisp/loaddefs-gen.el
> @@ -433,7 +433,7 @@ loaddefs-generate--parse-file
>            ;; loaddefs for packages so that `syntax-ppss' later gives
>            ;; correct results.
>            (emacs-lisp-mode)
> -        (let ((version (lm-header "version"))
> +        (let ((version (lm-version))
>                package)
>            (when (and version
>                       (setq version (ignore-errors (version-to-list version)))
> -- 
> 2.41.0
>
>
>>From 20db8c9afcb03d8a5acb750fa738c5066e204401 Mon Sep 17 00:00:00 2001
> From: Joseph Turner <joseph@HIDDEN>
> Date: Mon, 4 Mar 2024 22:14:26 -0800
> Subject: [PATCH 1/2] Check Package-Version: header in lm-version also
>
> * lisp/emacs-lisp/lisp-mnt.el (lm-version)
> ---
>  lisp/emacs-lisp/lisp-mnt.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lisp/emacs-lisp/lisp-mnt.el b/lisp/emacs-lisp/lisp-mnt.el
> index f111a77663c..12b23853801 100644
> --- a/lisp/emacs-lisp/lisp-mnt.el
> +++ b/lisp/emacs-lisp/lisp-mnt.el
> @@ -416,6 +416,7 @@ lm-version
>  This can be found in an RCS or SCCS header."
>    (lm-with-file file
>      (or (lm-header "version")
> +        (lm-header "package-version")
>          (let ((header-max (lm-code-start)))
>  	  (goto-char (point-min))
>  	  (cond

Joseph Turner <joseph@HIDDEN> writes:

> Joseph Turner <joseph@HIDDEN> writes:
>
>> Philip Kaludercic <philipk@HIDDEN> writes:
>>> So in general, this patch might be appropriate?
>>>
>>> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
>>> index 581053f6304..42f386933dc 100644
>>> --- a/lisp/emacs-lisp/loaddefs-gen.el
>>> +++ b/lisp/emacs-lisp/loaddefs-gen.el
>>> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file
>>>            ;; loaddefs for packages so that `syntax-ppss' later gives
>>>            ;; correct results.
>>>            (emacs-lisp-mode)
>>> -        (let ((version (lm-header "version"))
>>> +        (let ((version (or (lm-header "package-version")
>>> +                           (lm-header "version")))
>>>                package)
>>>            (when (and version
>>>                       (setq version (ignore-errors (version-to-list version)))
>>>
>>>
>>
>> What about making `lm-version' handle the "package-version" header then
>> using `lm-version' in loaddefs-generate--parse-file?  See patches.
>>
>> Joseph
>>
>> [2. text/x-diff; 0002-Use-lm-version-instead-of-lm-header-version.patch]...
>>
>> [3. text/x-diff; 0001-Check-Package-Version-header-in-lm-version-also.patch]...
>
> Ping!
>
>
>
>

Eli Zaretskii <eliz@HIDDEN> writes:

> Ping! Ping!  Philip, can you please chime in?
>
>> Cc: 69528 <at> debbugs.gnu.org, iarchivedmywholelife@HIDDEN
>> Date: Wed, 08 May 2024 23:53:38 -0700
>> From:  Joseph Turner via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>> 
>> Joseph Turner <joseph@HIDDEN> writes:
>> 
>> > Philip Kaludercic <philipk@HIDDEN> writes:
>> >> So in general, this patch might be appropriate?
>> >>
>> >> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
>> >> index 581053f6304..42f386933dc 100644
>> >> --- a/lisp/emacs-lisp/loaddefs-gen.el
>> >> +++ b/lisp/emacs-lisp/loaddefs-gen.el
>> >> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file
>> >>            ;; loaddefs for packages so that `syntax-ppss' later gives
>> >>            ;; correct results.
>> >>            (emacs-lisp-mode)
>> >> -        (let ((version (lm-header "version"))
>> >> +        (let ((version (or (lm-header "package-version")
>> >> +                           (lm-header "version")))
>> >>                package)
>> >>            (when (and version
>> >>                       (setq version (ignore-errors (version-to-list version)))
>> >>
>> >>
>> >
>> > What about making `lm-version' handle the "package-version" header then
>> > using `lm-version' in loaddefs-generate--parse-file?  See patches.
>> >
>> > Joseph
>
>
>
>

-- 
	Philip Kaludercic on peregrine

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Joseph Turner <joseph@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 25 May 2024 08:09:02 +0000
Resent-Message-ID: <handler.69528.B69528.171662451027507 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Philip Kaludercic <philipk@HIDDEN>
Cc: eliz@HIDDEN, 69528 <at> debbugs.gnu.org, iarchivedmywholelife@HIDDEN
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171662451027507
          (code B ref 69528); Sat, 25 May 2024 08:09:02 +0000
Received: (at 69528) by debbugs.gnu.org; 25 May 2024 08:08:30 +0000
Received: from localhost ([127.0.0.1]:41987 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sAmS5-00079b-Fs
	for submit <at> debbugs.gnu.org; Sat, 25 May 2024 04:08:30 -0400
Received: from out-177.mta0.migadu.com ([91.218.175.177]:60447)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joseph@HIDDEN>) id 1sAmS3-00079T-HD
 for 69528 <at> debbugs.gnu.org; Sat, 25 May 2024 04:08:28 -0400
X-Envelope-To: philipk@HIDDEN
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; 
 s=key1; t=1716624493;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=j3U2I3F+Kddg2uVrvC7i8vKO8eJmaV+ohwtHoRirByc=;
 b=FyN1MMIJhNGg0PxN8A3reDaeQE2iIb5WXZ3DSc3SY82inw81bBenpUkNOQdgA5QThPnMMF
 JJ6r6VxP3/9m3XqRzZ9GyKqUJ+wbc8pRbZ1DH2PtKWC9jvFEzEIwpBQtsLCqCvNzX4SYIu
 Nl3FohSCi/MalfwREgGV/uSG/7GyFvQ=
X-Envelope-To: 69528 <at> debbugs.gnu.org
X-Envelope-To: iarchivedmywholelife@HIDDEN
X-Envelope-To: eliz@HIDDEN
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
From: Joseph Turner <joseph@HIDDEN>
In-Reply-To: <878qzypbav.fsf@HIDDEN> (Philip Kaludercic's message of "Sat, 
 25 May 2024 08:04:24 +0000")
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN>
Date: Sat, 25 May 2024 01:08:08 -0700
Message-ID: <87o78ul3fb.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Philip Kaludercic <philipk@HIDDEN> writes:

> Joseph Turner <joseph@HIDDEN> writes:
>
>> Philip Kaludercic <philipk@HIDDEN> writes:
>>> So in general, this patch might be appropriate?
>>>
>>> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
>>> index 581053f6304..42f386933dc 100644
>>> --- a/lisp/emacs-lisp/loaddefs-gen.el
>>> +++ b/lisp/emacs-lisp/loaddefs-gen.el
>>> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file
>>>            ;; loaddefs for packages so that `syntax-ppss' later gives
>>>            ;; correct results.
>>>            (emacs-lisp-mode)
>>> -        (let ((version (lm-header "version"))
>>> +        (let ((version (or (lm-header "package-version")
>>> +                           (lm-header "version")))
>>>                package)
>>>            (when (and version
>>>                       (setq version (ignore-errors (version-to-list version)))
>>>
>>>
>>
>> What about making `lm-version' handle the "package-version" header then
>> using `lm-version' in loaddefs-generate--parse-file?  See patches.
>
> My main concern was if we want to have Package-Version always override
> Version, but if my patch modified loaddefs-gen, then I don't think there
> is much of a difference if we change lisp-mnt instead (in terms of the
> generality of the change).

If it would be more appropriate, I can resubmit another patch with
"Version" used preferentially over "Package-Version".

> So I am fine with the change, and think we can merge it.  Eli: Is master
> still fine for these kinds of changes?
>
>> Joseph
>>
>>>From e83ee369ae90e5e15b3adca9eab1ded4db864427 Mon Sep 17 00:00:00 2001
>> From: Joseph Turner <joseph@HIDDEN>
>> Date: Mon, 4 Mar 2024 22:15:50 -0800
>> Subject: [PATCH 2/2] Use lm-version instead of lm-header "version"
>>
>> bug#69528
>>
>> * lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate--parse-file)
>> ---
>>  lisp/emacs-lisp/loaddefs-gen.el | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
>> index 581053f6304..6b24f7dc8c7 100644
>> --- a/lisp/emacs-lisp/loaddefs-gen.el
>> +++ b/lisp/emacs-lisp/loaddefs-gen.el
>> @@ -433,7 +433,7 @@ loaddefs-generate--parse-file
>>            ;; loaddefs for packages so that `syntax-ppss' later gives
>>            ;; correct results.
>>            (emacs-lisp-mode)
>> -        (let ((version (lm-header "version"))
>> +        (let ((version (lm-version))
>>                package)
>>            (when (and version
>>                       (setq version (ignore-errors (version-to-list version)))
>> -- 
>> 2.41.0
>>
>>
>>>From 20db8c9afcb03d8a5acb750fa738c5066e204401 Mon Sep 17 00:00:00 2001
>> From: Joseph Turner <joseph@HIDDEN>
>> Date: Mon, 4 Mar 2024 22:14:26 -0800
>> Subject: [PATCH 1/2] Check Package-Version: header in lm-version also
>>
>> * lisp/emacs-lisp/lisp-mnt.el (lm-version)
>> ---
>>  lisp/emacs-lisp/lisp-mnt.el | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lisp/emacs-lisp/lisp-mnt.el b/lisp/emacs-lisp/lisp-mnt.el
>> index f111a77663c..12b23853801 100644
>> --- a/lisp/emacs-lisp/lisp-mnt.el
>> +++ b/lisp/emacs-lisp/lisp-mnt.el
>> @@ -416,6 +416,7 @@ lm-version
>>  This can be found in an RCS or SCCS header."
>>    (lm-with-file file
>>      (or (lm-header "version")
>> +        (lm-header "package-version")
>>          (let ((header-max (lm-code-start)))
>>  	  (goto-char (point-min))
>>  	  (cond
>
> Joseph Turner <joseph@HIDDEN> writes:
>
>> Joseph Turner <joseph@HIDDEN> writes:
>>
>>> Philip Kaludercic <philipk@HIDDEN> writes:
>>>> So in general, this patch might be appropriate?
>>>>
>>>> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
>>>> index 581053f6304..42f386933dc 100644
>>>> --- a/lisp/emacs-lisp/loaddefs-gen.el
>>>> +++ b/lisp/emacs-lisp/loaddefs-gen.el
>>>> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file
>>>>            ;; loaddefs for packages so that `syntax-ppss' later gives
>>>>            ;; correct results.
>>>>            (emacs-lisp-mode)
>>>> -        (let ((version (lm-header "version"))
>>>> +        (let ((version (or (lm-header "package-version")
>>>> +                           (lm-header "version")))
>>>>                package)
>>>>            (when (and version
>>>>                       (setq version (ignore-errors (version-to-list version)))
>>>>
>>>>
>>>
>>> What about making `lm-version' handle the "package-version" header then
>>> using `lm-version' in loaddefs-generate--parse-file?  See patches.
>>>
>>> Joseph
>>>
>>> [2. text/x-diff; 0002-Use-lm-version-instead-of-lm-header-version.patch]...
>>>
>>> [3. text/x-diff; 0001-Check-Package-Version-header-in-lm-version-also.patch]...
>>
>> Ping!
>>
>>
>>
>>
>
> Eli Zaretskii <eliz@HIDDEN> writes:
>
>> Ping! Ping!  Philip, can you please chime in?
>>
>>> Cc: 69528 <at> debbugs.gnu.org, iarchivedmywholelife@HIDDEN
>>> Date: Wed, 08 May 2024 23:53:38 -0700
>>> From:  Joseph Turner via "Bug reports for GNU Emacs,
>>>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>>> 
>>> Joseph Turner <joseph@HIDDEN> writes:
>>> 
>>> > Philip Kaludercic <philipk@HIDDEN> writes:
>>> >> So in general, this patch might be appropriate?
>>> >>
>>> >> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
>>> >> index 581053f6304..42f386933dc 100644
>>> >> --- a/lisp/emacs-lisp/loaddefs-gen.el
>>> >> +++ b/lisp/emacs-lisp/loaddefs-gen.el
>>> >> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file
>>> >>            ;; loaddefs for packages so that `syntax-ppss' later gives
>>> >>            ;; correct results.
>>> >>            (emacs-lisp-mode)
>>> >> -        (let ((version (lm-header "version"))
>>> >> +        (let ((version (or (lm-header "package-version")
>>> >> +                           (lm-header "version")))
>>> >>                package)
>>> >>            (when (and version
>>> >>                       (setq version (ignore-errors (version-to-list version)))
>>> >>
>>> >>
>>> >
>>> > What about making `lm-version' handle the "package-version" header then
>>> > using `lm-version' in loaddefs-generate--parse-file?  See patches.
>>> >
>>> > Joseph
>>
>>
>>
>>

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Philip Kaludercic <philipk@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 25 May 2024 08:48:01 +0000
Resent-Message-ID: <handler.69528.B69528.171662687428735 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Joseph Turner <joseph@HIDDEN>
Cc: eliz@HIDDEN, 69528 <at> debbugs.gnu.org, iarchivedmywholelife@HIDDEN
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171662687428735
          (code B ref 69528); Sat, 25 May 2024 08:48:01 +0000
Received: (at 69528) by debbugs.gnu.org; 25 May 2024 08:47:54 +0000
Received: from localhost ([127.0.0.1]:42142 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sAn4D-0007TP-P4
	for submit <at> debbugs.gnu.org; Sat, 25 May 2024 04:47:54 -0400
Received: from mout01.posteo.de ([185.67.36.65]:47637)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1sAn4B-0007TE-3a
 for 69528 <at> debbugs.gnu.org; Sat, 25 May 2024 04:47:51 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 13402240028
 for <69528 <at> debbugs.gnu.org>; Sat, 25 May 2024 10:47:38 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1716626858; bh=yaiYTkajEsGUSnQV1EOKRmFYYqEqcUsbfu9Vci5lBCM=;
 h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version:
 Content-Type:Content-Transfer-Encoding:From;
 b=Ga2Y6ymZ5mshBMb2a2BBhlzICmK08HpXz6/G4aongktz9cCfh5+77YqGEKJFSTJwP
 sr/y2ZzSWY56C8DDVC1hP0Ngo1l3CJYdbbvoTaOkmr0g8D+9O5ufomAyCzx3w/mnpU
 50+z/edH+WnYtacNhFTRgb+e5KC2pGEeqL0niXbdim46UNzdJwSKwW48t2XvS3//Qm
 vV+jp8iOv940Ypbzm6PtkMDPVZsTCrOPDmgrGa7TuiCpUOTMZOTfnE0diDLt9j0Cal
 pLpPtQAba+c30UX4XuTwagh7ax6gH1Q/bQyumdVaV6rJxGeampVyJB+Q0XGaMreavD
 x8SsTVG1zMRgQ==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4VmbBx2vLmz6tvt;
 Sat, 25 May 2024 10:47:37 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
In-Reply-To: <87o78ul3fb.fsf@HIDDEN> (Joseph Turner's message of
 "Sat, 25 May 2024 01:08:08 -0700")
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN> <87o78ul3fb.fsf@HIDDEN>
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
 url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
 preference=signencrypt
Date: Sat, 25 May 2024 08:47:36 +0000
Message-ID: <87pltanuqf.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Joseph Turner <joseph@HIDDEN> writes:

> Philip Kaludercic <philipk@HIDDEN> writes:
>
>> Joseph Turner <joseph@HIDDEN> writes:
>>
>>> Philip Kaludercic <philipk@HIDDEN> writes:
>>>> So in general, this patch might be appropriate?
>>>>
>>>> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddef=
s-gen.el
>>>> index 581053f6304..42f386933dc 100644
>>>> --- a/lisp/emacs-lisp/loaddefs-gen.el
>>>> +++ b/lisp/emacs-lisp/loaddefs-gen.el
>>>> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file
>>>>            ;; loaddefs for packages so that `syntax-ppss' later gives
>>>>            ;; correct results.
>>>>            (emacs-lisp-mode)
>>>> -        (let ((version (lm-header "version"))
>>>> +        (let ((version (or (lm-header "package-version")
>>>> +                           (lm-header "version")))
>>>>                package)
>>>>            (when (and version
>>>>                       (setq version (ignore-errors (version-to-list ve=
rsion)))
>>>>
>>>>
>>>
>>> What about making `lm-version' handle the "package-version" header then
>>> using `lm-version' in loaddefs-generate--parse-file?  See patches.
>>
>> My main concern was if we want to have Package-Version always override
>> Version, but if my patch modified loaddefs-gen, then I don't think there
>> is much of a difference if we change lisp-mnt instead (in terms of the
>> generality of the change).
>
> If it would be more appropriate, I can resubmit another patch with
> "Version" used preferentially over "Package-Version".

No, I believe that would be wrong, at least going by these quotes from
the manual:

(elisp) Simple Packages:

     The version number comes from the =E2=80=98Package-Version=E2=80=99 he=
ader, if it
  exists, or from the =E2=80=98Version=E2=80=99 header otherwise.  One or t=
he other _must_
  be present.  Here, the version number is 1.3.

(elisp) Library Headers:

  =E2=80=98Package-Version=E2=80=99
       If =E2=80=98Version=E2=80=99 is not suitable for use by the package =
manager, then a
       package can define =E2=80=98Package-Version=E2=80=99; it will be use=
d instead.
       This is handy if =E2=80=98Version=E2=80=99 is an RCS id or something=
 else that
       cannot be parsed by =E2=80=98version-to-list=E2=80=99.

So the patch is fine as it is.

--=20
	Philip Kaludercic on peregrine

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 25 May 2024 10:50:02 +0000
Resent-Message-ID: <handler.69528.B69528.171663418014931 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Philip Kaludercic <philipk@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>
Cc: iarchivedmywholelife@HIDDEN, 69528 <at> debbugs.gnu.org, joseph@HIDDEN
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171663418014931
          (code B ref 69528); Sat, 25 May 2024 10:50:02 +0000
Received: (at 69528) by debbugs.gnu.org; 25 May 2024 10:49:40 +0000
Received: from localhost ([127.0.0.1]:42735 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sAoy3-0003sl-Mn
	for submit <at> debbugs.gnu.org; Sat, 25 May 2024 06:49:40 -0400
Received: from eggs.gnu.org ([209.51.188.92]:56640)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1sAoy1-0003sP-KN
 for 69528 <at> debbugs.gnu.org; Sat, 25 May 2024 06:49:38 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1sAoxm-0002S8-Ow; Sat, 25 May 2024 06:49:22 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=l+BK+P2qHAAJBI3a4Um63eQrWGy77o+nXsY2bKANjas=; b=p4+0ib8UxzR3
 J6BRAu3jYI3qV0uzQ+5vTY/67uHBHks2Czu//RugOcDrVpAg6yuOEfg+GJcUjhtSSaocodIBgZf3T
 r9jeHcq2NeOHiUZpzkPihz6p1EGKAV5dvdCHFppRhBhb/mhYytnpBnS5WRZZMc2/i+zF+Qv0v5qEl
 RUFCBIBgjmzn6cZbLkLRqESU50dtZ4jcyUSrqisSDloKQykNEZ3JGyvRfNjj4iaoNLKFY/BPbgqds
 EtY+ots0QuvTkJgWeb6Rs1sQFPQl/xo4lOUgts/Zlp0FpHh5mD7ithr17b44o/z3VtjL7iaimeN5K
 2GDJHqMJzsSe/P5/SdPFUg==;
Date: Sat, 25 May 2024 13:49:01 +0300
Message-Id: <86ed9qyxnm.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <878qzypbav.fsf@HIDDEN> (message from Philip Kaludercic on
 Sat, 25 May 2024 08:04:24 +0000)
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 69528 <at> debbugs.gnu.org, iarchivedmywholelife@HIDDEN
> From: Philip Kaludercic <philipk@HIDDEN>
> Date: Sat, 25 May 2024 08:04:24 +0000
> 
> Joseph Turner <joseph@HIDDEN> writes:
> 
> > What about making `lm-version' handle the "package-version" header then
> > using `lm-version' in loaddefs-generate--parse-file?  See patches.
> 
> My main concern was if we want to have Package-Version always override
> Version, but if my patch modified loaddefs-gen, then I don't think there
> is much of a difference if we change lisp-mnt instead (in terms of the
> generality of the change).
> 
> So I am fine with the change, and think we can merge it.  Eli: Is master
> still fine for these kinds of changes?

I think so, yes.  But maybe I don't fully understand the effect of
this change?  Can you describe it?

I also added the other maintainers, in case they have opinions on
this.

Thanks.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Joseph Turner <joseph@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 26 May 2024 00:47:01 +0000
Resent-Message-ID: <handler.69528.B69528.171668437513688 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Philip Kaludercic <philipk@HIDDEN>
Cc: eliz@HIDDEN, 69528 <at> debbugs.gnu.org, iarchivedmywholelife@HIDDEN
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171668437513688
          (code B ref 69528); Sun, 26 May 2024 00:47:01 +0000
Received: (at 69528) by debbugs.gnu.org; 26 May 2024 00:46:15 +0000
Received: from localhost ([127.0.0.1]:34253 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sB21e-0003Y4-LW
	for submit <at> debbugs.gnu.org; Sat, 25 May 2024 20:46:15 -0400
Received: from out-175.mta1.migadu.com ([95.215.58.175]:39818)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joseph@HIDDEN>) id 1sB21b-0003MV-QL
 for 69528 <at> debbugs.gnu.org; Sat, 25 May 2024 20:46:12 -0400
X-Envelope-To: philipk@HIDDEN
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; 
 s=key1; t=1716684327;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=bVJg8EoN0jfdWR8ATaCw0eQCQ/68vG1EwwZ40rs3WcE=;
 b=IFKFrOmqOYIOP7M/d84DVkncxNNVYfoIfuqU7XPBu8oxB0muQ7wt9GaFfn0HxcAbYQCTMx
 nu25wUnUDRMV7mhQtUwjAMdhjWKVWnX9yshXzE2qK5axRYAlW1snrp6YWsL25fo+YAAC8i
 JDbnMXuhPTTDhRrETVTc4T2cnCatcQY=
X-Envelope-To: 69528 <at> debbugs.gnu.org
X-Envelope-To: iarchivedmywholelife@HIDDEN
X-Envelope-To: eliz@HIDDEN
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
From: Joseph Turner <joseph@HIDDEN>
In-Reply-To: <87pltanuqf.fsf@HIDDEN> (Philip Kaludercic's message of "Sat, 
 25 May 2024 08:47:36 +0000")
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN> <87o78ul3fb.fsf@HIDDEN>
 <87pltanuqf.fsf@HIDDEN>
Date: Sat, 25 May 2024 17:45:21 -0700
Message-ID: <877cfhl7tq.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Philip Kaludercic <philipk@HIDDEN> writes:

> Joseph Turner <joseph@HIDDEN> writes:
>
>> Philip Kaludercic <philipk@HIDDEN> writes:
>>
>>> Joseph Turner <joseph@HIDDEN> writes:
>>>
>>>> Philip Kaludercic <philipk@HIDDEN> writes:
>>>>> So in general, this patch might be appropriate?
>>>>>
>>>>> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loadde=
fs-gen.el
>>>>> index 581053f6304..42f386933dc 100644
>>>>> --- a/lisp/emacs-lisp/loaddefs-gen.el
>>>>> +++ b/lisp/emacs-lisp/loaddefs-gen.el
>>>>> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file
>>>>>            ;; loaddefs for packages so that `syntax-ppss' later gives
>>>>>            ;; correct results.
>>>>>            (emacs-lisp-mode)
>>>>> -        (let ((version (lm-header "version"))
>>>>> +        (let ((version (or (lm-header "package-version")
>>>>> +                           (lm-header "version")))
>>>>>                package)
>>>>>            (when (and version
>>>>>                       (setq version (ignore-errors (version-to-list v=
ersion)))
>>>>>
>>>>>
>>>>
>>>> What about making `lm-version' handle the "package-version" header then
>>>> using `lm-version' in loaddefs-generate--parse-file?  See patches.
>>>
>>> My main concern was if we want to have Package-Version always override
>>> Version, but if my patch modified loaddefs-gen, then I don't think there
>>> is much of a difference if we change lisp-mnt instead (in terms of the
>>> generality of the change).
>>
>> If it would be more appropriate, I can resubmit another patch with
>> "Version" used preferentially over "Package-Version".
>
> No, I believe that would be wrong, at least going by these quotes from
> the manual:
>
> (elisp) Simple Packages:
>
>      The version number comes from the =E2=80=98Package-Version=E2=80=99 =
header, if it
>   exists, or from the =E2=80=98Version=E2=80=99 header otherwise.  One or=
 the other _must_
>   be present.  Here, the version number is 1.3.
>
> (elisp) Library Headers:
>
>   =E2=80=98Package-Version=E2=80=99
>        If =E2=80=98Version=E2=80=99 is not suitable for use by the packag=
e manager, then a
>        package can define =E2=80=98Package-Version=E2=80=99; it will be u=
sed instead.
>        This is handy if =E2=80=98Version=E2=80=99 is an RCS id or somethi=
ng else that
>        cannot be parsed by =E2=80=98version-to-list=E2=80=99.
>
> So the patch is fine as it is.

Thanks for double-checking.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 02 Jun 2024 10:38:01 +0000
Resent-Message-ID: <handler.69528.B69528.17173246679628 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>, Philip Kaludercic <philipk@HIDDEN>,  Stefan Monnier <monnier@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>
Cc: iarchivedmywholelife@HIDDEN, 69528 <at> debbugs.gnu.org, joseph@HIDDEN
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.17173246679628
          (code B ref 69528); Sun, 02 Jun 2024 10:38:01 +0000
Received: (at 69528) by debbugs.gnu.org; 2 Jun 2024 10:37:47 +0000
Received: from localhost ([127.0.0.1]:57920 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sDiax-0002VE-4p
	for submit <at> debbugs.gnu.org; Sun, 02 Jun 2024 06:37:47 -0400
Received: from mail-lf1-f42.google.com ([209.85.167.42]:61556)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1sDiav-0002V0-7B
 for 69528 <at> debbugs.gnu.org; Sun, 02 Jun 2024 06:37:45 -0400
Received: by mail-lf1-f42.google.com with SMTP id
 2adb3069b0e04-52b82d57963so3239855e87.2
 for <69528 <at> debbugs.gnu.org>; Sun, 02 Jun 2024 03:37:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1717324587; x=1717929387; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=/vdldenti0Y/mcocqpnnfSX2U24NWULQ/OSBYuWGsZ8=;
 b=lUZG8TGRXj9iSh4dIT/mH6yXHcVkpAE3035FYx/CYAUiUgDMvGcRTUQy2U641FZRax
 neKQUGfa0dP15FoosJyZU5/rfuyengzyN+4syBqoZyWbiLfsikKeAqt0D4wJHWqCG0t2
 23vhmDRNvNlCQgAQoWM9qIzlYesNUDxSVfshKGX0LXgKeILrBdXjqa+Mp5dvJ3ZaKHnb
 83TLdcgkZT4ynJj9jC9/dYJsyhzTaavwx/5nLO/RwE20M5q1ewPQrkqPzFV+UW2vhj4w
 3C/hmisd1Z3A/nweI/urUY0a2jHYjJIE5ihiQFbZwzyyWbIotX8Q+iEglCbMcGdAJZqB
 rbyQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1717324587; x=1717929387;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=/vdldenti0Y/mcocqpnnfSX2U24NWULQ/OSBYuWGsZ8=;
 b=ixHXOUa+5bbuO0ppMo/Z42JZnop3xQfJxTSkcK8S5G3pxTvG/LzHymsp0BPbpxZgTO
 2c3s3h4St3B2OfTRz5V3OxcdjgagcKXSW+VKflArR9GqzA8864o3no30OQ78eHZh2K7P
 HYXQmsiWF1vDy2wlnGAbnS4dOGTUhwy80NkqXsICDhHVVmEWYqTPQcoJkB1R2KknTPPY
 Igo2HOcEjs64EhMbMEaY2m9EjjL7T71WkL75a6cjzY6m10Ib4w+vnQmnb73H0ma6YsnS
 Vqnf6dQ5m3CqAeFlFucaJ9pZLirg+U5gOMYJwFu3sCmaUuUADGhxgj0gXgABLI+byfKD
 dBPg==
X-Forwarded-Encrypted: i=1;
 AJvYcCU49IP4SeKtUbeGoAvl/zT2aiGMj4G3UU0/pfjqzwSly53qFSeTqOjolQKiE5jCgRPVV9+6qmz9Qmcg7/mys9TXUxptAqE=
X-Gm-Message-State: AOJu0YyA3itNGzA4WtCIqa2Ua4kflTUvu7T/Az/LgvwnL6Co5dD64lmJ
 P2SqAx76c1ZC3JF4fg5jVMEKsvPOULMUJ8NJmpl97qmD/bk4YkayfQ/NiCvWcqDigM9kNpVP0L1
 9mkOEsdTlV8Q/JB/7nLO3A6vbEVQ=
X-Google-Smtp-Source: AGHT+IHzb6HnoMVI3r1GqPxQLXEhGuKId4eii5KClJVTeCaWMH8O8+/vBPtTjvTEFe5E/Xt5C82Qm206924KKl6tGjc=
X-Received: by 2002:a05:6512:250:b0:523:90df:a9c6 with SMTP id
 2adb3069b0e04-52b896da5f9mr4048302e87.50.1717324586739; Sun, 02 Jun 2024
 03:36:26 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 2 Jun 2024 10:36:26 +0000
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <86ed9qyxnm.fsf@HIDDEN>
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN> <86ed9qyxnm.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sun, 2 Jun 2024 10:36:26 +0000
Message-ID: <CADwFkmn4S5ocBUYc5mKee1c38BBSVKLaWGbDBPYGWPpP4Rhwqw@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

>> > What about making `lm-version' handle the "package-version" header the=
n
>> > using `lm-version' in loaddefs-generate--parse-file?  See patches.
>>
>> My main concern was if we want to have Package-Version always override
>> Version, but if my patch modified loaddefs-gen, then I don't think there
>> is much of a difference if we change lisp-mnt instead (in terms of the
>> generality of the change).
>>
>> So I am fine with the change, and think we can merge it.  Eli: Is master
>> still fine for these kinds of changes?
>
> I think so, yes.  But maybe I don't fully understand the effect of
> this change?  Can you describe it?
>
> I also added the other maintainers, in case they have opinions on
> this.

I think the first patch is right, i.e. to use

    (lm-version)

instead of

    (lm-header "version")

So let's install that one, I think.

The effect of the second patch is to change `lm-version` to look for a
"Package-Version" header if there is no "Version" header.

This has two problems:

1. We didn't do that until now, and it's not clear to me what is the
   issue that is prompting this change.  The transient.el issue seems to
   have been fixed already.

2. The way I read the manual, it seems like "Package-Version" should be
   preferred over "Version", if it exists:

        =E2=80=98Package-Version=E2=80=99
             If =E2=80=98Version=E2=80=99 is not suitable for use by the pa=
ckage manager, then a
             package can define =E2=80=98Package-Version=E2=80=99; it will =
be used instead.
             This is handy if =E2=80=98Version=E2=80=99 is an RCS id or som=
ething else that
             cannot be parsed by =E2=80=98version-to-list=E2=80=99.

   I'm also not sure we need to support packages with unusual versions
   like RCS id's these days.  Is that use case still relevant?  Perhaps
   we should simply deprecate the "Package-Version" header?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Philip Kaludercic <philipk@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 02 Jun 2024 11:08:02 +0000
Resent-Message-ID: <handler.69528.B69528.171732644512666 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: iarchivedmywholelife@HIDDEN, joseph@HIDDEN, 69528 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>, Stefan Monnier <monnier@HIDDEN>
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171732644512666
          (code B ref 69528); Sun, 02 Jun 2024 11:08:02 +0000
Received: (at 69528) by debbugs.gnu.org; 2 Jun 2024 11:07:25 +0000
Received: from localhost ([127.0.0.1]:57952 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sDj3c-0003ID-U4
	for submit <at> debbugs.gnu.org; Sun, 02 Jun 2024 07:07:25 -0400
Received: from mout02.posteo.de ([185.67.36.66]:37561)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1sDj3b-0003Hy-Hw
 for 69528 <at> debbugs.gnu.org; Sun, 02 Jun 2024 07:07:24 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 2D1BA240101
 for <69528 <at> debbugs.gnu.org>; Sun,  2 Jun 2024 13:07:04 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1717326425; bh=cZf8TeO/VhVGQ2w5+3vL0P0qWtcWzdXfoSABetCbeSI=;
 h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version:
 Content-Type:Content-Transfer-Encoding:From;
 b=GO2Ex3ZXBFU+a7jwIpl2WjSil28GGeI2WJm+/yLyszNNjI1+QptzgXq50fgtWmkCZ
 F7pvB0/fbBLvkYs08FYiWAyaVdeRutez9qR5/GdoFlE1mNt3zDMhea81Xsu4JVOMY3
 uXTY1M0iMxyFv/YENDYZLEV61z5q6FqJKqK9VrgW2z8smlHogAzzCSMWekiYY9pZpv
 VXgQQie/Y/auct3j9xbuKLd52+a3pksn7v44Bf4BpChYVnrIonxgPpyMJ6bVShfeZj
 B2twj53BA8Lrx9mV7F87G/onFD7I0mmsKDpWzL9pKS0U3q3bZNE0JAgcptH5yZv20Q
 3Xw6fUnIOGCIg==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4VsYw72Xf3z9rxL;
 Sun,  2 Jun 2024 13:07:03 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
In-Reply-To: <CADwFkmn4S5ocBUYc5mKee1c38BBSVKLaWGbDBPYGWPpP4Rhwqw@HIDDEN>
 (Stefan Kangas's message of "Sun, 2 Jun 2024 10:36:26 +0000")
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN> <86ed9qyxnm.fsf@HIDDEN>
 <CADwFkmn4S5ocBUYc5mKee1c38BBSVKLaWGbDBPYGWPpP4Rhwqw@HIDDEN>
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
 url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
 preference=signencrypt
Date: Sun, 02 Jun 2024 11:07:02 +0000
Message-ID: <871q5ffvs9.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Stefan Kangas <stefankangas@HIDDEN> writes:

> Eli Zaretskii <eliz@HIDDEN> writes:
>
>>> > What about making `lm-version' handle the "package-version" header th=
en
>>> > using `lm-version' in loaddefs-generate--parse-file?  See patches.
>>>
>>> My main concern was if we want to have Package-Version always override
>>> Version, but if my patch modified loaddefs-gen, then I don't think there
>>> is much of a difference if we change lisp-mnt instead (in terms of the
>>> generality of the change).
>>>
>>> So I am fine with the change, and think we can merge it.  Eli: Is master
>>> still fine for these kinds of changes?
>>
>> I think so, yes.  But maybe I don't fully understand the effect of
>> this change?  Can you describe it?

Sorry for the late response, but Stefan summaries the situation well
below.

>> I also added the other maintainers, in case they have opinions on
>> this.
>
> I think the first patch is right, i.e. to use
>
>     (lm-version)
>
> instead of
>
>     (lm-header "version")
>
> So let's install that one, I think.

I agree.

> The effect of the second patch is to change `lm-version` to look for a
> "Package-Version" header if there is no "Version" header.
>
> This has two problems:
>
> 1. We didn't do that until now, and it's not clear to me what is the
>    issue that is prompting this change.  The transient.el issue seems to
>    have been fixed already.
>
> 2. The way I read the manual, it seems like "Package-Version" should be
>    preferred over "Version", if it exists:
>
>         =E2=80=98Package-Version=E2=80=99
>              If =E2=80=98Version=E2=80=99 is not suitable for use by the =
package manager, then a
>              package can define =E2=80=98Package-Version=E2=80=99; it wil=
l be used instead.
>              This is handy if =E2=80=98Version=E2=80=99 is an RCS id or s=
omething else that
>              cannot be parsed by =E2=80=98version-to-list=E2=80=99.
>
>    I'm also not sure we need to support packages with unusual versions
>    like RCS id's these days.  Is that use case still relevant?  Perhaps
>    we should simply deprecate the "Package-Version" header?

FWIW I use this for some of my own scripts that I version using RCS, so
I'd appreciate it if that functionality would stay.

--=20
	Philip Kaludercic on peregrine

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 02 Jun 2024 12:11:01 +0000
Resent-Message-ID: <handler.69528.B69528.171733022229281 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Philip Kaludercic <philipk@HIDDEN>
Cc: iarchivedmywholelife@HIDDEN, joseph@HIDDEN, 69528 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>, Stefan Monnier <monnier@HIDDEN>
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171733022229281
          (code B ref 69528); Sun, 02 Jun 2024 12:11:01 +0000
Received: (at 69528) by debbugs.gnu.org; 2 Jun 2024 12:10:22 +0000
Received: from localhost ([127.0.0.1]:57995 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sDk2X-0007cD-VJ
	for submit <at> debbugs.gnu.org; Sun, 02 Jun 2024 08:10:22 -0400
Received: from mail-ed1-f54.google.com ([209.85.208.54]:50365)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1sDk2T-0007bs-PT
 for 69528 <at> debbugs.gnu.org; Sun, 02 Jun 2024 08:10:21 -0400
Received: by mail-ed1-f54.google.com with SMTP id
 4fb4d7f45d1cf-57a1fe63a96so2937038a12.0
 for <69528 <at> debbugs.gnu.org>; Sun, 02 Jun 2024 05:10:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1717330139; x=1717934939; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=W/TXR+niB8IU3dkfuzUDZqQTPiw5jodR68Fqloq0MxA=;
 b=jDNcZmyTx7hAE635/NSRMwW0X1szHYP5LaREnDUG3U0inm+3K9SxPrCtBpXrhPWTPL
 21bTZ/c/PLILPTJogtpr5u6HjFUuci4GQ9ra+3BqcwvqAb3YoG5aEn8waKjrJwDAbgIg
 n2y1bmZ7hOI0Xg1U/37qZKLGi6isyBqKO20ituzLYYjPSY8Iq2ZBpdSgUCDZvBFC/ko2
 eIcxmJzfReI8gqLdG7QJEaqTiCeJaJvgLN/HvMKgO2ahmc+ghyae972pfRNBD1ZVU3Xv
 1n3QUNjfgu/xLpmIwwnrnMzM1QJJdck7On39sfETMJa3iAQphTrrDB6VfB3prpCJQUgA
 nq0g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1717330139; x=1717934939;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=W/TXR+niB8IU3dkfuzUDZqQTPiw5jodR68Fqloq0MxA=;
 b=D1pwHz+Yy/HunP/u2lAfZ2ae9luSoNLv0mL+1hwqx8+uQNFlxs0cWQoHNXhUySKkQZ
 5qdzz9o1ACY+kQMQSSh8FpxQv+4Rsbvc6yl3GhU13K8ymK39YG+7qVaGpWrI3vRZ9czn
 iaRjVSEXsBN9xM4Ulxazdh9zgogGZ3RiGzbgVLODwjVegHx36jBaoalsZlejEdZ8/KeS
 HpPLb+MHaAtv8NIcjwnVYYD7posrjoz7En3KeqpktmFh/IUF9aayOlN8jEU4ZvWbd5bf
 M0QyAj7U1Of3euX0UJQAcdJODo9sjdkx9KQBpi7hXzXb/Fm6/tgLyap13vM5wdSB66LZ
 IgTg==
X-Forwarded-Encrypted: i=1;
 AJvYcCVaoJENeZx+IQ6UjLm1idIR0XjbvESWSDElmub0o5ifbfxwaKV9c0dxl/kcQ2O8e8RQYYr+yeGEVlmiYvq0ZAeKS68IE98=
X-Gm-Message-State: AOJu0YxF3ScLl0PBJcQgead4YP5G4wmzZve0XCOUhnSN7zjv1lCp5dNv
 VGeEdCQtgNhFXl261l9uvxg+hPwlXdnTeuJCSvkj0SBBou8eOKPzm9u3UyNXTnbHMcnFOaYc8TA
 WRZNsgtPvqiXx0cYn+8pzS64HEOg=
X-Google-Smtp-Source: AGHT+IF9OoouYEtkKOWX0jnG+lOjwh8nbegBKvyZlJmpBhGvktso8ulGclBORRuOFb92wxnFby0gDoVZyQckFGsx35Q=
X-Received: by 2002:a50:9509:0:b0:57a:3114:7d07 with SMTP id
 4fb4d7f45d1cf-57a3638221emr4319415a12.9.1717330139271; Sun, 02 Jun 2024
 05:08:59 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sun, 2 Jun 2024 05:08:58 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <871q5ffvs9.fsf@HIDDEN>
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN> <86ed9qyxnm.fsf@HIDDEN>
 <CADwFkmn4S5ocBUYc5mKee1c38BBSVKLaWGbDBPYGWPpP4Rhwqw@HIDDEN>
 <871q5ffvs9.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sun, 2 Jun 2024 05:08:58 -0700
Message-ID: <CADwFkmkw4s_LUK83o1HJPDNESRtocUVYcZ8SXtCJKx_AMZuN_Q@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Philip Kaludercic <philipk@HIDDEN> writes:

>> 2. The way I read the manual, it seems like "Package-Version" should be
>>    preferred over "Version", if it exists:
>>
>>         =E2=80=98Package-Version=E2=80=99
>>              If =E2=80=98Version=E2=80=99 is not suitable for use by the=
 package manager, then a
>>              package can define =E2=80=98Package-Version=E2=80=99; it wi=
ll be used instead.
>>              This is handy if =E2=80=98Version=E2=80=99 is an RCS id or =
something else that
>>              cannot be parsed by =E2=80=98version-to-list=E2=80=99.
>
> FWIW I use this for some of my own scripts that I version using RCS, so
> I'd appreciate it if that functionality would stay.

OK, so let's keep it.  But shouldn't the below be the correct order
according to the above quoted documentation?

diff --git a/lisp/emacs-lisp/lisp-mnt.el b/lisp/emacs-lisp/lisp-mnt.el
index f111a77663c..5db0b50adc3 100644
--- a/lisp/emacs-lisp/lisp-mnt.el
+++ b/lisp/emacs-lisp/lisp-mnt.el
@@ -415,7 +415,8 @@ lm-version
   "Return the version listed in file FILE, or current buffer if FILE is ni=
l.
 This can be found in an RCS or SCCS header."
   (lm-with-file file
-    (or (lm-header "version")
+    (or (lm-header "package-version")
+        (lm-header "version")
         (let ((header-max (lm-code-start)))
 	  (goto-char (point-min))
 	  (cond

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Philip Kaludercic <philipk@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 02 Jun 2024 13:13:02 +0000
Resent-Message-ID: <handler.69528.B69528.171733392213220 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: iarchivedmywholelife@HIDDEN, joseph@HIDDEN, 69528 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>, Stefan Monnier <monnier@HIDDEN>
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171733392213220
          (code B ref 69528); Sun, 02 Jun 2024 13:13:02 +0000
Received: (at 69528) by debbugs.gnu.org; 2 Jun 2024 13:12:02 +0000
Received: from localhost ([127.0.0.1]:58038 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sDl0E-0003R3-0X
	for submit <at> debbugs.gnu.org; Sun, 02 Jun 2024 09:12:02 -0400
Received: from mout01.posteo.de ([185.67.36.65]:35329)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1sDl09-0003Ql-SP
 for 69528 <at> debbugs.gnu.org; Sun, 02 Jun 2024 09:12:00 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id CDD11240027
 for <69528 <at> debbugs.gnu.org>; Sun,  2 Jun 2024 15:11:39 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1717333899; bh=olbPms2RRXEC51RXSWenG5lD/l4SVI9lYl12naFuyA4=;
 h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version:
 Content-Type:Content-Transfer-Encoding:From;
 b=DVOfh0FqcLWG5xl78V/1rNiSIah8qAdyFtLB9XhaAzBrR8x9YWwyNJYETclnsGQmq
 giUVtJ2DWsWGbJd6f8kfmfFXwYP/U/kPkfDFE5UHxpN70RAzk2G/C4M2YZprNHMj2f
 Vj42ubb6NXbgWc7ir7ZA4esaTEzBcDNEm4Xt+l3jO8why0hCqG7GdnwWsfgG3vYDSf
 UxGIBl1kV5xL8FPsjtPNoIegj7Vt84TQXEHAGTAHJ5AjR9HCVPqzB2zR4xuPJnSBZ4
 EG6VA9EVGc21s7wEGiuMXmD9lX6/cnM/ElFZKNBnxdfW/KhG7Eo+QDhUUvrmnwfZL8
 gQchz2gXxGfpg==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4Vscgv02Vlz9rxD;
 Sun,  2 Jun 2024 15:11:38 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
In-Reply-To: <CADwFkmkw4s_LUK83o1HJPDNESRtocUVYcZ8SXtCJKx_AMZuN_Q@HIDDEN>
 (Stefan Kangas's message of "Sun, 2 Jun 2024 05:08:58 -0700")
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN> <86ed9qyxnm.fsf@HIDDEN>
 <CADwFkmn4S5ocBUYc5mKee1c38BBSVKLaWGbDBPYGWPpP4Rhwqw@HIDDEN>
 <871q5ffvs9.fsf@HIDDEN>
 <CADwFkmkw4s_LUK83o1HJPDNESRtocUVYcZ8SXtCJKx_AMZuN_Q@HIDDEN>
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
 url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
 preference=signencrypt
Date: Sun, 02 Jun 2024 13:11:38 +0000
Message-ID: <87wmn7ebg5.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Stefan Kangas <stefankangas@HIDDEN> writes:

> Philip Kaludercic <philipk@HIDDEN> writes:
>
>>> 2. The way I read the manual, it seems like "Package-Version" should be
>>>    preferred over "Version", if it exists:
>>>
>>>         =E2=80=98Package-Version=E2=80=99
>>>              If =E2=80=98Version=E2=80=99 is not suitable for use by th=
e package manager, then a
>>>              package can define =E2=80=98Package-Version=E2=80=99; it w=
ill be used instead.
>>>              This is handy if =E2=80=98Version=E2=80=99 is an RCS id or=
 something else that
>>>              cannot be parsed by =E2=80=98version-to-list=E2=80=99.
>>
>> FWIW I use this for some of my own scripts that I version using RCS, so
>> I'd appreciate it if that functionality would stay.
>
> OK, so let's keep it.  But shouldn't the below be the correct order
> according to the above quoted documentation?
>
> diff --git a/lisp/emacs-lisp/lisp-mnt.el b/lisp/emacs-lisp/lisp-mnt.el
> index f111a77663c..5db0b50adc3 100644
> --- a/lisp/emacs-lisp/lisp-mnt.el
> +++ b/lisp/emacs-lisp/lisp-mnt.el
> @@ -415,7 +415,8 @@ lm-version
>    "Return the version listed in file FILE, or current buffer if FILE is =
nil.
>  This can be found in an RCS or SCCS header."
>    (lm-with-file file
> -    (or (lm-header "version")
> +    (or (lm-header "package-version")
> +        (lm-header "version")
>          (let ((header-max (lm-code-start)))
>  	  (goto-char (point-min))
>  	  (cond

Of course, that was also the change proposed in my first patch but I
didn't notice the change in Joseph's suggestion.

--=20
	Philip Kaludercic on peregrine

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Joseph Turner <joseph@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 02 Jun 2024 18:28:01 +0000
Resent-Message-ID: <handler.69528.B69528.171735282926904 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Philip Kaludercic <philipk@HIDDEN>
Cc: iarchivedmywholelife@HIDDEN, 69528 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN>
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171735282926904
          (code B ref 69528); Sun, 02 Jun 2024 18:28:01 +0000
Received: (at 69528) by debbugs.gnu.org; 2 Jun 2024 18:27:09 +0000
Received: from localhost ([127.0.0.1]:60258 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sDpvA-0006zs-Ra
	for submit <at> debbugs.gnu.org; Sun, 02 Jun 2024 14:27:09 -0400
Received: from out-179.mta0.migadu.com ([91.218.175.179]:20502)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joseph@HIDDEN>) id 1sDpv7-0006zM-QA
 for 69528 <at> debbugs.gnu.org; Sun, 02 Jun 2024 14:27:08 -0400
X-Envelope-To: philipk@HIDDEN
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; 
 s=key1; t=1717352807;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=eGzlIqI2cgtmyHS0MhtaONyFHTlpL+WKiwyAcfpPnzI=;
 b=TRnybyTm0pWQH8No/CT6i30HqNH2/3/f38HFUAH+TjcIdyaUSlTVi8muRgjMXgyIlutdys
 bU5VZ0iJFLQaKGRHkgO9cCuH/Fpg3R9GppqKduvubl0GcNr/HzDcsUniQ71O7EO5LiNRzZ
 v7PGqFeNKvGVhAEV6mDJ4NApzPYCkTI=
X-Envelope-To: stefankangas@HIDDEN
X-Envelope-To: iarchivedmywholelife@HIDDEN
X-Envelope-To: 69528 <at> debbugs.gnu.org
X-Envelope-To: eliz@HIDDEN
X-Envelope-To: acorallo@HIDDEN
X-Envelope-To: monnier@HIDDEN
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
From: Joseph Turner <joseph@HIDDEN>
In-Reply-To: <87wmn7ebg5.fsf@HIDDEN> (Philip Kaludercic's message of "Sun, 
 02 Jun 2024 13:11:38 +0000")
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN> <86ed9qyxnm.fsf@HIDDEN>
 <CADwFkmn4S5ocBUYc5mKee1c38BBSVKLaWGbDBPYGWPpP4Rhwqw@HIDDEN>
 <871q5ffvs9.fsf@HIDDEN>
 <CADwFkmkw4s_LUK83o1HJPDNESRtocUVYcZ8SXtCJKx_AMZuN_Q@HIDDEN>
 <87wmn7ebg5.fsf@HIDDEN>
Date: Sun, 02 Jun 2024 11:26:42 -0700
Message-ID: <87mso3mc9p.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Philip Kaludercic <philipk@HIDDEN> writes:

> Stefan Kangas <stefankangas@HIDDEN> writes:
>
>> Philip Kaludercic <philipk@HIDDEN> writes:
>>
>>>> 2. The way I read the manual, it seems like "Package-Version" should be
>>>>    preferred over "Version", if it exists:
>>>>
>>>>         =E2=80=98Package-Version=E2=80=99
>>>>              If =E2=80=98Version=E2=80=99 is not suitable for use by t=
he package manager, then a
>>>>              package can define =E2=80=98Package-Version=E2=80=99; it =
will be used instead.
>>>>              This is handy if =E2=80=98Version=E2=80=99 is an RCS id o=
r something else that
>>>>              cannot be parsed by =E2=80=98version-to-list=E2=80=99.
>>>
>>> FWIW I use this for some of my own scripts that I version using RCS, so
>>> I'd appreciate it if that functionality would stay.
>>
>> OK, so let's keep it.  But shouldn't the below be the correct order
>> according to the above quoted documentation?
>>
>> diff --git a/lisp/emacs-lisp/lisp-mnt.el b/lisp/emacs-lisp/lisp-mnt.el
>> index f111a77663c..5db0b50adc3 100644
>> --- a/lisp/emacs-lisp/lisp-mnt.el
>> +++ b/lisp/emacs-lisp/lisp-mnt.el
>> @@ -415,7 +415,8 @@ lm-version
>>    "Return the version listed in file FILE, or current buffer if FILE is=
 nil.
>>  This can be found in an RCS or SCCS header."
>>    (lm-with-file file
>> -    (or (lm-header "version")
>> +    (or (lm-header "package-version")
>> +        (lm-header "version")
>>          (let ((header-max (lm-code-start)))
>>  	  (goto-char (point-min))
>>  	  (cond
>
> Of course, that was also the change proposed in my first patch but I
> didn't notice the change in Joseph's suggestion.

Thanks for the correction.  Are the attached patches appropriate?


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=0001-Check-Package-Version-header-in-lm-version-also.patch

From a666581f2a58568bb7f83a369e1040920a6b2c14 Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@HIDDEN>
Date: Mon, 4 Mar 2024 22:14:26 -0800
Subject: [PATCH 1/2] Check Package-Version: header in lm-version also

* lisp/emacs-lisp/lisp-mnt.el (lm-version)
---
 lisp/emacs-lisp/lisp-mnt.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/lisp-mnt.el b/lisp/emacs-lisp/lisp-mnt.el
index f111a77663c..5db0b50adc3 100644
--- a/lisp/emacs-lisp/lisp-mnt.el
+++ b/lisp/emacs-lisp/lisp-mnt.el
@@ -415,7 +415,8 @@ lm-version
   "Return the version listed in file FILE, or current buffer if FILE is nil.
 This can be found in an RCS or SCCS header."
   (lm-with-file file
-    (or (lm-header "version")
+    (or (lm-header "package-version")
+        (lm-header "version")
         (let ((header-max (lm-code-start)))
 	  (goto-char (point-min))
 	  (cond
-- 
2.41.0


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=0002-Use-lm-version-instead-of-lm-header-version.patch

From 6c4262d7236c64bbc938f7b4e76988d95049b7c1 Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@HIDDEN>
Date: Mon, 4 Mar 2024 22:15:50 -0800
Subject: [PATCH 2/2] Use lm-version instead of lm-header "version"

bug#69528

* lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate--parse-file)
---
 lisp/emacs-lisp/loaddefs-gen.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
index 50e90cdf94c..f0355b25f57 100644
--- a/lisp/emacs-lisp/loaddefs-gen.el
+++ b/lisp/emacs-lisp/loaddefs-gen.el
@@ -433,7 +433,7 @@ loaddefs-generate--parse-file
           ;; loaddefs for packages so that `syntax-ppss' later gives
           ;; correct results.
           (emacs-lisp-mode)
-        (let ((version (lm-header "version"))
+        (let ((version (lm-version))
               package)
           (when (and version
                      (setq version (ignore-errors (version-to-list version)))
-- 
2.41.0


--=-=-=--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Philip Kaludercic <philipk@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 02 Jun 2024 18:41:01 +0000
Resent-Message-ID: <handler.69528.B69528.171735363928178 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Joseph Turner <joseph@HIDDEN>
Cc: iarchivedmywholelife@HIDDEN, 69528 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN>
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171735363928178
          (code B ref 69528); Sun, 02 Jun 2024 18:41:01 +0000
Received: (at 69528) by debbugs.gnu.org; 2 Jun 2024 18:40:39 +0000
Received: from localhost ([127.0.0.1]:60270 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sDq8E-0007KQ-Ls
	for submit <at> debbugs.gnu.org; Sun, 02 Jun 2024 14:40:39 -0400
Received: from mout01.posteo.de ([185.67.36.65]:51745)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1sDq8A-0007K8-Bx
 for 69528 <at> debbugs.gnu.org; Sun, 02 Jun 2024 14:40:37 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id E997A24002A
 for <69528 <at> debbugs.gnu.org>; Sun,  2 Jun 2024 20:40:15 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1717353615; bh=XP+Z2QHBEfvJU4wDvhV+bsZlimCx+26hjV2SgmPm+vs=;
 h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version:
 Content-Type:Content-Transfer-Encoding:From;
 b=no3o2iwEPKzdo0FDMlGaYZ5zaPZfwwIq7hhE0ONAp6I6M96LT+6EXrdtRaC5V2V4y
 emt2moPZ22cvFs4xVTLGJL4hZHsF0xU/QWsvVTnuKOf4mj7rdMkco2McEuNlBJZrML
 8RASr5YYWg1OxbqdxTbZlII7a+784aoyKQIbeXp68LIQJchQ+avww5qTdY47j9cS8J
 jfUt/6qA5ZKSstbRNFDkerWLhSK6i69xpjiE2mbIUCaq0VdzgQv7vh+pUV81+HVofN
 Izw11h40Aclk8d88YqIVpkeel4cYNV487T9mTzTdnkVoQztbwIpl1CK/AEMRcV82ao
 sFsec6ndKD65w==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4Vslz204f8z6twS;
 Sun,  2 Jun 2024 20:40:13 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
In-Reply-To: <87mso3mc9p.fsf@HIDDEN> (Joseph Turner's message of
 "Sun, 02 Jun 2024 11:26:42 -0700")
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN> <86ed9qyxnm.fsf@HIDDEN>
 <CADwFkmn4S5ocBUYc5mKee1c38BBSVKLaWGbDBPYGWPpP4Rhwqw@HIDDEN>
 <871q5ffvs9.fsf@HIDDEN>
 <CADwFkmkw4s_LUK83o1HJPDNESRtocUVYcZ8SXtCJKx_AMZuN_Q@HIDDEN>
 <87wmn7ebg5.fsf@HIDDEN> <87mso3mc9p.fsf@HIDDEN>
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
 url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
 preference=signencrypt
Date: Sun, 02 Jun 2024 18:40:13 +0000
Message-ID: <87r0dfdw8i.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Joseph Turner <joseph@HIDDEN> writes:

> Philip Kaludercic <philipk@HIDDEN> writes:
>
>> Stefan Kangas <stefankangas@HIDDEN> writes:
>>
>>> Philip Kaludercic <philipk@HIDDEN> writes:
>>>
>>>>> 2. The way I read the manual, it seems like "Package-Version" should =
be
>>>>>    preferred over "Version", if it exists:
>>>>>
>>>>>         =E2=80=98Package-Version=E2=80=99
>>>>>              If =E2=80=98Version=E2=80=99 is not suitable for use by =
the package manager, then a
>>>>>              package can define =E2=80=98Package-Version=E2=80=99; it=
 will be used instead.
>>>>>              This is handy if =E2=80=98Version=E2=80=99 is an RCS id =
or something else that
>>>>>              cannot be parsed by =E2=80=98version-to-list=E2=80=99.
>>>>
>>>> FWIW I use this for some of my own scripts that I version using RCS, so
>>>> I'd appreciate it if that functionality would stay.
>>>
>>> OK, so let's keep it.  But shouldn't the below be the correct order
>>> according to the above quoted documentation?
>>>
>>> diff --git a/lisp/emacs-lisp/lisp-mnt.el b/lisp/emacs-lisp/lisp-mnt.el
>>> index f111a77663c..5db0b50adc3 100644
>>> --- a/lisp/emacs-lisp/lisp-mnt.el
>>> +++ b/lisp/emacs-lisp/lisp-mnt.el
>>> @@ -415,7 +415,8 @@ lm-version
>>>    "Return the version listed in file FILE, or current buffer if FILE i=
s nil.
>>>  This can be found in an RCS or SCCS header."
>>>    (lm-with-file file
>>> -    (or (lm-header "version")
>>> +    (or (lm-header "package-version")
>>> +        (lm-header "version")
>>>          (let ((header-max (lm-code-start)))
>>>  	  (goto-char (point-min))
>>>  	  (cond
>>
>> Of course, that was also the change proposed in my first patch but I
>> didn't notice the change in Joseph's suggestion.
>
> Thanks for the correction.  Are the attached patches appropriate?

Unless I am forgetting something again, it looks good.

--=20
	Philip Kaludercic on peregrine

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 03 Jun 2024 17:26:01 +0000
Resent-Message-ID: <handler.69528.B69528.171743556030902 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Joseph Turner <joseph@HIDDEN>, Philip Kaludercic <philipk@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>, iarchivedmywholelife@HIDDEN, Stefan Monnier <monnier@HIDDEN>, 69528 <at> debbugs.gnu.org
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171743556030902
          (code B ref 69528); Mon, 03 Jun 2024 17:26:01 +0000
Received: (at 69528) by debbugs.gnu.org; 3 Jun 2024 17:26:00 +0000
Received: from localhost ([127.0.0.1]:52259 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sEBRX-00082J-CR
	for submit <at> debbugs.gnu.org; Mon, 03 Jun 2024 13:25:59 -0400
Received: from mail-ed1-f54.google.com ([209.85.208.54]:59701)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1sEBRU-00081t-7g
 for 69528 <at> debbugs.gnu.org; Mon, 03 Jun 2024 13:25:57 -0400
Received: by mail-ed1-f54.google.com with SMTP id
 4fb4d7f45d1cf-579fa270e53so5097542a12.3
 for <69528 <at> debbugs.gnu.org>; Mon, 03 Jun 2024 10:25:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1717435477; x=1718040277; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=FKkQhwmjNkXDrAcQfENWEnXy9yjPkmuIMQqO7wgAdAQ=;
 b=XBTwgapNzL5IAFeIXg+Rq+Qw4duDue/sMFZuO5mGoLBgBYbQUfgyzbk62nZGWET1Nf
 7BqE2IHfPzfUHZjxIYgdC5gUHE9HkeTVGkjulI13j9ymI4kH3IIvu3oLri4b6+B50Sb6
 mutIFk+DFmOlx9ql5SqTVqMRctqSWD0rxkWStnrgAsZh5Eht9hEK+v14pH7Td6SNkhzi
 fxfGGr+yQ8RuPyWNrr/yO20sNiN80rBaUSjlMl2v0PGQ52dL6BbZ7qW0VY1hrcMfvCZ8
 Z4d85ljDOeWJ6qR82KX1+CUCwf+eg7HTbnAiKvrk0jFgnqLrpigGvfLnTG7FyWyMRsfM
 Jnow==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1717435477; x=1718040277;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=FKkQhwmjNkXDrAcQfENWEnXy9yjPkmuIMQqO7wgAdAQ=;
 b=rXCchRXUIr/bmocNH65Be0pZX0Bdh/cR8PtByLBAMIXF/FB2EY+W16mwUI7iN3Ro2b
 zOfv36ygPJ564yUirx8oeQf5Yayx69ANeqCf3G3By4bR56l/FlBrGoqmTX9QoBLypPO5
 Qqm4k5aatAQV0m3ajGq5KQc1zZgXPVoc8DGmlkddFKHpvzG3y2l+CmFt1OyPWTcNWtsJ
 so22FfIQxNxNglxAuIHHqnxGAbsrqgNlgmFLGQQm+PBnIVDYRhCO9CVDqT0QVU0m86or
 hJSRdwJtSF0y+TmC10x91L4h1B3pN7nlqQie/nSbGXBG+gX3qq6Pky7WbFcvJ3fNAw+l
 oOFg==
X-Forwarded-Encrypted: i=1;
 AJvYcCV5EZgUBfRJuRZtJg3VoM1IXYWJZrdUfHGxX8L1Z8ddLl+KC3CHjU8WI5WZ2cmb3TUSIXD1NZCLE80r0FWblF8bP7r8zGc=
X-Gm-Message-State: AOJu0YwW1f+C7/fDBI3T5Km/CcLlAxr+oPwSBFbb36b1wZGDcisK95rz
 PuadFYkK9MNBQ08TEEVkssxWlYl6UI07ymwfogS6iXkm+M0TfhWvLNRBdZygZvzvwqbqohTpVsm
 uTxIOGlIRbRzXWP17aHpqRUPlkCw=
X-Google-Smtp-Source: AGHT+IGUXw+5DYVtTl7vIOVFyEaLBcCUx98l/v8QmP6q9DYaljzsqUdhCXI0/sJDCJSXR+1+Qywdzw0Bmiek31znWMQ=
X-Received: by 2002:a50:d494:0:b0:578:5eab:3f31 with SMTP id
 4fb4d7f45d1cf-57a365cae19mr7719489a12.38.1717435477263; Mon, 03 Jun 2024
 10:24:37 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Mon, 3 Jun 2024 13:24:36 -0400
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87mso3mc9p.fsf@HIDDEN>
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN> <86ed9qyxnm.fsf@HIDDEN>
 <CADwFkmn4S5ocBUYc5mKee1c38BBSVKLaWGbDBPYGWPpP4Rhwqw@HIDDEN>
 <871q5ffvs9.fsf@HIDDEN>
 <CADwFkmkw4s_LUK83o1HJPDNESRtocUVYcZ8SXtCJKx_AMZuN_Q@HIDDEN>
 <87wmn7ebg5.fsf@HIDDEN> <87mso3mc9p.fsf@HIDDEN>
MIME-Version: 1.0
Date: Mon, 3 Jun 2024 13:24:36 -0400
Message-ID: <CADwFkm=p+QoWueCxymD0tiHQOq+g0SspiKQ8qbJX=K=ZyiP+1w@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Joseph Turner <joseph@HIDDEN> writes:

>> Of course, that was also the change proposed in my first patch but I
>> didn't notice the change in Joseph's suggestion.

Ah, right.  I somehow missed that part.

> Thanks for the correction.  Are the attached patches appropriate?

Looks good to me, except for a few comments below.

> From a666581f2a58568bb7f83a369e1040920a6b2c14 Mon Sep 17 00:00:00 2001
> From: Joseph Turner <joseph@HIDDEN>
> Date: Mon, 4 Mar 2024 22:14:26 -0800
> Subject: [PATCH 1/2] Check Package-Version: header in lm-version also

Bonus points if you add a test for this one.

> * lisp/emacs-lisp/lisp-mnt.el (lm-version)

See CONTRIBUTE for details, but this should read:

* lisp/emacs-lisp/lisp-mnt.el (lm-version): Prefer version in the
"Package-Version:" header.  (Bug#69528)

> ---
>  lisp/emacs-lisp/lisp-mnt.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/emacs-lisp/lisp-mnt.el b/lisp/emacs-lisp/lisp-mnt.el
> index f111a77663c..5db0b50adc3 100644
> --- a/lisp/emacs-lisp/lisp-mnt.el
> +++ b/lisp/emacs-lisp/lisp-mnt.el
> @@ -415,7 +415,8 @@ lm-version
>    "Return the version listed in file FILE, or current buffer if FILE is nil.
>  This can be found in an RCS or SCCS header."

It would be good to fix the docstring here to clarify that it can come
from the "Version" or "Package-Version" headers too.

>    (lm-with-file file
> -    (or (lm-header "version")
> +    (or (lm-header "package-version")
> +        (lm-header "version")
>          (let ((header-max (lm-code-start)))
>  	  (goto-char (point-min))
>  	  (cond
> --
> 2.41.0
>
> From 6c4262d7236c64bbc938f7b4e76988d95049b7c1 Mon Sep 17 00:00:00 2001
> From: Joseph Turner <joseph@HIDDEN>
> Date: Mon, 4 Mar 2024 22:15:50 -0800
> Subject: [PATCH 2/2] Use lm-version instead of lm-header "version"
>
> bug#69528
>
> * lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate--parse-file)

This should read something like this instead:

* lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate--parse-file):
Prefer 'lm-version'.  (Bug#69528)

> ---
>  lisp/emacs-lisp/loaddefs-gen.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
> index 50e90cdf94c..f0355b25f57 100644
> --- a/lisp/emacs-lisp/loaddefs-gen.el
> +++ b/lisp/emacs-lisp/loaddefs-gen.el
> @@ -433,7 +433,7 @@ loaddefs-generate--parse-file
>            ;; loaddefs for packages so that `syntax-ppss' later gives
>            ;; correct results.
>            (emacs-lisp-mode)
> -        (let ((version (lm-header "version"))
> +        (let ((version (lm-version))
>                package)
>            (when (and version
>                       (setq version (ignore-errors (version-to-list version)))
> --
> 2.41.0

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 03 Jun 2024 19:26:01 +0000
Resent-Message-ID: <handler.69528.B69528.171744272329560 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: Philip Kaludercic <philipk@HIDDEN>, iarchivedmywholelife@HIDDEN, Joseph Turner <joseph@HIDDEN>, 69528 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171744272329560
          (code B ref 69528); Mon, 03 Jun 2024 19:26:01 +0000
Received: (at 69528) by debbugs.gnu.org; 3 Jun 2024 19:25:23 +0000
Received: from localhost ([127.0.0.1]:55697 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sEDJ4-0007gh-Ok
	for submit <at> debbugs.gnu.org; Mon, 03 Jun 2024 15:25:22 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3117)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1sEDJ2-0007gP-D4
 for 69528 <at> debbugs.gnu.org; Mon, 03 Jun 2024 15:25:21 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A7706100048;
 Mon,  3 Jun 2024 15:25:01 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1717442700;
 bh=TU8sq9QDKZGlEsgTW4wteET4laVBvj/uDwFz7eCHcXY=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=kFqzRzw0x90AQP7yjoOEhLUoTcFYPNK4wBn0oUd6tdGEi7xb9iybQTgITAurlz9Sm
 bEZeWkPCJq24yoLOXAU9vc7uJL//tTP4nHK/t/F7kI4+4ofUfGA2Rs2HLxClKR6S7/
 KIPVwHDLy/jZHwRtjMKceb4NKwnbIgXhQOR41Km5sV8Qq24x2HVTZ7f24va5EXQtxu
 RpqYjrfR1mGqzSuRGMtuim48UD7+UrxcTv59rZUi/2fXKnu+WRBLiT/cusOZ5kvJ9m
 Oy7z7gxhgP6LrqK7dSV0nf7k4Q4dxasPCTxgto6M/H5GK4A5gait1u5sTTiTnw/IN6
 sZuvKJ1xUGJAg==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id ADB46100035;
 Mon,  3 Jun 2024 15:25:00 -0400 (EDT)
Received: from alfajor (unknown [23.233.149.155])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 82D6F1204B4;
 Mon,  3 Jun 2024 15:25:00 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <CADwFkm=p+QoWueCxymD0tiHQOq+g0SspiKQ8qbJX=K=ZyiP+1w@HIDDEN>
 (Stefan Kangas's message of "Mon, 3 Jun 2024 13:24:36 -0400")
Message-ID: <jwv4ja9al1g.fsf-monnier+emacs@HIDDEN>
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN> <86ed9qyxnm.fsf@HIDDEN>
 <CADwFkmn4S5ocBUYc5mKee1c38BBSVKLaWGbDBPYGWPpP4Rhwqw@HIDDEN>
 <871q5ffvs9.fsf@HIDDEN>
 <CADwFkmkw4s_LUK83o1HJPDNESRtocUVYcZ8SXtCJKx_AMZuN_Q@HIDDEN>
 <87wmn7ebg5.fsf@HIDDEN> <87mso3mc9p.fsf@HIDDEN>
 <CADwFkm=p+QoWueCxymD0tiHQOq+g0SspiKQ8qbJX=K=ZyiP+1w@HIDDEN>
Date: Mon, 03 Jun 2024 15:24:59 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.030 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain T_SCC_BODY_TEXT_LINE    -0.01 -
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> * lisp/emacs-lisp/lisp-mnt.el (lm-version): Prefer version in the
> "Package-Version:" header.  (Bug#69528)

BTW, I think this is a backward-incompatible change.

Whether we want `lm-version` to return the info from `Version:` or from
`Package-Version:` depends on what we want to do with it.


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Philip Kaludercic <philipk@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 03 Jun 2024 19:59:02 +0000
Resent-Message-ID: <handler.69528.B69528.17174447401657 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: iarchivedmywholelife@HIDDEN, Joseph Turner <joseph@HIDDEN>, 69528 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN>
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.17174447401657
          (code B ref 69528); Mon, 03 Jun 2024 19:59:02 +0000
Received: (at 69528) by debbugs.gnu.org; 3 Jun 2024 19:59:00 +0000
Received: from localhost ([127.0.0.1]:55716 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sEDpc-0000Qf-5c
	for submit <at> debbugs.gnu.org; Mon, 03 Jun 2024 15:59:00 -0400
Received: from mout01.posteo.de ([185.67.36.65]:50943)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1sEDpY-0000QJ-Ps
 for 69528 <at> debbugs.gnu.org; Mon, 03 Jun 2024 15:58:58 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 9473C24002A
 for <69528 <at> debbugs.gnu.org>; Mon,  3 Jun 2024 21:58:37 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1717444717; bh=0kqhsE8vjlGXDqQ9Ks4F3laSL0AJ7mjdYhF0BkjXBEw=;
 h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version:
 Content-Type:From;
 b=ONu3DBw7tggdEJlpyIVwjAnxKjaIXMU3cFdNVPRUfIMaADx0XXw2a37+aT+AsgWAu
 sn0ak+Xm/TD7g1ciP3utTZ88qESIZexzwwlkuTp1ohOJ9csxfUUbXU9wdjwKjW4cih
 tWvnhpHHOIy8UXtGJZBbnGOdjq9draUwzlE96rxaPkxniupiReajLUoZpc9UKNEmWV
 9hTbtb+eA9vhWG7GYT/eGdEEU9VQMHc8VMJpJAvC2w9ndGeE5xQnKmXtJZYwUNh25o
 gRq4j8d1aAzhO7fxr5g9c54m0jQxPutMSUIjd5B9HEGUUfgNhXLHlUlMkNVRG+DsHv
 d1DhNTkm1vcaw==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4VtPfz3xgSz6v0r;
 Mon,  3 Jun 2024 21:58:35 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
In-Reply-To: <jwv4ja9al1g.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Mon, 03 Jun 2024 15:24:59 -0400")
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN> <86ed9qyxnm.fsf@HIDDEN>
 <CADwFkmn4S5ocBUYc5mKee1c38BBSVKLaWGbDBPYGWPpP4Rhwqw@HIDDEN>
 <871q5ffvs9.fsf@HIDDEN>
 <CADwFkmkw4s_LUK83o1HJPDNESRtocUVYcZ8SXtCJKx_AMZuN_Q@HIDDEN>
 <87wmn7ebg5.fsf@HIDDEN> <87mso3mc9p.fsf@HIDDEN>
 <CADwFkm=p+QoWueCxymD0tiHQOq+g0SspiKQ8qbJX=K=ZyiP+1w@HIDDEN>
 <jwv4ja9al1g.fsf-monnier+emacs@HIDDEN>
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
 url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
 preference=signencrypt
Date: Mon, 03 Jun 2024 19:58:35 +0000
Message-ID: <87o78hdcic.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Stefan Monnier <monnier@HIDDEN> writes:

>> * lisp/emacs-lisp/lisp-mnt.el (lm-version): Prefer version in the
>> "Package-Version:" header.  (Bug#69528)
>
> BTW, I think this is a backward-incompatible change.
>
> Whether we want `lm-version` to return the info from `Version:` or from
> `Package-Version:` depends on what we want to do with it.

When do we want lm-version to return Version and not Package-Version,
where a (lm-header "version") wouldn't serve as a more specific
replacement?

FWIW the function is used in a single place (in the core, lm-report-bug)
and both on ELPA and NonGNU ELPA, all instances appear to might as well
be using `package-get-version' (if it were not for the version of Emacs
they are depending on).

-- 
	Philip Kaludercic on peregrine

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 03 Jun 2024 20:39:01 +0000
Resent-Message-ID: <handler.69528.B69528.17174471227094 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Philip Kaludercic <philipk@HIDDEN>
Cc: iarchivedmywholelife@HIDDEN, Joseph Turner <joseph@HIDDEN>, 69528 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN>
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.17174471227094
          (code B ref 69528); Mon, 03 Jun 2024 20:39:01 +0000
Received: (at 69528) by debbugs.gnu.org; 3 Jun 2024 20:38:42 +0000
Received: from localhost ([127.0.0.1]:55811 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sEES2-0001qM-4N
	for submit <at> debbugs.gnu.org; Mon, 03 Jun 2024 16:38:42 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9211)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1sEERz-0001q4-JT
 for 69528 <at> debbugs.gnu.org; Mon, 03 Jun 2024 16:38:41 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3A5DE8089D;
 Mon,  3 Jun 2024 16:38:20 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1717447099;
 bh=WTnYuykTgvotyPX0gV7+e0lV4wtzrEuGMLyG7JZQmJ4=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=CV4qRexDtxGwVZWwkDoy9TPecaOXa4ai2vGO26aOgvRdmtNklT5FgCtLAPikUzNn9
 AXCIASkhPxzWLQCb5zp5zsDL20FTXJZnaXkLRfwKlV6SXzUvFGnUvxn8Mx0F5x1s6O
 3J4v05+sRUawQerD8tsSYI6LJ7YPu2YMlwQtSAgXFtFvwnO3z05kEO7E6AjlImqBS4
 hYYKzcRa31SihsV9yoY4JVSWaKsfToeCJb5xCHHLtBP/7JRffayWbj1dzGuFfo1FOu
 QHvkCzMbiOzzCgx1VXXGP2M1IGzLWwF2zPeAK88knCVTMXUk0S/iv4FrmnVtML72fW
 aJFuH8wW+QvwA==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3214E805DE;
 Mon,  3 Jun 2024 16:38:19 -0400 (EDT)
Received: from pastel (unknown [24.140.236.196])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DE2F71202AB;
 Mon,  3 Jun 2024 16:38:18 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <87o78hdcic.fsf@HIDDEN> (Philip Kaludercic's message of "Mon, 
 03 Jun 2024 19:58:35 +0000")
Message-ID: <jwvh6e9n4qc.fsf-monnier+emacs@HIDDEN>
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN> <86ed9qyxnm.fsf@HIDDEN>
 <CADwFkmn4S5ocBUYc5mKee1c38BBSVKLaWGbDBPYGWPpP4Rhwqw@HIDDEN>
 <871q5ffvs9.fsf@HIDDEN>
 <CADwFkmkw4s_LUK83o1HJPDNESRtocUVYcZ8SXtCJKx_AMZuN_Q@HIDDEN>
 <87wmn7ebg5.fsf@HIDDEN> <87mso3mc9p.fsf@HIDDEN>
 <CADwFkm=p+QoWueCxymD0tiHQOq+g0SspiKQ8qbJX=K=ZyiP+1w@HIDDEN>
 <jwv4ja9al1g.fsf-monnier+emacs@HIDDEN> <87o78hdcic.fsf@HIDDEN>
Date: Mon, 03 Jun 2024 16:38:17 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.002 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain T_SCC_BODY_TEXT_LINE    -0.01 -
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>>> * lisp/emacs-lisp/lisp-mnt.el (lm-version): Prefer version in the
>>> "Package-Version:" header.  (Bug#69528)
>> BTW, I think this is a backward-incompatible change.
>> Whether we want `lm-version` to return the info from `Version:` or from
>> `Package-Version:` depends on what we want to do with it.
> When do we want lm-version to return Version and not Package-Version,
> where a (lm-header "version") wouldn't serve as a more specific
> replacement?

I don't know, but if we never want to return the value of `Version:`
when there's a `Package-Version:` then we don't need `Package-Version:`
either (we should just replace the `Version:` field with the content of
`Package-Version:`).

IOW the very existence of `Package-Version:` is predicated on the desire
to distinguish the two.


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 04 Jun 2024 22:22:02 +0000
Resent-Message-ID: <handler.69528.B69528.171753967317581 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>, Philip Kaludercic <philipk@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>, 69528 <at> debbugs.gnu.org, iarchivedmywholelife@HIDDEN, Joseph Turner <joseph@HIDDEN>
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171753967317581
          (code B ref 69528); Tue, 04 Jun 2024 22:22:02 +0000
Received: (at 69528) by debbugs.gnu.org; 4 Jun 2024 22:21:13 +0000
Received: from localhost ([127.0.0.1]:56312 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sEcWn-0004ZU-Dv
	for submit <at> debbugs.gnu.org; Tue, 04 Jun 2024 18:21:13 -0400
Received: from mail-lj1-f177.google.com ([209.85.208.177]:45099)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1sEcWk-0004Z4-UG
 for 69528 <at> debbugs.gnu.org; Tue, 04 Jun 2024 18:21:11 -0400
Received: by mail-lj1-f177.google.com with SMTP id
 38308e7fff4ca-2eaa794eb9fso48293881fa.2
 for <69528 <at> debbugs.gnu.org>; Tue, 04 Jun 2024 15:20:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1717539591; x=1718144391; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=6hbfZh2V6TsZZYy/K86/NDisg6u8vSZ9FPIlhr3sSj0=;
 b=dYRtmZlRZGS/X8xun82kzJXqtTZpz00nsHDtSwUwPW+vXzU1AF1rA7/U0wCVOm/FLH
 88SZRvExj1UtNAcOcFwV4v9e+k27TjCq5o3/1Z9K7V9A/3FljLqbFBcaheNNQwrR+Ms9
 w7ORT4ScQvRlqzTg0PfExiFyLw7n4LchGxK4wtHnO3sT3GWxlAu/QrA1GeXJaUHk4nLT
 HjHI5KyHr+k3lTIGTNM7bOmCQyX+y2C9ueURfGuNyLNOtGhYzFFJjnCB2xNj8qF5/Pxa
 ppJSM5ZWcBIh9MNHFf6Ah6e4Su17HgvblBRl/95TblVoNctQFQifEum1t759ZH6c3zrV
 sedg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1717539591; x=1718144391;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=6hbfZh2V6TsZZYy/K86/NDisg6u8vSZ9FPIlhr3sSj0=;
 b=suMRmfirkCNVLrKnXn/XNU0QsgyXVl1+peDjMh9T6U1ogFGDEA0BCtjyM2JsA7cbwf
 sa/hj1BI9TRnLTuQ4l/MxAyYpD/EJ6omu6o6lZ3JSJYB5DS4GXWNRHKv5l7RBSaeDBY9
 UWoqJZmFHWQui2cnYvSXVtZ05CXNoHeKd1kyH0aEDw8qvTS8awZvGrP8EMpibFi+PNTA
 +LKDs7nSeBUgU1i264EoHYyyik4nuZ6mQ2WvwDU4J4VtXowt02ABZYshAMV6Qm3nQMOY
 +TxfPGfCxPdF+bnkMhAVE4J2uyjfmNmE2f6gk2ZSdf6U0NCKllWmEUzfCVx+AVSmotTI
 DnaA==
X-Forwarded-Encrypted: i=1;
 AJvYcCV4x8PVF2RAMpA7373WPyMq65Z43xHAUruivzClP2CNnSKH1lFydGeKGS6MyRR/A5VW8Sp3eTJYjjw64vDTYRAcqCrkCJo=
X-Gm-Message-State: AOJu0Ywk0b3ZWCtWHkJESLsEqzlLmaXHq7j44VdqXqTyDYcC+jrdfwGp
 ix2jMWt2kqMxk/LXlYWSZD+kZiSD718eNqi7Oi6OtMrlYP0K7CdTpf/XoKTrqUWYIGMWyGIqhmd
 hh7NHkLEp+/Fi1KTsEsuigqVvqUI=
X-Google-Smtp-Source: AGHT+IHQq5GMm0tlHh0640LWRVH2JI3N6QGRp5yk/kvmXYFXtWO9U6AhS01ElYrP366+hs9R2sMNKH2C/H3b987aqpc=
X-Received: by 2002:a2e:a7c5:0:b0:2ea:7e9c:58c1 with SMTP id
 38308e7fff4ca-2eac7a52c4fmr3490151fa.40.1717539591072; Tue, 04 Jun 2024
 15:19:51 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Tue, 4 Jun 2024 18:19:50 -0400
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <jwvh6e9n4qc.fsf-monnier+emacs@HIDDEN>
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN> <86ed9qyxnm.fsf@HIDDEN>
 <CADwFkmn4S5ocBUYc5mKee1c38BBSVKLaWGbDBPYGWPpP4Rhwqw@HIDDEN>
 <871q5ffvs9.fsf@HIDDEN>
 <CADwFkmkw4s_LUK83o1HJPDNESRtocUVYcZ8SXtCJKx_AMZuN_Q@HIDDEN>
 <87wmn7ebg5.fsf@HIDDEN> <87mso3mc9p.fsf@HIDDEN>
 <CADwFkm=p+QoWueCxymD0tiHQOq+g0SspiKQ8qbJX=K=ZyiP+1w@HIDDEN>
 <jwv4ja9al1g.fsf-monnier+emacs@HIDDEN> <87o78hdcic.fsf@HIDDEN>
 <jwvh6e9n4qc.fsf-monnier+emacs@HIDDEN>
MIME-Version: 1.0
Date: Tue, 4 Jun 2024 18:19:50 -0400
Message-ID: <CADwFkmnWOhKk9wuLmR6B2pSs9PGeHmS4ENfoFarjkkXp539pow@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stefan Monnier <monnier@HIDDEN> writes:

>>>> * lisp/emacs-lisp/lisp-mnt.el (lm-version): Prefer version in the
>>>> "Package-Version:" header.  (Bug#69528)
>>> BTW, I think this is a backward-incompatible change.
>>> Whether we want `lm-version` to return the info from `Version:` or from
>>> `Package-Version:` depends on what we want to do with it.

AFAICT, we currently use it in `lm-report-bug' and with Joseph's patch
we will use it also for `loaddefs-generate--parse-file'.

>> When do we want lm-version to return Version and not Package-Version,
>> where a (lm-header "version") wouldn't serve as a more specific
>> replacement?
>
> I don't know, but if we never want to return the value of `Version:`
> when there's a `Package-Version:` then we don't need `Package-Version:`
> either (we should just replace the `Version:` field with the content of
> `Package-Version:`).

I don't have a strong opinion, but there seems to be a mismatch between
what the code does and what the documentation says.

    "The version number comes from the =E2=80=98Package-Version=E2=80=99 he=
ader, if it
    exists, or from the =E2=80=98Version=E2=80=99 header otherwise."

    (info "(elisp) Simple Packages")

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Joseph Turner <joseph@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 04 Jun 2024 22:24:02 +0000
Resent-Message-ID: <handler.69528.B69528.171753982818089 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: Philip Kaludercic <philipk@HIDDEN>, iarchivedmywholelife@HIDDEN, Stefan Monnier <monnier@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>, 69528 <at> debbugs.gnu.org
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171753982818089
          (code B ref 69528); Tue, 04 Jun 2024 22:24:02 +0000
Received: (at 69528) by debbugs.gnu.org; 4 Jun 2024 22:23:48 +0000
Received: from localhost ([127.0.0.1]:56528 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sEcZH-0004hg-Ld
	for submit <at> debbugs.gnu.org; Tue, 04 Jun 2024 18:23:47 -0400
Received: from out-170.mta1.migadu.com ([95.215.58.170]:14653)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <joseph@HIDDEN>) id 1sEcZG-0004hH-32
 for 69528 <at> debbugs.gnu.org; Tue, 04 Jun 2024 18:23:46 -0400
X-Envelope-To: stefankangas@HIDDEN
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; 
 s=key1; t=1717539775;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=9CBaA9KBkq9PzwhFDhFpRH0ahRV+2d0lgO9l/JVLyiY=;
 b=mhfyny/hNaEsdQ3ayHNWq5StnlsiI5FApviCDze+0aabD25uTBnQrIAZ962+r33rSCqBIy
 aU22TtIbAuuNJadi8JWOEF0Ul/aXJIgNfGUrPMZMYAvohDURLs+kBZdeeu0Swyqi62PtIg
 gvJ+bJYLgRZC7cCpteF/sLaZEtxbVs4=
X-Envelope-To: philipk@HIDDEN
X-Envelope-To: iarchivedmywholelife@HIDDEN
X-Envelope-To: 69528 <at> debbugs.gnu.org
X-Envelope-To: eliz@HIDDEN
X-Envelope-To: acorallo@HIDDEN
X-Envelope-To: monnier@HIDDEN
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
From: Joseph Turner <joseph@HIDDEN>
In-Reply-To: <CADwFkm=p+QoWueCxymD0tiHQOq+g0SspiKQ8qbJX=K=ZyiP+1w@HIDDEN>
 (Stefan Kangas's message of "Mon, 3 Jun 2024 13:24:36 -0400")
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN> <86ed9qyxnm.fsf@HIDDEN>
 <CADwFkmn4S5ocBUYc5mKee1c38BBSVKLaWGbDBPYGWPpP4Rhwqw@HIDDEN>
 <871q5ffvs9.fsf@HIDDEN>
 <CADwFkmkw4s_LUK83o1HJPDNESRtocUVYcZ8SXtCJKx_AMZuN_Q@HIDDEN>
 <87wmn7ebg5.fsf@HIDDEN> <87mso3mc9p.fsf@HIDDEN>
 <CADwFkm=p+QoWueCxymD0tiHQOq+g0SspiKQ8qbJX=K=ZyiP+1w@HIDDEN>
Date: Tue, 04 Jun 2024 15:22:50 -0700
Message-ID: <871q5cgxfp.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stefan Kangas <stefankangas@HIDDEN> writes:

> Joseph Turner <joseph@HIDDEN> writes:
>
>>> Of course, that was also the change proposed in my first patch but I
>>> didn't notice the change in Joseph's suggestion.
>
> Ah, right.  I somehow missed that part.
>
>> Thanks for the correction.  Are the attached patches appropriate?
>
> Looks good to me, except for a few comments below.

[...]

I'll be happy to make those changes if we decide to move forward with
the general idea of this patch.

Thanks!

Joseph

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 04 Jun 2024 22:56:02 +0000
Resent-Message-ID: <handler.69528.B69528.171754172123619 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69528
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: Philip Kaludercic <philipk@HIDDEN>, iarchivedmywholelife@HIDDEN, Joseph Turner <joseph@HIDDEN>, 69528 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Andrea Corallo <acorallo@HIDDEN>
Received: via spool by 69528-submit <at> debbugs.gnu.org id=B69528.171754172123619
          (code B ref 69528); Tue, 04 Jun 2024 22:56:02 +0000
Received: (at 69528) by debbugs.gnu.org; 4 Jun 2024 22:55:21 +0000
Received: from localhost ([127.0.0.1]:58874 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sEd3o-00068r-5l
	for submit <at> debbugs.gnu.org; Tue, 04 Jun 2024 18:55:20 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29241)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>)
 id 1sEck4-0005GO-Hk; Tue, 04 Jun 2024 18:34:57 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 20B0D80A6B;
 Tue,  4 Jun 2024 18:34:37 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1717540476;
 bh=nA7hOIzDcAA03ngZQqL+o4ZSHs5xMy5AdLez425r4gI=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=i4mOQvMml3sn905gZtNrROVKagWrj/T7xEv59OzjPjqMhUGRBVh0w8CmTRpI29H0h
 RpgrPVBJE+/o0O69EOU7QLrlBCw8WnYFtLxA3KDof+jp7NBLV65TmOm+9sBUash0aV
 d7ROuofJa9F+lR1tEPS867NDCTtRYZsihT/KGs1fkvsWfTRiKjoyo9oux9V8sfKy9u
 o6hlsRWDNOXZxag5kFdvHzAWyTf8c9Vkt3cgGTX84zDyM/bkEKk4UJrwTuCsOEjCAp
 ekuE+RZDampo8wf/ocrYMXzlaJJh0L/pY3Rsit36+wI2lh9/VR6Ob3kYaWoz0fVy4/
 xVYGmPSW3Um7w==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EBB4B807F5;
 Tue,  4 Jun 2024 18:34:35 -0400 (EDT)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CDFB61203C3;
 Tue,  4 Jun 2024 18:34:35 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <CADwFkmnWOhKk9wuLmR6B2pSs9PGeHmS4ENfoFarjkkXp539pow@HIDDEN>
 (Stefan Kangas's message of "Tue, 4 Jun 2024 18:19:50 -0400")
Message-ID: <jwv8qzkl4z5.fsf-monnier+emacs@HIDDEN>
References: <87edcrtegz.fsf@HIDDEN> <87sf15rjyf.fsf@HIDDEN>
 <8734t5yh49.fsf@HIDDEN> <87edcp9p54.fsf@HIDDEN>
 <878qzypbav.fsf@HIDDEN> <86ed9qyxnm.fsf@HIDDEN>
 <CADwFkmn4S5ocBUYc5mKee1c38BBSVKLaWGbDBPYGWPpP4Rhwqw@HIDDEN>
 <871q5ffvs9.fsf@HIDDEN>
 <CADwFkmkw4s_LUK83o1HJPDNESRtocUVYcZ8SXtCJKx_AMZuN_Q@HIDDEN>
 <87wmn7ebg5.fsf@HIDDEN> <87mso3mc9p.fsf@HIDDEN>
 <CADwFkm=p+QoWueCxymD0tiHQOq+g0SspiKQ8qbJX=K=ZyiP+1w@HIDDEN>
 <jwv4ja9al1g.fsf-monnier+emacs@HIDDEN> <87o78hdcic.fsf@HIDDEN>
 <jwvh6e9n4qc.fsf-monnier+emacs@HIDDEN>
 <CADwFkmnWOhKk9wuLmR6B2pSs9PGeHmS4ENfoFarjkkXp539pow@HIDDEN>
Date: Tue, 04 Jun 2024 18:34:35 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.011 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain T_SCC_BODY_TEXT_LINE    -0.01 -
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>>>>> * lisp/emacs-lisp/lisp-mnt.el (lm-version): Prefer version in the
>>>>> "Package-Version:" header.  (Bug#69528)
>>>> BTW, I think this is a backward-incompatible change.
>>>> Whether we want `lm-version` to return the info from `Version:` or from
>>>> `Package-Version:` depends on what we want to do with it.
> AFAICT, we currently use it in `lm-report-bug' and with Joseph's patch
> we will use it also for `loaddefs-generate--parse-file'.

`lm-report-bug` does not seem directly related to ELPA packaging, so it
makes sense to use just `Version:` there, which is presumably the format
that the maintainer favors (where the `Package-Version:` header is
instead the format that the maintainer was forced to add to accommodate
the restrictions of the ELPA protocol).

In contrast, `loaddefs-generate--parse-file' is about generating info
for `package.el`, so this one *does* want to use `Package-Version:`
if it's present.

Of course `lm-report-bug` would work likely fine as well if it uses
`Package-Version:`.  The distinction is probably not that important in
that case.

> I don't have a strong opinion, but there seems to be a mismatch between
> what the code does and what the documentation says.
>
>     "The version number comes from the =E2=80=98Package-Version=E2=80=99 =
header, if it
>     exists, or from the =E2=80=98Version=E2=80=99 header otherwise."
>
>     (info "(elisp) Simple Packages")

Definitely.  My only point was that the patch changed `lm-version` in
a backward incompatible way (tho arguably a minor one) without even
mentioning it.
Maybe it's OK to do that, but let's do it consciously.
If not, then we'll presumably add a new `lm-package-version` (which
wouldn't look at RCS keywords either).


        Stefan

Last modified: Tue, 4 Jun 2024 23:00:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.