GNU logs - #6967, boring messages

Message sent to owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN:

Subject: bug#6967: flymake not cleaning after itself (kill-buffer)
Resent-From: S Boucher <stbya@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-To: owner <at> debbugs.gnu.org
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 01 Sep 2010 19:18:02 +0000
Resent-Message-ID: <handler.6967.B.128336864716112 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 6967 <at> debbugs.gnu.org
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com;
	h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:MIME-Version:Content-Type;
	b=c52+KLIFPO1IN5mIMN2cyH2Q/wVHXAeMy04kckWay4rPdPNiveNj05yklTZJPtuVZ88+lsJXdBRLv9Vkx5YazyklV95OagKu6I3MFkArp8MIQP6iaXIBUE/sSISEqCxYX/jV1qCx0CNrXcExXYL9kKVko9u6syivmAwcVYf9TD0=;
Message-ID: <696071.46975.qm@HIDDEN>
Date: Wed, 1 Sep 2010 12:19:02 -0700 (PDT)
From: S Boucher <stbya@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org

That's with emacs 23.2

flymake-kill-buffer-hook does not actually kill the flymake process.  So, if flymake is used in conjunction with semantic, it gets problematic.

When semantic does background parsing, it may find-file/kill-buffer for files not already in memory.  If semantic proceeds to kill-buffer while a flymake process is running, then a window pops up asking whether the buffer's process should be killed (because kill-buffer asks before killing processes).

It seems like flymake-kill-buffer-hook should kill the buffer, so that by the time semantic calls kill-buffer, there won't be a process to query about.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: S Boucher <stbya@HIDDEN>
Subject: bug#6967: Acknowledgement (flymake not cleaning after itself
 (kill-buffer))
Message-ID: <handler.6967.B.128336864716112.ack <at> debbugs.gnu.org>
References: <696071.46975.qm@HIDDEN>
X-Gnu-PR-Message: ack 6967
X-Gnu-PR-Package: emacs
Reply-To: 6967 <at> debbugs.gnu.org
Date: Wed, 01 Sep 2010 19:18:02 +0000

Thank you for filing a new bug report with GNU.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 6967 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
6967: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D6967
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN:

Subject: bug#6967: flymake not cleaning after itself (kill-buffer)
Resent-From: Chong Yidong <cyd@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-To: owner <at> debbugs.gnu.org
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 24 Oct 2010 17:11:02 +0000
Resent-Message-ID: <handler.6967.B6967.128794024515172 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: S Boucher <stbya@HIDDEN>
Cc: Eric Ludlam <zappo@HIDDEN>, 6967 <at> debbugs.gnu.org
From: Chong Yidong <cyd@HIDDEN>
References: <696071.46975.qm@HIDDEN>
Date: Sun, 24 Oct 2010 13:14:38 -0400
In-Reply-To: <696071.46975.qm@HIDDEN> (S. Boucher's
	message of "Wed, 1 Sep 2010 12:19:02 -0700 (PDT)")
Message-ID: <87eibffr7l.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org

S Boucher <stbya@HIDDEN> writes:

> flymake-kill-buffer-hook does not actually kill the flymake process.
> So, if flymake is used in conjunction with semantic, it gets
> problematic.
>
> When semantic does background parsing, it may find-file/kill-buffer
> for files not already in memory.  If semantic proceeds to kill-buffer
> while a flymake process is running, then a window pops up asking
> whether the buffer's process should be killed (because kill-buffer
> asks before killing processes).
>
> It seems like flymake-kill-buffer-hook should kill the buffer, so that
> by the time semantic calls kill-buffer, there won't be a process to
> query about.

It would be wrong for flymake-kill-buffer-hook to kill the buffer,
because there may be other functions on the hook that may need to
examine the buffer state.

The problem here seems to be that when Semantic visits files to parse
them, Flymake is enabled when it should not.  I'm guessing you are using
flymake-find-file-hook, is that correct?

Maybe the solution is for Semantic to either avoid using
find-file[-noselect], or detect if Flymake is on and disable it for
files that are only being parsed temporarily.  Eric, what do you think?

Message sent to owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN:

Subject: bug#6967: flymake not cleaning after itself (kill-buffer)
Resent-From: "Eric M. Ludlam" <eric@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-To: owner <at> debbugs.gnu.org
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 25 Oct 2010 11:12:01 +0000
Resent-Message-ID: <handler.6967.B6967.128800511320530 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Chong Yidong <cyd@HIDDEN>
Cc: S Boucher <stbya@HIDDEN>, Eric Ludlam <zappo@HIDDEN>, 6967 <at> debbugs.gnu.org
Message-ID: <4CC566E3.4020905@HIDDEN>
Date: Mon, 25 Oct 2010 07:15:47 -0400
From: "Eric M. Ludlam" <eric@HIDDEN>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.3a1pre) Gecko/20091222 Shredder/3.1a1pre
MIME-Version: 1.0
References: <696071.46975.qm@HIDDEN>
	<87eibffr7l.fsf@HIDDEN>
In-Reply-To: <87eibffr7l.fsf@HIDDEN>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org

On 10/24/2010 01:14 PM, Chong Yidong wrote:
> S Boucher<stbya@HIDDEN>  writes:
>
>> flymake-kill-buffer-hook does not actually kill the flymake process.
>> So, if flymake is used in conjunction with semantic, it gets
>> problematic.
>>
>> When semantic does background parsing, it may find-file/kill-buffer
>> for files not already in memory.  If semantic proceeds to kill-buffer
>> while a flymake process is running, then a window pops up asking
>> whether the buffer's process should be killed (because kill-buffer
>> asks before killing processes).
>>
>> It seems like flymake-kill-buffer-hook should kill the buffer, so that
>> by the time semantic calls kill-buffer, there won't be a process to
>> query about.
>
> It would be wrong for flymake-kill-buffer-hook to kill the buffer,
> because there may be other functions on the hook that may need to
> examine the buffer state.
>
> The problem here seems to be that when Semantic visits files to parse
> them, Flymake is enabled when it should not.  I'm guessing you are using
> flymake-find-file-hook, is that correct?
>
> Maybe the solution is for Semantic to either avoid using
> find-file[-noselect], or detect if Flymake is on and disable it for
> files that are only being parsed temporarily.  Eric, what do you think?

Semantic uses semantic-find-file-noselect which clears out a list of 
hooks and settings before calling find-file-noselect to avoid problems 
like this.

Semantic needs a variant of find-file that puts a buffer into the 
correct mode, which in turn runs the major-mode hook.  It also needs to 
run the mode-local hooks, but doesn't run miscellaneous other 
interactive tool hooks.

I suppose Semantic could also have a pre-find-file hook that authors of 
modes like flymake could install a temporary uninstall hook into, but 
that seems kind of strange.

Eric

Message sent to owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#6967: flymake not cleaning after itself (kill-buffer)
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-To: owner <at> debbugs.gnu.org
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 25 Oct 2010 16:17:01 +0000
Resent-Message-ID: <handler.6967.B6967.128802340631024 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 6967
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: "Eric M. Ludlam" <eric@HIDDEN>
Cc: S Boucher <stbya@HIDDEN>, Chong Yidong <cyd@HIDDEN>, Eric Ludlam <zappo@HIDDEN>, 6967 <at> debbugs.gnu.org
Received: via spool by 6967-submit <at> debbugs.gnu.org id=B6967.128802340631024
          (code B ref 6967); Mon, 25 Oct 2010 16:17:01 +0000
Received: (at 6967) by debbugs.gnu.org; 25 Oct 2010 16:16:46 +0000
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1PAPj3-00084L-R7
	for submit <at> debbugs.gnu.org; Mon, 25 Oct 2010 12:16:46 -0400
Received: from ironport2-out.teksavvy.com ([206.248.154.181]
	helo=ironport2-out.pppoe.ca)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <monnier@HIDDEN>) id 1PAPj1-00084F-Qs
	for 6967 <at> debbugs.gnu.org; Mon, 25 Oct 2010 12:16:44 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AmQJAJZLxUxFxL/T/2dsb2JhbACgYntyvSGFSASSHw
X-IronPort-AV: E=Sophos;i="4.58,236,1286164800"; d="scan'208";a="80629505"
Received: from 69-196-191-211.dsl.teksavvy.com (HELO pastel.home)
	([69.196.191.211])
	by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA;
	25 Oct 2010 12:20:45 -0400
Received: by pastel.home (Postfix, from userid 20848)
	id 0EA73A8506; Mon, 25 Oct 2010 12:20:45 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwviq0qnt54.fsf-monnier+emacs@HIDDEN>
References: <696071.46975.qm@HIDDEN>
	<87eibffr7l.fsf@HIDDEN> <4CC566E3.4020905@HIDDEN>
Date: Mon, 25 Oct 2010 12:20:45 -0400
In-Reply-To: <4CC566E3.4020905@HIDDEN> (Eric M. Ludlam's message of
	"Mon, 25 Oct 2010 07:15:47 -0400")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.1 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -2.1 (--)

> Semantic needs a variant of find-file that puts a buffer into the correct
> mode, which in turn runs the major-mode hook.  It also needs to run the
> mode-local hooks, but doesn't run miscellaneous other interactive
> tool hooks.

IIUC Semantic visits those files "temporarily" (i.e. it will kill the
buffer afterwards, although probably not if the buffer already existed).

I think this need is not specific to Semantic, and so we should provide
this functionality in files.el.  Maybe in a `with-found-file' macro.


        Stefan

Message sent to owner <at> debbugs.gnu.org, bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#6967: flymake not cleaning after itself (kill-buffer)
References: <696071.46975.qm@HIDDEN>
Resent-From: S Boucher <stbya@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-To: owner <at> debbugs.gnu.org
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 25 Oct 2010 21:51:01 +0000
Resent-Message-ID: <handler.6967.B6967.128804342710207 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 6967
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Chong Yidong <cyd@HIDDEN>, "Eric M. Ludlam" <eric@HIDDEN>
Cc: Eric Ludlam <zappo@HIDDEN>, 6967 <at> debbugs.gnu.org
Received: via spool by 6967-submit <at> debbugs.gnu.org id=B6967.128804342710207
          (code B ref 6967); Mon, 25 Oct 2010 21:51:01 +0000
Received: (at 6967) by debbugs.gnu.org; 25 Oct 2010 21:50:27 +0000
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1PAUvz-0002ea-1Y
	for submit <at> debbugs.gnu.org; Mon, 25 Oct 2010 17:50:27 -0400
Received: from web56807.mail.re3.yahoo.com ([66.196.97.81])
	by debbugs.gnu.org with smtp (Exim 4.69)
	(envelope-from <stbya@HIDDEN>) id 1PAUvx-0002eU-0j
	for 6967 <at> debbugs.gnu.org; Mon, 25 Oct 2010 17:50:25 -0400
Received: (qmail 58933 invoked by uid 60001); 25 Oct 2010 21:54:27 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024;
	t=1288043667; bh=y4AeJA0g3DOhmEiQD0KuOfbSOGMfOmCyN73phthSBEk=;
	h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
	b=s3csIIiGg6svr26WZSNN4BaLXgF7wPWS58H51o/Yyl/W1JEbGZsCOGtQMDFXFmLz2BM2funRxb6mZ59C4z241az8qpzTbI9LDy37FR4WtVVTLVJjiI/hOiCvj2EEKQIzNMkSmAesUqvjM/A+uVSEGDCXHYWS9qQTToVpQODNtbY=
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com;
	h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
	b=S+g0eMo/LsS+JRFSI9okXGfpq9L1rHhPEZlgdGUOeMFszS3mehrEkhA4mo3dJP2SG7bjrFuFxqCxdtWCdt+O8sC91ZndPuysiaN7lA4IiilNJ9b3BX17DQK0GnY9O91ooz8DG294fWV8r9vAlzGHBlChe9Gjw25KPODI+Naodm0=;
Message-ID: <369403.57458.qm@HIDDEN>
X-YMail-OSG: cT4iWhAVM1lAnY9Hnh3zaWWHgC37pXwfNO.KcmvycsN47fK
	BJwaFLrHkoMdIYCEdq3cajBYK9tNdwm_5.f98sHAiYvz7El5qR5ZT5ygJe1.
	Wwdh_sKqAmXxvg5SQJjz_KA.Hqiba3XZnQkZKrVUiaRR.AYTq6L7lpv2nL6s
	Mf9mnCB9qWinl5pxGOPNCsBoAHc3bw40rvW8va3tbaZLS5DY9mRQrhy4qKql
	.NKgfvsJYLIT0lzbBVWVwukXzU8mqTixqt.NitJovTnwMBrBMAF5IEk1Rvwv
	ZqkFY77OzdbrZ6N9CGeTRrjD6M4gZpQ9lvkRkWJis_2aQB3QwzrVMag--
Received: from [209.5.112.166] by web56807.mail.re3.yahoo.com via HTTP;
	Mon, 25 Oct 2010 14:54:27 PDT
X-Mailer: YahooMailClassic/11.4.9 YahooMailWebService/0.8.107.284920
Date: Mon, 25 Oct 2010 14:54:27 -0700 (PDT)
From: S Boucher <stbya@HIDDEN>
In-Reply-To: <4CC566E3.4020905@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -3.9 (---)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -3.7 (---)

=0A> Semantic needs a variant of find-file that puts a buffer=0A> into the =
correct mode, which in turn runs the major-mode=0A> hook.=A0 It also needs =
to run the mode-local hooks, but=0A> doesn't run miscellaneous other intera=
ctive tool hooks.=0A> =0A> I suppose Semantic could also have a pre-find-fi=
le hook=0A> that authors of modes like flymake could install a temporary=0A=
> uninstall hook into, but that seems kind of strange.=0A=0AA generic flag =
that indicates whether it is background find-file should be enough for flym=
ake to decide not to run subprocesses, and for other modes to decide based =
on this flag.=0A=0AStill, I think that on kill-buffer, flymake should just =
kill the process.=0A =0A=0A

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.