GNU bug report logs - #6980
Could goto-char please have its own history list?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6980 in the body.
You can then email your comments to 6980 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: Could goto-char please have its own history list?
Date: Sat, 4 Sep 2010 00:24:21 +0200

I can't see no reason its history should be mixed by something else.
(More than devel historic reasons ;-)

Message #8 received at 6980 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 6980 <at> debbugs.gnu.org
Subject: Re: Could goto-char please have its own history list?
Date: Wed, 10 Aug 2011 22:50:39 +0300

> I can't see no reason its history should be mixed by something else.
> (More than devel historic reasons ;-)

It makes sense to share the same history that contains only numeric
values between all commands that use `read-number', like
e.g. `goto-line' and `goto-char' (with some changes), because
non-numeric values (added to the history from other commands)
are useless for such number-reading commands.

Message #11 received at 6980 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Juri Linkov'" <juri <at> jurta.org>,
	"'Lennart Borgman'" <lennart.borgman <at> gmail.com>
Cc: 6980 <at> debbugs.gnu.org
Subject: RE: bug#6980: Could goto-char please have its own history list?
Date: Wed, 10 Aug 2011 14:41:51 -0700

> > I can't see no reason its history should be mixed by something else.
> > (More than devel historic reasons ;-)
> 
> It makes sense to share the same history that contains only numeric
> values between all commands that use `read-number', like
> e.g. `goto-line' and `goto-char' (with some changes), because
> non-numeric values (added to the history from other commands)
> are useless for such number-reading commands.

I don't have much of an opinion about the suggestion.
There are always pros & cons to making a history more or less specific.

But I'll point out that just because non-numeric histories are inappropriate for
numeric input does not mean that the same numeric history should be used for all
numeric inputs.

Message #14 received at 6980 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 'Lennart Borgman' <lennart.borgman <at> gmail.com>, 6980 <at> debbugs.gnu.org
Subject: Re: bug#6980: Could goto-char please have its own history list?
Date: Thu, 18 Aug 2011 14:52:20 +0300

>> > I can't see no reason its history should be mixed by something else.
>> > (More than devel historic reasons ;-)
>>
>> It makes sense to share the same history that contains only numeric
>> values between all commands that use `read-number', like
>> e.g. `goto-line' and `goto-char' (with some changes), because
>> non-numeric values (added to the history from other commands)
>> are useless for such number-reading commands.
>
> I don't have much of an opinion about the suggestion.
> There are always pros & cons to making a history more or less specific.
>
> But I'll point out that just because non-numeric histories are inappropriate for
> numeric input does not mean that the same numeric history should be used for all
> numeric inputs.

Yes, not all number-reading commands should share the numeric history.

For instance, version-control commands that read a revision number
can also accept non-numeric values like "submit:".  So every case
should be carefully considered on its own.

Message #17 received at 6980 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Juri Linkov <juri <at> jurta.org>
Cc: 6980 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#6980: Could goto-char please have its own history list?
Date: Thu, 18 Aug 2011 14:27:27 +0200

On Thu, Aug 18, 2011 at 13:52, Juri Linkov <juri <at> jurta.org> wrote:
>>> > I can't see no reason its history should be mixed by something else.
>>> > (More than devel historic reasons ;-)
>>>
>>> It makes sense to share the same history that contains only numeric
>>> values between all commands that use `read-number', like
>>> e.g. `goto-line' and `goto-char' (with some changes), because
>>> non-numeric values (added to the history from other commands)
>>> are useless for such number-reading commands.
>>
>> I don't have much of an opinion about the suggestion.
>> There are always pros & cons to making a history more or less specific.
>>
>> But I'll point out that just because non-numeric histories are inappropriate for
>> numeric input does not mean that the same numeric history should be used for all
>> numeric inputs.
>
> Yes, not all number-reading commands should share the numeric history.
>
> For instance, version-control commands that read a revision number
> can also accept non-numeric values like "submit:".  So every case
> should be carefully considered on its own.

And of course I mean "I can see no reason its history should be mixed
by something else". ;-)

Message #22 received at 6980 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 6980 <at> debbugs.gnu.org
Subject: Re: bug#6980: Could goto-char please have its own history list?
Date: Wed, 17 Feb 2021 10:51:08 +0200

>> I can't see no reason its history should be mixed by something else.
>> (More than devel historic reasons ;-)
>
> It makes sense to share the same history that contains only numeric
> values between all commands that use `read-number', like
> e.g. `goto-line' and `goto-char' (with some changes), because
> non-numeric values (added to the history from other commands)
> are useless for such number-reading commands.

Matt reminded about this request in
https://lists.gnu.org/archive/html/emacs-devel/2021-02/msg01270.html

Now `read-number' has own history in `read-number-history' added a year ago
in bug#38282.  The same commit 7c5d6a2afc6 also added `goto-line-history'
for `goto-line'.

So this request could be closed unless there is still a need to add
`goto-char-history' for `goto-char' too.  I'm not sure if
`read-number-history' is sufficient already, or own history should be added
to every number-reading command like `move-to-column', etc.

Message #25 received at 6980 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> jurta.org>
Cc: Lennart Borgman <lennart.borgman <at> gmail.com>, 6980 <at> debbugs.gnu.org
Subject: Re: bug#6980: Could goto-char please have its own history list?
Date: Sun, 18 Jul 2021 22:22:58 +0200

Juri Linkov <juri <at> jurta.org> writes:

> Now `read-number' has own history in `read-number-history' added a year ago
> in bug#38282.  The same commit 7c5d6a2afc6 also added `goto-line-history'
> for `goto-line'.
>
> So this request could be closed unless there is still a need to add
> `goto-char-history' for `goto-char' too.  I'm not sure if
> `read-number-history' is sufficient already, or own history should be added
> to every number-reading command like `move-to-column', etc.

I think the new number history is probably sufficient, so I'm closing
this bug report.  But I wouldn't object if somebody feels strongly that
`goto-char' should have its own history.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.