GNU logs - #6986, boring messages

Message sent to owner <at> debbugs.gnu.org, bug-coreutils@HIDDEN:

Subject: bug#6986: [PATCH] test: add check to determine whether files are on the same device
Resent-From: Dieter Plaetinck <dieter@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-To: owner <at> debbugs.gnu.org
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Sun, 05 Sep 2010 13:35:02 +0000
Resent-Message-ID: <handler.6986.B.128369366812922 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 6986 <at> debbugs.gnu.org
Date: Sun, 5 Sep 2010 13:13:42 +0200
From: Dieter Plaetinck <dieter@HIDDEN>
Message-ID: <20100905131342.470022a6@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org

In the test program, there is '-ef' which checks whether files
are on the same device *and* have the same inode number.
This change introduces '-ed' which is basically the same, minus the
inode number checking
---
 src/test.c |   19 +++++++++++++++----
 1 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/src/test.c b/src/test.c
index e2247d2..8e738e9 100644
--- a/src/test.c
+++ b/src/test.c
@@ -174,9 +174,9 @@ static bool
 binop (char const *s)
 {
   return ((STREQ (s,   "=")) || (STREQ (s,  "!=")) || (STREQ (s, "-nt")) ||
-          (STREQ (s, "-ot")) || (STREQ (s, "-ef")) || (STREQ (s, "-eq")) ||
-          (STREQ (s, "-ne")) || (STREQ (s, "-lt")) || (STREQ (s, "-le")) ||
-          (STREQ (s, "-gt")) || (STREQ (s, "-ge")));
+          (STREQ (s, "-ot")) || (STREQ (s, "-ed")) || (STREQ (s, "-ef")) ||
+          (STREQ (s, "-eq")) || (STREQ (s, "-ne")) || (STREQ (s, "-lt")) ||
+          (STREQ (s, "-le")) || (STREQ (s, "-gt")) || (STREQ (s, "-ge")));
 }
 
 /*
@@ -191,7 +191,7 @@ binop (char const *s)
  *	string
  *	string ('!='|'=') string
  *	<int> '-'(eq|ne|le|lt|ge|gt) <int>
- *	file '-'(nt|ot|ef) file
+ *	file '-'(nt|ot|ed|ef) file
  *	'(' <expr> ')'
  * int ::=
  *	'-l' string
@@ -327,6 +327,16 @@ binary_operator (bool l_is_l)
           break;
 
         case 'e':
+          if (argv[op][2] == 'd' && !argv[op][3])
+            {
+              /* ed - same device? */
+              pos += 3;
+              if (l_is_l || r_is_l)
+                test_syntax_error (_("-ed does not accept -l"), NULL);
+              return (stat (argv[op - 1], &stat_buf) == 0
+                      && stat (argv[op + 1], &stat_spare) == 0
+                      && stat_buf.st_dev == stat_spare.st_dev);
+            }
           if (argv[op][2] == 'f' && !argv[op][3])
             {
               /* ef - hard link? */
@@ -726,6 +736,7 @@ EXPRESSION is true or false and sets exit status.  It is one of:\n\
 "), stdout);
       fputs (_("\
 \n\
+  FILE1 -ed FILE2   FILE1 and FILE2 have the same device number\n\
   FILE1 -ef FILE2   FILE1 and FILE2 have the same device and inode numbers\n\
   FILE1 -nt FILE2   FILE1 is newer (modification date) than FILE2\n\
   FILE1 -ot FILE2   FILE1 is older than FILE2\n\
-- 
1.7.2.3

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.427 (Entity 5.427)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Dieter Plaetinck <dieter@HIDDEN>
Subject: bug#6986: Acknowledgement ([PATCH] test: add check to determine
 whether files are on the same device)
Message-ID: <handler.6986.B.128369366812922.ack <at> debbugs.gnu.org>
References: <20100905131342.470022a6@HIDDEN>
X-Gnu-PR-Message: ack 6986
X-Gnu-PR-Package: coreutils
X-Gnu-PR-Keywords: patch
Reply-To: 6986 <at> debbugs.gnu.org
Date: Sun, 05 Sep 2010 13:35:02 +0000

Thank you for filing a new bug report with GNU.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-coreutils@HIDDEN

If you wish to submit further information on this problem, please
send it to 6986 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
6986: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D6986
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to owner <at> debbugs.gnu.org, bug-coreutils@HIDDEN:

Subject: bug#6986: [PATCH] test: add check to determine whether files are on the same device
Resent-From: Jim Meyering <jim@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-To: owner <at> debbugs.gnu.org
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Mon, 06 Sep 2010 18:23:02 +0000
Resent-Message-ID: <handler.6986.B6986.128379735032068 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Dieter Plaetinck <dieter@HIDDEN>
Cc: 6986 <at> debbugs.gnu.org
From: Jim Meyering <jim@HIDDEN>
In-Reply-To: <20100905131342.470022a6@HIDDEN> (Dieter Plaetinck's
	message of "Sun, 5 Sep 2010 13:13:42 +0200")
References: <20100905131342.470022a6@HIDDEN>
Date: Mon, 06 Sep 2010 20:24:16 +0200
Message-ID: <87hbi2vigf.fsf@HIDDEN>
Lines: 40
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org

Dieter Plaetinck wrote:
> In the test program, there is '-ef' which checks whether files
> are on the same device *and* have the same inode number.
> This change introduces '-ed' which is basically the same, minus the
> inode number checking
> ---
>  src/test.c |   19 +++++++++++++++----
>  1 files changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/src/test.c b/src/test.c

Thank you for the patch.
However, can you make a case for adding this to test
rather than using an existing tool like stat?

For example, here's a tiny shell function:

    same_dev()
    {
      local d1=$(stat --format=%d "$1") || return 1
      local d2=$(stat --format=%d "$2") || return 1
      test "$d1" = "$d2"
    }

You could use it like this:

    $ same_dev a b && echo same
    same
    $ same_dev a / && echo same || echo different devices
    different devices

That it's so easy to accomplish the same thing with
existing tools makes it hard to justify adding the feature.

Besides, if you're really interested in getting this feature
into "test", you don't want to start with coreutils.
Its "test" program is used only rarely, since "test"
is always a shell built-in, these days.
Thus you'd want to request that your feature be added
to at least bash and zsh.

Message sent to owner <at> debbugs.gnu.org, bug-coreutils@HIDDEN:

Subject: bug#6986: [PATCH] test: add check to determine whether files are on the same device
Resent-From: Dieter Plaetinck <dieter@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-To: owner <at> debbugs.gnu.org
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Mon, 06 Sep 2010 20:07:02 +0000
Resent-Message-ID: <handler.6986.B6986.12838035832265 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Jim Meyering <jim@HIDDEN>
Cc: 6986 <at> debbugs.gnu.org
Date: Mon, 6 Sep 2010 21:33:22 +0200
From: Dieter Plaetinck <dieter@HIDDEN>
Message-ID: <20100906213322.0e40a821@HIDDEN>
In-Reply-To: <87hbi2vigf.fsf@HIDDEN>
References: <20100905131342.470022a6@HIDDEN>
	<87hbi2vigf.fsf@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: list
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org

On Mon, 06 Sep 2010 20:24:16 +0200
Jim Meyering <jim@HIDDEN> wrote:

> Dieter Plaetinck wrote:
> > In the test program, there is '-ef' which checks whether files
> > are on the same device *and* have the same inode number.
> > This change introduces '-ed' which is basically the same, minus the
> > inode number checking
> > ---
> >  src/test.c |   19 +++++++++++++++----
> >  1 files changed, 15 insertions(+), 4 deletions(-)
> >
> > diff --git a/src/test.c b/src/test.c
> 
> Thank you for the patch.
> However, can you make a case for adding this to test
> rather than using an existing tool like stat?
> 
> For example, here's a tiny shell function:
> 
>     same_dev()
>     {
>       local d1=$(stat --format=%d "$1") || return 1
>       local d2=$(stat --format=%d "$2") || return 1
>       test "$d1" = "$d2"
>     }
> 
> You could use it like this:
> 
>     $ same_dev a b && echo same
>     same
>     $ same_dev a / && echo same || echo different devices
>     different devices
> 
> That it's so easy to accomplish the same thing with
> existing tools makes it hard to justify adding the feature.
> 
> Besides, if you're really interested in getting this feature
> into "test", you don't want to start with coreutils.
> Its "test" program is used only rarely, since "test"
> is always a shell built-in, these days.
> Thus you'd want to request that your feature be added
> to at least bash and zsh.


Hey Jim,
at first I considered writing a shell function like the one you suggest.
But putting it in test seemed like a better, more generally useful
place, especially since there are some similar functions in test.
(like -ef), and it's just a few lines of C code.
I would argue some of the existing functionality in test can as
easily be removed in favor of a shell function.  (I don't suggest
doing so)

Ie, for test -O :
owned_by_me ()
{
  local owner_id=$(stat --format='%u' "$1") || return 1
  test $owner_id -eq $EUID
}

I know some shells provide the 'test' features as a built-in,
that's fine.  But they should mimic the features test has.
It makes the shell implementation dependent on test, not the
other way around.  If this feature is considered useful for test, and
gets merged into test, shells will follow soon enough.

But anyway, your call :)
At least thanks for the timely feedback and have a nice day.

Dieter

Message sent to owner <at> debbugs.gnu.org, bug-coreutils@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#6986: [PATCH] test: add check to determine whether files are on the same device
Resent-From: Jim Meyering <jim@HIDDEN>
Original-Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Resent-To: owner <at> debbugs.gnu.org
Resent-CC: bug-coreutils@HIDDEN
Resent-Date: Sun, 17 Apr 2011 09:30:02 +0000
Resent-Message-ID: <handler.6986.B6986.13030325447419 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 6986
X-GNU-PR-Package: coreutils
X-GNU-PR-Keywords: patch
To: 6986 <at> debbugs.gnu.org
Received: via spool by 6986-submit <at> debbugs.gnu.org id=B6986.13030325447419
          (code B ref 6986); Sun, 17 Apr 2011 09:30:02 +0000
Received: (at 6986) by debbugs.gnu.org; 17 Apr 2011 09:29:04 +0000
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1QBOHv-0001vc-P1
	for submit <at> debbugs.gnu.org; Sun, 17 Apr 2011 05:29:03 -0400
Received: from mx.meyering.net ([82.230.74.64])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jim@HIDDEN>) id 1QBOHu-0001v9-64
	for 6986 <at> debbugs.gnu.org; Sun, 17 Apr 2011 05:29:02 -0400
Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000)
	id 947E160110; Sun, 17 Apr 2011 11:28:56 +0200 (CEST)
From: Jim Meyering <jim@HIDDEN>
In-Reply-To: <20100906213322.0e40a821@HIDDEN> (Dieter Plaetinck's
	message of "Mon, 6 Sep 2010 21:33:22 +0200")
References: <20100905131342.470022a6@HIDDEN>
	<87hbi2vigf.fsf@HIDDEN> <20100906213322.0e40a821@HIDDEN>
Date: Sun, 17 Apr 2011 11:28:56 +0200
Message-ID: <8762qdb50n.fsf@HIDDEN>
Lines: 15
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -5.9 (-----)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -5.9 (-----)

tags 6986 wishlist notabug
thanks

Dieter Plaetinck wrote:
...
> I know some shells provide the 'test' features as a built-in,
> that's fine.  But they should mimic the features test has.
> It makes the shell implementation dependent on test, not the
> other way around.  If this feature is considered useful for test, and
> gets merged into test, shells will follow soon enough.
>
> But anyway, your call :)
> At least thanks for the timely feedback and have a nice day.

Reclassifying this as "wishlist" (i.e., not a bug).

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 17 Apr 2011 11:26:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 17 07:26:40 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1QBQ7k-00068J-HQ
	for submit <at> debbugs.gnu.org; Sun, 17 Apr 2011 07:26:40 -0400
Received: from mx.meyering.net ([82.230.74.64])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jim@HIDDEN>) id 1QBQ7j-000687-7Z
	for control <at> debbugs.gnu.org; Sun, 17 Apr 2011 07:26:39 -0400
Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000)
	id 9BB4D6012A; Sun, 17 Apr 2011 13:26:33 +0200 (CEST)
From: Jim Meyering <jim@HIDDEN>
To: control <at> debbugs.gnu.org
Subject: Re: bug#6986: [PATCH] test: add check to determine whether files are
	on the same device
In-Reply-To: <8762qdb50n.fsf@HIDDEN> (Jim Meyering's message of
	"Sun, 17 Apr 2011 11:28:56 +0200")
References: <20100905131342.470022a6@HIDDEN>
	<87hbi2vigf.fsf@HIDDEN> <20100906213322.0e40a821@HIDDEN>
	<8762qdb50n.fsf@HIDDEN>
Date: Sun, 17 Apr 2011 13:26:33 +0200
Message-ID: <87ipud9l06.fsf@HIDDEN>
Lines: 2
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -5.9 (-----)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -5.9 (-----)

tags 6986 wishlist notabug
thanks

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 18 Apr 2011 07:32:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 18 03:32:26 2011
Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1QBiwc-000861-7K
	for submit <at> debbugs.gnu.org; Mon, 18 Apr 2011 03:32:26 -0400
Received: from mx.meyering.net ([82.230.74.64])
	by debbugs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jim@HIDDEN>) id 1QBiwY-00085j-Tf
	for control <at> debbugs.gnu.org; Mon, 18 Apr 2011 03:32:25 -0400
Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000)
	id D92D260318; Mon, 18 Apr 2011 09:32:15 +0200 (CEST)
From: Jim Meyering <jim@HIDDEN>
To: control <at> debbugs.gnu.org
Subject: 
Date: Mon, 18 Apr 2011 09:32:13 +0200
Message-ID: <87r590816q.fsf@HIDDEN>
Lines: 1
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -3.6 (---)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.11
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/pipermail/debbugs-submit>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
	<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Sender: debbugs-submit-bounces <at> debbugs.gnu.org
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
X-Spam-Score: -2.4 (--)

severity 6986 wishlist

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.