GNU bug report logs - #69921
[PATCH] eval-string: Fix setting port column

Previous Next

Package: guile;

Reported by: Jonas Hahnfeld <hahnjo <at> hahnjo.de>

Date: Wed, 20 Mar 2024 20:14:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

To reply to this bug, email your comments to 69921 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-guile <at> gnu.org:
bug#69921; Package guile. (Wed, 20 Mar 2024 20:14:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Jonas Hahnfeld <hahnjo <at> hahnjo.de>:
New bug report received and forwarded. Copy sent to bug-guile <at> gnu.org. (Wed, 20 Mar 2024 20:14:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonas Hahnfeld <hahnjo <at> hahnjo.de>
To: Nikita Domnitskii <nikita <at> domnitskii.me>, guile-devel <at> gnu.org
Cc: bug-guile <at> gnu.org
Subject: Re: [PATCH] eval-string: Fix setting port column
Date: Wed, 20 Mar 2024 21:12:52 +0100

[Message part 1 (text/plain, inline)]
On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote:
> ---
>  module/ice-9/eval-string.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
> index ea0f17777..9cac03632 100644
> --- a/module/ice-9/eval-string.scm
> +++ b/module/ice-9/eval-string.scm
> @@ -81,7 +81,7 @@
>            (if line
>                (set-port-line! port line))
>            (if column
> -              (set-port-column! port line))
> +              (set-port-column! port column))
>  
>            (if (or compile? (not (language-evaluator lang)))
>                ((load-thunk-from-memory
> 
> 

LGTM (wrong since 2011, it seems), but needs somebody with commit
access to push.

[signature.asc (application/pgp-signature, inline)]
Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Mon, 06 May 2024 09:40:01 GMT) Full text and rfc822 format available.
Notification sent to Jonas Hahnfeld <hahnjo <at> hahnjo.de>:
bug acknowledged by developer. (Mon, 06 May 2024 09:40:02 GMT) Full text and rfc822 format available.

Message #10 received at 69921-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jonas Hahnfeld <hahnjo <at> hahnjo.de>
Cc: 69921-done <at> debbugs.gnu.org, Nikita Domnitskii <nikita <at> domnitskii.me>,
 guile-devel <at> gnu.org
Subject: Re: bug#69921: [PATCH] eval-string: Fix setting port column
Date: Mon, 06 May 2024 11:38:35 +0200

Jonas Hahnfeld <hahnjo <at> hahnjo.de> skribis:

> On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote:
>> ---
>>  module/ice-9/eval-string.scm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
>> index ea0f17777..9cac03632 100644
>> --- a/module/ice-9/eval-string.scm
>> +++ b/module/ice-9/eval-string.scm
>> @@ -81,7 +81,7 @@
>>            (if line
>>                (set-port-line! port line))
>>            (if column
>> -              (set-port-column! port line))
>> +              (set-port-column! port column))
>>  
>>            (if (or compile? (not (language-evaluator lang)))
>>                ((load-thunk-from-memory
>> 
>> 
>
> LGTM (wrong since 2011, it seems), but needs somebody with commit
> access to push.

This was pushed as 025bb024ae4b586dc721e3d2e3471fbea5f8cc81.

Closing!

Ludo’.
This bug report was last modified today.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.