X-Loop: help-debbugs@HIDDEN
Subject: bug#70023: [PATCH] Add typescript-ts-mode indentation for interface bodies
Resent-From: Noah Peart <noah.v.peart@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 27 Mar 2024 06:21:02 +0000
Resent-Message-ID: <handler.70023.B.171152044614800 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 70023
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: 70023 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.171152044614800
(code B ref -1); Wed, 27 Mar 2024 06:21:02 +0000
Received: (at submit) by debbugs.gnu.org; 27 Mar 2024 06:20:46 +0000
Received: from localhost ([127.0.0.1]:35590 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rpMeS-0003qc-Rk
for submit <at> debbugs.gnu.org; Wed, 27 Mar 2024 02:20:46 -0400
Received: from lists.gnu.org ([2001:470:142::17]:53586)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <noah.v.peart@HIDDEN>) id 1rpMeN-0003qA-I2
for submit <at> debbugs.gnu.org; Wed, 27 Mar 2024 02:20:44 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>)
id 1rpMeH-0005tV-Ib
for bug-gnu-emacs@HIDDEN; Wed, 27 Mar 2024 02:20:34 -0400
Received: from mail-oa1-x2c.google.com ([2001:4860:4864:20::2c])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>)
id 1rpMeE-000835-Mk
for bug-gnu-emacs@HIDDEN; Wed, 27 Mar 2024 02:20:33 -0400
Received: by mail-oa1-x2c.google.com with SMTP id
586e51a60fabf-2220a389390so254472fac.0
for <bug-gnu-emacs@HIDDEN>; Tue, 26 Mar 2024 23:20:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1711520429; x=1712125229; darn=gnu.org;
h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
:date:message-id:reply-to;
bh=5vqFUZedQudXBf27rQBIPKoKmxY74/ALu+K0THPIvcg=;
b=Ri4zc3JrzZi8zKdwxq0rkNizOuZ7JlZM5swFO/PcJ8FbxYHoavpzZx5igCnbz9TVXv
8EriXiniQXSO2rZCWzdOzcRdH6tq6YC7zNwudzhNHBz6xRgz4EQzUMW7q/tK2dvEpNIC
2/RoqIu2aTFwNPkpfakQCi+CYrMO3AKVQo9O2jpw/kH6iOhVlnmvJebsiZjaBUNaoThw
NdAKMaWaBKmMwtx4daAZwu+1+yVRji4rhMK9p8OIUCX/b04hH24YRWfvS01cszPOO54o
hNycUJozILQJU9nTrHeEPG6AwWTyHTY32hTbinHROGWqDS76AmWp7MjLwPUNMvUY1Gpl
WzyA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1711520429; x=1712125229;
h=to:subject:message-id:date:from:mime-version:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=5vqFUZedQudXBf27rQBIPKoKmxY74/ALu+K0THPIvcg=;
b=hOBm3VXjFtj8Nt+18geahspf0iYcJ6MzeonsZVGqPJJYr48WErwc6GMq+shOML5S4j
KHpULTvKY7cyJlLskZVhM9IyF4rcwWgfCAY+83XAI6pieisBAZv8DLhAckUVgfS8dgtW
6ZBgKuyIL9oxCow8wB5Ue4qI3MXzV1E+kTNT9PYXJ9P96t/FGA0afNP9tk484A6z1s+0
jxelw4wyo8iwZN3vMitzyraEEwSwLHN317ORK1UW8uTcA7ZVoIHJocx+mFNN5Oy94z8S
TDzGDjQCgU4Zv4B1sH4Nqr4PKtlCzUE0T8cei272VMaCprT7g3YH9w3JznH8YvG0cse5
Dq3w==
X-Gm-Message-State: AOJu0YxvavN9FUCJCqnK/ybH5kZTXq+L9kptNfXN6iknzZPO3jyFWBdx
SiyGZOZU3uIyIjHltFwt48Vhprr65X3qnUXPHbOEBqjRs4Ah3QOla40pidspH5tMWfRvl9sRV9E
LD8b8JZ6PxXex0dDKHNbmPag7ckSP+wGNMSJhuKP7w10=
X-Google-Smtp-Source: AGHT+IGWuGBoDo+Bmz2Cm4aVhL2G4j45jIKON893CuS376CpMfPdMHn5uDP0gsC0QMARwYaqNsmbZvhqfrUEz9bjKvk=
X-Received: by 2002:a05:6870:a40c:b0:229:ff08:398e with SMTP id
m12-20020a056870a40c00b00229ff08398emr1662943oal.21.1711520429097; Tue, 26
Mar 2024 23:20:29 -0700 (PDT)
MIME-Version: 1.0
From: Noah Peart <noah.v.peart@HIDDEN>
Date: Tue, 26 Mar 2024 23:20:18 -0700
Message-ID: <CAPVBTSfqhXbgGGa4M55DH1FL7ne0Yorvj+KhD03uV9=M53u5qg@HIDDEN>
Content-Type: multipart/mixed; boundary="00000000000033e47a06149e6794"
Received-SPF: pass client-ip=2001:4860:4864:20::2c;
envelope-from=noah.v.peart@HIDDEN; helo=mail-oa1-x2c.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--00000000000033e47a06149e6794
Content-Type: multipart/alternative; boundary="00000000000033e47906149e6792"
--00000000000033e47906149e6792
Content-Type: text/plain; charset="UTF-8"
Tags: patch
Adds missing indentation for typescript interfaces.
Currently, there is no indentation for property signatures in typescript
interfaces.
To reproduce, call `M-x (my-test-typescript-indent)`
(defun my-test-typescript-indent ()
(interactive)
(typescript-ts-mode)
(setq-local typescript-ts-mode-indent-offset 4)
(indent-region (point-min) (point-max)))
in buffer with the following typescript code:
interface Foo {
foo: string; // no matching indent rule
bar?: boolean; // no matching indent rule
}
In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2024-03-24 built on noah-X580VD
Repository revision: c5de73a95a6ecefe46fe1ac07da8e83032be7f5b
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.4 LTS
Configured using:
'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'
--00000000000033e47906149e6792
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Tags: patch<br><br><br>Adds missing indentation for typesc=
ript interfaces.<br><br>Currently, there is no indentation for property sig=
natures in typescript<br>interfaces.<br><br>To reproduce, call `M-x (my-tes=
t-typescript-indent)`<br><br>=C2=A0 =C2=A0 (defun my-test-typescript-indent=
()<br>=C2=A0 =C2=A0 =C2=A0 (interactive)<br>=C2=A0 =C2=A0 =C2=A0 (typescri=
pt-ts-mode)<br>=C2=A0 =C2=A0 =C2=A0 (setq-local typescript-ts-mode-indent-o=
ffset 4)<br>=C2=A0 =C2=A0 =C2=A0 (indent-region (point-min) (point-max)))<b=
r><br><br>in buffer with the following typescript code:<br><br>=C2=A0 =C2=
=A0 interface Foo {<br>=C2=A0 =C2=A0 foo: string; =C2=A0 // no matching ind=
ent rule<br>=C2=A0 =C2=A0 bar?: boolean; // no matching indent rule<br>=C2=
=A0 =C2=A0 }<br><br><br>In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu,=
GTK+ Version<br>3.24.33, cairo version 1.16.0) of 2024-03-24 built on noah=
-X580VD<br>Repository revision: c5de73a95a6ecefe46fe1ac07da8e83032be7f5b<br=
>Repository branch: master<br>Windowing system distributor 'The X.Org F=
oundation', version 11.0.12101004<br>System Description: Ubuntu 22.04.4=
LTS<br><br>Configured using:<br>=C2=A0'configure --prefix=3D/usr/local=
--with-modules --with-tree-sitter<br>--with-threads --with-x-toolkit=3Dgtk=
3 --with-xwidgets --with-gnutls<br>--with-json --with-mailutils --with-jpeg=
--with-png --with-rsvg<br>--with-tiff --with-xml2 --with-xpm --with-imagem=
agick CC=3Dgcc-12<br>CXX=3Dgcc-12'<br></div>
--00000000000033e47906149e6792--
--00000000000033e47a06149e6794
Content-Type: text/x-patch; charset="US-ASCII";
name="0001-Add-typescript-ts-mode-indentation-for-interface-bod.patch"
Content-Disposition: attachment;
filename="0001-Add-typescript-ts-mode-indentation-for-interface-bod.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lu9f1ycw0>
X-Attachment-Id: f_lu9f1ycw0
RnJvbSBhMzlmMjM2NDk3Mzk5ODMxOGI1NmQ5MWNiMjgwMWEwNmIyMzdiODhhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FoIFBlYXJ0IDxub2FoLnYucGVhcnRAZ21haWwuY29tPgpE
YXRlOiBUdWUsIDI2IE1hciAyMDI0IDIyOjQ0OjQ4IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gQWRk
IHR5cGVzY3JpcHQtdHMtbW9kZSBpbmRlbnRhdGlvbiBmb3IgaW50ZXJmYWNlIGJvZGllcwoKKiBs
aXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwKKHR5cGVzY3JpcHQtdHMtbW9kZS0t
aW5kZW50LXJ1bGVzKTogQWRkIGluZGVudGF0aW9uIHJ1bGUgZm9yCmludGVyZmFjZSBib2RpZXMu
Ci0tLQogbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsIHwgMSArCiAxIGZpbGUg
Y2hhbmdlZCwgMSBpbnNlcnRpb24oKykKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy90eXBl
c2NyaXB0LXRzLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwK
aW5kZXggZWE0ZjY0MTdjNWEuLmFiMWQ3NmFiMjBlIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rl
cy90eXBlc2NyaXB0LXRzLW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10
cy1tb2RlLmVsCkBAIC0xMjQsNiArMTI0LDcgQEAgdHlwZXNjcmlwdC10cy1tb2RlLS1pbmRlbnQt
cnVsZXMKICAgICAgKChwYXJlbnQtaXMgIm9iamVjdF90eXBlIikgcGFyZW50LWJvbCB0eXBlc2Ny
aXB0LXRzLW1vZGUtaW5kZW50LW9mZnNldCkKICAgICAgKChwYXJlbnQtaXMgImVudW1fYm9keSIp
IHBhcmVudC1ib2wgdHlwZXNjcmlwdC10cy1tb2RlLWluZGVudC1vZmZzZXQpCiAgICAgICgocGFy
ZW50LWlzICJjbGFzc19ib2R5IikgcGFyZW50LWJvbCB0eXBlc2NyaXB0LXRzLW1vZGUtaW5kZW50
LW9mZnNldCkKKyAgICAgKChwYXJlbnQtaXMgImludGVyZmFjZV9ib2R5IikgcGFyZW50LWJvbCB0
eXBlc2NyaXB0LXRzLW1vZGUtaW5kZW50LW9mZnNldCkKICAgICAgKChwYXJlbnQtaXMgImFycm93
X2Z1bmN0aW9uIikgcGFyZW50LWJvbCB0eXBlc2NyaXB0LXRzLW1vZGUtaW5kZW50LW9mZnNldCkK
ICAgICAgKChwYXJlbnQtaXMgInBhcmVudGhlc2l6ZWRfZXhwcmVzc2lvbiIpIHBhcmVudC1ib2wg
dHlwZXNjcmlwdC10cy1tb2RlLWluZGVudC1vZmZzZXQpCiAgICAgICgocGFyZW50LWlzICJiaW5h
cnlfZXhwcmVzc2lvbiIpIHBhcmVudC1ib2wgdHlwZXNjcmlwdC10cy1tb2RlLWluZGVudC1vZmZz
ZXQpCi0tIAoyLjM0LjEKCg==
--00000000000033e47a06149e6794--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Noah Peart <noah.v.peart@HIDDEN> Subject: bug#70023: Acknowledgement ([PATCH] Add typescript-ts-mode indentation for interface bodies) Message-ID: <handler.70023.B.171152044614800.ack <at> debbugs.gnu.org> References: <CAPVBTSfqhXbgGGa4M55DH1FL7ne0Yorvj+KhD03uV9=M53u5qg@HIDDEN> X-Gnu-PR-Message: ack 70023 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 70023 <at> debbugs.gnu.org Date: Wed, 27 Mar 2024 06:21:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 70023 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 70023: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70023 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: bug#70023: [PATCH] Add typescript-ts-mode indentation for interface bodies
Resent-From: Theodor Thornhill <theo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 28 Mar 2024 13:12:01 +0000
Resent-Message-ID: <handler.70023.B70023.171163151030359 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70023
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Noah Peart <noah.v.peart@HIDDEN>
Cc: 70023 <at> debbugs.gnu.org
Received: via spool by 70023-submit <at> debbugs.gnu.org id=B70023.171163151030359
(code B ref 70023); Thu, 28 Mar 2024 13:12:01 +0000
Received: (at 70023) by debbugs.gnu.org; 28 Mar 2024 13:11:50 +0000
Received: from localhost ([127.0.0.1]:39566 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rppXo-0007tZ-Ig
for submit <at> debbugs.gnu.org; Thu, 28 Mar 2024 09:11:50 -0400
Received: from out-171.mta0.migadu.com ([91.218.175.171]:27176)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <theo@HIDDEN>) id 1rppXk-0007sz-CR
for 70023 <at> debbugs.gnu.org; Thu, 28 Mar 2024 09:11:46 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no;
s=key1; t=1711631497;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=FDs5eh/LLli7t0hZar44X6AfE9HqkvdVwkqrOaiiRs4=;
b=RlpDcsuNWZcwwKzWTMHW3EBHyYRAM11I6rxha+ggPFGRI4m955HZbjXWza31ibEHlygoSF
t4AQpcapKaqozvH7g8GBDbYgO3jeP9ZzsHn//iGlVOzS4BJFHn1wAcsu9RAaJtBuOz+1QQ
1O7eeKWUOWiVXiNUQW1tXCRnQlbo8xKIOfL6cawkFnignzk3QWD7EuCOiObMaMVYXInn4r
rO9H7VydO4Uc35IURgo1HPHbyQNNS1jCz+ao/Wj1xxRQVkMSTi2ovUGIESLOIG0sgkkcpS
NO8m3L9XKybDCH04CdCh7TtQC1BCiVP9M9VikaYGAZYLDbF6s96RCuTbQNTa1w==
From: Theodor Thornhill <theo@HIDDEN>
In-Reply-To: <CAPVBTSfqhXbgGGa4M55DH1FL7ne0Yorvj+KhD03uV9=M53u5qg@HIDDEN>
(Noah Peart's message of "Tue, 26 Mar 2024 23:20:18 -0700")
References: <CAPVBTSfqhXbgGGa4M55DH1FL7ne0Yorvj+KhD03uV9=M53u5qg@HIDDEN>
Date: Thu, 28 Mar 2024 14:11:33 +0100
Message-ID: <87sf0awlfe.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Noah Peart <noah.v.peart@HIDDEN> writes:
> Tags: patch
>
> Adds missing indentation for typescript interfaces.
>
> Currently, there is no indentation for property signatures in typescript
> interfaces.
>
> To reproduce, call `M-x (my-test-typescript-indent)`
>
> (defun my-test-typescript-indent ()
> (interactive)
> (typescript-ts-mode)
> (setq-local typescript-ts-mode-indent-offset 4)
> (indent-region (point-min) (point-max)))
>
> in buffer with the following typescript code:
>
> interface Foo {
> foo: string; // no matching indent rule
> bar?: boolean; // no matching indent rule
> }
Thanks - This looks good to me. Have you contributed to emacs earlier? I
think this could go in regardless as it is a trivial addition, or what,
Eli?
I'll install it on emacs-29 later today if noone cries out :-)
Theo
X-Loop: help-debbugs@HIDDEN
Subject: bug#70023: [PATCH] Add typescript-ts-mode indentation for interface bodies
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 28 Mar 2024 14:33:01 +0000
Resent-Message-ID: <handler.70023.B70023.171163635923670 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70023
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Theodor Thornhill <theo@HIDDEN>
Cc: noah.v.peart@HIDDEN, 70023 <at> debbugs.gnu.org
Received: via spool by 70023-submit <at> debbugs.gnu.org id=B70023.171163635923670
(code B ref 70023); Thu, 28 Mar 2024 14:33:01 +0000
Received: (at 70023) by debbugs.gnu.org; 28 Mar 2024 14:32:39 +0000
Received: from localhost ([127.0.0.1]:40896 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rpqnz-00069S-Rf
for submit <at> debbugs.gnu.org; Thu, 28 Mar 2024 10:32:39 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:52874)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1rpqnu-00068M-RG
for 70023 <at> debbugs.gnu.org; Thu, 28 Mar 2024 10:32:34 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1rpqno-0001Ty-HD; Thu, 28 Mar 2024 10:32:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=yoS20+VBWYhzNuto8OvwpoAh2UGgsVtl7vXkQKzliUI=; b=UwdLGJgwVOxJ
u/xbcUsXwNwNPw+2WCTbijrVKClYuBUb4oa23qa7HliBoLhCED23KJWHCX+dsbZQOApzqe1y5oJHj
CQlptlzvpy99di8OUdpH3o7k5XLQClsnXkbqxE5ut3ay/BV3v0/4QmlQQ/GvCwiMhH89nmIStGhU0
muPLFEI8v00a/Qp4Nxr0vIFDaEzrlzgGuREWN7urzcHqKu2uIiYJ91nAmmi+OBN/DzFSsRdkTK0SP
8rM73VK/NYdO5NRxMQUm3R2dDZVD2xvIluPtZEeYFDhUtPwhozD4d8Z7d0dTLMo3AMKfbFKVpywCd
Ht+vINgxwt1I7SCd7ItGWQ==;
Date: Thu, 28 Mar 2024 16:31:51 +0200
Message-Id: <86le62fmw8.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87sf0awlfe.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN)
References: <CAPVBTSfqhXbgGGa4M55DH1FL7ne0Yorvj+KhD03uV9=M53u5qg@HIDDEN>
<87sf0awlfe.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Cc: 70023 <at> debbugs.gnu.org
> Date: Thu, 28 Mar 2024 14:11:33 +0100
> From: Theodor Thornhill via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>
> Thanks - This looks good to me. Have you contributed to emacs earlier? I
> think this could go in regardless as it is a trivial addition, or what,
> Eli?
Noah has copyright assignment on file, so we can accept his
contributions without limitations.
X-Loop: help-debbugs@HIDDEN
Subject: bug#70023: [PATCH] Add typescript-ts-mode indentation for interface bodies
Resent-From: Theodor Thornhill <theo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 28 Mar 2024 18:11:02 +0000
Resent-Message-ID: <handler.70023.B70023.17116494568480 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70023
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Noah Peart <noah.v.peart@HIDDEN>
Cc: 70023 <at> debbugs.gnu.org
Received: via spool by 70023-submit <at> debbugs.gnu.org id=B70023.17116494568480
(code B ref 70023); Thu, 28 Mar 2024 18:11:02 +0000
Received: (at 70023) by debbugs.gnu.org; 28 Mar 2024 18:10:56 +0000
Received: from localhost ([127.0.0.1]:41113 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rpuDH-0002Ch-MJ
for submit <at> debbugs.gnu.org; Thu, 28 Mar 2024 14:10:55 -0400
Received: from out-172.mta0.migadu.com ([91.218.175.172]:52833)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <theo@HIDDEN>) id 1rpuDE-0002CQ-Ni
for 70023 <at> debbugs.gnu.org; Thu, 28 Mar 2024 14:10:54 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no;
s=key1; t=1711649445;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=0xas1BkgrJ1ibz4+l9tkuFxoSxfbDgNJR9fqItYjUko=;
b=RkrgxiSh1pnm2nEM/V6keOWIah/VpvWejRAr6qJIOO0WiNXF36gJjZ0Bw0xKxzlDaRc0Pc
hagIH6PdghhIpZKXPhoZkZ0clQy/LSifOmTQrtdMNMfnZ5bZRfLHR12VR3NLSDliE6oypJ
D99kz8Qak2GQ6sM5OTddUK3RHlLmZ1uNej75hNWLMJ5WANh358B9g3AWZSqi5j2I6s3daw
KzYR3da6/oiLtY9ir/bBZRsgWHgYtB5yDKS+ZgYiB31LoVL2SafZpgkKVCyQeAz4ovenHL
GiXsxX+BK+C5SpJaqKcCyEBJ/GUTZM7ETUQxFRnbFU/2SH06xTOFMAVR6uVyIg==
From: Theodor Thornhill <theo@HIDDEN>
In-Reply-To: <CAPVBTSfqhXbgGGa4M55DH1FL7ne0Yorvj+KhD03uV9=M53u5qg@HIDDEN>
(Noah Peart's message of "Tue, 26 Mar 2024 23:20:18 -0700")
References: <CAPVBTSfqhXbgGGa4M55DH1FL7ne0Yorvj+KhD03uV9=M53u5qg@HIDDEN>
Date: Thu, 28 Mar 2024 19:10:41 +0100
Message-ID: <87o7ayw7ku.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Noah Peart <noah.v.peart@HIDDEN> writes:
> Tags: patch
>
> Adds missing indentation for typescript interfaces.
>
> Currently, there is no indentation for property signatures in typescript
> interfaces.
>
> To reproduce, call `M-x (my-test-typescript-indent)`
>
> (defun my-test-typescript-indent ()
> (interactive)
> (typescript-ts-mode)
> (setq-local typescript-ts-mode-indent-offset 4)
> (indent-region (point-min) (point-max)))
>
[...]
Pushed in bcf6dd6e266222a293e359430afdf3a2dc18369c. I also added a test
confirming the behavior.
As a small aside, this node type was added very recently. Until now we
had a rule for it in 'object'
Thanks!
Theo
Received: (at control) by debbugs.gnu.org; 28 Mar 2024 18:13:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Mar 28 14:13:18 2024 Received: from localhost ([127.0.0.1]:41119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rpuFa-0002In-4y for submit <at> debbugs.gnu.org; Thu, 28 Mar 2024 14:13:18 -0400 Received: from out-180.mta0.migadu.com ([91.218.175.180]:58478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <theo@HIDDEN>) id 1rpuFY-0002Ib-Kx for control <at> debbugs.gnu.org; Thu, 28 Mar 2024 14:13:17 -0400 Date: Thu, 28 Mar 2024 19:13:06 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1711649590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc; bh=FddqomWQivA4SOs8a4+qYnt6fM0FHgCtoZvADQ+yBwM=; b=FFjGXbi6SYtuBXbE1Y74sKEbGlLXOxpBUKmg/zEvP42qPu3eDbxfAYHI6mrtdKoI6vu9b0 eN7hJfNEJP5rAdvFefYMQDcnj3hZPrLMnNKx2AvQclOsUijboMP2rbNp2ptGyG1h5CSl5w V4ATPW2aaJUxYqBYtc7rmmiCicUU6Ivjvbfkrdi4l8LQVAw4u93praEtTxKRPaX6F3KFC/ UOfwlDDxSXDAo+Xc1xVkgdF1Hq0j3ExMJiq3jvmkm/ey/8tdmsmbTpQ2aNNVsLQ/dkOlGk fDHawfw/rqmKnhwYWOkZIuDxlyeUFbsplD6Tve8RlDPoXaeMeVSTYcGjr4FMPQ== Message-ID: <ff07e64597465accc7feed405d8b21ef.theo@HIDDEN> To: control <at> debbugs.gnu.org X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and include these headers. From: Theodor Thornhill <theo@HIDDEN> Subject: control message for bug #70023 X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) fixed 70023 29.3 quit
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Stefan Kangas <stefankangas@HIDDEN>
Subject: bug#70023: closed ([PATCH] Add typescript-ts-mode indentation for
interface bodies)
CC: tracker <at> debbugs.gnu.org
Message-ID: <handler.70023.D70023.171972701029345.ackdone <at> debbugs.gnu.org>
References: <CADwFkmk8ZdF5a=_6bOemwemhKCktPeyHitZB+Z58U1N_f7ZnHQ@HIDDEN>
<CAPVBTSfqhXbgGGa4M55DH1FL7ne0Yorvj+KhD03uV9=M53u5qg@HIDDEN>
X-Gnu-PR-Message: closed 70023
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Date: Sun, 30 Jun 2024 05:57:02 +0000
Content-Type: multipart/mixed; boundary="----------=_1719727022-29376-0"
This is a multi-part message in MIME format...
------------=_1719727022-29376-0
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf-8
Your message dated Sat, 29 Jun 2024 22:55:42 -0700
with message-id <CADwFkmk8ZdF5a=3D_6bOemwemhKCktPeyHitZB+Z58U1N_f7ZnHQ@mail=
.gmail.com>
and subject line Re: bug#70023: [PATCH] Add typescript-ts-mode indentation =
for interface bodies
has caused the debbugs.gnu.org bug report #70023,
regarding [PATCH] Add typescript-ts-mode indentation for interface bodies
to be marked as done.
(If you believe you have received this mail in error, please contact
help-debbugs@HIDDEN)
--=20
70023: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70023
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems
------------=_1719727022-29376-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Received: (at submit) by debbugs.gnu.org; 27 Mar 2024 06:20:46 +0000
Received: from localhost ([127.0.0.1]:35590 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rpMeS-0003qc-Rk
for submit <at> debbugs.gnu.org; Wed, 27 Mar 2024 02:20:46 -0400
Received: from lists.gnu.org ([2001:470:142::17]:53586)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <noah.v.peart@HIDDEN>) id 1rpMeN-0003qA-I2
for submit <at> debbugs.gnu.org; Wed, 27 Mar 2024 02:20:44 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>)
id 1rpMeH-0005tV-Ib
for bug-gnu-emacs@HIDDEN; Wed, 27 Mar 2024 02:20:34 -0400
Received: from mail-oa1-x2c.google.com ([2001:4860:4864:20::2c])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>)
id 1rpMeE-000835-Mk
for bug-gnu-emacs@HIDDEN; Wed, 27 Mar 2024 02:20:33 -0400
Received: by mail-oa1-x2c.google.com with SMTP id
586e51a60fabf-2220a389390so254472fac.0
for <bug-gnu-emacs@HIDDEN>; Tue, 26 Mar 2024 23:20:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1711520429; x=1712125229; darn=gnu.org;
h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
:date:message-id:reply-to;
bh=5vqFUZedQudXBf27rQBIPKoKmxY74/ALu+K0THPIvcg=;
b=Ri4zc3JrzZi8zKdwxq0rkNizOuZ7JlZM5swFO/PcJ8FbxYHoavpzZx5igCnbz9TVXv
8EriXiniQXSO2rZCWzdOzcRdH6tq6YC7zNwudzhNHBz6xRgz4EQzUMW7q/tK2dvEpNIC
2/RoqIu2aTFwNPkpfakQCi+CYrMO3AKVQo9O2jpw/kH6iOhVlnmvJebsiZjaBUNaoThw
NdAKMaWaBKmMwtx4daAZwu+1+yVRji4rhMK9p8OIUCX/b04hH24YRWfvS01cszPOO54o
hNycUJozILQJU9nTrHeEPG6AwWTyHTY32hTbinHROGWqDS76AmWp7MjLwPUNMvUY1Gpl
WzyA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1711520429; x=1712125229;
h=to:subject:message-id:date:from:mime-version:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=5vqFUZedQudXBf27rQBIPKoKmxY74/ALu+K0THPIvcg=;
b=hOBm3VXjFtj8Nt+18geahspf0iYcJ6MzeonsZVGqPJJYr48WErwc6GMq+shOML5S4j
KHpULTvKY7cyJlLskZVhM9IyF4rcwWgfCAY+83XAI6pieisBAZv8DLhAckUVgfS8dgtW
6ZBgKuyIL9oxCow8wB5Ue4qI3MXzV1E+kTNT9PYXJ9P96t/FGA0afNP9tk484A6z1s+0
jxelw4wyo8iwZN3vMitzyraEEwSwLHN317ORK1UW8uTcA7ZVoIHJocx+mFNN5Oy94z8S
TDzGDjQCgU4Zv4B1sH4Nqr4PKtlCzUE0T8cei272VMaCprT7g3YH9w3JznH8YvG0cse5
Dq3w==
X-Gm-Message-State: AOJu0YxvavN9FUCJCqnK/ybH5kZTXq+L9kptNfXN6iknzZPO3jyFWBdx
SiyGZOZU3uIyIjHltFwt48Vhprr65X3qnUXPHbOEBqjRs4Ah3QOla40pidspH5tMWfRvl9sRV9E
LD8b8JZ6PxXex0dDKHNbmPag7ckSP+wGNMSJhuKP7w10=
X-Google-Smtp-Source: AGHT+IGWuGBoDo+Bmz2Cm4aVhL2G4j45jIKON893CuS376CpMfPdMHn5uDP0gsC0QMARwYaqNsmbZvhqfrUEz9bjKvk=
X-Received: by 2002:a05:6870:a40c:b0:229:ff08:398e with SMTP id
m12-20020a056870a40c00b00229ff08398emr1662943oal.21.1711520429097; Tue, 26
Mar 2024 23:20:29 -0700 (PDT)
MIME-Version: 1.0
From: Noah Peart <noah.v.peart@HIDDEN>
Date: Tue, 26 Mar 2024 23:20:18 -0700
Message-ID: <CAPVBTSfqhXbgGGa4M55DH1FL7ne0Yorvj+KhD03uV9=M53u5qg@HIDDEN>
Subject: [PATCH] Add typescript-ts-mode indentation for interface bodies
To: bug-gnu-emacs@HIDDEN
Content-Type: multipart/mixed; boundary="00000000000033e47a06149e6794"
Received-SPF: pass client-ip=2001:4860:4864:20::2c;
envelope-from=noah.v.peart@HIDDEN; helo=mail-oa1-x2c.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--00000000000033e47a06149e6794
Content-Type: multipart/alternative; boundary="00000000000033e47906149e6792"
--00000000000033e47906149e6792
Content-Type: text/plain; charset="UTF-8"
Tags: patch
Adds missing indentation for typescript interfaces.
Currently, there is no indentation for property signatures in typescript
interfaces.
To reproduce, call `M-x (my-test-typescript-indent)`
(defun my-test-typescript-indent ()
(interactive)
(typescript-ts-mode)
(setq-local typescript-ts-mode-indent-offset 4)
(indent-region (point-min) (point-max)))
in buffer with the following typescript code:
interface Foo {
foo: string; // no matching indent rule
bar?: boolean; // no matching indent rule
}
In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2024-03-24 built on noah-X580VD
Repository revision: c5de73a95a6ecefe46fe1ac07da8e83032be7f5b
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.4 LTS
Configured using:
'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'
--00000000000033e47906149e6792
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Tags: patch<br><br><br>Adds missing indentation for typesc=
ript interfaces.<br><br>Currently, there is no indentation for property sig=
natures in typescript<br>interfaces.<br><br>To reproduce, call `M-x (my-tes=
t-typescript-indent)`<br><br>=C2=A0 =C2=A0 (defun my-test-typescript-indent=
()<br>=C2=A0 =C2=A0 =C2=A0 (interactive)<br>=C2=A0 =C2=A0 =C2=A0 (typescri=
pt-ts-mode)<br>=C2=A0 =C2=A0 =C2=A0 (setq-local typescript-ts-mode-indent-o=
ffset 4)<br>=C2=A0 =C2=A0 =C2=A0 (indent-region (point-min) (point-max)))<b=
r><br><br>in buffer with the following typescript code:<br><br>=C2=A0 =C2=
=A0 interface Foo {<br>=C2=A0 =C2=A0 foo: string; =C2=A0 // no matching ind=
ent rule<br>=C2=A0 =C2=A0 bar?: boolean; // no matching indent rule<br>=C2=
=A0 =C2=A0 }<br><br><br>In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu,=
GTK+ Version<br>3.24.33, cairo version 1.16.0) of 2024-03-24 built on noah=
-X580VD<br>Repository revision: c5de73a95a6ecefe46fe1ac07da8e83032be7f5b<br=
>Repository branch: master<br>Windowing system distributor 'The X.Org F=
oundation', version 11.0.12101004<br>System Description: Ubuntu 22.04.4=
LTS<br><br>Configured using:<br>=C2=A0'configure --prefix=3D/usr/local=
--with-modules --with-tree-sitter<br>--with-threads --with-x-toolkit=3Dgtk=
3 --with-xwidgets --with-gnutls<br>--with-json --with-mailutils --with-jpeg=
--with-png --with-rsvg<br>--with-tiff --with-xml2 --with-xpm --with-imagem=
agick CC=3Dgcc-12<br>CXX=3Dgcc-12'<br></div>
--00000000000033e47906149e6792--
--00000000000033e47a06149e6794
Content-Type: text/x-patch; charset="US-ASCII";
name="0001-Add-typescript-ts-mode-indentation-for-interface-bod.patch"
Content-Disposition: attachment;
filename="0001-Add-typescript-ts-mode-indentation-for-interface-bod.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lu9f1ycw0>
X-Attachment-Id: f_lu9f1ycw0
RnJvbSBhMzlmMjM2NDk3Mzk5ODMxOGI1NmQ5MWNiMjgwMWEwNmIyMzdiODhhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FoIFBlYXJ0IDxub2FoLnYucGVhcnRAZ21haWwuY29tPgpE
YXRlOiBUdWUsIDI2IE1hciAyMDI0IDIyOjQ0OjQ4IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gQWRk
IHR5cGVzY3JpcHQtdHMtbW9kZSBpbmRlbnRhdGlvbiBmb3IgaW50ZXJmYWNlIGJvZGllcwoKKiBs
aXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwKKHR5cGVzY3JpcHQtdHMtbW9kZS0t
aW5kZW50LXJ1bGVzKTogQWRkIGluZGVudGF0aW9uIHJ1bGUgZm9yCmludGVyZmFjZSBib2RpZXMu
Ci0tLQogbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsIHwgMSArCiAxIGZpbGUg
Y2hhbmdlZCwgMSBpbnNlcnRpb24oKykKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy90eXBl
c2NyaXB0LXRzLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwK
aW5kZXggZWE0ZjY0MTdjNWEuLmFiMWQ3NmFiMjBlIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rl
cy90eXBlc2NyaXB0LXRzLW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10
cy1tb2RlLmVsCkBAIC0xMjQsNiArMTI0LDcgQEAgdHlwZXNjcmlwdC10cy1tb2RlLS1pbmRlbnQt
cnVsZXMKICAgICAgKChwYXJlbnQtaXMgIm9iamVjdF90eXBlIikgcGFyZW50LWJvbCB0eXBlc2Ny
aXB0LXRzLW1vZGUtaW5kZW50LW9mZnNldCkKICAgICAgKChwYXJlbnQtaXMgImVudW1fYm9keSIp
IHBhcmVudC1ib2wgdHlwZXNjcmlwdC10cy1tb2RlLWluZGVudC1vZmZzZXQpCiAgICAgICgocGFy
ZW50LWlzICJjbGFzc19ib2R5IikgcGFyZW50LWJvbCB0eXBlc2NyaXB0LXRzLW1vZGUtaW5kZW50
LW9mZnNldCkKKyAgICAgKChwYXJlbnQtaXMgImludGVyZmFjZV9ib2R5IikgcGFyZW50LWJvbCB0
eXBlc2NyaXB0LXRzLW1vZGUtaW5kZW50LW9mZnNldCkKICAgICAgKChwYXJlbnQtaXMgImFycm93
X2Z1bmN0aW9uIikgcGFyZW50LWJvbCB0eXBlc2NyaXB0LXRzLW1vZGUtaW5kZW50LW9mZnNldCkK
ICAgICAgKChwYXJlbnQtaXMgInBhcmVudGhlc2l6ZWRfZXhwcmVzc2lvbiIpIHBhcmVudC1ib2wg
dHlwZXNjcmlwdC10cy1tb2RlLWluZGVudC1vZmZzZXQpCiAgICAgICgocGFyZW50LWlzICJiaW5h
cnlfZXhwcmVzc2lvbiIpIHBhcmVudC1ib2wgdHlwZXNjcmlwdC10cy1tb2RlLWluZGVudC1vZmZz
ZXQpCi0tIAoyLjM0LjEKCg==
--00000000000033e47a06149e6794--
------------=_1719727022-29376-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Received: (at 70023-done) by debbugs.gnu.org; 30 Jun 2024 05:56:50 +0000
Received: from localhost ([127.0.0.1]:54608 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sNnYQ-0007dD-Hj
for submit <at> debbugs.gnu.org; Sun, 30 Jun 2024 01:56:50 -0400
Received: from mail-lj1-f175.google.com ([209.85.208.175]:49443)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <stefankangas@HIDDEN>) id 1sNnYO-0007cx-S8
for 70023-done <at> debbugs.gnu.org; Sun, 30 Jun 2024 01:56:49 -0400
Received: by mail-lj1-f175.google.com with SMTP id
38308e7fff4ca-2ec408c6d94so19513871fa.3
for <70023-done <at> debbugs.gnu.org>; Sat, 29 Jun 2024 22:56:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1719726943; x=1720331743; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:from:to:cc:subject:date:message-id:reply-to;
bh=E+OIJtnUDP5KTZ2RetdCPDOi4Ggza7FUt0oQ8cgY4yE=;
b=iT6Io2n0Y8gZ5bovhQtFIi3lwQV8pepMst3vkq0a+OCcQb+HW4644efE631E+Qzlyd
JxETdRGkr91RvXenp65pA+TVOizjSUFtn45ep2D5s3tloJJsX5tpAaTKMKsM6XG9M8dS
uswxXQJdY2D19U6DuNh+d2ytDvtqmp1/iUb/Yp4S4bbrakUjQ8z7mKcUQ+D//o0Fx//1
BHj0R/9rpIXr2JcuDacNquBUDvf8QaMuPRwOPAEZ58T4YxE1LrmbRMB45+1PIunrODou
6gGt6XlLVQ4sKIPO6t14X9uyFEB7sNriU6+20hb3Sa0jJ5xodMqSbxpR5mGta5hQFMbq
Z5gw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1719726943; x=1720331743;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=E+OIJtnUDP5KTZ2RetdCPDOi4Ggza7FUt0oQ8cgY4yE=;
b=NU0ehszSAv1KEOLB305gSn8s8E+M+K5UjmB1sMqEOyYNZXBbRgCjDWDA3qz6vm/8fP
bgyGcLA7Y4kBUr2T+lkWSQmHRYPTlRbCgyUPqXsJnft2T8FywejLMq0x/lT8NYD0t4FB
RcFdgz1B1R7LSfYWTSSkM04eSr+UoofMBxHmH6JUSQmOOYoTxjalroBcqgxV720TNBPA
JpE0z+og/E89MSJopGVYzbRRN/0/5it87Ad1guw+6LkRf569CS+wLf9aL4DT0zicRYDd
RZufDk91uiWgbaYE0LfnZZey2QyfhRV7/saCHhC3Pl5AdEhM97ru+JgB/+tMdUeOhCyp
s8RA==
X-Forwarded-Encrypted: i=1;
AJvYcCU+DMrIUsXm+AxiIC2qZ3zjmFw8PwR/FNtcWK90PvE8TwSYS6dSErAGVcc2G+V3nYA4g29uuBimeDqqb1EoItvnOszytOcQx+m6PQ==
X-Gm-Message-State: AOJu0YyldSn1ZcfNUWvBcQXFTqJQjCib+UbCpz6As2X7m9s4QYFjUOAJ
7P+lN692Pi2THb7bhdmQJJ0e00nBojkqiRoLjoJT5QD+XSDdn2iA4XWJZJGqIvgRKVnYiwgyukx
u/zEaBa9zn9GFsj1hNw5lezEWbCY=
X-Google-Smtp-Source: AGHT+IFSjHSGTSDyyZzLWtJbayRjHTeTwVHJDPCDp+bQAJit0R+o/muOZe1KYJGLPbFoVkFE5QaNc3Er/6lvvhoh694=
X-Received: by 2002:a2e:86c8:0:b0:2ec:5469:9d64 with SMTP id
38308e7fff4ca-2ee5e6f271cmr15971701fa.32.1719726943100; Sat, 29 Jun 2024
22:55:43 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Sat, 29 Jun 2024 22:55:42 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87o7ayw7ku.fsf@HIDDEN> (Theodor Thornhill's message of
"Thu, 28 Mar 2024 19:10:41 +0100")
References: <CAPVBTSfqhXbgGGa4M55DH1FL7ne0Yorvj+KhD03uV9=M53u5qg@HIDDEN>
<87o7ayw7ku.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sat, 29 Jun 2024 22:55:42 -0700
Message-ID: <CADwFkmk8ZdF5a=_6bOemwemhKCktPeyHitZB+Z58U1N_f7ZnHQ@HIDDEN>
Subject: Re: bug#70023: [PATCH] Add typescript-ts-mode indentation for
interface bodies
To: Theodor Thornhill <theo@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 70023-done
Cc: Noah Peart <noah.v.peart@HIDDEN>, 70023-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Theodor Thornhill <theo@HIDDEN> writes:
> Noah Peart <noah.v.peart@HIDDEN> writes:
>
>> Tags: patch
>>
>> Adds missing indentation for typescript interfaces.
>>
>> Currently, there is no indentation for property signatures in typescript
>> interfaces.
>>
>> To reproduce, call `M-x (my-test-typescript-indent)`
>>
>> (defun my-test-typescript-indent ()
>> (interactive)
>> (typescript-ts-mode)
>> (setq-local typescript-ts-mode-indent-offset 4)
>> (indent-region (point-min) (point-max)))
>>
>
> [...]
>
> Pushed in bcf6dd6e266222a293e359430afdf3a2dc18369c. I also added a test
> confirming the behavior.
>
> As a small aside, this node type was added very recently. Until now we
> had a rule for it in 'object'
I'm therefore closing this bug report.
------------=_1719727022-29376-0--
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Noah Peart <noah.v.peart@HIDDEN>
Subject: bug#70023: closed (Re: bug#70023: [PATCH] Add typescript-ts-mode
indentation for interface bodies)
Message-ID: <handler.70023.D70023.171972701029345.notifdone <at> debbugs.gnu.org>
References: <CADwFkmk8ZdF5a=_6bOemwemhKCktPeyHitZB+Z58U1N_f7ZnHQ@HIDDEN>
<CAPVBTSfqhXbgGGa4M55DH1FL7ne0Yorvj+KhD03uV9=M53u5qg@HIDDEN>
X-Gnu-PR-Message: they-closed 70023
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 70023 <at> debbugs.gnu.org
Date: Sun, 30 Jun 2024 05:57:02 +0000
Content-Type: multipart/mixed; boundary="----------=_1719727022-29376-1"
This is a multi-part message in MIME format...
------------=_1719727022-29376-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Your bug report
#70023: [PATCH] Add typescript-ts-mode indentation for interface bodies
which was filed against the emacs package, has been closed.
The explanation is attached below, along with your original report.
If you require more details, please reply to 70023 <at> debbugs.gnu.org.
--=20
70023: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70023
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems
------------=_1719727022-29376-1
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Received: (at 70023-done) by debbugs.gnu.org; 30 Jun 2024 05:56:50 +0000
Received: from localhost ([127.0.0.1]:54608 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sNnYQ-0007dD-Hj
for submit <at> debbugs.gnu.org; Sun, 30 Jun 2024 01:56:50 -0400
Received: from mail-lj1-f175.google.com ([209.85.208.175]:49443)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <stefankangas@HIDDEN>) id 1sNnYO-0007cx-S8
for 70023-done <at> debbugs.gnu.org; Sun, 30 Jun 2024 01:56:49 -0400
Received: by mail-lj1-f175.google.com with SMTP id
38308e7fff4ca-2ec408c6d94so19513871fa.3
for <70023-done <at> debbugs.gnu.org>; Sat, 29 Jun 2024 22:56:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1719726943; x=1720331743; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:from:to:cc:subject:date:message-id:reply-to;
bh=E+OIJtnUDP5KTZ2RetdCPDOi4Ggza7FUt0oQ8cgY4yE=;
b=iT6Io2n0Y8gZ5bovhQtFIi3lwQV8pepMst3vkq0a+OCcQb+HW4644efE631E+Qzlyd
JxETdRGkr91RvXenp65pA+TVOizjSUFtn45ep2D5s3tloJJsX5tpAaTKMKsM6XG9M8dS
uswxXQJdY2D19U6DuNh+d2ytDvtqmp1/iUb/Yp4S4bbrakUjQ8z7mKcUQ+D//o0Fx//1
BHj0R/9rpIXr2JcuDacNquBUDvf8QaMuPRwOPAEZ58T4YxE1LrmbRMB45+1PIunrODou
6gGt6XlLVQ4sKIPO6t14X9uyFEB7sNriU6+20hb3Sa0jJ5xodMqSbxpR5mGta5hQFMbq
Z5gw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1719726943; x=1720331743;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=E+OIJtnUDP5KTZ2RetdCPDOi4Ggza7FUt0oQ8cgY4yE=;
b=NU0ehszSAv1KEOLB305gSn8s8E+M+K5UjmB1sMqEOyYNZXBbRgCjDWDA3qz6vm/8fP
bgyGcLA7Y4kBUr2T+lkWSQmHRYPTlRbCgyUPqXsJnft2T8FywejLMq0x/lT8NYD0t4FB
RcFdgz1B1R7LSfYWTSSkM04eSr+UoofMBxHmH6JUSQmOOYoTxjalroBcqgxV720TNBPA
JpE0z+og/E89MSJopGVYzbRRN/0/5it87Ad1guw+6LkRf569CS+wLf9aL4DT0zicRYDd
RZufDk91uiWgbaYE0LfnZZey2QyfhRV7/saCHhC3Pl5AdEhM97ru+JgB/+tMdUeOhCyp
s8RA==
X-Forwarded-Encrypted: i=1;
AJvYcCU+DMrIUsXm+AxiIC2qZ3zjmFw8PwR/FNtcWK90PvE8TwSYS6dSErAGVcc2G+V3nYA4g29uuBimeDqqb1EoItvnOszytOcQx+m6PQ==
X-Gm-Message-State: AOJu0YyldSn1ZcfNUWvBcQXFTqJQjCib+UbCpz6As2X7m9s4QYFjUOAJ
7P+lN692Pi2THb7bhdmQJJ0e00nBojkqiRoLjoJT5QD+XSDdn2iA4XWJZJGqIvgRKVnYiwgyukx
u/zEaBa9zn9GFsj1hNw5lezEWbCY=
X-Google-Smtp-Source: AGHT+IFSjHSGTSDyyZzLWtJbayRjHTeTwVHJDPCDp+bQAJit0R+o/muOZe1KYJGLPbFoVkFE5QaNc3Er/6lvvhoh694=
X-Received: by 2002:a2e:86c8:0:b0:2ec:5469:9d64 with SMTP id
38308e7fff4ca-2ee5e6f271cmr15971701fa.32.1719726943100; Sat, 29 Jun 2024
22:55:43 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Sat, 29 Jun 2024 22:55:42 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87o7ayw7ku.fsf@HIDDEN> (Theodor Thornhill's message of
"Thu, 28 Mar 2024 19:10:41 +0100")
References: <CAPVBTSfqhXbgGGa4M55DH1FL7ne0Yorvj+KhD03uV9=M53u5qg@HIDDEN>
<87o7ayw7ku.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sat, 29 Jun 2024 22:55:42 -0700
Message-ID: <CADwFkmk8ZdF5a=_6bOemwemhKCktPeyHitZB+Z58U1N_f7ZnHQ@HIDDEN>
Subject: Re: bug#70023: [PATCH] Add typescript-ts-mode indentation for
interface bodies
To: Theodor Thornhill <theo@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 70023-done
Cc: Noah Peart <noah.v.peart@HIDDEN>, 70023-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Theodor Thornhill <theo@HIDDEN> writes:
> Noah Peart <noah.v.peart@HIDDEN> writes:
>
>> Tags: patch
>>
>> Adds missing indentation for typescript interfaces.
>>
>> Currently, there is no indentation for property signatures in typescript
>> interfaces.
>>
>> To reproduce, call `M-x (my-test-typescript-indent)`
>>
>> (defun my-test-typescript-indent ()
>> (interactive)
>> (typescript-ts-mode)
>> (setq-local typescript-ts-mode-indent-offset 4)
>> (indent-region (point-min) (point-max)))
>>
>
> [...]
>
> Pushed in bcf6dd6e266222a293e359430afdf3a2dc18369c. I also added a test
> confirming the behavior.
>
> As a small aside, this node type was added very recently. Until now we
> had a rule for it in 'object'
I'm therefore closing this bug report.
------------=_1719727022-29376-1
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Received: (at submit) by debbugs.gnu.org; 27 Mar 2024 06:20:46 +0000
Received: from localhost ([127.0.0.1]:35590 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rpMeS-0003qc-Rk
for submit <at> debbugs.gnu.org; Wed, 27 Mar 2024 02:20:46 -0400
Received: from lists.gnu.org ([2001:470:142::17]:53586)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <noah.v.peart@HIDDEN>) id 1rpMeN-0003qA-I2
for submit <at> debbugs.gnu.org; Wed, 27 Mar 2024 02:20:44 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>)
id 1rpMeH-0005tV-Ib
for bug-gnu-emacs@HIDDEN; Wed, 27 Mar 2024 02:20:34 -0400
Received: from mail-oa1-x2c.google.com ([2001:4860:4864:20::2c])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <noah.v.peart@HIDDEN>)
id 1rpMeE-000835-Mk
for bug-gnu-emacs@HIDDEN; Wed, 27 Mar 2024 02:20:33 -0400
Received: by mail-oa1-x2c.google.com with SMTP id
586e51a60fabf-2220a389390so254472fac.0
for <bug-gnu-emacs@HIDDEN>; Tue, 26 Mar 2024 23:20:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1711520429; x=1712125229; darn=gnu.org;
h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
:date:message-id:reply-to;
bh=5vqFUZedQudXBf27rQBIPKoKmxY74/ALu+K0THPIvcg=;
b=Ri4zc3JrzZi8zKdwxq0rkNizOuZ7JlZM5swFO/PcJ8FbxYHoavpzZx5igCnbz9TVXv
8EriXiniQXSO2rZCWzdOzcRdH6tq6YC7zNwudzhNHBz6xRgz4EQzUMW7q/tK2dvEpNIC
2/RoqIu2aTFwNPkpfakQCi+CYrMO3AKVQo9O2jpw/kH6iOhVlnmvJebsiZjaBUNaoThw
NdAKMaWaBKmMwtx4daAZwu+1+yVRji4rhMK9p8OIUCX/b04hH24YRWfvS01cszPOO54o
hNycUJozILQJU9nTrHeEPG6AwWTyHTY32hTbinHROGWqDS76AmWp7MjLwPUNMvUY1Gpl
WzyA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1711520429; x=1712125229;
h=to:subject:message-id:date:from:mime-version:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=5vqFUZedQudXBf27rQBIPKoKmxY74/ALu+K0THPIvcg=;
b=hOBm3VXjFtj8Nt+18geahspf0iYcJ6MzeonsZVGqPJJYr48WErwc6GMq+shOML5S4j
KHpULTvKY7cyJlLskZVhM9IyF4rcwWgfCAY+83XAI6pieisBAZv8DLhAckUVgfS8dgtW
6ZBgKuyIL9oxCow8wB5Ue4qI3MXzV1E+kTNT9PYXJ9P96t/FGA0afNP9tk484A6z1s+0
jxelw4wyo8iwZN3vMitzyraEEwSwLHN317ORK1UW8uTcA7ZVoIHJocx+mFNN5Oy94z8S
TDzGDjQCgU4Zv4B1sH4Nqr4PKtlCzUE0T8cei272VMaCprT7g3YH9w3JznH8YvG0cse5
Dq3w==
X-Gm-Message-State: AOJu0YxvavN9FUCJCqnK/ybH5kZTXq+L9kptNfXN6iknzZPO3jyFWBdx
SiyGZOZU3uIyIjHltFwt48Vhprr65X3qnUXPHbOEBqjRs4Ah3QOla40pidspH5tMWfRvl9sRV9E
LD8b8JZ6PxXex0dDKHNbmPag7ckSP+wGNMSJhuKP7w10=
X-Google-Smtp-Source: AGHT+IGWuGBoDo+Bmz2Cm4aVhL2G4j45jIKON893CuS376CpMfPdMHn5uDP0gsC0QMARwYaqNsmbZvhqfrUEz9bjKvk=
X-Received: by 2002:a05:6870:a40c:b0:229:ff08:398e with SMTP id
m12-20020a056870a40c00b00229ff08398emr1662943oal.21.1711520429097; Tue, 26
Mar 2024 23:20:29 -0700 (PDT)
MIME-Version: 1.0
From: Noah Peart <noah.v.peart@HIDDEN>
Date: Tue, 26 Mar 2024 23:20:18 -0700
Message-ID: <CAPVBTSfqhXbgGGa4M55DH1FL7ne0Yorvj+KhD03uV9=M53u5qg@HIDDEN>
Subject: [PATCH] Add typescript-ts-mode indentation for interface bodies
To: bug-gnu-emacs@HIDDEN
Content-Type: multipart/mixed; boundary="00000000000033e47a06149e6794"
Received-SPF: pass client-ip=2001:4860:4864:20::2c;
envelope-from=noah.v.peart@HIDDEN; helo=mail-oa1-x2c.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--00000000000033e47a06149e6794
Content-Type: multipart/alternative; boundary="00000000000033e47906149e6792"
--00000000000033e47906149e6792
Content-Type: text/plain; charset="UTF-8"
Tags: patch
Adds missing indentation for typescript interfaces.
Currently, there is no indentation for property signatures in typescript
interfaces.
To reproduce, call `M-x (my-test-typescript-indent)`
(defun my-test-typescript-indent ()
(interactive)
(typescript-ts-mode)
(setq-local typescript-ts-mode-indent-offset 4)
(indent-region (point-min) (point-max)))
in buffer with the following typescript code:
interface Foo {
foo: string; // no matching indent rule
bar?: boolean; // no matching indent rule
}
In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2024-03-24 built on noah-X580VD
Repository revision: c5de73a95a6ecefe46fe1ac07da8e83032be7f5b
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.4 LTS
Configured using:
'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'
--00000000000033e47906149e6792
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Tags: patch<br><br><br>Adds missing indentation for typesc=
ript interfaces.<br><br>Currently, there is no indentation for property sig=
natures in typescript<br>interfaces.<br><br>To reproduce, call `M-x (my-tes=
t-typescript-indent)`<br><br>=C2=A0 =C2=A0 (defun my-test-typescript-indent=
()<br>=C2=A0 =C2=A0 =C2=A0 (interactive)<br>=C2=A0 =C2=A0 =C2=A0 (typescri=
pt-ts-mode)<br>=C2=A0 =C2=A0 =C2=A0 (setq-local typescript-ts-mode-indent-o=
ffset 4)<br>=C2=A0 =C2=A0 =C2=A0 (indent-region (point-min) (point-max)))<b=
r><br><br>in buffer with the following typescript code:<br><br>=C2=A0 =C2=
=A0 interface Foo {<br>=C2=A0 =C2=A0 foo: string; =C2=A0 // no matching ind=
ent rule<br>=C2=A0 =C2=A0 bar?: boolean; // no matching indent rule<br>=C2=
=A0 =C2=A0 }<br><br><br>In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu,=
GTK+ Version<br>3.24.33, cairo version 1.16.0) of 2024-03-24 built on noah=
-X580VD<br>Repository revision: c5de73a95a6ecefe46fe1ac07da8e83032be7f5b<br=
>Repository branch: master<br>Windowing system distributor 'The X.Org F=
oundation', version 11.0.12101004<br>System Description: Ubuntu 22.04.4=
LTS<br><br>Configured using:<br>=C2=A0'configure --prefix=3D/usr/local=
--with-modules --with-tree-sitter<br>--with-threads --with-x-toolkit=3Dgtk=
3 --with-xwidgets --with-gnutls<br>--with-json --with-mailutils --with-jpeg=
--with-png --with-rsvg<br>--with-tiff --with-xml2 --with-xpm --with-imagem=
agick CC=3Dgcc-12<br>CXX=3Dgcc-12'<br></div>
--00000000000033e47906149e6792--
--00000000000033e47a06149e6794
Content-Type: text/x-patch; charset="US-ASCII";
name="0001-Add-typescript-ts-mode-indentation-for-interface-bod.patch"
Content-Disposition: attachment;
filename="0001-Add-typescript-ts-mode-indentation-for-interface-bod.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lu9f1ycw0>
X-Attachment-Id: f_lu9f1ycw0
RnJvbSBhMzlmMjM2NDk3Mzk5ODMxOGI1NmQ5MWNiMjgwMWEwNmIyMzdiODhhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FoIFBlYXJ0IDxub2FoLnYucGVhcnRAZ21haWwuY29tPgpE
YXRlOiBUdWUsIDI2IE1hciAyMDI0IDIyOjQ0OjQ4IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gQWRk
IHR5cGVzY3JpcHQtdHMtbW9kZSBpbmRlbnRhdGlvbiBmb3IgaW50ZXJmYWNlIGJvZGllcwoKKiBs
aXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwKKHR5cGVzY3JpcHQtdHMtbW9kZS0t
aW5kZW50LXJ1bGVzKTogQWRkIGluZGVudGF0aW9uIHJ1bGUgZm9yCmludGVyZmFjZSBib2RpZXMu
Ci0tLQogbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsIHwgMSArCiAxIGZpbGUg
Y2hhbmdlZCwgMSBpbnNlcnRpb24oKykKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy90eXBl
c2NyaXB0LXRzLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwK
aW5kZXggZWE0ZjY0MTdjNWEuLmFiMWQ3NmFiMjBlIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rl
cy90eXBlc2NyaXB0LXRzLW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10
cy1tb2RlLmVsCkBAIC0xMjQsNiArMTI0LDcgQEAgdHlwZXNjcmlwdC10cy1tb2RlLS1pbmRlbnQt
cnVsZXMKICAgICAgKChwYXJlbnQtaXMgIm9iamVjdF90eXBlIikgcGFyZW50LWJvbCB0eXBlc2Ny
aXB0LXRzLW1vZGUtaW5kZW50LW9mZnNldCkKICAgICAgKChwYXJlbnQtaXMgImVudW1fYm9keSIp
IHBhcmVudC1ib2wgdHlwZXNjcmlwdC10cy1tb2RlLWluZGVudC1vZmZzZXQpCiAgICAgICgocGFy
ZW50LWlzICJjbGFzc19ib2R5IikgcGFyZW50LWJvbCB0eXBlc2NyaXB0LXRzLW1vZGUtaW5kZW50
LW9mZnNldCkKKyAgICAgKChwYXJlbnQtaXMgImludGVyZmFjZV9ib2R5IikgcGFyZW50LWJvbCB0
eXBlc2NyaXB0LXRzLW1vZGUtaW5kZW50LW9mZnNldCkKICAgICAgKChwYXJlbnQtaXMgImFycm93
X2Z1bmN0aW9uIikgcGFyZW50LWJvbCB0eXBlc2NyaXB0LXRzLW1vZGUtaW5kZW50LW9mZnNldCkK
ICAgICAgKChwYXJlbnQtaXMgInBhcmVudGhlc2l6ZWRfZXhwcmVzc2lvbiIpIHBhcmVudC1ib2wg
dHlwZXNjcmlwdC10cy1tb2RlLWluZGVudC1vZmZzZXQpCiAgICAgICgocGFyZW50LWlzICJiaW5h
cnlfZXhwcmVzc2lvbiIpIHBhcmVudC1ib2wgdHlwZXNjcmlwdC10cy1tb2RlLWluZGVudC1vZmZz
ZXQpCi0tIAoyLjM0LjEKCg==
--00000000000033e47a06149e6794--
------------=_1719727022-29376-1--
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.