Received: (at 70068) by debbugs.gnu.org; 9 Apr 2024 11:25:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 09 07:25:03 2024 Received: from localhost ([127.0.0.1]:48506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ru9b4-0000sE-IL for submit <at> debbugs.gnu.org; Tue, 09 Apr 2024 07:25:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1ru9b2-0000rZ-1b for 70068 <at> debbugs.gnu.org; Tue, 09 Apr 2024 07:25:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1ru9ao-0000mw-Ee; Tue, 09 Apr 2024 07:24:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=VbKMzSy5tEK09H2zYrYsrbks6E6kbor4aUS7CGhFCBY=; b=gNW3MZsjAxMqI7ZaRbDL T6P1SQs+sVK2zzReEUeKTNsSdQlbg567WCuLZgL6NUWPUC5BPWGwjy1bNNggtdMAe3S2R9bfyXDhn xOiE7Wr2AFxrz77TdSxBfRJY6eLI+dSBk1E8ukr+nyNTjLe8/RFVHE0dsk3xChVNp207inoTP+3fQ yD0sGlL6/NKfGx/Klhy2ZWKb6tSM0I4JlckdnUZKWVMH+4Wp39XJxOjv+g0fUQRfk1RL7o8BwnLx6 YY5mfNUdvqWYll6uo0OVf4q+/tBL5DOZVCmC2zKFi+vCBqEGsPiZ8LiEut42ePelVeF0O2VlAn/Ok BjOzTpM018MKOw==; Date: Tue, 09 Apr 2024 14:24:42 +0300 Message-Id: <86il0qwzgl.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <963F9A52-9903-426A-A505-2CF7F7F315F8@HIDDEN> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Tue, 9 Apr 2024 12:45:18 +0200) Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode References: <2FB192D4-40E7-4327-BC0E-62674C2C1A03@HIDDEN> <8734s2cnv7.fsf@HIDDEN> <6246FE18-7962-40F0-807F-1ABE8F9D2A25@HIDDEN> <93A70615-823B-4369-BE17-128EEA430ADA@HIDDEN> <87y19o2ubc.fsf@HIDDEN> <8634rwytcq.fsf@HIDDEN> <jwvcyr0dpwc.fsf-monnier+emacs@HIDDEN> <7FFED798-8839-43D4-9629-E087A6DFE0D0@HIDDEN> <86msq2x3r4.fsf@HIDDEN> <963F9A52-9903-426A-A505-2CF7F7F315F8@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70068 Cc: philipk@HIDDEN, monnier@HIDDEN, 70068 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Mattias Engdegård <mattias.engdegard@HIDDEN> > Date: Tue, 9 Apr 2024 12:45:18 +0200 > Cc: monnier@HIDDEN, > philipk@HIDDEN, > 70068 <at> debbugs.gnu.org > > 9 apr. 2024 kl. 11.51 skrev Eli Zaretskii <eliz@HIDDEN>: > > >> Looks like option 3 won. Actually I implemented option 3' which is like 3 but checks the mode instead of lexical-binding, on the grounds that a user who damages his lexical cookie by mistake wants to be reminded of it as soon as possible. > > > > That's not what I see in the changes you installed on master. > > Then I made a mistake, but I don't see where. The intent is to have flymake add the argument > > --eval (setq bytecomp--inhibit-lexical-cookie-warning t) > > if (derived-mode-p 'lisp-interaction-mode) is true, and then make the warning conditional on that variable. Doesn't it work? Ah, okay, then it's my misunderstanding: I saw the (local-variable-p 'lexical-binding) test and thought you intended to replace that with a mode test. Apologies.
bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.Received: (at 70068) by debbugs.gnu.org; 9 Apr 2024 10:45:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 09 06:45:35 2024 Received: from localhost ([127.0.0.1]:48439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ru8yt-0004uP-9A for submit <at> debbugs.gnu.org; Tue, 09 Apr 2024 06:45:35 -0400 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]:61711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1ru8yr-0004Zz-Lm for 70068 <at> debbugs.gnu.org; Tue, 09 Apr 2024 06:45:34 -0400 Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2d8b194341eso2193871fa.3 for <70068 <at> debbugs.gnu.org>; Tue, 09 Apr 2024 03:45:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712659520; x=1713264320; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=LmfY2bDB7He7Rh9jZY63r/0myxl/13tU9bFEsanUWc0=; b=gm/fnsuBShktgTFQkC21dFCgy6NaKEoICmr2/cpcmawbNfGMbYs6BvPEqnNGrGOlzB EGp94l2NG/tld4NDp9J/eRZU2SyL3Rf8TS7+zQjvNAYBuzL+m5iQrGhnn43jRiMRTkwz cK4HDRCgfeVC1mPwQkNLUSmj+LGKI9YJL8M9pqxU1eonvdGSAGgIsctnsFjPP0easWuV OTtfnYGeczM2DveLA1o0fB0C4XbMvli4G3BnAlSUfP8YwPa9d9vPYKjD1pMf9PP2vqtR RXXfgkrhvDtJjQEetmS6dEuwEanSIohH0ARRsyuWx15QHp89Q2R4JjK7JSACjQ3wT4GW O1iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712659520; x=1713264320; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=LmfY2bDB7He7Rh9jZY63r/0myxl/13tU9bFEsanUWc0=; b=eVm7iS4/lTMUq2UdGg3MUlSUby87pJeJUMU/tsjCAXTkWl69LpOgXLHtxvX+gahQOJ u6DhhNy0TPPUwAhUa3pv5NYJoVwPwnkNKlZQ70eRTSN3Rap/RtFfYvxFUQ0MctlMC32Q 5VRl97ZneWH2Zy26+9eAzLgX/jGyui1rruqYx7RGa+6owxL1kgF/WjR1KeNBy4ukUxm4 lKHrIUutQqhX+bRtIYq0PuHt8ypKVlgdvTnsf1S0OLM3v9TSknRw8O+yyYBDnzEh/uo2 CvOlZzk/ZG5fQhpg6O6U6o3IB0bbODpYy1FmlCIWYEw2hU5SbbhzGVvKVKbZkalGJTTA Pbpw== X-Forwarded-Encrypted: i=1; AJvYcCVjIIccqsuClxFKj/bLOkCB/BdPdqHDTk27qJWbaP7Z7jqj1CgTdZ9YWKK91HjeZABcubAGk/OfU04KKmxvD2E9fj1QVCQ= X-Gm-Message-State: AOJu0YwxJayHAduuNzG1Y+1QbXf1AzRzsM5ANhtPdkLTXx0F4XQDS4Uz BhNd3rRM5KIAJK6evpb4By/iekNo+0rU9HnsScM9XwY6FRTIUZ1CCvV9NjKI X-Google-Smtp-Source: AGHT+IHENZP1Fp4W5Nx8Edsrh0jAy11wWeqe6hsFJxy7neHxgTrgE93O9zXm/RDq4uNt2Z/JxYhskg== X-Received: by 2002:a2e:330e:0:b0:2d8:7a75:9452 with SMTP id d14-20020a2e330e000000b002d87a759452mr5903744ljc.29.1712659519449; Tue, 09 Apr 2024 03:45:19 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id z6-20020a2ebe06000000b002d865254e49sm1469386ljq.16.2024.04.09.03.45.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2024 03:45:18 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <86msq2x3r4.fsf@HIDDEN> Date: Tue, 9 Apr 2024 12:45:18 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <963F9A52-9903-426A-A505-2CF7F7F315F8@HIDDEN> References: <2FB192D4-40E7-4327-BC0E-62674C2C1A03@HIDDEN> <8734s2cnv7.fsf@HIDDEN> <6246FE18-7962-40F0-807F-1ABE8F9D2A25@HIDDEN> <93A70615-823B-4369-BE17-128EEA430ADA@HIDDEN> <87y19o2ubc.fsf@HIDDEN> <8634rwytcq.fsf@HIDDEN> <jwvcyr0dpwc.fsf-monnier+emacs@HIDDEN> <7FFED798-8839-43D4-9629-E087A6DFE0D0@HIDDEN> <86msq2x3r4.fsf@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70068 Cc: philipk@HIDDEN, monnier@HIDDEN, 70068 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 9 apr. 2024 kl. 11.51 skrev Eli Zaretskii <eliz@HIDDEN>: >> Looks like option 3 won. Actually I implemented option 3' which is = like 3 but checks the mode instead of lexical-binding, on the grounds = that a user who damages his lexical cookie by mistake wants to be = reminded of it as soon as possible. >=20 > That's not what I see in the changes you installed on master. Then I made a mistake, but I don't see where. The intent is to have = flymake add the argument --eval (setq bytecomp--inhibit-lexical-cookie-warning t) if (derived-mode-p 'lisp-interaction-mode) is true, and then make the = warning conditional on that variable. Doesn't it work? What I can see is an unrelated bug in flymake: if the first line of a = buffer (of an .el file) is empty, then the compiler emits a lexical = cookie warning but flymake doesn't show it. Stefan, is this because = there is no text to attach the warning to?
bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.Received: (at 70068) by debbugs.gnu.org; 9 Apr 2024 09:52:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 09 05:52:24 2024 Received: from localhost ([127.0.0.1]:48294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ru89P-0006Kj-UY for submit <at> debbugs.gnu.org; Tue, 09 Apr 2024 05:52:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1ru89M-0006JK-1G for 70068 <at> debbugs.gnu.org; Tue, 09 Apr 2024 05:52:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1ru894-0000El-MA; Tue, 09 Apr 2024 05:52:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=04BdNBF6i6nOI4DuVFvj4QTjfY67/FubxU0UJcj0OQw=; b=DIEdby5GCKCqi6PowvX6 cEUFUZX7ILahuZjCcMiwgoTdYHJdpAdt8Ch/TTGw5rr5f2l6s7yMNSqHyX++y0VN8YBlKNl+WKxv8 4RqA8649yER9W1mSMFWVFCcjyxSgDz/2BZZ0OoXYdLN42pGcqxg0cRtPK0yGDzSvCiAGknOEEknVv ql7Nr8KhB1ng2nhfY00JkdU/GeZ4LddZaBzXjlD1esYR+/CKc3t+PMDSM7ND664j6bMZUAZAWE5lH k9nnoPGgpavds68PwWQQknMN3frE1ETLp3K5oNLnV/uECh2QetO8VIpOVfcX8X8WPRBtRSmbcnAXY bhtXw4gxkKyouA==; Date: Tue, 09 Apr 2024 12:51:59 +0300 Message-Id: <86msq2x3r4.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <7FFED798-8839-43D4-9629-E087A6DFE0D0@HIDDEN> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Tue, 9 Apr 2024 10:57:40 +0200) Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode References: <2FB192D4-40E7-4327-BC0E-62674C2C1A03@HIDDEN> <8734s2cnv7.fsf@HIDDEN> <6246FE18-7962-40F0-807F-1ABE8F9D2A25@HIDDEN> <93A70615-823B-4369-BE17-128EEA430ADA@HIDDEN> <87y19o2ubc.fsf@HIDDEN> <8634rwytcq.fsf@HIDDEN> <jwvcyr0dpwc.fsf-monnier+emacs@HIDDEN> <7FFED798-8839-43D4-9629-E087A6DFE0D0@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70068 Cc: philipk@HIDDEN, monnier@HIDDEN, 70068 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Mattias Engdegård <mattias.engdegard@HIDDEN> > Date: Tue, 9 Apr 2024 10:57:40 +0200 > Cc: Eli Zaretskii <eliz@HIDDEN>, > Philip Kaludercic <philipk@HIDDEN>, > 70068 <at> debbugs.gnu.org > > 8 apr. 2024 kl. 14.02 skrev Stefan Monnier <monnier@HIDDEN>: > > >>> I like the third option. > >> > >> Agreed. > > > > I vote against 1, and I'm fine with both 2 and 3. > > Looks like option 3 won. Actually I implemented option 3' which is like 3 but checks the mode instead of lexical-binding, on the grounds that a user who damages his lexical cookie by mistake wants to be reminded of it as soon as possible. That's not what I see in the changes you installed on master. But if you want to check the mode, against what would you compare it?
bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.Received: (at 70068) by debbugs.gnu.org; 9 Apr 2024 08:58:00 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 09 04:58:00 2024 Received: from localhost ([127.0.0.1]:48249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ru7Il-0001TM-8A for submit <at> debbugs.gnu.org; Tue, 09 Apr 2024 04:58:00 -0400 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:50565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1ru7Ih-0001Sc-Ue for 70068 <at> debbugs.gnu.org; Tue, 09 Apr 2024 04:57:58 -0400 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-516d09bd434so5634704e87.1 for <70068 <at> debbugs.gnu.org>; Tue, 09 Apr 2024 01:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712653062; x=1713257862; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=5U8R9Hyxq367D9RDfs6C384kIS6jeVZEsVlUHB9/llk=; b=AqU1m/aUoFLgFVKYUPNhvUauSBNBGD0YSZPWMCaUmnvbnOJX71sIiFkvDHBs3A9q6/ P6rzvAJmDsRYqIZPSX3atSwfaF9T1mot6CxkA6laFIB+cYxDOlWJ8UPURGdMLErDxYgz 3SOCVLEmQmthCtfFPpakDT4v1XI81PrwHZCYY0k1BuQih7dQ6+XWQRZFQPkAMfBe9+pS oceu/SEIiROwkqvUky0Ia0uPaNcXfA+m25aa6B3CO7OAmrKbMRADNPHOEAhiuWiDo3Mb RBz1qPqewpHmkARJuMVXbGVTOx2ZXfmOe0NySrv0FkBFZmD6k3qbaN2TpLEPO97Z5UaR uGFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712653062; x=1713257862; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5U8R9Hyxq367D9RDfs6C384kIS6jeVZEsVlUHB9/llk=; b=PKIGsTve1U5mRfWOE1LTb/fJ223q+vzWODvkAWYh6ZL4yF13Al8twQ3hhsPUGT3RhS H6NQTMpui8D2xpb/o24aZoVzI8X03NRf/BUeghdYGM0mKqqEmn7wVTA97TLxyQjImEwG /siPdx0Kyo8+ZmLGQ+zJYCjVbEBMjlHA6DdHOh8JnnDdbmTMsY2zZWs2rBFG4w5ZktGd FjN4G4eiqtjMCKXuT2PO0SJgWR46uw0la3NvSbuQkY8Wzi+V/iEe/sSrPF/ZG8JsMfP1 7JnibfkpMauDKkB8mtGhnIFscrS1UjZNyIN0njNPadG7JK2cE9reW3HtMZaR168EXUoZ bcCA== X-Forwarded-Encrypted: i=1; AJvYcCXZTJh7RS8BLAAdWxn/2Ay4XNC/KjhNPcw9i1nzFvLcCNhGW82U6Ew4LTDtkU3Oe85XKpqnoE9CGnB5zej4F7bsxcpuW0w= X-Gm-Message-State: AOJu0YxA26i6PsZsC61ONJrzGq+BEVGOQ2Bp+/W6Z+269ECKYuHz1lCd GnUCplW+K66rQWIRyWI8TZlA45yphSw3ct2//kSFkor3oj55WrwI X-Google-Smtp-Source: AGHT+IHXjARes0EsCv0ZIZfCAsrczYg6DeqnIjs54MBMIfVvoVQ0PL5PbBOZ4011bLoom5ykfM4aMQ== X-Received: by 2002:ac2:5111:0:b0:516:d16f:29d0 with SMTP id q17-20020ac25111000000b00516d16f29d0mr6798966lfb.1.1712653061722; Tue, 09 Apr 2024 01:57:41 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id k12-20020a192d0c000000b00517374e92ecsm308981lfj.93.2024.04.09.01.57.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2024 01:57:41 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <jwvcyr0dpwc.fsf-monnier+emacs@HIDDEN> Date: Tue, 9 Apr 2024 10:57:40 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <7FFED798-8839-43D4-9629-E087A6DFE0D0@HIDDEN> References: <2FB192D4-40E7-4327-BC0E-62674C2C1A03@HIDDEN> <8734s2cnv7.fsf@HIDDEN> <6246FE18-7962-40F0-807F-1ABE8F9D2A25@HIDDEN> <93A70615-823B-4369-BE17-128EEA430ADA@HIDDEN> <87y19o2ubc.fsf@HIDDEN> <8634rwytcq.fsf@HIDDEN> <jwvcyr0dpwc.fsf-monnier+emacs@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70068 Cc: Eli Zaretskii <eliz@HIDDEN>, Philip Kaludercic <philipk@HIDDEN>, 70068 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 8 apr. 2024 kl. 14.02 skrev Stefan Monnier <monnier@HIDDEN>: >>> I like the third option. >>=20 >> Agreed. >=20 > I vote against 1, and I'm fine with both 2 and 3. Looks like option 3 won. Actually I implemented option 3' which is like = 3 but checks the mode instead of lexical-binding, on the grounds that a = user who damages his lexical cookie by mistake wants to be reminded of = it as soon as possible.
bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.
Received: (at 70068) by debbugs.gnu.org; 8 Apr 2024 12:02:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 08 08:02:28 2024
Received: from localhost ([127.0.0.1]:45485 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rtnhj-0008Kb-VW
for submit <at> debbugs.gnu.org; Mon, 08 Apr 2024 08:02:28 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62693)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1rtnhh-0008Jk-RU
for 70068 <at> debbugs.gnu.org; Mon, 08 Apr 2024 08:02:26 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2503C80BDD;
Mon, 8 Apr 2024 08:02:13 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1712577732;
bh=KCAy4mrwMsPoH/Gqq+PxIMu0gBvzMB3S2ouBkDHeQG0=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=jzKwt/u/CQ6rnsTO41bGbpYSD9qsduX3d5H0mBOMpBo53cfN5gwc/nfq+HyRDQN2P
TH9qccK/Y5NvfV2p2kXGt6u/HGu6+i7/DGvFekdhJPgrlk5mTwI4Q5T++R7ztJz0gz
abgFkudnicaniuAvC9OoJrPSDf5geNXvpI+R0q3PxqGTvlxFMaTpqI5YvdNm9ELvp4
6S34tG5y6xkOjfUO3ed2tgNyVP24m4tfEOBfYRxnVFWRDRTOwcj0qE3YmGoj7cAREk
P0//vEKcnM53wufr6WuRjBjCAZu6u2TSYtGZGBlE959iBI2+U9y9DNoU/NEGcS0cMY
qY6kPB9mY5Hgw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 433C6802B6;
Mon, 8 Apr 2024 08:02:12 -0400 (EDT)
Received: from pastel (unknown [45.72.201.215])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 141E7120804;
Mon, 8 Apr 2024 08:02:12 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in
lisp-interaction-mode
In-Reply-To: <8634rwytcq.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 08 Apr
2024 14:41:25 +0300")
Message-ID: <jwvcyr0dpwc.fsf-monnier+emacs@HIDDEN>
References: <2FB192D4-40E7-4327-BC0E-62674C2C1A03@HIDDEN>
<8734s2cnv7.fsf@HIDDEN>
<6246FE18-7962-40F0-807F-1ABE8F9D2A25@HIDDEN>
<93A70615-823B-4369-BE17-128EEA430ADA@HIDDEN>
<87y19o2ubc.fsf@HIDDEN> <8634rwytcq.fsf@HIDDEN>
Date: Mon, 08 Apr 2024 08:02:11 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.096 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 70068
Cc: Philip Kaludercic <philipk@HIDDEN>, mattias.engdegard@HIDDEN,
70068 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> > If we want to do something about this, here are some options.
>> >
>> > 1. Add -*-lexical-binding:t-*- to initial-scratch-message.
>> >
>> > 2. It will sort itself out eventually as lexical-binding becomes the
>> > default. Sit and wait (a few years).
>> >
>> > 3. Something like the attached hack.
>>
>> I like the third option.
>
> Agreed.
>
> Stefan?
I vote against 1, and I'm fine with both 2 and 3.
Stefan
bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.Received: (at 70068) by debbugs.gnu.org; 8 Apr 2024 11:41:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 08 07:41:43 2024 Received: from localhost ([127.0.0.1]:45448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rtnNe-0006lk-PL for submit <at> debbugs.gnu.org; Mon, 08 Apr 2024 07:41:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rtnNc-0006lS-5n for 70068 <at> debbugs.gnu.org; Mon, 08 Apr 2024 07:41:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rtnNP-0008A7-BH; Mon, 08 Apr 2024 07:41:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=2IeLZEHJ4UylhzcPXs6MFcFPwemymx0+C+VD0Bs+ol8=; b=AnxewnLhvYJK5svC6EQ6 EXGoAes85cjNKYmUuPQgO5v29QLvkfekM5vRUnYd4r2vY6owLigtdsAdTfXjDlzwlfHY5syYiHgG4 8teQdYwKVEDl8gwYsKTML+7qXzM/erLq0HWxnoSecX1jdWAwm8ZsJZLIfPbz1UsEdNz0SluPi+ncl ChAO0GAbs3E3hy7DWQimf5Mb3vAJ5Bq59xhuNHM+K2TKWsoBPquD/Yd2Zcw01XJXHaTalQEoX7MS5 AQyGerlLHu51dwSdjlHyqBcbqdgvSDmsxYFftg/QxdIzOdhaWH28y6xTOeaxQ+vTbEG/p1ImrtrbJ F0B+ttcnu3ZZJg==; Date: Mon, 08 Apr 2024 14:41:25 +0300 Message-Id: <8634rwytcq.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Philip Kaludercic <philipk@HIDDEN> In-Reply-To: <87y19o2ubc.fsf@HIDDEN> (message from Philip Kaludercic on Mon, 08 Apr 2024 07:21:43 +0000) Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode References: <2FB192D4-40E7-4327-BC0E-62674C2C1A03@HIDDEN> <8734s2cnv7.fsf@HIDDEN> <6246FE18-7962-40F0-807F-1ABE8F9D2A25@HIDDEN> <93A70615-823B-4369-BE17-128EEA430ADA@HIDDEN> <87y19o2ubc.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70068 Cc: mattias.engdegard@HIDDEN, monnier@HIDDEN, 70068 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Philip Kaludercic <philipk@HIDDEN> > Cc: Stefan Monnier <monnier@HIDDEN>, Eli Zaretskii > <eliz@HIDDEN>, 70068 <at> debbugs.gnu.org > Date: Mon, 08 Apr 2024 07:21:43 +0000 > > Mattias Engdegård <mattias.engdegard@HIDDEN> writes: > > > If we want to do something about this, here are some options. > > > > 1. Add -*-lexical-binding:t-*- to initial-scratch-message. > > > > 2. It will sort itself out eventually as lexical-binding becomes the default. Sit and wait (a few years). > > > > 3. Something like the attached hack. > > I like the third option. Agreed. Stefan?
bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.
Received: (at 70068) by debbugs.gnu.org; 8 Apr 2024 07:22:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 08 03:22:15 2024
Received: from localhost ([127.0.0.1]:45202 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rtjKX-0006sI-BP
for submit <at> debbugs.gnu.org; Mon, 08 Apr 2024 03:22:15 -0400
Received: from mout02.posteo.de ([185.67.36.66]:45197)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <philipk@HIDDEN>) id 1rtjKS-0006qc-0V
for 70068 <at> debbugs.gnu.org; Mon, 08 Apr 2024 03:22:12 -0400
Received: from submission (posteo.de [185.67.36.169])
by mout02.posteo.de (Postfix) with ESMTPS id 80EF2240107
for <70068 <at> debbugs.gnu.org>; Mon, 8 Apr 2024 09:21:54 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
t=1712560914; bh=TwvZHhE59OZjgRo1/HlZJrl8JYdj2LuRcreNQsy7msQ=;
h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version:
Content-Type:Content-Transfer-Encoding:From;
b=RDBUCFWSA8+JY3k3MIF7hw7DBMaWKi4Mh/8Q+ZjbYOyYrmVGWKyBJqi9vtErzEMYl
f70BY27d/WiofSRgSCiAarN5A7hcC88JxO2XTeNYeOkMkYUOjUoAYhx0pOj7hKWJPH
OMmoR2xuB0x67JZKlzotQo+9+e4eoAdR7vlePT383nTxiKK14RQEgW/Ct+QjPSCi2z
C9nORLSeU+yCZRnA7HszhCnPw7hhwYUoMafjrtD++C0yXBNIpPGRmo8C0SgsFq+BDC
X0x9WF6ytWL8alvnAyKwzvfrl5RGVcOU5d5fgM69xSvfFmrzhI51dYsQYu2gvZIcQF
O1myvYA/2Y8UA==
Received: from customer (localhost [127.0.0.1])
by submission (posteo.de) with ESMTPSA id 4VCgWX4Vsfz9rxQ;
Mon, 8 Apr 2024 09:21:44 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in
lisp-interaction-mode
In-Reply-To: <93A70615-823B-4369-BE17-128EEA430ADA@HIDDEN> ("Mattias
=?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Sat, 6 Apr 2024 12:14:02
+0200")
References: <2FB192D4-40E7-4327-BC0E-62674C2C1A03@HIDDEN>
<8734s2cnv7.fsf@HIDDEN>
<6246FE18-7962-40F0-807F-1ABE8F9D2A25@HIDDEN>
<93A70615-823B-4369-BE17-128EEA430ADA@HIDDEN>
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
preference=signencrypt
Date: Mon, 08 Apr 2024 07:21:43 +0000
Message-ID: <87y19o2ubc.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 70068
Cc: Eli Zaretskii <eliz@HIDDEN>, Stefan Monnier <monnier@HIDDEN>,
70068 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Mattias Engdeg=C3=A5rd <mattias.engdegard@HIDDEN> writes:
> If we want to do something about this, here are some options.
>
> 1. Add -*-lexical-binding:t-*- to initial-scratch-message.
>
> 2. It will sort itself out eventually as lexical-binding becomes the defa=
ult. Sit and wait (a few years).
>
> 3. Something like the attached hack.
I like the third option.
--=20
Philip Kaludercic on peregrine
bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.
Received: (at 70068) by debbugs.gnu.org; 6 Apr 2024 10:14:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 06 06:14:25 2024
Received: from localhost ([127.0.0.1]:38342 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rt344-00025n-88
for submit <at> debbugs.gnu.org; Sat, 06 Apr 2024 06:14:25 -0400
Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:57796)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mattias.engdegard@HIDDEN>) id 1rt33w-000248-JU
for 70068 <at> debbugs.gnu.org; Sat, 06 Apr 2024 06:14:20 -0400
Received: by mail-lf1-x129.google.com with SMTP id
2adb3069b0e04-516d3a470d5so2007814e87.3
for <70068 <at> debbugs.gnu.org>; Sat, 06 Apr 2024 03:14:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1712398444; x=1713003244; darn=debbugs.gnu.org;
h=references:to:cc:in-reply-to:date:subject:mime-version:message-id
:from:sender:from:to:cc:subject:date:message-id:reply-to;
bh=m77id6i/8KSSSTe0sFHB0SHcgr0S+btYWgF4XmXNwKg=;
b=eJuPHNsu8Qtqc/YGpv0R1sL5uLYZkeUKbFt5f+lz1xtR6fLm3DnYsPCvF6qkcOqOEp
qOU7tBiBuJSLEeHhewO7KxjKyeWhXAOhl3tw3o+kisHfxOVBtr4saUywIVyXx4gvtVxh
eOlNcd4jZKP45KdXvPonozqIPFDG8yLFibbf1DPPFxcjL9ym5olxsH4QHyLZZv9rYawI
hHxrPD+GSrW5gm2Ma9fPkQPS+l3Uwfh5WPXm+Bm4udmmfYdiIz3mo3AXfbyOrUeizf9A
olgDZfErJb/0NYCBynuUHfjreHS1wuC51cmXClXkYRMiGccWT9mT32InXnkqBtDNqT3M
ThAg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1712398444; x=1713003244;
h=references:to:cc:in-reply-to:date:subject:mime-version:message-id
:from:sender:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=m77id6i/8KSSSTe0sFHB0SHcgr0S+btYWgF4XmXNwKg=;
b=vujvzrhwMZyoWDzFsdFYSQGEWCmCiwXN3+jviyiHM1xpjlP57QQwYrQ9T1g4DZyqur
7FEOcyACkCaQ8pkmptAXv/kgXU5VLPOAi+FQD+gm6gcDRTgOHCaTUMEW/fedOqzD5J+H
+TdR1mr0yYY/r4xtkqDaghpMzU+cyYxsIAN6b2opgzCujCJ7s1Yt65XnmbMK64h8dxbY
bhKZ+KlL0/MHZT6FVONEU0QvVLz9fu6LihxfxdZ4fdibZHxaRsIHjvLMGA8NiWcJkzBn
EE9xG/9/WGMN61QuHOFSLer5SslVE/PthStormUIWp9eq0Pxr3ChkLstALxTMnKJbDo5
j2Hg==
X-Forwarded-Encrypted: i=1;
AJvYcCX6qf7VM3CPi8HcnDeeJECGp20SaVuk5leYqOnChRb/OBjJ9/YB4tQ6h/jy04BJIERK8zerRdfCxB20ZBmLQJNQqgf6Rrg=
X-Gm-Message-State: AOJu0YzGZ1iY04qc5bR+eaxunLMmNk2Qn4Z4nufK+NF7LC7n5smx5iR8
isaXF5auw+4wiEITcgHxwLj9MhxLjLTCVs0fgZWD6XOIIm3oo48v
X-Google-Smtp-Source: AGHT+IF5zRBdcLTJ1YQo188NcwcOisGegCnY0TlMzwa7TsPsGtB+r+jCbmQLJvi4dhDORIhRU8D0/w==
X-Received: by 2002:a19:2d5b:0:b0:515:920e:eedb with SMTP id
t27-20020a192d5b000000b00515920eeedbmr2070558lft.39.1712398443676;
Sat, 06 Apr 2024 03:14:03 -0700 (PDT)
Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se.
[80.217.1.132]) by smtp.gmail.com with ESMTPSA id
m11-20020a056512358b00b00515d32e33a8sm438086lfr.99.2024.04.06.03.14.02
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Sat, 06 Apr 2024 03:14:03 -0700 (PDT)
From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>
Message-Id: <93A70615-823B-4369-BE17-128EEA430ADA@HIDDEN>
Content-Type: multipart/mixed;
boundary="Apple-Mail=_7F095A87-97AA-4AFE-BBB2-95823E86B1C3"
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\))
Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in
lisp-interaction-mode
Date: Sat, 6 Apr 2024 12:14:02 +0200
In-Reply-To: <6246FE18-7962-40F0-807F-1ABE8F9D2A25@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
References: <2FB192D4-40E7-4327-BC0E-62674C2C1A03@HIDDEN>
<8734s2cnv7.fsf@HIDDEN> <6246FE18-7962-40F0-807F-1ABE8F9D2A25@HIDDEN>
X-Mailer: Apple Mail (2.3654.120.0.1.15)
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 70068
Cc: Eli Zaretskii <eliz@HIDDEN>, Stefan Monnier <monnier@HIDDEN>,
70068 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--Apple-Mail=_7F095A87-97AA-4AFE-BBB2-95823E86B1C3
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=us-ascii
If we want to do something about this, here are some options.
1. Add -*-lexical-binding:t-*- to initial-scratch-message.
2. It will sort itself out eventually as lexical-binding becomes the =
default. Sit and wait (a few years).
3. Something like the attached hack.
--Apple-Mail=_7F095A87-97AA-4AFE-BBB2-95823E86B1C3
Content-Disposition: attachment;
filename=lexbind-warning-supp.diff
Content-Type: application/octet-stream;
x-unix-mode=0644;
name="lexbind-warning-supp.diff"
Content-Transfer-Encoding: 7bit
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 5cff86784f0..fb3278c08ab 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -2149,6 +2149,8 @@ byte-write-target-file
(cons tempfile target-file))
(rename-file tempfile target-file t)))))
+(defvar bytecomp--inhibit-lexical-cookie-warning nil)
+
;;;###autoload
(defun byte-compile-file (filename &optional load)
"Compile a file of Lisp code named FILENAME into a file of byte code.
@@ -2234,7 +2236,8 @@ byte-compile-file
(setq buffer-read-only nil
filename buffer-file-name))
;; Don't inherit lexical-binding from caller (bug#12938).
- (unless (local-variable-p 'lexical-binding)
+ (unless (or (local-variable-p 'lexical-binding)
+ bytecomp--inhibit-lexical-cookie-warning)
(let ((byte-compile-current-buffer (current-buffer)))
(displaying-byte-compile-warnings
(byte-compile-warn-x
diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el
index 8a713bd19a2..6bba1199aec 100644
--- a/lisp/progmodes/elisp-mode.el
+++ b/lisp/progmodes/elisp-mode.el
@@ -2169,6 +2169,8 @@ elisp-flymake-byte-compile-load-path
(dolist (path x t) (unless (stringp path)
(throw 'tag nil)))))))
+(defvar bytecomp--inhibit-lexical-cookie-warning)
+
;;;###autoload
(defun elisp-flymake-byte-compile (report-fn &rest _args)
"A Flymake backend for elisp byte compilation.
@@ -2184,7 +2186,14 @@ elisp-flymake-byte-compile
(save-restriction
(widen)
(write-region (point-min) (point-max) temp-file nil 'nomessage))
- (let* ((output-buffer (generate-new-buffer " *elisp-flymake-byte-compile*")))
+ (let* ((output-buffer (generate-new-buffer " *elisp-flymake-byte-compile*"))
+ ;; Hack: suppress warning about missing lexical cookie if the
+ ;; buffer has `lexical-binding' set, so that we don't
+ ;; complain about *scratch* buffers.
+ (warning-suppression-opt
+ (and lexical-binding
+ '("--eval"
+ "(setq bytecomp--inhibit-lexical-cookie-warning t)"))))
(setq
elisp-flymake--byte-compile-process
(make-process
@@ -2196,6 +2205,7 @@ elisp-flymake-byte-compile
;; "--eval" "(setq load-prefer-newer t)" ; for testing
,@(mapcan (lambda (path) (list "-L" path))
elisp-flymake-byte-compile-load-path)
+ ,@warning-suppression-opt
"-f" "elisp-flymake--batch-compile-for-flymake"
,temp-file)
:connection-type 'pipe
--Apple-Mail=_7F095A87-97AA-4AFE-BBB2-95823E86B1C3--
bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.
Received: (at 70068) by debbugs.gnu.org; 3 Apr 2024 19:07:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 03 15:07:37 2024
Received: from localhost ([127.0.0.1]:59640 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rs5xQ-0001c9-Vp
for submit <at> debbugs.gnu.org; Wed, 03 Apr 2024 15:07:37 -0400
Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:51394)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mattias.engdegard@HIDDEN>) id 1rs5xM-0001bF-BJ
for 70068 <at> debbugs.gnu.org; Wed, 03 Apr 2024 15:07:36 -0400
Received: by mail-lf1-x135.google.com with SMTP id
2adb3069b0e04-513e25afabaso271482e87.2
for <70068 <at> debbugs.gnu.org>; Wed, 03 Apr 2024 12:07:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1712171242; x=1712776042; darn=debbugs.gnu.org;
h=to:references:message-id:content-transfer-encoding:cc:date
:in-reply-to:from:subject:mime-version:sender:from:to:cc:subject
:date:message-id:reply-to;
bh=jJRX2qvnLPhuA9N1PySquj8jhuVlxprfZAQFJV6n9SI=;
b=JnBc5FvvIG7vmbEKeDfG8DlcsB1Beh+AXYm1DbIJSbzarFcVRNRIgkVu2yr1gufUq3
UItQKr1HjVtcA3C2fvMrWPShlb2VgXsCJIrPPYf1cFmrApx2xtb2bkJ5TsXE/1hPdx3B
/89E41mBjZG24cdzbINWiTwxL8NYu9uQNTwaLxSx1rQML4IccSMTtNOhmechPuqUebKs
V+nbeRcGL/xvnxWLMyiMBkX9tjbvZsDhVZE0tevoJPAxKGxnu1NzuDbRprgQw/vJPTjt
Yy9Xh3DsqbWihL6yFYVupNmR3FiGFyZLn8F+ZxJp2DB82JjiJfgYiZW1p5ZcMcsPesnp
JIAg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1712171242; x=1712776042;
h=to:references:message-id:content-transfer-encoding:cc:date
:in-reply-to:from:subject:mime-version:sender:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=jJRX2qvnLPhuA9N1PySquj8jhuVlxprfZAQFJV6n9SI=;
b=Ib7ufJqsrBPaq2F2ueI6jatVaxOCZPPg8PP2N+/K/3956nPOoJTB7Rkk5exzU8QrEa
WNo1x0dtB/wpOi1As08I6V7spHGV72eSllIKYy6EJOc4OfYs0pSkuLdidfbZHbTqODqc
HPfQ7TTH5yuJznQ1KPmBdEKNxc+9fvgS084z6r8Z5JlxKUbuZkWNTzNFi7Cf7FepZj1s
P1M7wQWuHMd5D9qknkdTvFEWMj06qrAnL9QdHoJUi+9Vvm9QeDJbfSNt65SjquYsNIUB
pO5KlHVJ2cpt0Gh2/AJyRenRM+gPNKEUrp+wN99DCRGlBLeGjlPfxlhupMagRblgdQlr
6pIg==
X-Forwarded-Encrypted: i=1;
AJvYcCUggNY645mYFSkRI+gSzdo4swlkVFp1XDbZhujm7CBvRvfJrC4MpMa/fENs0Apq1H9/yL3dsUDOwaIDt7LdK0824skXNgs=
X-Gm-Message-State: AOJu0Yx4j2hCg9XhcJ0rtGCi7CATmtS4QTv6FK5gSSSm5WFU/qVDVXwB
0tY3dVV4y6hSGcQdp7sDoZUME2OheaGdGAVy8CUab66gZw6DvySw
X-Google-Smtp-Source: AGHT+IEUdmN0UleSF5QL69T7zQerVbPhqgr/uzMVtE0hkuKfGeF0nO+6L53VV43xS+J0DKRu7Fxt1w==
X-Received: by 2002:a05:6512:361a:b0:514:cbee:a261 with SMTP id
f26-20020a056512361a00b00514cbeea261mr270397lfs.27.1712171241452;
Wed, 03 Apr 2024 12:07:21 -0700 (PDT)
Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se.
[80.217.1.132]) by smtp.gmail.com with ESMTPSA id
cf11-20020a056512280b00b00515c82be232sm2062167lfb.92.2024.04.03.12.07.20
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Wed, 03 Apr 2024 12:07:20 -0700 (PDT)
Content-Type: text/plain;
charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\))
Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in
lisp-interaction-mode
From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>
In-Reply-To: <8734s2cnv7.fsf@HIDDEN>
Date: Wed, 3 Apr 2024 21:07:19 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <6246FE18-7962-40F0-807F-1ABE8F9D2A25@HIDDEN>
References: <2FB192D4-40E7-4327-BC0E-62674C2C1A03@HIDDEN>
<8734s2cnv7.fsf@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
X-Mailer: Apple Mail (2.3654.120.0.1.15)
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 70068
Cc: Eli Zaretskii <eliz@HIDDEN>, Stefan Monnier <monnier@HIDDEN>,
70068 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
3 apr. 2024 kl. 20.17 skrev Philip Kaludercic <philipk@HIDDEN>:
> You are right, I made a mistake; What I want to say is this:
> - (unless (local-variable-p 'lexical-binding)
> + (when (or (not (local-variable-p 'lexical-binding))
> + (null lexical-binding))
Are you sure that you didn't mean
(unless (or (local-variable-p 'lexical-binding)
lexical-binding)
a.k.a.
(when (and (not (local-variable-p 'lexical-binding)
(not lexical-binding))
which may or may not make more sense? But how would either of these =
work, given that flymake runs a byte-compilation in a spawned Emacs and, =
as far as I can tell, propagates neither the buffer mode nor the =
lexical-binding value to that process?
bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.
Received: (at 70068) by debbugs.gnu.org; 3 Apr 2024 18:17:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 03 14:17:32 2024
Received: from localhost ([127.0.0.1]:59555 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rs5Ay-00064z-AR
for submit <at> debbugs.gnu.org; Wed, 03 Apr 2024 14:17:32 -0400
Received: from mout02.posteo.de ([185.67.36.66]:49209)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <philipk@HIDDEN>) id 1rs5Aw-000647-6Y
for 70068 <at> debbugs.gnu.org; Wed, 03 Apr 2024 14:17:31 -0400
Received: from submission (posteo.de [185.67.36.169])
by mout02.posteo.de (Postfix) with ESMTPS id E7926240104
for <70068 <at> debbugs.gnu.org>; Wed, 3 Apr 2024 20:17:18 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
t=1712168238; bh=Wf6oBzhvPQvGasoVCjP3r1ie/EwhFNAA/dOR3OQh29k=;
h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version:
Content-Type:Content-Transfer-Encoding:From;
b=cJuMpkxt1ZxTBVhlAabBrv5Vt6BnD93XgzkJDpxR7X6YqqpUYnpo1XaQO5/S+28kz
psyvU0aHu0vR0uYK6Hqp0Mb/ht5cCg0zOsQonBmPC8Ijl1twnmZO6n7C5OV9QCqNiK
2Asa3XL7f2JF2SfOFy+zbK7GDmBe4Vx5kXXH8CCR9+D0Kon4cnHplvDZRm7gSxUkDZ
mYFbWpgw762RZuVjduLvNdbVEwtiNJO7ezmqeIEAN/HB6AVFu9KHvM0XQZG7cea2yl
BU3UN801if9wgM5SUPRxP4hP8zI8SgJI2JObPtZcmmRpdzeytpJN1MF3ScxppCeqHy
eShZq34Ml59xg==
Received: from customer (localhost [127.0.0.1])
by submission (posteo.de) with ESMTPSA id 4V8tJF45dqz9rxB;
Wed, 3 Apr 2024 20:17:17 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in
lisp-interaction-mode
In-Reply-To: <2FB192D4-40E7-4327-BC0E-62674C2C1A03@HIDDEN> ("Mattias
=?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Wed, 3 Apr 2024 11:35:50
+0200")
References: <2FB192D4-40E7-4327-BC0E-62674C2C1A03@HIDDEN>
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
preference=signencrypt
Date: Wed, 03 Apr 2024 18:17:16 +0000
Message-ID: <8734s2cnv7.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 70068
Cc: Eli Zaretskii <eliz@HIDDEN>, Stefan Monnier <monnier@HIDDEN>,
70068 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Mattias Engdeg=C3=A5rd <mattias.engdegard@HIDDEN> writes:
>> - (unless (local-variable-p 'lexical-binding)
>> + (unless (or (local-variable-p 'lexical-binding)
>> + (null lexical-binding))
>
> That logic doesn't make sense to me, and it clearly doesn't work so I rev=
erted it.
> (For some reason the test didn't catch it, but it's now been made more ro=
bust.)
You are right, I made a mistake; What I want to say is this:
--8<---------------cut here---------------start------------->8---
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 5cff86784f0..a1194f2dc70 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -2234,7 +2234,8 @@ byte-compile-file
(setq buffer-read-only nil
filename buffer-file-name))
;; Don't inherit lexical-binding from caller (bug#12938).
- (unless (local-variable-p 'lexical-binding)
+ (when (or (not (local-variable-p 'lexical-binding))
+ (null lexical-binding))
(let ((byte-compile-current-buffer (current-buffer)))
(displaying-byte-compile-warnings
(byte-compile-warn-x
--8<---------------cut here---------------end--------------->8---
What makes me uncertain is that you say it makes "no sense", so I want
to make sure I am not misunderstanding something completely.
--=20
Philip Kaludercic on peregrine
bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.Received: (at 70068) by debbugs.gnu.org; 3 Apr 2024 09:36:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 03 05:36:04 2024 Received: from localhost ([127.0.0.1]:57082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rrx2K-0003wz-EI for submit <at> debbugs.gnu.org; Wed, 03 Apr 2024 05:36:04 -0400 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]:47269) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1rrx2I-0003w6-LI for 70068 <at> debbugs.gnu.org; Wed, 03 Apr 2024 05:36:03 -0400 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-516c116f480so8447e87.2 for <70068 <at> debbugs.gnu.org>; Wed, 03 Apr 2024 02:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712136952; x=1712741752; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=UsbwLx5MX42KRtvn0paUR7LDe0a5wvrdXZfynTVFJ3A=; b=M9+nlPZPk0r8B1ymgEpKLCjSpUBgi4eTmPYaTDNmUVgb9CslWKZQXZoVKwip/OUUrE yRAAEzSi45FBI/Y6amezppeEQtYuucZtBsuxj1tUjsggchbtYPxMUKEdVSw5rZcKkrwt 9JpeUvy55i9cFGH/usvuijZll6/IiddaxlaDzkdBXuMceVLngX1DyBlyq8X4Bd8bsgf+ AA7kv2aI1exAVtBMhB0q17DB22bkdpGA7yXMaRUIGxa+9U/eYS/6eEGAGmMrzP5/ZPtE 7LJ5/DVPWjixJswS/rdrN6N1+xqXmmmIKNQzkXVv486dZ1BdXqoDsFVYLWx26Hxrl0pa JNHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712136952; x=1712741752; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UsbwLx5MX42KRtvn0paUR7LDe0a5wvrdXZfynTVFJ3A=; b=l+xIvMfO/rMLP/i+dY3IB2ZKAKrFaxFhCQ0QtEpCBUu5xMUYUt1FWUFhPhEJ3eRkST IPFxytFc/vrsNT6NXokly6pG+XnRfjG9bph579D0/i0/jWxNkZ+XTG1M5n5G9nucAC7u UpHXzkemcbCORp+dDqR+Qcf+/JuvYL/ARskGYvEYWTEPhgSmJbHbQaskzoEZ8wiwz4+8 6Yz5THqsP+lGmdOytnfBUE/rTcWm/sZAtVi+6zyonilVwDz3kMBu3dKKT3+Dp5bkVX3a h3vdtjVmDb30YZKq3lFNpKtAG+iF37h/bT9j6+Y2GHXA1ChEBHqugZ08qnEvr0QruGcx 2C2w== X-Forwarded-Encrypted: i=1; AJvYcCVAsl8VSGyaidPBXN2vDgfg7lzL66NAVN9LPD7QOGchpvz3txX9V6wriwJPTqnlqXHXor1MxgHf4ew5CcxC3xCjij8Krq8= X-Gm-Message-State: AOJu0Yxxdpz9tGTI6JqbohlD4voU22qmBgpFbwt3nJQy/6SQw1kLRJfd VW0zQ9vkQq1jOOVtOznn9QZ01i4Zqi8wB/SUbbXY84+JIDbIf8b4 X-Google-Smtp-Source: AGHT+IFxmnEU+MNqljq74geLQ7JJ114Xz1PG6iEmw1q89MKe6F8MXxOOT6MZbAqYcGW/+MmBds7ukg== X-Received: by 2002:ac2:4c05:0:b0:516:a517:f26d with SMTP id t5-20020ac24c05000000b00516a517f26dmr1307487lfq.9.1712136952071; Wed, 03 Apr 2024 02:35:52 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id i28-20020a198c5c000000b00513d51042f8sm2011698lfj.137.2024.04.03.02.35.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Apr 2024 02:35:51 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode Message-Id: <2FB192D4-40E7-4327-BC0E-62674C2C1A03@HIDDEN> Date: Wed, 3 Apr 2024 11:35:50 +0200 To: Philip Kaludercic <philipk@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70068 Cc: Eli Zaretskii <eliz@HIDDEN>, Stefan Monnier <monnier@HIDDEN>, 70068 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) > - (unless (local-variable-p 'lexical-binding) > + (unless (or (local-variable-p 'lexical-binding) > + (null lexical-binding)) That logic doesn't make sense to me, and it clearly doesn't work so I = reverted it. (For some reason the test didn't catch it, but it's now been made more = robust.)
bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.Received: (at 70068-done) by debbugs.gnu.org; 3 Apr 2024 08:53:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 03 04:53:09 2024 Received: from localhost ([127.0.0.1]:57007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rrwMn-0000FD-1B for submit <at> debbugs.gnu.org; Wed, 03 Apr 2024 04:53:09 -0400 Received: from mout01.posteo.de ([185.67.36.65]:50885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <philipk@HIDDEN>) id 1rrwMk-0000ED-NU for 70068-done <at> debbugs.gnu.org; Wed, 03 Apr 2024 04:53:07 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 825AC240028 for <70068-done <at> debbugs.gnu.org>; Wed, 3 Apr 2024 10:52:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1712134376; bh=pIlKCi3EyqgUnsbfGWmEHlymE8DQnEndOdTO2rm1BSQ=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=cZ375YnQIuI3UUfnqu6mdjzfqqpE4MqnhGEZashHP1f4k/QmF92pjgQQpb9oNGKs6 y//UhjPUUUZpjnHZMnKU1ytaJ/dRXgrHm/iAkAaxFWhet0KiJgD1moIw14KXN6Lbru 3OBajWtWoeb3jM71NjxzCoc8DCXiThts0gLnqEduC+fTmq7aRtKELjmCnvKoMcA3o8 u8M4NDexdO86aaj8v08WME5EfalzChUHf8fXbWqY/jIfbq/T20K0kuSNBaFgxl7uLi kcbSFm6ORJR9roi/ERk0lNzbBD4UPEyi0rvlShg1W5ihr0ihUMsxXfcTHUgnvwy/xD QXAfxHDEo1dUQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4V8dn25JKVz9rxM; Wed, 3 Apr 2024 10:52:54 +0200 (CEST) From: Philip Kaludercic <philipk@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode In-Reply-To: <jwvil11r6x2.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message of "Mon, 01 Apr 2024 01:27:27 -0400") References: <878r21jmu2.fsf@HIDDEN> <86a5mgdx5i.fsf@HIDDEN> <87msqg2d2j.fsf@HIDDEN> <86r0frdgmx.fsf@HIDDEN> <jwvil11r6x2.fsf-monnier+emacs@HIDDEN> OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Wed, 03 Apr 2024 08:52:54 +0000 Message-ID: <87jzle4yl5.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70068-done Cc: Eli Zaretskii <eliz@HIDDEN>, 70068-done <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Stefan Monnier <monnier@HIDDEN> writes: >>> My thinking was that one never needs to set the variable anyway, since >>> `lisp-interaction-mode' sets `lexical-binding' anyway. Alternatively, >>> one could also modify the patch to check if `lexical-binding' is non-nil? >> >> The latter possibility would be better, I think. Stefan, WDYT? > > Testing `lexical-binding` sounds good: the purpose is to encourage people > to activate `lexical-binding`, rather than encourage them to add a magic cookie. OK, I have modified by patch and pushed it to master (0197db7b). > > Stefan > -- Philip Kaludercic on peregrine
Philip Kaludercic <philipk@HIDDEN>:Philip Kaludercic <philipk@HIDDEN>:
Received: (at 70068) by debbugs.gnu.org; 1 Apr 2024 05:27:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 01 01:27:42 2024
Received: from localhost ([127.0.0.1]:49297 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rrACr-0008Bs-NY
for submit <at> debbugs.gnu.org; Mon, 01 Apr 2024 01:27:42 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14252)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1rrACo-0008Bd-Vi
for 70068 <at> debbugs.gnu.org; Mon, 01 Apr 2024 01:27:40 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 112AE44097B;
Mon, 1 Apr 2024 01:27:30 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1711949248;
bh=6LjWeh7HAAPuJI8cbDfN4mFLFoN03MW2btB0n8INyxg=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=GJq0ntaRiZ+6Jh0gmy2VraJ+RTC61d9UdUopRch9WRjax6sZcr83KxUakzpV3vg8f
2UT3Jd0BkDlptsq0CZoyMXzw2ymXB41YXznxJcwmyQTiHtIrVsiTuTvVsGehTuhndp
LfLKM7PGZ6mAjNbxh8bICk5naO4Lvw5d2nmmSdtwao9bkJlGhCqv8HjfpwQ1p2g1op
5wD6gfF18uDI4D0Aq/hdX4JKjK3uqH5BdJQSpheiL7cSlaKoIEqAhH71ErJBWHIgma
tYSmg8WkRyGtDxp3TUZmzY2bNGguffmBUN+KlqPw+YTmC8QyYijV3P0jnGsygWhwyK
RiBkpxA4J7t6A==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E6434440777;
Mon, 1 Apr 2024 01:27:28 -0400 (EDT)
Received: from pastel (unknown [45.72.201.215])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BB076120283;
Mon, 1 Apr 2024 01:27:28 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in
lisp-interaction-mode
In-Reply-To: <86r0frdgmx.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 30 Mar
2024 15:54:30 +0300")
Message-ID: <jwvil11r6x2.fsf-monnier+emacs@HIDDEN>
References: <878r21jmu2.fsf@HIDDEN> <86a5mgdx5i.fsf@HIDDEN>
<87msqg2d2j.fsf@HIDDEN> <86r0frdgmx.fsf@HIDDEN>
Date: Mon, 01 Apr 2024 01:27:27 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.088 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 70068
Cc: Philip Kaludercic <philipk@HIDDEN>, 70068 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> My thinking was that one never needs to set the variable anyway, since
>> `lisp-interaction-mode' sets `lexical-binding' anyway. Alternatively,
>> one could also modify the patch to check if `lexical-binding' is non-nil?
>
> The latter possibility would be better, I think. Stefan, WDYT?
Testing `lexical-binding` sounds good: the purpose is to encourage people
to activate `lexical-binding`, rather than encourage them to add a magic cookie.
Stefan
bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.Received: (at 70068) by debbugs.gnu.org; 30 Mar 2024 12:54:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 30 08:54:42 2024 Received: from localhost ([127.0.0.1]:44183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rqYEM-0006Sg-DL for submit <at> debbugs.gnu.org; Sat, 30 Mar 2024 08:54:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rqYEK-0006ST-Nb for 70068 <at> debbugs.gnu.org; Sat, 30 Mar 2024 08:54:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rqYED-0003NI-9F; Sat, 30 Mar 2024 08:54:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eWrdfvTl9vBR9ebWtryMX3mJ+NSKwdt0JTK6tIlo+Cw=; b=K1DxXowvRRBc ILBgMxTcBclITBa0oUJMMk2eN5cfHJdvQsIIqJLVnP8Mf6I0awTLdKQyPZ5AVO0qlp/wWNzW+7txO I3ekwPwFzsP5nC60CqwlH9OUexs7xVq9//bGZYmGfG8UcblkhIYFmMjJ+soc3yYvWOSfh0Qvi7cj0 pHD9u5i203EdtMnBBD3yAMD/kJvyBnDborBkktuN9Otw38sdfdumblDeiDLeVTUhlAcFsd0ZD9XLM 3Bo1jqouTYlyCBCPsykbWxmV1QMSReV7Fri6+j36xqsC3oBt/7R7yAAxkUkVC6I8z2tmTnWcgkaxe Fb3qR3hP/eG2bG60muh+Gg==; Date: Sat, 30 Mar 2024 15:54:30 +0300 Message-Id: <86r0frdgmx.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Philip Kaludercic <philipk@HIDDEN> In-Reply-To: <87msqg2d2j.fsf@HIDDEN> (message from Philip Kaludercic on Sat, 30 Mar 2024 11:07:00 +0000) Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode References: <878r21jmu2.fsf@HIDDEN> <86a5mgdx5i.fsf@HIDDEN> <87msqg2d2j.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70068 Cc: Stefan Monnier <monnier@HIDDEN>, 70068 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Philip Kaludercic <philipk@HIDDEN> > Cc: 70068 <at> debbugs.gnu.org > Date: Sat, 30 Mar 2024 11:07:00 +0000 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> From: Philip Kaludercic <philipk@HIDDEN> > >> Date: Fri, 29 Mar 2024 11:31:49 +0000 > >> > >> The main intention here is to avoid underlining the first line in the > >> *scratch* buffer when flymake is enabled: > > > > If this is the goal, why such a general change? Wouldn't it be better > > to special-case *scratch* in Flymake instead? Making such > > generalizations runs the risk of unintended consequences. > > My thinking was that one never needs to set the variable anyway, since > `lisp-interaction-mode' sets `lexical-binding' anyway. Alternatively, > one could also modify the patch to check if `lexical-binding' is non-nil? The latter possibility would be better, I think. Stefan, WDYT?
bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.Received: (at 70068) by debbugs.gnu.org; 30 Mar 2024 11:07:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 30 07:07:16 2024 Received: from localhost ([127.0.0.1]:44069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rqWYN-0006M9-W2 for submit <at> debbugs.gnu.org; Sat, 30 Mar 2024 07:07:16 -0400 Received: from mout02.posteo.de ([185.67.36.66]:51679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <philipk@HIDDEN>) id 1rqWYH-0006L8-Qb for 70068 <at> debbugs.gnu.org; Sat, 30 Mar 2024 07:07:11 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E887B240101 for <70068 <at> debbugs.gnu.org>; Sat, 30 Mar 2024 12:07:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1711796821; bh=Um3RYJtmKdwM9jhwcHyb6FwYk3VUH9ySlWtqutKIMQs=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=enKZSfFeOshw5DArpqPszDYmSbUFbEafZOYtFRMxbScHTQ6mu21QO9inTOv2F60ut YPzhADA9qcTC/a1tkmTkIMRV3N8cpVnUVKxep1qz78QmS1XAGV8zb6J4aCG6kgHr7S RPf5FEeiE6bmS+tuA/4g9L6HW/Q0tQfsuEfp7m7uNhAp652TiIKOaQwk4v5Fku1jGZ Dqp/miicYGZom6ajOWr3u04oRqowjhVREYshe/1hu+Rlas3cx+hv5selqBUoORDMRX DmUqV2dQzLF6E3pCdS54SBxNwD7CK5R5QAWpYrNJZgwfKLYAfrn9gaBwnCxqkgonDs wDr7+P9Jzff4Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4V6Dxd1fL3z6twZ; Sat, 30 Mar 2024 12:07:00 +0100 (CET) From: Philip Kaludercic <philipk@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode In-Reply-To: <86a5mgdx5i.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 30 Mar 2024 09:57:45 +0300") References: <878r21jmu2.fsf@HIDDEN> <86a5mgdx5i.fsf@HIDDEN> OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Sat, 30 Mar 2024 11:07:00 +0000 Message-ID: <87msqg2d2j.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70068 Cc: 70068 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Eli Zaretskii <eliz@HIDDEN> writes: >> From: Philip Kaludercic <philipk@HIDDEN> >> Date: Fri, 29 Mar 2024 11:31:49 +0000 >> >> The main intention here is to avoid underlining the first line in the >> *scratch* buffer when flymake is enabled: > > If this is the goal, why such a general change? Wouldn't it be better > to special-case *scratch* in Flymake instead? Making such > generalizations runs the risk of unintended consequences. My thinking was that one never needs to set the variable anyway, since `lisp-interaction-mode' sets `lexical-binding' anyway. Alternatively, one could also modify the patch to check if `lexical-binding' is non-nil? -- Philip Kaludercic on peregrine
bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.Received: (at 70068) by debbugs.gnu.org; 30 Mar 2024 06:57:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 30 02:57:57 2024 Received: from localhost ([127.0.0.1]:43816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rqSf7-0002Z5-HC for submit <at> debbugs.gnu.org; Sat, 30 Mar 2024 02:57:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rqSf4-0002Yp-Go for 70068 <at> debbugs.gnu.org; Sat, 30 Mar 2024 02:57:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rqSex-0002x1-9I; Sat, 30 Mar 2024 02:57:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YqOd0diyz4gqpMfyOHJFHQVARw+emUtIQkmMV+U8Fno=; b=WKIpoWGyP4CV +RXtmh6YEWfVaFroJ0hJR5zl5BuDvCrCqut+7Xatj31jJ+kQKdo1wudNX/dmV2i5KqtwhxHWScuZd QoOV2HkOXM/Vrtw/L61mAFYHdZV9LPDZugLEBOSEMbHMFmbt5JZ5kHj8Fastr1Y/5d8Dk84RzM0tm OwKuSU1eNrXXtV+t3PkZ5dA3guxVLEhfvEuHZm8d48B9jCw0UNdf9+GrZqo8gg98B4fGLgUqx690R TwY9E+7fLJbG3/COEDY/wDoXA8xW2Z8sSYwVVIOUaon3nrSU8RzLet/6OEJAApyyXemTHtBTNUWdt Bno89vnr1BR/F8huNT0oXg==; Date: Sat, 30 Mar 2024 09:57:45 +0300 Message-Id: <86a5mgdx5i.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Philip Kaludercic <philipk@HIDDEN> In-Reply-To: <878r21jmu2.fsf@HIDDEN> (message from Philip Kaludercic on Fri, 29 Mar 2024 11:31:49 +0000) Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode References: <878r21jmu2.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70068 Cc: 70068 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Philip Kaludercic <philipk@HIDDEN> > Date: Fri, 29 Mar 2024 11:31:49 +0000 > > The main intention here is to avoid underlining the first line in the > *scratch* buffer when flymake is enabled: If this is the goal, why such a general change? Wouldn't it be better to special-case *scratch* in Flymake instead? Making such generalizations runs the risk of unintended consequences.
bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 29 Mar 2024 11:32:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 29 07:32:06 2024
Received: from localhost ([127.0.0.1]:41800 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rqASs-0003pM-Ep
for submit <at> debbugs.gnu.org; Fri, 29 Mar 2024 07:32:06 -0400
Received: from lists.gnu.org ([2001:470:142::17]:59176)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <philipk@HIDDEN>) id 1rqASr-0003os-71
for submit <at> debbugs.gnu.org; Fri, 29 Mar 2024 07:32:05 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <philipk@HIDDEN>)
id 1rqASj-0007pr-5r
for bug-gnu-emacs@HIDDEN; Fri, 29 Mar 2024 07:31:58 -0400
Received: from mout02.posteo.de ([185.67.36.66])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <philipk@HIDDEN>)
id 1rqASg-0002xS-L2
for bug-gnu-emacs@HIDDEN; Fri, 29 Mar 2024 07:31:56 -0400
Received: from submission (posteo.de [185.67.36.169])
by mout02.posteo.de (Postfix) with ESMTPS id AEC33240101
for <bug-gnu-emacs@HIDDEN>; Fri, 29 Mar 2024 12:31:50 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
t=1711711910; bh=ASKbXH5F4V9+XuEHrhtKK8QcNC6KxOxjobE9KHED9Kk=;
h=From:To:Subject:OpenPGP:Date:Message-ID:MIME-Version:Content-Type:
From;
b=W+W8b7BUypHC5aabNEzPjnk3Kguzf/NWEbvAoQmyN0xibndeyYf7i0WO5uPZipu5B
ARwWW1n8iYykjzxwSnKby6sEz8uuCxXL4DzUgK8+WRFbjLZbaI6GmQzBWwyuaEtaPw
Ubf7wbQSDib5PbpyhIl8l1O6UZAkx97Wc4FLMxQKXNy4uLU2yCL/d//8l/9pnLVDrr
XKh9YlMY4tKtftH7hh8A4073NUwSJg9CzQvfZ7A+n7TJtlXXzmp/R2nKnzBlkmc1ph
qsb6CHsLTDSe3MHx/OgnXX5vnH4fM6vD8+pJwggGzb10MPmgbq/kWiM7YeytDgI6wh
HJSJi/SC0rmxw==
Received: from customer (localhost [127.0.0.1])
by submission (posteo.de) with ESMTPSA id 4V5dXk2XcYz9rxF
for <bug-gnu-emacs@HIDDEN>; Fri, 29 Mar 2024 12:31:50 +0100 (CET)
From: Philip Kaludercic <philipk@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Don't warn about lexical binding in lisp-interaction-mode
OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66;
url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66";
preference=signencrypt
Date: Fri, 29 Mar 2024 11:31:49 +0000
Message-ID: <878r21jmu2.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@HIDDEN;
helo=mout02.posteo.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
--=-=-=
Content-Type: text/plain
The main intention here is to avoid underlining the first line in the
*scratch* buffer when flymake is enabled:
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-Don't-warn-about-lexical-binding-in-lisp-interacti.patch
Content-Description: [PATCH] Don't warn about lexical binding in lisp-interaction-mode
From 714cba0f576566e39b7ffeb77b8f9b80bb3003ff Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <philipk@HIDDEN>
Date: Fri, 29 Mar 2024 12:30:59 +0100
Subject: [PATCH] Don't warn about lexical binding in lisp-interaction-mode
* lisp/emacs-lisp/bytecomp.el (byte-compile-file): Suppress
warning in 'lisp-interaction-mode' buffers like the *scratch*
buffer.
---
lisp/emacs-lisp/bytecomp.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 7af568cfe34..e04df8f9ade 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -2234,7 +2234,8 @@ byte-compile-file
(setq buffer-read-only nil
filename buffer-file-name))
;; Don't inherit lexical-binding from caller (bug#12938).
- (unless (local-variable-p 'lexical-binding)
+ (unless (or (local-variable-p 'lexical-binding)
+ (derived-mode-p 'lisp-interaction-mode))
(let ((byte-compile-current-buffer (current-buffer)))
(displaying-byte-compile-warnings
(byte-compile-warn-x
--
2.44.0
--=-=-=
Content-Type: text/plain
--
Philip Kaludercic on peregrine
--=-=-=--
Philip Kaludercic <philipk@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#70068; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.