Package: guix-patches;
Reported by: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
Date: Fri, 29 Mar 2024 16:32:03 UTC
Severity: normal
Tags: patch
Done: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>
To reply to this bug, email your comments to 70078 AT debbugs.gnu.org.
There is no need to reopen the bug first.
Toggle the display of automated, internal messages from the tracker.
View this report as an mbox folder, status mbox, maintainer mbox
guix-patches <at> gnu.org:bug#70078; Package guix-patches.
(Fri, 29 Mar 2024 16:32:03 GMT) Full text and rfc822 format available.Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>:guix-patches <at> gnu.org.
(Fri, 29 Mar 2024 16:32:03 GMT) Full text and rfc822 format available.Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
From: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es> To: guix-patches <at> gnu.org Cc: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es> Subject: [PATCH] gnu: Add stremio. Date: Fri, 29 Mar 2024 17:25:11 +0100
* gnu/packages/video.scm (stremio): New variable.
Change-Id: Ie4c2dc30a0d488e20be21c3802330e993a60df70
---
gnu/packages/video.scm | 105 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 105 insertions(+)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 94334e0c97..e0da7a4874 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -169,6 +169,7 @@ (define-module (gnu packages video)
#:use-module (gnu packages ncurses)
#:use-module (gnu packages nettle)
#:use-module (gnu packages networking)
+ #:use-module (gnu packages node)
#:use-module (gnu packages ocr)
#:use-module (gnu packages pcre)
#:use-module (gnu packages pciutils)
@@ -3751,6 +3752,110 @@ (define-public streamlink
from sites like Twitch.tv and pipes them into a video player of choice.")
(license license:bsd-2)))
+(define-public stremio
+ (define server-js
+ (let ((version "4.20.8"))
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://dl.strem.io/server/v" version
+ "/desktop/server.js"))
+ (file-name (string-append "server-js-" version))
+ (sha256 (base32 "0xmlbx6aib5h78ya369pnpxyn05b12l05i8v2kymijbmaw7j04vi")))))
+ (package
+ (name "stremio")
+ (version "4.4.168")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/Stremio/stremio-shell")
+ (commit (string-append "v" version))
+ (recursive? #t)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "14x9i8qvm19sijh7hqppbk8s14dvv7dqlck7x3s8n9i4xn4ncgd7"))))
+ (build-system qt-build-system)
+ (native-inputs (list librsvg))
+ (inputs (list qtbase-5
+ qtdeclarative-5
+ qtwebchannel-5
+ qtwebengine-5
+ qtquickcontrols-5
+ openssl
+ mpv
+ node))
+ (arguments
+ (list
+ #:tests? #f
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'unpack 'setup-server
+ (lambda _
+ (copy-file #$server-js "server.js")))
+ (add-after 'unpack 'fix-paths
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* "main.qml"
+ (("var node_executable =.*$")
+ (string-append "var node_executable =\""
+ (search-input-file inputs "bin/node")
+ "\"\n"))
+ (("applicationDirPath \\+\"/server\\.js\"")
+ (string-append "\""
+ #$server-js "\"")))
+ (substitute* "smartcode-stremio.desktop"
+ (("Exec=stremio")
+ (string-append "Exec="
+ #$output "/bin/stremio")))))
+ (replace 'configure
+ (lambda _
+ (invoke "qmake")))
+ (replace 'build
+ (lambda _
+ (invoke "make" "-f" "release.makefile"
+ (string-append "PREFIX="
+ #$output))))
+ (replace 'install
+ (lambda _
+ (invoke "make" "-f" "release.makefile" "install"
+ (string-append "PREFIX="
+ #$output))
+ ;; Setup bin dir.
+ (with-directory-excursion #$output
+ (install-file "opt/stremio/stremio" "bin")
+ (install-file "opt/stremio/smartcode-stremio.desktop"
+ "share/applications")
+ ;; Setup icon dir.
+ (for-each (lambda (size)
+ (let ((dir (string-append #$output
+ "/share/icons/hicolor/"
+ size
+ "x"
+ size
+ "/apps")))
+ (mkdir-p dir)
+ (copy-file (string-append
+ "opt/stremio/icons/smartcode-stremio_"
+ size ".png")
+ (string-append dir
+ "/smartcode-stremio.png"))
+ (copy-file (string-append
+ "opt/stremio/icons/smartcode-stremio-tray_"
+ size ".png")
+ (string-append dir
+ "/smartcode-stremio-tray.png"))))
+ '("16" "22" "24" "32" "64" "128"))
+ ;; Remove unnecessary opt dir.
+ (delete-file-recursively "opt")))))))
+ (home-page "https://www.stremio.com")
+ (synopsis "Modern media center that gives you the freedom to watch
+everything you want")
+ (description
+ "Stremio offers a secure, modern and seamless entertainment experience.
+With its easy-to-use interface and diverse content library, including 4K HDR
+support, users can enjoy their favorite movies and TV shows across all their
+devices. And with its commitment to security, Stremio is the ultimate choice
+for a worry-free, high-quality streaming experience.")
+ (license license:expat)))
+
(define-public twitchy
(let ((commit "9beb36d80b16662414129693e74fa3a2fd97554e")) ; 3.4 has no tag
(package
base-commit: 8ed9ce9d0070b854f0aadc6626e624ba2156c112
--
2.41.0
sergio.pastorperez <at> outlook.es, guix-patches <at> gnu.org:bug#70078; Package guix-patches.
(Sat, 05 Apr 2025 18:01:01 GMT) Full text and rfc822 format available.Message #8 received at 70078 <at> debbugs.gnu.org (full text, mbox):
From: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com> To: 70078 <at> debbugs.gnu.org Cc: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com> Subject: [PATCH v2] gnu: Add stremio. Date: Sat, 5 Apr 2025 20:00:00 +0200
* gnu/packages/video.scm (stremio): New variable.
Change-Id: Ie4c2dc30a0d488e20be21c3802330e993a60df70
---
gnu/packages/video.scm | 112 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 112 insertions(+)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 0ddfc022a9..54dfb8ccc9 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -177,6 +177,7 @@ (define-module (gnu packages video)
#:use-module (gnu packages ncurses)
#:use-module (gnu packages nettle)
#:use-module (gnu packages networking)
+ #:use-module (gnu packages node)
#:use-module (gnu packages ocr)
#:use-module (gnu packages pcre)
#:use-module (gnu packages pciutils)
@@ -3844,6 +3845,117 @@ (define-public streamlink
from sites like Twitch.tv and pipes them into a video player of choice.")
(license license:bsd-2)))
+(define-public stremio
+ (define server-js
+ (let ((version "4.20.8"))
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://dl.strem.io/server/v" version
+ "/desktop/server.js"))
+ (file-name (string-append "stremio-server-" version ".js"))
+ (sha256 (base32 "0xmlbx6aib5h78ya369pnpxyn05b12l05i8v2kymijbmaw7j04vi")))))
+ (package
+ (name "stremio")
+ (version "4.4.168")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/Stremio/stremio-shell")
+ (commit (string-append "v" version))
+ ;; NOTE: submodules are embedded libraries so there is no reason
+ ;; to unbundle them.
+ (recursive? #t)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "14x9i8qvm19sijh7hqppbk8s14dvv7dqlck7x3s8n9i4xn4ncgd7"))))
+ (build-system qt-build-system)
+ (arguments
+ (list
+ #:tests? #f
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'setup-server
+ (lambda _
+ (copy-file #$server-js "server.js")))
+ (add-after 'unpack 'fix-paths
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* "CMakeLists.txt"
+ (("opt/stremio")
+ "bin"))
+ (substitute* "release.makefile"
+ (("/opt/stremio")
+ "/bin"))
+ (substitute* "main.qml"
+ (("var node_executable =.*$")
+ (string-append "var node_executable =\""
+ (search-input-file inputs "bin/node") "\"\n"))
+ (("applicationDirPath \\+\"/server\\.js\"")
+ (string-append "\""
+ #$server-js "\"")))
+ (substitute* "smartcode-stremio.desktop"
+ (("Exec=stremio")
+ (string-append "Exec="
+ #$output "/bin/stremio")))))
+ (replace 'configure
+ (lambda _
+ (invoke "qmake")))
+ (replace 'build
+ (lambda _
+ (invoke "make" "-f" "release.makefile"
+ (string-append "PREFIX="
+ #$output))))
+ (replace 'install
+ (lambda _
+ (invoke "make" "-f" "release.makefile" "install"
+ (string-append "PREFIX="
+ #$output))
+ (with-directory-excursion #$output
+ ;; Setup desktop file.
+ (let ((dir "share/applications")
+ (desktop "smartcode-stremio.desktop"))
+ (mkdir-p "share/applications")
+ (copy-file (string-append "bin/" desktop)
+ (string-append dir "/" desktop))
+ (delete-file (string-append "bin/" desktop)))
+ ;; Setup icon dir.
+ (for-each (lambda (size)
+ (let ((dir (string-append "share/icons/hicolor/"
+ size "x" size "/apps")))
+ (mkdir-p dir)
+ (copy-file (string-append
+ "bin/icons/smartcode-stremio_" size
+ ".png")
+ (string-append dir
+ "/smartcode-stremio.png"))
+ (copy-file (string-append
+ "bin/icons/smartcode-stremio-tray_"
+ size ".png")
+ (string-append dir
+ "/smartcode-stremio-tray.png"))))
+ '("16" "22" "24" "32" "64" "128"))
+ ;; Remove unnecessary opt dir.
+ (delete-file-recursively "bin/icons")))))))
+ (inputs (list librsvg
+ mpv
+ node
+ openssl
+ qtdeclarative-5
+ qtquickcontrols-5
+ qtwebchannel-5
+ qtwebengine-5
+ qtbase-5))
+ (home-page "https://www.stremio.com")
+ (synopsis "Modern media center that gives you the freedom to watch
+everything you want")
+ (description
+ "Stremio offers a secure, modern and seamless entertainment experience.
+With its easy-to-use interface and diverse content library, including 4K HDR
+support, users can enjoy their favorite movies and TV shows across all their
+devices. And with its commitment to security, Stremio is the ultimate choice
+for a worry-free, high-quality streaming experience.")
+ (license license:expat)))
+
(define-public twitchy
(let ((commit "9beb36d80b16662414129693e74fa3a2fd97554e")) ; 3.4 has no tag
(package
base-commit: bcfb283cda1b782129c8a70b69d216b925501185
--
2.49.0
guix-patches <at> gnu.org:bug#70078; Package guix-patches.
(Mon, 14 Apr 2025 14:00:01 GMT) Full text and rfc822 format available.Message #11 received at 70078 <at> debbugs.gnu.org (full text, mbox):
From: Andreas Enge <andreas <at> enge.fr> To: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com> Cc: 70078 <at> debbugs.gnu.org Subject: Re: [PATCH v2] gnu: Add stremio. Date: Mon, 14 Apr 2025 15:59:22 +0200
Hello Sergio, since this package passes QA, I had a quick look. Concerning the license, the https://github.com/Stremio/stremio-shell repository links to the GPL version 3, not expat. Normally this means "or later"; unfortunately the source code does not seem to have an explicit license notice specifying gpl3 or gpl3+. So should this package be called stremio or stremio-shell? The binary is called stremio, so I think it makes sense to keep this also as the project name. I also did not find a license for the "embedded" stremio-server-4.20.8.js file; the file itself says /*! For license information please see server.js.LICENSE.txt */ but where is this file? I also found this open issue https://github.com/Stremio/stremio-service/issues/49 which seems to indicate that the code is not free. Andreas
guix-patches <at> gnu.org:bug#70078; Package guix-patches.
(Sat, 19 Apr 2025 10:44:02 GMT) Full text and rfc822 format available.Message #14 received at 70078 <at> debbugs.gnu.org (full text, mbox):
From: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com> To: Andreas Enge <andreas <at> enge.fr> Cc: 70078 <at> debbugs.gnu.org Subject: Re: [PATCH v2] gnu: Add stremio. Date: Sat, 19 Apr 2025 12:43:27 +0200
Hello Andreas, thanks for reviewing my patch. Andreas Enge <andreas <at> enge.fr> writes: > Concerning the license, the https://github.com/Stremio/stremio-shell > repository links to the GPL version 3, not expat. Normally this means > "or later"; unfortunately the source code does not seem to have an > explicit license notice specifying gpl3 or gpl3+. I apologise for the mistake. > So should this package be called stremio or stremio-shell? > The binary is called stremio, so I think it makes sense to keep this > also as the project name. I think "stremio" is the better name. In my opinion, it's more clear for the end user. > I also did not find a license for the "embedded" > stremio-server-4.20.8.js file; the file itself says > /*! For license information please see server.js.LICENSE.txt */ > but where is this file? > I also found this open issue > https://github.com/Stremio/stremio-service/issues/49 > which seems to indicate that the code is not free. I could neither find the license for that file. It's probably an overlooked issue, I think we can probably get in touch with the developers to clarify that. Reading that issue, it seems that they did not have the source code available for the "server.js", which now it is, as you can see[1]. Also this post[2] seem to indicate that the intention of the Stremio developers it to open-source everything. [1] https://dl.strem.io/server/v4.20.8/desktop/server.js [2] https://blog.stremio.com/announcing-stremio-core-embracing-open-source-and-rust Reading that post it seems that the "server.js" should also fall under an open-source license. What do you reckon? Do we need to contact the developers before merging the package? Best regards, Sergio.
guix-patches <at> gnu.org:bug#70078; Package guix-patches.
(Sun, 20 Apr 2025 12:41:02 GMT) Full text and rfc822 format available.Message #17 received at 70078 <at> debbugs.gnu.org (full text, mbox):
From: Divya Ranjan Pattanaik <divya <at> subvertising.org> To: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com> Cc: 70078 <at> debbugs.gnu.org, Andreas Enge <andreas <at> enge.fr> Subject: Re: [bug#70078] [PATCH v2] gnu: Add stremio. Date: Sun, 20 Apr 2025 12:40:44 +0000
Hello Sergio and Andreas, >> I also did not find a license for the "embedded" >> stremio-server-4.20.8.js file; the file itself says >> /*! For license information please see server.js.LICENSE.txt */ >> but where is this file? >> I also found this open issue >> https://github.com/Stremio/stremio-service/issues/49 >> which seems to indicate that the code is not free. > > I could neither find the license for that file. It's probably an > overlooked issue, I think we can probably get in touch with the > developers to clarify that. Reading that issue, it seems that they did > not have the source code available for the "server.js", which now it is, > as you can see[1]. > > Also this post[2] seem to indicate that the intention of the Stremio > developers it to open-source everything. > > [1] https://dl.strem.io/server/v4.20.8/desktop/server.js > [2] > https://blog.stremio.com/announcing-stremio-core-embracing-open-source-and-rust > > Reading that post it seems that the "server.js" should also fall under > an open-source license. > > What do you reckon? Do we need to contact the developers before merging > the package? I concur with Sergio, the server.js has been available now and the announcement post does make it clear that it is "open-source". Now of course we need a license to make it clear if it’s libre (GPL-compatible) or not. We should contact the developers for that. But I think it is GPL-compatible, since if you look at the flatpak of Stremio[0] it says that GPL-3.0-or-later. So I don’t think there’s much to worry, we should double check it from the devs and then go forward in adding it. Stremio is a godsend for people who torrent and self-host their media content. [0]: https://flathub.org/apps/com.stremio.Stremio Regards, -- Divya Ranjan, Philosophy, Mathematics, Libre Software. PGP Fingerprint: F0B3 1A69 8006 8FB8 096A 2F12 B245 10C6 108C 8D4A
guix-patches <at> gnu.org:bug#70078; Package guix-patches.
(Tue, 29 Apr 2025 18:34:02 GMT) Full text and rfc822 format available.Message #20 received at 70078 <at> debbugs.gnu.org (full text, mbox):
From: Andreas Enge <andreas <at> enge.fr> To: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com> Cc: 70078 <at> debbugs.gnu.org, Divya Ranjan Pattanaik <divya <at> subvertising.org> Subject: Re: [PATCH v2] gnu: Add stremio. Date: Tue, 29 Apr 2025 20:33:14 +0200
Hello, Am Sat, Apr 19, 2025 at 12:43:27PM +0200 schrieb Sergio Pastor Pérez: > I think "stremio" is the better name. In my opinion, it's more clear for > the end user. okay, good with me. > > I also did not find a license for the "embedded" > > stremio-server-4.20.8.js file; the file itself says > > /*! For license information please see server.js.LICENSE.txt */ > > but where is this file? > > I also found this open issue > > https://github.com/Stremio/stremio-service/issues/49 > > which seems to indicate that the code is not free. > I could neither find the license for that file. It's probably an > overlooked issue, I think we can probably get in touch with the > developers to clarify that. Reading that issue, it seems that they did > not have the source code available for the "server.js", which now it is, > as you can see[1]. > Also this post[2] seem to indicate that the intention of the Stremio > developers it to open-source everything. > [1] https://dl.strem.io/server/v4.20.8/desktop/server.js > [2] > https://blog.stremio.com/announcing-stremio-core-embracing-open-source-and-rust > Reading that post it seems that the "server.js" should also fall under > an open-source license. > What do you reckon? Do we need to contact the developers before merging > the package? This all seems to be a bit vague. There is this press release [2] from 2019 that makes announcements like "Stremio-core will be open-source too, and licensed under the permissive MIT license.", but such a declaration of intentions does not mean that anything *is* actually published under such a license. (And for instance, the expat vs. gpl3 question shows the discrepancy between announcements and reality.) On the other hand, there is the issue https://github.com/Stremio/stremio-service/issues/49 from 2023 in which the "lead dev" arguments that some parts of the code are and should remain proprietary. It may just be an oversight, and the hint towards a license file at the top of server.js is an indication of that, but we cannot be sure and do not have this license file. So my opinion is that as long as we have no proofs of a free license, this package has to be considered proprietary and cannot be added to Guix. Maybe you could bring this up with the developers and have them add a license statement, or a link to such a statement, in the server.js file. Andreas
guix-patches <at> gnu.org:bug#70078; Package guix-patches.
(Thu, 01 May 2025 09:16:02 GMT) Full text and rfc822 format available.Message #23 received at 70078 <at> debbugs.gnu.org (full text, mbox):
From: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com> To: Andreas Enge <andreas <at> enge.fr> Cc: 70078 <at> debbugs.gnu.org, Divya Ranjan Pattanaik <divya <at> subvertising.org> Subject: Re: [PATCH v2] gnu: Add stremio. Date: Thu, 01 May 2025 11:15:41 +0200
Andreas Enge <andreas <at> enge.fr> writes: > This all seems to be a bit vague. There is this press release [2] from > 2019 that makes announcements like "Stremio-core will be open-source too, > and licensed under the permissive MIT license.", but such a declaration > of intentions does not mean that anything *is* actually published under > such a license. (And for instance, the expat vs. gpl3 question shows the > discrepancy between announcements and reality.) > > On the other hand, there is the issue > https://github.com/Stremio/stremio-service/issues/49 > from 2023 in which the "lead dev" arguments that some parts of the code > are and should remain proprietary. > > It may just be an oversight, and the hint towards a license file at the > top of server.js is an indication of that, but we cannot be sure and do > not have this license file. > > So my opinion is that as long as we have no proofs of a free license, > this package has to be considered proprietary and cannot be added to > Guix. Maybe you could bring this up with the developers and have them > add a license statement, or a link to such a statement, in the server.js > file. Alright, I've opened an issue in their Github page[1]. Let's see if they can clarify the license for us. [1] https://github.com/Stremio/stremio-shell/issues/435
Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com>:Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>:Message #28 received at 70078-close <at> debbugs.gnu.org (full text, mbox):
From: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com> To: Andreas Enge <andreas <at> enge.fr> Cc: 70078-close <at> debbugs.gnu.org, Divya Ranjan Pattanaik <divya <at> subvertising.org> Subject: Re: [PATCH v2] gnu: Add stremio. Date: Thu, 01 May 2025 12:15:13 +0200
Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com> writes: > Andreas Enge <andreas <at> enge.fr> writes: >> This all seems to be a bit vague. There is this press release [2] from >> 2019 that makes announcements like "Stremio-core will be open-source too, >> and licensed under the permissive MIT license.", but such a declaration >> of intentions does not mean that anything *is* actually published under >> such a license. (And for instance, the expat vs. gpl3 question shows the >> discrepancy between announcements and reality.) >> >> On the other hand, there is the issue >> https://github.com/Stremio/stremio-service/issues/49 >> from 2023 in which the "lead dev" arguments that some parts of the code >> are and should remain proprietary. >> >> It may just be an oversight, and the hint towards a license file at the >> top of server.js is an indication of that, but we cannot be sure and do >> not have this license file. >> >> So my opinion is that as long as we have no proofs of a free license, >> this package has to be considered proprietary and cannot be added to >> Guix. Maybe you could bring this up with the developers and have them >> add a license statement, or a link to such a statement, in the server.js >> file. > > Alright, I've opened an issue in their Github page[1]. Let's see if they > can clarify the license for us. > > [1] https://github.com/Stremio/stremio-shell/issues/435 I've got a reply and seems Andreas was right distrusting the licensing. According to the developers 'server.js' is proprietary software[1] [1] https://github.com/Stremio/stremio-shell/issues/435#issuecomment-2844471402 -- Closing this issue due to the package not following Guix guidelines.
guix-patches <at> gnu.org:bug#70078; Package guix-patches.
(Thu, 01 May 2025 10:27:02 GMT) Full text and rfc822 format available.Message #31 received at 70078 <at> debbugs.gnu.org (full text, mbox):
From: Andreas Enge <andreas <at> enge.fr> To: Sergio Pastor Pérez <sergio.pastorperez <at> gmail.com> Cc: 70078 <at> debbugs.gnu.org, Divya Ranjan Pattanaik <divya <at> subvertising.org> Subject: Re: [PATCH v2] gnu: Add stremio. Date: Thu, 1 May 2025 12:26:35 +0200
Hello Sergio, Am Thu, May 01, 2025 at 12:15:13PM +0200 schrieb Sergio Pastor Pérez: > I've got a reply and seems Andreas was right distrusting the > licensing. According to the developers 'server.js' is proprietary > software[1] > https://github.com/Stremio/stremio-shell/issues/435#issuecomment-2844471402 thanks for following up! The logic behind using free software to "only wrap" non-free software, so that the combined work becomes non-distributable by third parties, is strange, but their decision to make. Andreas
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.