GNU logs - #70136, boring messages

Message sent to spacibba@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#70136: 30.0.50; comint-mode doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Augusto Stoffel <arstoffel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: spacibba@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 02 Apr 2024 05:56:02 +0000
Resent-Message-ID: <handler.70136.B.171203730417862 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 70136 <at> debbugs.gnu.org
Cc: Ergus <spacibba@HIDDEN>
From: Augusto Stoffel <arstoffel@HIDDEN>
Date: Tue, 02 Apr 2024 07:54:46 +0200
Message-ID: <87zfuc48d5.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2a00:1450:4864:20::129;
 envelope-from=arstoffel@HIDDEN; helo=mail-lf1-x129.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

This would be sometimes useful, and more consistent with other modes like
dired and diff.  Is there any reason to not do it?

Ergus: I've cc'ed you because this is potentially related to your recent
discussion in emacs-devel about "out of sources compilation"
(compilation buffers use comint-mode).

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Augusto Stoffel <arstoffel@HIDDEN>
Subject: bug#70136: Acknowledgement (30.0.50; comint-mode doesn't call
 hack-dir-local-variables-non-file-buffer)
Message-ID: <handler.70136.B.171203730417862.ack <at> debbugs.gnu.org>
References: <87zfuc48d5.fsf@HIDDEN>
X-Gnu-PR-Message: ack 70136
X-Gnu-PR-Package: emacs
Reply-To: 70136 <at> debbugs.gnu.org
Date: Tue, 02 Apr 2024 05:56:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Ergus <spacibba@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 70136 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
70136: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70136
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#70136: 30.0.50; comint-mode doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 02 Apr 2024 12:00:02 +0000
Resent-Message-ID: <handler.70136.B70136.171205914920530 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Augusto Stoffel <arstoffel@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, spacibba@HIDDEN
Date: Tue, 02 Apr 2024 14:58:45 +0300
Message-Id: <86msqc9dsa.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87zfuc48d5.fsf@HIDDEN> (message from Augusto Stoffel on Tue, 
 02 Apr 2024 07:54:46 +0200)
References: <87zfuc48d5.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Cc: Ergus <spacibba@HIDDEN>
> From: Augusto Stoffel <arstoffel@HIDDEN>
> Date: Tue, 02 Apr 2024 07:54:46 +0200
> 
> This would be sometimes useful, and more consistent with other modes like
> dired and diff.  Is there any reason to not do it?

It doesn't sound right to me to do that by default, since comint is
used for shell-like interpreters, and those tend to change directories
at will.  Which means that dir-locals for some random directory
doesn't necessarily take such modes into consideration.

If you need that for some particular use case, can't you call it from
comint-mode-hook or something?

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#70136: 30.0.50; comint-mode doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Augusto Stoffel <arstoffel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 02 Apr 2024 14:04:01 +0000
Resent-Message-ID: <handler.70136.B70136.171206661624277 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, spacibba@HIDDEN
From: Augusto Stoffel <arstoffel@HIDDEN>
In-Reply-To: <86msqc9dsa.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 02 Apr
 2024 14:58:45 +0300")
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
Date: Tue, 02 Apr 2024 16:03:23 +0200
Message-ID: <874jcjeuac.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On Tue,  2 Apr 2024 at 14:58, Eli Zaretskii wrote:

> It doesn't sound right to me to do that by default, since comint is
> used for shell-like interpreters, and those tend to change directories
> at will.  Which means that dir-locals for some random directory
> doesn't necessarily take such modes into consideration.

This observation makes sense, but it mostly applies to the good old
'M-x shell', not to 'M-x project-shell', other language interpreters, or
to compilation buffers.

By the way, I now realize that 'M-x compile' doesn't use comint-mode
by default.  Which raises the same question: should compilation-mode
call hack-dir-local-variables-non-file-buffer?

> If you need that for some particular use case, can't you call it from
> comint-mode-hook or something?

Sure, it's an easy customization, but the question is whether it's the
expected default behavior. :-)

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; comint-mode doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 02 Apr 2024 15:12:01 +0000
Resent-Message-ID: <handler.70136.B70136.171207069716795 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Augusto Stoffel <arstoffel@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, spacibba@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171207069716795
          (code B ref 70136); Tue, 02 Apr 2024 15:12:01 +0000
Received: (at 70136) by debbugs.gnu.org; 2 Apr 2024 15:11:37 +0000
Received: from localhost ([127.0.0.1]:54973 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rrfnU-0004Mo-HC
	for submit <at> debbugs.gnu.org; Tue, 02 Apr 2024 11:11:37 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:38446)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rrfnR-0004Ly-Tq
 for 70136 <at> debbugs.gnu.org; Tue, 02 Apr 2024 11:11:35 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rrfnI-00037v-Lo; Tue, 02 Apr 2024 11:11:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=qZDgJJoW1mQpDXHYj4xH3lIAEPt8KjxfR+Re3QyIPjA=; b=d6P7WGgAMh/t
 0WKHCmFHZ0wNPJE73d9QWK6fKp1C0QUhKVv2ZTo23r6K1zrcRTnoFD16Gnngq/pmGvZ8AuI5BN+SC
 av9wdSvPviaYbHfN+xEu+/b+vQJTKLLifLLNq07jgOxfkH9IF339uA8q0pjEpJe2gdgSXfC9K+MvW
 27ImGvEDxFE/atgnyRtUJgRjvQwX5SUJcLmpXPsepEBVOr8IVMPFZ3q3uvkFf7wW+tGdJ20YGwMCP
 ZQv/F1GLwI+DsGqYAyiwtTtOroDuOi4EGz4CxUxkAUn5Q5E/LDBifGEd3B0XBv7l7R3GbP2MhC1O6
 bzc2wYW/bRSN+NN3WNdx/w==;
Date: Tue, 02 Apr 2024 18:11:22 +0300
Message-Id: <86edbnajfp.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <874jcjeuac.fsf@HIDDEN> (message from Augusto Stoffel on Tue, 
 02 Apr 2024 16:03:23 +0200)
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Augusto Stoffel <arstoffel@HIDDEN>
> Cc: 70136 <at> debbugs.gnu.org,  spacibba@HIDDEN
> Date: Tue, 02 Apr 2024 16:03:23 +0200
> 
> By the way, I now realize that 'M-x compile' doesn't use comint-mode
> by default.  Which raises the same question: should compilation-mode
> call hack-dir-local-variables-non-file-buffer?

Maybe.  What kind of directory-specific variables relevant to
compilation-mode would make sense?

> > If you need that for some particular use case, can't you call it from
> > comint-mode-hook or something?
> 
> Sure, it's an easy customization, but the question is whether it's the
> expected default behavior. :-)

The only way to answer that is if we see a flood of requests to have
that by default.  Without that, local customizations are perfectly
adequate.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; comint-mode doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Augusto Stoffel <arstoffel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 14 Apr 2024 09:18:04 +0000
Resent-Message-ID: <handler.70136.B70136.171308623918979 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, spacibba@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171308623918979
          (code B ref 70136); Sun, 14 Apr 2024 09:18:04 +0000
Received: (at 70136) by debbugs.gnu.org; 14 Apr 2024 09:17:19 +0000
Received: from localhost ([127.0.0.1]:34287 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rvvzB-0004vm-8x
	for submit <at> debbugs.gnu.org; Sun, 14 Apr 2024 05:17:18 -0400
Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:45323)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arstoffel@HIDDEN>) id 1rvvz1-0004tk-Vo
 for 70136 <at> debbugs.gnu.org; Sun, 14 Apr 2024 05:17:14 -0400
Received: by mail-ed1-x533.google.com with SMTP id
 4fb4d7f45d1cf-56e1f3462caso2548156a12.3
 for <70136 <at> debbugs.gnu.org>; Sun, 14 Apr 2024 02:16:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1713086211; x=1713691011; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=+cZdrY/DE5QYzu0VSH9tZwj81t+d4UgnJ4NUkm9rIXI=;
 b=ljQ08UiuKaLrPYCeZ2Bb3s9vjroq3sHJRA6b2PWG/zsm26hbaP9nsBu84xUDLmXWmd
 EGSRkMxZ233ry1fi76Pu/h9/YjS12tV/fe8sGlPbWReds11+GDRzg46H6ZRyjPZPH6DD
 uGTufOUiSLXD8h+VAzy/udKMaXyrPu4AFMPwOhC1D+JzGVONKTXJGgD/sfVKh1wP5VHp
 UVK0ZJu03caCOg++Oi9a5WSNCZHAKNr1i3W+dknKmZWJjui2UCAZsbTA6JZyG09fdqOc
 o2kbH0iIAyGU25+slE/Guajhoj+rPTUTGyLJbzPI3BjuGZsbW35b2E8PdC1qqBrstrtK
 fsIg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1713086211; x=1713691011;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=+cZdrY/DE5QYzu0VSH9tZwj81t+d4UgnJ4NUkm9rIXI=;
 b=Z3C3d4cSsulLU8LEa4mfzPe8BV+wHwNNHamKQav/0FkHHLh3AJMcU09uy5LOoA90Jl
 IUgsvT/X8eGy9AdvX9104QODlbSsIwlKtZCazNpPJNawtyfEZO5bwSc0DnhtMlDcOy1q
 Ai57TmRUyGh917JZnFC+KOMK9xbJ+l1F8K3a+fPOhI2GoYajS2aaZbavLDYowbjSldEi
 bSewu5W/2Xxm01JGiW+ZFUh9Xa3O8tVo7dsU1XkIJtNs9oK8p6xLqpM+VFSoeHL/NQBB
 QWJav+BSfM1f/BCINdiVDXIw9fy8RzNdQ9S9TOL578fyyPoAZ+5fH1eqbBD57estCczF
 OPyA==
X-Gm-Message-State: AOJu0YwixUf0AUkTZVyqk05SiEYsGkBI70r+jILXdW3HW8e9VCTeLkT3
 ijUP/CFbLjzbslSzSJt60sn5IfxNry1rocstRlU/4TftmS6TstBu
X-Google-Smtp-Source: AGHT+IGlYFfWIz3ebQkyXTQOhGXjWp9vYjBh7YkNDnJqoT/08AwoG0moS721vYvLW/XXwJ4HOrqNcw==
X-Received: by 2002:a50:cd82:0:b0:56e:2e17:a3d1 with SMTP id
 p2-20020a50cd82000000b0056e2e17a3d1mr5699166edi.25.1713086210796; 
 Sun, 14 Apr 2024 02:16:50 -0700 (PDT)
Received: from ars3 ([2a02:8109:8a87:ff00::6223])
 by smtp.gmail.com with ESMTPSA id
 b11-20020aa7c6cb000000b0056e7ba0497dsm3441492eds.28.2024.04.14.02.16.49
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 14 Apr 2024 02:16:50 -0700 (PDT)
From: Augusto Stoffel <arstoffel@HIDDEN>
In-Reply-To: <86edbnajfp.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 02 Apr
 2024 18:11:22 +0300")
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
Date: Sun, 14 Apr 2024 11:16:48 +0200
Message-ID: <87r0f8cni7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Tue,  2 Apr 2024 at 18:11, Eli Zaretskii wrote:

> Maybe.  What kind of directory-specific variables relevant to
> compilation-mode would make sense?

There are some many.  To say just the first that comes to mind:
compilation-error-regexp-alist.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Augusto Stoffel <arstoffel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 14 Apr 2024 09:28:03 +0000
Resent-Message-ID: <handler.70136.B70136.171308687025175 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171308687025175
          (code B ref 70136); Sun, 14 Apr 2024 09:28:03 +0000
Received: (at 70136) by debbugs.gnu.org; 14 Apr 2024 09:27:50 +0000
Received: from localhost ([127.0.0.1]:34308 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rvw9O-0006Xv-Au
	for submit <at> debbugs.gnu.org; Sun, 14 Apr 2024 05:27:50 -0400
Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]:58614)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arstoffel@HIDDEN>) id 1rvw9M-0006Wl-J3
 for 70136 <at> debbugs.gnu.org; Sun, 14 Apr 2024 05:27:49 -0400
Received: by mail-ej1-x62b.google.com with SMTP id
 a640c23a62f3a-a5200202c1bso269934766b.0
 for <70136 <at> debbugs.gnu.org>; Sun, 14 Apr 2024 02:27:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1713086852; x=1713691652; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=jstUUaQFYxoyRPplHgVYsT8sNGbyTxI8zUWVImqcJcw=;
 b=FyJfGDGv6StUHvuA2oTsmNqPyc8diN51cHbne+o6qbSqwFJleDoX4NvrPUkXKx1qHj
 vkskUK3hefsODJvsMLziX1xsSHGt1ZvJOVoo7MeAb2UgfkR5q0p0paEPscxl+5NRTO7F
 PvS2BRRmYf13r5HFg5IKUzSj8EZjWjQ7d2UYhwqLJCeUYtoUJPTGpILbeAm9CffdFsXq
 7h07RRSqZQNMRuLXcdEOqk/UFfBKC5h0SCgOxAs3QUMhWpQLzaVDmWa8Hj9wPmWXWFhH
 YJwiMrMS99gFmDFCoNRE6lhT4Vr3WvsM31eApNw+EUJPXYh48/PCqSQWHRPoTle3Wf5r
 wXZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1713086852; x=1713691652;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=jstUUaQFYxoyRPplHgVYsT8sNGbyTxI8zUWVImqcJcw=;
 b=Z0IiCrZdqAGKORb4Le7oTTfOHwvYyiKJ5b6rEKlLNig7DwA1sJE7vH2cKFPa4BKLbV
 esxbdX3WgqXY0kQCYakWUjD02UjEczMqWjdnZoANrC6RNtLHkc9+6JbJJdS1+fxftX5j
 HBSTM67PsSmqrp6O+4AdRetM0EP2CqF/0//XlPhYrMigI4It4+QvpKIHIzwAOzHMjiJy
 ZyNzDy8NsgmYM7zzcPzM1A44t3om5Yk/LztmF7fIgsHFVeinN40xsYDVF5IjNA6AzhBi
 b0lUtqKbwHkyXpwLPFH6nKGiL52U7lXioauu0TxN7hRzZ++mmBSDwc0qnRGRLzL/vf1o
 3R4A==
X-Gm-Message-State: AOJu0YzhePTifFQ26D+7kVzlbBD1NGNRZCDZNRUTH6dOHYXJr+nSXhoJ
 lHAZSnORdCnQDCC5yXwhhwv5TBPXZSQTH0bMCs93/+GfWGzEEBeR
X-Google-Smtp-Source: AGHT+IHoqWZVz5RDyhmCSXfHTwOv/TfN9zaPu1AABVyTaTZUMcMVcCgFKXgVJE+vx3N3KgrythUcPQ==
X-Received: by 2002:a17:906:d142:b0:a52:5e79:7970 with SMTP id
 br2-20020a170906d14200b00a525e797970mr850693ejb.15.1713086851521; 
 Sun, 14 Apr 2024 02:27:31 -0700 (PDT)
Received: from ars3 ([2a02:8109:8a87:ff00::6223])
 by smtp.gmail.com with ESMTPSA id
 go36-20020a1709070da400b00a51fea47897sm3980439ejc.214.2024.04.14.02.27.29
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 14 Apr 2024 02:27:29 -0700 (PDT)
From: Augusto Stoffel <arstoffel@HIDDEN>
In-Reply-To: <86edbnajfp.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 02 Apr
 2024 18:11:22 +0300")
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
Date: Sun, 14 Apr 2024 11:27:28 +0200
Message-ID: <87mspwcn0f.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain

Since compilation buffers go as far as to print the directory they're
running on at the top of the buffer, I think it's pretty clear they
should receive dir-local variables.

So I'd suggest the attached patch, which does that and also removes a
more limited mechanism I added some time ago to allow compilation with
project-specific settings.  I've CC'ed Stefan since at the time he kind
of supported the changes I'm now suggesting to remove.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Add-dir-local-variables-to-compilation-buffers.patch

From e29f1849c278ebf55aa67470b5f35263ecf989f3 Mon Sep 17 00:00:00 2001
From: Augusto Stoffel <arstoffel@HIDDEN>
Date: Sun, 14 Apr 2024 11:07:02 +0200
Subject: [PATCH] Add dir-local variables to compilation buffers

* lisp/progmodes/compile.el (compilation-mode): Arrange for dir-local
variables to be hacked into to non-file compilation buffers.
(compilation-start): Remove a less flexible solution to set up the
compilation environment (cf. discussion in bug#50607).
---
 lisp/progmodes/compile.el | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index b18eb81fee1..f81c1edb8c3 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -1929,9 +1929,6 @@ compilation-start
 	    (replace-regexp-in-string "-mode\\'" "" (symbol-name mode))))
 	 (thisdir default-directory)
 	 (thisenv compilation-environment)
-         (buffer-path (and (local-variable-p 'exec-path) exec-path))
-         (buffer-env (and (local-variable-p 'process-environment)
-                          process-environment))
 	 outwin outbuf)
     (with-current-buffer
 	(setq outbuf
@@ -2004,12 +2001,6 @@ compilation-start
         ;; NB: must be done after (funcall mode) as that resets local variables
         (setq-local compilation-directory thisdir)
         (setq-local compilation-environment thisenv)
-        (if buffer-path
-            (setq-local exec-path buffer-path)
-          (kill-local-variable 'exec-path))
-        (if buffer-env
-            (setq-local process-environment buffer-env)
-          (kill-local-variable 'process-environment))
 	(if highlight-regexp
             (setq-local compilation-highlight-regexp highlight-regexp))
         (if (or compilation-auto-jump-to-first-error
@@ -2372,6 +2363,11 @@ compilation-mode
   ;; some other input event happens.
   (setq-local jit-lock-defer-time nil)
   (setq buffer-read-only t)
+  (unless (buffer-file-name)
+    (let ((sym (make-symbol "hack-dir-local-variables-non-file-buffer")))
+      (set sym #'hack-dir-local-variables-non-file-buffer)
+      ;; Ensure hack-dir-locals is called only after a derived mode is set.
+      (push sym delayed-mode-hooks)))
   (run-mode-hooks 'compilation-mode-hook))
 
 ;;;###autoload
-- 
2.44.0


--=-=-=--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; comint-mode doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 14 Apr 2024 10:10:15 +0000
Resent-Message-ID: <handler.70136.B70136.171308937417592 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Augusto Stoffel <arstoffel@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, spacibba@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171308937417592
          (code B ref 70136); Sun, 14 Apr 2024 10:10:15 +0000
Received: (at 70136) by debbugs.gnu.org; 14 Apr 2024 10:09:34 +0000
Received: from localhost ([127.0.0.1]:34364 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rvwnf-0004ZC-F7
	for submit <at> debbugs.gnu.org; Sun, 14 Apr 2024 06:09:32 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:47432)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rvwnU-0004Wj-B7
 for 70136 <at> debbugs.gnu.org; Sun, 14 Apr 2024 06:09:22 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rvwnC-00069T-UK; Sun, 14 Apr 2024 06:08:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=tfeSRfEvvAShLxK7tAZtssGaHqOXpsdJPfg/B1QRZG0=; b=oTxv7hrYwoAg
 n/8EBf6J6qUAjC77xQ9wpUKfMYIibWeUF/6TIKgx8gaRLHWXdIm0Nqdjy5snEcqW3u3dIemKTB/Ne
 xwKBJ4I6aVUz63ulc+DFS+rzvDU+AF+V9FmedGJZgPVL87Re8woN4tpMhPj2HPkeJaSRgwmuvdPzD
 wRwfKKiWdizfDURAnh7GoClhK6Q7fJ06/8Oct8uP9dzG9/QSIOAn1w5XEP2qSC8r+grI6POEL36Bt
 3gXHza2NF+8CMAzjVLOaFlz9EGrXzDTOdBXQYRcElI7k07b4qotzbGYsHs8WyhigcQvUc2akWCFFb
 REZ1gvdb71TNl6cDPTbTHQ==;
Date: Sun, 14 Apr 2024 13:08:55 +0300
Message-Id: <86zftwmf2g.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87r0f8cni7.fsf@HIDDEN> (message from Augusto Stoffel on Sun, 
 14 Apr 2024 11:16:48 +0200)
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN> <87r0f8cni7.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Augusto Stoffel <arstoffel@HIDDEN>
> Cc: 70136 <at> debbugs.gnu.org,  spacibba@HIDDEN
> Date: Sun, 14 Apr 2024 11:16:48 +0200
> 
> On Tue,  2 Apr 2024 at 18:11, Eli Zaretskii wrote:
> 
> > Maybe.  What kind of directory-specific variables relevant to
> > compilation-mode would make sense?
> 
> There are some many.  To say just the first that comes to mind:
> compilation-error-regexp-alist.

I must say this is not very convincing.

What bothers me is that .dir-locals.el in a directory is not meant for
compilation-mode and similar modes, so settings there that are not
specific to modes could get in the way in *compilation* and "grep*
buffers.  But if this is optional behavior, by default off, I don't
think I'd mind.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 14 Apr 2024 10:23:06 +0000
Resent-Message-ID: <handler.70136.B70136.171309014024764 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Augusto Stoffel <arstoffel@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, monnier@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171309014024764
          (code B ref 70136); Sun, 14 Apr 2024 10:23:06 +0000
Received: (at 70136) by debbugs.gnu.org; 14 Apr 2024 10:22:20 +0000
Received: from localhost ([127.0.0.1]:34397 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rvx03-0006Qc-6E
	for submit <at> debbugs.gnu.org; Sun, 14 Apr 2024 06:22:18 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:46956)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rvwzv-0006Om-Hb
 for 70136 <at> debbugs.gnu.org; Sun, 14 Apr 2024 06:22:11 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rvwzd-0008WV-JH; Sun, 14 Apr 2024 06:21:50 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=RohSRsRfHcUJ8p3Sjo5ddQby1nINj3EeOuOA8u3YF14=; b=Z7dsVNOX6y6M
 YeBXdRMkFRuj9Gj44MJffWQHDtOJKWKD1MolTk7Q704FPvSKO12j1VE0bDICzJSNXKCpbLusTSzBI
 GSmNAF+7FMbdUnHlCAXW6J0BzvBHBRezcpmroDRwRoxNB8WrKM64rLzNQj/VuxwE2GMXHv7d3MH16
 /W7Or+9Dob1HTrHa86pAJtdXtbd/GZipFcFstJusBvuLwTGiUhSXW0aF8+Kf5vyoYLDJS+fYPlyr4
 y47z0Bo8XK9QJUuk7VGhuzqq0UKdkxrbL1+mVbOpwz1Pvu1cylt2QlASEqa0Pp5vEOGayshvFoaiH
 X3Sz1/KEDt3XPNvQZYLOuQ==;
Date: Sun, 14 Apr 2024 13:21:47 +0300
Message-Id: <86v84kmeh0.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87mspwcn0f.fsf_-_@HIDDEN> (message from Augusto Stoffel on
 Sun, 14 Apr 2024 11:27:28 +0200)
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Augusto Stoffel <arstoffel@HIDDEN>
> Cc: 70136 <at> debbugs.gnu.org,  Stefan Monnier <monnier@HIDDEN>
> Date: Sun, 14 Apr 2024 11:27:28 +0200
> 
> Since compilation buffers go as far as to print the directory they're
> running on at the top of the buffer, I think it's pretty clear they
> should receive dir-local variables.
> 
> So I'd suggest the attached patch, which does that and also removes a
> more limited mechanism I added some time ago to allow compilation with
> project-specific settings.  I've CC'ed Stefan since at the time he kind
> of supported the changes I'm now suggesting to remove.

Thanks, but I think this should be optional behavior, by default off,
because it could cause trouble in directory trees which already have
.dir-locals.el that were not intended to affect compilation-mode (and
its descendants, like Grep).

Also, this needs a NEWS entry, I think.

> +  (unless (buffer-file-name)
> +    (let ((sym (make-symbol "hack-dir-local-variables-non-file-buffer")))
> +      (set sym #'hack-dir-local-variables-non-file-buffer)
> +      ;; Ensure hack-dir-locals is called only after a derived mode is set.
> +      (push sym delayed-mode-hooks)))

Why such a complicated way of using the symbol of a function that's
defined in a preloaded Lisp file?  Am I missing some subtlety here?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Augusto Stoffel <arstoffel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 15 Apr 2024 17:11:01 +0000
Resent-Message-ID: <handler.70136.B70136.171320103024876 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, monnier@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171320103024876
          (code B ref 70136); Mon, 15 Apr 2024 17:11:01 +0000
Received: (at 70136) by debbugs.gnu.org; 15 Apr 2024 17:10:30 +0000
Received: from localhost ([127.0.0.1]:38396 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rwPqe-0006Sz-Nt
	for submit <at> debbugs.gnu.org; Mon, 15 Apr 2024 13:10:30 -0400
Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:44196)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arstoffel@HIDDEN>) id 1rwPqb-0006SI-MG
 for 70136 <at> debbugs.gnu.org; Mon, 15 Apr 2024 13:10:27 -0400
Received: by mail-ed1-x529.google.com with SMTP id
 4fb4d7f45d1cf-57013379e17so1987846a12.0
 for <70136 <at> debbugs.gnu.org>; Mon, 15 Apr 2024 10:10:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1713201008; x=1713805808; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=+JbVqhUhdUIE/lrB7eTlgVj5SXnWsiX2jm5m/4tMP+Q=;
 b=VFX4FBxeFnb1NBXhgPf8acS8wjSp02lz9U3zD4BbEjvs7I/cJut7h6AuhOGq8RxxuL
 UIfD61NvHk8rpneVsyowfz89yUSBSWVHCNGqZ6/gyLEd0eeiO1b2SoJw4LB5uLi1xy95
 tLzSTqWmrnmS4ul1SUGu5shh4SG7GMjpjEM+nc2TCEjmM2XYE5MhRhYCRfS3uz0r9xb3
 zS9ziCigfmf4KohCh6YOUoYn/GNRbgtzNOYsq8r3wZ7FYhMtHjZUl3APaKd0L1WLpd7C
 eINxFKeHJ/NXVwkqgl2cy0Z3ZrHpj3iaH+doRpdasnU9zhD5xEg+/GoxZ7TveXA7g431
 jkZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1713201008; x=1713805808;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=+JbVqhUhdUIE/lrB7eTlgVj5SXnWsiX2jm5m/4tMP+Q=;
 b=JUCTgEHVK443wJaxO+hfDlCsVZOIea/wpgCnl01uy0I7zGQuuFJLp3fQw/6+V006SV
 6Jz7bJpMSCBR2P0KmbpwG69PtfRLKWCTmv+vwAWaHgZQPrL0EE5RJnotIk56u5RpeSi5
 9cX4IbxVpJFc/uhTiZJehrFPbOZqZzELHggM7RYxi+JJk6EKDhNT7wPCet4V73ZaBjrD
 cWBhECOXY7apT4C5qrEoAaxkV5kJn46zYekOMII7kxwNFQnPElOCj3obpi0dqQrgzNxU
 93pNyP03Lp4MQxTZCJYe01WidwjL5yDnTNynsSvlQTtDD+3NCouh5/dB8Qeo2xrOrw1a
 3vNw==
X-Gm-Message-State: AOJu0YwvxsTYyUk2j1qgeR9Eiexv/q7axsMeolTPe1/mFFyofEbRZ4Cy
 MR6ncS/R1KNI6DlGfHDxSjgq2H7RHaeuSnMvnbhmvq1hvMVWd+gg
X-Google-Smtp-Source: AGHT+IFXj+G6gsqA6fkdg5aA62Pv2GdH1/Bdnyma318HHuvYnQFhySlWkzJU7r1Vym5lxWLSOhuC8g==
X-Received: by 2002:a50:9f2b:0:b0:56e:2ebc:5c4 with SMTP id
 b40-20020a509f2b000000b0056e2ebc05c4mr8186283edf.20.1713201006975; 
 Mon, 15 Apr 2024 10:10:06 -0700 (PDT)
Received: from ars3 ([2a02:8109:8a87:ff00::6223])
 by smtp.gmail.com with ESMTPSA id
 ee42-20020a056402292a00b005701550ddc5sm2739388edb.90.2024.04.15.10.10.06
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 15 Apr 2024 10:10:06 -0700 (PDT)
From: Augusto Stoffel <arstoffel@HIDDEN>
In-Reply-To: <86v84kmeh0.fsf@HIDDEN> (Eli Zaretskii's message of "Sun, 14 Apr
 2024 13:21:47 +0300")
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN> <86v84kmeh0.fsf@HIDDEN>
Date: Mon, 15 Apr 2024 19:10:05 +0200
Message-ID: <874jc2y2ky.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Sun, 14 Apr 2024 at 13:21, Eli Zaretskii wrote:

>> From: Augusto Stoffel <arstoffel@HIDDEN>
>> Cc: 70136 <at> debbugs.gnu.org,  Stefan Monnier <monnier@HIDDEN>
>> Date: Sun, 14 Apr 2024 11:27:28 +0200
>> 
>> Since compilation buffers go as far as to print the directory they're
>> running on at the top of the buffer, I think it's pretty clear they
>> should receive dir-local variables.
>> 
>> So I'd suggest the attached patch, which does that and also removes a
>> more limited mechanism I added some time ago to allow compilation with
>> project-specific settings.  I've CC'ed Stefan since at the time he kind
>> of supported the changes I'm now suggesting to remove.
>
> Thanks, but I think this should be optional behavior, by default off,
> because it could cause trouble in directory trees which already have
> .dir-locals.el that were not intended to affect compilation-mode (and
> its descendants, like Grep).

This seems rather hypothetical to me.  Do you have a concrete example?
The dir locals mechanism is very precise and easy to use.  Anything not
intended to affect compilation buffers should be put under prog-mode (or
a descendant), text-mode, or whatever else it's actually intended for.

On the other hand, imagine this situation: you're working on a project
with very long lines in some files, so you want your grep buffers to
look more compact.  Then you type

  M-x add-dir-local-variable RET grep-mode RET truncate-lines RET t RET

Wouldn't you be very confused that this doesn't work?

> Also, this needs a NEWS entry, I think.
>
>> +  (unless (buffer-file-name)
>> +    (let ((sym (make-symbol "hack-dir-local-variables-non-file-buffer")))
>> +      (set sym #'hack-dir-local-variables-non-file-buffer)
>> +      ;; Ensure hack-dir-locals is called only after a derived mode is set.
>> +      (push sym delayed-mode-hooks)))
>
> Why such a complicated way of using the symbol of a function that's
> defined in a preloaded Lisp file?  Am I missing some subtlety here?

This is because delayed-mode-hooks is a _list of hooks_, not a hook.
Adding (the name of) a function to it doesn't work.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 15 Apr 2024 18:28:04 +0000
Resent-Message-ID: <handler.70136.B70136.17132056811016 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Augusto Stoffel <arstoffel@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, monnier@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.17132056811016
          (code B ref 70136); Mon, 15 Apr 2024 18:28:04 +0000
Received: (at 70136) by debbugs.gnu.org; 15 Apr 2024 18:28:01 +0000
Received: from localhost ([127.0.0.1]:38871 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rwR3g-0000GK-OI
	for submit <at> debbugs.gnu.org; Mon, 15 Apr 2024 14:28:01 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:59434)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rwR3e-0000GA-5i
 for 70136 <at> debbugs.gnu.org; Mon, 15 Apr 2024 14:27:58 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rwR3L-0007QB-LQ; Mon, 15 Apr 2024 14:27:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=1I+Z8tF58rdFUDRScxK0baZlDfgJcP7C8UK3NtRAQCE=; b=qlJalxGH9GGx
 KbLP5Hc5YVNyrcLN6gK2aUuVjWeKz5Mz+LhtAwCSQTTpnmKn564d27Pi0eTrUdkKJNVLx64C+xmbI
 uTuD/3eF5PtTiAyacccSrdnxR1PEXmi8Yl5loy4nVdQ/qVhqGfPp4gdwoI0MzATRsk8kY3uF/8KmX
 xwvZsJSpyOCJ2Ub9rdkF2xzSxoDuhwL5eo43U36FLn9qKzCdH6gfax7Li2k2nuNOvzXoXpjZqIL83
 O3v3hq602pFXPgecf38wlPBIueKT5jsmx7sePwMW5hIY2LllF3/nBVHaZb3ZPDRGeYME5/j3KqtQC
 GO0kzK1nJz/lxGtXpgZFRg==;
Date: Mon, 15 Apr 2024 21:27:35 +0300
Message-Id: <86sezmjxbc.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <874jc2y2ky.fsf@HIDDEN> (message from Augusto Stoffel on Mon, 
 15 Apr 2024 19:10:05 +0200)
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN> <86v84kmeh0.fsf@HIDDEN>
 <874jc2y2ky.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Augusto Stoffel <arstoffel@HIDDEN>
> Cc: 70136 <at> debbugs.gnu.org,  monnier@HIDDEN
> Date: Mon, 15 Apr 2024 19:10:05 +0200
> 
> On Sun, 14 Apr 2024 at 13:21, Eli Zaretskii wrote:
> 
> >> From: Augusto Stoffel <arstoffel@HIDDEN>
> >> Cc: 70136 <at> debbugs.gnu.org,  Stefan Monnier <monnier@HIDDEN>
> >> Date: Sun, 14 Apr 2024 11:27:28 +0200
> >> 
> >> Since compilation buffers go as far as to print the directory they're
> >> running on at the top of the buffer, I think it's pretty clear they
> >> should receive dir-local variables.
> >> 
> >> So I'd suggest the attached patch, which does that and also removes a
> >> more limited mechanism I added some time ago to allow compilation with
> >> project-specific settings.  I've CC'ed Stefan since at the time he kind
> >> of supported the changes I'm now suggesting to remove.
> >
> > Thanks, but I think this should be optional behavior, by default off,
> > because it could cause trouble in directory trees which already have
> > .dir-locals.el that were not intended to affect compilation-mode (and
> > its descendants, like Grep).
> 
> This seems rather hypothetical to me.  Do you have a concrete example?

You are entitled to your opinions, but this is clearly a change in
behavior that will affect a lot of users (since compilation-mode and
its descendants are very popular and widely used).  Therefore, I don't
understand why you need concrete examples: the issue is crystal clear
just by thinking about it.

> The dir locals mechanism is very precise and easy to use.  Anything not
> intended to affect compilation buffers should be put under prog-mode (or
> a descendant), text-mode, or whatever else it's actually intended for.

On the contrary, .dir-locals.el affects every file in a directory, so
it is quite a blunt weapon.

> On the other hand, imagine this situation: you're working on a project
> with very long lines in some files, so you want your grep buffers to
> look more compact.  Then you type
> 
>   M-x add-dir-local-variable RET grep-mode RET truncate-lines RET t RET
> 
> Wouldn't you be very confused that this doesn't work?

No, I would not.

> 
> > Also, this needs a NEWS entry, I think.
> >
> >> +  (unless (buffer-file-name)
> >> +    (let ((sym (make-symbol "hack-dir-local-variables-non-file-buffer")))
> >> +      (set sym #'hack-dir-local-variables-non-file-buffer)
> >> +      ;; Ensure hack-dir-locals is called only after a derived mode is set.
> >> +      (push sym delayed-mode-hooks)))
> >
> > Why such a complicated way of using the symbol of a function that's
> > defined in a preloaded Lisp file?  Am I missing some subtlety here?
> 
> This is because delayed-mode-hooks is a _list of hooks_, not a hook.
> Adding (the name of) a function to it doesn't work.

I'm asking mainly about the need to use make-symbol.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Juri Linkov <juri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 16 Apr 2024 06:43:02 +0000
Resent-Message-ID: <handler.70136.B70136.171324976915315 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Augusto Stoffel <arstoffel@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70136 <at> debbugs.gnu.org, monnier@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171324976915315
          (code B ref 70136); Tue, 16 Apr 2024 06:43:02 +0000
Received: (at 70136) by debbugs.gnu.org; 16 Apr 2024 06:42:49 +0000
Received: from localhost ([127.0.0.1]:41978 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rwcWn-0003yx-AQ
	for submit <at> debbugs.gnu.org; Tue, 16 Apr 2024 02:42:49 -0400
Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]:41493)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1rwcWS-0003uk-VO
 for 70136 <at> debbugs.gnu.org; Tue, 16 Apr 2024 02:42:36 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id F345BFF804;
 Tue, 16 Apr 2024 06:42:07 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
In-Reply-To: <874jc2y2ky.fsf@HIDDEN> (Augusto Stoffel's message of "Mon, 15
 Apr 2024 19:10:05 +0200")
Organization: LINKOV.NET
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN> <86v84kmeh0.fsf@HIDDEN>
 <874jc2y2ky.fsf@HIDDEN>
Date: Tue, 16 Apr 2024 09:33:51 +0300
Message-ID: <86r0f5n8bk.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> On the other hand, imagine this situation: you're working on a project
> with very long lines in some files, so you want your grep buffers to
> look more compact.  Then you type
>
>   M-x add-dir-local-variable RET grep-mode RET truncate-lines RET t RET
>
> Wouldn't you be very confused that this doesn't work?

I agree this would be confusing.

IMHO, the problem is more wide and it's that dir-local variables
are not supported in non-file buffers by default.  Maybe a new
option could enable them not only in compilation buffers,
but in all non-file buffers?  Or such a new option could be
a list of non-file modes that should support dir-local variables.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 16 Apr 2024 12:38:01 +0000
Resent-Message-ID: <handler.70136.B70136.171327105731828 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Juri Linkov <juri@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, arstoffel@HIDDEN, monnier@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171327105731828
          (code B ref 70136); Tue, 16 Apr 2024 12:38:01 +0000
Received: (at 70136) by debbugs.gnu.org; 16 Apr 2024 12:37:37 +0000
Received: from localhost ([127.0.0.1]:43655 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rwi47-0008H0-2D
	for submit <at> debbugs.gnu.org; Tue, 16 Apr 2024 08:37:37 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:60874)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rwi44-0008Fn-Ao
 for 70136 <at> debbugs.gnu.org; Tue, 16 Apr 2024 08:37:32 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rwi3l-00033y-HJ; Tue, 16 Apr 2024 08:37:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=+xg4ZRfXPlZQ4sToc6d+VaMlIH0ikYC6olEQXe75eOM=; b=jwrDJBnLAo8i
 ws7OpLwGUOy8qXpnepWSIjlBdVhtdIdT5QdaZY3Um/z1EZhUtDEjY+9nTdaSQUti6q6C8l7MOivGM
 h636Yb+i/BZPl3XegR+ttuKDsa1XgDXBZXRRWi0B6CC3fxmANozTb+DIp/TDmcyDcKfX/gLRslmTx
 0kMtTGYSLNl+ixd+D3BQ5BxKBnv+wWAIdjQGg/Wcr53v9/6mRkmrEp2i5akGAtNbqr2PxJPBfE2PB
 yPxLbDKKwCWx/SwlibFOdLGH89sbnOOXtG159zStX90SgjgoURW/bPHicpWEeVh+r7SimVoQdLzkD
 ARsin2mNS6QTtEiN6Ke8oA==;
Date: Tue, 16 Apr 2024 15:37:11 +0300
Message-Id: <868r1djxfs.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <86r0f5n8bk.fsf@HIDDEN> (message from Juri Linkov on
 Tue, 16 Apr 2024 09:33:51 +0300)
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN> <86v84kmeh0.fsf@HIDDEN>
 <874jc2y2ky.fsf@HIDDEN> <86r0f5n8bk.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Juri Linkov <juri@HIDDEN>
> Cc: Eli Zaretskii <eliz@HIDDEN>,  70136 <at> debbugs.gnu.org,
>   monnier@HIDDEN
> Date: Tue, 16 Apr 2024 09:33:51 +0300
> 
> > On the other hand, imagine this situation: you're working on a project
> > with very long lines in some files, so you want your grep buffers to
> > look more compact.  Then you type
> >
> >   M-x add-dir-local-variable RET grep-mode RET truncate-lines RET t RET
> >
> > Wouldn't you be very confused that this doesn't work?
> 
> I agree this would be confusing.
> 
> IMHO, the problem is more wide and it's that dir-local variables
> are not supported in non-file buffers by default.  Maybe a new
> option could enable them not only in compilation buffers,
> but in all non-file buffers?  Or such a new option could be
> a list of non-file modes that should support dir-local variables.

I'm okay with such opt-in behavior.  We can later make it the default
if enough people like it and not many complain about it.

Thanks.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 16 Apr 2024 21:50:02 +0000
Resent-Message-ID: <handler.70136.B70136.171330417518003 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, Augusto Stoffel <arstoffel@HIDDEN>
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171330417518003
          (code B ref 70136); Tue, 16 Apr 2024 21:50:02 +0000
Received: (at 70136) by debbugs.gnu.org; 16 Apr 2024 21:49:35 +0000
Received: from localhost ([127.0.0.1]:45260 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rwqgH-0004fu-GX
	for submit <at> debbugs.gnu.org; Tue, 16 Apr 2024 17:49:35 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:35388)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1rwqgC-0004eD-GS
 for 70136 <at> debbugs.gnu.org; Tue, 16 Apr 2024 17:49:31 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4497380C41;
 Tue, 16 Apr 2024 17:49:10 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1713304149;
 bh=/PXAMCTgCrkCWvz1nOv6e2A05f7i1jzfuxJL+xjJU68=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=ZGA2dC3MpStRx6h4cmQbhP8eji1XF0RdYWKPp1b0TqCVBMwQvFak6hb94g5QCRBjm
 J8ltWqDXPZ8+Kesa5CLf8ExQlouS1NUVnYdTXR/JwwCbTa6nPwET1MuYUwrAUYbS2b
 Ms7wU6LdVg9toX7yWDyGgITtTckdTiEDotjEVRP1I1HfZWGjiys2Lmp+4szMQdY3zv
 bhIGsdTmd/0FSmCKJ3lHpc3H2b/1w26egv39tTxpx/Ep7Ya/K1VFDIb7PsjYNJ8gJW
 hmvoUKzAHNETZTuwiywl15FvXe88oQZb88R4dJg/3ZyuNuuOatcPw2U6DOjoKVr/TR
 LLuRAdOS5PkiQ==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4DEA080A95;
 Tue, 16 Apr 2024 17:49:09 -0400 (EDT)
Received: from pastel (unknown [45.72.201.215])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2389F120250;
 Tue, 16 Apr 2024 17:49:09 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <86sezmjxbc.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 15 Apr
 2024 21:27:35 +0300")
Message-ID: <jwvh6g10yst.fsf-monnier+emacs@HIDDEN>
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN> <86v84kmeh0.fsf@HIDDEN>
 <874jc2y2ky.fsf@HIDDEN> <86sezmjxbc.fsf@HIDDEN>
Date: Tue, 16 Apr 2024 17:49:08 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL -0.057 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> You are entitled to your opinions, but this is clearly a change in
> behavior that will affect a lot of users (since compilation-mode and
> its descendants are very popular and widely used).  Therefore, I don't
> understand why you need concrete examples: the issue is crystal clear
> just by thinking about it.

FWIW, back in 2010 (commit 8117868f0ce6) when we added support for
dir-locals to non-file buffers, we did it without even a config var to
turn it off.

AFAICT the `dir-locals.el` format should already be sufficiently
flexible to make it easy for users annoyed by the new behavior to
recover the old behavior (without affecting older Emacsen).

I think we should make an effort to enable dir-locals in as many buffers
as makes sense (but that can't be all buffers, because many buffers
aren't really related to any particular place in the file system, in
which case using the dir-locals setting of the directory that happens to
be current when the buffer was created is too arbitrary).


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 Apr 2024 02:35:01 +0000
Resent-Message-ID: <handler.70136.B70136.171332129416418 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, arstoffel@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171332129416418
          (code B ref 70136); Wed, 17 Apr 2024 02:35:01 +0000
Received: (at 70136) by debbugs.gnu.org; 17 Apr 2024 02:34:54 +0000
Received: from localhost ([127.0.0.1]:45443 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rwv8Q-0004Gk-97
	for submit <at> debbugs.gnu.org; Tue, 16 Apr 2024 22:34:54 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:39730)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rwv8M-0004Ge-Rf
 for 70136 <at> debbugs.gnu.org; Tue, 16 Apr 2024 22:34:53 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rwv84-0007OP-9f; Tue, 16 Apr 2024 22:34:32 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=y+aJzBL561FGOp/5tjyeGWX6s8MzStBMCdBjT97iJUs=; b=DYQcJU92OD6F
 cBQqgHEYrrG1uNFLb3ht0Y8DP5ZlICW3FR7kQpIZjhrSnHFqnDrgmHkz7x6yjBrmRFQheIWt+RAE9
 WOr1uSFv70OSw/59EhKTyLhvhgt2/rYkqTgrMQ29ajeity8KGQVbS9bBWekJFFzhdjkugsJJ6FQEc
 lLO/VU0sTyHNGuR4b1xDb5ohoAr+zFCLZ8y2ChQONuut4NUxNEv08o7S5409VftYhzwI+4elC5HQv
 5kKi3wy3IGPF5efdVvVUQhVvmGG11/Or/RShgHuXIeieHMIc86qZtusMNlztgqPhajcIS5bFNgt1W
 xvsjeOlzZBxMe1hUfLxfbA==;
Date: Wed, 17 Apr 2024 05:34:31 +0300
Message-Id: <86a5lsiuo8.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <jwvh6g10yst.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Tue, 16 Apr 2024 17:49:08 -0400)
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN> <86v84kmeh0.fsf@HIDDEN>
 <874jc2y2ky.fsf@HIDDEN> <86sezmjxbc.fsf@HIDDEN>
 <jwvh6g10yst.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: Augusto Stoffel <arstoffel@HIDDEN>,  70136 <at> debbugs.gnu.org
> Date: Tue, 16 Apr 2024 17:49:08 -0400
> 
> > You are entitled to your opinions, but this is clearly a change in
> > behavior that will affect a lot of users (since compilation-mode and
> > its descendants are very popular and widely used).  Therefore, I don't
> > understand why you need concrete examples: the issue is crystal clear
> > just by thinking about it.
> 
> FWIW, back in 2010 (commit 8117868f0ce6) when we added support for
> dir-locals to non-file buffers, we did it without even a config var to
> turn it off.

That's not the same.  Also, we did quite a few things wrong regarding
backward compatibility over the years, and I don't want us to repeat
past mistakes.

> AFAICT the `dir-locals.el` format should already be sufficiently
> flexible to make it easy for users annoyed by the new behavior to
> recover the old behavior (without affecting older Emacsen).
> 
> I think we should make an effort to enable dir-locals in as many buffers
> as makes sense (but that can't be all buffers, because many buffers
> aren't really related to any particular place in the file system, in
> which case using the dir-locals setting of the directory that happens to
> be current when the buffer was created is too arbitrary).

Like I said: I'm okay with this change provided that it is opt-in.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 Apr 2024 02:59:01 +0000
Resent-Message-ID: <handler.70136.B70136.171332271719012 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, arstoffel@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171332271719012
          (code B ref 70136); Wed, 17 Apr 2024 02:59:01 +0000
Received: (at 70136) by debbugs.gnu.org; 17 Apr 2024 02:58:37 +0000
Received: from localhost ([127.0.0.1]:45457 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rwvVL-0004wS-Vm
	for submit <at> debbugs.gnu.org; Tue, 16 Apr 2024 22:58:37 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21915)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1rwvVG-0004uy-9x
 for 70136 <at> debbugs.gnu.org; Tue, 16 Apr 2024 22:58:33 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BF75F1000D6;
 Tue, 16 Apr 2024 22:58:11 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1713322690;
 bh=emy6bxkfgwF5nbdT3eozgDo5q/4R0Ir8FIwzNuOanPM=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=haOQDedoKnqWfIp0qvb5Mk63EfsldC6bUbD7NmlaHZfPDhIvzBdb1qU39IbNu8Zwc
 WwE0THZbVxsvowQVTVbVppvi9ynu3FD0cJOYwPmToeb+alATXPhrVfK+QzOffxZJD0
 PBUKu9MyrEUUdeS5gikJHMSVx8b04GN/sACSeHciq9n8GaESvcIu9WEd+jRBkrWSDS
 sqajM70oCAPCTZjEQdv0Yfy2ImeO1WJYneHjq8IbEMf8YwI23oQZ2Z/ixTtMQpgKKk
 szK3Ih4XRvtgGup+WYGmoxukof/wwKmfJv7ErCRxe7KwRtUKx9MRoiBwPbY4Vhqjmb
 IpQUizbVPsJkw==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BEACB100044;
 Tue, 16 Apr 2024 22:58:10 -0400 (EDT)
Received: from pastel (unknown [45.72.201.215])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 97E9E1204C0;
 Tue, 16 Apr 2024 22:58:10 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <86a5lsiuo8.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 17 Apr
 2024 05:34:31 +0300")
Message-ID: <jwvttk0zoyb.fsf-monnier+emacs@HIDDEN>
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN> <86v84kmeh0.fsf@HIDDEN>
 <874jc2y2ky.fsf@HIDDEN> <86sezmjxbc.fsf@HIDDEN>
 <jwvh6g10yst.fsf-monnier+emacs@HIDDEN> <86a5lsiuo8.fsf@HIDDEN>
Date: Tue, 16 Apr 2024 22:58:10 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.041 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> FWIW, back in 2010 (commit 8117868f0ce6) when we added support for
>> dir-locals to non-file buffers, we did it without even a config var to
>> turn it off.
> That's not the same.  Also, we did quite a few things wrong regarding
> backward compatibility over the years, and I don't want us to repeat
> past mistakes.

I can relate to that, but I can't remember bug reports (nor questions
from confused users in other channels) when we made that change, so
I don't see why we should consider that specific past choice to be
a "past mistake".
Also, I'm not seeing why "That's not the same".

> Like I said: I'm okay with this change provided that it is opt-in.

The problem with that is discovery.  Should we add a message like
"ignoring dir-locals.  See obey-dir-local-variables-in-all-non-file-buffers"?

And of course a related question is what kind of granularity to use for
the "opt-in"?  Will we add a new var every time we notice another (set
of) buffers for which we should apply dir-local vars, or would it be OK
to have a single variable?

If it's OK to have a single var: why should this var not
apply to diff-mode, log-edit-mode, ...?
Or should this var contain a list of modes which allow it, so we can
make it default to (diff-mode log-edit-mode ...)?  And maybe also allow
a t value?

And since this var is needed only to avoid breaking backward
compatibility, it would be desirable to have a plan to get rid of it in
the longer term.


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Augusto Stoffel <arstoffel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 Apr 2024 08:17:03 +0000
Resent-Message-ID: <handler.70136.B70136.171334179117919 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Juri Linkov <juri@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70136 <at> debbugs.gnu.org, monnier@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171334179117919
          (code B ref 70136); Wed, 17 Apr 2024 08:17:03 +0000
Received: (at 70136) by debbugs.gnu.org; 17 Apr 2024 08:16:31 +0000
Received: from localhost ([127.0.0.1]:45658 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rx0T1-0004ex-4p
	for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 04:16:31 -0400
Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]:43448)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arstoffel@HIDDEN>) id 1rx0Su-0004eY-MD
 for 70136 <at> debbugs.gnu.org; Wed, 17 Apr 2024 04:16:29 -0400
Received: by mail-ed1-x52d.google.com with SMTP id
 4fb4d7f45d1cf-565c6cf4819so924651a12.1
 for <70136 <at> debbugs.gnu.org>; Wed, 17 Apr 2024 01:16:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1713341766; x=1713946566; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=JmWxSmFf7JBKsv/gZAXV5C3c9CjCZPQznM2UjZ6Gbyc=;
 b=iblwwXycCHGWdCy2wibB9sBDBwXnyP+uWAqjN7NNu2ymZzr6yM/JFA9MM+i24qmKOE
 8s8bXs8oqFibFUWhnJcki2q5Ep2Lk6bE/a5MX1ysltUqoO5KUCFgezys3eI0TVgZ/rOC
 O5CYWhVkduDcN01aAd9r095ns3o/sJPn5QZVWJxjwo/CPGJ3i5Y2sLiFNRcRn1Tl+5uj
 rkM6r4/E8ZHfaszZf9Gxl9zwnxTalM85ZHJaDF12UYrCWr/m6Sc3C8RWK+l2E7eFoYO1
 jaRsSgI8nxuiZlHAMBRp+UxE5CDS8Hi3ifEDw1wmQ0jLvlrJXjEEFKl//QLXGbrzctpr
 S8vw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1713341766; x=1713946566;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=JmWxSmFf7JBKsv/gZAXV5C3c9CjCZPQznM2UjZ6Gbyc=;
 b=aLmjNtfSwILW317rZd0n5dNMc8rN8BG+MoqoK0vIOxgnlFJLQtXDHJwSz7O1LQNcvA
 Exd389+VyTamN0Ge1+/3sRU3Kju1T6/xX0owipECrXtrMBljtzYMEs77xh2uMQ+YxJeO
 1vAPwi8xerLPxjsGGmNEE9rQ+RgpAeZcX3Pf7XRzbX33giWgiCCWREa151oOp6GOx8i9
 ECacCBTJGL7tj/G4ApC14tB2Rhh7WiNMl8g/uHCiIIAkZDBAVrcjg6ucjTRVPNumSK7X
 LGOUHeLkd5QDOcRvQXkWwpaLJQj6y0IqGMzJZH8F0JSdQOJvfqzQVEXuDnWL/iNRQXmS
 io8Q==
X-Forwarded-Encrypted: i=1;
 AJvYcCVCunlCqGdAWWKBc7m26t1snqlrVpS3Tp2KzeQJRIPGGxclF4b4TD1YmUZzzCo6W1EDkcG/8OHPYwY0kqOAj/A2TH1iAC8=
X-Gm-Message-State: AOJu0YxtLdpErFuF288QenPPZDDC8v4oASmrRN9DYaCIWpoP3sPYemyO
 sZzyy1zzHQJIT+Xtv4VrlGKgHSasxl9EUaEPBac9v8q/PD3JK0qgG/yn6Q==
X-Google-Smtp-Source: AGHT+IGUPp7Oh9wq+3dffgYD+q6r4g8qdXJJ0MgX5CDMWFD+ZWcLdeGVeMRbEGUIbETc/gtszxq99Q==
X-Received: by 2002:a17:906:1196:b0:a4a:36e4:c3f9 with SMTP id
 n22-20020a170906119600b00a4a36e4c3f9mr4484947eja.7.1713341765676; 
 Wed, 17 Apr 2024 01:16:05 -0700 (PDT)
Received: from ars3 ([2a02:8109:8a87:ff00::6223])
 by smtp.gmail.com with ESMTPSA id
 cx10-20020a170906c80a00b00a51b5282837sm7861508ejb.15.2024.04.17.01.16.04
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 17 Apr 2024 01:16:04 -0700 (PDT)
From: Augusto Stoffel <arstoffel@HIDDEN>
In-Reply-To: <86r0f5n8bk.fsf@HIDDEN> (Juri Linkov's message of "Tue, 
 16 Apr 2024 09:33:51 +0300")
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN> <86v84kmeh0.fsf@HIDDEN>
 <874jc2y2ky.fsf@HIDDEN> <86r0f5n8bk.fsf@HIDDEN>
Date: Wed, 17 Apr 2024 10:16:03 +0200
Message-ID: <87v84g9zgc.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Tue, 16 Apr 2024 at 09:33, Juri Linkov wrote:

> IMHO, the problem is more wide and it's that dir-local variables
> are not supported in non-file buffers by default.  Maybe a new
> option could enable them not only in compilation buffers,
> but in all non-file buffers?

One would have to exclude temporary and internal work buffers, for
efficiency reasons.

And then there's also the case of buffers that don't really "belong" to
a directory, such as *Help*.  Do you think there's a reliable way to
distinguish those from the rest?

(By the way, *Help* and friends get stuck forever in whatever
default-directory they were first created; so for instance if you do
C-x C-f in a *Help* buffer, you will see a random directory as
starting point...)

>  Or such a new option could be a list of non-file modes that should
> support dir-local variables.

I'm not a big fan of this idea.  The .dir-locals.el file is already a
list of modes, you can decide there which modes you want to be affected.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Augusto Stoffel <arstoffel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 Apr 2024 08:33:04 +0000
Resent-Message-ID: <handler.70136.B70136.17133427272933 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: Eli Zaretskii <eliz@HIDDEN>, 70136 <at> debbugs.gnu.org
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.17133427272933
          (code B ref 70136); Wed, 17 Apr 2024 08:33:04 +0000
Received: (at 70136) by debbugs.gnu.org; 17 Apr 2024 08:32:07 +0000
Received: from localhost ([127.0.0.1]:45687 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rx0i7-0000lF-AW
	for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 04:32:07 -0400
Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:50545)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <arstoffel@HIDDEN>) id 1rx0i3-0000dh-R4
 for 70136 <at> debbugs.gnu.org; Wed, 17 Apr 2024 04:32:05 -0400
Received: by mail-ed1-x536.google.com with SMTP id
 4fb4d7f45d1cf-56e6acb39d4so7053633a12.1
 for <70136 <at> debbugs.gnu.org>; Wed, 17 Apr 2024 01:31:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1713342704; x=1713947504; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=DUoSfOU1k7F+Sl7T80p2izkuJFxbdZDxbQ9iCUUSi7s=;
 b=nF4BHpht9Z3l5P3/RslxhV6OmH577U+DCTfcHJWqBH1jNkLSI/OMl9u/mnqlWLyDD0
 kyWVjk86bW0SKUSFaUtn4bwfDvPtAq3RkS5cTTWLjw3Oxwug4nrGR/Q2Dh6VYvIP1ylr
 BfkEdkiSuVymAFrfNFUo1D04T2NfQ28W4DBFSqJKT5o07Yx5wigoCOIWMJ/Ws/gPmbD5
 KrkSBEaUBYMFSGksHsPdz+xH6ZbDTI8HIJkH4s7h/6DENLcsaL1NP4XNzOOvWT1nA8uc
 OFrSlhDsBjpAKmG28SPl9zw+enNJitjqq0wfRJt9TTmrSMIasmD3RklCi3OrHZX7E6YL
 VfhA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1713342704; x=1713947504;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=DUoSfOU1k7F+Sl7T80p2izkuJFxbdZDxbQ9iCUUSi7s=;
 b=WrcoED63cuX9zAoE2spFyb8zD5Fj+fWXsilW7BkDrwifePgvK7+eSMVyaqK3Qxs32V
 vqg6riaWvaYX/RAb1p+7dcagxgXJ/y2drP80FqpDmzQRhyV4cHtUIVJPP7b8hxjp20/F
 qq09kAu+tPIrja3t/qw8I54fGJsrTYz9wDe3oCK8NPVhj9HpifbQ/IREqg2jzAsjK24z
 a7/P7wQaSCI11M5Ilp2E9XDpDWQxT2xpxbtkpR+XJGUsLKk1wkChFYa8LzuSXnLFaHX7
 zSVlTRwL3zQBhjw1P82ahwnR7HdMlNOn4QQz6JfNV5hR0djm1smnxEHM9Kucz/0tCXpK
 ipPw==
X-Forwarded-Encrypted: i=1;
 AJvYcCUE9SwL7dv2c/86+NigyujeV5UfcnmdKbsLTnNBTK3dkWDi9k24v6rzzWBhsnB5A0XSj2BsXfyldQS1ndxNo2b3+MsFcm4=
X-Gm-Message-State: AOJu0Yy+PSLJwFBg3Ike2/F8MQpj0rpiQGgv6QnM5mhGBHSIsppQ7rU+
 4p6vs8n4QZ6DXEqozPrnfJ2dBdimzOV9n5AX2/bnV9LlyGK6wB8B0F3O8A==
X-Google-Smtp-Source: AGHT+IF/FBKDj29MQq6Toh51G46xQ5EJFcV2fJDE0m5G2YlfzFre4F+0gGUZnign4MupXOkZWL/SMw==
X-Received: by 2002:a17:907:5c5:b0:a46:d041:28e0 with SMTP id
 wg5-20020a17090705c500b00a46d04128e0mr11828337ejb.59.1713342704193; 
 Wed, 17 Apr 2024 01:31:44 -0700 (PDT)
Received: from ars3 ([2a02:8109:8a87:ff00::6223])
 by smtp.gmail.com with ESMTPSA id
 s13-20020a170906354d00b00a5556cd0fd5sm532755eja.183.2024.04.17.01.31.43
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 17 Apr 2024 01:31:43 -0700 (PDT)
From: Augusto Stoffel <arstoffel@HIDDEN>
In-Reply-To: <jwvttk0zoyb.fsf-monnier+emacs@HIDDEN> (Stefan Monnier's message
 of "Tue, 16 Apr 2024 22:58:10 -0400")
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN> <86v84kmeh0.fsf@HIDDEN>
 <874jc2y2ky.fsf@HIDDEN> <86sezmjxbc.fsf@HIDDEN>
 <jwvh6g10yst.fsf-monnier+emacs@HIDDEN> <86a5lsiuo8.fsf@HIDDEN>
 <jwvttk0zoyb.fsf-monnier+emacs@HIDDEN>
Date: Wed, 17 Apr 2024 10:31:42 +0200
Message-ID: <87r0f49yq9.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Tue, 16 Apr 2024 at 22:58, Stefan Monnier wrote:

> And since this var is needed only to avoid breaking backward
> compatibility, it would be desirable to have a plan to get rid of it in
> the longer term.

I definitely agree with this.  Eli's worry is about retaining
compatibility with buggy code (in this case, a hypothetical
.dir-locals.el that doesn't properly map variables to the desired
modes), so the compatibility workarounds, if any at all, should be
transitional.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 Apr 2024 12:37:03 +0000
Resent-Message-ID: <handler.70136.B70136.171335738915269 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, arstoffel@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171335738915269
          (code B ref 70136); Wed, 17 Apr 2024 12:37:03 +0000
Received: (at 70136) by debbugs.gnu.org; 17 Apr 2024 12:36:29 +0000
Received: from localhost ([127.0.0.1]:45999 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rx4Wa-0003yB-9R
	for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 08:36:28 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:53176)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rx4WX-0003x7-W0
 for 70136 <at> debbugs.gnu.org; Wed, 17 Apr 2024 08:36:27 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rx4WE-0003Sl-W3; Wed, 17 Apr 2024 08:36:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=Zjs5njwcU44SQWweDMxhN0ermBy4PfLo4jEqrrsTIyA=; b=TaPVVJw55fSn
 NTZZ39Tk8vngC6DwdtWrPkX5WDvLIBS/G4G2YWHadXr36Er26B2pVZdHwlGRPBAOX5k9n3n4frkOf
 uxKMrjO9udZFou9QfPv9EQIXmePg04olxaeBUvldXio4kwWNAiTvxSJ62MMAqLdlEvDW8OIIbzsY+
 zcPCUL2+Xh9XKioH3AsEm8Pt57SqWuonltTQYxosdM6queEghGcKEP+Sav8+LLdlrAO+G1W96ZP5V
 TznE2jhfYD1Ks0a+5Ph4jeKVEd/ust6BFD6b80KHF0UpJAwRDU/O/RJBD4NO5dlpfM+pMNpZS0YSG
 6k6S+hwaKL8yKrc4UteT2w==;
Date: Wed, 17 Apr 2024 15:36:03 +0300
Message-Id: <86wmowgo98.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <jwvttk0zoyb.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Tue, 16 Apr 2024 22:58:10 -0400)
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN> <86v84kmeh0.fsf@HIDDEN>
 <874jc2y2ky.fsf@HIDDEN> <86sezmjxbc.fsf@HIDDEN>
 <jwvh6g10yst.fsf-monnier+emacs@HIDDEN> <86a5lsiuo8.fsf@HIDDEN>
 <jwvttk0zoyb.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: arstoffel@HIDDEN,  70136 <at> debbugs.gnu.org
> Date: Tue, 16 Apr 2024 22:58:10 -0400
> 
> >> FWIW, back in 2010 (commit 8117868f0ce6) when we added support for
> >> dir-locals to non-file buffers, we did it without even a config var to
> >> turn it off.
> > That's not the same.  Also, we did quite a few things wrong regarding
> > backward compatibility over the years, and I don't want us to repeat
> > past mistakes.
> 
> I can relate to that, but I can't remember bug reports (nor questions
> from confused users in other channels) when we made that change, so
> I don't see why we should consider that specific past choice to be
> a "past mistake".

I didn't mean to say that introduction of dir-locals specifically was
a mistake, I meant that in general, to make the point that not
everything we did before can be taken as a good recipe for imitation.

> Also, I'm not seeing why "That's not the same".

Because introducing a new feature is qualitatively different: it can
have no backward-compatibility problems, since no one can possibly
have existing customizations for it.

> > Like I said: I'm okay with this change provided that it is opt-in.
> 
> The problem with that is discovery.

It always is, with opt-in features.  But that doesn't mean we should
turn each new feature on, just to make it more discoverable.  There
are other considerations, and some are more important than
discoverability.

> Should we add a message like
> "ignoring dir-locals.  See obey-dir-local-variables-in-all-non-file-buffers"?

The time for April 1 jokes has come and passed this year, no? ;-)

> And of course a related question is what kind of granularity to use for
> the "opt-in"?  Will we add a new var every time we notice another (set
> of) buffers for which we should apply dir-local vars, or would it be OK
> to have a single variable?

There's no such dilemma in this case, because this feature was
proposed to be controlled by users to begin with.  So the variable was
already proposed, the discussion is just about its default value.

> And since this var is needed only to avoid breaking backward
> compatibility, it would be desirable to have a plan to get rid of it in
> the longer term.

I believe I suggested such a plan in my previous messages.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 Apr 2024 13:01:03 +0000
Resent-Message-ID: <handler.70136.B70136.171335881826657 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, arstoffel@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171335881826657
          (code B ref 70136); Wed, 17 Apr 2024 13:01:03 +0000
Received: (at 70136) by debbugs.gnu.org; 17 Apr 2024 13:00:18 +0000
Received: from localhost ([127.0.0.1]:46035 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rx4td-0006vs-U2
	for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 09:00:18 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15300)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1rx4tY-0006uG-CY
 for 70136 <at> debbugs.gnu.org; Wed, 17 Apr 2024 09:00:15 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 442B24413B2;
 Wed, 17 Apr 2024 08:59:53 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1713358791;
 bh=/yFsa9t9q9D/hly42ipfVUz19QNnK04jyX1/Skc+Fcc=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=XHjKWHqvWfj9Om3yzVtUI0aC7eZXfF491g8XtGOQ7ffaddesbYfJ6s75ngjEOnBvt
 0z3wPJAUfrvHumpxTuCD5k2U+1B7wNgjkdJIKH+u9v6SxCflwcLhEUtgQPeMcFxjj/
 a5NfWJo4Dhm7SYloABrHMlIx76X0TOFMBbltSAFWsRAumokQ/UK6NBE1m33TiArSiv
 /O8Ljisaa9XAA7BN7xZzaNTAOoznrOYe/znjIftVrzlkFAbHpiTOoMTB2zz8vBmwzx
 4A5tW+JLkoJxu7R1U+sCwt0U0ZZEvFcqfyb2rzfgN8R01TUCg8C7DQnbbKP/FMC+IN
 fc8Uuvsit5+DA==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D9CA5441606;
 Wed, 17 Apr 2024 08:59:51 -0400 (EDT)
Received: from pastel (unknown [45.72.201.215])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B4329120831;
 Wed, 17 Apr 2024 08:59:51 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <86wmowgo98.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 17 Apr
 2024 15:36:03 +0300")
Message-ID: <jwv1q74ywyk.fsf-monnier+emacs@HIDDEN>
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN> <86v84kmeh0.fsf@HIDDEN>
 <874jc2y2ky.fsf@HIDDEN> <86sezmjxbc.fsf@HIDDEN>
 <jwvh6g10yst.fsf-monnier+emacs@HIDDEN> <86a5lsiuo8.fsf@HIDDEN>
 <jwvttk0zoyb.fsf-monnier+emacs@HIDDEN> <86wmowgo98.fsf@HIDDEN>
Date: Wed, 17 Apr 2024 08:59:50 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.009 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> Also, I'm not seeing why "That's not the same".
>
> Because introducing a new feature is qualitatively different: it can
> have no backward-compatibility problems, since no one can possibly
> have existing customizations for it.

That commit I referred to had AFAICT the same effect as the one
discussed here: it made some modes (diff-mode, log-edit-mode, and a few
more) obey dir-locals whereas they didn't before.
And dir-locals existed since several years before that.

Why would it be more likely for them to have .dir-locals which
accidentally affect grep-mode than diff-mode/log-edit-mode/...?

AFAICT it risked the exact same backward compatibility problems.

>> Should we add a message like
>> "ignoring dir-locals.  See obey-dir-local-variables-in-all-non-file-buffers"?
> The time for April 1 jokes has come and passed this year, no? ;-)

I'm quite serious.  From where I stand, I think most users would
want to enable this feature in they have a situation where it affects
the behavior of Emacs.


        Stefan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 Apr 2024 13:02:01 +0000
Resent-Message-ID: <handler.70136.B70136.171335888127319 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Augusto Stoffel <arstoffel@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, monnier@HIDDEN, juri@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171335888127319
          (code B ref 70136); Wed, 17 Apr 2024 13:02:01 +0000
Received: (at 70136) by debbugs.gnu.org; 17 Apr 2024 13:01:21 +0000
Received: from localhost ([127.0.0.1]:46040 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rx4ua-00075q-Ak
	for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 09:01:20 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:46030)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rx4uV-00073w-Hj
 for 70136 <at> debbugs.gnu.org; Wed, 17 Apr 2024 09:01:15 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rx4uC-00085i-HX; Wed, 17 Apr 2024 09:00:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=yI4uvM9/8I/IIWjJZLBFiKetvUXHKGFkTIyijgntuI4=; b=EwJHvK2UvMpx
 sf2cnqfN03vAgP97ZneuxsBtviPsUNWt7dLdD4RnbiYJX3utw8E5yglUwaGTkGUvuiNBSTxcQk4lV
 wMA0V8RUjOU6hxO1ft2GIBoWUVYM9h+BEec+WjTOF5NbYkddKXVbL+yv0BWjvMNLfV2T8IphLwzbm
 sZ9WIUVl0ZoU6H11Gxqz8f6fHpd6K4YAXDlsogxUDhIYWkGGaCzEh8/0NPugFSfcXZRHPmttC564E
 QgFFeGCLZ+GQmRRVKwme6uVyjCdoPHJYBbL7JRlD4HxeBUFgBZ7XS/ghKAuOUpLRhjTSGRwR5v49d
 k9BKY3qbyAwtTAx4RoUpaA==;
Date: Wed, 17 Apr 2024 16:00:48 +0300
Message-Id: <86pluogn3z.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87v84g9zgc.fsf@HIDDEN> (message from Augusto Stoffel on Wed, 
 17 Apr 2024 10:16:03 +0200)
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN> <86v84kmeh0.fsf@HIDDEN>
 <874jc2y2ky.fsf@HIDDEN> <86r0f5n8bk.fsf@HIDDEN>
 <87v84g9zgc.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Augusto Stoffel <arstoffel@HIDDEN>
> Cc: Eli Zaretskii <eliz@HIDDEN>,  70136 <at> debbugs.gnu.org,
>   monnier@HIDDEN
> Date: Wed, 17 Apr 2024 10:16:03 +0200
> 
> On Tue, 16 Apr 2024 at 09:33, Juri Linkov wrote:
> 
> >  Or such a new option could be a list of non-file modes that should
> > support dir-local variables.
> 
> I'm not a big fan of this idea.  The .dir-locals.el file is already a
> list of modes, you can decide there which modes you want to be affected.

The difference is that if we say this should be in .dir-locals.el, we
place the burden on the users, whereas if we do what Juri suggested,
we solve this ourselves at least for modes that come with Emacs.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 Apr 2024 13:05:01 +0000
Resent-Message-ID: <handler.70136.B70136.171335905428931 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Augusto Stoffel <arstoffel@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, monnier@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171335905428931
          (code B ref 70136); Wed, 17 Apr 2024 13:05:01 +0000
Received: (at 70136) by debbugs.gnu.org; 17 Apr 2024 13:04:14 +0000
Received: from localhost ([127.0.0.1]:46045 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rx4xO-0007W9-GG
	for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 09:04:14 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:33738)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rx4xI-0007UI-DD
 for 70136 <at> debbugs.gnu.org; Wed, 17 Apr 2024 09:04:08 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rx4wy-0008UD-RZ; Wed, 17 Apr 2024 09:03:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=dSWJHu8Jx/Hb0BdZU5GR6+UwKpzFdZfDBGD4Ke2qAAQ=; b=alNrz9/nsFm9
 5n/B4jlRMNRrJG6o+zO0Mir6lLWWxcwkIUs0Nq9835ApxJSOkzRLarsLe3VzqTamtrftjpdWnjLtX
 9ys2KE6Muy+O0dUOhF3oWGwInTJbLz9ZeXa7Po/sNR2wYHwNIL6GhSUP6bsT/njgkHuyaTktVdyju
 syMP0ybrCTilqxEwPB2Nma0TySQNoAi9Oxz84GnL9vKt0jymBvz2+gONT8r0VBqza7Sk6L0nvFrjE
 H5EjsrXTB7a66r6/zQ6HMbQZTWSDqqAegmI8lrckpbU5NbTT5tl/MAtDY+70mBFFyVG9epa0FRO3q
 SsNW4yq8vWzuJnEzMKki5w==;
Date: Wed, 17 Apr 2024 16:03:18 +0300
Message-Id: <86mspsgmzt.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87r0f49yq9.fsf@HIDDEN> (message from Augusto Stoffel on Wed, 
 17 Apr 2024 10:31:42 +0200)
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN> <86v84kmeh0.fsf@HIDDEN>
 <874jc2y2ky.fsf@HIDDEN> <86sezmjxbc.fsf@HIDDEN>
 <jwvh6g10yst.fsf-monnier+emacs@HIDDEN> <86a5lsiuo8.fsf@HIDDEN>
 <jwvttk0zoyb.fsf-monnier+emacs@HIDDEN> <87r0f49yq9.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Augusto Stoffel <arstoffel@HIDDEN>
> Cc: Eli Zaretskii <eliz@HIDDEN>,  70136 <at> debbugs.gnu.org
> Date: Wed, 17 Apr 2024 10:31:42 +0200
> 
> On Tue, 16 Apr 2024 at 22:58, Stefan Monnier wrote:
> 
> > And since this var is needed only to avoid breaking backward
> > compatibility, it would be desirable to have a plan to get rid of it in
> > the longer term.
> 
> I definitely agree with this.  Eli's worry is about retaining
> compatibility with buggy code (in this case, a hypothetical
> .dir-locals.el that doesn't properly map variables to the desired
> modes), so the compatibility workarounds, if any at all, should be
> transitional.

This is not so much about buggy .dir-locals.el, this is about
non-buggy .dir-locals.el that have customizations for nil mode --
those customizations might not expect non-file modes to be affected.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 Apr 2024 13:17:01 +0000
Resent-Message-ID: <handler.70136.B70136.17133598032058 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Stefan Monnier <monnier@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, arstoffel@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.17133598032058
          (code B ref 70136); Wed, 17 Apr 2024 13:17:01 +0000
Received: (at 70136) by debbugs.gnu.org; 17 Apr 2024 13:16:43 +0000
Received: from localhost ([127.0.0.1]:46063 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rx59W-0000X1-FE
	for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 09:16:43 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:46916)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rx59S-0000Vg-Ve
 for 70136 <at> debbugs.gnu.org; Wed, 17 Apr 2024 09:16:40 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rx59A-0002Wf-0A; Wed, 17 Apr 2024 09:16:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=udTYOOwsNGQCAfBPd12ZFcbfh3p7i3ZlbvMn0nU8wto=; b=H1Jr4X1zWjd3
 iJxCO+UdUavwl6vA6dQw8CB29MPxqX/XgabLwSo2frolKsNQtCVwh90REgIsDtqUa8QLhjOrgnX9y
 /dEBxhxWYz/jBlM+W5fq/8gQ8W/XuFkHEC+prRNrB1OMHQ21FjgxL/dMmnvw6VOTZAVuITPKKFahL
 RHNwWv4kSsaIjcnPe2/FiU8/INa2ssS9ty/W11SQDThicYmtK3AJ4cC8Tf3JDJQVGDZYbWTLVc2xe
 +fJ6wI1tewI4aBBnlbEvutz0cOr37YACGVyMEGOZ5o9KnzTc7ctZMFjkvzp19GNZj1iyiiY4IO3hP
 kEsopgmFm0juDEscYe5HRA==;
Date: Wed, 17 Apr 2024 16:16:16 +0300
Message-Id: <86il0ggme7.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <jwv1q74ywyk.fsf-monnier+emacs@HIDDEN> (message from Stefan
 Monnier on Wed, 17 Apr 2024 08:59:50 -0400)
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN> <86v84kmeh0.fsf@HIDDEN>
 <874jc2y2ky.fsf@HIDDEN> <86sezmjxbc.fsf@HIDDEN>
 <jwvh6g10yst.fsf-monnier+emacs@HIDDEN> <86a5lsiuo8.fsf@HIDDEN>
 <jwvttk0zoyb.fsf-monnier+emacs@HIDDEN> <86wmowgo98.fsf@HIDDEN>
 <jwv1q74ywyk.fsf-monnier+emacs@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Stefan Monnier <monnier@HIDDEN>
> Cc: arstoffel@HIDDEN,  70136 <at> debbugs.gnu.org
> Date: Wed, 17 Apr 2024 08:59:50 -0400
> 
> >> Also, I'm not seeing why "That's not the same".
> >
> > Because introducing a new feature is qualitatively different: it can
> > have no backward-compatibility problems, since no one can possibly
> > have existing customizations for it.
> 
> That commit I referred to had AFAICT the same effect as the one
> discussed here: it made some modes (diff-mode, log-edit-mode, and a few
> more) obey dir-locals whereas they didn't before.
> And dir-locals existed since several years before that.
> 
> Why would it be more likely for them to have .dir-locals which
> accidentally affect grep-mode than diff-mode/log-edit-mode/...?
> 
> AFAICT it risked the exact same backward compatibility problems.

So we should risk it again?

> >> Should we add a message like
> >> "ignoring dir-locals.  See obey-dir-local-variables-in-all-non-file-buffers"?
> > The time for April 1 jokes has come and passed this year, no? ;-)
> 
> I'm quite serious.  From where I stand, I think most users would
> want to enable this feature in they have a situation where it affects
> the behavior of Emacs.

If you are right, we will be able to make this on by default in Emacs
31 (assuming we introduce the opt-in feature in Emacs 30, that is: no
one has yet shown the code, so we are discussing a highly theoretical
feature).

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70136: 30.0.50; compilation-mode [was: comint-mode] doesn't call hack-dir-local-variables-non-file-buffer
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 17 Apr 2024 18:00:06 +0000
Resent-Message-ID: <handler.70136.B70136.171337674523615 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70136
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 70136 <at> debbugs.gnu.org, arstoffel@HIDDEN
Received: via spool by 70136-submit <at> debbugs.gnu.org id=B70136.171337674523615
          (code B ref 70136); Wed, 17 Apr 2024 18:00:06 +0000
Received: (at 70136) by debbugs.gnu.org; 17 Apr 2024 17:59:05 +0000
Received: from localhost ([127.0.0.1]:47230 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rx9Ym-00068d-2e
	for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 13:59:04 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27104)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1rx9Yj-00067G-Eu
 for 70136 <at> debbugs.gnu.org; Wed, 17 Apr 2024 13:59:02 -0400
Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F1DA044181C;
 Wed, 17 Apr 2024 13:58:42 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1713376721;
 bh=01CqONiPKTlxI87NmiHDhLGEFcqBCCHrw6fVkl+bDwE=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=gee46PuvSy2S+O9xgQ3pp/RMb8p8FRKZFZAhPIfnyOihQuC/TfVWQsJjWWHlFmBo4
 Y0IXy2eBVf7110FwPW8R+PZUhRrfaTMnnRy3qwJimsGH0CAdY9yOeGdSmMUx72xQPR
 vH63FetqtcDt/GVHgDnE8BXka/vwOczKEZPI+RxR03kmoJcT5h7Iau4rDjhyNThlI9
 gVEDES6XT7mA1JwAQ4i9aHxeuiqeF2iwOCZGBxyP9uZT+tUic+dxH4WOKIbKT//+Ct
 FraK6BS6E80k9ADNT47A+XiBtCSGy+DwzLyNBUXquZPZYrOF1TClU6ixOO0+IeFrQ3
 lDGxra5BxB8BA==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C04014417AA;
 Wed, 17 Apr 2024 13:58:41 -0400 (EDT)
Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id ADB3C120804;
 Wed, 17 Apr 2024 13:58:41 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <86il0ggme7.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 17 Apr
 2024 16:16:16 +0300")
Message-ID: <jwvedb3510t.fsf-monnier+emacs@HIDDEN>
References: <87zfuc48d5.fsf@HIDDEN> <86msqc9dsa.fsf@HIDDEN>
 <874jcjeuac.fsf@HIDDEN> <86edbnajfp.fsf@HIDDEN>
 <87mspwcn0f.fsf_-_@HIDDEN> <86v84kmeh0.fsf@HIDDEN>
 <874jc2y2ky.fsf@HIDDEN> <86sezmjxbc.fsf@HIDDEN>
 <jwvh6g10yst.fsf-monnier+emacs@HIDDEN> <86a5lsiuo8.fsf@HIDDEN>
 <jwvttk0zoyb.fsf-monnier+emacs@HIDDEN> <86wmowgo98.fsf@HIDDEN>
 <jwv1q74ywyk.fsf-monnier+emacs@HIDDEN> <86il0ggme7.fsf@HIDDEN>
Date: Wed, 17 Apr 2024 13:55:55 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results:  0
 ALL_TRUSTED                -1 Passed through trusted hosts only via SMTP
 AWL 0.087 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DKIM_SIGNED               0.1 Message has a DKIM or DK signature,
 not necessarily valid
 DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
 DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
 domain
 DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
 domain
X-SPAM-LEVEL: 
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

>> That commit I referred to had AFAICT the same effect as the one
>> discussed here: it made some modes (diff-mode, log-edit-mode, and a few
>> more) obey dir-locals whereas they didn't before.
>> And dir-locals existed since several years before that.
>> 
>> Why would it be more likely for them to have .dir-locals which
>> accidentally affect grep-mode than diff-mode/log-edit-mode/...?
>> 
>> AFAICT it risked the exact same backward compatibility problems.
>
> So we should risk it again?

Well, that risk paid off because by all accounts it seems that noone
suffered (and some people benefited), so that argues in favor of taking
that risk again.


        Stefan

Last modified: Wed, 17 Apr 2024 18:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.