Received: (at 70148) by debbugs.gnu.org; 4 May 2024 16:50:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 04 12:50:08 2024 Received: from localhost ([127.0.0.1]:54628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s3IaO-0002xJ-Dw for submit <at> debbugs.gnu.org; Sat, 04 May 2024 12:50:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1s3IaJ-0002wm-SE for 70148 <at> debbugs.gnu.org; Sat, 04 May 2024 12:50:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1s3IZq-0001Io-SH; Sat, 04 May 2024 12:49:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=d9lJqTEpKqgtHke0XffpUBVr9ocRL2RLIgcxGuKtLPM=; b=NhPx2Ksfgm1+1BOdBOU+ 9PDjbetC1VmfzS5zug29Oit+Ukwi4R82Zi5XMcCEl9sr/YuD8bm3fnYryh7QRxytNh/SMA+MhFl/k 7A1OKIqrHzguMSn+w8cJXGRFV85d/HkgAJj1Kz5ONnwytOd/exsGjETHgnx117GFehOky2mZILmK7 gknZWwGRtqE9XoThtYFIssCisZER4Fq8htJ5jIpFa1TWjt29IEqefCdQF4ln/x8vYAX12iKvWKtIK cYfpSbXtfkcQJ60QlDHk8Hs2oeS3GxFxCOXdfWmeJgBGj2WTJfw/Qlgpbl72NFSsANA5ha/p+Ex0F 6d5terVIkjkJkA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Richard Sent <richard@HIDDEN> Subject: Re: [bug#70148] [PATCH] guix-install.sh: Add daemonize to requirements. In-Reply-To: <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@HIDDEN> (Richard Sent's message of "Tue, 2 Apr 2024 12:14:16 -0400") References: <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@HIDDEN> Date: Sat, 04 May 2024 18:49:31 +0200 Message-ID: <87wmo9sesk.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70148 Cc: 70148 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi Richard, Richard Sent <richard@HIDDEN> skribis: > * etc/guix-install.sh (REQUIRE): Add daemonize to requirements list. > Needed to spawn the Guix Daemon in guix-daemon.in > > Change-Id: I77c7f2bdd686bb023ecfa108a499c2eafbad1eb7 > --- > > Hi Guix. I noticed that in Debian WSL the guix daemon sysvinit service > wouldn't start due to daemonize not being present. This patch should > catch that issue sooner. > > Both openrc and sysvinit use guix-daemon.in so daemonize should be > required regardless of the init system. =E2=80=98daemonize=E2=80=99 seems to be used by etc/init.d/guix-daemon.in, = but not by etc/openrc/guix-daemon.in, right? > REQUIRE=3D( > + "daemonize" My only concern is if the majority of users (which I assume use systemd) would get an error for a missing package they don=E2=80=99t actually need. Do you think that is a risk or is =E2=80=98daemonize=E2=80=99 usually insta= lled =E2=80=9Cby default=E2=80=9D even on those systemd distros? Thanks, Ludo=E2=80=99.
guix-patches@HIDDEN:bug#70148; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 2 Apr 2024 16:22:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 02 12:22:19 2024
Received: from localhost ([127.0.0.1]:55836 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rrgtr-0008NB-JB
for submit <at> debbugs.gnu.org; Tue, 02 Apr 2024 12:22:19 -0400
Received: from lists.gnu.org ([2001:470:142::17]:56456)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <richard@HIDDEN>) id 1rrgtm-0008Lb-49
for submit <at> debbugs.gnu.org; Tue, 02 Apr 2024 12:22:14 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <richard@HIDDEN>)
id 1rrgta-0000tw-Hd
for guix-patches@HIDDEN; Tue, 02 Apr 2024 12:21:58 -0400
Received: from mail-108-mta46.mxroute.com ([136.175.108.46])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <richard@HIDDEN>)
id 1rrgtY-0001oI-3O
for guix-patches@HIDDEN; Tue, 02 Apr 2024 12:21:58 -0400
Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com)
(Authenticated sender: mN4UYu2MZsgR)
by mail-108-mta46.mxroute.com (ZoneMTA) with ESMTPSA id 18e9f9deaac0003bea.001
for <guix-patches@HIDDEN>
(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
Tue, 02 Apr 2024 16:21:50 +0000
X-Zone-Loop: baecaac8d03564c464822a785361533782971da0a5d9
X-Originating-IP: [136.175.111.2]
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:MIME-Version:
Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=GLmgSVrtIJ+5ImW6Xk3aZ3Kuyrh/o1wS6eABoget5zw=; b=r0r+BQ3gcV3PrL96ebuNCRdMn+
I06DA5LSOdFbbVzFud0HhopyF3+QNA2CEOIpRqwRwWKGBbyWvnKEaf8a7bUK7klF1G4k/V4nLWFv3
O8WZrazhGwjzJ5cEsQhf15nR0uNPCkDwytil6F5ZOh7osFDt5e/JhgPA+BUgmFpP5eUyudextgBlO
z98BusIcKFeDB9EtE2JnQk2WyWlNLl/pUCri4GmsK/vrZ18L4kdIYhNddQAxrs7DozuHe3pEzvxUb
Gs0hz3Qf2Ai13qLsS0mSAaUqnNLGvvQjMYqS9B+cK/6iC+T2soQBXNJxr1j+hR1+abo3XJ4qy+C2c
cegW0ULA==;
From: Richard Sent <richard@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] guix-install.sh: Add daemonize to requirements.
Date: Tue, 2 Apr 2024 12:14:16 -0400
Message-ID: <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Authenticated-Id: richard@HIDDEN
Received-SPF: pass client-ip=136.175.108.46;
envelope-from=richard@HIDDEN; helo=mail-108-mta46.mxroute.com
X-Spam_score_int: -16
X-Spam_score: -1.7
X-Spam_bar: -
X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1,
DKIM_SIGNED=0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
Cc: Richard Sent <richard@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)
* etc/guix-install.sh (REQUIRE): Add daemonize to requirements list.
Needed to spawn the Guix Daemon in guix-daemon.in
Change-Id: I77c7f2bdd686bb023ecfa108a499c2eafbad1eb7
---
Hi Guix. I noticed that in Debian WSL the guix daemon sysvinit service
wouldn't start due to daemonize not being present. This patch should
catch that issue sooner.
Both openrc and sysvinit use guix-daemon.in so daemonize should be
required regardless of the init system.
etc/guix-install.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 982fb0a266..94ecb1d8f3 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -56,6 +56,7 @@ set -eo pipefail
[ "$UID" -eq 0 ] || { echo "This script must be run as root."; exit 1; }
REQUIRE=(
+ "daemonize"
"dirname"
"readlink"
"wget"
base-commit: d67e4f0f9b10c7ddac8fb0ca68cbf1d6ad0a6e5d
--
2.41.0
Richard Sent <richard@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#70148; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.