GNU bug report logs - #70269
[PATCH] gnu: Add python-pybadges.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70269 in the body.
You can then email your comments to 70269 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Giacomo Leidi <goodoldpaul <at> autistici.org>
To: guix-patches <at> gnu.org
Cc: Giacomo Leidi <goodoldpaul <at> autistici.org>
Subject: [PATCH] gnu: Add python-pybadges.
Date: Mon,  8 Apr 2024 00:13:02 +0200

* gnu/packages/python-web.scm (python-pybadges): New variable.

Change-Id: Idd53ddf94b24112015c0a0b82396cf366920417e
---
 gnu/packages/python-web.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 9ad081beb1..da4f019476 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -9123,6 +9123,40 @@ (define-public python-whatthepatch
      "This package provides a library to parse and apply patches.")
     (license license:expat)))
 
+(define-public python-pybadges
+  (package
+    (name "python-pybadges")
+    (version "3.0.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/google/pybadges")
+                    (commit (string-append version))))
+              (file-name (git-file-name name version))
+              (sha256
+               "1zgb9idz7m3mzf8wvik0gwmyrxp753axqjv2pab326cr5myj1s4b")))
+    (build-system pyproject-build-system)
+    (arguments
+     (list
+      #:test-flags
+      #~'("-k"
+          ;; Disable network dependent tests.
+          "not test_changes and not test_not_image_url and not test_http_url")))
+    (propagated-inputs (list python-jinja2 python-requests))
+    (native-inputs (list python-flask
+                         python-fonttools
+                         python-nox
+                         python-pillow
+                         python-pytest
+                         python-xmldiff))
+    (home-page "https://github.com/google/pybadges")
+    (synopsis
+     "Libbrary and command-line tool for generating Github-style badges")
+    (description
+     "This package provides @code{python-pybadges}: a library and command-line
+tool for generating Github-style badges.")
+    (license license:asl2.0)))
+
 (define-public python-grid5000
   (package
     (name "python-grid5000")

base-commit: 69951a61a1d8f1f2135ea2dc836738be282b97bc
-- 
2.41.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Giacomo Leidi via Guix-patches via <guix-patches <at> gnu.org>,
 70269 <at> debbugs.gnu.org
Cc: Giacomo Leidi <goodoldpaul <at> autistici.org>,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 Munyoki Kilyungi <me <at> bonfacemunyoki.com>, Lars-Dominik Braun <lars <at> 6xq.net>,
 jgart <jgart <at> dismail.de>, Marius Bakke <marius <at> gnu.org>,
 Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: Re: [bug#70269] [PATCH] gnu: Add python-pybadges.
Date: Mon, 13 May 2024 07:40:10 +0200

On 2024-04-08 00:13, Giacomo Leidi via Guix-patches via wrote:

> * gnu/packages/python-web.scm (python-pybadges): New variable.
>
> Change-Id: Idd53ddf94b24112015c0a0b82396cf366920417e
> ---
>  gnu/packages/python-web.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 9ad081beb1..da4f019476 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -9123,6 +9123,40 @@ (define-public python-whatthepatch
>       "This package provides a library to parse and apply patches.")
>      (license license:expat)))
>  
> +(define-public python-pybadges
> +  (package
> +    (name "python-pybadges")
> +    (version "3.0.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/google/pybadges")
> +                    (commit (string-append version))))

(string-append with a single string is a bit odd ;)

> +              (file-name (git-file-name name version))
> +              (sha256
> +               "1zgb9idz7m3mzf8wvik0gwmyrxp753axqjv2pab326cr5myj1s4b")))
> +    (build-system pyproject-build-system)
> +    (arguments
> +     (list
> +      #:test-flags
> +      #~'("-k"
> +          ;; Disable network dependent tests.
> +          "not test_changes and not test_not_image_url and not test_http_url")))
> +    (propagated-inputs (list python-jinja2 python-requests))
> +    (native-inputs (list python-flask
> +                         python-fonttools
> +                         python-nox
> +                         python-pillow
> +                         python-pytest
> +                         python-xmldiff))
> +    (home-page "https://github.com/google/pybadges")
> +    (synopsis
> +     "Libbrary and command-line tool for generating Github-style badges")
           ^ typo there
> +    (description
> +     "This package provides @code{python-pybadges}: a library and command-line
> +tool for generating Github-style badges.")

Maybe you can be a bit more descriptive: "as SVG images" in the Github
description is informative. I often also like (but I'm not sure it's a
norm) to write my synopsis as an action statement, such as "Generate
Github-style badges on the command-line".

> +    (license license:asl2.0)))

Otherwise LGTM.

> +
>  (define-public python-grid5000
>    (package
>      (name "python-grid5000")
>
> base-commit: 69951a61a1d8f1f2135ea2dc836738be282b97bc

-- 
Best regards,
Nicolas Graves

Message #14 received at 70269 <at> debbugs.gnu.org (full text, mbox):

From: paul <goodoldpaul <at> autistici.org>
To: Nicolas Graves <ngraves <at> ngraves.fr>, 70269 <at> debbugs.gnu.org
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 Munyoki Kilyungi <me <at> bonfacemunyoki.com>, Lars-Dominik Braun <lars <at> 6xq.net>,
 jgart <jgart <at> dismail.de>, Marius Bakke <marius <at> gnu.org>,
 Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: Re: [bug#70269] [PATCH] gnu: Add python-pybadges.
Date: Mon, 13 May 2024 19:07:40 +0200

Hi Nicolas,


Thank you for your review: I'm sending an updated patch.


giacomo

Message #17 received at 70269 <at> debbugs.gnu.org (full text, mbox):

From: Giacomo Leidi <goodoldpaul <at> autistici.org>
To: 70269 <at> debbugs.gnu.org
Cc: Giacomo Leidi <goodoldpaul <at> autistici.org>
Subject: [PATCH v2] gnu: Add python-pybadges.
Date: Mon, 13 May 2024 19:05:52 +0200

* gnu/packages/python-web.scm (python-pybadges): New variable.

Change-Id: Idd53ddf94b24112015c0a0b82396cf366920417e
---
 gnu/packages/python-web.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index affa2f52f4..df19b30386 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -9183,6 +9183,40 @@ (define-public python-whatthepatch
      "This package provides a library to parse and apply patches.")
     (license license:expat)))
 
+(define-public python-pybadges
+  (package
+    (name "python-pybadges")
+    (version "3.0.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/google/pybadges")
+                    (commit (string-append version))))
+              (file-name (git-file-name name version))
+              (sha256
+               "1zgb9idz7m3mzf8wvik0gwmyrxp753axqjv2pab326cr5myj1s4b")))
+    (build-system pyproject-build-system)
+    (arguments
+     (list
+      #:test-flags
+      #~'("-k"
+          ;; Disable network dependent tests.
+          "not test_changes and not test_not_image_url and not test_http_url")))
+    (propagated-inputs (list python-jinja2 python-requests))
+    (native-inputs (list python-flask
+                         python-fonttools
+                         python-nox
+                         python-pillow
+                         python-pytest
+                         python-xmldiff))
+    (home-page "https://github.com/google/pybadges")
+    (synopsis
+     "Generate Github-style badges on the command-line")
+    (description
+     "This package provides @code{python-pybadges}: a library and command-line
+tool for generating Github-style badges as SVG images.")
+    (license license:asl2.0)))
+
 (define-public python-grid5000
   (package
     (name "python-grid5000")

base-commit: aa9ac252206615713ab988d7068da9e14a9bccc0
-- 
2.41.0

Message #20 received at 70269 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: control <at> debbugs.gnu.org,70269 <at> debbugs.gnu.org
Subject: QA review for 70269
Date: Tue, 14 May 2024 22:10:44 +0200

user guix
usertag 70269 + reviewed-looks-good
thanks

Guix QA review form submission:
LGTM

Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package tests, New package synopsis and descriptions

-- 
Best regards,
Nicolas Graves

Message #23 received at 70269 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 70269 <at> debbugs.gnu.org
Subject: Comments
Date: Wed, 15 May 2024 15:58:13 +0200

Hello,

the lonely "string-append" is still there, and the description a bit short.
I would not mind changing that myself, but since I am having trouble
downloading the patch anyway (clicking on "download raw message" in
issues.guix.gnu.org drops the attached commit), I will let you send in
a third version.

Thanks!

Andreas

Message #28 received at 70269-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Giacomo Leidi <goodoldpaul <at> autistici.org>
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 Munyoki Kilyungi <me <at> bonfacemunyoki.com>, 70269-done <at> debbugs.gnu.org,
 Lars-Dominik Braun <lars <at> 6xq.net>, jgart <jgart <at> dismail.de>,
 Marius Bakke <marius <at> gnu.org>, Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: Re: [bug#70269] [PATCH v2] gnu: Add python-pybadges.
Date: Fri, 31 May 2024 12:02:40 +0200

[Message part 1 (text/plain, inline)]

Hi,

Applied with the changes below, as suggested by Andreas.

Thanks everyone!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 4970366c93d..5ca50fa5a6c 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -9232,7 +9232,7 @@ (define-public python-pybadges
               (method git-fetch)
               (uri (git-reference
                     (url "https://github.com/google/pybadges")
-                    (commit (string-append version))))
+                    (commit version)))
               (file-name (git-file-name name version))
               (sha256
                "1zgb9idz7m3mzf8wvik0gwmyrxp753axqjv2pab326cr5myj1s4b")))
@@ -9251,8 +9251,7 @@ (define-public python-pybadges
                          python-pytest
                          python-xmldiff))
     (home-page "https://github.com/google/pybadges")
-    (synopsis
-     "Generate Github-style badges on the command-line")
+    (synopsis "Generate Github-style badges on the command-line")
     (description
      "This package provides @code{python-pybadges}: a library and command-line
 tool for generating Github-style badges as SVG images.")

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.