GNU bug report logs - #70301
30.0.50; secrets-create-item mangles cyrillic passwords

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs; Reported by: k.ninev@HIDDEN; Keywords: patch; dated Tue, 9 Apr 2024 08:20:04 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 70301 <at> debbugs.gnu.org:


Received: (at 70301) by debbugs.gnu.org; 12 Apr 2024 08:14:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 12 04:14:46 2024
Received: from localhost ([127.0.0.1]:57815 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rvC3Z-0002D3-Sw
	for submit <at> debbugs.gnu.org; Fri, 12 Apr 2024 04:14:46 -0400
Received: from mout.gmx.net ([212.227.17.20]:51225)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1rvC3W-0002BR-UW
 for 70301 <at> debbugs.gnu.org; Fri, 12 Apr 2024 04:14:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de;
 s=s31663417; t=1712909659; x=1713514459; i=michael.albinus@HIDDEN;
 bh=ynzbcooBf+nDUsC3vAfvMtNnZO3GawyPTHz73KQ4GYI=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date:
 Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding:
 content-type:date:from:message-id:mime-version:reply-to:subject:
 to;
 b=RHZz64kMq4/yCv+g+LX8FAIaqrwIb4Q+8gaoSF24yuhPjaTNe4npTcr9jlglhBXO
 CazmAp4jmRHtT6i228LysUIbYuDXLStYXrdiu+mjMZYcPrsZ1URKD5FSouTGUSv+e
 /AMJDybNlMx3W4DAPBTbVy5RbTswxUN0u6C/e2Q6bd2ddCqsj50PFNzzh0Ul4qMjR
 8uow4qoqYtN8FKygmHcWvS/xQN/USZwOJO1z0m4dRlp/IrR+Li4JbLgI6NCTMgVII
 mb6l2m21hY5gR3vHuD9wW2RqRKJUhIABvSzHz/ArCvUL5LSfkeMco0EJxnhuak6ri
 EqP68uW51czvFTXrDQ==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx105
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MgvrB-1sP25G1kC5-00hLc6; Fri, 12
 Apr 2024 10:14:19 +0200
From: Michael Albinus <michael.albinus@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#70301: 30.0.50; secrets-create-item mangles cyrillic passwords
In-Reply-To: <87bk6hryg7.fsf@HIDDEN> (Michael Albinus's message of "Wed, 10
 Apr 2024 18:10:00 +0200")
References: <1712650236526.1662743497.3911072838@HIDDEN>
 <86o7aix3wq.fsf@HIDDEN> <87jzl5s06c.fsf@HIDDEN>
 <86o7ahusrg.fsf@HIDDEN> <87bk6hryg7.fsf@HIDDEN>
Date: Fri, 12 Apr 2024 10:14:18 +0200
Message-ID: <87o7afyp45.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:Wb9S9ruC7vWfOPuFekylMVqU+s0tvPkdFWDKm6td5VT7+VPzAhI
 B4YZWFD5X4ikyBUXVf3Ga1reK+hkJzRAr08DD5UcGP89fCU3Ssy08JCA+dP8RBNdq8cCqM2
 CIdPNqTEi9jg5b/UGITBAN4RoOe4AA5OJFFLcDwj/tIG5L8MGQ79zAQecxhj/vVBI/1Te1L
 cGlkfxSQ5fS0GUVkKmqvQ==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:oBMvsiudsQo=;hmohF+1Vaaph44l/38nb3c3nDE1
 o5D/ElwgBUiMr49CjABiH4qeN4zeh6GNNimANUDM3W6zIrRIPx9NAwzkEcXoGtsU2hWIgpxer
 YBebQdgrUjaqEcvEsq5jOFAzFXm0nJn827t/3nbKeF0ZqVHJHs2JnmsuVgA6rN+g8lBJF/YcX
 27TApmRUI2y9ADp8YDAZlBaUgFPO9ZAgws206ZDg4U8rIeKXj2x75c1Yqhtv//NOO4VtKN8kU
 hDOSBbZgA8xI4X/6yUlk5e7RopPV4QuKwYUwMLBRjWhI/7sqzOFlc8tlonsVtEkyZfNE4ChAD
 io3y+aZIptRgcn5Agpl0V0q/oZUaVdlx+ZpwRNW7R924SNwz52P/XZ3EwDmHaWM9ShwiVHNyd
 ydjUT+cYcqQyIr4oEWodD0E5v0ZV5+3q03sqIigrLOHzePwKt9BeCkyAP+JW9bU7iozZSRBVy
 yKguRVguGAMB3zvosNJgU7+5mmJXd7jDvbA9qt9op2q48z2wQ5mmu8bi62gWBF/qbbsQShCpN
 mWF68z0pVFTVqNd2VQK019qehi/0OTmbmapMdQuIdVpA5fs5A6GJUB4O/aLxyAXcOuA8y3+WN
 9M192Vy+Hz5WvjBXa13Z5vmfnUZ6/O7gFTGImY5ptVkV3AmX7IDMSdQm3zoUNKa3ThRmf/Yi7
 GKgQRbabM/JwKTSz27IOPTlDNy9q3pHYAgQI+ke2HNU5NF8Mo3r3Ys+0Ehk5QfvHHXI3cFuVx
 OG8Fjk0LQu7XzFJN88okNZ1kgKc7F+zDPHwGnwPxse7rrKMBjmZg1/dHnY3S1W5I8lgVHUqw+
 mtj6yw7erpcz8S/QvJEB9Y96uQuEFG+oSrmht9LeUevi0=
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 70301
Cc: 70301 <at> debbugs.gnu.org, k.ninev@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Michael Albinus <michael.albinus@HIDDEN> writes:

> I'll puzzle everything together by tomorrow.

Pushed to master. Could you, pls, check whether it works as expected?

Best regards, <<michael.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70301; Package emacs. Full text available.

Message received at 70301 <at> debbugs.gnu.org:


Received: (at 70301) by debbugs.gnu.org; 10 Apr 2024 16:10:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 10 12:10:27 2024
Received: from localhost ([127.0.0.1]:54235 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ruaWp-0001WP-Ih
	for submit <at> debbugs.gnu.org; Wed, 10 Apr 2024 12:10:27 -0400
Received: from mout.gmx.net ([212.227.17.22]:50217)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1ruaWm-0001Vv-UD
 for 70301 <at> debbugs.gnu.org; Wed, 10 Apr 2024 12:10:26 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de;
 s=s31663417; t=1712765402; x=1713370202; i=michael.albinus@HIDDEN;
 bh=/q4Ia6QX4HLyKBPggIGNUe3oZSi4Xl7x9pXy5pmKv0o=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:
 Date;
 b=ZzN3huCFECH4EWdGWaBFC5FCzkvk5MgGOveuy7iLDGzLyioH0ONNPo/n/nFjQF0d
 /UpZxxst0t89WIa+GdvpW2oqgOuPil+GTe+1u3w5m7hfYOIiCNN+1gHz6ICieGwjA
 bbk00TK/6KyawNRwA00zFDt3ylHrrUCfiu8fBUrEYeQPy1fY381dgfJkM7LH4k0HX
 Z5f5NL1k+LwZaHHr7+tCPZ8r10YVq6LpJe++p6lJ//g+k5zbk7Io9lfwFy2XpAImy
 uHLDXJKBBVQO2CFANxy3kMIo41CXGYZQLjJIhyZI+ucnGRdivs4jXDxkSbmlW+yjv
 0ZAs6JtjNXFakpmmLA==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx105
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MF3HU-1s17y53oIi-00FPkr; Wed, 10
 Apr 2024 18:10:01 +0200
From: Michael Albinus <michael.albinus@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#70301: 30.0.50; secrets-create-item mangles cyrillic passwords
In-Reply-To: <86o7ahusrg.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 10 Apr
 2024 18:44:35 +0300")
References: <1712650236526.1662743497.3911072838@HIDDEN>
 <86o7aix3wq.fsf@HIDDEN> <87jzl5s06c.fsf@HIDDEN>
 <86o7ahusrg.fsf@HIDDEN>
Date: Wed, 10 Apr 2024 18:10:00 +0200
Message-ID: <87bk6hryg7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:1DOSdlMNW3qCDhZC8fJC143XGiPFlBOCfJ7m3lakto+Pn9hKekj
 OhF7y9czNPW7rEtqKRBN2K5NHa0P8RCZBflAH4JPclZ3LokyjLYPDi2RR67xurqVgQsUK7U
 w4DqHEGc6TFrFjMKMGNE/qz1Qhchc37PcWTJjAs0B+GQY+iVZ8SPP/dWc4ksUjp6rA2EZ97
 mRYs7q+YuMvfc8/IdgIPg==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:06O2wdFNSyU=;WHHrV4Mt1SwwP95Opxf5PssytxQ
 Rb3MznZ1X8Lm+3TsQ+Fjg7pjSneS2cAEVOczH9AUeckV1Na+yVzbCJrxr2mCnXiTp05UN9l73
 x4CmTvUze5NRBoT4vq32+j89ShFEc7qBB1flp3RZ+MAPU3fHu6TWnmqTIa/LdyyuoJmoB9I2I
 Wtwo2/InHlc45H/RKL2RkDTCjX5Vs12zM72biyQ/ZbrqoZBJnywd81oETgtViwImc/58Vn03l
 rjvgNMokzNUPu/yZZ43arBh+0XDPH28X/rlokV3Zx5Wu4v3DyghsNv2zuOYEIqHZ7MoGuOfBq
 vlvaFnW6rPZBUib96trXl608+Sj9YSKKEah/+eq7D6PcomQNDwsGirrIFU5eHMfU4wsDPccvT
 H0daxFuaFzHKR/XcPIEU3+6x8A/2Y04b6eq+m1EtJlNyAJ7nhCCJG3r2dAhlxRWy+Tb3ZdUtT
 3MCjfe7je5qh11c/fhBhwIgVG1j+5qCVzB7VOlnJQALe9uMyM4/z1wDDn1646tz3VQ+56hFYF
 IAf+tVm9hDYsQqesM5AFMhy4UezHDlMLwzN3t2iLgg04sMFCgOB2f5j1tIZhZkmwC1xLoKtcE
 DbRWaIR8BFaHFi31Qkvzb+3kbtHxJtO4dTIE/yZ9oj7nprFP9FOucSFceBgqcinalr/m2pHep
 Pf/7zMXhLDjnz/0pqg1kpciLo5NDaqX2FsiNj/RqWbzReMF2whWZRuHMEIfCHBDtJrHXMQ1ry
 SSjUIlrouDiOsOVWvENcgXfqFarzyh5SsIwWhwXcXV3HvqsAff3wrBO2LyJ8CDWF1YScXgKpT
 FSaGOzKeF05ejmZdyZ7xBSpm1+Nk1YW3q6dwuT0ll3gjI=
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 70301
Cc: 70301 <at> debbugs.gnu.org, k.ninev@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

Hi Eli,

>> Thanks for the patch. However, I believe we shouldn't fix it in
>> secrets.el, but in dbus.el.
>
> Then we ought to update the doc string of dbus-string-to-byte-array,
> which currently says the argument should be a UTF-8 encoded string.

Yep.

>> > Michael, I think we have a similar problem in
>> > dbus-byte-array-to-string: when MULTIBYTE is non-nil, the function
>> > should call decode-coding-string on the unibyte string it produces
>> > instead of converting each byte to multibyte.  Because the bytes in
>> > the argument BYTE-ARRAY are not characters, they are raw bytes of the
>> > UTF-8 sequence, so calling 'string' on them is not TRT.
>>
>> Yes. The following patch works for me. WDYT?
>
> If you are okay with changing the behavior of
> dbus-byte-array-to-string in backward-incompatible ways, I don't mind.
> But maybe this should be called out in NEWS.

I'm aware of this incompatibility. Well, I've played several hours today
with this. Since we have no information from D-Bus about the underlying
byte array, we must assume a given context. A sequence of raw 8-bit
bytes, unibyte, representing an UTF-8 encoded string seems to be aapropriate.

If people want another conversion for a D-Bus byte array, it is still
possible. But they shouldn't use dbus-byte-array-to-string and
dbus-string-to-byte-array then.

I'll puzzle everything together by tomorrow.

Best regards, <<michael.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70301; Package emacs. Full text available.

Message received at 70301 <at> debbugs.gnu.org:


Received: (at 70301) by debbugs.gnu.org; 10 Apr 2024 15:44:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 10 11:44:58 2024
Received: from localhost ([127.0.0.1]:54201 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rua88-00036n-Ms
	for submit <at> debbugs.gnu.org; Wed, 10 Apr 2024 11:44:58 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:42226)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rua85-00035N-3W
 for 70301 <at> debbugs.gnu.org; Wed, 10 Apr 2024 11:44:55 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rua7q-000730-4k; Wed, 10 Apr 2024 11:44:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=xhlATQzFrZ5VDC/0gf43MMOs1G47B3nvoq7mzMDCdRg=; b=HSmMNjj0aiYs
 WRp8Hy+9SSqFiFI/jpBeKgTHlqO3UUIoNLcM34ANHJxEA55qiZUp6LhH7EPwTUyv9guOr97vEmy4V
 oguUtOaIuz8A/C8F0I0Uye1EtAVQoyI8/9VuNphh/iuNL/JOQSvtGmKKJ+o1WxQUIpAuAS8KJRxZb
 mQISaVLRK6XeMTqXBAtdi0/rEUW/AgwGH1bI42Ku1MU8jUm8r0YJRZnYVnnSRKr0wH7T6l80Rop2b
 2MFM8tzOh98+GGOMQaWe85OGlXqGFik8W+n27RGEAEz9EfOGfGncyZha0Rc954of6UnSTdzQoD00m
 euZ0UOuupsyLYqoRr3RBFw==;
Date: Wed, 10 Apr 2024 18:44:35 +0300
Message-Id: <86o7ahusrg.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
In-Reply-To: <87jzl5s06c.fsf@HIDDEN> (message from Michael Albinus on Wed, 10
 Apr 2024 17:32:43 +0200)
Subject: Re: bug#70301: 30.0.50; secrets-create-item mangles cyrillic passwords
References: <1712650236526.1662743497.3911072838@HIDDEN>
 <86o7aix3wq.fsf@HIDDEN> <87jzl5s06c.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 70301
Cc: 70301 <at> debbugs.gnu.org, k.ninev@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Michael Albinus <michael.albinus@HIDDEN>
> Cc: k.ninev@HIDDEN,  70301 <at> debbugs.gnu.org
> Date: Wed, 10 Apr 2024 17:32:43 +0200
> 
> > Does the patch below give good results?
> 
> Thanks for the patch. However, I believe we shouldn't fix it in
> secrets.el, but in dbus.el.

Then we ought to update the doc string of dbus-string-to-byte-array,
which currently says the argument should be a UTF-8 encoded string.

> > Michael, I think we have a similar problem in
> > dbus-byte-array-to-string: when MULTIBYTE is non-nil, the function
> > should call decode-coding-string on the unibyte string it produces
> > instead of converting each byte to multibyte.  Because the bytes in
> > the argument BYTE-ARRAY are not characters, they are raw bytes of the
> > UTF-8 sequence, so calling 'string' on them is not TRT.
> 
> Yes. The following patch works for me. WDYT?

If you are okay with changing the behavior of
dbus-byte-array-to-string in backward-incompatible ways, I don't mind.
But maybe this should be called out in NEWS.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70301; Package emacs. Full text available.
Added tag(s) patch. Request was from Michael Albinus <michael.albinus@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 70301 <at> debbugs.gnu.org:


Received: (at 70301) by debbugs.gnu.org; 10 Apr 2024 15:33:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 10 11:33:10 2024
Received: from localhost ([127.0.0.1]:54187 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ruZwj-0001Nc-54
	for submit <at> debbugs.gnu.org; Wed, 10 Apr 2024 11:33:10 -0400
Received: from mout.gmx.net ([212.227.17.20]:51633)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <michael.albinus@HIDDEN>) id 1ruZwf-0001Le-Sh
 for 70301 <at> debbugs.gnu.org; Wed, 10 Apr 2024 11:33:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de;
 s=s31663417; t=1712763164; x=1713367964; i=michael.albinus@HIDDEN;
 bh=F78+uJjtUnzj62w34EYspKKtvEYwFrwxb9G68dBi7lU=;
 h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date:
 Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding:
 content-type:date:from:message-id:mime-version:reply-to:subject:
 to;
 b=RCz1m/az13sEwHHtHdF59CnmF+P2kO+2jxf4Zcuylf6ToogGYwtcecDt6E4P3/Px
 scBo9psth+4Onf0nWSIFIjFeyrDhzvAYzmnfVbRqbl8p2oEGjW6NGeZbVqhGhyq89
 XJSGrZPNX2YcsX3xVMCeghbwtSnzcOfYInNkbrhnzcmdnqh6Qe69r3htHh5qhTB3V
 0fb7DV/8fMziHAiCiUpQldhDv7AiMgCsB7s0NYb0RtjtOBepABu9bvvdnCZ+lPHqW
 s8eU4ebZdIHqosngtxHKACeSoaMIpRK0r4hetuvL/XoeUrd7b1eYLRkoGCBkSNT/9
 5R6RUqW/PdRpmaHJkg==
X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a
Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx104
 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M4s51-1rtD1n0INj-0020ik; Wed, 10
 Apr 2024 17:32:44 +0200
From: Michael Albinus <michael.albinus@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#70301: 30.0.50; secrets-create-item mangles cyrillic passwords
In-Reply-To: <86o7aix3wq.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 09 Apr
 2024 12:48:37 +0300")
References: <1712650236526.1662743497.3911072838@HIDDEN>
 <86o7aix3wq.fsf@HIDDEN>
Date: Wed, 10 Apr 2024 17:32:43 +0200
Message-ID: <87jzl5s06c.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Provags-ID: V03:K1:MtvW8iF99b3XCJv65XGAtdoIesBZpXdgYPU13szzDg10hDLjSCQ
 OeQcvjBxCaqVN3hdpImHMYkKB2m5BfgdlYVnVxy7ICGCQzJ60YFs5uQX+Pxw9KLrNW7eqhV
 moJpBh23CnmhaNK16dos5/DtfmjH6cMSQP0MgmOdRmSi2PQyR4JKB48QszXoeHKFA7bjG1+
 h7ZIxu9WzZRDxfgAa5zyA==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:ZsociVLCtMk=;th9qft1JvBPB+e2UhAavwgms388
 vLNNcFwgeeUjORQ3vp3EYhR2Era5Z6X45d11ATsWcy5fjVhCFlA6Ulrtre+f1J+Bz1dAK3Du1
 C5caOb4Ljh7nSDRr7pR1uv57Ih91SNgiuYBHmSGMcgJruoZdzRte4/RM3fRGUIG7tN74kWf4g
 VSbW1+KBr4/VTQ7D9Ke0GojwH+C30Qcm3y+xkyvxrvCixpK2bOBPzYv4a3oNXDbWZ6Ib8STJD
 /i+0SwcZ0bjl72ZiQ9zKlc2g6Gt/sGB6xigJUN1pRy+7J70bNXlKey2+h4z+ZwNYDqz2G+IZr
 khbZKYwjFbuvCHmexee9/E0YRkUnaMPswAdT6b5rthzoJClEU8kGPYIbEoWmSaIUFcpplWRqp
 ojjCxzgrt+eI213d+oAjLQSjq1jZ9000B5nJb0BuP9MWPbzNACTvJFCOoRNrGBLrarZNhHX0b
 SAKDqW+elBOxYQoXXVfeRpiGvbz90a8FI8Onim9SYV1Kv4bWh+zSlH7QrIncSMj7MtvMT0oYh
 dz6IHWwnsOgGHvIZMTICnk5mGAZzVxC8CmtXvW2rCayUEEkIv5SPJfwxt4+cNZ2y2pesL6LOU
 QPQygOTWsiIUkr0P2JUcDQ9/eo5b4GDN4zxpgxFKtn04IcvRyXwYM9efq0XOyg2OW0NLLMeXg
 d58jjXnzKYGZwt8PxIkukE16aukc/UlKgIaJ2KjMsqKxL/ix2SJiDbkgWTG9iX3ZNO1cX5E4k
 sUEZIGr0Oc28Yd0EOD62hNOGLPd5kECc8Mxs7Jz0MEtjYfTATCEeHHhwkWB8buzrynM4M593x
 vVVVWSOh0/6BM2JmM6aNhz05WuTSSxXN3J4sCxc5D7tO0=
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 70301
Cc: 70301 <at> debbugs.gnu.org, k.ninev@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain

Eli Zaretskii <eliz@HIDDEN> writes:

Hi Eli,

> Does the patch below give good results?

Thanks for the patch. However, I believe we shouldn't fix it in
secrets.el, but in dbus.el.

> Michael, I think we have a similar problem in
> dbus-byte-array-to-string: when MULTIBYTE is non-nil, the function
> should call decode-coding-string on the unibyte string it produces
> instead of converting each byte to multibyte.  Because the bytes in
> the argument BYTE-ARRAY are not characters, they are raw bytes of the
> UTF-8 sequence, so calling 'string' on them is not TRT.

Yes. The following patch works for me. WDYT?


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

diff --git a/lisp/net/dbus.el b/lisp/net/dbus.el
index 46f85daba24..11c87e72d4e 100644
=2D-- a/lisp/net/dbus.el
+++ b/lisp/net/dbus.el
@@ -997,17 +997,18 @@ dbus-string-to-byte-array
 STRING shall be UTF-8 coded."
   (if (zerop (length string))
       '(:array :signature "y")
-    (cons :array (mapcan (lambda (c) (list :byte c)) string))))
+    (cons :array
+          (mapcan (lambda (c) (list :byte c))
+                  (encode-coding-string string 'utf-8)))))

-(defun dbus-byte-array-to-string (byte-array &optional multibyte)
+(defun dbus-byte-array-to-string (byte-array &optional _multibyte)
   "Transform BYTE-ARRAY into UTF-8 coded string.
-BYTE-ARRAY must be a list of structure (c1 c2 ...), or a byte
-array as produced by `dbus-string-to-byte-array'.  The resulting
-string is unibyte encoded, unless MULTIBYTE is non-nil."
-  (apply
-   (if multibyte #'string #'unibyte-string)
-   (unless (equal byte-array '(:array :signature "y"))
-     (seq-filter #'characterp byte-array))))
+BYTE-ARRAY must be a unibyte list of structure (c1 c2 ...), or a byte
+array as produced by `dbus-string-to-byte-array'."
+   (if-let ((bytes (seq-filter #'characterp byte-array))
+            (string (apply #'unibyte-string bytes)))
+       (decode-coding-string string 'utf-8)
+     ""))

 (defun dbus-escape-as-identifier (string)
   "Escape an arbitrary STRING so it follows the rules for a C identifier.

--=-=-=--
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70301; Package emacs. Full text available.

Message received at 70301 <at> debbugs.gnu.org:


Received: (at 70301) by debbugs.gnu.org; 9 Apr 2024 10:24:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 09 06:24:22 2024
Received: from localhost ([127.0.0.1]:48393 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ru8eL-0001zE-Ss
	for submit <at> debbugs.gnu.org; Tue, 09 Apr 2024 06:24:22 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:33786)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1ru8eI-0001yH-FO
 for 70301 <at> debbugs.gnu.org; Tue, 09 Apr 2024 06:24:19 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1ru8e3-0005eb-1N; Tue, 09 Apr 2024 06:24:03 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=AE2QF5rm36NVkXtNYk8GlR6WokRuc1K5yxUWv7wsPds=; b=V/zjKXhIZfcb
 ooQe2568r4TlkJsM57vj5IMXMfh+cq1QjEckfMQBTG0+bEwGJBbHgGDz1mcI+IAYrNpQafhs3yzMp
 X658/x5nJomfp8mqegA1iZCGUdbbSkxCV9eHDagS2F7xCS5maGHoNscsLu66c6OALs52+CPDLftuV
 85j3kVLmhHXceWwwr4vWjkjTGUzpYWiXNnzzINdlGp1zvczE1wbgvRRD/dpQXT/Ojiwwa6ClU6umZ
 dx4Wn71qHVX6Hjkm3X4/5V18F/bD6Hr5ExPAbagzbzXqdhhQA484QV7TVVtogahC35IjPKSOTaR6L
 GgeURpERfBXQVVPUGZs0+Q==;
Date: Tue, 09 Apr 2024 13:23:58 +0300
Message-Id: <86jzl6x29t.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: k.ninev@HIDDEN
In-Reply-To: <1712657350147.2542454644.3268333671@HIDDEN> (k.ninev@HIDDEN)
Subject: Re: bug#70301: 30.0.50; secrets-create-item mangles cyrillic passwords
References: <86o7aix3wq.fsf@HIDDEN>
 <1712657350147.2542454644.3268333671@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 70301
Cc: 70301 <at> debbugs.gnu.org, michael.albinus@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: k.ninev@HIDDEN
> Cc: 70301 <at> debbugs.gnu.org
> Date: Tue, 09 Apr 2024 10:09:19 +0000
> 
> 
> Yes, the patch works for me. Thank you.

Thanks for testing.
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70301; Package emacs. Full text available.

Message received at 70301 <at> debbugs.gnu.org:


Received: (at 70301) by debbugs.gnu.org; 9 Apr 2024 10:09:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 09 06:09:39 2024
Received: from localhost ([127.0.0.1]:48353 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ru8Q5-00007A-BG
	for submit <at> debbugs.gnu.org; Tue, 09 Apr 2024 06:09:38 -0400
Received: from mail.cdots.bg ([91.92.199.54]:60928)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <k.ninev@HIDDEN>) id 1ru8Q1-00005b-SC
 for 70301 <at> debbugs.gnu.org; Tue, 09 Apr 2024 06:09:35 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.cdots.bg (Postfix) with ESMTP id 45DAFA0D6352;
 Tue,  9 Apr 2024 13:09:20 +0300 (EEST)
Received: from mail.cdots.bg ([127.0.0.1])
 by localhost (mail.cdots.bg [127.0.0.1]) (amavis, port 10032) with ESMTP
 id hFXsvU1LRa3A; Tue,  9 Apr 2024 13:09:19 +0300 (EEST)
Received: from localhost (localhost [127.0.0.1])
 by mail.cdots.bg (Postfix) with ESMTP id 9CD53A0D634D;
 Tue,  9 Apr 2024 13:09:19 +0300 (EEST)
DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cdots.bg 9CD53A0D634D
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cdots.bg;
 s=38EB8BB6-1E4E-11E5-AEB1-E0FC2BDD2164; t=1712657359;
 bh=Wse4o1wiJAQzQxJ99gsm4DDKqwkdkEsJ4BSfUgVFlNw=;
 h=Message-Id:From:To:Date:MIME-Version;
 b=gtRipSRlilI4XaFMIRkSYK7WbI1Ysyj0Q0bJG+Y17HklhATyC838/bdpeqD74FAxw
 4432r5dQMpl7ufCZfuRKqkJiGopBzJLu/a8LsMsPuOisVSlMtX1NHxo/1SCf4aQRr3
 /aTk3R75EjKruZE0A/oRaU0c05BdAmj2VaE7cieI=
X-Virus-Scanned: amavis at mail.cdots.bg
Received: from mail.cdots.bg ([127.0.0.1])
 by localhost (mail.cdots.bg [127.0.0.1]) (amavis, port 10026) with ESMTP
 id 5tmI0Coa2a5C; Tue,  9 Apr 2024 13:09:19 +0300 (EEST)
Received: from noip.localdomain (unknown [85.196.152.25])
 by mail.cdots.bg (Postfix) with ESMTPSA id 7F4DCA0D3264;
 Tue,  9 Apr 2024 13:09:19 +0300 (EEST)
Content-Type: text/plain; charset=utf-8
Message-Id: <1712657350147.2542454644.3268333671@HIDDEN>
From: k.ninev@HIDDEN
To: Eli Zaretskii <eliz@HIDDEN>, Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#70301: 30.0.50; secrets-create-item mangles cyrillic passwords
Date: Tue, 09 Apr 2024 10:09:19 +0000
In-Reply-To: <86o7aix3wq.fsf@HIDDEN>
References: <86o7aix3wq.fsf@HIDDEN>
X-Mailer: Vivaldi Mail
User-Agent: Vivaldi Mail/6.6.3271.57
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 70301
Cc: 70301 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Yes, the patch works for me. Thank you.

On Tuesday, April 9, 2024 12:48 PM (+03:00), Eli Zaretskii wrote:

> > Date: Tue, 09 Apr 2024 08:18:37 +0000
> > From: k.ninev--- via "Bug reports for GNU Emacs,
> >  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> >=20
> >=20
> > using this Secret Service API code in 'emacs -Q'
> >=20
> > (require 'secrets)
> > (secrets-create-item "session" "my item" "=D0=BF=D0=B0=D1=80=D0=BE=
=D0=BB=D0=B0" :method "sudo" :user
> > "joe" :host "remote-host")
> >=20
> > Successfully creates an entry but the password "=D0=BF=D0=B0=D1=80=
=D0=BE=D0=BB=D0=B0" is mangled to
> > "?0@>;0" and cannot be viewed both with M-x secrets-show-secrets=20
> > and secret-tool cli tool , this does not occur with latin passwords
>=20
> Does the patch below give good results?
>=20
> Michael, I think we have a similar problem in
> dbus-byte-array-to-string: when MULTIBYTE is non-nil, the function
> should call decode-coding-string on the unibyte string it produces
> instead of converting each byte to multibyte.  Because the bytes in
> the argument BYTE-ARRAY are not characters, they are raw bytes of the
> UTF-8 sequence, so calling 'string' on them is not TRT.
>=20
> diff --git a/lisp/net/secrets.el b/lisp/net/secrets.el
> index c1a670f..63fc874 100644
> --- a/lisp/net/secrets.el
> +++ b/lisp/net/secrets.el
> @@ -665,7 +665,8 @@ secrets-create-item
>  	     ;; Secret.
>  	     `(:struct :object-path ,secrets-session-path
>  		       (:array :signature "y") ;; No parameters.
> -		       ,(dbus-string-to-byte-array password)
> +		       ,(dbus-string-to-byte-array
> +                         (encode-coding-string password 'utf-8))
>                         ,secrets-struct-secret-content-type)
>  	     ;; Do not replace. Replace does not seem to work.
>  	     nil))
>=20

--=20
KN
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70301; Package emacs. Full text available.

Message received at 70301 <at> debbugs.gnu.org:


Received: (at 70301) by debbugs.gnu.org; 9 Apr 2024 09:48:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 09 05:48:59 2024
Received: from localhost ([127.0.0.1]:48289 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ru866-0005sG-V0
	for submit <at> debbugs.gnu.org; Tue, 09 Apr 2024 05:48:59 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:50810)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1ru863-0005r7-LW
 for 70301 <at> debbugs.gnu.org; Tue, 09 Apr 2024 05:48:57 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1ru85p-0007vC-G3; Tue, 09 Apr 2024 05:48:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=eVRYXR6MxpfEZ40L5KEkr2qKV4nHzdVwt/NeyZI1Z/g=; b=TA0+yX4E2fswFR0uqpYA
 P5cTiNn6lCA/rrKfqPcycs6GOC6qvGngk4vxIlk993QesdTChJSmGoY6lsDLnIyRLa4Hib96ZJHg3
 GL2sfrWtgdOfgSt3SqOSVIMhY33/ytOK4vDxH/UikypKG2QUhgbEctE8oO3qavXCPsXuEEwvEaAX8
 Rs9yde8WIQP1ocie9Xq6vaYs12PIISnYNSfcmv4czno7VTcmnwU1/rF0x+nMjxN7VBVn7J04QhYoR
 ZeZmieHfzWGnlRHcKItgXAFYSu16o6NLcOrcSvbiFaIzbqccCjZjIkaHH3Ulf/TQQV6hAfpl9ETF8
 x5xk0RJ3txsk6w==;
Date: Tue, 09 Apr 2024 12:48:37 +0300
Message-Id: <86o7aix3wq.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: k.ninev@HIDDEN, Michael Albinus <michael.albinus@HIDDEN>
In-Reply-To: <1712650236526.1662743497.3911072838@HIDDEN>
 (bug-gnu-emacs@HIDDEN)
Subject: Re: bug#70301: 30.0.50; secrets-create-item mangles cyrillic passwords
References: <1712650236526.1662743497.3911072838@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 70301
Cc: 70301 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Tue, 09 Apr 2024 08:18:37 +0000
> From: k.ninev--- via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> 
> using this Secret Service API code in 'emacs -Q'
> 
> (require 'secrets)
> (secrets-create-item "session" "my item" "парола" :method "sudo" :user
> "joe" :host "remote-host")
> 
> Successfully creates an entry but the password "парола" is mangled to
> "?0@>;0" and cannot be viewed both with M-x secrets-show-secrets 
> and secret-tool cli tool , this does not occur with latin passwords

Does the patch below give good results?

Michael, I think we have a similar problem in
dbus-byte-array-to-string: when MULTIBYTE is non-nil, the function
should call decode-coding-string on the unibyte string it produces
instead of converting each byte to multibyte.  Because the bytes in
the argument BYTE-ARRAY are not characters, they are raw bytes of the
UTF-8 sequence, so calling 'string' on them is not TRT.

diff --git a/lisp/net/secrets.el b/lisp/net/secrets.el
index c1a670f..63fc874 100644
--- a/lisp/net/secrets.el
+++ b/lisp/net/secrets.el
@@ -665,7 +665,8 @@ secrets-create-item
 	     ;; Secret.
 	     `(:struct :object-path ,secrets-session-path
 		       (:array :signature "y") ;; No parameters.
-		       ,(dbus-string-to-byte-array password)
+		       ,(dbus-string-to-byte-array
+                         (encode-coding-string password 'utf-8))
                        ,secrets-struct-secret-content-type)
 	     ;; Do not replace. Replace does not seem to work.
 	     nil))
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#70301; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 9 Apr 2024 08:19:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 09 04:19:15 2024
Received: from localhost ([127.0.0.1]:48223 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ru6hF-00066c-1p
	for submit <at> debbugs.gnu.org; Tue, 09 Apr 2024 04:19:14 -0400
Received: from lists.gnu.org ([2001:470:142::17]:51464)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <k.ninev@HIDDEN>) id 1ru6h8-00064h-Ng
 for submit <at> debbugs.gnu.org; Tue, 09 Apr 2024 04:19:10 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <k.ninev@HIDDEN>) id 1ru6gu-0005h2-OO
 for bug-gnu-emacs@HIDDEN; Tue, 09 Apr 2024 04:18:53 -0400
Received: from mail.cdots.bg ([91.92.199.54])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <k.ninev@HIDDEN>) id 1ru6gs-0000nV-2m
 for bug-gnu-emacs@HIDDEN; Tue, 09 Apr 2024 04:18:52 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.cdots.bg (Postfix) with ESMTP id 76FE7A002215
 for <bug-gnu-emacs@HIDDEN>; Tue,  9 Apr 2024 11:18:39 +0300 (EEST)
Received: from mail.cdots.bg ([127.0.0.1])
 by localhost (mail.cdots.bg [127.0.0.1]) (amavis, port 10032) with ESMTP
 id Zlxrxzk38Tf2 for <bug-gnu-emacs@HIDDEN>;
 Tue,  9 Apr 2024 11:18:38 +0300 (EEST)
Received: from localhost (localhost [127.0.0.1])
 by mail.cdots.bg (Postfix) with ESMTP id 57EFEA0BCEC6
 for <bug-gnu-emacs@HIDDEN>; Tue,  9 Apr 2024 11:18:38 +0300 (EEST)
DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cdots.bg 57EFEA0BCEC6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cdots.bg;
 s=38EB8BB6-1E4E-11E5-AEB1-E0FC2BDD2164; t=1712650718;
 bh=Bs+Hk2fIJnaZhjyjMM/IJ+kx3ECvvXgMQUBZmHn/y7s=;
 h=Message-Id:From:To:Date:MIME-Version;
 b=VtpRm8bQEH766SzQhWbHi/VP8HX1iEjrV4XKBX2f2lqW17pfSuiZeHf6Fx1o+V88O
 Pxua9S+0sGixxTYuKhVz0F0/1ne33f1nL2AXmnga0J44QFAKlmpNBqYa6i5wa30ld0
 J+8+Gm4E/lSJNFV8wh/irbtzGFaoLuN2NY3Oo29I=
X-Virus-Scanned: amavis at mail.cdots.bg
Received: from mail.cdots.bg ([127.0.0.1])
 by localhost (mail.cdots.bg [127.0.0.1]) (amavis, port 10026) with ESMTP
 id GhRgwctPHUzO for <bug-gnu-emacs@HIDDEN>;
 Tue,  9 Apr 2024 11:18:38 +0300 (EEST)
Received: from noip.localdomain (unknown [85.196.152.25])
 by mail.cdots.bg (Postfix) with ESMTPSA id 37204A0D30C9
 for <bug-gnu-emacs@HIDDEN>; Tue,  9 Apr 2024 11:18:38 +0300 (EEST)
Content-Type: text/plain; charset=utf-8
Message-Id: <1712650236526.1662743497.3911072838@HIDDEN>
From: k.ninev@HIDDEN
To: bug-gnu-emacs@HIDDEN
Subject: 30.0.50; secrets-create-item mangles cyrillic passwords
Date: Tue, 09 Apr 2024 08:18:37 +0000
X-Mailer: Vivaldi Mail
User-Agent: Vivaldi Mail/6.6.3271.57
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Received-SPF: pass client-ip=91.92.199.54; envelope-from=k.ninev@HIDDEN;
 helo=mail.cdots.bg
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)


using this Secret Service API code in 'emacs -Q'

(require 'secrets)
(secrets-create-item "session" "my item" "=D0=BF=D0=B0=D1=80=D0=BE=D0=BB=
=D0=B0" :method "sudo" :user
"joe" :host "remote-host")

Successfully creates an entry but the password "=D0=BF=D0=B0=D1=80=D0=BE=
=D0=BB=D0=B0" is mangled to
"?0@>;0" and cannot be viewed both with M-x secrets-show-secrets=20
and secret-tool cli tool , this does not occur with latin passwords

Tested with both gnome-keyring and keepassxc as API backends.


--text follows this line-
In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.41, cairo version 1.18.0) of 2024-04-08 built on
 arch-nspawn-197981
Repository revision: 600ac35cc6597b63306786bffd0d762f70555322
Repository branch: master
System Description: Arch Linux

Configured using:
 'configure --prefix=3D/usr --sysconfdir=3D/etc --libexecdir=3D/usr/lib
 --localstatedir=3D/var --mandir=3D/usr/share/man --with-gameuser=3D:games
 --with-modules --without-m17n-flt --without-gconf
 --with-native-compilation=3Dyes --with-xinput2 --with-pgtk
 --without-xaw3d --with-sound=3Dno --with-tree-sitter --without-gpm
 --without-compress-install
 '--program-transform-name=3Ds/\([ec]tags\)/\1.emacs/'
 'CFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -pipe -fno-plt =
-fexceptions
 -Wp,-D_FORTIFY_SOURCE=3D2 -Wformat -Werror=3Dformat-security
 -fstack-clash-protection -fcf-protection -g
 -ffile-prefix-map=3D/build/emacs-git/src=3D/usr/src/debug/emacs-git
 -flto=3Dauto' 'LDFLAGS=3D-Wl,-O1 -Wl,--sort-common -Wl,--as-needed
 -Wl,-z,relro -Wl,-z,now -Wl,-z,pack-relative-relocs -flto=3Dauto''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG
LCMS2 LIBOTF LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY
PDUMPER PGTK PNG RSVG SECCOMP SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER WEBP XIM GTK3 ZLIB

Important settings:
  value of $LC_MONETARY: bg_BG.UTF-8
  value of $LC_NUMERIC: bg_BG.UTF-8
  value of $LC_TIME: bg_BG.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Fundamental

--=20
KN
Acknowledgement sent to k.ninev@HIDDEN:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#70301; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 12 Apr 2024 08:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.