GNU bug report logs - #70312
[PATCH] Avoid unnecessary escaping in url-build-query-string

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 9 Apr 2024 14:59:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 09 10:59:58 2024
Received: from localhost ([127.0.0.1]:51226 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ruCx3-0002yX-8z
	for submit <at> debbugs.gnu.org; Tue, 09 Apr 2024 10:59:58 -0400
Received: from lists.gnu.org ([2001:470:142::17]:52130)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ilmari@HIDDEN>) id 1ruCTW-0007VV-J5
 for submit <at> debbugs.gnu.org; Tue, 09 Apr 2024 10:29:27 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ilmari@HIDDEN>) id 1ruCTG-0006z7-1K
 for bug-gnu-emacs@HIDDEN; Tue, 09 Apr 2024 10:29:10 -0400
Received: from fhigh6-smtp.messagingengine.com ([103.168.172.157])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ilmari@HIDDEN>) id 1ruCTE-00012Y-05
 for bug-gnu-emacs@HIDDEN; Tue, 09 Apr 2024 10:29:09 -0400
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47])
 by mailfhigh.nyi.internal (Postfix) with ESMTP id 227351140154
 for <bug-gnu-emacs@HIDDEN>; Tue,  9 Apr 2024 10:29:04 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute6.internal (MEProxy); Tue, 09 Apr 2024 10:29:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilmari.org; h=cc
 :content-type:content-type:date:date:from:from:in-reply-to
 :message-id:mime-version:reply-to:subject:subject:to:to; s=fm1;
 t=1712672944; x=1712759344; bh=6UP6w0Rzl8jbSN6GLb5ebMkMMbtu9iQh
 TDtLf9vkFxc=; b=hEY7NJZ1cluDV7/XBZ4fhydKy2YgCXvEt1z3uFeNIA3LR4PM
 lRcSihr4ZwzFFGi6IjMrJInP0rNAQ3K0/QxLWIQrJ00an49MBKV74TWtB6WZKjir
 BtFiLuROztBOPkvUtjFXfitXW9lBbYXDZWGBEsx32SOh2AxCJQBrsaTNLgwQMaCU
 RZGrjMpGCjreFx4ksYCXKFYjIerhTCl8gs1NC1+E6icI+W+9ESnbWdH50DWbaz8E
 HaRT0mJ9WwG7uuDLE/PAYLq7iY46T8w8UuN2H3qUJ/vY8+7kc4f3hzQb8f25nQeY
 MKvbpbLGA21p0XlcLhl2Zp1XpbBwIO229Vk0Hg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:content-type:date:date
 :feedback-id:feedback-id:from:from:in-reply-to:message-id
 :mime-version:reply-to:subject:subject:to:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=
 1712672944; x=1712759344; bh=6UP6w0Rzl8jbSN6GLb5ebMkMMbtu9iQhTDt
 Lf9vkFxc=; b=Hx2HW/alkeAL5IF8Ew0xcInPhqOiInaH5X+N37NpTIOZus3FvAA
 xU+hejrAFy8viGUaN8BKhkpQEVL7OYDWQrBp8OgDpbe0C0RPbXJdNUBB1/OO+1d8
 KVCjwYA72g95OFMKokZW20as8ytY2zcYtnTCRpVRXN4HuWnPDn/OQm/rCQH+ap3T
 suwesn+TneqVABxD0axXqkzrXuzyfwrOfoW3O0o8mdSPGwcWm/avTndU+NzSPO+B
 90agjm/JHLPwI39V7mw72Q8drG4QRn+T6I4f8dLtxN5ZSePXuR3MMq/++uFxYinY
 rOQRNXIBmafJiKVkQ+wHwO6E81qwQioJioA==
X-ME-Sender: <xms:r1AVZv0M6fnsWxp0OsGJHAWiCo2BOjlpUd-B0mSAeaAu6r-6e3NGUw>
 <xme:r1AVZuHxF3E8j8NjVSiHEYdTUwVxPalO_6aOGWs72KqSQYtYH5Do_SfekSdwT-20v
 2n9azKMDLHQgp5Igv4>
X-ME-Received: <xmr:r1AVZv56TruKk_4kbzdEnFVCA9a3YSwVWkyo2aNFoEkvq_54H8xbISvH0qXSKmxOMo9LM31p_dVJxoISTA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudehvddgtdekucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkfgggtgesmhdtreertd
 erjeenucfhrhhomhepffgrghhfihhnnhcukfhlmhgrrhhiucforghnnhhsnohkvghruceo
 ihhlmhgrrhhisehilhhmrghrihdrohhrgheqnecuggftrfgrthhtvghrnhepieeiveetvd
 euveevkeefueejieekgfdvtdetffekgeejtedvjeetheehueeliedvnecuvehluhhsthgv
 rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihhlmhgrrhhisehilhhmrg
 hrihdrohhrgh
X-ME-Proxy: <xmx:r1AVZk3-9S3L6I-AVrqXez-fu8KJSucCfLNjNVEK5YGhZxF5d-AoYQ>
 <xmx:r1AVZiE5dgVmn_H6FGGscATphhD39Ui4K6mCUNvEPItarLDaNqeiqQ>
 <xmx:r1AVZl-V_FP9f0JigBCHDYNRatICJgP7sdond82vxBBhkY4PmLVUdg>
 <xmx:r1AVZvmE8DhclN_vLgO5fV0eoSC9ZcCWN_UlmR9NNgHaqaKRPRKphQ>
 <xmx:sFAVZkOmH2UzH6eTJDiOtFD9haqIr15kNts-LKo8-2EKPoT1tUmZlYd->
Feedback-ID: i1ff147bf:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA for
 <bug-gnu-emacs@HIDDEN>; Tue, 9 Apr 2024 10:29:03 -0400 (EDT)
From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: [PATCH] Avoid unnecessary escaping in url-build-query-string
Date: Tue, 09 Apr 2024 15:29:00 +0100
Message-ID: <8734ruk3tf.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=103.168.172.157; envelope-from=ilmari@HIDDEN;
 helo=fhigh6-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Tue, 09 Apr 2024 10:59:53 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

--=-=-=
Content-Type: text/plain

Hi,

While writing a custom URL function for git-link.el I noticed that
url-build-query-string unnecessarily escapes slashes in query parameter
values.  Here's a patch that fixes that by passing
url-query-allowed-chars to the url-hexify-string call.

- ilmari


--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-Avoid-unnecessary-escaping-in-url-build-query-string.patch

From ca1dbe67939ac78f5db06d746cd511928a138657 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dagfinn=20Ilmari=20Manns=C3=A5ker?= <ilmari@HIDDEN>
Date: Tue, 9 Apr 2024 15:02:45 +0100
Subject: [PATCH] Avoid unnecessary escaping in url-build-query-string

* lisp/url/url-util.el (url-build-query-string):
Pass url-query-allowed-chars to url-hexify-string to avoid unnecessarily
escaping characters that don't need to be escaped in a query string.
---
 lisp/url/url-util.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/url/url-util.el b/lisp/url/url-util.el
index 5f45b98c7a5..4fc0efcdf62 100644
--- a/lisp/url/url-util.el
+++ b/lisp/url/url-util.el
@@ -268,7 +268,8 @@ instead of just \"key\" as in the example above."
    (lambda (key-vals)
      (let ((escaped
             (mapcar (lambda (sym)
-                      (url-hexify-string (format "%s" sym))) key-vals)))
+                      (url-hexify-string (format "%s" sym) url-query-allowed-chars))
+                    key-vals)))
        (mapconcat (lambda (val)
                     (let ((vprint (format "%s" val))
                           (eprint (format "%s" (car escaped))))
-- 
2.39.2


--=-=-=--