GNU bug report logs - #70318
[PATCH] Fix unitentional creation of greeter's home directory

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70318 in the body.
You can then email your comments to 70318 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: lgcoelho <at> disroot.org
To: guix-patches <at> gnu.org
Subject: [PATCH] Fix unitentional creation of greeter's home directory
Date: Wed, 10 Apr 2024 01:58:01 +0200

[Message part 1 (text/plain, inline)]

This patch adresses the unintentional creation of the greeter's home 
directory when using the greetd-service.

[Message part 2 (text/html, inline)]

[0001-services-base-Fix-unintentional-creation-of-greeter-.patch (text/x-diff, attachment)]

Message #8 received at 70318 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: lgcoelho <at> disroot.org
Cc: 70318 <at> debbugs.gnu.org
Subject: Re: [bug#70318] [PATCH] Fix unitentional creation of greeter's home
 directory
Date: Fri, 03 Jan 2025 21:05:34 +0300

[Message part 1 (text/plain, inline)]

This may break greeters which are more complex than agreety. For 
instance, gtkgreet/wlgreet run under sway. One of subdependencies 
is mesa, which will want to write shader caches somewhere. Another 
one is fontconfig, doing similar thing for fonts. There may be 
others, which hard to track and tune. Some could be impossible to 
tune at all.

lgcoelho <at> disroot.org writes:

> This patch adresses the unintentional creation of the greeter's 
> home
> directory when using the greetd-service.
>
> [4. text/x-diff; 
> 0001-services-base-Fix-unintentional-creation-of-greeter-.patch]...

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 70318 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: muradm <mail <at> muradm.net>, lgcoelho <at> disroot.org
Cc: 70318 <at> debbugs.gnu.org
Subject: Re: [bug#70318] [PATCH] Fix unitentional creation of greeter's home
 directory
Date: Sat, 04 Jan 2025 15:06:56 +0100

On 2025-01-03 21:05, muradm wrote:

> This may break greeters which are more complex than agreety. For 
> instance, gtkgreet/wlgreet run under sway. One of subdependencies 
> is mesa, which will want to write shader caches somewhere. Another 
> one is fontconfig, doing similar thing for fonts. There may be 
> others, which hard to track and tune. Some could be impossible to 
> tune at all.

Then maybe we can make it conditional on agreety?

If all greetd-configuration-terminals have their
greet-default-session-command being an greetd-agreety-session?, we could
set it to #f.

Something like this could work: 
(create-home-directory? (not (every greetd-agreety-session? (map greetd-default-session-command (greetd-configuration-terminals config)))))

WDYT?

-- 
Best regards,
Nicolas Graves

Message #14 received at 70318 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 70318 <at> debbugs.gnu.org, lgcoelho <at> disroot.org
Subject: Re: [bug#70318] [PATCH] Fix unitentional creation of greeter's home
 directory
Date: Sat, 04 Jan 2025 18:05:49 +0300

[Message part 1 (text/plain, inline)]

Nicolas Graves <ngraves <at> ngraves.fr> writes:

> On 2025-01-03 21:05, muradm wrote:
>
>> This may break greeters which are more complex than agreety. 
>> For
>> instance, gtkgreet/wlgreet run under sway. One of 
>> subdependencies
>> is mesa, which will want to write shader caches somewhere. 
>> Another
>> one is fontconfig, doing similar thing for fonts. There may be
>> others, which hard to track and tune. Some could be impossible 
>> to
>> tune at all.
>
> Then maybe we can make it conditional on agreety?
>
> If all greetd-configuration-terminals have their
> greet-default-session-command being an greetd-agreety-session?, 
> we could
> set it to #f.
>
> Something like this could work:
> (create-home-directory? (not (every greetd-agreety-session? (map 
> greetd-default-session-command (greetd-configuration-terminals 
> config)))))
>
> WDYT?

2 of 3 greeters needs home. With improvements implemented by 75270 
`greetd-terminal-configuration` is detached from details of its 
`default-session-command`. By this, any user can workout its 
greeter. If we hardcode implementation of greeter in terminal user 
may loose such flexibility. Also once you implement such 
condition, you will have to maintain with any other greeter added 
in the future.

One way would be to carry this flag into `greetd-configuration`, 
IMHO will uneccessarily complicate the things. Is there any good 
reason for doing that?

What is the problem with having home directory for greeter user?

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 70318 <at> debbugs.gnu.org (full text, mbox):

From: muradm <mail <at> muradm.net>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 70318 <at> debbugs.gnu.org, lgcoelho <at> disroot.org
Subject: Re: [bug#70318] [PATCH] Fix unitentional creation of greeter's home
 directory
Date: Sat, 04 Jan 2025 20:08:58 +0300

[Message part 1 (text/plain, inline)]

muradm <mail <at> muradm.net> writes:

>>
>> Then maybe we can make it conditional on agreety?
>>
>> If all greetd-configuration-terminals have their
>> greet-default-session-command being an greetd-agreety-session?, 
>> we
>> could
>> set it to #f.
>>
>> Something like this could work:
>> (create-home-directory? (not (every greetd-agreety-session? 
>> (map
>> greetd-default-session-command (greetd-configuration-terminals
>> config)))))
>>
>> WDYT?
>
> 2 of 3 greeters needs home. With improvements implemented by 
> 75270
> `greetd-terminal-configuration` is detached from details of its
> `default-session-command`. By this, any user can workout its 
> greeter.
> If we hardcode implementation of greeter in terminal user may 
> loose
> such flexibility. Also once you implement such condition, you 
> will
> have to maintain with any other greeter added in the future.
>
> One way would be to carry this flag into `greetd-configuration`, 
> IMHO
> will uneccessarily complicate the things. Is there any good 
> reason for
> doing that?
>
> What is the problem with having home directory for greeter user?

After some more meditation, I remembered that originally I also 
did not like idea of having extra user home directory and 
considering changes introduced by #75270, it became obvious that 
sway specific environment can be setup within 
`make-greetd-sway-greeter-command`. Further greeters may either 
improve on it, or provide their own entry point commands as they 
see fit. v2 of 75270 includes this change, and adjusts the 
environment accordingly. This issue can be closed in favor if 
75270.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.