GNU bug report logs - #70344
Increase verbosity of diffoscope test suite

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70344 in the body.
You can then email your comments to 70344 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> reproducible-builds.org>
To: guix-patches <at> gnu.org
Cc: Wilko Meyer <w <at> wmeyer.eu>, Christopher Baines <mail <at> cbaines.net>
Subject: Increase verbosity of diffoscope test suite
Date: Thu, 11 Apr 2024 12:50:54 -0700

[Message part 1 (text/plain, inline)]

The attached patch increases the verbosity of the test suite, showing
each test on it's own line and provides a useful summary, often
including a reason why skipped tests were skipped.

This can be useful to help find additional packages to add for broader
test coverage, inspired by discussion in
https://issues.guix.gnu.org/70293

This also reveals that the conditional to add "enjarify" to
native-inputs on x86_64 is not working correctly... and plausibly could
reveal other similar issues with other missing native-inputs.

live well,
  vagrant

[0001-gnu-diffoscope-Increase-test-verbosity.patch (text/x-diff, inline)]

From b1475226dc655986e97445dca889d4b0c362215c Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant <at> reproducible-builds.org>
Date: Thu, 11 Apr 2024 12:40:19 -0700
Subject: [PATCH] gnu: diffoscope: Increase test verbosity.

* gnu/packages/diffoscope.scm (diffoscope)[phases]: Replace 'check.
---
 gnu/packages/diffoscope.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/diffoscope.scm b/gnu/packages/diffoscope.scm
index 3db52e5008..8106a6d258 100644
--- a/gnu/packages/diffoscope.scm
+++ b/gnu/packages/diffoscope.scm
@@ -139,6 +139,11 @@ (define (bin command)
             (lambda _
               ;; This requires /sbin to be in $PATH.
               (delete-file "tests/test_tools.py")))
+         (replace 'check
+           (lambda* (#:key tests? #:allow-other-keys)
+             (when tests?
+               ;; Increase verbosity of tests and provide a summary
+               (invoke "pytest" "-vv" "-r" "sxX"))))
           (add-after 'install 'install-man-page
             (lambda* (#:key outputs #:allow-other-keys)
               (let* ((out (assoc-ref outputs "out"))
-- 
2.39.2

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 70344-done <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> reproducible-builds.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: Wilko Meyer <w <at> wmeyer.eu>, 70344-done <at> debbugs.gnu.org
Subject: Re: Increase verbosity of diffoscope test suite
Date: Fri, 17 May 2024 20:08:39 -0700

[Message part 1 (text/plain, inline)]

On 2024-04-15, Christopher Baines wrote:
> Vagrant Cascadian <vagrant <at> reproducible-builds.org> writes:
>
>> The attached patch increases the verbosity of the test suite, showing
>> each test on it's own line and provides a useful summary, often
>> including a reason why skipped tests were skipped.
>>
>> This can be useful to help find additional packages to add for broader
>> test coverage, inspired by discussion in
>> https://issues.guix.gnu.org/70293
>>
>> This also reveals that the conditional to add "enjarify" to
>> native-inputs on x86_64 is not working correctly... and plausibly could
>> reveal other similar issues with other missing native-inputs.
>>
>> live well,
>>   vagrant
>>
>> [2. text/x-diff; 0001-gnu-diffoscope-Increase-test-verbosity.patch]
>> From b1475226dc655986e97445dca889d4b0c362215c Mon Sep 17 00:00:00 2001
>> From: Vagrant Cascadian <vagrant <at> reproducible-builds.org>
>> Date: Thu, 11 Apr 2024 12:40:19 -0700
>> Subject: [PATCH] gnu: diffoscope: Increase test verbosity.
>>
>> * gnu/packages/diffoscope.scm (diffoscope)[phases]: Replace 'check.
>> ---
>>  gnu/packages/diffoscope.scm | 5 +++++
>>  1 file changed, 5 insertions(+)
>
> This looks great, I've pushed it to master as
> 4dec6e9fb74a688e0297b127773b88a699531785.

Sending to the correct -done address. :)

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.