Received: (at submit) by debbugs.gnu.org; 17 Apr 2024 10:52:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 17 06:52:09 2024 Received: from localhost ([127.0.0.1]:45872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rx2tc-0003gz-CX for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 06:52:09 -0400 Received: from lists.gnu.org ([2001:470:142::17]:41034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1rx2tW-0003ew-1d for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 06:52:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1rx2tD-0007uS-S5 for guix-patches@HIDDEN; Wed, 17 Apr 2024 06:51:43 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1rx2tB-0000HY-Mq for guix-patches@HIDDEN; Wed, 17 Apr 2024 06:51:43 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id B85F127BBE9; Wed, 17 Apr 2024 11:51:38 +0100 (BST) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 787275f5; Wed, 17 Apr 2024 10:51:37 +0000 (UTC) From: Christopher Baines <mail@HIDDEN> To: Ashish <ashish.is@HIDDEN> Subject: Re: [bug#70407] [PATCH] gnu: Add fnc In-Reply-To: <rx5ve7ioah3xsau6xzxc2slohnp5bgmvaehfiwhxreaskgrwbn@p33iit6nahvl> (Ashish's message of "Wed, 17 Apr 2024 09:25:33 +0000") References: <57b18e1298ae636df0fa11968978adcf227a0cab.1713212712.git.ashish.is@HIDDEN> <87msptt0d5.fsf@HIDDEN> <rx5ve7ioah3xsau6xzxc2slohnp5bgmvaehfiwhxreaskgrwbn@p33iit6nahvl> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Wed, 17 Apr 2024 11:51:35 +0100 Message-ID: <87bk68tg7c.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@HIDDEN; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Daniel Ziltener <dziltener@HIDDEN>, 70407-done <at> debbugs.gnu.org, "ashish.is--- via Guix-patches via" <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Ashish <ashish.is@HIDDEN> writes: > On Tue, Apr 16, 2024 at 11:21:26PM +0100, Christopher Baines wrote: >> "ashish.is--- via Guix-patches" via <guix-patches@HIDDEN> writes: >> >> > + (inputs (list ncurses zlib sqlite-next)) >> > + (home-page "https://fnc.bsdbox.org") >> > + (synopsis "Interactive text-based user interface for Fossil") >> > + (description "fnc uses ncurses and libfossil to create a fossil ui experience in >> > +the terminal, and parse local changes at the hunk level to prepare atomic commits.") >> > + (license license:isc))) >> > >> > base-commit: a8353e9d6b34fd8d42d2e8f14ce844849fe9c293 >> >> I did have a quick check over the source, including a concatenated >> sqlite seems unusual and not ideal, but I'm not quite sure how it's >> used. > > libfossil is a library implementation of fossil ships with bundled > sqlite3, and the author decide to bundle libfossil, and so sqlite3 > comes with it. Right, it would be good to package libfossil and unbundle sqlite3 there, then use that libfossil package here. If libfossil can't use the built sqlite3 from Guix, then maybe the Guix package source can be used. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmYfqbdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcehA//TUeJHtKR3xfpkWSBsNc2VCA2bDPaMAVw MV1+6OOFK6jhmcH2LhR8/olMcQ1crtWyPHfLrjhvsjAr5wuxo1tUBu134dg972r4 Ug0hu12Kf/UhUFPI4tno5QboSwC6tOO0Io52s452mniQb4b8Nf5R0KisrLX0Av3f 3SD0w+Eb4+Dc6IapvSwUfZArxpkdOwHANeGHr9FLNxK4nhkGZladm+Dv9F4lLLuz Qz4fzX+9T/llg4H/h+eW43rG6qVkav8NMvv1fhMev/HCGFHwv6v0UGwKltnftIa/ Kop1UskXoUgiiJc/9tEprrczbH+b/M7YgYbVu1REqV2gqxiBFL914Hhd2cCwXJfa k2H3z0XAQX9Cil6g4ErTIi/x9KqKeRYJOnxiFlrO5iDg7Y2FZu9zHmg0NhJ3icJR a9UXXzkFylXsxADmnm3J9TtPb8SbZRdip6rMBP9PU/SfUoWZTrU3mz4gyaav08Nr uoGQ4+yLS6T6Q4rNRsZABoqbWWb97hjQ5611P0VStORc0UHwQPO2L1wpO1y+pVN8 6IxhImOO8o7ERAfmoHv9FbkmzZidJSGXAvoy8k2XDM1p6mUT1zMYhY/6njokukTj uFHp1SuC75AxdDYmN5avkH8X2/dgi+Ge9qvlSlT54GX7P5MB0AXc9AFP1/8s5BOB j5wcye/wU0o= =YbDo -----END PGP SIGNATURE----- --=-=-=--
guix-patches@HIDDEN:bug#70407; Package guix-patches.
Full text available.Received: (at 70407-done) by debbugs.gnu.org; 17 Apr 2024 10:51:57 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 17 06:51:56 2024 Received: from localhost ([127.0.0.1]:45868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rx2tP-0003ed-5K for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 06:51:56 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1rx2tM-0003eK-FJ for 70407-done <at> debbugs.gnu.org; Wed, 17 Apr 2024 06:51:54 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id B85F127BBE9; Wed, 17 Apr 2024 11:51:38 +0100 (BST) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 787275f5; Wed, 17 Apr 2024 10:51:37 +0000 (UTC) From: Christopher Baines <mail@HIDDEN> To: Ashish <ashish.is@HIDDEN> Subject: Re: [bug#70407] [PATCH] gnu: Add fnc In-Reply-To: <rx5ve7ioah3xsau6xzxc2slohnp5bgmvaehfiwhxreaskgrwbn@p33iit6nahvl> (Ashish's message of "Wed, 17 Apr 2024 09:25:33 +0000") References: <57b18e1298ae636df0fa11968978adcf227a0cab.1713212712.git.ashish.is@HIDDEN> <87msptt0d5.fsf@HIDDEN> <rx5ve7ioah3xsau6xzxc2slohnp5bgmvaehfiwhxreaskgrwbn@p33iit6nahvl> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Wed, 17 Apr 2024 11:51:35 +0100 Message-ID: <87bk68tg7c.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 70407-done Cc: Daniel Ziltener <dziltener@HIDDEN>, 70407-done <at> debbugs.gnu.org, "ashish.is--- via Guix-patches via" <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Ashish <ashish.is@HIDDEN> writes: > On Tue, Apr 16, 2024 at 11:21:26PM +0100, Christopher Baines wrote: >> "ashish.is--- via Guix-patches" via <guix-patches@HIDDEN> writes: >> >> > + (inputs (list ncurses zlib sqlite-next)) >> > + (home-page "https://fnc.bsdbox.org") >> > + (synopsis "Interactive text-based user interface for Fossil") >> > + (description "fnc uses ncurses and libfossil to create a fossil ui experience in >> > +the terminal, and parse local changes at the hunk level to prepare atomic commits.") >> > + (license license:isc))) >> > >> > base-commit: a8353e9d6b34fd8d42d2e8f14ce844849fe9c293 >> >> I did have a quick check over the source, including a concatenated >> sqlite seems unusual and not ideal, but I'm not quite sure how it's >> used. > > libfossil is a library implementation of fossil ships with bundled > sqlite3, and the author decide to bundle libfossil, and so sqlite3 > comes with it. Right, it would be good to package libfossil and unbundle sqlite3 there, then use that libfossil package here. If libfossil can't use the built sqlite3 from Guix, then maybe the Guix package source can be used. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmYfqbdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcehA//TUeJHtKR3xfpkWSBsNc2VCA2bDPaMAVw MV1+6OOFK6jhmcH2LhR8/olMcQ1crtWyPHfLrjhvsjAr5wuxo1tUBu134dg972r4 Ug0hu12Kf/UhUFPI4tno5QboSwC6tOO0Io52s452mniQb4b8Nf5R0KisrLX0Av3f 3SD0w+Eb4+Dc6IapvSwUfZArxpkdOwHANeGHr9FLNxK4nhkGZladm+Dv9F4lLLuz Qz4fzX+9T/llg4H/h+eW43rG6qVkav8NMvv1fhMev/HCGFHwv6v0UGwKltnftIa/ Kop1UskXoUgiiJc/9tEprrczbH+b/M7YgYbVu1REqV2gqxiBFL914Hhd2cCwXJfa k2H3z0XAQX9Cil6g4ErTIi/x9KqKeRYJOnxiFlrO5iDg7Y2FZu9zHmg0NhJ3icJR a9UXXzkFylXsxADmnm3J9TtPb8SbZRdip6rMBP9PU/SfUoWZTrU3mz4gyaav08Nr uoGQ4+yLS6T6Q4rNRsZABoqbWWb97hjQ5611P0VStORc0UHwQPO2L1wpO1y+pVN8 6IxhImOO8o7ERAfmoHv9FbkmzZidJSGXAvoy8k2XDM1p6mUT1zMYhY/6njokukTj uFHp1SuC75AxdDYmN5avkH8X2/dgi+Ge9qvlSlT54GX7P5MB0AXc9AFP1/8s5BOB j5wcye/wU0o= =YbDo -----END PGP SIGNATURE----- --=-=-=--
guix-patches@HIDDEN:bug#70407; Package guix-patches.
Full text available.Received: (at submit) by debbugs.gnu.org; 17 Apr 2024 09:26:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 17 05:26:19 2024 Received: from localhost ([127.0.0.1]:45761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rx1YZ-0001n4-C2 for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 05:26:19 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ashish.is@HIDDEN>) id 1rx1YW-0001kr-9B for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 05:26:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ashish.is@HIDDEN>) id 1rx1Y4-0007LR-9Y for guix-patches@HIDDEN; Wed, 17 Apr 2024 05:25:48 -0400 Received: from anamika.lostca.se ([65.21.75.227]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <ashish.is@HIDDEN>) id 1rx1Y2-0002Ag-2c for guix-patches@HIDDEN; Wed, 17 Apr 2024 05:25:48 -0400 Received: from chateau.d.if (198.red-81-34-32.dynamicip.rima-tde.net [81.34.32.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: abbe) by anamika.lostca.se (Postfix) with ESMTPSA id 27AC1113E; Wed, 17 Apr 2024 09:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lostca.se; s=anamika; t=1713345935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zO2gouVgLPsjNTfEA2iTa+xPQnXbnzGYQU8rfO0oxs0=; b=jfYJ3NHrMbU93lEI3tOZVkV9db/nKqD2Jn5RCQrrIIcmGYN7licuvnlh4Tf+ebgSM05xr0 nrs24Um5pwPwU2TPQm7qH4ylaWDV68UgtE9AjyqLbfjCM6jHoYIhlFiCtWsTC+JNSpjvrr aZR3lPLTLKq4GSt7uv2kdy5qWbabZuk= Date: Wed, 17 Apr 2024 09:25:33 +0000 From: Ashish <ashish.is@HIDDEN> To: Christopher Baines <mail@HIDDEN> Subject: Re: Re: [bug#70407] [PATCH] gnu: Add fnc Message-ID: <rx5ve7ioah3xsau6xzxc2slohnp5bgmvaehfiwhxreaskgrwbn@p33iit6nahvl> References: <57b18e1298ae636df0fa11968978adcf227a0cab.1713212712.git.ashish.is@HIDDEN> <87msptt0d5.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="meqj6nymmrg2mjem" Content-Disposition: inline In-Reply-To: <87msptt0d5.fsf@HIDDEN> User-Agent: NeoMutt/20231221 Received-SPF: pass client-ip=65.21.75.227; envelope-from=ashish.is@HIDDEN; helo=anamika.lostca.se X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Daniel Ziltener <dziltener@HIDDEN>, 70407-done <at> debbugs.gnu.org, "ashish.is--- via Guix-patches via" <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) --meqj6nymmrg2mjem Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 16, 2024 at 11:21:26PM +0100, Christopher Baines wrote: > "ashish.is--- via Guix-patches" via <guix-patches@HIDDEN> writes: >=20 > > From: Ashish SHUKLA <ashish.is@HIDDEN> > > > > * gnu/packages/version-control.scm (fnc): New variable. > > > > Change-Id: Idf1cb254c3ae18bacb86bf020511a5d34e2d3684 > > Signed-off-by: Ashish SHUKLA <ashish.is@HIDDEN> > > --- > > gnu/packages/version-control.scm | 25 +++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-co= ntrol.scm > > index 96ca1df552..33607940ec 100644 > > --- a/gnu/packages/version-control.scm > > +++ b/gnu/packages/version-control.scm > > @@ -4145,3 +4145,28 @@ (define-public git-sizer > > (description "Compute various size metrics for a Git repository, f= lagging > > those that might cause problems or inconvenience.") > > (license license:expat))) > > + > > +(define-public fnc > > + (package > > + (name "fnc") > > + (version "0.16") > > + (source (origin > > + (method url-fetch) > > + (uri > > + (string-append "https://fnc.bsdbox.org/uv/dl/fnc-" vers= ion ".tar.gz")) > > + (sha256 > > + (base32 > > + "1npnbdz5i4p61ri76vx6awggbc0q19y8b26l3sy4wxmaxkly7gwy"= )))) > > + (build-system gnu-build-system) > > + (arguments > > + '(#:phases (modify-phases %standard-phases > > + (delete 'configure)) > > + #:tests? #f > > + #:make-flags (list "CC=3Dgcc" > > + (string-append "PREFIX=3D" (assoc-ref %outputs "out"))))) >=20 > The arguments needed a bit of touching up. Using gexp's is the new > style. It's unclear why the tests are disabled, I guess it's because > there are no tests so I've added a comment to this effect. Hardcoding > CC=3Dgcc also causes problems for cross building, so use (cc-for-target) > instead. Thanks for catching this, it indeed crossed my mind, but I was not sure wha= t to replace it with should someone chose to build with `clang' (or other C= language compiler), and `cc' is not present. > > + (inputs (list ncurses zlib sqlite-next)) > > + (home-page "https://fnc.bsdbox.org") > > + (synopsis "Interactive text-based user interface for Fossil") > > + (description "fnc uses ncurses and libfossil to create a fossil ui= experience in > > +the terminal, and parse local changes at the hunk level to prepare ato= mic commits.") > > + (license license:isc))) > > > > base-commit: a8353e9d6b34fd8d42d2e8f14ce844849fe9c293 >=20 > I did have a quick check over the source, including a concatenated > sqlite seems unusual and not ideal, but I'm not quite sure how it's > used. libfossil is a library implementation of fossil ships with bundled sqlite3,= and the author decide to bundle libfossil, and so sqlite3 comes with it. >=20 > One final change I made was moving the package definition up off the > bottom of the file (as if everyone adds new packages there, it causes > merge conflicts). >=20 > I've pushed this to master with the changes I describe as > a45b2c7c63c6af9c42698e12b6809c41c0926de3 so please take a look. >=20 > Thanks, >=20 > Chris Thanks! --=20 Ashish | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0 "If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin) --meqj6nymmrg2mjem Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEE9oLNzDncD+rhFiC2x0bPqedPpLAFAmYflY1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY2 ODJDRENDMzlEQzBGRUFFMTE2MjBCNkM3NDZDRkE5RTc0RkE0QjAACgkQx0bPqedP pLBG/w/8C7zElodKXntITeFvcJXYuyI4oW9KufmGcfFWINWeb8szUvi3LmBCegn0 efVIFLRlfW4p46/GxvXzqL3xJUete4wKxwzar19aW7Oc4hAQ5cAb5v3+BNC3sH4a s6OEZoPwVApJNxELK9Jgy01u2iUsN59rn1T7F87tGtqBk694dw1eNzkb5AtmSBVY 4v2NIkYpjHfhz4VdYSGDfxAgyabootFspsvfAPkGvPnyB7xMI+zwHbT7fqrfFxfU BxVgWFwe9NrweGfcpbAyd90uZHs+QiL9NkPFihM3V52o0PVUTAqXIu7VTCa0+h1C eANVjakxCklIY37BiGgOof7yNKBGSMO16qmR3DDGrMp7y6o+oYGA3OPPVr4ElYr2 qv1K693JpQU84+B2sVedvopPrT/XPsMLEcaVsTkbITXCoEjJXVtk6O940ezqbQTh Lo3378lN2yHEdGOc6APgVxAPuiTZ/io6HhaoNLykVmWibTUgUT6j8uoxDr7BMlSq ss8HOD2tBeb/3dEwryP6bC9LbrdKop4ff4y8fmVs/IY64g9UAxaauqXfF7IgA+gk nTIoZrueI/HIfSKrsGQGrU96uPWsPUI4O6rj2RZiKQhyiliN8E5cbFw2rilkfjMo uOt4zj1aajOsFFh6+kl49m1+Avauxt7PGzCyScqn6V0Ayn+UxuI= =ejuW -----END PGP SIGNATURE----- --meqj6nymmrg2mjem--
guix-patches@HIDDEN:bug#70407; Package guix-patches.
Full text available.Received: (at 70407-done) by debbugs.gnu.org; 17 Apr 2024 09:26:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 17 05:26:01 2024 Received: from localhost ([127.0.0.1]:45757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rx1YF-0001jl-Iy for submit <at> debbugs.gnu.org; Wed, 17 Apr 2024 05:26:01 -0400 Received: from anamika.lostca.se ([65.21.75.227]:34830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ashish.is@HIDDEN>) id 1rx1YB-0001iD-4X for 70407-done <at> debbugs.gnu.org; Wed, 17 Apr 2024 05:25:58 -0400 Received: from chateau.d.if (198.red-81-34-32.dynamicip.rima-tde.net [81.34.32.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: abbe) by anamika.lostca.se (Postfix) with ESMTPSA id 27AC1113E; Wed, 17 Apr 2024 09:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lostca.se; s=anamika; t=1713345935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zO2gouVgLPsjNTfEA2iTa+xPQnXbnzGYQU8rfO0oxs0=; b=jfYJ3NHrMbU93lEI3tOZVkV9db/nKqD2Jn5RCQrrIIcmGYN7licuvnlh4Tf+ebgSM05xr0 nrs24Um5pwPwU2TPQm7qH4ylaWDV68UgtE9AjyqLbfjCM6jHoYIhlFiCtWsTC+JNSpjvrr aZR3lPLTLKq4GSt7uv2kdy5qWbabZuk= Date: Wed, 17 Apr 2024 09:25:33 +0000 From: Ashish <ashish.is@HIDDEN> To: Christopher Baines <mail@HIDDEN> Subject: Re: Re: [bug#70407] [PATCH] gnu: Add fnc Message-ID: <rx5ve7ioah3xsau6xzxc2slohnp5bgmvaehfiwhxreaskgrwbn@p33iit6nahvl> References: <57b18e1298ae636df0fa11968978adcf227a0cab.1713212712.git.ashish.is@HIDDEN> <87msptt0d5.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="meqj6nymmrg2mjem" Content-Disposition: inline In-Reply-To: <87msptt0d5.fsf@HIDDEN> User-Agent: NeoMutt/20231221 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70407-done Cc: Daniel Ziltener <dziltener@HIDDEN>, 70407-done <at> debbugs.gnu.org, "ashish.is--- via Guix-patches via" <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --meqj6nymmrg2mjem Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 16, 2024 at 11:21:26PM +0100, Christopher Baines wrote: > "ashish.is--- via Guix-patches" via <guix-patches@HIDDEN> writes: >=20 > > From: Ashish SHUKLA <ashish.is@HIDDEN> > > > > * gnu/packages/version-control.scm (fnc): New variable. > > > > Change-Id: Idf1cb254c3ae18bacb86bf020511a5d34e2d3684 > > Signed-off-by: Ashish SHUKLA <ashish.is@HIDDEN> > > --- > > gnu/packages/version-control.scm | 25 +++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-co= ntrol.scm > > index 96ca1df552..33607940ec 100644 > > --- a/gnu/packages/version-control.scm > > +++ b/gnu/packages/version-control.scm > > @@ -4145,3 +4145,28 @@ (define-public git-sizer > > (description "Compute various size metrics for a Git repository, f= lagging > > those that might cause problems or inconvenience.") > > (license license:expat))) > > + > > +(define-public fnc > > + (package > > + (name "fnc") > > + (version "0.16") > > + (source (origin > > + (method url-fetch) > > + (uri > > + (string-append "https://fnc.bsdbox.org/uv/dl/fnc-" vers= ion ".tar.gz")) > > + (sha256 > > + (base32 > > + "1npnbdz5i4p61ri76vx6awggbc0q19y8b26l3sy4wxmaxkly7gwy"= )))) > > + (build-system gnu-build-system) > > + (arguments > > + '(#:phases (modify-phases %standard-phases > > + (delete 'configure)) > > + #:tests? #f > > + #:make-flags (list "CC=3Dgcc" > > + (string-append "PREFIX=3D" (assoc-ref %outputs "out"))))) >=20 > The arguments needed a bit of touching up. Using gexp's is the new > style. It's unclear why the tests are disabled, I guess it's because > there are no tests so I've added a comment to this effect. Hardcoding > CC=3Dgcc also causes problems for cross building, so use (cc-for-target) > instead. Thanks for catching this, it indeed crossed my mind, but I was not sure wha= t to replace it with should someone chose to build with `clang' (or other C= language compiler), and `cc' is not present. > > + (inputs (list ncurses zlib sqlite-next)) > > + (home-page "https://fnc.bsdbox.org") > > + (synopsis "Interactive text-based user interface for Fossil") > > + (description "fnc uses ncurses and libfossil to create a fossil ui= experience in > > +the terminal, and parse local changes at the hunk level to prepare ato= mic commits.") > > + (license license:isc))) > > > > base-commit: a8353e9d6b34fd8d42d2e8f14ce844849fe9c293 >=20 > I did have a quick check over the source, including a concatenated > sqlite seems unusual and not ideal, but I'm not quite sure how it's > used. libfossil is a library implementation of fossil ships with bundled sqlite3,= and the author decide to bundle libfossil, and so sqlite3 comes with it. >=20 > One final change I made was moving the package definition up off the > bottom of the file (as if everyone adds new packages there, it causes > merge conflicts). >=20 > I've pushed this to master with the changes I describe as > a45b2c7c63c6af9c42698e12b6809c41c0926de3 so please take a look. >=20 > Thanks, >=20 > Chris Thanks! --=20 Ashish | GPG: F682 CDCC 39DC 0FEA E116 20B6 C746 CFA9 E74F A4B0 "If I destroy you, what business is it of yours ?" (Dark Forest, Liu Cixin) --meqj6nymmrg2mjem Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEE9oLNzDncD+rhFiC2x0bPqedPpLAFAmYflY1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY2 ODJDRENDMzlEQzBGRUFFMTE2MjBCNkM3NDZDRkE5RTc0RkE0QjAACgkQx0bPqedP pLBG/w/8C7zElodKXntITeFvcJXYuyI4oW9KufmGcfFWINWeb8szUvi3LmBCegn0 efVIFLRlfW4p46/GxvXzqL3xJUete4wKxwzar19aW7Oc4hAQ5cAb5v3+BNC3sH4a s6OEZoPwVApJNxELK9Jgy01u2iUsN59rn1T7F87tGtqBk694dw1eNzkb5AtmSBVY 4v2NIkYpjHfhz4VdYSGDfxAgyabootFspsvfAPkGvPnyB7xMI+zwHbT7fqrfFxfU BxVgWFwe9NrweGfcpbAyd90uZHs+QiL9NkPFihM3V52o0PVUTAqXIu7VTCa0+h1C eANVjakxCklIY37BiGgOof7yNKBGSMO16qmR3DDGrMp7y6o+oYGA3OPPVr4ElYr2 qv1K693JpQU84+B2sVedvopPrT/XPsMLEcaVsTkbITXCoEjJXVtk6O940ezqbQTh Lo3378lN2yHEdGOc6APgVxAPuiTZ/io6HhaoNLykVmWibTUgUT6j8uoxDr7BMlSq ss8HOD2tBeb/3dEwryP6bC9LbrdKop4ff4y8fmVs/IY64g9UAxaauqXfF7IgA+gk nTIoZrueI/HIfSKrsGQGrU96uPWsPUI4O6rj2RZiKQhyiliN8E5cbFw2rilkfjMo uOt4zj1aajOsFFh6+kl49m1+Avauxt7PGzCyScqn6V0Ayn+UxuI= =ejuW -----END PGP SIGNATURE----- --meqj6nymmrg2mjem--
guix-patches@HIDDEN:bug#70407; Package guix-patches.
Full text available.Received: (at submit) by debbugs.gnu.org; 16 Apr 2024 22:22:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 16 18:22:04 2024 Received: from localhost ([127.0.0.1]:45341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rwrBi-0000KI-5Z for submit <at> debbugs.gnu.org; Tue, 16 Apr 2024 18:22:04 -0400 Received: from lists.gnu.org ([2001:470:142::17]:58798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1rwrBc-0000Il-Mw for submit <at> debbugs.gnu.org; Tue, 16 Apr 2024 18:22:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1rwrBK-0003YN-SH for guix-patches@HIDDEN; Tue, 16 Apr 2024 18:21:38 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1rwrBI-0008OS-KQ for guix-patches@HIDDEN; Tue, 16 Apr 2024 18:21:38 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 4BFE427BBE9; Tue, 16 Apr 2024 23:21:29 +0100 (BST) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 6a9b4622; Tue, 16 Apr 2024 22:21:28 +0000 (UTC) From: Christopher Baines <mail@HIDDEN> To: "ashish.is--- via Guix-patches" via <guix-patches@HIDDEN>, Daniel Ziltener <dziltener@HIDDEN> Subject: Re: [bug#70407] [PATCH] gnu: Add fnc In-Reply-To: <57b18e1298ae636df0fa11968978adcf227a0cab.1713212712.git.ashish.is@HIDDEN> (ashish is's message of "Mon, 15 Apr 2024 20:25:12 +0000") References: <57b18e1298ae636df0fa11968978adcf227a0cab.1713212712.git.ashish.is@HIDDEN> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Tue, 16 Apr 2024 23:21:26 +0100 Message-ID: <87msptt0d5.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@HIDDEN; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: 70407-done <at> debbugs.gnu.org, ashish.is@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain "ashish.is--- via Guix-patches" via <guix-patches@HIDDEN> writes: > From: Ashish SHUKLA <ashish.is@HIDDEN> > > * gnu/packages/version-control.scm (fnc): New variable. > > Change-Id: Idf1cb254c3ae18bacb86bf020511a5d34e2d3684 > Signed-off-by: Ashish SHUKLA <ashish.is@HIDDEN> > --- > gnu/packages/version-control.scm | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm > index 96ca1df552..33607940ec 100644 > --- a/gnu/packages/version-control.scm > +++ b/gnu/packages/version-control.scm > @@ -4145,3 +4145,28 @@ (define-public git-sizer > (description "Compute various size metrics for a Git repository, flagging > those that might cause problems or inconvenience.") > (license license:expat))) > + > +(define-public fnc > + (package > + (name "fnc") > + (version "0.16") > + (source (origin > + (method url-fetch) > + (uri > + (string-append "https://fnc.bsdbox.org/uv/dl/fnc-" version ".tar.gz")) > + (sha256 > + (base32 > + "1npnbdz5i4p61ri76vx6awggbc0q19y8b26l3sy4wxmaxkly7gwy")))) > + (build-system gnu-build-system) > + (arguments > + '(#:phases (modify-phases %standard-phases > + (delete 'configure)) > + #:tests? #f > + #:make-flags (list "CC=gcc" > + (string-append "PREFIX=" (assoc-ref %outputs "out"))))) The arguments needed a bit of touching up. Using gexp's is the new style. It's unclear why the tests are disabled, I guess it's because there are no tests so I've added a comment to this effect. Hardcoding CC=gcc also causes problems for cross building, so use (cc-for-target) instead. > + (inputs (list ncurses zlib sqlite-next)) > + (home-page "https://fnc.bsdbox.org") > + (synopsis "Interactive text-based user interface for Fossil") > + (description "fnc uses ncurses and libfossil to create a fossil ui experience in > +the terminal, and parse local changes at the hunk level to prepare atomic commits.") > + (license license:isc))) > > base-commit: a8353e9d6b34fd8d42d2e8f14ce844849fe9c293 I did have a quick check over the source, including a concatenated sqlite seems unusual and not ideal, but I'm not quite sure how it's used. One final change I made was moving the package definition up off the bottom of the file (as if everyone adds new packages there, it causes merge conflicts). I've pushed this to master with the changes I describe as a45b2c7c63c6af9c42698e12b6809c41c0926de3 so please take a look. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmYe+eZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xcbzg//RnDzOf8x5I7xLOMd1N6TiTythTxui+5r HvT4cVq0ElzzPj/KAi2ITX/VbGKJ0/FoDL+pZJu9y6OfPmwUTr8uzcdGvtJmO7Yv Kx7fsTde5EkpCGwWZo9GHepgoYIuGzVt+Jwk5vWnDfxsZAzD4E8+6b6ZHEfehXlQ /ydJXJi0aZWpBwuPqQ5QNR0TqffOz2YELUAi25QD3VQSakQaSlkTEjj6PAM1Ve6B t2K+zkATYfzzxj0opN1nOBSrEvwrYosTkrMz8zIYipvXNzxcyD6+8MAVfmjbJ7NA eoTeqZNth4mKS3JK0+94dcbmWVPKaYb7sRpJg/bPR0ZGW+KapUBnyN+l5WmROfAk 6aU/o5MF9nfefeqgj7cDo86ffCBB3ioyhNfm2/KTVoXOr8/PCCygomcPhz2D76qz aTMah8C+FTGHw6bSGbCCuVmDs68rC3+4Utjgt8B9xiBwg3FZ0F2I1xLKuuner6Tz VsD3YWoX4fP7HkTBGQNmwjFxLp5jM8/qUp6e5yu8i0bGeCt7JxVxfQyj/n9k9cpm dj7sdUT9Y3Zhp+0TF9VmB7u7WbMa/ekCtpKxg7G9AhbK94DSV2VhH8ZQacLr5f7O RsnRppbCV2F/tFkBtX0P7cGxI02mr1TKzQY5tNFr82+KmBsfi4HFGjlNPq0rJKJ0 xtpeAHOysHM= =MunI -----END PGP SIGNATURE----- --=-=-=--
guix-patches@HIDDEN:bug#70407; Package guix-patches.
Full text available.Received: (at 70407-done) by debbugs.gnu.org; 16 Apr 2024 22:21:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 16 18:21:45 2024 Received: from localhost ([127.0.0.1]:45338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rwrBQ-0000Ie-Mb for submit <at> debbugs.gnu.org; Tue, 16 Apr 2024 18:21:45 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1rwrBO-0000IQ-B4 for 70407-done <at> debbugs.gnu.org; Tue, 16 Apr 2024 18:21:43 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 4BFE427BBE9; Tue, 16 Apr 2024 23:21:29 +0100 (BST) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 6a9b4622; Tue, 16 Apr 2024 22:21:28 +0000 (UTC) From: Christopher Baines <mail@HIDDEN> To: "ashish.is--- via Guix-patches" via <guix-patches@HIDDEN>, Daniel Ziltener <dziltener@HIDDEN> Subject: Re: [bug#70407] [PATCH] gnu: Add fnc In-Reply-To: <57b18e1298ae636df0fa11968978adcf227a0cab.1713212712.git.ashish.is@HIDDEN> (ashish is's message of "Mon, 15 Apr 2024 20:25:12 +0000") References: <57b18e1298ae636df0fa11968978adcf227a0cab.1713212712.git.ashish.is@HIDDEN> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Tue, 16 Apr 2024 23:21:26 +0100 Message-ID: <87msptt0d5.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 70407-done Cc: 70407-done <at> debbugs.gnu.org, ashish.is@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain "ashish.is--- via Guix-patches" via <guix-patches@HIDDEN> writes: > From: Ashish SHUKLA <ashish.is@HIDDEN> > > * gnu/packages/version-control.scm (fnc): New variable. > > Change-Id: Idf1cb254c3ae18bacb86bf020511a5d34e2d3684 > Signed-off-by: Ashish SHUKLA <ashish.is@HIDDEN> > --- > gnu/packages/version-control.scm | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm > index 96ca1df552..33607940ec 100644 > --- a/gnu/packages/version-control.scm > +++ b/gnu/packages/version-control.scm > @@ -4145,3 +4145,28 @@ (define-public git-sizer > (description "Compute various size metrics for a Git repository, flagging > those that might cause problems or inconvenience.") > (license license:expat))) > + > +(define-public fnc > + (package > + (name "fnc") > + (version "0.16") > + (source (origin > + (method url-fetch) > + (uri > + (string-append "https://fnc.bsdbox.org/uv/dl/fnc-" version ".tar.gz")) > + (sha256 > + (base32 > + "1npnbdz5i4p61ri76vx6awggbc0q19y8b26l3sy4wxmaxkly7gwy")))) > + (build-system gnu-build-system) > + (arguments > + '(#:phases (modify-phases %standard-phases > + (delete 'configure)) > + #:tests? #f > + #:make-flags (list "CC=gcc" > + (string-append "PREFIX=" (assoc-ref %outputs "out"))))) The arguments needed a bit of touching up. Using gexp's is the new style. It's unclear why the tests are disabled, I guess it's because there are no tests so I've added a comment to this effect. Hardcoding CC=gcc also causes problems for cross building, so use (cc-for-target) instead. > + (inputs (list ncurses zlib sqlite-next)) > + (home-page "https://fnc.bsdbox.org") > + (synopsis "Interactive text-based user interface for Fossil") > + (description "fnc uses ncurses and libfossil to create a fossil ui experience in > +the terminal, and parse local changes at the hunk level to prepare atomic commits.") > + (license license:isc))) > > base-commit: a8353e9d6b34fd8d42d2e8f14ce844849fe9c293 I did have a quick check over the source, including a concatenated sqlite seems unusual and not ideal, but I'm not quite sure how it's used. One final change I made was moving the package definition up off the bottom of the file (as if everyone adds new packages there, it causes merge conflicts). I've pushed this to master with the changes I describe as a45b2c7c63c6af9c42698e12b6809c41c0926de3 so please take a look. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmYe+eZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xcbzg//RnDzOf8x5I7xLOMd1N6TiTythTxui+5r HvT4cVq0ElzzPj/KAi2ITX/VbGKJ0/FoDL+pZJu9y6OfPmwUTr8uzcdGvtJmO7Yv Kx7fsTde5EkpCGwWZo9GHepgoYIuGzVt+Jwk5vWnDfxsZAzD4E8+6b6ZHEfehXlQ /ydJXJi0aZWpBwuPqQ5QNR0TqffOz2YELUAi25QD3VQSakQaSlkTEjj6PAM1Ve6B t2K+zkATYfzzxj0opN1nOBSrEvwrYosTkrMz8zIYipvXNzxcyD6+8MAVfmjbJ7NA eoTeqZNth4mKS3JK0+94dcbmWVPKaYb7sRpJg/bPR0ZGW+KapUBnyN+l5WmROfAk 6aU/o5MF9nfefeqgj7cDo86ffCBB3ioyhNfm2/KTVoXOr8/PCCygomcPhz2D76qz aTMah8C+FTGHw6bSGbCCuVmDs68rC3+4Utjgt8B9xiBwg3FZ0F2I1xLKuuner6Tz VsD3YWoX4fP7HkTBGQNmwjFxLp5jM8/qUp6e5yu8i0bGeCt7JxVxfQyj/n9k9cpm dj7sdUT9Y3Zhp+0TF9VmB7u7WbMa/ekCtpKxg7G9AhbK94DSV2VhH8ZQacLr5f7O RsnRppbCV2F/tFkBtX0P7cGxI02mr1TKzQY5tNFr82+KmBsfi4HFGjlNPq0rJKJ0 xtpeAHOysHM= =MunI -----END PGP SIGNATURE----- --=-=-=--
ashish.is@HIDDEN:Christopher Baines <mail@HIDDEN>:Received: (at 70407) by debbugs.gnu.org; 15 Apr 2024 22:12:00 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 15 18:12:00 2024 Received: from localhost ([127.0.0.1]:39900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rwUYR-00069t-4Y for submit <at> debbugs.gnu.org; Mon, 15 Apr 2024 18:12:00 -0400 Received: from 195-15-241-199.dc3-a.pub1.etik-cloud.com ([195.15.241.199]:60147 helo=lyrion.ch) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dziltener@HIDDEN>) id 1rwUYK-00068F-PX; Mon, 15 Apr 2024 18:11:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lyrion.ch; s=20230702; t=1713219096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hRinfQgzjNcpc9wnB27csGYJEK6OxlHp2x2cWhY+cxg=; b=wmFR5WDX1TJdImHVZkrOt55UF983nY9X/2jtFrvQGI3a35QlcCje+rO17dsG4jm8JYQv6A UOvCSoeYPAOBl41U+JWYvU7bijRrflPPZeAC6UUyndqAsXBLz81e9ZylwBXGTbdauoLnXl OXzCSqiPdivfyaNLdPEIO4gnGitOc6oNI35ZfaJk2yMiIYtqC68YNKXBNMGNCcNhsyxxfn XVKsTgGIgpnTWOdsqqoizhRCM2HjbIqfOlOaCEjXc8A4HA9bojXs0JkVnZZO0YegO/xJF8 Qs5g6s5n7YW8vjPBdyq7h3tC1NdhCYIff6GTFy7AVsZ+oSXc+rGWkzBywV99JA== Received: from [IPV6:2a06:6880:42c:1600:23cf:27ad:e59d:8816] (<unknown> [2a06:6880:42c:1600:23cf:27ad:e59d:8816]) by lyrion.ch (OpenSMTPD) with ESMTPSA id 779c9a22 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 15 Apr 2024 22:11:36 +0000 (UTC) Message-ID: <180aae40-6597-9ae4-5533-3a410fc70348@HIDDEN> Date: Tue, 16 Apr 2024 00:11:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 To: control <at> debbugs.gnu.org, 70407 <at> debbugs.gnu.org Subject: QA review for 70407 Content-Language: en-US From: Daniel Ziltener <dziltener@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 70407 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.6 (/) user guix usertag 70407 + reviewed-looks-good thanks Guix QA review form submission: Items marked as checked: New package licenses, New package synopsis and descriptions
guix-patches@HIDDEN:bug#70407; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 15 Apr 2024 20:26:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 15 16:26:26 2024
Received: from localhost ([127.0.0.1]:39417 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rwSuH-0005Zh-RG
for submit <at> debbugs.gnu.org; Mon, 15 Apr 2024 16:26:26 -0400
Received: from lists.gnu.org ([2001:470:142::17]:44754)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ashish.is@HIDDEN>) id 1rwSuC-0005Yj-Vi
for submit <at> debbugs.gnu.org; Mon, 15 Apr 2024 16:26:24 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ashish.is@HIDDEN>)
id 1rwStq-0005IJ-Pi
for guix-patches@HIDDEN; Mon, 15 Apr 2024 16:25:58 -0400
Received: from anamika.lostca.se ([65.21.75.227])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <ashish.is@HIDDEN>)
id 1rwStm-0001qy-SK
for guix-patches@HIDDEN; Mon, 15 Apr 2024 16:25:56 -0400
Received: from localhost.localdomain (poincare.inet6.in
[IPv6:2a0a:4cc0:1:12d4::1])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested) (Authenticated sender: abbe)
by anamika.lostca.se (Postfix) with ESMTPSA id 0FDA784A;
Mon, 15 Apr 2024 20:25:52 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lostca.se; s=anamika;
t=1713212752;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding;
bh=p9UynI7zEw9nbDjgvVx051u9YHkPuLH96Og5q9P6BoE=;
b=mxW/mnY0PY2fzQnLabAmleOVPjAX475X+IoCrL0hFdicdiXcsvrzmi7iD4FTLi3aHhUjrb
bh2kp/Vug07nRYknt+B9DRopB5QImBB1soY/UxNe9dAQw7heWrkUCHgzWj5t19fXIVal63
RcA/juoOmGG/0oMzbQ7MdDqEFVH5DMY=
From: ashish.is@HIDDEN
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: Add fnc
Date: Mon, 15 Apr 2024 20:25:12 +0000
Message-ID: <57b18e1298ae636df0fa11968978adcf227a0cab.1713212712.git.ashish.is@HIDDEN>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=65.21.75.227; envelope-from=ashish.is@HIDDEN;
helo=anamika.lostca.se
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
Cc: Ashish SHUKLA <ashish.is@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)
From: Ashish SHUKLA <ashish.is@HIDDEN>
* gnu/packages/version-control.scm (fnc): New variable.
Change-Id: Idf1cb254c3ae18bacb86bf020511a5d34e2d3684
Signed-off-by: Ashish SHUKLA <ashish.is@HIDDEN>
---
gnu/packages/version-control.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 96ca1df552..33607940ec 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -4145,3 +4145,28 @@ (define-public git-sizer
(description "Compute various size metrics for a Git repository, flagging
those that might cause problems or inconvenience.")
(license license:expat)))
+
+(define-public fnc
+ (package
+ (name "fnc")
+ (version "0.16")
+ (source (origin
+ (method url-fetch)
+ (uri
+ (string-append "https://fnc.bsdbox.org/uv/dl/fnc-" version ".tar.gz"))
+ (sha256
+ (base32
+ "1npnbdz5i4p61ri76vx6awggbc0q19y8b26l3sy4wxmaxkly7gwy"))))
+ (build-system gnu-build-system)
+ (arguments
+ '(#:phases (modify-phases %standard-phases
+ (delete 'configure))
+ #:tests? #f
+ #:make-flags (list "CC=gcc"
+ (string-append "PREFIX=" (assoc-ref %outputs "out")))))
+ (inputs (list ncurses zlib sqlite-next))
+ (home-page "https://fnc.bsdbox.org")
+ (synopsis "Interactive text-based user interface for Fossil")
+ (description "fnc uses ncurses and libfossil to create a fossil ui experience in
+the terminal, and parse local changes at the hunk level to prepare atomic commits.")
+ (license license:isc)))
base-commit: a8353e9d6b34fd8d42d2e8f14ce844849fe9c293
--
2.41.0
ashish.is@HIDDEN:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#70407; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.