GNU logs - #70484, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#70484: Fix compatibility of build-aux/make-info-dir script
Resent-From: Felix Janda <felix.janda@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 20 Apr 2024 21:17:02 +0000
Resent-Message-ID: <handler.70484.B.171364778528117 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 70484 <at> debbugs.gnu.org
Date: Sat, 20 Apr 2024 19:05:57 +0000
From: Felix Janda <felix.janda@HIDDEN>
Message-ID: <ZiQSFS4PxRoZmXZJ@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Received-SPF: pass client-ip=185.67.36.66; envelope-from=felix.janda@HIDDEN;
 helo=mout02.posteo.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Mailman-Approved-At: Sat, 20 Apr 2024 17:16:24 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Hi,

I'm reporting the bug in the build scripts:

https://bugs.gentoo.org/930086

To summarize, the build-aux/make-info-dir script uses the substitution
${@?}, which is incompatible with mksh (and possibly other shells) and
undefined behavior in the proposed next POSIX standard.

A possible fix is to check $# at the beginning of the script, and then
simplify the rest of the script.

Felix

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Felix Janda <felix.janda@HIDDEN>
Subject: bug#70484: Acknowledgement (Fix compatibility of build-aux/make-info-dir
 script)
Message-ID: <handler.70484.B.171364778528117.ack <at> debbugs.gnu.org>
References: <ZiQSFS4PxRoZmXZJ@localhost>
X-Gnu-PR-Message: ack 70484
X-Gnu-PR-Package: emacs
Reply-To: 70484 <at> debbugs.gnu.org
Date: Sat, 20 Apr 2024 21:17:04 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 70484 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
70484: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70484
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#70484: Fix compatibility of build-aux/make-info-dir script
References: <ZiQSFS4PxRoZmXZJ@localhost>
In-Reply-To: <ZiQSFS4PxRoZmXZJ@localhost>
Resent-From: Ulrich Mueller <ulm@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 23 Apr 2024 17:38:04 +0000
Resent-Message-ID: <handler.70484.B70484.171389384917898 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 70484 <at> debbugs.gnu.org
From: Ulrich Mueller <ulm@HIDDEN>
Date: Tue, 23 Apr 2024 19:36:54 +0200
Message-ID: <u34rcrnex@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain

Attached patch fixes the problem for me. It applies cleanly to both
emacs-29 and master.

--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
 filename=0001-build-aux-make-info-dir-Avoid-bashism-bug-70484.patch

From cb490ee7a8365c6375dc6c7a5f6d8202ab381219 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@HIDDEN>
Date: Tue, 23 Apr 2024 07:37:17 +0200
Subject: [PATCH] * build-aux/make-info-dir: Avoid bashism (bug#70484).

---
 build-aux/make-info-dir | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/build-aux/make-info-dir b/build-aux/make-info-dir
index e5f4972902f..631fe533e69 100755
--- a/build-aux/make-info-dir
+++ b/build-aux/make-info-dir
@@ -33,7 +33,8 @@
 
 ## Header contains non-printing characters, so this is more
 ## reliable than using awk.
-cat <"${1?}" || exit
+test $# -ge 2 || exit 1
+cat <"$1"
 shift
 
 exec "${AWK-awk}" '
@@ -101,4 +102,4 @@       detexinfo()
       if (data[dircat])
         printf "\n%s\n%s", topic[dircat], data[dircat]
   }
-' "${@?}"
+' "$@"
-- 
2.44.0


--=-=-=--

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#70484: Fix compatibility of build-aux/make-info-dir script
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 23 Apr 2024 17:58:11 +0000
Resent-Message-ID: <handler.70484.B70484.171389506731420 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Ulrich Mueller <ulm@HIDDEN>
Cc: 70484 <at> debbugs.gnu.org
Date: Tue, 23 Apr 2024 20:57:01 +0300
Message-Id: <868r143qtu.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <u34rcrnex@HIDDEN> (message from Ulrich Mueller on Tue, 23
 Apr 2024 19:36:54 +0200)
References: <ZiQSFS4PxRoZmXZJ@localhost> <u34rcrnex@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Ulrich Mueller <ulm@HIDDEN>
> Date: Tue, 23 Apr 2024 19:36:54 +0200
> 
> Attached patch fixes the problem for me. It applies cleanly to both
> emacs-29 and master.

Thanks, please install on the emacs-29 branch.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 23 Apr 2024 19:12:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 23 15:12:13 2024
Received: from localhost ([127.0.0.1]:53870 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rzLYp-00011k-VO
	for submit <at> debbugs.gnu.org; Tue, 23 Apr 2024 15:12:13 -0400
Received: from woodpecker.gentoo.org ([140.211.166.183]:57684
 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ulm@HIDDEN>) id 1rzLYm-0000zt-Bm
 for control <at> debbugs.gnu.org; Tue, 23 Apr 2024 15:12:10 -0400
From: Ulrich Mueller <ulm@HIDDEN>
To: control <at> debbugs.gnu.org
Subject: Re: bug#70484: Fix compatibility of build-aux/make-info-dir script
Date: Tue, 23 Apr 2024 21:11:41 +0200
Message-ID: <uv847rj0y@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

close 70484 29.4
thanks

Last modified: Tue, 23 Apr 2024 19:15:05 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.