GNU bug report logs - #70563
[PATCH] gnu: Add pkcs11-helper.

Previous Next

Package: guix-patches;

Reported by: Andy Tai <atai <at> atai.org>

Date: Thu, 25 Apr 2024 09:24:10 UTC

Severity: normal

Tags: patch

Done: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70563 in the body.
You can then email your comments to 70563 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#70563; Package guix-patches. (Thu, 25 Apr 2024 09:24:12 GMT) Full text and rfc822 format available.

Acknowledgement sent to Andy Tai <atai <at> atai.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 25 Apr 2024 09:24:12 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: guix-patches <at> gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH] gnu: Add pkcs11-helper.
Date: Thu, 25 Apr 2024 02:22:35 -0700
* gnu/packages/security-token.scm (pkcs11-helper): New variable.

Change-Id: Ib17e0cf209a6fe797d0c797829ba91091b719028
---
 gnu/packages/security-token.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 00a7f97582..5e20424001 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -394,6 +394,30 @@ (define-public opensc
 #15 standard and the PKCS #11 API.")
     (license license:lgpl2.1+)))
 
+
+(define-public pkcs11-helper
+  (package
+    (name "pkcs11-helper")
+    (version "1.30.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-"
+             version "/pkcs11-helper-" version ".tar.bz2"))
+       (sha256
+        (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c"))))
+    (build-system gnu-build-system)
+    (inputs (list openssl-1.1 pcsc-lite))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/OpenSC/pkcs11-helper")
+    (synopsis "Library that simplifies the interaction with PKCS#11 providers")
+    (description
+     "Pkcs11-helper is a library that simplifies the interaction with
+PKCS#11 providers for end-user applications")
+    (license (list license:gpl2 license:bsd-3))))
+
+
 (define-public yubico-piv-tool
   (package
     (name "yubico-piv-tool")

base-commit: 4514239971895fc7ad47c7752e30d98a0c44a154
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70563; Package guix-patches. (Tue, 30 Apr 2024 19:23:01 GMT) Full text and rfc822 format available.

Message #8 received at 70563 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 70563 <at> debbugs.gnu.org
Subject: Re: bug#70563: Acknowledgement ([PATCH] gnu: Add pkcs11-helper.)
Date: Tue, 30 Apr 2024 12:21:49 -0700
patch passed QA
https://qa.guix.gnu.org/issue/70563




Information forwarded to guix-patches <at> gnu.org:
bug#70563; Package guix-patches. (Thu, 02 May 2024 21:23:02 GMT) Full text and rfc822 format available.

Message #11 received at 70563 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 70563 <at> debbugs.gnu.org
Date: Thu, 2 May 2024 14:21:01 -0700
patch passed QA

https://qa.guix.gnu.org/issue/70563




Information forwarded to guix-patches <at> gnu.org:
bug#70563; Package guix-patches. (Mon, 13 May 2024 07:02:02 GMT) Full text and rfc822 format available.

Message #14 received at 70563 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: control <at> debbugs.gnu.org,70563 <at> debbugs.gnu.org
Subject: QA review for 70563
Date: Mon, 13 May 2024 09:01:44 +0200
user guix
usertag 70563 + reviewed-looks-good
thanks

Guix QA review form submission:
The description probably needs a little bit more precision. In particular, it would be good to include the statement &quot;PKCS#11 is the de-facto standard to access cryptographic devices.&quot; or something like that. 

Otherwise LGTM.

Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package tests

-- 
Best regards,
Nicolas Graves




Information forwarded to guix-patches <at> gnu.org:
bug#70563; Package guix-patches. (Mon, 13 May 2024 12:35:02 GMT) Full text and rfc822 format available.

Message #17 received at 70563 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolas Graves <ngraves <at> ngraves.fr>, Andy Tai <atai <at> atai.org>
Cc: control <at> debbugs.gnu.org, 70563 <at> debbugs.gnu.org
Subject: Re: [bug#70563] QA review for 70563
Date: Mon, 13 May 2024 14:34:37 +0200
Hi Andy,

Did you receive Nicolas’ message below?

Nicolas Graves <ngraves <at> ngraves.fr> skribis:

> user guix
> usertag 70563 + reviewed-looks-good
> thanks
>
> Guix QA review form submission:
> The description probably needs a little bit more precision. In particular, it would be good to include the statement &quot;PKCS#11 is the de-facto standard to access cryptographic devices.&quot; or something like that. 
>
> Otherwise LGTM.

Note that despite being marked as “reviewed-looks-good”, Nicolas makes
a suggestion that I think is worth addressing in a second version.

Thanks,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#70563; Package guix-patches. (Mon, 13 May 2024 14:12:01 GMT) Full text and rfc822 format available.

Message #20 received at 70563 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 70563 <at> debbugs.gnu.org, control <at> debbugs.gnu.org,
 Nicolas Graves <ngraves <at> ngraves.fr>
Subject: Re: [bug#70563] QA review for 70563
Date: Mon, 13 May 2024 07:09:54 -0700
OK I did not see that reply in email but I will send v2 patch
addressing the comment

On Mon, May 13, 2024 at 5:34 AM Ludovic Courtès <ludo <at> gnu.org> wrote:
>
> Hi Andy,
>
> Did you receive Nicolas’ message below?
>
> Nicolas Graves <ngraves <at> ngraves.fr> skribis:
>
> > user guix
> > usertag 70563 + reviewed-looks-good
> > thanks
> >
> > Guix QA review form submission:
> > The description probably needs a little bit more precision. In particular, it would be good to include the statement &quot;PKCS#11 is the de-facto standard to access cryptographic devices.&quot; or something like that.
> >
> > Otherwise LGTM.
>
> Note that despite being marked as “reviewed-looks-good”, Nicolas makes
> a suggestion that I think is worth addressing in a second version.
>
> Thanks,
> Ludo’.



-- 
Andy Tai, atai <at> atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andytai1010
Year 2024 民國113年
自動的精神力是信仰與覺悟
自動的行為力是勞動與技能




Information forwarded to guix-patches <at> gnu.org:
bug#70563; Package guix-patches. (Thu, 16 May 2024 05:44:02 GMT) Full text and rfc822 format available.

Message #23 received at 70563 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 70563 <at> debbugs.gnu.org,
	ngraves <at> ngraves.fr,
	ludo <at> gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH v2] gnu: Add pkcs11-helper.
Date: Wed, 15 May 2024 22:42:09 -0700
* gnu/packages/security-token.scm (pkcs11-helper): New variable.

Change-Id: Ib17e0cf209a6fe797d0c797829ba91091b719028
---
 gnu/packages/security-token.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 35a8d4e216..78ddf5456b 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -394,6 +394,31 @@ (define-public opensc
 #15 standard and the PKCS #11 API.")
     (license license:lgpl2.1+)))
 
+
+(define-public pkcs11-helper
+  (package
+    (name "pkcs11-helper")
+    (version "1.30.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-"
+             version "/pkcs11-helper-" version ".tar.bz2"))
+       (sha256
+        (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c"))))
+    (build-system gnu-build-system)
+    (inputs (list openssl-1.1 pcsc-lite))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/OpenSC/pkcs11-helper")
+    (synopsis "Library that simplifies the interaction with PKCS#11 providers")
+    (description
+     "Pkcs11-helper is a library that simplifies the interaction with
+PKCS#11 providers for end-user applications. PKCS#11 is published standard.
+PKCS#11 is the de-facto standard to access cryptographic devices")
+    (license (list license:gpl2 license:bsd-3))))
+
+
 (define-public yubico-piv-tool
   (package
     (name "yubico-piv-tool")

base-commit: 5a624adfd7b14c3717237d137bd0766c77f0f570
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70563; Package guix-patches. (Wed, 22 May 2024 05:36:02 GMT) Full text and rfc822 format available.

Message #26 received at 70563 <at> debbugs.gnu.org (full text, mbox):

From: Z572 <zhengjunjie <at> iscas.ac.cn>
To: Andy Tai <atai <at> atai.org>
Cc: ngraves <at> ngraves.fr, ludo <at> gnu.org, 70563 <at> debbugs.gnu.org
Subject: Re: [bug#70563] [PATCH v2] gnu: Add pkcs11-helper.
Date: Wed, 22 May 2024 13:34:48 +0800
[Message part 1 (text/plain, inline)]
Andy Tai <atai <at> atai.org> writes:

> * gnu/packages/security-token.scm (pkcs11-helper): New variable.
>
> Change-Id: Ib17e0cf209a6fe797d0c797829ba91091b719028
> ---
>  gnu/packages/security-token.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
> index 35a8d4e216..78ddf5456b 100644
> --- a/gnu/packages/security-token.scm
> +++ b/gnu/packages/security-token.scm
> @@ -394,6 +394,31 @@ (define-public opensc
>  #15 standard and the PKCS #11 API.")
>      (license license:lgpl2.1+)))
>  
> +
> +(define-public pkcs11-helper
> +  (package
> +    (name "pkcs11-helper")
> +    (version "1.30.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-"
> +             version "/pkcs11-helper-" version ".tar.bz2"))
> +       (sha256
> +        (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c"))))
> +    (build-system gnu-build-system)
> +    (inputs (list openssl-1.1 pcsc-lite))

Can this package use openssl-3.0? As i known, openssl 1.1 is EOL,
see https://www.openssl.org/blog/blog/2023/03/28/1.1.1-EOL/index.html.
It is best not to add more openssl-1.1 dependencies.  other LGTM.

> +    (native-inputs (list pkg-config))
> +    (home-page "https://github.com/OpenSC/pkcs11-helper")
> +    (synopsis "Library that simplifies the interaction with PKCS#11 providers")
> +    (description
> +     "Pkcs11-helper is a library that simplifies the interaction with
> +PKCS#11 providers for end-user applications. PKCS#11 is published standard.
> +PKCS#11 is the de-facto standard to access cryptographic devices")
> +    (license (list license:gpl2 license:bsd-3))))
> +
> +
>  (define-public yubico-piv-tool
>    (package
>      (name "yubico-piv-tool")
>
> base-commit: 5a624adfd7b14c3717237d137bd0766c77f0f570
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#70563; Package guix-patches. (Wed, 22 May 2024 06:19:02 GMT) Full text and rfc822 format available.

Message #29 received at 70563 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Z572 <zhengjunjie <at> iscas.ac.cn>
Cc: ngraves <at> ngraves.fr, ludo <at> gnu.org, 70563 <at> debbugs.gnu.org
Subject: Re: [bug#70563] [PATCH v2] gnu: Add pkcs11-helper.
Date: Tue, 21 May 2024 23:16:14 -0700
will check and possible update patch




Information forwarded to guix-patches <at> gnu.org:
bug#70563; Package guix-patches. (Wed, 22 May 2024 17:33:02 GMT) Full text and rfc822 format available.

Message #32 received at 70563 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 70563 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH v3] gnu: Add pkcs11-helper.
Date: Wed, 22 May 2024 10:31:37 -0700
* gnu/packages/security-token.scm (pkcs11-helper): New variable.

Change-Id: Ib17e0cf209a6fe797d0c797829ba91091b719028
---
 gnu/packages/security-token.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 35a8d4e216..939febd4e3 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -394,6 +394,31 @@ (define-public opensc
 #15 standard and the PKCS #11 API.")
     (license license:lgpl2.1+)))
 
+
+(define-public pkcs11-helper
+  (package
+    (name "pkcs11-helper")
+    (version "1.30.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-"
+             version "/pkcs11-helper-" version ".tar.bz2"))
+       (sha256
+        (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c"))))
+    (build-system gnu-build-system)
+    (inputs (list openssl pcsc-lite))
+    (native-inputs (list pkg-config))
+    (home-page "https://github.com/OpenSC/pkcs11-helper")
+    (synopsis "Library that simplifies the interaction with PKCS#11 providers")
+    (description
+     "Pkcs11-helper is a library that simplifies the interaction with
+PKCS#11 providers for end-user applications. PKCS#11 is published standard.
+PKCS#11 is the de-facto standard to access cryptographic devices")
+    (license (list license:gpl2 license:bsd-3))))
+
+
 (define-public yubico-piv-tool
   (package
     (name "yubico-piv-tool")

base-commit: f1a573067c7157a30e8d5e5b3443fee7fcb8af42
-- 
2.34.1





Reply sent to Zheng Junjie <zhengjunjie <at> iscas.ac.cn>:
You have taken responsibility. (Thu, 23 May 2024 05:36:01 GMT) Full text and rfc822 format available.

Notification sent to Andy Tai <atai <at> atai.org>:
bug acknowledged by developer. (Thu, 23 May 2024 05:36:02 GMT) Full text and rfc822 format available.

Message #37 received at 70563-done <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Andy Tai <atai <at> atai.org>
Cc: 70563-done <at> debbugs.gnu.org
Subject: Re: [bug#70563] [PATCH v3] gnu: Add pkcs11-helper.
Date: Thu, 23 May 2024 13:34:51 +0800
[Message part 1 (text/plain, inline)]
Andy Tai <atai <at> atai.org> writes:

> * gnu/packages/security-token.scm (pkcs11-helper): New variable.
>
> Change-Id: Ib17e0cf209a6fe797d0c797829ba91091b719028
> ---
>  gnu/packages/security-token.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
> index 35a8d4e216..939febd4e3 100644
> --- a/gnu/packages/security-token.scm
> +++ b/gnu/packages/security-token.scm
> @@ -394,6 +394,31 @@ (define-public opensc
>  #15 standard and the PKCS #11 API.")
>      (license license:lgpl2.1+)))
>  
> +
> +(define-public pkcs11-helper
> +  (package
> +    (name "pkcs11-helper")
> +    (version "1.30.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-"
> +             version "/pkcs11-helper-" version ".tar.bz2"))
> +       (sha256
> +        (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c"))))
> +    (build-system gnu-build-system)
> +    (inputs (list openssl pcsc-lite))
> +    (native-inputs (list pkg-config))
> +    (home-page "https://github.com/OpenSC/pkcs11-helper")
> +    (synopsis "Library that simplifies the interaction with PKCS#11 providers")
> +    (description
> +     "Pkcs11-helper is a library that simplifies the interaction with
> +PKCS#11 providers for end-user applications. PKCS#11 is published standard.
> +PKCS#11 is the de-facto standard to access cryptographic devices")
> +    (license (list license:gpl2 license:bsd-3))))
> +
> +
>  (define-public yubico-piv-tool
>    (package
>      (name "yubico-piv-tool")
>
> base-commit: f1a573067c7157a30e8d5e5b3443fee7fcb8af42

push, see https://git.savannah.gnu.org/cgit/guix.git/commit/?id=d4118a34e34554592a777000497f2c3d33fc6f5b
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 20 Jun 2024 11:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 36 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.