GNU logs - #70588, boring messages

Message sent to ludo@HIDDEN, bug-guix@HIDDEN:

Subject: bug#70588: hash mismatch error and stop fallback
Resent-From: Simon Tournier <zimon.toutoune@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: ludo@HIDDEN, bug-guix@HIDDEN
Resent-Date: Fri, 26 Apr 2024 08:50:11 +0000
Resent-Message-ID: <handler.70588.B.171412135318140 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 70588 <at> debbugs.gnu.org
Cc: ludo@HIDDEN
From: Simon Tournier <zimon.toutoune@HIDDEN>
Date: Thu, 25 Apr 2024 15:28:27 +0200
Message-ID: <87ttjpinb8.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=2a00:1450:4864:20::434;
 envelope-from=zimon.toutoune@HIDDEN; helo=mail-wr1-x434.google.com
X-Spam_score_int: -10
X-Spam_score: -1.1
X-Spam_bar: -
X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_12_24=1.049,
 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.8 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.

 Content preview:  Hi, Considering something from the past =?UTF-8?Q?=E2=80=93?= well to my knowledge
    it is still an issue with the current implementation and such it will be
   a issue for the future. ;-) For instance, the R package MASS from 2019 (Guix
    revision 711cec): because the CRAN project did some in-place replacements,
    we have a hash mismatch and all the process stops. 

 Content analysis details:   (1.8 points, 10.0 required)

  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
                             provider (zimon.toutoune[at]gmail.com)
  0.8 DATE_IN_PAST_12_24     Date: is 12 to 24 hours before Received: date
  1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.8 (/)

Hi,

Considering something from the past =E2=80=93 well to my knowledge it is st=
ill
an issue with the current implementation and such it will be a issue for
the future. ;-)

For instance, the R package MASS from 2019 (Guix revision 711cec):
because the CRAN project did some in-place replacements, we have a hash
mismatch and all the process stops.

--8<---------------cut here---------------start------------->8---
$ guix build /gnu/store/wfq2ji5x9awgyk680i1vv95hq75nx3vv-MASS_7.3-51.4.tar.=
gz.drv
substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
substitute: updating substitutes from 'https://bordeaux.guix.gnu.org'... 10=
0.0%
The following derivation will be built:
  /gnu/store/wfq2ji5x9awgyk680i1vv95hq75nx3vv-MASS_7.3-51.4.tar.gz.drv
building /gnu/store/wfq2ji5x9awgyk680i1vv95hq75nx3vv-MASS_7.3-51.4.tar.gz.d=
rv...

Starting download of /gnu/store/gxbam95zqjaxdd6303j97z4djr907yzn-MASS_7.3-5=
1.4.tar.gz
From http://cran.r-project.org/src/contrib/MASS_7.3-51.4.tar.gz...
download failed "http://cran.r-project.org/src/contrib/MASS_7.3-51.4.tar.gz=
" 404 "Not Found"

Starting download of /gnu/store/gxbam95zqjaxdd6303j97z4djr907yzn-MASS_7.3-5=
1.4.tar.gz
From http://cran.rstudio.com/src/contrib/MASS_7.3-51.4.tar.gz...
download failed "http://cran.rstudio.com/src/contrib/MASS_7.3-51.4.tar.gz" =
404 "Not Found"

Starting download of /gnu/store/gxbam95zqjaxdd6303j97z4djr907yzn-MASS_7.3-5=
1.4.tar.gz
From http://cran.univ-lyon1.fr/src/contrib/MASS_7.3-51.4.tar.gz...
following redirection to `https://pbil.univ-lyon1.fr/CRAN/src/contrib/MASS_=
7.3-51.4.tar.gz'...
download failed "https://pbil.univ-lyon1.fr/CRAN/src/contrib/MASS_7.3-51.4.=
tar.gz" 404 "Not Found"

Starting download of /gnu/store/gxbam95zqjaxdd6303j97z4djr907yzn-MASS_7.3-5=
1.4.tar.gz
From http://cran.ism.ac.jp/src/contrib/MASS_7.3-51.4.tar.gz...
download failed "http://cran.ism.ac.jp/src/contrib/MASS_7.3-51.4.tar.gz" 40=
4 "Not Found"

Starting download of /gnu/store/gxbam95zqjaxdd6303j97z4djr907yzn-MASS_7.3-5=
1.4.tar.gz
From http://cran.stat.auckland.ac.nz/src/contrib/MASS_7.3-51.4.tar.gz...
download failed "http://cran.stat.auckland.ac.nz/src/contrib/MASS_7.3-51.4.=
tar.gz" 404 "Not Found"

Starting download of /gnu/store/gxbam95zqjaxdd6303j97z4djr907yzn-MASS_7.3-5=
1.4.tar.gz
From http://cran.mirror.ac.za/src/contrib/MASS_7.3-51.4.tar.gz...
download failed "http://cran.mirror.ac.za/src/contrib/MASS_7.3-51.4.tar.gz"=
 404 "Not Found"

Starting download of /gnu/store/gxbam95zqjaxdd6303j97z4djr907yzn-MASS_7.3-5=
1.4.tar.gz
From http://cran.csie.ntu.edu.tw/src/contrib/MASS_7.3-51.4.tar.gz...
download failed "http://cran.csie.ntu.edu.tw/src/contrib/MASS_7.3-51.4.tar.=
gz" 404 "Not Found"

Starting download of /gnu/store/gxbam95zqjaxdd6303j97z4djr907yzn-MASS_7.3-5=
1.4.tar.gz
From http://cran.r-project.org/src/contrib/Archive/MASS/MASS_7.3-51.4.tar.g=
z...
downloading from http://cran.r-project.org/src/contrib/Archive/MASS/MASS_7.=
3-51.4.tar.gz ...
 MASS_7.3-51.4.tar.gz  476KiB         2.1MiB/s 00:00 =E2=96=95=E2=96=88=E2=
=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=
=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=
=E2=96=8F 100.0%
sha256 hash mismatch for /gnu/store/gxbam95zqjaxdd6303j97z4djr907yzn-MASS_7=
.3-51.4.tar.gz:
  expected hash: 0x1ckf51y851g0kvbhsgdxb26vfpmbw3xdbcnh3ck7fjm13da4cr
  actual hash:   1swfd4jnqhsb2imznib629bywrxah7b63yqxhwhd9bhyaji70hl4
hash mismatch for store item '/gnu/store/gxbam95zqjaxdd6303j97z4djr907yzn-M=
ASS_7.3-51.4.tar.gz'
build of /gnu/store/wfq2ji5x9awgyk680i1vv95hq75nx3vv-MASS_7.3-51.4.tar.gz.d=
rv failed
View build log at '/var/log/guix/drvs/wf/q2ji5x9awgyk680i1vv95hq75nx3vv-MAS=
S_7.3-51.4.tar.gz.drv.gz'.
guix build: error: build of `/gnu/store/wfq2ji5x9awgyk680i1vv95hq75nx3vv-MA=
SS_7.3-51.4.tar.gz.drv' failed
--8<---------------cut here---------------end--------------->8---

When the source is correctly available in SWH:

--8<---------------cut here---------------start------------->8---
$ guix build /gnu/store/wfq2ji5x9awgyk680i1vv95hq75nx3vv-MASS_7.3-51.4.tar.=
gz.drv
The following derivation will be built:
  /gnu/store/wfq2ji5x9awgyk680i1vv95hq75nx3vv-MASS_7.3-51.4.tar.gz.drv
building /gnu/store/wfq2ji5x9awgyk680i1vv95hq75nx3vv-MASS_7.3-51.4.tar.gz.d=
rv...

[...]

Starting download of /gnu/store/gxbam95zqjaxdd6303j97z4djr907yzn-MASS_7.3-5=
1.4.tar.gz
From https://archive.softwareheritage.org/api/1/content/sha256:9911d546a8d2=
9dc906b46cb53ef8aad76d23566f4fc3b52778a1201f8a9b2c74/raw/...
downloading from https://archive.softwareheritage.org/api/1/content/sha256:=
9911d546a8d29dc906b46cb53ef8aad76d23566f4fc3b52778a1201f8a9b2c74/raw/ ...
 raw/  476KiB                         9.9MiB/s 00:00 =E2=96=95=E2=96=88=E2=
=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=
=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=E2=96=88=
=E2=96=8F 100.0%
successfully built /gnu/store/wfq2ji5x9awgyk680i1vv95hq75nx3vv-MASS_7.3-51.=
4.tar.gz.drv
/gnu/store/gxbam95zqjaxdd6303j97z4djr907yzn-MASS_7.3-51.4.tar.gz

$ guix hash /gnu/store/gxbam95zqjaxdd6303j97z4djr907yzn-MASS_7.3-51.4.tar.gz
0x1ckf51y851g0kvbhsgdxb26vfpmbw3xdbcnh3ck7fjm13da4cr
--8<---------------cut here---------------end--------------->8---

Therefore, the bug is to not consider a hash mismatch as a fullstop and
error out but consider it as a failure of one strategy and thus try the
next strategy.

Other said, hash mismatch should be raised and obviously the content
must be discarded; then the hash mismatch should be considered as =E2=80=9C=
not
found=E2=80=9D so let try the next strategy for downloading the content.

Cheers,
simon

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Simon Tournier <zimon.toutoune@HIDDEN>
Subject: bug#70588: Acknowledgement (hash mismatch error and stop fallback)
Message-ID: <handler.70588.B.171412135318140.ack <at> debbugs.gnu.org>
References: <87ttjpinb8.fsf@HIDDEN>
X-Gnu-PR-Message: ack 70588
X-Gnu-PR-Package: guix
Reply-To: 70588 <at> debbugs.gnu.org
Date: Fri, 26 Apr 2024 08:50:13 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  ludo@HIDDEN
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 70588 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
70588: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70588
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#70588: hash mismatch error and stop fallback
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Wed, 01 May 2024 10:37:03 +0000
Resent-Message-ID: <handler.70588.B70588.171455982019027 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Simon Tournier <zimon.toutoune@HIDDEN>
Cc: 70588 <at> debbugs.gnu.org
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
In-Reply-To: <87ttjpinb8.fsf@HIDDEN> (Simon Tournier's message of "Thu, 25
 Apr 2024 15:28:27 +0200")
References: <87ttjpinb8.fsf@HIDDEN>
Date: Wed, 01 May 2024 12:36:27 +0200
Message-ID: <87h6fh7r9w.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

Simon Tournier <zimon.toutoune@HIDDEN> skribis:

> Other said, hash mismatch should be raised and obviously the content
> must be discarded; then the hash mismatch should be considered as =E2=80=
=9Cnot
> found=E2=80=9D so let try the next strategy for downloading the content.

Agreed.  I merged it with <https://issues.guix.gnu.org/28659>.

Thanks,
Ludo=E2=80=99.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 1 May 2024 10:36:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 01 06:36:02 2024
Received: from localhost ([127.0.0.1]:36673 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s27Ji-0004vS-0n
	for submit <at> debbugs.gnu.org; Wed, 01 May 2024 06:36:02 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:40656)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1s27Jf-0004vA-NM
 for control <at> debbugs.gnu.org; Wed, 01 May 2024 06:36:00 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1s27JD-0005ru-Il
 for control <at> debbugs.gnu.org; Wed, 01 May 2024 06:35:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to:
 references; bh=LVzaG5N61pdo1WvVetyP63LxLXZ5nf/bi4c85EN90hg=; b=X+p0EpYwWWMG1x
 feCSvt9GveO68/xskeIyg8mGM83u0ySj5+261uZB4fYV6o1o7HxVEgdzA4DiojWhPla3mW21GHIpg
 0zNPpNZGJsfMFrUwRehBUvClrxM8oPvN3qdeKGViiEdZqQqJEkZvyuCOx82tnMozF5GJYC5UocBrj
 rOgZ+MrKEeCgo7nMPYmWqczdn7X/s4ZPBCWedZNgiKOKfAwLfdDnrsnu2/aGSOvJjQcEZMnd8ETpn
 Rg8LQM/xanvc52EABK2pRUGnPPVEIOEI3st2shULUXhz+p/Z7o8wAG6W4hW7Fylzv5yVbyb2SPzCb
 58gu7WnOVluKgaLUVLyw==;
Date: Wed, 01 May 2024 12:35:08 +0200
Message-Id: <87msp97rc3.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Subject: control message for bug #70588
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

severity 70588 important
quit

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 1 May 2024 10:36:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 01 06:36:14 2024
Received: from localhost ([127.0.0.1]:36678 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s27Ju-0004vx-AF
	for submit <at> debbugs.gnu.org; Wed, 01 May 2024 06:36:14 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:45552)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1s27Js-0004vl-Qn
 for control <at> debbugs.gnu.org; Wed, 01 May 2024 06:36:13 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1s27JQ-0005sb-R7
 for control <at> debbugs.gnu.org; Wed, 01 May 2024 06:35:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to:
 references; bh=wOpiVfXFhMzec0GeQZP58monAmb1EPislekB49136L0=; b=qD7H0RSmaPTy4c
 YPH03xhsTBeUfpYvU31Q2KbM1bCjGKPBPLr32YUWBHG5JSf4AIlB0ACiwo3pU1ZO/KUnDaKFBIQTw
 MAFKszdL7yDoNSI+DmH9rJWkIwNybC+ozbpoxKsWX9lvMFTY58kqWLfxBn3p6j4PS1V8J5hTMTRLU
 +MRbuUVyO1UI7KKCFyWsAAJhycG1lIqubI21qU7HQDbiPH3Qd/OYHc0LUUb0IzWGVml3R3dthUhJm
 G+uGOc166jiZO4jI9/E5R/A23g3nQzsHin8w7Gk7hh+saqE2E27rSDx+BKpM54DJZ7NIEIgopcV+a
 83rkD22V0hid+PoRs5EA==;
Date: Wed, 01 May 2024 12:35:39 +0200
Message-Id: <87le4t7rb8.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Subject: control message for bug #28659
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

merge 28659 70588
quit

Message sent to bug-guix@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#70588: hash mismatch error and stop fallback
Resent-From: Simon Tournier <zimon.toutoune@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Fri, 03 May 2024 18:33:02 +0000
Resent-Message-ID: <handler.70588.B70588.171476117521905 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 70588
X-GNU-PR-Package: guix
X-GNU-PR-Keywords: 
To: 70588 <at> debbugs.gnu.org
Cc: ludo@HIDDEN
Received: via spool by 70588-submit <at> debbugs.gnu.org id=B70588.171476117521905
          (code B ref 70588); Fri, 03 May 2024 18:33:02 +0000
Received: (at 70588) by debbugs.gnu.org; 3 May 2024 18:32:55 +0000
Received: from localhost ([127.0.0.1]:48127 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s2xiI-0005hF-Jd
	for submit <at> debbugs.gnu.org; Fri, 03 May 2024 14:32:55 -0400
Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:39147)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1s2xiG-0005h8-Fa
 for 70588 <at> debbugs.gnu.org; Fri, 03 May 2024 14:32:53 -0400
Received: by mail-lj1-x233.google.com with SMTP id
 38308e7fff4ca-2e2554b8cdfso1271fa.0
 for <70588 <at> debbugs.gnu.org>; Fri, 03 May 2024 11:32:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1714761144; x=1715365944; darn=debbugs.gnu.org;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=gxnttXzLj12523Nbhx/rHT+mn3qAeLKpnPJR5cMFBtI=;
 b=dQ4dr3pRGk54c8GyLLhDJHdCdLAD3ev48iKjUO+B41NFsZ7kL3p6t84+0oa1TY1+X0
 mbt55eQarJNd4oGNg0NAQe/Ehi6t905E1gdJkCmBuuS29H7Va+IEQQq3qITgz20lt4/y
 UIJXShewO3RR7q93Gch8A8QLdAcuI1dOAFfTa/wUafi/PBOvO+U0484ikuDPVqQTToYr
 xRn16tcFg0SR0OQAeZGlU7yRM2ub3UWCrDovMvZQkj0w6zPu3x5fvUIeGDqC4SyxN3n1
 8O6P6ECLKY3Uch90nHnQA1HrT4+Bd28YWf4Nc4TcQapsR3sfFAoOOTaV6GQrPj0DmEmA
 Pfrw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1714761144; x=1715365944;
 h=content-transfer-encoding:mime-version:user-agent:message-id:date
 :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
 :to:cc:subject:date:message-id:reply-to;
 bh=gxnttXzLj12523Nbhx/rHT+mn3qAeLKpnPJR5cMFBtI=;
 b=vWPPQ0oMFpgazPT3i8DHT2DJwPbs08zLpeXcm5zC0ldSrmiAzyIkrTD8b9fNxgZrsM
 A1ylK7dmDa/Pbt72+y1vkY6CuASGhNcwFhCRJd015cmvQ9w3J8mYPA1r0I0ALwnv+Kl/
 POZEQXIKlfQ/L4ZVqXy/9uxNjkKU+lFuDzFBg9kpBmMiL6TcGMae+Yuo1351lmrjnnkv
 U2FjL2slGhoyC+5VU/g2UnBLaMXlc0YTT/+EydW5BYJiCeZ5bwC3/wxmoDkpNP5WwCs1
 smJ+ruZuO/mR4oNRepvxvXK9q3GE3aSEhAsnNPhvukVeRmu2JQtzxJla3KO8LBi4FMnV
 eGOw==
X-Gm-Message-State: AOJu0YwWvg6/S7J92eyU46BQUI8pTkCWUL7RoeQXg1ruvYO9niaz10Sc
 9dk1E5rbbCrW5nAIXUbS6m+Ksemw0IubhW7FnIoIX4cRJWifACNr
X-Google-Smtp-Source: AGHT+IGt6OeQZhKz2avkRybGIdh6ZlwwwRIZERW+Kqu+aog9tLWQV5KTSiTYqEV6dc5GS0At8O0qpQ==
X-Received: by 2002:a2e:9f17:0:b0:2dd:87a9:f152 with SMTP id
 u23-20020a2e9f17000000b002dd87a9f152mr2200606ljk.2.1714761143647; 
 Fri, 03 May 2024 11:32:23 -0700 (PDT)
Received: from lili (roam-nat-fw-prg-194-254-61-41.net.univ-paris-diderot.fr.
 [194.254.61.41]) by smtp.gmail.com with ESMTPSA id
 j15-20020a05600c190f00b0041bf512f85bsm10183329wmq.14.2024.05.03.11.32.22
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 03 May 2024 11:32:22 -0700 (PDT)
From: Simon Tournier <zimon.toutoune@HIDDEN>
In-Reply-To: <87ttjpinb8.fsf@HIDDEN> (Simon Tournier's message of "Thu, 25
 Apr 2024 15:28:27 +0200")
References: <87ttjpinb8.fsf@HIDDEN>
Date: Fri, 03 May 2024 19:53:39 +0200
Message-ID: <878r0qkcik.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

On lun., 02 oct. 2017 at 17:09, ludo@HIDDEN (Ludovic Court=C3=A8s) wrote:

> The problem is that the hash check is performed by guix-daemon itself,
> not by =E2=80=9Cguix perform-download=E2=80=9D.  So when guix-daemon diag=
noses a hash
> mismatch, it=E2=80=99s too late and we cannot try again and use the
> content-addressed mirror.

This quote from [1].  Well, why not run a sequence of =E2=80=9Cguix downloa=
d=E2=80=9D
then =E2=80=9Cguix build=E2=80=9D?  Ah the store item would be hashed twice=
.  Let try to
avoid this sub-optimized behaviour.

The only way to avoid hashing twice is to extend the protocol of
guix-daemon.  Because currently it reads,

            /* Check the hash. */
            Hash h2 =3D recursive ? hashPath(ht, actualPath).first : hashFi=
le(ht, actualPath);
            if (h !=3D h2) {
		if (settings.printBuildTrace)
		    printMsg(lvlError, format("@ hash-mismatch %1% %2% %3% %4%")
			     % path % i->second.hashAlgo
			     % printHash16or32(h) % printHash16or32(h2));
                throw BuildError(format("hash mismatch for store item '%1%'=
") % path);
	    }

with the call under error catch:

        /* Compute the FS closure of the outputs and register them as
           being valid. */
        registerOutputs();

[...]

    } catch (BuildError & e) {


Thus the number of solutions is very limited. :-)

Well, from my understanding, moving elsewhere in guix-daemon the check
of the hash appears to me too cumbersome.  Therefore, the only way is to
replace this =E2=80=99BuildError=E2=80=99 by something that is not an error=
 and do not
register the item.

Easier to say than to implement.  Again from my understanding, each
strategy for downloading is seen by the daemon as an element of a list
of independent builds and these elements are tried in sequence.
Therefore, we need to special case in order to be able to distinguish
different kind of failures.

All in all, this bug (missing feature):

        Other said, hash mismatch should be raised and obviously the content
        must be discarded; then the hash mismatch should be considered as =
=E2=80=9Cnot
        found=E2=80=9D so let try the next strategy for downloading the con=
tent.

is not straightforward to fix. :-)  Need for more thought=E2=80=A6


Cheers,
simon


1: bug#28659: v0.13: guix pull fails; libgit2-0.26.0 and 0.25.1 content has=
hes fail
ludo@HIDDEN (Ludovic Court=C3=A8s)
Mon, 02 Oct 2017 17:09:39 +0200
id:87o9ppoabw.fsf@HIDDEN
https://issues.guix.gnu.org/28659
https://issues.guix.gnu.org/msgid/87o9ppoabw.fsf@HIDDEN
https://yhetil.org/guix/87o9ppoabw.fsf@HIDDEN

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 13 May 2024 10:20:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 13 06:20:07 2024
Received: from localhost ([127.0.0.1]:60071 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1s6Sms-0008Ix-Ps
	for submit <at> debbugs.gnu.org; Mon, 13 May 2024 06:20:06 -0400
Received: from eggs.gnu.org ([209.51.188.92]:49324)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1s6Smq-0008IN-HU
 for control <at> debbugs.gnu.org; Mon, 13 May 2024 06:20:05 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1s6Smk-0007FJ-RU
 for control <at> debbugs.gnu.org; Mon, 13 May 2024 06:19:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to:
 references; bh=Qr+39URydsRmMvvsn7j+Mmnoa0xM4KcIKxtNmEjiJCg=; b=MZHWfnTvQQ5fGM
 /+0Jb4sXSpHbafOqYtz27tosUwKgMjCe70SLkIxWQ2V+BdmewE3Wbg07TPTjG8k/J1TRcw+RkW8Ma
 rJp73z8dQXrpV2fcSxFAZWj3RqysoOJM0G0Rma2UNqpVNO354TsEqESMwuTVbnv1osot+v3CDnsnY
 3oeHXhvmIOAb/gClR0U2aHoPyVO9wJ6e3zuA80ZMfC1xwAgRIOY0SEMSr/CQ/2aAlJkplU6AJDfGw
 ETahuGpK8SkucgPTXshOQ3r0k+f7u2jPlytcxI6QYpfsjwvhekD+Sq+T7yLTDE+viGCEaW+zF21QW
 mncjO7/yfoa8pAS3PBfA==;
Date: Mon, 13 May 2024 12:19:43 +0200
Message-Id: <87a5kuc8u8.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Subject: control message for bug #70588
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

retitle 70588 Content-addressed mirror is not used upon invalid hash
quit

Last modified: Mon, 13 May 2024 10:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.