GNU bug report logs - #70656
[PATCH python-team 0/4] Use git-minimal/pinned for some Python packages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70656 in the body.
You can then email your comments to 70656 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH python-team 0/4] Use git-minimal/pinned for some Python
 packages
Date: Mon, 29 Apr 2024 21:38:03 +0100

[Message part 1 (text/plain, inline)]

This reduces the direct dependencies on git, making it easier to update.

Christopher Baines (4):
  gnu: python-gitpython: Use git-minimal/pinned.
  gnu: python-gitdb: Use git-minimal/pinned.
  gnu: python-pbr: Use git-minimal/pinned.
  gnu: python-versioneer: Use git-minimal/pinned.

 gnu/packages/python-xyz.scm      | 4 ++--
 gnu/packages/version-control.scm | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)


base-commit: 3bd8d238aba718bf949691d0e37fa310e2cfc12a
-- 
2.41.0

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 70656 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 70656 <at> debbugs.gnu.org
Subject: [PATCH python-team 2/4] gnu: python-gitdb: Use git-minimal/pinned.
Date: Mon, 29 Apr 2024 21:40:47 +0100

This helps reduce the dependencies on git, as I think it's find to build with
a slightly older git, at least during periods when git-minimal/pinned needs
updating.

* gnu/packages/version-control.scm (python-gitdb)[native-inputs]: Use
git-minimal/pinned.

Change-Id: Ib9e65383d18a234567a36824ad3e08dc21eff200
---
 gnu/packages/version-control.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index c340d5fdc8..c2ff4040fb 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -1409,7 +1409,7 @@ (define-public python-gitdb
     (propagated-inputs
      (list python-smmap))
     (native-inputs
-     (list git python-nose))
+     (list git-minimal/pinned python-nose))
     (home-page "https://github.com/gitpython-developers/gitdb")
     (synopsis "Python implementation of the Git object database")
     (description
-- 
2.41.0

Message #11 received at 70656 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 70656 <at> debbugs.gnu.org
Subject: [PATCH python-team 3/4] gnu: python-pbr: Use git-minimal/pinned.
Date: Mon, 29 Apr 2024 21:40:48 +0100

This helps reduce the dependencies on git, as I think it's find to build with
a slightly older git, at least during periods when git-minimal/pinned needs
updating.

* gnu/packages/version-control.scm (python-pbr)[propagated-inputs]: Use
git-minimal/pinned.

Change-Id: Ib90056a1a603e06a99b5c601f9fcba7375dc24ac
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index f22b891ba5..16b47d0aa7 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -5128,7 +5128,7 @@ (define-public python-pbr
     (arguments
      `(#:tests? #f)) ;; Most tests seem to use the Internet.
     (propagated-inputs
-      (list git)) ;; pbr actually uses the "git" binary.
+      (list git-minimal/pinned)) ;; pbr actually uses the "git" binary.
     (native-inputs
       `(("python-fixtures" ,python-fixtures-bootstrap)
         ;; discover, coverage, hacking, subunit
-- 
2.41.0

Message #14 received at 70656 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 70656 <at> debbugs.gnu.org
Subject: [PATCH python-team 4/4] gnu: python-versioneer: Use
 git-minimal/pinned.
Date: Mon, 29 Apr 2024 21:40:49 +0100

This helps reduce the dependencies on git, as I think it's find to build with
a slightly older git, at least during periods when git-minimal/pinned needs
updating.

* gnu/packages/version-control.scm (python-versioneer)[propagated-inputs]: Use
git-minimal/pinned.

Change-Id: Id537baa8228afeb3b84161ecb5fea0d131b45442
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 16b47d0aa7..b5a2197a0a 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -31915,7 +31915,7 @@ (define-public python-versioneer
                 (invoke "pycodestyle" "--max-line-length=88"
                         "git_version.py" "versioneer.py")))))))
     (native-inputs
-     (list git python-flake8 python-pycodestyle python-pyflakes))
+     (list git-minimal/pinned python-flake8 python-pycodestyle python-pyflakes))
     (propagated-inputs
      (list python-tomli))
     (home-page "https://github.com/python-versioneer/python-versioneer")
-- 
2.41.0

Message #17 received at 70656 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 70656 <at> debbugs.gnu.org
Subject: [PATCH python-team 1/4] gnu: python-gitpython: Use git-minimal/pinned.
Date: Mon, 29 Apr 2024 21:40:46 +0100

This helps reduce the dependencies on git, as I think it's find to build with
a slightly older git, at least during periods when git-minimal/pinned needs
updating.

* gnu/packages/version-control.scm (python-gitpython)[arguments,inputs]: Use
git-minimal/pinned.

Change-Id: Id4325fe58a62bafce58b74828fa5823621166c55
---
 gnu/packages/version-control.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 0c7c496c82..c340d5fdc8 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -1438,10 +1438,10 @@ (define-public python-gitpython
                       (substitute* "git/cmd.py"
                         (("git_exec_name = \"git\"")
                          (string-append "git_exec_name = \""
-                                        (assoc-ref inputs "git")
+                                        (assoc-ref inputs "git-minimal")
                                         "/bin/git\""))))))))
     (inputs
-     (list git))
+     (list git-minimal/pinned))
     (propagated-inputs
      (list python-gitdb python-typing-extensions))
     (native-inputs

base-commit: 3bd8d238aba718bf949691d0e37fa310e2cfc12a
-- 
2.41.0

Message #20 received at 70656 <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 70656 <at> debbugs.gnu.org, Tanguy Le Carrour <tanguy <at> bioneland.org>,
 Munyoki Kilyungi <me <at> bonfacemunyoki.com>, jgart <jgart <at> dismail.de>,
 Marius Bakke <marius <at> gnu.org>, Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: Re: [bug#70656] [PATCH python-team 3/4] gnu: python-pbr: Use
 git-minimal/pinned.
Date: Sat, 4 May 2024 10:12:37 +0200

Hi,

> This helps reduce the dependencies on git, as I think it's find to build with
> a slightly older git, at least during periods when git-minimal/pinned needs
> updating.

this one is used on the repository cloned during build. As far as I see
we use git-minimal for cloning. Do we know whether the on-disk structures
of git are stable, i.e. can a clone of git version A be read by a git
version B with B < A?

Lars

Message #23 received at 70656 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Lars-Dominik Braun <lars <at> 6xq.net>
Cc: 70656 <at> debbugs.gnu.org, Tanguy Le Carrour <tanguy <at> bioneland.org>,
 Munyoki Kilyungi <me <at> bonfacemunyoki.com>,
 Christopher Baines <mail <at> cbaines.net>, jgart <jgart <at> dismail.de>,
 Marius Bakke <marius <at> gnu.org>, Sharlatan Hellseher <sharlatanus <at> gmail.com>
Subject: Re: [bug#70656] [PATCH python-team 3/4] gnu: python-pbr: Use
 git-minimal/pinned.
Date: Thu, 24 Oct 2024 12:26:02 -0400

On Sat, May 4, 2024 at 4:14 AM Lars-Dominik Braun <lars <at> 6xq.net> wrote:
>
> Hi,
>
> > This helps reduce the dependencies on git, as I think it's find to build with
> > a slightly older git, at least during periods when git-minimal/pinned needs
> > updating.
>
> this one is used on the repository cloned during build. As far as I see
> we use git-minimal for cloning. Do we know whether the on-disk structures
> of git are stable, i.e. can a clone of git version A be read by a git
> version B with B < A?

Why do we use git-minimal for cloning instead of git-minimal/pinned?

Message #26 received at 70656 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Greg Hogan <code <at> greghogan.com>
Cc: 70656 <at> debbugs.gnu.org, 74892 <at> debbugs.gnu.org
Subject: Re: [bug#74892] [PATCH 0/9] Depending on 'git-minimal/pinned' where
 appropriate
Date: Sat, 21 Dec 2024 11:53:20 +0100

Hi,

Greg Hogan <code <at> greghogan.com> skribis:

> Please also look at #70656 from Christopher Baines. One of his
> proposed patches looks to have been the Python change noted above, two
> are included here, and the fourth proposed patch (python-pbr) has an
> outstanding question (that it is not included here might be the
> answer).

Thanks for the heads-up, I had completely overlooked that other patch
series.

I don’t see why the python-pbr change couldn’t be included;
‘git-minimal/pinned’ is just an older version, it shouldn’t be a
problem.

I’ll add it to this series and see whether I can push it to
‘python-team’.

Thanks!

Ludo’.

Message #31 received at 70656-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Sharlatan Hellseher <sharlatanus <at> gmail.com>, 70656-done <at> debbugs.gnu.org,
 74892-done <at> debbugs.gnu.org
Subject: Re: [bug#74892] [PATCH 0/9] Depending on 'git-minimal/pinned' where
 appropriate
Date: Sun, 22 Dec 2024 23:19:03 +0100

Ricardo Wurmus <rekado <at> elephly.net> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:

[...]

>> Sure I can do that if there are plans to merge it in the coming days;
>> otherwise I think I’d rather merge it straight to ‘master’ sooner.
>>
>> WDYT?
>
> We'd like to merge python-team "soon", but we're still dealing with
> pretty fundamental breakage (and I'm going to be away from keyboard for
> a while starting next week), so I think it would be better for you to
> push it straight to master when you see fit.

Pushed:

  988ceea743 * gnu: python-pbr: Use git-minimal/pinned.
  976ea30c46 * gnu: pre-commit: Switch to ‘git-minimal/pinned’.
  8560cddd0a * gnu: python-reno: Switch to ‘git-minimal/pinned’.
  37e624859b * gnu: rust-git2: Switch to ‘git-minimal/pinned’.
  d8f413eb52 * gnu: podman: Switch to ‘git-minimal/pinned’.
  b3ee0f54ff * gnu: crun: Switch to ‘git-minimal/pinned'.
  b2754935cc * gnu: python-kanon: Switch to ‘git-minimal/pinned’.
  1cb16d8aba * gnu: python-gitdb: Switch to ‘git-minimal/pinned’.
  549e0f2fa7 * gnu: python-gitpython: Switch to ‘git-minimal/pinned’.
  43c16ce7fa * gnu: python-gitpython: Rewrite to use gexps.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.