Debbugs Internal Request <help-debbugs@HIDDEN>
to internal_control <at> debbugs.gnu.org.
Full text available.
Received: (at 70794) by debbugs.gnu.org; 28 Apr 2025 20:22:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 28 16:22:33 2025
Received: from localhost ([127.0.0.1]:36345 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1u9Uzo-0006KD-Kg
for submit <at> debbugs.gnu.org; Mon, 28 Apr 2025 16:22:33 -0400
Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:50480)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <v.pupillo@HIDDEN>)
id 1u9Uzg-0006IM-9v
for 70794 <at> debbugs.gnu.org; Mon, 28 Apr 2025 16:22:29 -0400
Received: by mail-ej1-x629.google.com with SMTP id
a640c23a62f3a-ac339f53df9so1007278966b.1
for <70794 <at> debbugs.gnu.org>; Mon, 28 Apr 2025 13:22:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1745871738; x=1746476538; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=Odks9OYCd0/C+tj2j18R3M1+0kSVKNSiAL6cxruMhfg=;
b=nHXIlmte1O13TQ7esRa/Ls2VpEbYu4g09xcfY03nHNYUKfm3xUZcLTnCuBAITz2Jza
rqtYW2k9d3VxXZKYRuI2s3duSD6SDXAghByyci+2wXEVaqBvVi6hgAAd/yhpjDk9x0Pk
3NvHyJ9Dw+nyrK551dFPFbQHyrKF1e/iKEMJxx2+CvEQTI0/ULMO/iyoN7wHflYtQmAb
5FdXebYLIKBnojCkVT7WmB6PMQ26u4/rNGHva8PgfLdWnDP38Kjxl7d69YutaQmV+/U8
ww9XL/CTmGIdW74eBYeCnXwJ6Rsks8CHH/PhZnc3zafvY/EWLeSdECSm54A2on4xnKZE
IoUw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1745871738; x=1746476538;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=Odks9OYCd0/C+tj2j18R3M1+0kSVKNSiAL6cxruMhfg=;
b=VJ6me4+7HWi3GtvIM4+Fc/BQQsThaqCH0ijn07zv9O5GO7nhP+8RoBehbMj/Z/0tQc
z989JS+pkx7RR3RIv2sUotdJHUjVzBg/jwYTHrO1+vSg5GqD0s3+HC2pWGPNaoxSaY0U
kyyF+Zwb4q1RWCSGEfgtgZHDmfojCIIfVKLTekOUMagfSw8z5eQpc5ylx/2hSbkn9XCh
dpZhreEJwLt2iiQwHFQNNfztib6ruW8ij04QMkC+Clv2ICSiLSvm0iLe2sXSMEJwoJo9
Pb4OUgkRsTrK/44vwxeV1vxhehfkx5Zw1+btdHjTMJAnL4DXtRfldM8duj1QbRjjI9x/
24rQ==
X-Gm-Message-State: AOJu0YwjiBkBjZV/rYZ7Mli3u0lX3nsjIxtzqNKrBpyCriqFYyKVum2p
j4rbVfV0IsAiaZyAwtD3tbD+ksHZSf5MZM6Q6ungv/jvI/J9thXk
X-Gm-Gg: ASbGnct/AfE9Eskeav7o1cTAJqFU0mVru9f7K43/uW/VCafw4T80onRvPaS5kdChHWd
0o5ASbXkPPo3cxFqaVJJaGdIMcOv86HWX1OMbClkPvR2aYDPhH+RKbGXB4jkwboD+KsWy4kaWkS
n28HY102dshYn7qve3/YlWJG55OTYVCCbYlt/gCysXmMnmhPCDao7o11/609pcRR3Kl9YWYBbfB
OXGBLD36cRHjeZUwgVRywbqHmAM3NAs6EoPY7u22cKYT3hRZE1OhP7d2uUtDNDLKt5yRsR1384I
grTT3md0LNnbvBX7+11ZwsP2aUofgkXeyZ/DeIfVVgV4Qtw3Ux7cZB43kJRy1Mm+em4AX/7Z1Gk
7rBSI
X-Google-Smtp-Source: AGHT+IF6ajMjY3u6cxRjTHg3FgTy/qSmVoDqCZ99mYrRa0/qDTRg5X1agzpWw51MhCxnDmu54i4HNg==
X-Received: by 2002:a17:907:9725:b0:ac2:49b1:166f with SMTP id
a640c23a62f3a-ace84b4c0b9mr933962366b.52.1745871737902;
Mon, 28 Apr 2025 13:22:17 -0700 (PDT)
Received: from fedora.localnet (2-230-139-124.ip202.fastwebnet.it.
[2.230.139.124]) by smtp.gmail.com with ESMTPSA id
a640c23a62f3a-ace6edafbf0sm670156666b.168.2025.04.28.13.22.16
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 28 Apr 2025 13:22:17 -0700 (PDT)
From: Vincenzo Pupillo <v.pupillo@HIDDEN>
To: Mattias =?UTF-8?B?RW5nZGVnw6VyZA==?= <mattias.engdegard@HIDDEN>,
Eli Zaretskii <eliz@HIDDEN>, bug-gnu-emacs@HIDDEN
Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex
Date: Mon, 28 Apr 2025 22:22:16 +0200
Message-ID: <2805083.vuYhMxLoTh@fedora>
In-Reply-To: <CADwFkm=i=mdeQAk7Pkb7HRZeN9wQG05X6AdM3P2bEDWjCgfX0A@HIDDEN>
References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN>
<09473128-D0DB-442C-8404-EE58A18F5A5B@HIDDEN>
<CADwFkm=i=mdeQAk7Pkb7HRZeN9wQG05X6AdM3P2bEDWjCgfX0A@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart5014419.OV4Wx5bFTl"
Content-Transfer-Encoding: 7Bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 70794
Cc: 70794 <at> debbugs.gnu.org, Randy Taylor <dev@HIDDEN>, spacibba@HIDDEN,
Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
This is a multi-part message in MIME format.
--nextPart5014419.OV4Wx5bFTl
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Ciao,
Would the attached patch be good?
Vincenzo
p.s. the tests come from Rust docs.
In data gioved=C3=AC 6 giugno 2024 09:34:42 Ora legale dell=E2=80=99Europa =
centrale, Stefan=20
Kangas ha scritto:
> Mattias Engdeg=C3=A5rd <mattias.engdegard@HIDDEN> writes:
> > 3 juni 2024 kl. 18.33 skrev Eli Zaretskii <eliz@HIDDEN>:
> >> Fine by me (I don't use Rust), but is the rule really broken? What
> >> happens if you move it to the end?
> >=20
> > It is indeed broken as written because it would match anything
> > starting with 'warning:' to something that looks like an arrow further
> > down the log which could be an unrelated message a megabyte away.
> >=20
> > I could try to slap together a guess at what a better one would be but
> > then again, I wouldn't use it myself (rarely use Rust and when I do
> > it's one of those external packages which have their own patterns and
> > more importantly active maintainers). Furthermore I don't have the
> > time to go poking around in the rustc (or cargo?) source code to see
> > what the message-emitting parts look like, which is very useful when
> > adding patterns.
> >=20
> > Even with the obvious fixes, the pattern would still be incomplete and
> > not even match parts of the examples given. I'm happy to work with
> > Rust users or package maintainers to work out details but I don't want
> > to do a rush job now, nor delay Emacs 30.
>=20
> Randy, would you be interested in working with Mattias to create a good
> `compilation-mode` regexp for Rust?
--nextPart5014419.OV4Wx5bFTl
Content-Disposition: attachment;
filename="0001-Support-Rust-compiler-error-and-warning-messages-in-.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="UTF-8";
name="0001-Support-Rust-compiler-error-and-warning-messages-in-.patch"
From 3a1bcf8e5cfa4cd2640ccece85d68df3f880cc46 Mon Sep 17 00:00:00 2001
From: Vincenzo Pupillo <v.pupillo@HIDDEN>
Date: Sat, 26 Apr 2025 23:42:36 +0200
Subject: [PATCH] Support Rust compiler error and warning messages in compile
mode.
* etc/compilation.txt: Add examples of Rust compiler error and warning
messages.
* lisp/progmodes/compile.el
(compilation-error-regexp-alist-alist): Add Rust error and warning
regexps.
* test/lisp/progmodes/compile-tests.el
(compile-tests--test-regexps-data): Add test case.
---
etc/compilation.txt | 9 +++++++++
lisp/progmodes/compile.el | 7 +++++++
test/lisp/progmodes/compile-tests.el | 6 ++++++
3 files changed, 22 insertions(+)
diff --git a/etc/compilation.txt b/etc/compilation.txt
index 67c7000ae09..c8a66bd074f 100644
--- a/etc/compilation.txt
+++ b/etc/compilation.txt
@@ -487,6 +487,15 @@ symbol: php
Parse error: parse error, unexpected $ in main.php on line 59
Fatal error: Call to undefined function: mysql_pconnect() in db.inc on line 66
+* Rust
+
+symbol: rust-error rust-warning
+
+error[E0277]: `Foo` is not an iterator
+ --> src/main.rs:4:16
+warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133)
+ --> lint_example.rs:11:13
+
* Ruby
symbol: ruby
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 1ca58b3ac7d..7a1b5d4fdd1 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -565,6 +565,13 @@ compilation-error-regexp-alist-alist
"\\(?:Parse\\|Fatal\\) error: \\(.*\\) in \\(.*\\) on line \\([0-9]+\\)"
2 3 nil nil)
+ (rustc-error
+ "^error[^:]*:[^\n]*\n\s+-->\s\\([^\n]+\\):\\([0-9]+\\):\\([0-9]+\\)"
+ 1 2 3)
+ (rustc-warning
+ "^warning[^:]*:[^\n]*\n\s+-->\s\\([^\n]+\\):\\([0-9]+\\):\\([0-9]+\\)"
+ 1 2 3 1)
+
(rxp
"^\\(?:Error\\|Warnin\\(g\\)\\):.*\n.* line \\([0-9]+\\) char\
\\([0-9]+\\) of file://\\(.+\\)"
diff --git a/test/lisp/progmodes/compile-tests.el b/test/lisp/progmodes/compile-tests.el
index b12e5d0b2d4..c98f8404e7b 100644
--- a/test/lisp/progmodes/compile-tests.el
+++ b/test/lisp/progmodes/compile-tests.el
@@ -372,6 +372,12 @@ compile-tests--test-regexps-data
1 nil 59 "main.php")
(php "Fatal error: Call to undefined function: mysql_pconnect() in db.inc on line 66"
1 nil 66 "db.inc")
+ ;; rust
+ (rust-error
+ "error[E0277]: `Foo` is not an iterator\n --> src/main.rs:4:16"
+ 1 16 4 "src/main.rs")
+ (rust-warning "warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133)\n --> lint_example.rs:11:13"
+ 1 13 11 "lint_example.rs")
;; ruby (uses gnu)
(gnu "plain-exception.rb:7:in `fun': unhandled exception"
1 nil 7 "plain-exception.rb")
--
2.49.0
--nextPart5014419.OV4Wx5bFTl--
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 28 Apr 2025 20:22:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 28 16:22:46 2025
Received: from localhost ([127.0.0.1]:36351 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1u9Uzx-0006LH-Tq
for submit <at> debbugs.gnu.org; Mon, 28 Apr 2025 16:22:46 -0400
Received: from lists.gnu.org ([2001:470:142::17]:50554)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <v.pupillo@HIDDEN>)
id 1u9Uzo-0006JQ-NB
for submit <at> debbugs.gnu.org; Mon, 28 Apr 2025 16:22:33 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <v.pupillo@HIDDEN>)
id 1u9Uzh-0005qe-BX
for bug-gnu-emacs@HIDDEN; Mon, 28 Apr 2025 16:22:26 -0400
Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <v.pupillo@HIDDEN>)
id 1u9Uzd-0002Wg-OE; Mon, 28 Apr 2025 16:22:23 -0400
Received: by mail-ed1-x532.google.com with SMTP id
4fb4d7f45d1cf-5e61da95244so715932a12.2;
Mon, 28 Apr 2025 13:22:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1745871738; x=1746476538; darn=gnu.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=Odks9OYCd0/C+tj2j18R3M1+0kSVKNSiAL6cxruMhfg=;
b=H55TDFgTwrdUYNQR2A61GxoCqZBs8QUPMp7JNVsygFb+Tn/GTaDkBKy08zk04YkxHb
Dt5NZRNL7qMBpXmbR2WiE4af0amavudwS3cFJMoqA0JR7CM7PxOtnwSzLmQQ8ZYt4Mo6
UN17uE3I/xYyXI5QGK0uORjmYTC62743ZeG+eQEedwu1R+phl4fVMpwejPT15+zMmClg
bFawNK9N3HhR/85WXQ+w1ZvDM+S3ew4kJFb4/PBBmzk4bCePIgpIcwJEyPwGyK9mr6bd
+p0xqLg/uXye8g23G3C8h2BAqBiQ8suucUfjDx/yc7K3AEVvCAiO4USUte1VGMDXcfRc
0rVg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1745871738; x=1746476538;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=Odks9OYCd0/C+tj2j18R3M1+0kSVKNSiAL6cxruMhfg=;
b=HkiWNf5owybhS98cdDSM1abxHiPIo6do1dHVRYF4MpOfc6VL02aavBuWXbtPny4Pky
lA6dy5NeTqPg+0L1IzD81i7Apgu57zBSb/bSgf4ZX+grgy2mm7M5yDO7n9yMz/hsOAuO
BoGce9adCVEOelp2EQXxqhhw9zI/gBfRsNhOUWXmFXir+ukpj1L3L9O93D2pGlpQF/4y
Xcg7GXTq+5uew59ARZcaGnJ50y4QWPe+caoYEXqihYYXq5FI3RSuGXAESpAUrOhCDF7+
nioTl75SEeb8YU57zx4QGDa32Tcaz1tDNDJpxwBtS2XE91iOIFZ6Ebo3JJiU4s8fW63B
C0bw==
X-Forwarded-Encrypted: i=1;
AJvYcCUx97ySEU0xPjE/3Dnrm35XNEGzj5Xs3qn0m93B0X7hbJoWWIbDk7YYqh62Kq4SmkdnRmfIAw==@gnu.org,
AJvYcCXId9bx4dRGbMFRt/8OJ7pWpCnokP4NhXXDXGPx6IOzAoZIuAX8YTrxwEkBbihzpAZ444V/mow+GsktJM4S@HIDDEN
X-Gm-Message-State: AOJu0Yz6dD7oP4YaCpTs81pNMvbpneQrnyoNmfXYXZlPk0ec1yZnS9u/
HuphJU/kQxfsiBaiDm4fhavYpIWMMuCU8UlO9koyFWvLUjF1YMGe
X-Gm-Gg: ASbGncs4hAPvHkWE2P5r5qNeO9rDQ470tFdOLQFCdKSqu6XGmX7I4EKJITDRwvgmt52
tHLPJAORwpe3j6JO+HsKTsCKooBBHMjpfc1nQWa+Lnmx5ievfMPAbU5OVx20PgB7mUkY0BKSrNu
i3YwRXBdZ5QeqNJ9lpfngtgB9RuHkCNXZIFrT2mtPIWvXguNlga5YOtIJu5CrTabKmBrQfjVv0Y
wmU4C1l9i7irbdhmDl7uSmzaj+TIRIRxMxrKT5ljCMQM28me58JJYoHjOh7XFhiZSHBripWPzS5
QC9rGlQ+eBgr4X2+4SNKzdqHndY0igItZM3mpA37y0aE3b2j0AGXmK3M49sSWfZ/tWQdxsJ44r5
Bv6nL
X-Google-Smtp-Source: AGHT+IF6ajMjY3u6cxRjTHg3FgTy/qSmVoDqCZ99mYrRa0/qDTRg5X1agzpWw51MhCxnDmu54i4HNg==
X-Received: by 2002:a17:907:9725:b0:ac2:49b1:166f with SMTP id
a640c23a62f3a-ace84b4c0b9mr933962366b.52.1745871737902;
Mon, 28 Apr 2025 13:22:17 -0700 (PDT)
Received: from fedora.localnet (2-230-139-124.ip202.fastwebnet.it.
[2.230.139.124]) by smtp.gmail.com with ESMTPSA id
a640c23a62f3a-ace6edafbf0sm670156666b.168.2025.04.28.13.22.16
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 28 Apr 2025 13:22:17 -0700 (PDT)
From: Vincenzo Pupillo <v.pupillo@HIDDEN>
To: Mattias =?UTF-8?B?RW5nZGVnw6VyZA==?= <mattias.engdegard@HIDDEN>,
Eli Zaretskii <eliz@HIDDEN>, bug-gnu-emacs@HIDDEN
Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex
Date: Mon, 28 Apr 2025 22:22:16 +0200
Message-ID: <2805083.vuYhMxLoTh@fedora>
In-Reply-To: <CADwFkm=i=mdeQAk7Pkb7HRZeN9wQG05X6AdM3P2bEDWjCgfX0A@HIDDEN>
References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN>
<09473128-D0DB-442C-8404-EE58A18F5A5B@HIDDEN>
<CADwFkm=i=mdeQAk7Pkb7HRZeN9wQG05X6AdM3P2bEDWjCgfX0A@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart5014419.OV4Wx5bFTl"
Content-Transfer-Encoding: 7Bit
Received-SPF: pass client-ip=2a00:1450:4864:20::532;
envelope-from=v.pupillo@HIDDEN; helo=mail-ed1-x532.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: 70794 <at> debbugs.gnu.org, Randy Taylor <dev@HIDDEN>, spacibba@HIDDEN,
Stefan Kangas <stefankangas@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
This is a multi-part message in MIME format.
--nextPart5014419.OV4Wx5bFTl
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Ciao,
Would the attached patch be good?
Vincenzo
p.s. the tests come from Rust docs.
In data gioved=C3=AC 6 giugno 2024 09:34:42 Ora legale dell=E2=80=99Europa =
centrale, Stefan=20
Kangas ha scritto:
> Mattias Engdeg=C3=A5rd <mattias.engdegard@HIDDEN> writes:
> > 3 juni 2024 kl. 18.33 skrev Eli Zaretskii <eliz@HIDDEN>:
> >> Fine by me (I don't use Rust), but is the rule really broken? What
> >> happens if you move it to the end?
> >=20
> > It is indeed broken as written because it would match anything
> > starting with 'warning:' to something that looks like an arrow further
> > down the log which could be an unrelated message a megabyte away.
> >=20
> > I could try to slap together a guess at what a better one would be but
> > then again, I wouldn't use it myself (rarely use Rust and when I do
> > it's one of those external packages which have their own patterns and
> > more importantly active maintainers). Furthermore I don't have the
> > time to go poking around in the rustc (or cargo?) source code to see
> > what the message-emitting parts look like, which is very useful when
> > adding patterns.
> >=20
> > Even with the obvious fixes, the pattern would still be incomplete and
> > not even match parts of the examples given. I'm happy to work with
> > Rust users or package maintainers to work out details but I don't want
> > to do a rush job now, nor delay Emacs 30.
>=20
> Randy, would you be interested in working with Mattias to create a good
> `compilation-mode` regexp for Rust?
--nextPart5014419.OV4Wx5bFTl
Content-Disposition: attachment;
filename="0001-Support-Rust-compiler-error-and-warning-messages-in-.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="UTF-8";
name="0001-Support-Rust-compiler-error-and-warning-messages-in-.patch"
From 3a1bcf8e5cfa4cd2640ccece85d68df3f880cc46 Mon Sep 17 00:00:00 2001
From: Vincenzo Pupillo <v.pupillo@HIDDEN>
Date: Sat, 26 Apr 2025 23:42:36 +0200
Subject: [PATCH] Support Rust compiler error and warning messages in compile
mode.
* etc/compilation.txt: Add examples of Rust compiler error and warning
messages.
* lisp/progmodes/compile.el
(compilation-error-regexp-alist-alist): Add Rust error and warning
regexps.
* test/lisp/progmodes/compile-tests.el
(compile-tests--test-regexps-data): Add test case.
---
etc/compilation.txt | 9 +++++++++
lisp/progmodes/compile.el | 7 +++++++
test/lisp/progmodes/compile-tests.el | 6 ++++++
3 files changed, 22 insertions(+)
diff --git a/etc/compilation.txt b/etc/compilation.txt
index 67c7000ae09..c8a66bd074f 100644
--- a/etc/compilation.txt
+++ b/etc/compilation.txt
@@ -487,6 +487,15 @@ symbol: php
Parse error: parse error, unexpected $ in main.php on line 59
Fatal error: Call to undefined function: mysql_pconnect() in db.inc on line 66
+* Rust
+
+symbol: rust-error rust-warning
+
+error[E0277]: `Foo` is not an iterator
+ --> src/main.rs:4:16
+warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133)
+ --> lint_example.rs:11:13
+
* Ruby
symbol: ruby
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 1ca58b3ac7d..7a1b5d4fdd1 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -565,6 +565,13 @@ compilation-error-regexp-alist-alist
"\\(?:Parse\\|Fatal\\) error: \\(.*\\) in \\(.*\\) on line \\([0-9]+\\)"
2 3 nil nil)
+ (rustc-error
+ "^error[^:]*:[^\n]*\n\s+-->\s\\([^\n]+\\):\\([0-9]+\\):\\([0-9]+\\)"
+ 1 2 3)
+ (rustc-warning
+ "^warning[^:]*:[^\n]*\n\s+-->\s\\([^\n]+\\):\\([0-9]+\\):\\([0-9]+\\)"
+ 1 2 3 1)
+
(rxp
"^\\(?:Error\\|Warnin\\(g\\)\\):.*\n.* line \\([0-9]+\\) char\
\\([0-9]+\\) of file://\\(.+\\)"
diff --git a/test/lisp/progmodes/compile-tests.el b/test/lisp/progmodes/compile-tests.el
index b12e5d0b2d4..c98f8404e7b 100644
--- a/test/lisp/progmodes/compile-tests.el
+++ b/test/lisp/progmodes/compile-tests.el
@@ -372,6 +372,12 @@ compile-tests--test-regexps-data
1 nil 59 "main.php")
(php "Fatal error: Call to undefined function: mysql_pconnect() in db.inc on line 66"
1 nil 66 "db.inc")
+ ;; rust
+ (rust-error
+ "error[E0277]: `Foo` is not an iterator\n --> src/main.rs:4:16"
+ 1 16 4 "src/main.rs")
+ (rust-warning "warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133)\n --> lint_example.rs:11:13"
+ 1 13 11 "lint_example.rs")
;; ruby (uses gnu)
(gnu "plain-exception.rb:7:in `fun': unhandled exception"
1 nil 7 "plain-exception.rb")
--
2.49.0
--nextPart5014419.OV4Wx5bFTl--
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.Vincenzo Pupillo <v.pupillo@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Debbugs Internal Request <help-debbugs@HIDDEN>
to internal_control <at> debbugs.gnu.org.
Full text available.Received: (at 70794) by debbugs.gnu.org; 6 Jun 2024 07:36:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 06 03:36:13 2024 Received: from localhost ([127.0.0.1]:46961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sF7fM-0004YZ-UK for submit <at> debbugs.gnu.org; Thu, 06 Jun 2024 03:36:13 -0400 Received: from mail-ed1-f45.google.com ([209.85.208.45]:50438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1sF7fI-0004Xm-Q9 for 70794 <at> debbugs.gnu.org; Thu, 06 Jun 2024 03:36:07 -0400 Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-57a2406f951so621905a12.1 for <70794 <at> debbugs.gnu.org>; Thu, 06 Jun 2024 00:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717659284; x=1718264084; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=jTQtBYmh7LcAisqeymzAVviAbaTuGozDrZ8L9tTN6Zg=; b=Ww7uK5iaVWxgoBX2wThymyldXSwgx2szrrUXtOsPeN7tpePCw+GYuO9sJB7+Kc4fLy WmB5CLuYz6twoYgsIt0wYVkug5svrmtanzoqzLoaaXqhkN8P6VSb5UOslTCfqS1ay+Gq x76+JJZgKZyzq+7VVFjsCZfhNloLHM8hAlZngurBbxW30wWPBULPeNYssgcTao6vco6o Wukb3P4XkpXx8Xravt2NxTDap9xn/u4vu3PsjqkBSmhtTqTkxLlxw6P2xgnUwVigiF3J UFj6br5ZWAkm+sCQIUAA9Q8jUtxSgGk+K90ycKLRjyjisDQBMFE0C8oNkc4jIoum35dh hrYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717659284; x=1718264084; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jTQtBYmh7LcAisqeymzAVviAbaTuGozDrZ8L9tTN6Zg=; b=GJBDS746DAGUbaAuvaUCtcfBelYTKS350s7xsigjbvF2SnJwpj0yWyO9zcXJqHWxlG DE4oupojXKDKAeC8YcGGc8VipeRGz8XruJHRjfdEaTUhYJwAkaEE+5DUKGyTw6iXQTae a0dzslzHILzipIWaCLDoKAuS1aIe3BcqBTllBOIKf0EgBVbnmJpXXpBggNF++ImPgz9z 4sgs8qyp6KY0OQNJaGV36K1SZ60jAXdhNTpBgAKSfD89qRtjRNlNN5u2ncORHu+LBHjh SAEyw3s10lb+R0kJU31sfe08Ht2pdyw0rfx5bex3Gdl76hncbAecRBUj9qwYVRT573qQ oe+A== X-Gm-Message-State: AOJu0YwO+x3M9SZZx+LOTJe7ZxjhH4WI9mwbVf882UzBHDYLGEp60Zf1 uCY7pUfI4x1NW3ZoxQAS2Rxq1EdKJSLid0gWLYymkOeisODkaLO8zpYarq4wdLjM9MBWxkbvZOj ZYyla8ao4KDCJ96QSQ8lsBdDt0MU= X-Google-Smtp-Source: AGHT+IEUlYYzveMtWwWpa6BZJHLZZsGl6WHPw5TiI/AgZHPzzs2n+Kq1bXls4GND/VhBcEpUWHkCW0eoolZmceIMoOI= X-Received: by 2002:a50:9f4a:0:b0:57a:3114:7d07 with SMTP id 4fb4d7f45d1cf-57a8b6873damr3151647a12.9.1717659283982; Thu, 06 Jun 2024 00:34:43 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 6 Jun 2024 03:34:42 -0400 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <09473128-D0DB-442C-8404-EE58A18F5A5B@HIDDEN> References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN> <F834A272-58A5-470E-8369-D0C158461EA5@HIDDEN> <86sexukpuh.fsf@HIDDEN> <8BC5E59B-63B1-4784-9454-51925E9DBCFC@HIDDEN> <86ikyqkmuo.fsf@HIDDEN> <09473128-D0DB-442C-8404-EE58A18F5A5B@HIDDEN> MIME-Version: 1.0 Date: Thu, 6 Jun 2024 03:34:42 -0400 Message-ID: <CADwFkm=i=mdeQAk7Pkb7HRZeN9wQG05X6AdM3P2bEDWjCgfX0A@HIDDEN> Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70794 Cc: 70794 <at> debbugs.gnu.org, Randy Taylor <dev@HIDDEN>, spacibba@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd <mattias.engdegard@HIDDEN> writes: > 3 juni 2024 kl. 18.33 skrev Eli Zaretskii <eliz@HIDDEN>: > >> Fine by me (I don't use Rust), but is the rule really broken? What >> happens if you move it to the end? > > It is indeed broken as written because it would match anything > starting with 'warning:' to something that looks like an arrow further > down the log which could be an unrelated message a megabyte away. > > I could try to slap together a guess at what a better one would be but > then again, I wouldn't use it myself (rarely use Rust and when I do > it's one of those external packages which have their own patterns and > more importantly active maintainers). Furthermore I don't have the > time to go poking around in the rustc (or cargo?) source code to see > what the message-emitting parts look like, which is very useful when > adding patterns. > > Even with the obvious fixes, the pattern would still be incomplete and > not even match parts of the examples given. I'm happy to work with > Rust users or package maintainers to work out details but I don't want > to do a rush job now, nor delay Emacs 30. Randy, would you be interested in working with Mattias to create a good `compilation-mode` regexp for Rust?
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.Received: (at 70794) by debbugs.gnu.org; 5 Jun 2024 22:57:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 05 18:57:06 2024 Received: from localhost ([127.0.0.1]:44659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sEzZ4-0006vp-1n for submit <at> debbugs.gnu.org; Wed, 05 Jun 2024 18:57:06 -0400 Received: from sonic312-21.consmr.mail.bf2.yahoo.com ([74.6.128.83]:39392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <spacibba@HIDDEN>) id 1sEzZ2-0006vC-Kz for 70794 <at> debbugs.gnu.org; Wed, 05 Jun 2024 18:57:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1717628204; bh=sStieO3psgHUcGxQoGVBHjjAOfH7gYI5x8m2WGINAWo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=M1bO404GNVQrI1wfMjr5E1WBMqS1sNk1dQdwmr9cE8PJsMBGdDTUgWZGHFcmYG2lnQKf/TVmXuZ8yYoWqpZMDdlu/WfjXWyJ3cDhCo28ONqHN4hoFQmdYsDDhq6B7/Z/13c4VoZC7+YtflKbSoMmKpuqTNOkeZO5f9eUoFKzFB5n/4OfJ3RJW87bEGkzxP54XeGKtbtuWluVvTBZfVsqw1WV4mN72QuyQWtlPACgRjc4WstRZ3YUEzPH2yiguL+GZsl2A8De/BNSpwyCGsFUb/7e3x2o5HEJbfshGeRBS+gG02BeEYSxUWFU4zjRHxJp6lyi9RO3rYAc16VpkHOrGA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1717628204; bh=/1IcETi4I+UNR4H8GehTsT+0Xan7bgraJTDP057MiA+=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=i9G6mGj4F0GkV7IKGUtsbql6ZVGfdtI93CXPl8bmKHtamgVdTLxfEqFGIIF8FWNfn+OxPHM60F2VCDwWkP+ua0byayXZLq/gqdA3IMf+WrriW/MOdPfvDfrJMmO5RdsaMuycg1UemM5apTv3y+d9Fw15LhftrujkWmVFMngfWQYWvYgR4ebh+ddfhRsHxmMGKnBaFDxWdApUHuRiRer3jsCsn7oOQOm2ZSyYb95NR2p4U0Q0S7Oqvz6zu0+jvoi4BZ9gzhSuLluGhwbDjM6trhr/PA1a6Vym1xUnfaYMWgI/xVY2RC59mPCrfjH58aKzi9iyqwZFmtuW0kuZ1SbIuw== X-YMail-OSG: 1kFSkoAVM1l6kaHtG3_i4cieq8_PH2fIBpHNoRzmn54Fo0nNGb3V0aSs1HGbDHd OCOkDjUxiku6esgRKYGmDni1TcPrR33.dWo7_xzv2.BWguPKqAUUsWXyX.3HqkEdRhGstGvjwrJj shxEwM2ADmdtM4EWtM0XCkbdjYwPsNH5eyxQahJibeD4qqfPCTWUm24EM_GxnULbPrgJGSkSmjkr epMeaB2NMQ03gBkymYj5MjgNHUXDEKSBoBDS6oIywKwKjicxbbaFDxOL4BrJPaDTBUhAHlo.NUvt jqKr9yfekf1alJwQYIE2a0laKHO11eq6lHtHEYlHaLoKfj3NfLu1GPzhzabPvlIABf2A1SP5osaV Di7kFbxFl2H9tMCc7O9KFyvL4hP0JeMkawtJ9if5YJj6qBkOkmZO7C2mmM4G8wuwn24IhF8TKQdG wAO7fICcSgzNN9LUGa.JVGSjETAMjCeJFXWmc05QD_C3UEa98897fsyywQC5PkSmQLhLQSR1glWo a64Zm2zgRrsPdLuNEvEDJk.j_S1sGpfdpPyilKi..5pQNteR58XFPjJRpOkJRppWnKfbJKlJ5kkW Agqrphv.PJwYUHzm.N1FUUUld2Wh7NYfbWa.ACrIZKX38diTkk3aucqC2n1wFDlP6kvem1gOrj0J lB6kpW.COOu3RtOIEVN_tHK8r_.0_xmu6dw0ZL0llvHftm0_yGB0Nqcg9a8CXFDPqSlihzPetC0A WjHpHICbCQ_4bMLGfA7gLsIEqDrfe0yzqiLnamNm7B0PZ_AlWq6j0Yauks0UMRBHVlmIf8b3Wqjk mEFFblSVePpUCD4snYJw.AirQJ1B8PUptfghYB.C7H8c8wWINcbzcEfAB6qsQIYXh2NK_f1hzWbc IIMx5URfUteCXxXg05PqXrmvLONKiV44mERwyyUB3wyRc3Oez1oCQoaRCWgCFrG1UI_FeUpgk2aK yEU7lY2UsnjoXEheLneQqNtjmnrf2U2CnJeIwTCCwWITw8hUzHMPazfDePrKhPs3Q.V5.ikD_V6y VVnYsr1XT7N7sYg.STD6pOS.3J5DjsSsik.5FgjiH8k4d.jSEL1hP_7ry5erMzKJ.JsL8KE8GLsV VEdykImOxRf5VZm7LYPcLwt4aawqaw5ejlrSX6k02ag7At29x9nr18HWqZ8FJMwsSXxpHOv1rFiq Qs2wY4nhrTS9yy6bbCPsJn_VCOQEzPdq9B8.P_.Y8Dh8qIByy1XX67e4Ah5FZYwrfzNYgRJUKYh6 Pd0qqNhCx9mmb8SjX3SqVCNHXy.Z8zsrscWp6UxT3FZ794hjNpLOXPsTir8KlXPkHm05H_8FAwtX AX0FiFPSuIZTUieTtOqu4UPHWja06fqa4pqpkrZ9GJJL79tWllEzvj_0R4r8mFVJ.1LA0wBBpTZf PAgH3uf4CRf_3d2v735sXiaq5OQFzlxTqCrvIIFHO8ClpQudX.EzCo.Qd2T.9l1ZuSB5IZG5cY6K Upc3M9tCzH8uGSnYNRE4s.RPi3nr8tjSpR58p47a8xOFeErIbrNC9.3hm7Fp0olC1EmYE__QiEbJ SsDLGYz0S5hbxiViNG8yzpafoT0.d8jpfdY6EgtKncLazkvkHjsREQu6fvaUvXfYMdoDdSst2fOz C2jLm8u4JqStx5IW_UN7W_KlGht9RfQvphfyzwjpnIDU.x8OGCYEfPjqX.JJOWB9VDWRi528APhl Vzuz.Dq50g6jsdWl9t.t.P1cxE38TN6Hwnl5IFhD8APmsSCBJ7Dld8RtlHzNorPt5wOznpSF4EQh SI9DVkbFPapEbNeOBP.93EEWstozkhZl3SjETnlC0hMGzcztNx776a95AjcaOLjh5A8mbpZMhigm 4lt6R5aB0Pr3LZSzjxwhiu3ZsqUci8d29XNg4hamF1d2_s0LYk5C1TiIMv00.siDN_xAo.J5N0hQ LO2J8.xg1tjJSqyA8Ilf2UomQuCiFKbQ.QG7Tu2prIV38Wzq.adAx0Bo0EcQ2VZZCX.hmTnxMv4H VfgCK5JF4u0EEtpRufZddwZS3jLJ8mt4mcrSmusJm9xhGptHwoLWGqkllK.UVKk.U4bO2C8W4Gyc ZpdruQ6Jo2VjTrNOVkTuRiVChEdd4BhIXbW7B0N6ouP8l8gQ4pdT43mEo8L0wxJooxdd4zs5avjh 2IlLH9WDEkV3mpNkf.8PGEjA9QfW_EgI1OgfZFFpQZW8r0k8S04R8c9kLgawru0OeTkIhvZ9P X-Sonic-MF: <spacibba@HIDDEN> X-Sonic-ID: 01afe841-e40d-40c4-824f-638d4b1932c6 Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.bf2.yahoo.com with HTTP; Wed, 5 Jun 2024 22:56:44 +0000 Received: by hermes--production-ir2-7b99fc9bb6-hcsdk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b0d243fd84e18f28c9d17fda4f6880e1; Wed, 05 Jun 2024 22:56:39 +0000 (UTC) Date: Thu, 6 Jun 2024 00:56:38 +0200 From: Ergus <spacibba@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex Message-ID: <87ikyn578o.fsf@HIDDEN> References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN> <F834A272-58A5-470E-8369-D0C158461EA5@HIDDEN> <86sexukpuh.fsf@HIDDEN> <8BC5E59B-63B1-4784-9454-51925E9DBCFC@HIDDEN> <86ikyqkmuo.fsf@HIDDEN> <09473128-D0DB-442C-8404-EE58A18F5A5B@HIDDEN> <CADwFkmn12kDCtFD3ZakVe2g3WKPPr2wjyobP+2nPmTi1B46=ew@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <CADwFkmn12kDCtFD3ZakVe2g3WKPPr2wjyobP+2nPmTi1B46=ew@HIDDEN> X-Mailer: WebService/1.1.22407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 1188 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70794 Cc: 70794 <at> debbugs.gnu.org, Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On Tue, Jun 04, 2024 at 06:06:16PM GMT, Stefan Kangas wrote: >Mattias Engdeg�rd <mattias.engdegard@HIDDEN> writes: > >> Even with the obvious fixes, the pattern would still be incomplete and not even match parts of the examples given. I'm happy to work with Rust users or package maintainers to work out details but I don't want to do a rush job now, nor delay Emacs 30. > >BTW, shouldn't stuff like this be happier if it was in something like >`rust-mode`? > >It seems like the maintainers of major modes are in a better position to >add and maintain support for the compilers and tools of their respective >languages than we are. Hi Stefan: Actually I opened the initial issue because there is a rust-ts-mode now in vanilla and in my opinion it is a bit incoherent to have a native mode to support rust, but don't support compiling rust. Specially considering that adding such support seems extremely simple, it only requires to improve the regex to be a bit more strict. And the one I provided is buggy mainly due to the "too free" wildcard I used to match anything including the new line... Just improving the [^\0]+?--> in the regex; I thing everything will work properly.
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.Received: (at 70794) by debbugs.gnu.org; 4 Jun 2024 22:10:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 04 18:10:20 2024 Received: from localhost ([127.0.0.1]:55509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sEcMG-00043U-Dn for submit <at> debbugs.gnu.org; Tue, 04 Jun 2024 18:10:20 -0400 Received: from mail-lj1-f177.google.com ([209.85.208.177]:47294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1sEcJd-0003wA-2t for 70794 <at> debbugs.gnu.org; Tue, 04 Jun 2024 18:07:38 -0400 Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2eabd22d404so16418561fa.2 for <70794 <at> debbugs.gnu.org>; Tue, 04 Jun 2024 15:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717538777; x=1718143577; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=fY9hqfd+WDWvzt1iF3ByqXfshbnrZ7voTbNKzZDxQQI=; b=ZFdRu/HxJYy+oVkRa+PTHqbolnsSEytVkoLbj7jr/5y5d/WBymmHlJDbcv48unK1Dp wQ8HdYf3fHk00Nttxgcnantv0uguTkFYMqj0K9u097APaJ+rb77k9VUrvn0v+hSVGIcR FlSqX1AvqLE+5djzRbLUyk++jWUlvXyFHeutpKCyNc3WbhNLwxOqbfk1SYP6OD8fKLvB hl4apiTiUanyoyRwvCUReia2ACQaKZFfRmCARwZA+M+r3Qf8xa1i2PsyJFzRlbqab+Oa +Bsdv286hZa6M+u38Vm8M4nTwcPPirxOxAKTr/13rX8hm5hkiWuy9M3qHGquje9ZW0z8 R44g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717538777; x=1718143577; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fY9hqfd+WDWvzt1iF3ByqXfshbnrZ7voTbNKzZDxQQI=; b=TAQXrmgFJFvB/ltTDxn2hKfEu1vIot0MnpWprS3Mg6vaPDn2Xdxp0t6rUWXnRcpRDy opuSzRB/I6dbJcQ9F3ZNd2RzKaY4Za06U/Nhz1+HwAlzpEW7w+Jvq3jQsJRx+GNbBr0S 2LvNtni0lETFjhvmqkb+tkU0/kXPkVQMDad95L6IEvKOJrlj4R/CFzzxMR2ESKDaxVxQ GfRRBVPavinVh82cfJ8ynwuOA1TanZFddJo2H6+QQvn9DGiZqjnBRCIyGID5q6WpGoDk 1Br4Wxh50eLcExiwJm8szeKbpF/sYwSpCfo/ZwnhUTt1tMsuCeyeUZc6OhQi+6ZCPWnL Z/7w== X-Gm-Message-State: AOJu0YyprD6bAN7dTyRS+gP/TIYV05PaSNpWgkqkllrE1lThLgS0w0TS 0qR4N913ARk9y4Qm8pfKJkQrU2FrpaCBRLx2bQgYv9dmEEfJMpwzEMy2F6wp9JQUMKOOuHqxsF7 AuJnIF//aQmdVZYmW89jejb+sbjQ= X-Google-Smtp-Source: AGHT+IFf8XeVNX60Ih1BxUUX7ns25GNqIHdl9diGw9SlQEQW9NwlWRUSCXdbMSg1KkLehKHvHfzPj0uTycHGGUuHEA0= X-Received: by 2002:a2e:321a:0:b0:2e0:37be:b70f with SMTP id 38308e7fff4ca-2eac79e9629mr2499421fa.26.1717538777129; Tue, 04 Jun 2024 15:06:17 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 4 Jun 2024 18:06:16 -0400 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <09473128-D0DB-442C-8404-EE58A18F5A5B@HIDDEN> References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN> <F834A272-58A5-470E-8369-D0C158461EA5@HIDDEN> <86sexukpuh.fsf@HIDDEN> <8BC5E59B-63B1-4784-9454-51925E9DBCFC@HIDDEN> <86ikyqkmuo.fsf@HIDDEN> <09473128-D0DB-442C-8404-EE58A18F5A5B@HIDDEN> MIME-Version: 1.0 Date: Tue, 4 Jun 2024 18:06:16 -0400 Message-ID: <CADwFkmn12kDCtFD3ZakVe2g3WKPPr2wjyobP+2nPmTi1B46=ew@HIDDEN> Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70794 Cc: 70794 <at> debbugs.gnu.org, spacibba@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd <mattias.engdegard@HIDDEN> writes: > Even with the obvious fixes, the pattern would still be incomplete and no= t even match parts of the examples given. I'm happy to work with Rust users= or package maintainers to work out details but I don't want to do a rush j= ob now, nor delay Emacs 30. BTW, shouldn't stuff like this be happier if it was in something like `rust-mode`? It seems like the maintainers of major modes are in a better position to add and maintain support for the compilers and tools of their respective languages than we are.
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.Received: (at 70794) by debbugs.gnu.org; 4 Jun 2024 14:34:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 04 10:34:04 2024 Received: from localhost ([127.0.0.1]:56194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sEVEh-0008Fp-TF for submit <at> debbugs.gnu.org; Tue, 04 Jun 2024 10:34:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sEVEf-0008FG-Q1 for 70794 <at> debbugs.gnu.org; Tue, 04 Jun 2024 10:34:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sEVEM-00047h-TY; Tue, 04 Jun 2024 10:33:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=9lwmBb/Q7vdJJke9H5A/Va2sjQcxV6wBuW+ZFS3XjwQ=; b=WEyNpt06vSPn4vLQzjGe mweMpAl8FQv0KHZoyILf6xJMeLn5tKD+EVt/ZG2e7ycXaXpy9ZD0lOhVnvbESZ3JLo4jFAU0qqPXK UNCzTZOsuKw5cAhZOi/wJJhJ55nxT+BjnCbgVxOPucxd7lVKC44AjckADbkruBtsyPwGbHPxh1WFG VI168G1kMkPCQTklanU+GTPxP3cav+fPQUKJx0zQKBTL+eTVzlP51idnMMG4dzzoWjCMvLoKF+n8C H3AJWI4vIWJmSKqK+Zpr8p+ktzTeYroc8L4LEN1Bf+m5BatBwL2H9Cm25ja8YJp0Qnl3SlkKzKQdp nHPELhhXrQl3bw==; Date: Tue, 04 Jun 2024 17:33:19 +0300 Message-Id: <865xuolqvk.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Ergus <spacibba@HIDDEN> In-Reply-To: <tbulecvelog66a2ipjobhij3iprg5ncs4au254w4vo7kpyzmpr@iokcybvl6oln> (message from Ergus on Tue, 4 Jun 2024 00:36:17 +0200) Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN> <F834A272-58A5-470E-8369-D0C158461EA5@HIDDEN> <86sexukpuh.fsf@HIDDEN> <8BC5E59B-63B1-4784-9454-51925E9DBCFC@HIDDEN> <tbulecvelog66a2ipjobhij3iprg5ncs4au254w4vo7kpyzmpr@iokcybvl6oln> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70794 Cc: 70794 <at> debbugs.gnu.org, mattias.engdegard@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Tue, 4 Jun 2024 00:36:17 +0200 > From: Ergus <spacibba@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, 70794 <at> debbugs.gnu.org > > On Mon, Jun 03, 2024 at 06:22:48PM GMT, Mattias Engdeg�rd wrote: > >3 juni 2024 kl. 17.28 skrev Eli Zaretskii <eliz@HIDDEN>: > > > >> The order of the patterns in the alist is a complete mystery to me. I > >> tried to figure it out, but eventually gave up. A remark won't cut > >> it, I think: we need a detailed description of the principles, > >> considerations, and the way of testing the results after adding a new > >> pattern. > > > >Yes, it's really not ideal. There are lots of legacy entries which are > >hardly ever used and just shouldn't be there, or at least not enabled > >by default. And as you say, the order is chaotic, difficult to > >understand, and probably not the best. > > > About this, I may say that IMO the best approach is to use lazy insertion > with-eval-after-load. That's orthogonal, and I'm not sure I agree with you. In any case, it only lowers the probability of clashes, but doesn't resolve them. Moreover, it makes the problems harder to reproduce (because now they will depend on the order of previous commands).
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.
Received: (at 70794) by debbugs.gnu.org; 3 Jun 2024 22:36:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 03 18:36:43 2024
Received: from localhost ([127.0.0.1]:55940 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sEGIE-0005YY-UA
for submit <at> debbugs.gnu.org; Mon, 03 Jun 2024 18:36:43 -0400
Received: from sonic316-12.consmr.mail.bf2.yahoo.com ([74.6.130.122]:44614)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <spacibba@HIDDEN>) id 1sEGID-0005YM-8D
for 70794 <at> debbugs.gnu.org; Mon, 03 Jun 2024 18:36:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048;
t=1717454182; bh=G5VK1YL1HBtaxeO/KnDV7h3AB96X8C5cQQErn96g8BM=;
h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To;
b=BpcovCh2MZTwwflLCwACigth1dgMmdNmr3YtZygkaxBm5jtOWcCDk6OVTUrcq10iAE8KAlhudCktxWHn+xTZd61Zk4xTwsfBC83JBZjsZ0cs5WrX3Ld4M9yYPxfqgzdHxK8ENCX3cN72GtE1qz2TGu9fIrBHfiNE3z4AqYnbZR9lK0emxMUf2ZKdLcGlLWPKXOiwqqHvtVlY54ANZv2uruD0PmfKhobHUhFw4mSWWTVS04+EI+5btkM2TSDf0j3do0JTgS1DXFC4G6fefjBFN8JWNWfMAN9WitgnWHb/KaQpRyMBXPQ3JTrumWGHT+QOoVOZcuGBbhbu0StYgUv9BA==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
t=1717454182; bh=B7FFKACMV6F8tMChlgWrJl5NVeWYRI6jzhcEUHTKkTC=;
h=X-Sonic-MF:Date:From:To:Subject:From:Subject;
b=scFyRVu9UaL9hnwGXPTm+SDcFjT5EjfNcGcnoSPZac7kENW6APDsX4dY+SV/wccDUG0ERaEmRCcImr8RB0PV6DSnBwLpL0X0APiqHhxbQ8+SjJtI612Yf/VYr6hmnRhTYHTjLGnhEH4FyPK8HssiEBZ5VP2PkuAH2mSY2UNR8iVnaXBWx+O14XY4vGHrXkNX+BGakSB5159GU9O1O8f8jHFaaIbTxDeWPTttpdtvbagYaWQUxuHWgIzYH9D4+Wq0cE0yHEKtjTIaQtx1swjI1EogDi8/+r3+ScGalDwEU5ryxxopvuCyvdCki50NzgnYVEjVchbr+ztckL0/Iq5SmA==
X-YMail-OSG: DKA0eEgVM1nsU4VtQi3L_3yKEmWDyvglNSULlgfEf8RC2PkobrFoPROxezKNjwO
sUPVhOiS.fYA4rz_07hI5paA5t2R_12l9JSK5bx9CrzPKMPxxw7nr3C2NwcQK_TZutaFupto_Plg
_jywYsTAJsqfUKCOOk9tnTIxD.Pz3WPWyH_BBHL9N_knoDCHVMOXV0gC4ZKFXuk6WlGXVZBPo4V.
.X2JoEKbxKb78RRV_dDFw2w_NyHAQkWTw0.XXehpEHDTrpvfFi_cWwN7EBQODt9loP4R_vR9Se6d
KPyxwaa8AZx0sn0Af9tsUkSxOSnRZtz5B3ZWw3y1XHYR.qj6ueJ9O3DUi99CaUqT.okLT95GxgQP
itUju9uNdkx.iebclHHbXfhjdAxG9Ocz5xbeypwaY8gcUvTx00lxZ_MOU_VKwtg.nqFDcPPeCHHc
EmeKje7OmkiKGS4VFK1oPj23nP6R8v.GS23CfdW2vBHrq1U8XJGPwxAqyVTkBLHsVnPwDTb2EPoY
wjEcF3_Fba8zg3xY_ZPj_Fz53zdUE.iXMQOvpCsmnBhl6CR4pILIy4RXuVgbdGH30Q7oQd3sdfVC
dB.6pRpyxVvcUy6eLDNP.pRcXpipNhPxSGlCV35UMT0BxRTSmXwdQRX22x4J9CQTEGofls0dOS.z
8LyBINlOginxOXX0.F3yrButwAl3U68DUiwRc_YUCjnsNTHskhUZ8S38TUoVtcj8fHOEZPwK9_CH
g8_KGzcg_V.ImZ16BATl8MAjOfmK9QoqJyUSwAJhOx5eV9F7IxcFvxQ4RTW7Tt76Bxvj7wBXuQCk
njUJwvII8d5TqdO_o6NXsQNpJ3rSwMPm.yuo0D6atCSpJrHCBw20nsdX0hjqZ6dqe2_wKRfGbv2J
GIJ58MonaIbLeC87fvGRPXC8fjNcofLG7nZ4USNJYTeXsqGgrclrz6T5ny6jvg9UN0Dthnc_XaEW
u.6fRZ.xR0XB1S5OvmGZDhje043Ff4RonQbUBV4zP.MzXxPCZMuL7KWaslcQldMymDXzGdxWCNOQ
7r_0LWic9bkfrSjrTYStymlJmUbbt6b.2_d4aOj6V69R4_HX.hTLytdJrleDMZgJaJ70xOhc27Ml
HZqeeJtV3hbZ5DVMJyyc0SjcXXCby_gftSYdEYdz2MHapF5obh.uAHZG1wbD9i1_QdY8hVMr9qxS
kUs2yxekTPp4twrH_cwh7wuggiaqd5atg6O1wPdF292mJ5gyeDaUR8Kq__5eKrCk4vG93IxMx6Q5
jNB8OUajUtqtW_4qxPgFrHVcR2c6yZdPavhJ7GQq5U1fbX_yWanSHj93IkPjcEaF4fNMhK2gFE61
mqDvogw7G6aTesYrSxTzcFSIvXyyUTtYPsic0Im0fohRtmyhG.IvZkJua2GBpt26I_Au2ZbaETYp
.xNJaOHwKDA_Fo2uRfr7S0EQ5MriOL.u3JAhWM8HqCQYtNZChSkVe7hitxqoK4BxLTfnffo1UdjD
F5vd1gJLdLt.SApo5VLwJNb0qFVqM_9KJBj7FVl2IuB7wsAI3uGZz0VuU7ifxv.Z0SXpOd8kjB3R
rvwKnRcH.nDSqKkT8sLw5oLrw7lUa4Kk9PWuUL5fuAUjJg6HMagcJoRsItrpRWSlXlQsEJoF98kJ
2hexn6Q7EArs6prF2qvkvptse91pShP.GO5dNJQsRuNZjCUTNLR6Im21rNb8BiGRVstLx3NBXCG_
DjLP15Xf8ck6cUgv_eRpnITHOxqJIMGvoO9mke99qdusdGeSrEIrGgs2eYVCdezycC8MoK9RychO
NswvMA9NTXe2m4qxGBgCbTVA6aJkt7DHGt.XQPbkRqUa._Y9TO_sobLHdDs2YTju9IauFZ4JFEe3
ykJQpUvQiP5oGkfP8g8kho5D7CaCp9KfBqmWa8m1okLoMonfaBMj5EWO_Ks7inkR5RAI5lzpNDeN
38O56M2w7T5hcLBWt9HN87UiEcb0sGG2B4CQNZD.de_HlXLnoukYhcgn_8Q5Cs3uaA9A17TTIEQT
84r3GV_kXqUdQCjt9lBRmLxv6kyWZaLybbfg4T0bTqlpnOzZt8hCr1ZiZ0uHvcet6uG_RKamcHt2
oMD.Fpn22v1eUKX5Pi7UHxy8tojSVB9o5VGlEdVw8FwCjR..kMlJMyExh6V.A5jIqiLjeQBEab.4
.4g9AoN2U1NyZDtHHtxHJztzz9mdsyiXE49VuOzC8ZazQcsWau8hqqT6Elok1_.NTOnKM.uVAZYr
gPKk-
X-Sonic-MF: <spacibba@HIDDEN>
X-Sonic-ID: a151bf5f-98e4-430b-b672-857fcd3653e7
Received: from sonic.gate.mail.ne1.yahoo.com by
sonic316.consmr.mail.bf2.yahoo.com with HTTP; Mon, 3 Jun 2024 22:36:22 +0000
Received: by hermes--production-ir2-7b99fc9bb6-24wkz (Yahoo Inc. Hermes SMTP
Server) with ESMTPA ID b3ccbed966a62edff6a10c71e2d11fd3;
Mon, 03 Jun 2024 22:36:19 +0000 (UTC)
Date: Tue, 4 Jun 2024 00:36:17 +0200
From: Ergus <spacibba@HIDDEN>
To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN>
Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex
Message-ID: <tbulecvelog66a2ipjobhij3iprg5ncs4au254w4vo7kpyzmpr@iokcybvl6oln>
References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN>
<F834A272-58A5-470E-8369-D0C158461EA5@HIDDEN>
<86sexukpuh.fsf@HIDDEN>
<8BC5E59B-63B1-4784-9454-51925E9DBCFC@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8BC5E59B-63B1-4784-9454-51925E9DBCFC@HIDDEN>
X-Mailer: WebService/1.1.22407
mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 2751
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 70794
Cc: 70794 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On Mon, Jun 03, 2024 at 06:22:48PM GMT, Mattias Engdeg�rd wrote:
>3 juni 2024 kl. 17.28 skrev Eli Zaretskii <eliz@HIDDEN>:
>
>> The order of the patterns in the alist is a complete mystery to me. I
>> tried to figure it out, but eventually gave up. A remark won't cut
>> it, I think: we need a detailed description of the principles,
>> considerations, and the way of testing the results after adding a new
>> pattern.
>
>Yes, it's really not ideal. There are lots of legacy entries which are
>hardly ever used and just shouldn't be there, or at least not enabled
>by default. And as you say, the order is chaotic, difficult to
>understand, and probably not the best.
>
About this, I may say that IMO the best approach is to use lazy insertion
with-eval-after-load.
For example, as I mentioned when I opened the issue: I have this in my
init file:
```
(with-eval-after-load 'rust-ts-mode
(with-eval-after-load 'compile
(add-to-list
'compilation-error-regexp-alist-alist
`(cargo
"^\\(?:\\(?4:error\\)\\|\\(?5:warning\\)\\)\\(?:\\[.+\\]\\)?:[^\0]+?--> \\(?1:[^:]+\\):\\(?2:[[:digit:]]+\\):\\(?3:[[:digit:]]+\\)"
1 2 3 (5)
nil
(5 compilation-warning-face)
(4 compilation-error-face)))
(add-to-list 'compilation-error-regexp-alist 'cargo)))
```
I use something similar for other build tools (like msbuild or
incredibuild) in order to avoid performance impact.
I also apply some tricks to reduce the compilation-error-regexp-alist
when I know that only one pattern may apply in my cases. It may be
amazing if we could simplify such customizations/optimizations somehow...
>There is also insufficient testing of cross-pattern interference which
>isn't easy or cheap to do if we are serious about it.
>
>The customisation interface is also not helping very much, and the
>whole mechanism is not very modular.
>
>>> In fact the added pattern has visibly wrecked the display of etc/compilation.txt so I'm taking the slightly drastic step of reverting it.
>>
>> That succeeded in my testing, so I wonder why it doesn't work for you.
>
>My guess it is because of the nondeterministic parsing by
>compilation-mode; it seems to depend on the order of fontification, and
>possibly user settings (faces maybe). I can reproduce it reliably here,
>though.
>
>Anyway, the syndrome was just a consequence of the previous
>observations about the (far too unrestrained) regexp, so there is no
>real mystery.
>
>> If you revert it, please fix this ASAP and install the results, since
>> I'd like to have this on the emacs-20 branch, which will be cut
>> soon-ish.
>
>Personally I strongly prefer no rule to a broken one, or even to
>Mattias's-best-guess-of-what-a-correct-rule-might-look-like.
>
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.Received: (at 70794) by debbugs.gnu.org; 3 Jun 2024 17:10:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 03 13:10:15 2024 Received: from localhost ([127.0.0.1]:51015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sEBCI-0004S3-2t for submit <at> debbugs.gnu.org; Mon, 03 Jun 2024 13:10:15 -0400 Received: from mail-lj1-f177.google.com ([209.85.208.177]:60772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1sEB33-0003xP-2d for 70794 <at> debbugs.gnu.org; Mon, 03 Jun 2024 13:00:41 -0400 Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2eaa80cb573so28339111fa.1 for <70794 <at> debbugs.gnu.org>; Mon, 03 Jun 2024 10:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717433962; x=1718038762; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=qza8sQNbXU394QUMgVx9ENE7/tltaSnYz01AV15pWf0=; b=EB9fYAA04xpQnd6JSzHM8gYMIZDRCg3G+3ulb9hnDBH8T7FxOtBso0+NnPno2mXxia 70TmUIL0VUSTM3l8IIh6mC/u6yfXI/Yvs230pwLxhvLw1vkaQ03pNETagoMmWge1ytR1 AG5Dl9eC4tQWqj8HpKf4dOnTKfPIzlI8GxWp8LVllCce9auFylcJPNeZtq7bH1Q7Ilje zJRYeRFOHjqyUuDU9ucloEsowQCcuPzwq4I6kQ37KjA8qpvqQXbZJjgfsMgSfal05CTi 9oiVJ3efSnffPHCDogD3lpmFI0875hC5l99G+Ik4kCfKTKEZdf9hzecuc04BIUcuPWfs uPbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717433962; x=1718038762; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qza8sQNbXU394QUMgVx9ENE7/tltaSnYz01AV15pWf0=; b=QKKz0BqnjeQJOa4rQ6FvmsUfcBe9MIgrqATQ5dmyaLJ5odSu7jyF8IL396YBfZniPz b5PmMcFbmuSttjxBJeQIX1RFLDgBwpqPaL7KsylQERx8cKRL9D0bgbytHYGX6TzheFbT gVReoNpizCPE2aSG89FB/J+LCozGjVePfwCy9yFR16FC1ejO5OxdZ3yc5/b6f+JIFrU7 t1dPkScW50IHbNNHjKOTnKK/N4kIWcqV0xXJ6JjYM9NyDmyqhAvLqqJdwbFWUyg2YMgV lv1iwoRqWfrHOAkc8p+1FXHmibPuoamkVirKzaBPoG6HLCWGGBdBX9lwxx0+2QT11MIW kPvg== X-Forwarded-Encrypted: i=1; AJvYcCWdzYYfgWLLek7cCeKNjvupYi0epvXXDei58HZ7mhXxK/vbV8T8arxYst58Nsa55+jMOLOFDJkFBf64GF06jmq6+73yTOs= X-Gm-Message-State: AOJu0YwBewscPUDTdHk2HI9SpcP4ved4cTRkNNSIPs0stw1ZwdJP3cWZ OZzNWMFgAqLpPG/Ie7BXZ18Z4E6wfW7ykVkIPDlDUs/Qc/dedkvl X-Google-Smtp-Source: AGHT+IEYdPhdyD9Wvbv6k77NSSuC6fkGgP/BUz+pqDbiKCR0eG5w9eGShjo+5Yg17gcLnvTB7b2hTw== X-Received: by 2002:a2e:9ac2:0:b0:2d8:b2e:7bf3 with SMTP id 38308e7fff4ca-2ea94f58e4fmr59025861fa.0.1717433961901; Mon, 03 Jun 2024 09:59:21 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2eab1e6c4d6sm3084401fa.64.2024.06.03.09.59.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2024 09:59:21 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <86ikyqkmuo.fsf@HIDDEN> Date: Mon, 3 Jun 2024 18:59:20 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <09473128-D0DB-442C-8404-EE58A18F5A5B@HIDDEN> References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN> <F834A272-58A5-470E-8369-D0C158461EA5@HIDDEN> <86sexukpuh.fsf@HIDDEN> <8BC5E59B-63B1-4784-9454-51925E9DBCFC@HIDDEN> <86ikyqkmuo.fsf@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70794 Cc: 70794 <at> debbugs.gnu.org, spacibba@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 3 juni 2024 kl. 18.33 skrev Eli Zaretskii <eliz@HIDDEN>: > Fine by me (I don't use Rust), but is the rule really broken? What > happens if you move it to the end? It is indeed broken as written because it would match anything starting = with 'warning:' to something that looks like an arrow further down the = log which could be an unrelated message a megabyte away. I could try to slap together a guess at what a better one would be but = then again, I wouldn't use it myself (rarely use Rust and when I do it's = one of those external packages which have their own patterns and more = importantly active maintainers). Furthermore I don't have the time to go = poking around in the rustc (or cargo?) source code to see what the = message-emitting parts look like, which is very useful when adding = patterns. Even with the obvious fixes, the pattern would still be incomplete and = not even match parts of the examples given. I'm happy to work with Rust = users or package maintainers to work out details but I don't want to do = a rush job now, nor delay Emacs 30.
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.Received: (at 70794) by debbugs.gnu.org; 3 Jun 2024 16:56:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 03 12:56:05 2024 Received: from localhost ([127.0.0.1]:49819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sEAya-0003gV-L2 for submit <at> debbugs.gnu.org; Mon, 03 Jun 2024 12:56:05 -0400 Received: from mail-ed1-f45.google.com ([209.85.208.45]:43519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1sEAyY-0003fM-PJ for 70794 <at> debbugs.gnu.org; Mon, 03 Jun 2024 12:56:03 -0400 Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-57a677d3d79so1723551a12.1 for <70794 <at> debbugs.gnu.org>; Mon, 03 Jun 2024 09:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717433684; x=1718038484; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=PQEvcqnkHyBPughOYsSKldLWowBYY4R5MjzXEPs9Av4=; b=OL/3o2m5gNEAX9dV2x0TIPDY2I3yFqji6W08NsDNWEJ7FbQvQ4+k+4clLGlDemuK2M bUCqQtCHXtKDnodCxXCS54c5JNGCanUWWa+HrIwSj1hIYXJHFm87RlZWv3tzlgS2HjzG Akr+hxyHOkAVUJshq78ULWs1pNgLGSwUoVMw/mQkl4U1OITZpl6TMq17+Y+s92uQrpQF El+M5VZhYOdDbzgD+1U4QuAWZLYoaNH2aABkPqP+4gf/dQBXZzvnLHgbzAy+uTbvPEuy QDtriNDnplQaTAf47ygkX59CdX6gcYwAZnNDFrnv8hq7w7pazUMySkQF3GA3tvhUUhlT xe9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717433684; x=1718038484; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PQEvcqnkHyBPughOYsSKldLWowBYY4R5MjzXEPs9Av4=; b=WQAEoPMuFGDBecw7Apk+qugkdBJMujfqOglSpmtdOSf7XRI1vZnpkP4EGs5qdwyPQ3 baQYhIMabIhd4gQNBDq7lLXo/j6t+dKb3oEWtLpFErKd9tai8SEa7agIoYk1AcFc8WrZ U/KWCFIo6peHXRHC6UXcdZeLAM7861sonWaUW8k/9um+nGUdffWOdmYUebHv/ZmdjvDs 4lbkes4YxsbXc0gIKn2hqBqmx0FxUmGA0YRNDHoR0YUPMDkIiPXFRwhDoyFhM6QWofxi KV2DXAeTe/xIL1Lb7FUSmHNAydwi4wTph2G/3jcHSCFnNt8zil9a2dDRNT8fFsetydav 6JbA== X-Forwarded-Encrypted: i=1; AJvYcCUfvXzxd7eK0wGyKhVULzIgBvnUvV5x58uYow1IhdMidK3gn6eU+lshkf+GCB4w9DdeF4aQaEpf/XrFPtWwqStMw/EzbCM= X-Gm-Message-State: AOJu0YyIQlkmAvXx6Pk+oOgArfrhqGwWzfNbLxGGcgB71h4NrfodkRZi qHIIQKkVLVDpHdt05QlZderHtxqecjeGRq20itBjimUIAX8ajaF+gyDEcg== X-Google-Smtp-Source: AGHT+IHgdZSseErOJKAm3JVP2lDCuaDIPGnDGVqtAwc/iIGNnYRnQPV9TVjSuyTWAKgE1r7mwi/0OQ== X-Received: by 2002:ac2:5f83:0:b0:52b:8d0f:93a3 with SMTP id 2adb3069b0e04-52ba2290ce3mr34790e87.29.1717431769674; Mon, 03 Jun 2024 09:22:49 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52b9918fa69sm443872e87.261.2024.06.03.09.22.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2024 09:22:49 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <86sexukpuh.fsf@HIDDEN> Date: Mon, 3 Jun 2024 18:22:48 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <8BC5E59B-63B1-4784-9454-51925E9DBCFC@HIDDEN> References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN> <F834A272-58A5-470E-8369-D0C158461EA5@HIDDEN> <86sexukpuh.fsf@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70794 Cc: 70794 <at> debbugs.gnu.org, spacibba@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 3 juni 2024 kl. 17.28 skrev Eli Zaretskii <eliz@HIDDEN>: > The order of the patterns in the alist is a complete mystery to me. I > tried to figure it out, but eventually gave up. A remark won't cut > it, I think: we need a detailed description of the principles, > considerations, and the way of testing the results after adding a new > pattern. Yes, it's really not ideal. There are lots of legacy entries which are = hardly ever used and just shouldn't be there, or at least not enabled by = default. And as you say, the order is chaotic, difficult to understand, = and probably not the best. There is also insufficient testing of cross-pattern interference which = isn't easy or cheap to do if we are serious about it. The customisation interface is also not helping very much, and the whole = mechanism is not very modular. >> In fact the added pattern has visibly wrecked the display of = etc/compilation.txt so I'm taking the slightly drastic step of reverting = it. >=20 > That succeeded in my testing, so I wonder why it doesn't work for you. My guess it is because of the nondeterministic parsing by = compilation-mode; it seems to depend on the order of fontification, and = possibly user settings (faces maybe). I can reproduce it reliably here, = though. Anyway, the syndrome was just a consequence of the previous observations = about the (far too unrestrained) regexp, so there is no real mystery. > If you revert it, please fix this ASAP and install the results, since > I'd like to have this on the emacs-20 branch, which will be cut > soon-ish. Personally I strongly prefer no rule to a broken one, or even to = Mattias's-best-guess-of-what-a-correct-rule-might-look-like.
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.Received: (at 70794) by debbugs.gnu.org; 3 Jun 2024 16:38:29 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 03 12:38:28 2024 Received: from localhost ([127.0.0.1]:48490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sEAhY-0002qL-96 for submit <at> debbugs.gnu.org; Mon, 03 Jun 2024 12:38:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sEAhW-0002pR-88 for 70794 <at> debbugs.gnu.org; Mon, 03 Jun 2024 12:38:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sEAcd-0007Sc-5H; Mon, 03 Jun 2024 12:33:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=J9f1NSFYWO4PCmz4ndEQjBP0pwngqey1pd+lV+4FIxk=; b=EaBLcgKLMAphakDjZB2o 3v5UcaD4iNrRcP/IsfASQbQW45b4iW9epCp34WpkApsuZNWgplzHNcQbotZZDmvA/w4/AgYyezoXj yxUMj4I2cp5pk2Y8MoufnyhGfvBBo41IzWhyoeLxNiiY7LS9m6/OiaI6Z+sX0RcaPZ/Wr3yHEkzdV 8Fl/QjjblBuHkqQH/9gHp/rYNt3P6QHHhhDvbYwWec2sLMHBUHhdtFjej0X0IbRxhzVk6EcRwW6L4 6+S+y/hHqJTXBH2VWLjxDBLXRX7JpJr5/31fACqLkAVCLperygz8lgKqYowRmVBSSqt/hJLnKsL3O gp/Nw1VHLuYZxQ==; Date: Mon, 03 Jun 2024 19:33:19 +0300 Message-Id: <86ikyqkmuo.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <8BC5E59B-63B1-4784-9454-51925E9DBCFC@HIDDEN> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Mon, 3 Jun 2024 18:22:48 +0200) Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN> <F834A272-58A5-470E-8369-D0C158461EA5@HIDDEN> <86sexukpuh.fsf@HIDDEN> <8BC5E59B-63B1-4784-9454-51925E9DBCFC@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70794 Cc: 70794 <at> debbugs.gnu.org, spacibba@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Mattias Engdegård <mattias.engdegard@HIDDEN> > Date: Mon, 3 Jun 2024 18:22:48 +0200 > Cc: spacibba@HIDDEN, > 70794 <at> debbugs.gnu.org > > > If you revert it, please fix this ASAP and install the results, since > > I'd like to have this on the emacs-20 branch, which will be cut > > soon-ish. > > Personally I strongly prefer no rule to a broken one, or even to Mattias's-best-guess-of-what-a-correct-rule-might-look-like. Fine by me (I don't use Rust), but is the rule really broken? What happens if you move it to the end?
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.Received: (at 70794) by debbugs.gnu.org; 3 Jun 2024 15:36:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 03 11:36:58 2024 Received: from localhost ([127.0.0.1]:43934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sE9k2-0008C0-6U for submit <at> debbugs.gnu.org; Mon, 03 Jun 2024 11:36:58 -0400 Received: from mail-lf1-f49.google.com ([209.85.167.49]:60671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1sE9jz-0008BR-VW for 70794 <at> debbugs.gnu.org; Mon, 03 Jun 2024 11:36:56 -0400 Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-52b894021cbso3872307e87.0 for <70794 <at> debbugs.gnu.org>; Mon, 03 Jun 2024 08:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717428937; x=1718033737; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=oGau47ULh8m3GwlfI4SQoe22ajAJSpczl3OFv/JmVXs=; b=VJB5l/XGduIVUMso06EVmsCzVPKi6F/eO0LUkPqvbuPJ8r5ZFYi7IqDa2WdJVyV5vX YbQFNplKxcWU2U3ZBwY22BMlRdnQxZzJ63DWqU7Ogg5eiyRGppcbexreM32v3Km5D7vB P1jhNoc4dGUluKUOoB7KgScyNKYHkCODrgZtje9GliFJuP9f6WxcwviMz6ha8GLZ84le VCy2tLtFOpHAdeVygNf+tFY5tZIMs/rz+emY0m2OLCiJgSB5RYUA7BuHgpvSVrAaCjXq 2tSr0PYso4b9uxiPvnKqW1o48okRjBZ1SlzOK81aD1IvjgQGRLcqiWI5Y8I8dv78HR1e GZEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717428937; x=1718033737; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=oGau47ULh8m3GwlfI4SQoe22ajAJSpczl3OFv/JmVXs=; b=Lrr00bxdT2JBxMI1LPbZ8ypWam/ZkJMnFTJo9Rm+BHuSBBC3v702f4jA2sQUVJdcDI A1HIKa3Hoxz83woT+mqy4CALHauSovGWFQmgVSdf0B0ZepHEfW8ipW/wwW2ViiSmd8qZ HuKDDN+lXA4GB61H614FLRJ0ffVS9qGmeEkGfQdZeVE9NNAl3bQZeJcOHARfp5LDj1QC iRJbpS6tpXy31Au6Cjygyux0KeEYV4PH34cEk43opHZHCHUxp4yB50P1XUlRJ187jttv VQlWtcogsCgwUJiJPWXh9hJpgSPsdx+cBg8OpHy5QqqUluy3LpC89ZUvN8R8g5k2sAh+ 0M8w== X-Forwarded-Encrypted: i=1; AJvYcCUMAxI7oo1ynDZEwFL8cai+u9rkbhD/1hLG36shRIbeI2bUDRvrSyyD/1vA0khBvYPdpaG3ibzk+g+YRjW6wmo6Fy31XA8= X-Gm-Message-State: AOJu0Yz7J9AIwyM/vY9ohMv/wzR1e7yHNBmoGpr1su4UOy24sRsm0iPH TnPkHd7HvefzUAYJbaKNbTUxntuXfm0+1aLUh7+yNuWeEjVGTHv8 X-Google-Smtp-Source: AGHT+IGILBMB49K7nO6Lfd7YqJbQJvMWQfMMiankL0ekARpvNuetqcN7JvdC5Jpyrj9z2NOdyaCoDg== X-Received: by 2002:ac2:4e91:0:b0:52b:8435:8f22 with SMTP id 2adb3069b0e04-52b896b23f0mr5581823e87.36.1717428936944; Mon, 03 Jun 2024 08:35:36 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52b954a552dsm611047e87.165.2024.06.03.08.35.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2024 08:35:36 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <ra7twcezodyvtrskr6egrfreurphcmprra2ci3nqgncwqmeiql@i5ila5dzhdqx> Date: Mon, 3 Jun 2024 17:35:35 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <A5DB9F36-395D-4F37-8F4D-A6423D1759CF@HIDDEN> References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN> <ra7twcezodyvtrskr6egrfreurphcmprra2ci3nqgncwqmeiql@i5ila5dzhdqx> To: Ergus <spacibba@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70794 Cc: 70794 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) 3 juni 2024 kl. 16.41 skrev Ergus <spacibba@HIDDEN>: > I actually expected someone else more "rusty" to > provide more complete information (I actually does not use rust with > emacs very often) Then maybe we should wait for someone with more Rust expertise to help = out? Without anyone actually using the stuff we risk making something that = may not be useful or that is already unmaintained from the start with = isn't a very good plan. Or (as in this case) actually having a negative effect on the other = patterns. I really prefer we only add something when we know what we are doing.
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.Received: (at 70794) by debbugs.gnu.org; 3 Jun 2024 15:30:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 03 11:30:47 2024 Received: from localhost ([127.0.0.1]:43535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sE9e3-0007uq-2U for submit <at> debbugs.gnu.org; Mon, 03 Jun 2024 11:30:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sE9e1-0007uP-CS for 70794 <at> debbugs.gnu.org; Mon, 03 Jun 2024 11:30:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sE9di-0008SN-Vs; Mon, 03 Jun 2024 11:30:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=giStgIVMH8xSBK0Aykte+3z+SaagCZMZk4NvXUlzIDo=; b=eDke5waXv+k4XvhGfKGW 4VULAxgZrsER5+5eykav+IBd9sBHDEKBzIQ6r18GJU+B9rZqtBrLs6jR59OtpcT4q9Az71R7mP4Ja qFF7U8n9Flajk07u9Hvk3/NrufWun8WyeuqjGBVWw70+PLYwU9pajw38yc/QiI022bBcZCL8+9Aly EXetzkDZNG7uUHBVJYNTlv8hBqN/Yx8abwQs4XLJE0CfMErLDXrowV3XSLblCX6oT5TVGWGpP/gVh 41sskIWCTebwXaFmLVQKS0RixevArAeFpIgADEeAVriuHHf8HP4xPlPPfZWsaEd9R9nNosB5KIbUz E49DqZYiousSVA==; Date: Mon, 03 Jun 2024 18:30:24 +0300 Message-Id: <86r0dekprj.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <F834A272-58A5-470E-8369-D0C158461EA5@HIDDEN> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Mon, 3 Jun 2024 16:54:02 +0200) Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN> <F834A272-58A5-470E-8369-D0C158461EA5@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70794 Cc: 70794 <at> debbugs.gnu.org, spacibba@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Mattias Engdegård <mattias.engdegard@HIDDEN> > Date: Mon, 3 Jun 2024 16:54:02 +0200 > Cc: Eli Zaretskii <eliz@HIDDEN>, > 70794 <at> debbugs.gnu.org > > In fact the added pattern has visibly wrecked the display of etc/compilation.txt so I'm taking the slightly drastic step of reverting it. It seems we'll need to work harder on this one -- sorry. If you revert it, please fix this ASAP and install the results, since I'd like to have this on the emacs-20 branch, which will be cut soon-ish. Thanks.
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.Received: (at 70794) by debbugs.gnu.org; 3 Jun 2024 15:29:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 03 11:29:02 2024 Received: from localhost ([127.0.0.1]:43425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sE9cM-0007nu-Dw for submit <at> debbugs.gnu.org; Mon, 03 Jun 2024 11:29:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sE9cK-0007nU-28 for 70794 <at> debbugs.gnu.org; Mon, 03 Jun 2024 11:29:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sE9c1-00080K-MN; Mon, 03 Jun 2024 11:28:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=z0n1Gdix/SSNgVdEu861shCv6rpSuRx2H8Jy9iySMQ8=; b=EycNZELZ4nYxtNNf50g1 WVhkbn9Vxm5jWvv5Yczjc59cdhUhc+dvOXaBOOxexFYdLv0AQzYEw3AauYGSUq0mvODJYsi+gfdSY RRBzq0PmuUo6dfcjDCWi+0tUIOiBVMxnXJ6n7pfspLcrMLEgmxU00og6QWz/EQb/IyTs7uQkwpB/D B3fkGelgF/FcE7OrqqZ3EAurb3WimtOvO8rrhTSrPJa0PgyvQcvwHQJLzlsCO14217xVMqxquvNMw hPcxNLABp06T2BkDKqBJeUUc1KQefODs0gZy/O5Pf6YknwGg23o39kT6c6QC3rHHIZMYMqnhWW+vg dJeTG/iC9VNtTw==; Date: Mon, 03 Jun 2024 18:28:38 +0300 Message-Id: <86sexukpuh.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <F834A272-58A5-470E-8369-D0C158461EA5@HIDDEN> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Mon, 3 Jun 2024 16:54:02 +0200) Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN> <F834A272-58A5-470E-8369-D0C158461EA5@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70794 Cc: 70794 <at> debbugs.gnu.org, spacibba@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Mattias Engdegård <mattias.engdegard@HIDDEN> > Date: Mon, 3 Jun 2024 16:54:02 +0200 > Cc: Eli Zaretskii <eliz@HIDDEN>, > 70794 <at> debbugs.gnu.org > > There is another problem with the added `cargo` regexp: its placement early in `compilation-error-regexp-alist-alist` causes it to match before other, possibly more frequently occurring patterns. > (That is not your (or Eli's) fault but an undocumented subtlety of that variable; I'll add a remark to the code.) The order of the patterns in the alist is a complete mystery to me. I tried to figure it out, but eventually gave up. A remark won't cut it, I think: we need a detailed description of the principles, considerations, and the way of testing the results after adding a new pattern. > In fact the added pattern has visibly wrecked the display of etc/compilation.txt so I'm taking the slightly drastic step of reverting it. That succeeded in my testing, so I wonder why it doesn't work for you.
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.Received: (at 70794) by debbugs.gnu.org; 3 Jun 2024 14:55:29 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 03 10:55:29 2024 Received: from localhost ([127.0.0.1]:42192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sE95t-0006Tm-7x for submit <at> debbugs.gnu.org; Mon, 03 Jun 2024 10:55:29 -0400 Received: from mail-lf1-f52.google.com ([209.85.167.52]:44499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1sE95m-0006TN-Qz for 70794 <at> debbugs.gnu.org; Mon, 03 Jun 2024 10:55:27 -0400 Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52b8b7b8698so3571495e87.1 for <70794 <at> debbugs.gnu.org>; Mon, 03 Jun 2024 07:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717426444; x=1718031244; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=3kgZ7pCkVlt5vn1tT96lfIetJxNzxjkMTGibc6xSSks=; b=iXgFgSym3275kvW9/YzVKy52kvCTAvdNIVZzaXySz8MPtrmHUCN1h4a657tNM9mPS3 B6550I04KB362p/RZXpzBXE9PQ7uHqeLT945FghewKlhGJMce1++byhuwzLysAg4/elA RgGRc5dJj4vRu8c6wbbNM+GxqJhsmCpi+4539lrG3yLhzRo6QxLdMl2XnMfWqjJCm3gy NFLoJTSFJjlhXSx8gXoUHjv/4KFGEqihgvW541QBWeXH+all0ZqveBbzx+w87/8JT8dj +7aFRBJoQJ1dumIr1+WlZleC85AcDGgRlqImwVc/r7VbCM3Bs1f4A4tXV6v2hm375mbc j4pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717426444; x=1718031244; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3kgZ7pCkVlt5vn1tT96lfIetJxNzxjkMTGibc6xSSks=; b=cDjXQvuYkkQXMpoxR0LZZzobrHyiieCD65Wgt0pqpP7zVTnQo1BwVY/BY5FGVIcyzl tYfVx4Ybve3Ky4nGM310qBqoFL4/RJ5GpKjz9+eXHhXdaNE1N87JPAVzRIl50D2tqCSU LwkW+TK1QAMTA+2pu5HF6Rl0g/O+37BNQarJKNHGVHPvaxSOVvMuUVM8bIV1DDBSZKI0 01RMywx+lPfzRcU147IWSDG0zSC4MlRPWbqZHYqCaQ19qk0ETyog/fqqVIZh9VkSzN0g 2sbniQkUbU0aHVMBP957I38k8KSqvJYfVdjyDR0EmohigpAsJ+wBr0gqWzfmyP9XL8jo MPew== X-Forwarded-Encrypted: i=1; AJvYcCX8hjkEDlMtWeURIAxINuhPuPuLICpUIeCDyS9c3HmqdpFMdG+9AnGNJFA9Ghd5zAQz8ISDexlUgcMfaDVDks2WWAt6sKI= X-Gm-Message-State: AOJu0YxJ/R+OLTNn0lk1FGJukSVCWZgyKhM/qMJqLlhDm0+nfUPfwBco na2cO5fxgmuF6rAqoWz4JWhkk52dVI8vHh3BW6+nbAkwRYqiD10bAvul6g== X-Google-Smtp-Source: AGHT+IHwmAIlhDNbpv1OQRscna0pi8k/4tWRbhbK2BvXv+H6TZJslTWrDikkN/JvOefGxyF3ErC1cA== X-Received: by 2002:a19:2d1c:0:b0:522:2c9b:63bb with SMTP id 2adb3069b0e04-52b896c1691mr5602917e87.52.1717426443652; Mon, 03 Jun 2024 07:54:03 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52b84d7ecfdsm1243070e87.189.2024.06.03.07.54.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2024 07:54:03 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> In-Reply-To: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN> Date: Mon, 3 Jun 2024 16:54:02 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <F834A272-58A5-470E-8369-D0C158461EA5@HIDDEN> References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN> To: Ergus <spacibba@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70794 Cc: 70794 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) There is also already a regexp that looks like it is used to match = similar messages in `rust-ts-flymake`, but it lacks some of the problems = listed above. Maybe they could be consolidated? There is another problem with the added `cargo` regexp: its placement = early in `compilation-error-regexp-alist-alist` causes it to match = before other, possibly more frequently occurring patterns. (That is not your (or Eli's) fault but an undocumented subtlety of that = variable; I'll add a remark to the code.) In fact the added pattern has visibly wrecked the display of = etc/compilation.txt so I'm taking the slightly drastic step of reverting = it. It seems we'll need to work harder on this one -- sorry.
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.Received: (at 70794) by debbugs.gnu.org; 3 Jun 2024 14:42:11 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 03 10:42:11 2024 Received: from localhost ([127.0.0.1]:42166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sE8t0-00067j-Ke for submit <at> debbugs.gnu.org; Mon, 03 Jun 2024 10:42:11 -0400 Received: from sonic304-9.consmr.mail.bf2.yahoo.com ([74.6.128.32]:42250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <spacibba@HIDDEN>) id 1sE8sv-000679-Cc for 70794 <at> debbugs.gnu.org; Mon, 03 Jun 2024 10:42:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1717425706; bh=LqeSL4Cyd+AE/3eKu8wZW8drFcemGfU8f7ZzN3d+l4A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To; b=B9xtY7u7zlAoSwIApygFD/irgcicPUHGdbBfpxcHT9Z1XiWFgFFhS+oAaBiwWYbp80ASwZ+gxeBNrgsOcZJ5xLD6bLyO/QzNmYdVsUottt+WkOTULTxAy2oghF0j34VUM1SQs+OjOMlgPnsnAexB5kVOv+WW/VoWqBE4ZqwmPgRTc8oG/vB7rUzFsKu24QnVKhEZKMLQDPuTZ7SIoeae3XGXFo/1yCTFYnCz3OlZdVuFamtpxqVWfZqrcxvcHgRcOEwGqmQ3Pwlm0exfHaI1HBESg2AIBGYsoROgQONpbmDvKRq/dm6TZ4GWmQVjCpNDb0RKN16lhcolTG0S9WZ/BQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1717425706; bh=S9rIsi4zwZeNFBTvs0FcknEQmhYgki6MiXdbk1XppTq=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=TDNcSf6u+Ks0K4X06sepnHWUyXWbnvkz/ZpQ8TuZe21aL52gWjRMuwpR4IheIrUPpKi2emcSPiIKaYnHAgKJyoWagqYnrZCZID7S8PAnC96j8xkshrVe9xVHqOHvlfh++ISs2yXFGZCCQWLWdGTt0FkP5gH1reYm3Lun5W0KL+QvraNhQAlJeB/g6WNYULIb8/E6jwF6isYa7HW+JtTXJW7InHcJnsiIUyqeUQhFoCBiT0Dy5ks/pKKvqmVTyZxLdU8xnU09PJcgjZU47bQrC9ZR4nOqHXlwGb5WDBk+Tgm35zkxypDkZmDrXvORuevLIzjifzYRiXdy4XnpYV/n1A== X-YMail-OSG: qopc81IVM1lqWuWM21lK.TWSOI5mTBJg0uiLS9V_Z89LyTPSkEybPSCWokRt9Ya MOAK629gwLWXAJwLeW8YQO_rBnrYucQFCejx0OCus2TkWDolF1TIBKgUuaU7nwlZkjRNiIsVwVUi .AGbRblo3dxaaJTA7UOjkWmo916x8.iy6u0M6VoWiDlD6p_rkCj2qYJUkm4XfKn0w39_I04Eqp8Q IR1XymBcNcz.wfzYY712S8QdLc4Jc8XifK38q_DQF.O.Mmln267psARuai9sDpM9YWNWVIsWrn6R azNPHurVhPAuQU7sYwRCWFfQ33qOu04G6RltMaS4dnav1Ah4QObuJqnPmEyVp4AVlmgTXgEnyPhb j6NlwbeTUlxnD3EaZjZIMOx2MXNrtHs2bJCo8smAxm77KF_E2vY.6b86MIF4mEUchE6EpeqtPaNh TTzLK3X46pqO7.zdEzF7hEPGI9DChjKZsKDjm6MSEwUqedx04DQc6T_rpUmAmgqHt6Uc44e7xrEy 33wnwB80DfBxIVAbUtuoik_7AbakagV9zMrEAWeluaHWUwVS8fk4NNsj9odN36rN6IFzyYVe8CSt KU014_3MTxfvvjRliXA7a4Odf8LFfOAFvY3XBoHYu6bvcl0pgt3dcvQG5p6zrv4n3VJtzLmq.jiX Y83cZzOQm9i5jZt_yB2KVFKc4PN84M7X1ADHzVKkZjbxHs3.RapETuhfMy2K2TmWAKg3VJPEbrCx zM.HlWIyXVr7L3A6WWaPRgE0YYnKdLjh8q60i4DqZXZV5xSMFLQznQ9me_cqZ3QOoULfBU87Es7C eUyYjjLsQtGwf4xYAK5GC201qEFdrbj3PJMSd1zVvSijLN3w5b2GVWttCx5cg29dpWBzcd8pEywv QegO51N9a55Yv2HNfySmHVXkOQeQrjK5kWwfYz5E3qIdeClIacjqmhi1XJ1mbHfgWA5c8GosDqqp 0vs_gtBhcoPmGitOige1u8t1R5SsTCxI1CjEkYiwkPXUodpUibxlquPhpPeEMqhKRewPAdvRPe5L B1k09wonCpxEaHzFDcYrkk6cE6F8MimZlGkh8f2oBvsajbAyP5zodbqzJZQnozln4_FCFOS10eJc pZMISKG2Gmn0HXfA9yLiZViduoR.3M7DF_vA2f3rJR6WURmTxFgQAvrLQ1S1yCu8UmJ_4Pprv0Wd P68SBUa3fSE42xwn.RHoNy6UPPSjBHnLPYG6cwLeialkd0p37bhTkhvsDIDFthEr7kwv3uqZsq.m h6QZ.zGmleAt3DVzwLoSMMgyrN72A.UCTzkd7xRn3M6LGL03ODsSDd81pNUbN221C3XSfH1lxp_J 2p0n.yTe_D6S3H1ol8sSUaw3ZZKlPNJX3IE8WDaB9eyLJc.UlSnx4cjwVIkk0pMK1syrF4spc7To pwFHdyuQoULKWOKtImwZIOcTHSJ6eilBOf_Q4_Ao5yHbodGu70EHVsAoJnKXMR1FQwIkBzHekJXy fOctLT5OzAvpq8syPFXimpiIJbRIgOSzicdtXSXz3TmjLwZqN42_MQAwqp_aD2Vj5qHC2Liu7WWY .sHP059SFpWxF0As71JIVO3HNXweCChcJV6YFqON.LOD5DA1VYdSZkx.ujWKUOCZpGpcCh3Wxsrp bhzrDTgW_sAxRWY9jaRRtmGKMZLnVnPiUli9cmtq5n4cbhWLcEuLfcVVkDn_ugubp0WUgrSJATpn dmXbZp5Nhix7F_jhuj4iLdT0nslY_PPzjzi2obPyiaSmO9EtgIonvvLmagyD4GbhpV_4rYr7Aj9h 8xHafl2vYW1Vz9RsZXFNB5jNakSOLsGcyF098MrhAc3eI1yHyAkGNRlUsny6NBZqZYQmk.PCVhkX Bmn1TDBekjLTbErA1An22IZawI8lDBUKkrci9i7s4Kyu0DNlZPpfDx90go1xQEDJIQ53KpM9tMyj BEnKJoDLCIt_F7q7UdRbggaHpEuvdQmWEKLIsnNUZFYLEpvuvUt4.4HZwFA.caacnaPQQOas.mAQ pDpT4rIHEMMiTDKfYj3cpyIfDKtgMzNh3fUNXeeZ9IxFqt1dQ3ZHPqKmKTRaPqm.4UWhV_e.iXhi WtwGnrT91Wk97RzY.tGB6ut_q_FbuoF2YMw7KqEgXZV_RTcgudy2G7oCODRj1VY2PQC0r.gbqwjb sMfRNC7schHPPSLxu23RZEe6vnFyysFI6BSTR_S3m5jK4alHNXmxb6wJE5s_JVVQT7Dmu5di9 X-Sonic-MF: <spacibba@HIDDEN> X-Sonic-ID: 98ae122f-9704-441f-b758-2be3bafca6cd Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.bf2.yahoo.com with HTTP; Mon, 3 Jun 2024 14:41:46 +0000 Received: by hermes--production-ir2-7b99fc9bb6-24wkz (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a7689670f10cb2a290a17411c2812904; Mon, 03 Jun 2024 14:41:44 +0000 (UTC) Date: Mon, 3 Jun 2024 16:41:42 +0200 From: Ergus <spacibba@HIDDEN> To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex Message-ID: <ra7twcezodyvtrskr6egrfreurphcmprra2ci3nqgncwqmeiql@i5ila5dzhdqx> References: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN> X-Mailer: WebService/1.1.22407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 3966 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70794 Cc: 70794 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Mattias: Thanks for your interest on this. As I said in my first message I just proposed what I have locally, but I didn't intent to insert the regex there as it was. On Fri, May 31, 2024 at 07:15:52PM GMT, Mattias Engdeg�rd wrote: >Ergus, thank you for your contribution! Some questions, if you don't mind: > >* There aren't any tests. If you care anything at all about your pattern working, and keep working, you should add some. > >We'll help you out, of course, but it's probably best if you give it a go yourself first so that we know exactly what you want to match. Take a look at compile-tests.el, `compile-tests--test-regexps-data`. You will also need to increase the expected counts at the end of `compile-test-error-regexps`. > Actually Eli added this commit with the poor information I provided in my mails because I don't have time to do it myself these days. Sorry for not being more specific. I actually expected someone else more "rusty" to provide more complete information (I actually does not use rust with emacs very often) >* The regexp doesn't match the variant with error code inside square brackets, the > >error[E0425]: cannot find function `ruun` in module `broot::cli` > >kind of message. Surely you intended it to? > You are right, Checking my local version I have a \\(\\[.+\\]\\)? before the : in my pattern, not sure when I added that since my first mail. >Here is your regexp again, translated to rx and with line numbers for >ease of discussion: I don't really understand the rx notatio :/ but I will try > >1 (rx (| (group-n 4 "error") (group-n 5 "warning")) >2 ":" >3 (+? (not (in "\x00"))) >4 "--> " >5 (group-n 1 (+ (not (in ":")))) >6 ":" >7 (group-n 2 (+ digit)) >8 ":" >9 (group-n 3 (+ digit))) > >* (Line 1): From the examples it appears that the messages start at the >beginning of a line. We very much prefer to anchor matches for reasons >of performance and to avoid collisions with other patterns. How about >we add a line-start anchor at the very beginning? > It is ok. Probaly you may want to add also a line-end >* (Line 3): This is an open-ended expression which will merrily match >just about anything including newlines. This can become very >expensive. And where does that NUL come from? > The NUL is actually negated to match anything up to the --> >In the examples you supplied, the message is on the first line, and the " --> " on the start of the second. Can we rely on that? If not, what can we rely on? > I think yes; that's at least what I tried to match. If you have a better/more efficient alternative fell free to change it. >* (Line 5): This excludes Windows file names which can include colon or do cargo messages have a special notation for those? In any case, it's usually a good idea to exclude newline as well to prevent a runaway repetition. > In this case I think not, because the filename is always relative in cargo and on MSWindows the colon comes after the drive in absolute paths right? But I could be wrong. >* Both the rust-mode and rustic packages appear to include regexps that match the same messages. How do they compare to yours? > You can take those indeed. I think they must be pretty much equivalent and probably more complete because they probably match the "note:" case which I preferred to ignore as emacs does not have an equivalent for that. IIRC they just don't use numeric capture groups, which I like a bit more t avoid weird errors, but at the end the regex is pretty simple, any alternative is fine. >What is the effect of someone using those modes with your regexp in Emacs? > > IIUC the packages pushes the entries in front of compilation-error-regexp-alist-alist, so in principle their regexp will match first and the loop stops. So, the main changes you propose are something like: "^\\(?:\\(?4:error\\)\\|\\(?5:warning\\)\\)\\(?:\\[.+\\]\\)?:[^\0]+?--> \\(?1:[^:]+\\):\\(?2:[[:digit:]]+\\):\\(?3:[[:digit:]]+\\)"
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.Received: (at 70794) by debbugs.gnu.org; 31 May 2024 17:17:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 31 13:17:18 2024 Received: from localhost ([127.0.0.1]:55290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sD5sU-0002Fh-DE for submit <at> debbugs.gnu.org; Fri, 31 May 2024 13:17:18 -0400 Received: from mail-lf1-f42.google.com ([209.85.167.42]:55795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mattias.engdegard@HIDDEN>) id 1sD5sO-0002FQ-Bl for 70794 <at> debbugs.gnu.org; Fri, 31 May 2024 13:17:16 -0400 Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-52b89fcdcc7so1198833e87.3 for <70794 <at> debbugs.gnu.org>; Fri, 31 May 2024 10:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717175755; x=1717780555; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=wuPS8H0FO4Rq8AajehLe+ZmQGm0jMxMZOpKN2ZTsGZI=; b=P7msn7oWmWa5lsJLV7DFP9Rn0MEHeRMN0/1En4Gyvz1JTGI3Ye/V/MSRFd8xcIidbm IeO3G7L6CSbkUTAsbUjKgU7JqskgfxiN/x1BnuC+asHGNdOCKQFv/WSfyOlGtoASpuFj ts0CEI+I3EaaWgCqCyHQxV18gKRSUN/wHtzhbA/NA/nUZsDLny0Xr4tBNISfTasSYGdw fqpmk1b8XHSt4Yz0SChYPLaHej+DkEo+4xzlot4Nwbh6lHCWpA/jakY8FWWiSizsHNWw X7NATlokANyfaus852EVBKDaNI3DtpKdjmd6Ho9F5qfzRWhH6dx1AyG0boW9ykniAA3k x0xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717175755; x=1717780555; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wuPS8H0FO4Rq8AajehLe+ZmQGm0jMxMZOpKN2ZTsGZI=; b=JownxIhhtxs72YAj/MKWKVMb1k1MBR11ju4aSaApsKSutUArQJDSWbjFK3cG7eBtC9 ep3vVGscnTRS0Se6K5mqWbw7PZrlIqPTufbqSFZrbgVuGE2iFFNqSi+mYXVDAIVdYrNj HOL97ynEGBb+atPAAzw27ITg/fhlBTMeetpuFbp7p0C/XJhr5ho2uF9V8lvpIw8+6lp+ 0PArl5yWzje6/CjVivWNY5VJgd8x2BwztV1aBZ9LccYJIbFWk0Wb28MVxOZGCasS0QlA ecwRo2l5+aqMcsF3HNJPzLyYsxBh0kgceL3c96NQ0Zez9+l1JE/Q2C5dN58wzauX97oG kNwg== X-Forwarded-Encrypted: i=1; AJvYcCUNPWfbxOVQCRA9iZaDvb60Tsi5/PNZmPQvrssswJXFJGJoaE5jEvr1m5qZGX1Kpj98z/pnYGn1/Ppsb2YKSQyGqCsAVDE= X-Gm-Message-State: AOJu0YwGj5BN+puVcVyLaRfGKLxVnV1UXBRBgq0dkJ+HKqjT9W+mFTpT NmouU7EKcLwWdx0oBr19zRjtPGuvHYuMipM4rk9xnxM7cp8XyeFS X-Google-Smtp-Source: AGHT+IERhqysld48yYhXXgFsN9orWu9KIY5se8SNyv+pqKJM+uOHgcHrz8aMhO/UcX76cLmmuYAnAw== X-Received: by 2002:a19:f804:0:b0:524:68f8:9566 with SMTP id 2adb3069b0e04-52b89597ca4mr1661997e87.30.1717175754780; Fri, 31 May 2024 10:15:54 -0700 (PDT) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52b84d802afsm382518e87.208.2024.05.31.10.15.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 May 2024 10:15:54 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= <mattias.engdegard@HIDDEN> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: bug#70794: 30.0.50; Add Rust compilation regex Message-Id: <16667D6C-F897-4A85-8C7A-0FA2E803FAA6@HIDDEN> Date: Fri, 31 May 2024 19:15:52 +0200 To: Ergus <spacibba@HIDDEN> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70794 Cc: 70794 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Ergus, thank you for your contribution! Some questions, if you don't = mind: * There aren't any tests. If you care anything at all about your pattern = working, and keep working, you should add some. We'll help you out, of course, but it's probably best if you give it a = go yourself first so that we know exactly what you want to match. Take a = look at compile-tests.el, `compile-tests--test-regexps-data`. You will = also need to increase the expected counts at the end of = `compile-test-error-regexps`. * The regexp doesn't match the variant with error code inside square = brackets, the error[E0425]: cannot find function `ruun` in module `broot::cli` kind of message. Surely you intended it to? Here is your regexp again, translated to rx and with line numbers for = ease of discussion: 1 (rx (| (group-n 4 "error") (group-n 5 "warning")) 2 ":" 3 (+? (not (in "\x00"))) 4 "--> " 5 (group-n 1 (+ (not (in ":")))) 6 ":" 7 (group-n 2 (+ digit)) 8 ":" 9 (group-n 3 (+ digit))) * (Line 1): =46rom the examples it appears that the messages start at = the beginning of a line. We very much prefer to anchor matches for = reasons of performance and to avoid collisions with other patterns. How = about we add a line-start anchor at the very beginning? * (Line 3): This is an open-ended expression which will merrily match = just about anything including newlines. This can become very expensive. = And where does that NUL come from? In the examples you supplied, the message is on the first line, and the = " --> " on the start of the second. Can we rely on that? If not, what = can we rely on? * (Line 5): This excludes Windows file names which can include colon or = do cargo messages have a special notation for those? In any case, it's = usually a good idea to exclude newline as well to prevent a runaway = repetition. * Both the rust-mode and rustic packages appear to include regexps that = match the same messages. How do they compare to yours? What is the effect of someone using those modes with your regexp in = Emacs?
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.
Received: (at 70794-done) by debbugs.gnu.org; 18 May 2024 10:52:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 18 06:52:47 2024
Received: from localhost ([127.0.0.1]:60998 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s8HgF-0001eJ-9M
for submit <at> debbugs.gnu.org; Sat, 18 May 2024 06:52:47 -0400
Received: from eggs.gnu.org ([209.51.188.92]:46064)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1s8HgC-0001eD-Vj
for 70794-done <at> debbugs.gnu.org; Sat, 18 May 2024 06:52:45 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1s8Hg3-00037l-JT; Sat, 18 May 2024 06:52:35 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=iuiwmZDI/IJN80HXmbTSs8XzHxIf2A9fkGLXN2/ozRY=; b=NYtR0lNhI/Rq
KmC46kROcZeCISxlMuulyVYRpdSUSYk/BM1N+MTiGcKthTD/7IdsetzLmo6MhoGtOkZqS07C/1e7t
vVgA0KVLO61VTFM/8YDd+x2y7HpSV+GIea1O7TY2kHUeBs7OpEYIrfTyptAtnWEPYBMGz7no5IqXQ
7x+sJKeAmJLOUm2HBTGf1tJTBg2jxonc9QVfMctfPgFJ4RJgEgrM/joJnENhu/6bYsQo7zItasVrB
pWzb8xtLtrzyf1kj2CaMCwMtewBwtV6jpKmyEYSa11xm0FpMGMLhWSZwNKyFcsKZlLE0Ku4bHZEyK
f/lx8GT7huBrzJqZz99ILA==;
Date: Sat, 18 May 2024 13:52:29 +0300
Message-Id: <868r07e6j6.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Ergus <spacibba@HIDDEN>
In-Reply-To: <q6appvzmmlhwxilvsokxtsyfoccj4pcqamsmh77o2ekdirzwnx@egqgkt5sawk5>
(message from Ergus on Wed, 15 May 2024 15:10:02 +0200)
Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex
References: <87y18nsp84.fsf.ref@HIDDEN> <87y18nsp84.fsf@HIDDEN>
<86le4g3f5z.fsf@HIDDEN>
<q6appvzmmlhwxilvsokxtsyfoccj4pcqamsmh77o2ekdirzwnx@egqgkt5sawk5>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 70794-done
Cc: 70794-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Date: Wed, 15 May 2024 15:10:02 +0200
> From: Ergus <spacibba@HIDDEN>
> Cc: 70794 <at> debbugs.gnu.org
>
> On Sat, May 11, 2024 at 11:51:04AM GMT, Eli Zaretskii wrote:
> >
> >Thanks, but could you please also send the examples of Rust messages,
> >because we need to add them to etc/compilation.txt?
>
> Hi Eli:
>
> Typically they look like this:
>
> ```
> error[E0425]: cannot find function `ruun` in module `broot::cli`
> --> src/main.rs:6:23
> |
> 6 | match broot::cli::ruun() {
> | ^^^^ help: a function with a similar name exists: `run`
> |
> ::: /tmp/broot/src/cli/mod.rs:49:1
> |
> 49 | pub fn run() -> Result<Option<Launchable>, ProgramError> {
> | -------------------------------------------------------- similarly
> named function `run` defined here
> ```
>
> or
>
> ```
> error: cannot find macro `deebug` in this scope
> --> src/main.rs:5:5
> |
> 5 | deebug!("env::args(): {:#?}", std::env::args().collect::<Vec<String>>());
> | ^^^^^^ help: a macro with a similar name exists: `debug`
> |
> ::: /home/ergo/.cargo/registry/src/index.crates.io-6f17d22bba15001f/log-0.4.21/src/macros.rs:154:1
> |
> 154 | macro_rules! debug {
> | ------------------ similarly named macro `debug` defined here
> ```
>
> ```
> warning: crate-level attribute should be an inner attribute: add an exclamation mark: `#![foo]`
> --> src/main.rs:3:1
> |
> 3 | #[feature(proc_macro_diagnostic)]
> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> |
> = note: `#[warn(unused_attributes)]` on by default
> ```
>
> Two details:
>
> 1. As you can see the [] is optional
> 2. The path is always relative to project's root
Thanks, installed on master, and closing the bug.
Ergus <spacibba@HIDDEN>:Eli Zaretskii <eliz@HIDDEN>:
Received: (at 70794) by debbugs.gnu.org; 15 May 2024 13:10:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed May 15 09:10:20 2024
Received: from localhost ([127.0.0.1]:42223 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s7EOf-0000ug-NF
for submit <at> debbugs.gnu.org; Wed, 15 May 2024 09:10:20 -0400
Received: from sonic303-2.consmr.mail.bf2.yahoo.com ([74.6.131.41]:35128)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <spacibba@HIDDEN>) id 1s7EOc-0000uW-P8
for 70794 <at> debbugs.gnu.org; Wed, 15 May 2024 09:10:16 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048;
t=1715778607; bh=ZWH2mViHBI047YhScjU9jsKmDbtJTp5IB3DS1Uk7aFs=;
h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject:Reply-To;
b=U4XL5QEYYX483HF+Pybtd9lVG4x2VxwVyhloZu7VplSUbzN+2wRsMnVVMge+0vmxh81We2Gwbn6N1YCKV2Sprvdzb2wHLAKGEY3YfeWXrxbcBuRh0moAyxK5wUh3X6IKwTHrdcCjVvtHpNXenGRqhFqREyl/HbIv7bj8Y8dKSj1Kc6PLWsi7sNs+oncLWwn2DBEqSs9gZHM3GqV1pd2r4lfOBVXxWzisfib+ix48DDX4zmRb7yyTiZM5O2BJZTTXGoUqxAKPNDbS44Si95saZcpjtuR62nZc0eBFLb4KBx+XcQOff9QwRoAP09Kb08YFeGzvdzbstyX0+kmKT738pw==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
t=1715778607; bh=ZIKGxs2w5PrrbaKas7NBHLu8bhC1HKI+dEX2IlENfIp=;
h=X-Sonic-MF:Date:From:To:Subject:From:Subject;
b=NTqw69dx/OQjAdEBiFCT2G3UnPf8828SmJKR8tiDkq2nEYBYZmu73CgQF3KNIo6ANN8wAxiwyHJkrDeixYm/yS1Wgp9EHs50GVzuiiW4PgYPaSFlN2Ims7kkgou2nmMFEaH/1kgu+nkDFtizTutwYPxARklnx04dRaVWUjt32c8u548NVmWIRBAX8pIiE0JxtTtSDyugEqIoopM5fdjRAmNMP2KJ0+btJIghLyjqcufhcldkylrcp6RoSXD2rSbneRrlOWmnVYPg4QZMiConNz2p1e9nJL9XIPJ0RMCdRRLtUEVXGFy1pKiUTZgMi8bM8+ejwuAAFCCgJpNlK+bCpQ==
X-YMail-OSG: DlsRbcAVM1mImvEatqpBX7JTMAL6VZV4A6m2bvxUv1LIwwgnJFwp6WPXmihWNhl
8YL3FThcB826XYkKB6.I4iIcRNUv6tl407hYbVgK8I4olI2.Pm6dNC7IkGVIrVqchAoo8U.LFbLH
A5hW.ZC77TYXKBKK5kpWjNGohwleYt..X50rLmW.t8m.Rih5JRMAdehNKQEN_ARStbKOrSHyH8nP
vX23UNRWD6vpeEaV7q72iDJsB5Yh.UaWmBuxsZ1gjIgyyVm_50vhUuk7R4boYNHyu4Eys6dM1abN
XaZFYLrMjmCV1j3w2ey.NFq5FMOKOpdwfnTxgqhfokvyYeD_gn4mzVUFW22PP8NffEYu04kmQAFb
9OvCW.xM6Zwtnf5UUv76Atl3cF50y5Bo8gM8yKM8.ZydEooWovkKXwQLEViypWR63ocmvMu71L4b
t3Y_CxWRx_CHvPEH85LrqfHX51FL0s9ArfuzHpPeVypMZjAiYPbsS1PM8xAey7RZJoy6LKZ1fGiX
ekRXwVF6K3zFeqH.WgcZzzaj4ouhQIvQGhE_noFFtDDg2W7azW5ckncI94fU0eaWwGg6D9w4cnfg
UgwIF.FLDra1_pUeE6dmylRAAtiS_fuCrzVoFVBAQRrau4rlZD_Kk2t2gwZVTiRiKgBafmQNOG3s
kPnp4hO9kUU8qlTfusxM3VCrfut7WyIRSwpOj2Y.Z3hJK6.e03YrCxnMvgL1G4PGigiLzZAgn.ms
jf60GGHJVOIzmel0snhU74_k4CPkCziBCxuwzcrxIk83hRubhLnQ4Oo_7lRd.rnrR3kYlOuYDiRD
2K8H_b0p2GRl1JgAGmcPq3PGp_ncxo6j3O0oFgLJ7O4.rPlDPoeCrc8OZ99NQNu10Tbmiv9lRSCz
iREycYFDgANr2sc9plk2k3HowIXpKKqUqIZawEBn35lRObie0gPJ7fV_gx.xaVVMCBTKrRXEQPQn
BEobsg6dhtwvwXHeZ9REMfq6pYQ4FZji7QIVyZ2Du0_xHb0t.qbx.1Iug.m5MEbFhXqj4pqwhMGw
9e4T.LO8yWZv.Yc62tPNW3KSEr1pj3Wk9B0xqHKAGQ5eQ40S2T1ypRp.LVnmmQKDWKu93HYXO8EW
Ct4WHIQkNJE9yF8dhBlreysQDnUfrqAm4ouQe452pzL3BiG1fEdC265q1IiY20.LSUXgBk4lOLiB
Q1WZrNZ_xnxA6ibdlEz9LiyWY4_.FN6B2OvmRV3nJEs9h74gpiCm7r5Ycqv9LOJEuUJyRbj07ku0
CM8yb99MAqdlFrtLwvt8mEVtJzbjiLQY7bxmluZgnWbaQKZiIuF4B3kfQQYdH4nW3wY8b54aT.Xn
IUSkfpHQYuD79Ng.ek41rtObR4C4N6Zv8iKxv.byty._uJCRzzHUihcoJQA.fBbRbKPUuj7qDXdx
nFXLXYmdM9MQORpXnRg8jhS13W9oQDtU0b640j6Jx146u2O37SmYydN5kq_S3Sx1RzG.xuPlx82U
ZczdnlC0NrpylQTGbfEzJo9Jrn73BMG979FAi7NgmJkpnEjGo39dhQtgBbGrwYa4Z1MSQgHhDB.W
YNYDdlvIRohJf0IOEqcx98ShrfeAZtPQsIyM731KdQU8o6JIgEjRPy6oMCxr6727N_YrhvjqNfwL
I4kvPmXZs4Q2khiRqeBWysSR3L7ymmlt3FNxVFmI2s70i7inFeNjp8VDJyMcuzKyUrTZe9EOFvse
i8uCgTl8jhDi7HHVJXVRW8kxInV0TDx9cSHsYkidRHdqDM3rA2dNsGEiP.RMqNPbwREc3sLE2LWr
4yZu2AvtDW2vH4OZQyqc2_8cxpRUhZiZpXtjJEOb6Gw9lpydiptwkI40Qm_g1zpOkqS30yatL9tm
K5ORtmI6551G9qd_x0FC37Sh2AmW0S91veGliFt0fNF4kmJlLvwGzgktl7TFdWme1gvpf9IE7TP.
_7WIhlgvJTvt6elI.WP1ruG.7vO3avJKtcJ5a2OMuVOdQVTcnPqycZwH6Kdd5rkbTiUoyej47wbE
.6U0zsD.pnPOyVSkloCj9pT9F0KqtNLU9KFGpi0KXvDJGYg4S0BwPAKsHU5U2YtOsR5tiDGOVpLq
5072c3.TB7Wm1jB_AkSYPnp__15507Z4sq9VaTCjXytbI01lS4ZxwZuSFKL9bSLYH.gpRQeV9l1O
OjIpq7tNNkMudMzhqJzPVcqkWrrzHjS4eByOuZf4VjB.LrW_yMINKIojVqzSwC2gViQrosME3
X-Sonic-MF: <spacibba@HIDDEN>
X-Sonic-ID: b840aa38-48e9-4915-a5b7-c8d60578c955
Received: from sonic.gate.mail.ne1.yahoo.com by
sonic303.consmr.mail.bf2.yahoo.com with HTTP; Wed, 15 May 2024 13:10:07 +0000
Received: by hermes--production-ir2-7b99fc9bb6-dmk2d (Yahoo Inc. Hermes SMTP
Server) with ESMTPA ID bf05b5f70d5b599b1691c1ae922cadfa;
Wed, 15 May 2024 13:10:04 +0000 (UTC)
Date: Wed, 15 May 2024 15:10:02 +0200
From: Ergus <spacibba@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex
Message-ID: <q6appvzmmlhwxilvsokxtsyfoccj4pcqamsmh77o2ekdirzwnx@egqgkt5sawk5>
References: <87y18nsp84.fsf.ref@HIDDEN> <87y18nsp84.fsf@HIDDEN>
<86le4g3f5z.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <86le4g3f5z.fsf@HIDDEN>
X-Mailer: WebService/1.1.22356
mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 2548
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 70794
Cc: 70794 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On Sat, May 11, 2024 at 11:51:04AM GMT, Eli Zaretskii wrote:
>> Date: Mon, 06 May 2024 03:28:43 +0200
>> From: Ergus via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
>>
>> Recently working with rust I have noticed that emacs does not recognizes
>> the rust/cargo error patterns.
>>
>> Considering that emacs has now the rust-ts-mode, it may worth adding
>> the rust/cargo error patterns to compile when using that mode
>>
>> In my system so far I have this:
>>
>> ```
>> (with-eval-after-load 'rust-ts-mode
>> (with-eval-after-load 'compile
>> (add-to-list
>> 'compilation-error-regexp-alist-alist
>> `(cargo
>> "\\(?:\\(?4:error\\)\\|\\(?5:warning\\)\\):[^\0]+?--> \\(?1:[^:]+\\):\\(?2:[[:digit:]]+\\):\\(?3:[[:digit:]]+\\)"
>> 1 2 3 (5)
>> nil
>> (5 compilation-warning-face)
>> (4 compilation-error-face)))
>>
>> (add-to-list 'compilation-error-regexp-alist 'cargo)))
>>
>> ```
>>
>> Maybe a more frequent rust user has a more general regex to
>> recommend. But this one works for me.
>>
>> WDYT?
>
>Thanks, but could you please also send the examples of Rust messages,
>because we need to add them to etc/compilation.txt?
Hi Eli:
Typically they look like this:
```
error[E0425]: cannot find function `ruun` in module `broot::cli`
--> src/main.rs:6:23
|
6 | match broot::cli::ruun() {
| ^^^^ help: a function with a similar name exists: `run`
|
::: /tmp/broot/src/cli/mod.rs:49:1
|
49 | pub fn run() -> Result<Option<Launchable>, ProgramError> {
| -------------------------------------------------------- similarly
named function `run` defined here
```
or
```
error: cannot find macro `deebug` in this scope
--> src/main.rs:5:5
|
5 | deebug!("env::args(): {:#?}", std::env::args().collect::<Vec<String>>());
| ^^^^^^ help: a macro with a similar name exists: `debug`
|
::: /home/ergo/.cargo/registry/src/index.crates.io-6f17d22bba15001f/log-0.4.21/src/macros.rs:154:1
|
154 | macro_rules! debug {
| ------------------ similarly named macro `debug` defined here
```
```
warning: crate-level attribute should be an inner attribute: add an exclamation mark: `#![foo]`
--> src/main.rs:3:1
|
3 | #[feature(proc_macro_diagnostic)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_attributes)]` on by default
```
Two details:
1. As you can see the [] is optional
2. The path is always relative to project's root
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.Received: (at 70794) by debbugs.gnu.org; 11 May 2024 08:51:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 11 04:51:16 2024 Received: from localhost ([127.0.0.1]:47104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1s5iRn-0006qb-St for submit <at> debbugs.gnu.org; Sat, 11 May 2024 04:51:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1s5iRl-0006qV-Th for 70794 <at> debbugs.gnu.org; Sat, 11 May 2024 04:51:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1s5iRh-0000fb-44; Sat, 11 May 2024 04:51:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SV69QzemWygR9u80QFwYnwms1FbO8Kc7dz+vVDi4EW8=; b=LlL1awDgfqol 9yI0TqFkvPXXZ90n6O/DVj88qI7BfmJK5ZfoxH3F5pLr4M55/X/eDAg1+LA+EevHtKpw1pwdSUKW7 pJKNz8vkvbUDtL5/lcYkIi8Xxmz3u9yCg0M4BFidS+rT8LK1bZvGqJnkpyJmfrN0AlDhR3B6BB8W6 paDZMJivGCgHMhCI/y/4HpB1SyPffsFOEIjAce1YOPvUbW6aIg1po1mTBCfeAhBQ98WoOuAEebJsI +Zh+72Xc72wI9qBYSs/LAyFfb6fYXxeajHw4t8Bqqva36VvuBZ2qr+/nhlHCSnsJ+MGPZQuQrVClo pGaiNq1KZpTzvbI11s/55A==; Date: Sat, 11 May 2024 11:51:04 +0300 Message-Id: <86le4g3f5z.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Ergus <spacibba@HIDDEN> In-Reply-To: <87y18nsp84.fsf@HIDDEN> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#70794: 30.0.50; Add Rust compilation regex References: <87y18nsp84.fsf.ref@HIDDEN> <87y18nsp84.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70794 Cc: 70794 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Mon, 06 May 2024 03:28:43 +0200 > From: Ergus via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > Recently working with rust I have noticed that emacs does not recognizes > the rust/cargo error patterns. > > Considering that emacs has now the rust-ts-mode, it may worth adding > the rust/cargo error patterns to compile when using that mode > > In my system so far I have this: > > ``` > (with-eval-after-load 'rust-ts-mode > (with-eval-after-load 'compile > (add-to-list > 'compilation-error-regexp-alist-alist > `(cargo > "\\(?:\\(?4:error\\)\\|\\(?5:warning\\)\\):[^\0]+?--> \\(?1:[^:]+\\):\\(?2:[[:digit:]]+\\):\\(?3:[[:digit:]]+\\)" > 1 2 3 (5) > nil > (5 compilation-warning-face) > (4 compilation-error-face))) > > (add-to-list 'compilation-error-regexp-alist 'cargo))) > > ``` > > Maybe a more frequent rust user has a more general regex to > recommend. But this one works for me. > > WDYT? Thanks, but could you please also send the examples of Rust messages, because we need to add them to etc/compilation.txt?
bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 6 May 2024 01:30:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 05 21:30:09 2024
Received: from localhost ([127.0.0.1]:34706 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1s3nBA-0001mc-Pt
for submit <at> debbugs.gnu.org; Sun, 05 May 2024 21:30:09 -0400
Received: from lists.gnu.org ([2001:470:142::17]:55624)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <spacibba@HIDDEN>) id 1s3nB7-0001kM-Vf
for submit <at> debbugs.gnu.org; Sun, 05 May 2024 21:30:07 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <spacibba@HIDDEN>) id 1s3nAe-0002fm-Ou
for bug-gnu-emacs@HIDDEN; Sun, 05 May 2024 21:29:36 -0400
Received: from sonic309-15.consmr.mail.bf2.yahoo.com ([74.6.129.125])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <spacibba@HIDDEN>) id 1s3nAZ-00040I-DV
for bug-gnu-emacs@HIDDEN; Sun, 05 May 2024 21:29:36 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048;
t=1714958967; bh=oGJzzqRyKjmZsp0onOcOwk+D5xoF9xw0azKd32Fer0w=;
h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To;
b=EPmAcE7q6PKsUl0pSeqFsy0CAlkP+jGjNZdZv1xvVArNDyUwDN6bHyiwkzoysvBckMRdw+OY3Xor5V48K2ACunWuVvn7cerTi6U7BehjQw1JllSJ54mJSEA802Bm8eikXcRjoeUGsROcWk8dPFLMnl0RAPXT5nHAfn+bPknwiKiXY2A3kuHcXZBBB53LhOoFYfpna0wa5Hb1+/xBGiARCqh1fiAXFVlLXHGGWIOMwUOnlQGUWCB30Y52nkJSa0EGdRq8qgcMw1fWfx+wT4lA4Yd2fgXd/mdsErrgptvM0l4KboCJfZhQXpEMP0ppKhc1MqbZgHW1DZeUGc5QSFt3Xg==
X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048;
t=1714958967; bh=uUpxcxgSLX7aH4CccIpp0dW+w1GnuhCAqH+VfOmle2u=;
h=X-Sonic-MF:From:To:Subject:Date:From:Subject;
b=ianmE7QQGs4Tm+I/kaP0mTTRN/axcqJ5SSZvTTRZ6wQKqY9jAU0Wb6j3L6CRTzI7QoWzvZPFJjRkRO41ZB6f09MWbAw/V4LeJzgbJrFQd/hKetm5unQNUj1gemn7W8zIp5GmRSXjgjDeAJZLCaPX+Ey9zhllQtertszqFzDVDOqqZNmx+CuYtwpcVZIoZIap/5DaHFI3e9lTW6+AP0n7eGc9yvfT5jR5MBx87R+Z37VCkFRMa35B2GegUIXl9OJ2x/ZzD7DfoCI5ixerUa59Ye1bcRL1cGb+3gJRgjUtMS/MZUDeBjYwb5FjEFwhY/ZlAwTf5lhsq5tlKz5S31mSjw==
X-YMail-OSG: 5.kMbgUVM1kZcMdRnPnElX50qK.Jg2FhIut2xIaSv4OZKHunPzDNktXlG8hiAho
AOq9QwpFh7QgZxriNORhuJ46hVsH0IBSiUAIGzVEPNg8Bi4ZcnTjvArcCHLVILjrHS0Hi2kKxsvz
eiOdLzQ5Y2IFu308xTDZBeMJC21pMUraPUzEgsE31lgqp.gkRdP8fRfC6jaBcdEuotLH4FILOW.W
I5tnlx5v_fqnRFkcMtuBpxXBQqSqWSysHidAgooVrkNY4H0lgqTZ9Py1jVHBkBm3HFyPl_DRiPFa
8ECWEx7o3RbHbjEhQClnWoc0tuxwuuS_g5b9SKmXw9CfnMZv.IcYQ42ic5VZQ6rN7MOSnmFVs1.Z
_LdhdJUrh9gNp7zOJMfxkacfp8lSyQ2b_nmROdPqVLrM4Do0mh_1Ym_HLZX6LY25lEUEyprLatIp
lT2SJGoIB7KezgppR8ETlvjL5nynQtbH1xP758tcWwc6_Zwc_G2kxsa4XZ_p9qApuIL.R_DZ.8JW
6v7BCvZ1UJrw0ySPGLg2pLo6SHaB.EzFHSBHBiOZjSeaueEGiLOZcPIWBHjdHvn0ilUXNRQuQAWy
ZKwDCTuc.L9c5VQQJ_3o0zj5PLPDPDJ4G25agAm4Md9ZXxc6qKbYrcMr0wQbYv4F4QXdaiPvtkgm
eRlsLuh9K1129BGbT85j.k8N2BLfJQ.IXdPYjUrwylUhN38SQRKTFp4BiR8mar1YMQNhdDCZlV4u
Hxh8kYoFxpVcUZnnczfIE.woaP26h3OM.P4PoN_OXQwRpefdU1xkmglePegVyccZOnkJwEeCq9Sk
hj9.2Jjfg3nxGaIqyWlAWUHCB1BKzKZRElTZ6qQGo3RXtxICCTGLLnA5xn8x3DfC6bnPgvMmu0QZ
19149uuczgwJxu1l8kNc6lVHxN7odsmhckw004i2QUm.yPp2PRk7edS8KKXjYj1hgF1fheUsOCwu
NtACe2hFfjCEh9x5Je.o..uUoM6zjX.er3UR1uSRQjRbVWCu3YRaXY8Fe.cEyMoSnJblN1SrI75U
dRW6VIYXtg7ciSR7NZ8O59Rbanwo_92JnsZhzJK2ViMAnimk2.kmKjV5vb_2iuCSym2dwj9ZdpZU
dK7WaKKptfdLfmfpWVUn8aprmzGqrO6odiL1jrM.S3otaLEL3SM68ki50PdYxX5T3t9MoolC15dN
twujaeSUL_Vbj6BOyogdocI2VS2Vq7kDmxEl4dJsogmP1g4vcGFmYbRVNOdJz.L4ed8ypcMDymN.
JafKtofhqB5cFgm6xa.ptbqoOXjfcxdSlXJxDmvC8wT4MSR493x3929Wc87U68nTkSIXEphUFz0k
AON.Ue8cVqQrt56Dx2Xv00jn1OOns.fGO_MtfWtPG.4rnb976Rt248zO1qBzq1eAKqLi489Xp4r6
1vCxrhdhIqzbusPDvtarfoBqNXoVOOPVx53ZLDnaFFuunI1H6ZF5mNBC.Y9dimODKiRhwGC8Zbk7
_Ih4WHT_eEk_VcN8n4G_exChgfrvxdsoyqNmRzqjT.Mxurp0w4oY5u2antEm9gd5bN7WGnTL4AmO
CIiMiF0aX0ORBU2yRXYUjAKCaTie2tbXW8MXhfE3Gw0FpAAHMXRkxoToNycDKYHBbGO_1uSGlkNK
dmc.hjPgBhEDUp_ZhU2M4ofaiMqfKJiK5WvGeTePLIA_clZvNlf8_MzpfGVVpX50mmckAG_AdlnV
nrCEdM4k2bF4oDLvtD1qfqlNNyojGnATPr2zQG16B7Vjv.ECTrMf_cYb0FsU.BTcPgWs4r9fm3Yo
GG9ZrtEFahMW2pDJ_Zry7VW1ik4B0jSHf21bQ46iLBQpwwMNwTJzIovV7O7uONfufumNiK1VAgx4
9dq3ZGKZpEmz4g5Y8yf9arCiG0ep2T2xx_mPT5uW3WNbaD67xrEabNGkyFO5eeendSITCI3GAK04
KNHCluXF_m2zPaZqoNNHKQlixMZTw63dpI1ZFyaUhEgb9hZ9Iw71wQHst8gs0IdZbkhgjX4VjmlT
_z3.GXyjgRIkeYYrDMemc6D7ILmuS9_awUF6qNXJHaEIC_CDAg2QVjqCWAV7Wfqm8llYp53hvwY4
RQQtE.CilJp1YhrBjLNROMqIqs_I6wl.Bpp1vNMi4zRlLUQldOebcQkh8.UTTpkkCUZzwb2yhr6D
9EZz8gz_2yw3YyNnvL3gi5o05eSfHMxbSABIeeXndp0fKbCpCoTO9MrB_7jbigf314NQ-
X-Sonic-MF: <spacibba@HIDDEN>
X-Sonic-ID: 2f94bd88-9a2e-481c-86a0-a084397e7c55
Received: from sonic.gate.mail.ne1.yahoo.com by
sonic309.consmr.mail.bf2.yahoo.com with HTTP; Mon, 6 May 2024 01:29:27 +0000
Received: by hermes--production-ir2-7b99fc9bb6-b6zps (Yahoo Inc. Hermes SMTP
Server) with ESMTPA ID c8b9f67d9d4a7aeba07624bbc6136576;
Mon, 06 May 2024 01:29:25 +0000 (UTC)
From: Ergus <spacibba@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 30.0.50; Add Rust compilation regex
X-Debbugs-Cc:
Date: Mon, 06 May 2024 03:28:43 +0200
Message-ID: <87y18nsp84.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
References: <87y18nsp84.fsf.ref@HIDDEN>
X-Mailer: WebService/1.1.22256
mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol
Content-Length: 817
Received-SPF: pass client-ip=74.6.129.125; envelope-from=spacibba@HIDDEN;
helo=sonic309-15.consmr.mail.bf2.yahoo.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.7 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)
Hi:
Recently working with rust I have noticed that emacs does not recognizes
the rust/cargo error patterns.
Considering that emacs has now the rust-ts-mode, it may worth adding
the rust/cargo error patterns to compile when using that mode
In my system so far I have this:
```
(with-eval-after-load 'rust-ts-mode
(with-eval-after-load 'compile
(add-to-list
'compilation-error-regexp-alist-alist
`(cargo
"\\(?:\\(?4:error\\)\\|\\(?5:warning\\)\\):[^\0]+?--> \\(?1:[^:]+\\):\\(?2:[[:digit:]]+\\):\\(?3:[[:digit:]]+\\)"
1 2 3 (5)
nil
(5 compilation-warning-face)
(4 compilation-error-face)))
(add-to-list 'compilation-error-regexp-alist 'cargo)))
```
Maybe a more frequent rust user has a more general regex to
recommend. But this one works for me.
WDYT?
Ergus <spacibba@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#70794; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.